Commit license

[Guillaume Poussel]

Hi everyone,
All of my past and future contributions to LibreOffice may be licensed
under MPL/LGPLv3+ dual license (or any other license).

Regards,
Guillaume Poussel
Le 3 mai 2012 13:19, "Michael Meeks"  a écrit :

> Hi there,
>
> On Sun, 2011-02-27 at 23:03 +0100, Guillaume Poussel wrote:
> > Please find attached 2 patches in base/ which clean useless comments up.
> ...
> > (still under LGPLv3+/MPL)
>
>I'm just working through the MPL/LGPLv3+ re-licensing audit at
> the moment (so we can include code from Apache OpenOffice :-) What would
> really help reduce the work would be if we could have a blanket
> statement from you for all past/future contributions we can link into:
>
>http://wiki.documentfoundation.org/Development/Developers
>
>Something like:
>
>"All of my past & future contributions to LibreOffice may be
> licensed under the MPL/LGPLv3+ dual license"
>
>sent to the libreoffice@lists.freedesktop.org would be wonderful
> (no
> subscription required).
>
>That'd save me having to dig through each of your commits, mailing
> list
> posts and so on :-) Any chance of that ?
>
>Thanks !
>
>Michael.
>
> --
> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove useless comments.

[Guillaume Poussel]

Attached patches for components and filters.

Regards,
Guillaume.


0001-Remove-various-useless-comments-in-filters.patch
Description: Binary data


0001-Remove-various-useless-comments-in-components.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Code cleanliness

[Guillaume Poussel]

Better with files attached :)

2011/2/27 Guillaume Poussel :
> Hi,
>
> Please find attached 2 patches in base/ which clean useless comments up.
>
> Regards,
> Guillaume
>
> (still under LGPLv3+/MPL)
>


0001-Remove-date-comments-in-base.patch
Description: Binary data


0002-Remove-bogus-comments.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Code cleanliness

[Guillaume Poussel]

Hi,

Please find attached 2 patches in base/ which clean useless comments up.

Regards,
Guillaume

(still under LGPLv3+/MPL)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove bogus comments in components and impress

[Guillaume Poussel]

Hi,

Find attached new patches that remove bogus comments (still under
LGPLv3+/MPL) in components and impress.

Comments with kind of 'revision control' (with dates) remain in writer
and binfilter. I will work on writer and write it on the wiki.


Regards,
Guillaume Poussel


0001-Remove-bogus-and-dates-comments-components.patch
Description: Binary data


0001-Remove-bogus-and-dates-comments-impress.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Building fail on Ubuntu

[Guillaume Poussel]

Hello,

I am unable to build i18npool on Ubuntu 10.10 for an unknown reason.
You could see build log here: http://libreoffice.pastebin.com/raw.php?i=qfADMV51

I have download again the full source and i got the same error. Could
someone please help me?

Thanks, regards.
Guillaume Poussel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Again cppcheck cleanliness

[Guillaume Poussel]

Hi everybody,

A new patch which correct cppcheck warnings in base/.

To be continued with other modules.

Regards,
Guillaume


0002-Clean-resourceleak-warning-in-cppcheck.patch
Description: Binary data


0001-cppcheck-cleanliness.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] CppCheck cleanliness in bootstrap

[Guillaume Poussel]

Hi everybody,

I've started to look at the huge
listof "defects" that Cpp Check
show. I have corrected few things in bootstrap.
The rest should be false positive or errors in dmake/ folder.

It would be great if someone could have a look and keep me posted about
this.

Regards!


0001-Removing-few-cppchecks-warnings.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Easy Hacks] Creating OUString

[Guillaume Poussel]

Hi all,

I have had a look on the "Use RTL_CONSTASCII_USTRINGPARAM macro" 
 
task.
Lot of module have his own macro to transform an ASCII string to an 
OUString : CREATE_OUSTRING, OUSTR, UNISTRING, C2U...


It should be better to use a global macro, isn't it ?

Thanks for your answer :)

Regards,
Guillaume.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] Remove bogus macro...

[Guillaume Poussel]

Hi,

You will find attached 2 patches to complete the easy task "Remove bogus 
macro..".


When you will be OK, i'll be able to edit the wiki.

Thanks again for your friendly welcome on this maling-list !

Guillaume.

>From cd375808b626d022d6d650e541382d6ba7854e9e Mon Sep 17 00:00:00 2001
From: Guillaume Poussel 
Date: Wed, 22 Dec 2010 18:37:18 +0100
Subject: [PATCH] Remove __READONLY_DATA

---
 tools/inc/tools/solar.h |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
index 8b72805..cc78aa5 100644
--- a/tools/inc/tools/solar.h
+++ b/tools/inc/tools/solar.h
@@ -87,8 +87,6 @@ typedef sal_uInt32			UINT32;	/* typedef unsigned intUINT32; previously "unsi
 
 #define DELETEZ( p )	( delete p,p = 0 )
 
-#define __READONLY_DATA 		const
-
 #ifdef WNT
 #if defined (_MSC_VER) && ( _MSC_VER < 1200 )
 #define __LOADONCALLAPI _cdecl
-- 
1.7.1

>From d6119fae6b3a12cecf8c78cf11e27b2f3d6c7b45 Mon Sep 17 00:00:00 2001
From: Guillaume Poussel 
Date: Wed, 22 Dec 2010 18:38:32 +0100
Subject: [PATCH] Removed __READONLY_DATA (replaced by const)

---
 .../objectpositioning/anchoredobjectposition.cxx   |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
index 61028b5..9368e7f 100644
--- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
@@ -1062,11 +1062,11 @@ bool SwAnchoredObjectPosition::_Minor( sal_Int16 _eRelOrient1,
 
 // draw aside order for left horizontal position
 //! one array entry for each value in text::RelOrientation
-static USHORT __READONLY_DATA aLeft[ 10 ] =
+static USHORT const aLeft[ 10 ] =
 { 5, 6, 0, 1, 8, 4, 7, 2, 3, 9 };
 // draw aside order for right horizontal position
 //! one array entry for each value in text::RelOrientation
-static USHORT __READONLY_DATA aRight[ 10 ] =
+static USHORT const aRight[ 10 ] =
 { 5, 6, 0, 8, 1, 7, 4, 2, 3, 9 };
 
 // decide depending on given order, which frame has to draw aside another frame
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Guillaume Poussel]

Thank you for your welcome !

I was not sure about /git diff/ or /git format-patch/. Next time it 
would be better :)


I'm studying in Sophia-Antipolis, near to Nice, more precisely in 
Polytech'Nice-Sophia <http://www.polytechnice.fr/>.
I'm not sure to be able to convince my teachers, but i will talk about 
it after the Xmas holidays.


Now, i will take other "easy tasks" and try to send my code.

Guillaume.

Le 22/12/2010 14:49, Cedric Bosdonnat a écrit :

Bonjour Guillaume,

On Wed, 2010-12-22 at 11:47 +0100, Guillaume Poussel wrote:

I use LibreOffice almost every day and I'm interested in Open Source
softwares, so I would like to contribute.

Then be welcomed among LibreOffice develers!


I have grabbed the code and compile it. Then, i had a look on the wiki
and found an easy task : "Remove bogus macro that expand to empty
string".
I've attached a text file which contains my diff on 4 files I have
edited.

Many thanks for it, I've just pushed it. For a next time you may want to
create the patch using git format-patch.


Could someone please have a look and tell me if i'm on the right way ?

It's OK for me.


P.S. : I'm a french student (in computer science :) ), so I'm sorry if
my english is not perfect :)

Hey! nice to see students from french schools coming here... Where are
you studying? Would it be possible for you to convince your teachers to
switch some school dev project by a LibreOffice one?

Regards,


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] [Easy task] Remove bogus macro that expand to empty string

[Guillaume Poussel]

Hi everybody,


I use LibreOffice almost every day and I'm interested in Open Source 
softwares, so I would like to contribute.



I have grabbed the code and compile it. Then, i had a look on the wiki 
and found an easy task : "Remove bogus macro that expand to empty 
string" 
.

I've attached a text file which contains my diff on 4 files I have edited.

Could someone please have a look and tell me if i'm on the right way ?

Cheers,
Guillaume.

P.S. : I'm a french student (in computer science :) ), so I'm sorry if 
my english is not perfect :)


diff --git binfilter/inc/bf_sfx2/docfac.hxx binfilter/inc/bf_sfx2/docfac.hxx
index 085d11c..646b87d 100644
--- binfilter/inc/bf_sfx2/docfac.hxx
+++ binfilter/inc/bf_sfx2/docfac.hxx
@@ -635,7 +635,7 @@ extern "C"
 Factory().RegisterInitFactory( &InitFactory);  
  \
 }  
  \
   \
-SfxObjectShell*__EXPORT Class::CreateObject(SfxObjectCreateMode eMode) 
  \
+SfxObjectShell* Class::CreateObject(SfxObjectCreateMode eMode)   \
 {  
  \
 SfxCreateExtern_TYPE fCreate = (SfxCreateExtern_TYPE)  
\
 GetFunc##LibName( "CreateObj" #Class "Dll");\
diff --git svtools/source/contnr/svlbox.cxx svtools/source/contnr/svlbox.cxx
index 6eb2860..989a5b7 100644
--- svtools/source/contnr/svlbox.cxx
+++ svtools/source/contnr/svlbox.cxx
@@ -1696,7 +1696,7 @@ sal_Int8 SvLBox::AcceptDrop( const AcceptDropEvent& rEvt )
 }
 else
 {
-DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0 
(__EXPORT?)" );
+DBG_ASSERT( pDDSource, "SvLBox::QueryDrop(): SourceBox == 0" );
 if( !( pEntry && pDDSource->GetModel() == this->GetModel()
 && DND_ACTION_MOVE == rEvt.mnAction
 && ( pEntry->nEntryFlags & SV_ENTRYFLAG_DISABLE_DROP ) ))
diff --git tools/inc/tools/solar.h tools/inc/tools/solar.h
index 0ecaf58..8b72805 100644
--- tools/inc/tools/solar.h
+++ tools/inc/tools/solar.h
@@ -88,7 +88,6 @@ typedef sal_uInt32UINT32; /* typedef 
unsigned intUINT32; previously "unsi
 #define DELETEZ( p )   ( delete p,p = 0 )
 
 #define __READONLY_DATAconst
-#define __EXPORT
 
 #ifdef WNT
 #if defined (_MSC_VER) && ( _MSC_VER < 1200 )
diff --git sfx2/inc/sfx2/childwin.hxx sfx2/inc/sfx2/childwin.hxx
index f3e058a..5de9fba 100644
--- sfx2/inc/sfx2/childwin.hxx
+++ sfx2/inc/sfx2/childwin.hxx
@@ -313,7 +313,7 @@ public:
 SfxChildWindow *pWin = new Class(pParent, nId, pBindings, 
pInfo);\
 return pWin; \
 } \
-sal_uInt16 __EXPORT Class::GetChildWindowId () \
+sal_uInt16 Class::GetChildWindowId () \
 { return MyID; } \
 void   Class::RegisterChildWindow (sal_Bool bVis, SfxModule *pMod, 
sal_uInt16 nFlags)   \
 {  \
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice