Minutes from the UX/design meeting 2023-Jul-25
Present: Sahil, Rafael, Hossein, Heiko Comments: Stuart, Miguel, Felix, Eyal Tickets/Topics * LibreOffice shouldn't try to import the comment style from DOCX files + https://bugs.documentfoundation.org/show_bug.cgi?id=161657 + define the attributes line spacing = single, indents = all 0, on the Comments PS (Heiko) + alignment = left might be needed since justified looks odd but works only for LTR + spacing, font color, highlight (Rafael) => do it * Duplicate Options Menu (“Field”) in Tabbed Interface + https://bugs.documentfoundation.org/show_bug.cgi?id=161557 + no issue with the duplicated 'Field' button (Stuart, Rafael) + remove Fields from References (Sahil) + some users might be familiar with the current design (Hossein) + no urgent need to remove as long the space is sufficient (Hossein) + it is also available in the context menu at References (Rafael) => remove from the context menu but keep both at the tabs * Suppress editing of comments from other authors + https://bugs.documentfoundation.org/show_bug.cgi?id=161978 + adding a remark with the last editor (Miguel) + comments are nothing special (Felix) + completely block editing; with means to override (Eyal) + user can change the name anyway; WF in the narrow sense (Rafael) + having too many information in the classic comments clutter the UI; perhaps have an editing history in the upcoming sidebar (Sahil) + annotation require storage properties; sounds like feature-creep (Hossein) + maybe use track changes; currently not tracked (Rafael) => TC sounds as a good solution * Add option to set default Wrap for inserted pictures + https://bugs.documentfoundation.org/show_bug.cgi?id=157684 + idea is to introduce "Dynamic" image position depending on left|center|right alignment of paragraph + current default is Optimal placing the image left/right depending on the amount of text + previous discussion in bug 87720 c43/44 + using styles allows to change the default per document/template (Hossein) + if we decide to provide options for many/all options rather than forcing people to use templates, or vice versa, we should be consistent (Rafael) + we should go with a solution that users are familiar with / know from other office suites - and MSO has it under Options > Advanced > Cur, copy, and paste (Hossein) => introduce an option OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jul-25
Present: Sahil, Rafael, Hossein, Heiko Comments: Stuart, Miguel, Felix, Eyal Tickets/Topics * LibreOffice shouldn't try to import the comment style from DOCX files + https://bugs.documentfoundation.org/show_bug.cgi?id=161657 + define the attributes line spacing = single, indents = all 0, on the Comments PS (Heiko) + alignment = left might be needed since justified looks odd but works only for LTR + spacing, font color, highlight (Rafael) => do it * Duplicate Options Menu (“Field”) in Tabbed Interface + https://bugs.documentfoundation.org/show_bug.cgi?id=161557 + no issue with the duplicated 'Field' button (Stuart, Rafael) + remove Fields from References (Sahil) + some users might be familiar with the current design (Hossein) + no urgent need to remove as long the space is sufficient (Hossein) + it is also available in the context menu at References (Rafael) => remove from the context menu but keep both at the tabs * Suppress editing of comments from other authors + https://bugs.documentfoundation.org/show_bug.cgi?id=161978 + adding a remark with the last editor (Miguel) + comments are nothing special (Felix) + completely block editing; with means to override (Eyal) + user can change the name anyway; WF in the narrow sense (Rafael) + having too many information in the classic comments clutter the UI; perhaps have an editing history in the upcoming sidebar (Sahil) + annotation require storage properties; sounds like feature-creep (Hossein) + maybe use track changes; currently not tracked (Rafael) => TC sounds as a good solution * Add option to set default Wrap for inserted pictures + https://bugs.documentfoundation.org/show_bug.cgi?id=157684 + idea is to introduce "Dynamic" image position depending on left|center|right alignment of paragraph + current default is Optimal placing the image left/right depending on the amount of text + previous discussion in bug 87720 c43/44 + using styles allows to change the default per document/template (Hossein) + if we decide to provide options for many/all options rather than forcing people to use templates, or vice versa, we should be consistent (Rafael) + we should go with a solution that users are familiar with / know from other office suites - and MSO has it under Options > Advanced > Cur, copy, and paste (Hossein) => introduce an option OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sc/source
sc/source/core/data/patattr.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 98706cbfa6307de2f5a11ff0e5edb4120ad57bb8
Author: Heiko Tietze
AuthorDate: Mon Jul 22 14:38:20 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue Jul 23 09:51:55 2024 +0200
Related tdf#159541 - Fix font color issue in Calc
Follow-up to I954c9e3f8502a5243c664ed0bf066fb4c4cb4ccc
Change-Id: Ib0a5b38739e7b5f73d1e5fbb57687b89b3e86233
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170851
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index 0bf5cfc6ca41..d738507b2ffc 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -792,6 +792,13 @@ void ScPatternAttr::fillColor(model::ComplexColor&
rComplexColor, const SfxItemS
{
// pTextConfigColor can be used to avoid repeated lookup of the
configured color
aSysTextColor = *pTextConfigColor;
+if (SC_MOD()->GetColorConfig().GetColorValue(svtools::FONTCOLOR,
false).nColor == COL_AUTO)
+{
+if ( aBackColor.IsDark() && aSysTextColor.IsDark() )
+aSysTextColor = COL_WHITE;
+else
+aSysTextColor = COL_BLACK;
+}
}
else
{
core.git: editeng/source sc/source sw/source
editeng/source/editeng/impedit3.cxx |8
sc/source/core/data/patattr.cxx | 17 +
sw/source/core/txtnode/fntcache.cxx | 14 +-
3 files changed, 14 insertions(+), 25 deletions(-)
New commits:
commit 8534ad7b7b9aae2520d731cf748ff0aadfe2f0ed
Author: Heiko Tietze
AuthorDate: Thu Jul 4 14:31:09 2024 +0200
Commit: Heiko Tietze
CommitDate: Mon Jul 22 13:01:43 2024 +0200
Resolves tdf#159541 - Fix font color must not change depending on background
Change-Id: I954c9e3f8502a5243c664ed0bf066fb4c4cb4ccc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169991
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index 66ecfb814774..944f3a1c14a9 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -4958,13 +4958,13 @@ Color ImpEditEngine::GetAutoColor() const
}
else
{
-aColor = GetColorConfig().GetColorValue(svtools::FONTCOLOR).nColor;
+aColor = GetColorConfig().GetColorValue(svtools::FONTCOLOR,
false).nColor;
-if ( GetBackgroundColor() != COL_AUTO )
+if ( aColor == COL_AUTO )
{
-if ( GetBackgroundColor().IsDark() && aColor.IsDark() )
+if ( GetBackgroundColor().IsDark() )
aColor = COL_WHITE;
-else if ( GetBackgroundColor().IsBright() && aColor.IsBright() )
+else
aColor = COL_BLACK;
}
}
diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index da278bd53c30..0bf5cfc6ca41 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -798,22 +798,7 @@ void ScPatternAttr::fillColor(model::ComplexColor&
rComplexColor, const SfxItemS
aSysTextColor =
SC_MOD()->GetColorConfig().GetColorValue(svtools::FONTCOLOR).nColor;
}
-// select the resulting color
-if ( aBackColor.IsDark() && aSysTextColor.IsDark() )
-{
-// use white instead of dark on dark
-aColor = COL_WHITE;
-}
-else if ( aBackColor.IsBright() && aSysTextColor.IsBright() )
-{
-// use black instead of bright on bright
-aColor = COL_BLACK;
-}
-else
-{
-// use aSysTextColor (black for ScAutoFontColorMode::Print, from
style settings otherwise)
-aColor = aSysTextColor;
-}
+aColor = aSysTextColor;
}
aComplexColor.setFinalColor(aColor);
rComplexColor = aComplexColor;
diff --git a/sw/source/core/txtnode/fntcache.cxx
b/sw/source/core/txtnode/fntcache.cxx
index 52a9e71dff1d..d52484432791 100644
--- a/sw/source/core/txtnode/fntcache.cxx
+++ b/sw/source/core/txtnode/fntcache.cxx
@@ -58,6 +58,7 @@
#include
#include
#include "justify.hxx"
+#include
using namespace ::com::sun::star;
@@ -2293,11 +2294,14 @@ bool SwDrawTextInfo::ApplyAutoColor( vcl::Font* pFont )
}
// change painting color depending of dark/bright background
-Color aTmpColor( nNewColor );
-if ( pCol->IsDark() && aTmpColor.IsDark() )
-nNewColor = COL_WHITE;
-else if ( pCol->IsBright() && aTmpColor.IsBright() )
-nNewColor = COL_BLACK;
+if (!pVSh->GetWin() || // ie. IsPrinting, see SwViewShell::GetWin()
+svtools::ColorConfig().GetColorValue(svtools::FONTCOLOR,
false).nColor == COL_AUTO) // GetFontColor() uses the smart flag
+{
+if ( pCol->IsDark() )
+nNewColor = COL_WHITE;
+else
+nNewColor = COL_BLACK;
+}
}
}
Minutes from the UX/design meeting 2023-Jul-17
Present: Eyal, Sahil, Rafael, John, Heiko
Comments: Regina, Tuomas, Stuart, Mike
Tickets/Topics
* Overhaul terminology on the "Text along Path" dialog
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161956
+ title without ellipsis, command should have ellipsis though (Heiko)
+ "Style" => "Type" (Regina)
+ "Character Orientation and Skew" (Tuomas)
+ "Orientation", "Positioning" ("Type" is too unspecific) (Eyal)
+ "Text Layouts" (Sahil)
=> Orientation
+ tooltip "Baseline Off" => "Off" (Regina)
+ disable controls for "Off" (Eyal)
=> move out of the toolbar and make it a checkbox "[x] Enable"
+ "Rotate" => "Characters Perpendicular to Path" (Tuomas)
+ "Follow Baseline" (Rafael)
+ "Follow Path" (if frame title becomes "Orientation") (Eyal)
=> ""Follow Path"
+ "Upright" => "Characters Upright" (Tuomas)
+ "Upright along path" (Rafael)
+ "Ignore Path" (Eyal)
+ disagreement for this
+ Interpretation may depend on user's frame of reference:
is it "upright relative to the path", or
"upright relative to the page"? May be confusing (Eyal)
=> no decision
+ "Orientation" => "Flip" (Tuomas)
+ disagree (Regina)
+ "Invert Orientation" (Tuomas)
+ "Reverse" (Eyal)
+ move into the to-be-renamed "Orientation" section, eg,
instead of the current "Baseline Off" item (Eyal)
=> "Inverse" (Orientation) and move to the other frame
+ Shadow Offset: tooltip "Distance X/Y" are unclear (Eyal)
=> comment
* Setting to add XY shift to pasted drawing etc. objects
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161950
+ https://bugs.documentfoundation.org/show_bug.cgi?id=97993
+ see also https://bugs.documentfoundation.org/show_bug.cgi?id=100028
+ sometimes it has an advantage to place the copied object at the
exact position, for example when the user deletes the source or
if the target is some other document (Heiko, Eyal)
+ prefer a slight offset to give some feedback of the paste
option (John, Rafael)
+ moving an object is simple (Eyal) but shift+arrow for large movements
could place the object at the exact position again (Heiko)
+ cut objects likely not wanted to be offset (Heiko)
+ objects at the edge of the universe? would be placed at the
max position (Rafael)
+ introduce an option to toggle the offset on/off (Eyal)
=> do it
* When toggling an item in toolbar context menu > Visible Buttons
- keep the menu open
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161949
+ odd with all other menu selection actions (Stuart)
+ standard behavior (Heiko)
+ tools > customize offers a static dialog for this (Stuart)
=> WF
* Viewing: Feature request. Is it possible to add a horizontal
scroll search
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161862
+ only reasonable use case is probably to focus some column/cell
that is out of view so one can see the content from Z1:100 while
at the same time A1:100 is taken into the tooltip on scroll (Heiko)
+ freeze is a sufficient function for this (Rafael)
+ or hide columns (Heiko)
+ showing content from the sheet in a tooltip would be a
hack (Rafael, Heiko, Eyal)
+ wouldn't work on all OS/DE anyway (Rafael)
=> no compelling use case, hackish implementation => WF
* Implement Cyrillic Mongolian numbering for headings
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161744
+ add Mongolian for now and fix the lengthy list later (and
create an extra ticket for that) (Eyal)
+ make the alphanumeric letters depending on the language of
the character style per list style (Heiko)
+ have a "More..." option and show alternatives in an extra
dialog (Mike)
=> comment
OpenPGP_signature.asc
Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jul-17
Present: Eyal, Sahil, Rafael, John, Heiko
Comments: Regina, Tuomas, Stuart, Mike
Tickets/Topics
* Overhaul terminology on the "Text along Path" dialog
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161956
+ title without ellipsis, command should have ellipsis though (Heiko)
+ "Style" => "Type" (Regina)
+ "Character Orientation and Skew" (Tuomas)
+ "Orientation", "Positioning" ("Type" is too unspecific) (Eyal)
+ "Text Layouts" (Sahil)
=> Orientation
+ tooltip "Baseline Off" => "Off" (Regina)
+ disable controls for "Off" (Eyal)
=> move out of the toolbar and make it a checkbox "[x] Enable"
+ "Rotate" => "Characters Perpendicular to Path" (Tuomas)
+ "Follow Baseline" (Rafael)
+ "Follow Path" (if frame title becomes "Orientation") (Eyal)
=> ""Follow Path"
+ "Upright" => "Characters Upright" (Tuomas)
+ "Upright along path" (Rafael)
+ "Ignore Path" (Eyal)
+ disagreement for this
+ Interpretation may depend on user's frame of reference:
is it "upright relative to the path", or
"upright relative to the page"? May be confusing (Eyal)
=> no decision
+ "Orientation" => "Flip" (Tuomas)
+ disagree (Regina)
+ "Invert Orientation" (Tuomas)
+ "Reverse" (Eyal)
+ move into the to-be-renamed "Orientation" section, eg,
instead of the current "Baseline Off" item (Eyal)
=> "Inverse" (Orientation) and move to the other frame
+ Shadow Offset: tooltip "Distance X/Y" are unclear (Eyal)
=> comment
* Setting to add XY shift to pasted drawing etc. objects
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161950
+ https://bugs.documentfoundation.org/show_bug.cgi?id=97993
+ see also https://bugs.documentfoundation.org/show_bug.cgi?id=100028
+ sometimes it has an advantage to place the copied object at the
exact position, for example when the user deletes the source or
if the target is some other document (Heiko, Eyal)
+ prefer a slight offset to give some feedback of the paste
option (John, Rafael)
+ moving an object is simple (Eyal) but shift+arrow for large movements
could place the object at the exact position again (Heiko)
+ cut objects likely not wanted to be offset (Heiko)
+ objects at the edge of the universe? would be placed at the
max position (Rafael)
+ introduce an option to toggle the offset on/off (Eyal)
=> do it
* When toggling an item in toolbar context menu > Visible Buttons
- keep the menu open
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161949
+ odd with all other menu selection actions (Stuart)
+ standard behavior (Heiko)
+ tools > customize offers a static dialog for this (Stuart)
=> WF
* Viewing: Feature request. Is it possible to add a horizontal
scroll search
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161862
+ only reasonable use case is probably to focus some column/cell
that is out of view so one can see the content from Z1:100 while
at the same time A1:100 is taken into the tooltip on scroll (Heiko)
+ freeze is a sufficient function for this (Rafael)
+ or hide columns (Heiko)
+ showing content from the sheet in a tooltip would be a
hack (Rafael, Heiko, Eyal)
+ wouldn't work on all OS/DE anyway (Rafael)
=> no compelling use case, hackish implementation => WF
* Implement Cyrillic Mongolian numbering for headings
+ https://bugs.documentfoundation.org/show_bug.cgi?id=161744
+ add Mongolian for now and fix the lengthy list later (and
create an extra ticket for that) (Eyal)
+ make the alphanumeric letters depending on the language of
the character style per list style (Heiko)
+ have a "More..." option and show alternatives in an extra
dialog (Mike)
=> comment
OpenPGP_signature.asc
Description: OpenPGP digital signature
core.git: include/svx sc/qa svx/source
include/svx/strings.hrc| 10
sc/qa/uitest/calc_tests/cellBackgroundColorSelector.py | 16 +++---
svx/source/tbxctrls/PaletteManager.cxx | 19 +
3 files changed, 36 insertions(+), 9 deletions(-)
New commits:
commit 5e45351c52584fb116d2cc54da969734e5effab9
Author: Heiko Tietze
AuthorDate: Fri Jul 12 09:03:38 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue Jul 16 09:53:46 2024 +0200
Resolves tdf#105000 - Make shipped palette names translatable
Change-Id: Ifd062cf25c6e930da56571e01c21bd9d2ddf6ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170394
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/include/svx/strings.hrc b/include/svx/strings.hrc
index c9c1c88b..8b3a23870924 100644
--- a/include/svx/strings.hrc
+++ b/include/svx/strings.hrc
@@ -559,6 +559,14 @@
#define RID_SVXSTR_GRAFMODE_MONO
NC_("RID_SVXSTR_GRAFMODE_MONO", "Black/White")
#define RID_SVXSTR_GRAFMODE_WATERMARK
NC_("RID_SVXSTR_GRAFMODE_WATERMARK", "Watermark")
#define RID_SVXSTR_COLORBAR
NC_("RID_SVXSTR_COLORBAR", "Left click to apply as background color, right
click to set line color")
+// SOC color palettes
+#define RID_SVXSTR_COLOR_PALETTE_STANDARD
NC_("RID_SVXSTR_COLOR_PALETTE_STANDARD", "Standard")
+#define RID_SVXSTR_COLOR_PALETTE_TONAL
NC_("RID_SVXSTR_COLOR_PALETTE_TONAL", "Tonal")
+#define RID_SVXSTR_COLOR_PALETTE_HTML
NC_("RID_SVXSTR_COLOR_PALETTE_HTML", "HTML")
+#define RID_SVXSTR_COLOR_PALETTE_CHARTPALETTES
NC_("RID_SVXSTR_COLOR_PALETTE_CHARTPALETTES", "Chart Palettes")
+#define RID_SVXSTR_COLOR_PALETTE_COMPATIBILITY
NC_("RID_SVXSTR_COLOR_PALETTE_COMPATIBILITY", "Compatibility")
+#define RID_SVXSTR_COLOR_PALETTE_MATERIAL
NC_("RID_SVXSTR_COLOR_PALETTE_MATERIAL", "Material")
+#define RID_SVXSTR_COLOR_PALETTE_FREECOLOURHLC
NC_("RID_SVXSTR_COLOR_PALETTE_FREECOLOURHLC", "Freecolour HLC")
// Default colors
#define RID_SVXSTR_COLOR_DEFAULT_FONT
NC_("RID_SVXSTR_COLOR_DEFAULT_FONTCOLOR", "Dark Red 2")
#define RID_SVXSTR_COLOR_DEFAULT_FRAMELINE
NC_("RID_SVXSTR_COLOR_DEFAULT_FRAMELINE", "Blue")
@@ -1116,7 +1124,7 @@
// This is duplicated in GenericCommands.xcu in officecfg.
#define RID_SVXSTR_CHARFONTNAME
NC_("RID_SVXSTR_CHARFONTNAME", "Font Name")
#define RID_SVXSTR_CHARFONTNAME_NOTAVAILABLE
NC_("RID_SVXSTR_CHARFONTNAME_NOTAVAILABLE", "Font Name. The current font is not
available and will be substituted.")
-#define RID_SVXSTR_CUSTOM_PAL
NC_("RID_SVXSTR_CUSTOM_PAL", "custom")
+#define RID_SVXSTR_CUSTOM_PAL
NC_("RID_SVXSTR_CUSTOM_PAL", "Custom")
#define RID_SVXSTR_DOC_COLORS
NC_("RID_SVXSTR_DOC_COLORS", "Document colors")
#define RID_SVXSTR_THEME_COLORS
NC_("RID_SVXSTR_THEME_COLORS", "Theme colors")
#define RID_SVXSTR_DOC_COLOR_PREFIX
NC_("RID_SVXSTR_DOC_COLOR_PREFIX", "Document Color")
diff --git a/sc/qa/uitest/calc_tests/cellBackgroundColorSelector.py
b/sc/qa/uitest/calc_tests/cellBackgroundColorSelector.py
index dcd7c75c0f2a..1839545c7e88 100644
--- a/sc/qa/uitest/calc_tests/cellBackgroundColorSelector.py
+++ b/sc/qa/uitest/calc_tests/cellBackgroundColorSelector.py
@@ -36,7 +36,7 @@ class CalcCellBackgroundColorSelector(UITestCase):
color_selector = xColorpage.getChild("colorset")
# For chart-palettes colors
-select_by_text(xpaletteselector, "chart-palettes")
+select_by_text(xpaletteselector, "Chart Palettes")
# Select Color with id 2
color_selector.executeAction("CHOOSE",
mkPropertyValues({"POS": "2"}))
self.assertEqual(get_state_as_dict(color_selector)["CurrColorId"], "2")
@@ -54,7 +54,7 @@ class CalcCellBackgroundColorSelector(UITestCase):
self.assertEqual(get_state_as_dict(color_selector)["RGB"],
"(126,0,33)")
# For libreoffice colors
-select_by_text(xpaletteselector, "libreoffice")
+select_by_text(xpaletteselector, "LibreOffice")
# Select Color w
core.git: Branch 'feature/cib_contract49c' - officecfg/registry sc/source
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |7 +++
sc/source/ui/view/cellsh3.cxx| 27 ++-
2 files changed, 33 insertions(+), 1 deletion(-)
New commits:
commit 4d62c692d9106c9c2fc0d3dc9efb1cd57a8a12d3
Author: Heiko Tietze
AuthorDate: Thu Jun 20 15:12:05 2024 +0200
Commit: Thorsten Behrens
CommitDate: Mon Jul 15 11:33:18 2024 +0200
Resolves tdf#161641 - Select data area before select all
Advanced option SelectRangeBeforeAll to restore original behavior
Change-Id: Iab4b4e61dffc1ecf2ffed01a994c9894c84ab74d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169276
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-by: Heiko Tietze
diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index a8830ab1ba19..c5cc5d3f4d85 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -739,6 +739,13 @@
true
+
+
+ Disable to always select all
+ Select range before all
+
+true
+
diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx
index e6c89b6a2b9c..ebe5368d57c7 100644
--- a/sc/source/ui/view/cellsh3.cxx
+++ b/sc/source/ui/view/cellsh3.cxx
@@ -49,6 +49,7 @@
#include
#include
#include
+#include
#include
@@ -658,7 +659,31 @@ void ScCellShell::Execute( SfxRequest& rReq )
case SID_SELECTALL:
{
-pTabViewShell->SelectAll();
+SCTAB nTab = GetViewData().GetTabNo();
+SCCOL nStartCol = GetViewData().GetCurX();
+SCROW nStartRow = GetViewData().GetCurY();
+SCCOL nEndCol = nStartCol;
+SCROW nEndRow = nStartRow;
+bool bCanMark = false;
+
+ScMarkData& rMarkdata = GetViewData().GetMarkData();
+const bool
bSelectFirst(officecfg::Office::Calc::Input::SelectRangeBeforeAll::get());
+
+if (bSelectFirst && !rMarkdata.IsMarked())
+{
+const ScDocument& rDoc = GetViewData().GetDocument();
+rDoc.GetDataArea( nTab, nStartCol, nStartRow, nEndCol,
nEndRow, true, false );
+bCanMark = nStartCol != nEndCol || nStartRow != nEndRow;
+}
+
+if (bCanMark)
+{
+const ScRange aRange(nStartCol, nStartRow, nTab, nEndCol,
nEndRow, nTab);
+pTabViewShell->MarkRange(aRange, false);
+}
+else
+pTabViewShell->SelectAll();
+
rReq.Done();
}
break;
core.git: Branch 'libreoffice-24-8' - svx/source
svx/source/dialog/srchdlg.cxx | 17 +
svx/source/inc/findtextfield.hxx |1 +
svx/source/tbxctrls/tbunosearchcontrollers.cxx |5 +
3 files changed, 23 insertions(+)
New commits:
commit 982c262b479a5326925c13dfb7fb258901c6f348
Author: Heiko Tietze
AuthorDate: Mon Jul 8 16:50:37 2024 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Mon Jul 15 02:36:52 2024 +0200
Resolves tdf#161568 - Feedback for QFS in floating mode
As band-aid for the lack of proper toolbar resizing,
feedback is given via entry message type
Change-Id: Ic2b2a2aff93040f558775d63c18c21370fabcb39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170167
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 4e606c5b38139c4424fe9334aed32515c7547418)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170119
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx
index bb66ecde8343..dcb7e7d87a7b 100644
--- a/svx/source/dialog/srchdlg.cxx
+++ b/svx/source/dialog/srchdlg.cxx
@@ -72,6 +72,8 @@
#include
#include
+#include
+
#include
#include
#include
@@ -576,6 +578,9 @@ void SvxSearchDialog::SetSearchLabel(const OUString& rStr)
m_xSearchBox->set_size_request(-1, aSize.Height());
m_xSearchBox->set_background(COL_TRANSPARENT);
}
+
+if (rStr == SvxResId(RID_SVXSTR_SEARCH_NOT_FOUND))
+m_xSearchLB->set_entry_message_type(weld::EntryMessageType::Error);
}
void SvxSearchDialog::ApplyTransliterationFlags_Impl( TransliterationFlags
nSettings )
@@ -2373,6 +2378,18 @@ static void lcl_SetSearchLabelWindow(const OUString&
rStr, SfxViewFrame& rViewFr
pSearchLabel->set_label(rStr, LabelItemWindowType::Info);
pSearchLabel->SetOptimalSize();
}
+
+if (pToolBox->IsFloatingMode() && pToolBox->GetItemCommand(id) ==
".uno:FindText")
+{
+FindTextFieldControl* pFindText =
dynamic_cast(pToolBox->GetItemWindow(id));
+assert(pFindText);
+if (rStr == SvxResId(RID_SVXSTR_SEARCH_NOT_FOUND))
+
pFindText->set_entry_message_type(weld::EntryMessageType::Error);
+else if (rStr == SvxResId(RID_SVXSTR_SEARCH_END) || rStr ==
SvxResId(RID_SVXSTR_SEARCH_START))
+
pFindText->set_entry_message_type(weld::EntryMessageType::Warning);
+else
+
pFindText->set_entry_message_type(weld::EntryMessageType::Normal);
+}
}
xLayoutManager->doLayout();
pToolBox->Resize();
diff --git a/svx/source/inc/findtextfield.hxx b/svx/source/inc/findtextfield.hxx
index 9d15a0d8b47d..2c79a529b3f4 100644
--- a/svx/source/inc/findtextfield.hxx
+++ b/svx/source/inc/findtextfield.hxx
@@ -47,6 +47,7 @@ public:
OUString get_text(int nIndex) const;
OUString get_active_text() const;
void append_text(const OUString& rText);
+void set_entry_message_type(weld::EntryMessageType eType);
private:
ImplSVEvent* m_nAsyncGetFocusId;
diff --git a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
index c2070618d69e..47031df35524 100644
--- a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
+++ b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
@@ -436,6 +436,11 @@ OUString FindTextFieldControl::get_active_text() const
return m_xWidget->get_active_text();
}
+void FindTextFieldControl::set_entry_message_type(weld::EntryMessageType eType)
+{
+m_xWidget->set_entry_message_type(eType);
+}
+
void FindTextFieldControl::append_text(const OUString& rText)
{
m_xWidget->append_text(rText);
core.git: Branch 'libreoffice-24-8' - sw/source
sw/source/core/text/txthyph.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 2968bd73276e9bb62656a524926bf7fbd51a
Author: Heiko Tietze
AuthorDate: Tue Jul 9 12:53:03 2024 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Sat Jul 13 20:13:28 2024 +0200
Resolves tdf#161421 - Draw soft hyphen in black on PDF export
Change-Id: I69a19a0919fd31f8ea2fee962e994d61873e51c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170227
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/core/text/txthyph.cxx b/sw/source/core/text/txthyph.cxx
index bf8751d6cea5..8f419984323a 100644
--- a/sw/source/core/text/txthyph.cxx
+++ b/sw/source/core/text/txthyph.cxx
@@ -436,7 +436,8 @@ void SwSoftHyphPortion::Paint( const SwTextPaintInfo
) const
rInf.DrawViewOpt( *this, PortionType::SoftHyphen );
SwExpandPortion::Paint( rInf );
-if (rInf.GetOpt().IsViewMetaChars() && !rInf.GetOpt().IsPrinting())
+if (rInf.GetOpt().IsViewMetaChars() && !rInf.GetOpt().IsPrinting()
+&& !rInf.GetOpt().IsPDFExport())
{
OUString aMarker = u"-"_ustr;
SwTextPaintInfo aInf(rInf, );
core.git: Branch 'libreoffice-24-8' - sfx2/uiconfig
sfx2/uiconfig/ui/startcenter.ui |1 + 1 file changed, 1 insertion(+) New commits: commit a000c62e5d26dfc8c7b563d2a6c99fcf21955e98 Author: Heiko Tietze AuthorDate: Wed Jul 10 19:40:00 2024 +0200 Commit: Xisco Fauli CommitDate: Thu Jul 11 15:49:38 2024 +0200 tdf#161987: Always show donate icon in startcenter Issue on gtk3 environment only Change-Id: I251cf91fd04ed455383e443b5479e199486f7aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170303 Reviewed-by: Heiko Tietze Reviewed-by: Xisco Fauli Tested-by: Jenkins diff --git a/sfx2/uiconfig/ui/startcenter.ui b/sfx2/uiconfig/ui/startcenter.ui index 8e3126cf9761..657b1984006f 100644 --- a/sfx2/uiconfig/ui/startcenter.ui +++ b/sfx2/uiconfig/ui/startcenter.ui @@ -436,6 +436,7 @@ True none True +True False
core.git: sfx2/uiconfig
sfx2/uiconfig/ui/startcenter.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 3d4986cf3c94524a2cbb1a3313d7669ad369ea11 Author: Heiko Tietze AuthorDate: Wed Jul 10 19:40:00 2024 +0200 Commit: Heiko Tietze CommitDate: Thu Jul 11 15:26:24 2024 +0200 Always show donate icon in startcenter Issue on gtk3 environment only Change-Id: I251cf91fd04ed455383e443b5479e199486f7aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170325 Reviewed-by: Heiko Tietze Tested-by: Xisco Fauli Reviewed-by: Xisco Fauli diff --git a/sfx2/uiconfig/ui/startcenter.ui b/sfx2/uiconfig/ui/startcenter.ui index 8e3126cf9761..657b1984006f 100644 --- a/sfx2/uiconfig/ui/startcenter.ui +++ b/sfx2/uiconfig/ui/startcenter.ui @@ -436,6 +436,7 @@ True none True +True False
Minutes from the UX/design meeting 2023-Jul-11
Present: Sahil, Michael, Heiko Tickets/Topics *P2P collaboration* _User Stories_ * Simon wants to run a business meeting. He invites co-workers into the editing of a milestone document with text, numbers, and charts. After finalizing the content together, he as well as all colleagues add their signature so the document does not need to cycle through the company anymore. * Kryztina has to complete a form with a lot of bureaucratic text, and she struggles to understand all details as a person with migration background. She invites Christian into the editing to help her. * Maurizio works on a document with sensitive content. He needs help to accomplish a task but is not allowed to share the document publicly. So he invites Olivier to assist. * Eve has to insert some numbers in a spreadsheet but lacks on all data sources. She invites Benjamin to add his information while editing her own content. _Requirements_ * Easy to use: inviting a person is done as known from chat programs * Secure: privacy is always guaranteed * Fast: interaction feels never misplaced; no need for additional conflict handling as you always see the current state of the document * Reliability: everybody has a full copy of the document locally; and retrieves it when (re-)connecting; maybe it is necessary in some situations to protect the ownership and block storing the document on other participant's computer _Mockup_ * https://i.imgur.com/qywXe2t.png + (1) modifications are done likewise asynchronous tracked changes + (2) list of participants with an Add button to get the dialog (3) + (3) address book-like dialog to pick communication channels to invite people _Questions_ * How about special configurations like macros being disabled on one machine? * Relative links within the local file system wont work, and maybe need some additional work. * Have audio/video sharing additional to P2P collaboration? * Can this communication be standardized so any office application could join? OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jul-11
Present: Sahil, Michael, Heiko Tickets/Topics *P2P collaboration* _User Stories_ * Simon wants to run a business meeting. He invites co-workers into the editing of a milestone document with text, numbers, and charts. After finalizing the content together, he as well as all colleagues add their signature so the document does not need to cycle through the company anymore. * Kryztina has to complete a form with a lot of bureaucratic text, and she struggles to understand all details as a person with migration background. She invites Christian into the editing to help her. * Maurizio works on a document with sensitive content. He needs help to accomplish a task but is not allowed to share the document publicly. So he invites Olivier to assist. * Eve has to insert some numbers in a spreadsheet but lacks on all data sources. She invites Benjamin to add his information while editing her own content. _Requirements_ * Easy to use: inviting a person is done as known from chat programs * Secure: privacy is always guaranteed * Fast: interaction feels never misplaced; no need for additional conflict handling as you always see the current state of the document * Reliability: everybody has a full copy of the document locally; and retrieves it when (re-)connecting; maybe it is necessary in some situations to protect the ownership and block storing the document on other participant's computer _Mockup_ * https://i.imgur.com/qywXe2t.png + (1) modifications are done likewise asynchronous tracked changes + (2) list of participants with an Add button to get the dialog (3) + (3) address book-like dialog to pick communication channels to invite people _Questions_ * How about special configurations like macros being disabled on one machine? * Relative links within the local file system wont work, and maybe need some additional work. * Have audio/video sharing additional to P2P collaboration? * Can this communication be standardized so any office application could join? OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sfx2/source
sfx2/source/dialog/backingwindow.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit dd4d32797c7c4cb915f1f81ad92abb195985afb5
Author: Heiko Tietze
AuthorDate: Wed Jul 10 17:39:17 2024 +0200
Commit: Heiko Tietze
CommitDate: Thu Jul 11 12:50:52 2024 +0200
Fix to temporary variable name
Change-Id: I87be9a7b5cd2627844ab7b5f0c838eddbeb01b05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170319
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/sfx2/source/dialog/backingwindow.cxx
b/sfx2/source/dialog/backingwindow.cxx
index ee2e4459cf63..009c1acea6bc 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -196,9 +196,8 @@ BackingWindow::BackingWindow(vcl::Window* i_pParent)
// tdf#161796 make the extension button show the donation page
if (officecfg::Office::Common::Misc::ShowDonation::get())
{
-OUString test = SfxResId(STR_DONATE_BUTTON);
mxExtensionsButton->set_from_icon_name(BMP_DONATE); // icon first
needed on gtk3 to apply the label
-mxExtensionsButton->set_label(test);
+mxExtensionsButton->set_label(SfxResId(STR_DONATE_BUTTON));
}
mxDropTarget = mxAllRecentThumbnails->GetDropTarget();
core.git: sw/source
sw/source/core/text/txthyph.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit a9e23d1dcd361d95e046ab2d521ee55df9a77747
Author: Heiko Tietze
AuthorDate: Tue Jul 9 12:53:03 2024 +0200
Commit: Heiko Tietze
CommitDate: Wed Jul 10 13:47:09 2024 +0200
Resolves tdf#161421 - Draw soft hyphen in black on PDF export
Change-Id: I69a19a0919fd31f8ea2fee962e994d61873e51c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170211
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/text/txthyph.cxx b/sw/source/core/text/txthyph.cxx
index bf8751d6cea5..8f419984323a 100644
--- a/sw/source/core/text/txthyph.cxx
+++ b/sw/source/core/text/txthyph.cxx
@@ -436,7 +436,8 @@ void SwSoftHyphPortion::Paint( const SwTextPaintInfo
) const
rInf.DrawViewOpt( *this, PortionType::SoftHyphen );
SwExpandPortion::Paint( rInf );
-if (rInf.GetOpt().IsViewMetaChars() && !rInf.GetOpt().IsPrinting())
+if (rInf.GetOpt().IsViewMetaChars() && !rInf.GetOpt().IsPrinting()
+&& !rInf.GetOpt().IsPDFExport())
{
OUString aMarker = u"-"_ustr;
SwTextPaintInfo aInf(rInf, );
Minutes from the UX/design meeting 2023-Jul-03
Present: Eyal, Sahil, Rafael, Bogdan, John, Heiko Comments: Stuart, Cor, bdac Tickets/Topics * Extending safe mode + https://bugs.documentfoundation.org/show_bug.cgi?id=161249 + request is to migrate some of the version 6 user settings to version 24 + rather restructure the user profile (Stuart) + would export/import a user profile apart from the safe mode dialog (Eyal) + safe mode dialog is hard to use (Rafael, Heiko) + proposal at https://nextcloud.documentfoundation.org/s/Zj8nsETFTyPgeEB + missing feature to load an archived profile (Rafael) + access to each and every setting is dangerous (Rafael) + rather worth an extension (Heiko) or a stand-alone tool (Eyal) => WF; the dialog needs to receive an overhaul and has to become easier to use * Unexpected Selecting when character is selected and use TAB to move to next cell + https://bugs.documentfoundation.org/show_bug.cgi?id=161455 + https://bugs.documentfoundation.org/show_bug.cgi?id=118698 + not a bug (Cor, bdac, Stuart) + no good reason to not extend the selection beyond it's unusual (Heiko) + perhaps thinking about the moving concept (Eyal) + how about use shift+tab to extend selection and move with plain tab (Eyal) + downside is that we change established key combinations (Eyal) + afraid of conflicts with OS; "don't mess with tab" (Heiko) + shift+tab unselects backwards + feels like a bug, in particular after the end of the table is reached (Rafael) + happens also when the selection is done per shift+arrow (Heiko) + and that feels like a bug too (Eyal) + not really a convenience feature as the same might be achieved with shift+arrow + simply press esc and get the expected tab interaction (Sahil) => WF, or not * Functionality request for Writer: improve dialog "Insert index entry" + https://bugs.documentfoundation.org/show_bug.cgi?id=43530 + META in bug 122497 (Stuart) + usual autocompletion of lists; IOW the dropdown has an entry starting with BAR (Heiko) + probably caused by unclear labels (Eyal) + maybe tooltips help (Eyal) or forward to documentation (Heiko) => resolve WF (with request to reopen with more details) * Improve/create visibility for font fallback lists in the UI + https://bugs.documentfoundation.org/show_bug.cgi?id=161378 + no reason to adjust or expand usage (Stuart) + bug is about lists of font families (Eyal) + font families are unclear to me; sounds like a legacy (Heiko) => no expertise in the group, comments on final proposal might be possible OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jul-03
Present: Eyal, Sahil, Rafael, Bogdan, John, Heiko Comments: Stuart, Cor, bdac Tickets/Topics * Extending safe mode + https://bugs.documentfoundation.org/show_bug.cgi?id=161249 + request is to migrate some of the version 6 user settings to version 24 + rather restructure the user profile (Stuart) + would export/import a user profile apart from the safe mode dialog (Eyal) + safe mode dialog is hard to use (Rafael, Heiko) + proposal at https://nextcloud.documentfoundation.org/s/Zj8nsETFTyPgeEB + missing feature to load an archived profile (Rafael) + access to each and every setting is dangerous (Rafael) + rather worth an extension (Heiko) or a stand-alone tool (Eyal) => WF; the dialog needs to receive an overhaul and has to become easier to use * Unexpected Selecting when character is selected and use TAB to move to next cell + https://bugs.documentfoundation.org/show_bug.cgi?id=161455 + https://bugs.documentfoundation.org/show_bug.cgi?id=118698 + not a bug (Cor, bdac, Stuart) + no good reason to not extend the selection beyond it's unusual (Heiko) + perhaps thinking about the moving concept (Eyal) + how about use shift+tab to extend selection and move with plain tab (Eyal) + downside is that we change established key combinations (Eyal) + afraid of conflicts with OS; "don't mess with tab" (Heiko) + shift+tab unselects backwards + feels like a bug, in particular after the end of the table is reached (Rafael) + happens also when the selection is done per shift+arrow (Heiko) + and that feels like a bug too (Eyal) + not really a convenience feature as the same might be achieved with shift+arrow + simply press esc and get the expected tab interaction (Sahil) => WF, or not * Functionality request for Writer: improve dialog "Insert index entry" + https://bugs.documentfoundation.org/show_bug.cgi?id=43530 + META in bug 122497 (Stuart) + usual autocompletion of lists; IOW the dropdown has an entry starting with BAR (Heiko) + probably caused by unclear labels (Eyal) + maybe tooltips help (Eyal) or forward to documentation (Heiko) => resolve WF (with request to reopen with more details) * Improve/create visibility for font fallback lists in the UI + https://bugs.documentfoundation.org/show_bug.cgi?id=161378 + no reason to adjust or expand usage (Stuart) + bug is about lists of font families (Eyal) + font families are unclear to me; sounds like a legacy (Heiko) => no expertise in the group, comments on final proposal might be possible OpenPGP_signature.asc Description: OpenPGP digital signature
Re: GSoC: Libreoffice Theme WIN (not getting stdout, cannot do printfdebugging)
In cygwin environment, don't you run instdir/program/soffice.exe? Works well here. On 01.07.24 8:42 PM, Sahil Gautam wrote: Hi, I successfully built libreoffice on windows using LODE. The problem is that I cannot see stdout on the terminal, or in vscode's terminal. I rely on that for checking if opening this dialog trips this breakpoint or not, and how many times does it do so. using a debugger seems a good choice, but it's a hassle considering that UI can trigger a function changing colors n times, and I don't want to press F5 n times, it's not feasible. Is there any way to get the stdout on the terminal? I tried ./..soffice > log.file, but didn't get anything. If not then n times F5 (continue the debugger) will be the only option. I use `std::cout << "string here" << std::endl;` in the function calls. Regards Sahil Gautam OpenPGP_signature.asc Description: OpenPGP digital signature
Re: GSoC: Libreoffice Theme WIN (failed on ->./autogen.sh failed, visual-studio not found)
On 29.06.24 9:46 PM, Ilmari Lauhakangas wrote: Did you remember to add to your autogen.input --with-visual-studio=2022 Stumbled over the same problem ;-). As always, reading the notes helps. https://wiki.documentfoundation.org/Development/BuildingOnWindows#Notes_on_older_and_non-default_MS_compilers OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-24-2' - sw/inc
sw/inc/strings.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e812e31b845ff6550fc12036e4fd3ddcb535ae5c
Author: Heiko Tietze
AuthorDate: Mon Jun 24 08:07:28 2024 +0200
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Thu Jun 27 00:46:48 2024 +0200
Fixes copy/paste error
follow-up to Iff407da8907b761236ebc2aa8877b9d6b8294e10
Change-Id: Icb5b3703809e5df80df5e269e6160c1c78dc186d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169364
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Reviewed-by: Justin Luth
(cherry picked from commit c13528abd69ea256cfde5ef1933c4e7f51219d33)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169551
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index ea322289e36a..e2a2f153ac8d 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -134,7 +134,7 @@
#define STR_POOLCOLL_BULLET_LEVEL5
NC_("STR_POOLCOLL_BULLET_LEVEL5", "List 5")
#define STR_POOLCOLL_BULLET_LEVEL5E
NC_("STR_POOLCOLL_BULLET_LEVEL5E", "List 5 End")
#define STR_POOLCOLL_BULLET_NONUM5
NC_("STR_POOLCOLL_BULLET_NONUM5", "List 5 Cont.")
-#define STR_POOLCOLL_HEADERFOOTER NC_("STR_POOLCOLL_HEADER",
"Header and Footer")
+#define STR_POOLCOLL_HEADERFOOTER
NC_("STR_POOLCOLL_HEADERFOOTER", "Header and Footer")
#define STR_POOLCOLL_HEADER NC_("STR_POOLCOLL_HEADER",
"Header")
#define STR_POOLCOLL_HEADERLNC_("STR_POOLCOLL_HEADERL",
"Header Left")
#define STR_POOLCOLL_HEADERRNC_("STR_POOLCOLL_HEADERR",
"Header Right")
core.git: Branch 'libreoffice-24-8' - sw/inc
sw/inc/strings.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4e83c689efad85fc9657deca2c8e6aea2f618cdc
Author: Heiko Tietze
AuthorDate: Mon Jun 24 08:07:28 2024 +0200
Commit: Xisco Fauli
CommitDate: Wed Jun 26 17:46:40 2024 +0200
Fixes copy/paste error
follow-up to Iff407da8907b761236ebc2aa8877b9d6b8294e10
Change-Id: Icb5b3703809e5df80df5e269e6160c1c78dc186d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169364
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Reviewed-by: Justin Luth
(cherry picked from commit c13528abd69ea256cfde5ef1933c4e7f51219d33)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169498
Reviewed-by: Xisco Fauli
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index 298b861eecf6..2d21be7daedc 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -134,7 +134,7 @@
#define STR_POOLCOLL_BULLET_LEVEL5
NC_("STR_POOLCOLL_BULLET_LEVEL5", "List 5")
#define STR_POOLCOLL_BULLET_LEVEL5E
NC_("STR_POOLCOLL_BULLET_LEVEL5E", "List 5 End")
#define STR_POOLCOLL_BULLET_NONUM5
NC_("STR_POOLCOLL_BULLET_NONUM5", "List 5 Cont.")
-#define STR_POOLCOLL_HEADERFOOTER NC_("STR_POOLCOLL_HEADER",
"Header and Footer")
+#define STR_POOLCOLL_HEADERFOOTER
NC_("STR_POOLCOLL_HEADERFOOTER", "Header and Footer")
#define STR_POOLCOLL_HEADER NC_("STR_POOLCOLL_HEADER",
"Header")
#define STR_POOLCOLL_HEADERLNC_("STR_POOLCOLL_HEADERL",
"Header Left")
#define STR_POOLCOLL_HEADERRNC_("STR_POOLCOLL_HEADERR",
"Header Right")
core.git: sw/inc
sw/inc/strings.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c13528abd69ea256cfde5ef1933c4e7f51219d33
Author: Heiko Tietze
AuthorDate: Mon Jun 24 08:07:28 2024 +0200
Commit: Justin Luth
CommitDate: Tue Jun 25 14:08:11 2024 +0200
Fixes copy/paste error
follow-up to Iff407da8907b761236ebc2aa8877b9d6b8294e10
Change-Id: Icb5b3703809e5df80df5e269e6160c1c78dc186d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169364
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Reviewed-by: Justin Luth
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index b9e46f13d0c6..3a70a42cd0bd 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -134,7 +134,7 @@
#define STR_POOLCOLL_BULLET_LEVEL5
NC_("STR_POOLCOLL_BULLET_LEVEL5", "List 5")
#define STR_POOLCOLL_BULLET_LEVEL5E
NC_("STR_POOLCOLL_BULLET_LEVEL5E", "List 5 End")
#define STR_POOLCOLL_BULLET_NONUM5
NC_("STR_POOLCOLL_BULLET_NONUM5", "List 5 Cont.")
-#define STR_POOLCOLL_HEADERFOOTER NC_("STR_POOLCOLL_HEADER",
"Header and Footer")
+#define STR_POOLCOLL_HEADERFOOTER
NC_("STR_POOLCOLL_HEADERFOOTER", "Header and Footer")
#define STR_POOLCOLL_HEADER NC_("STR_POOLCOLL_HEADER",
"Header")
#define STR_POOLCOLL_HEADERLNC_("STR_POOLCOLL_HEADERL",
"Header Left")
#define STR_POOLCOLL_HEADERRNC_("STR_POOLCOLL_HEADERR",
"Header Right")
core.git: officecfg/registry sc/qa sc/source
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |7 +++
sc/qa/unit/uicalc/uicalc.cxx |2 +
sc/source/ui/view/cellsh3.cxx| 27 ++-
3 files changed, 35 insertions(+), 1 deletion(-)
New commits:
commit e932e2ab943a9941fcfc7073c9b6c11b982c2c4c
Author: Heiko Tietze
AuthorDate: Thu Jun 20 15:12:05 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue Jun 25 09:15:25 2024 +0200
Resolves tdf#161641 - Select data area before select all
Advanced option SelectRangeBeforeAll to restore original behavior
Change-Id: Iab4b4e61dffc1ecf2ffed01a994c9894c84ab74d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169276
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-by: Heiko Tietze
diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index 7303d1bacd00..b9f74d9724fa 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -763,6 +763,13 @@
true
+
+
+ Disable to always select all
+ Select range before all
+
+true
+
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 08a1eeb3848b..ae1edf38147e 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -2120,6 +2120,8 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf108654)
createScDoc("tdf108654.ods");
ScDocument* pDoc = getScDoc();
+dispatchCommand(mxComponent, u".uno:SelectAll"_ustr, {});
+// first .uno:SelectAll selects the range, second all (tdf#161641)
dispatchCommand(mxComponent, u".uno:SelectAll"_ustr, {});
dispatchCommand(mxComponent, u".uno:Copy"_ustr, {});
diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx
index c62500c7e124..dfb7b4d5e92b 100644
--- a/sc/source/ui/view/cellsh3.cxx
+++ b/sc/source/ui/view/cellsh3.cxx
@@ -49,6 +49,7 @@
#include
#include
#include
+#include
#include
@@ -657,7 +658,31 @@ void ScCellShell::Execute( SfxRequest& rReq )
case SID_SELECTALL:
{
-pTabViewShell->SelectAll();
+SCTAB nTab = GetViewData().GetTabNo();
+SCCOL nStartCol = GetViewData().GetCurX();
+SCROW nStartRow = GetViewData().GetCurY();
+SCCOL nEndCol = nStartCol;
+SCROW nEndRow = nStartRow;
+bool bCanMark = false;
+
+ScMarkData& rMarkdata = GetViewData().GetMarkData();
+const bool
bSelectFirst(officecfg::Office::Calc::Input::SelectRangeBeforeAll::get());
+
+if (bSelectFirst && !rMarkdata.IsMarked())
+{
+const ScDocument& rDoc = GetViewData().GetDocument();
+rDoc.GetDataArea( nTab, nStartCol, nStartRow, nEndCol,
nEndRow, true, false );
+bCanMark = nStartCol != nEndCol || nStartRow != nEndRow;
+}
+
+if (bCanMark)
+{
+const ScRange aRange(nStartCol, nStartRow, nTab, nEndCol,
nEndRow, nTab);
+pTabViewShell->MarkRange(aRange, false);
+}
+else
+pTabViewShell->SelectAll();
+
rReq.Done();
}
break;
core.git: officecfg/registry sc/inc sc/sdi sc/source
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu|6 +++ officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |8 sc/inc/sc.hrc |1 sc/sdi/cellsh.sdi |1 sc/sdi/scalc.sdi | 17 ++ sc/source/ui/view/cellsh.cxx |1 sc/source/ui/view/cellsh1.cxx | 11 ++ sc/source/ui/view/tabview3.cxx|1 8 files changed, 46 insertions(+) New commits: commit ec5e0d0cd7074a912415761f779b00f8b7117fcf Author: Heiko Tietze AuthorDate: Thu Jun 20 12:56:33 2024 +0200 Commit: Heiko Tietze CommitDate: Thu Jun 20 15:15:56 2024 +0200 Resolves tdf#64028 - Command to retain source cell on cut .uno:CopyDelete copies the cell and deletes the content, assigned to shift+ctrl+X Misses to block the command while in edit mode, see tdf#161712 Change-Id: I479008b0484ef8ced86b709a0dc2bdbfa6c44cb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169266 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index d90357018cb0..4a3962141caf 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -1525,6 +1525,12 @@ Ctrl+Shift+u aka U_SHIFT_MOD1 under GTK/IBUS is for unicode key input .uno:JumpToPrevTable + + +L10N SHORTCUTS - NO TRANSLATE +.uno:CopyDelete + + diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index ad4508627230..e968764fd2c5 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -2515,6 +2515,14 @@ 1 + + + ~Cut but Keep Format + + + 1 + + diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc index 9ef248660d7e..57c80e62df2d 100644 --- a/sc/inc/sc.hrc +++ b/sc/inc/sc.hrc @@ -513,6 +513,7 @@ static_assert(SID_PREVIEW_END < SID_KEYFUNC_START, "calc slots ids trampling inf #define SID_ACCEPT_FORMULA (SID_KEYFUNC_START + 42) #define SID_START_FORMULA (SID_KEYFUNC_START + 43) +#define SID_COPYDELETE (SID_KEYFUNC_START + 44) #define SID_KEYFUNC_END (SID_KEYFUNC_START + 50) diff --git a/sc/sdi/cellsh.sdi b/sc/sdi/cellsh.sdi index ebba146f998d..6f27650509d3 100644 --- a/sc/sdi/cellsh.sdi +++ b/sc/sdi/cellsh.sdi @@ -171,6 +171,7 @@ interface CellSelection SID_FOCUS_INPUTLINE [ ExecMethod = ExecuteMove; StateMethod = GetStateCursor; ] SID_CUT [ ExecMethod = ExecuteEdit; StateMethod = GetBlockState; ] SID_COPY[ ExecMethod = ExecuteEdit; StateMethod = GetBlockState; ] +SID_COPYDELETE [ ExecMethod = ExecuteEdit; StateMethod = GetBlockState; ] SID_PASTE [ ExecMethod = ExecuteEdit; StateMethod = GetClipState; ] SID_PASTE_SPECIAL [ ExecMethod = ExecuteEdit; StateMethod = GetClipState; ] SID_PASTE_UNFORMATTED [ ExecMethod = ExecuteEdit; StateMethod = GetClipState; ] diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi index 3591ca10f199..d532de343600 100644 --- a/sc/sdi/scalc.sdi +++ b/sc/sdi/scalc.sdi @@ -6700,3 +6700,20 @@ SfxVoidItem MoveKeepInsertMode FID_MOVE_KEEP_INSERT_MODE GroupId = SfxGroupId::Application; ] + +SfxVoidItem CopyDelete SID_COPYDELETE +() +[ +AutoUpdate = FALSE, +FastCall = FALSE, +ReadOnlyDoc = FALSE, +Toggle = FALSE, +Container = FALSE, +RecordAbsolute = FALSE, +RecordPerSet; + +AccelConfig = TRUE, +MenuConfig = TRUE, +ToolBoxConfig = TRUE, +GroupId = SfxGroupId::Edit; +] \ No newline at end of file diff --git a/sc/source/ui/view/cellsh.cxx b/sc/source/ui/view/cellsh.cxx index b61a5618..351868f3e95f 100644 --- a/sc/source/ui/view/cellsh.cxx +++ b/sc/source/ui/view/cellsh.cxx @@ -233,6 +233,7 @@ void ScCellShell::GetBlockState( SfxItemSet& rSet ) bDisable = false; break; case SID_CUT: // cut +case SID_COPYDELETE: bDisable = !bSimpleArea || GetObjectShell()->isContentExtractionLocked(); break; case FID_INS_CELL: // insert cells, just simple selection diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx index 50c5635a3b18..ed879ecb62f9 100644 --- a/sc/source/ui/view/ce
core.git: vcl/source
vcl/source/outdev/textline.cxx |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
New commits:
commit baf95a7e8e7312891aed73adb26de74e5bc9ad62
Author: Heiko Tietze
AuthorDate: Wed Jun 19 12:14:05 2024 +0200
Commit: Heiko Tietze
CommitDate: Thu Jun 20 09:11:46 2024 +0200
Resolves tdf#153223 - Suppress variable line height when skia is off
Change-Id: I9194c25bf2fc104574bd27e6b8683b63111e6ad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169192
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/vcl/source/outdev/textline.cxx b/vcl/source/outdev/textline.cxx
index 3155cb1a1681..fa9f481c201c 100644
--- a/vcl/source/outdev/textline.cxx
+++ b/vcl/source/outdev/textline.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
@@ -1036,7 +1037,12 @@ void OutputDevice::DrawWaveLine(const Point& rStartPos,
const Point& rEndPos, to
// #109280# make sure the waveline does not exceed the descent to avoid
paint problems
LogicalFontInstance* pFontInstance = mpFontInstance.get();
-if (nWaveHeight > pFontInstance->mxFontMetric->GetWavelineUnderlineSize())
+if (nWaveHeight > pFontInstance->mxFontMetric->GetWavelineUnderlineSize()
+// tdf#153223 polyline with lineheight >0 not drawn when skia is off
+#ifdef MACOSX
+|| !SkiaHelper::isVCLSkiaEnabled()
+#endif
+ )
{
nWaveHeight = pFontInstance->mxFontMetric->GetWavelineUnderlineSize();
// tdf#124848 hairline
Minutes from the UX/design meeting 2023-Jun-19
Present: Sahil, Rafael, Heiko Comments: Stephane, Stuart, Mike, Miguel, Ady, Eyal, Cor Tickets/Topics * Allow typing a date directly into the ad-hoc field when creating a custom date property + https://bugs.documentfoundation.org/show_bug.cgi?id=161393 + allow both entering a date by hand, while switching between increasingly large time ranges like decades with the pointer (Stephane) + nice idea (Cor) + just direct editing with some validation on-the-fly (Rafael, Heiko) + date picker with a switch so up/down change the year (Sahil) => do it * Change any style from a single window + https://bugs.documentfoundation.org/show_bug.cgi?id=160735 + implement an additional view mode 'Picked' (Stuart) + unclear request (Mike) + "Save as New" next to Reset, Apply..., which does not overwrites the currently edited style but creates a new children of it (Heiko) + likely detrimental to usability (Mike, Heiko) + offer a primary GUI to perform the style management (Stuart) + -1, changing styles is easy; mourning heading with percentage by default (Cor) + Stylist offers drag 'n drop so creating some style and moving it below another, which takes the attributes, is easy to do (Heiko) + see no obvious improvement in such a feature (Rafael) + create a dummy style, move the styles to change into this parent and change the property of the parent + to create a new children use New from the context menu + run into similar trouble with shapes (Rafael) + same procedure, create a new parent and move the styles into this + but it's moving not copying - we may use an accelerator like ctrl+drag to not move but copy + changing a style other than the current (and all other interactions) should be possible without the Stylist (Sahil) + would add a listview to the organizer tab that allows quick changes of the currently modified style (and maybe remove the name option and have some editing capability on this list) (Sahil) => introduce ctrl+drag to copy a style and make the style name a dropdown so changing any style is possible without the Stylist * Search in both values & formulae + https://bugs.documentfoundation.org/show_bug.cgi?id=161364 + agree (Miguel, Stuart, Sahil) + if implemented it should be labeled and working as "Everything" (Ady) + while FR distinguishes between Values and Formulas the QFS finds Values; OP obviously has not updated for a while + QFS should return Everything => go for the "Everything" option * UI: Hard to tell which side of a shape being used for as reference for rotation + https://bugs.documentfoundation.org/show_bug.cgi?id=161441 + rotation on plain shapes don't matter (Eyal) + leg/pointer extending in the vertical direction when created (Stuart) + reasonable request (Cor) + some kind of indicator on top left sounds good (Rafael) + flipping horizontally keeps the rotation while vertically changes it to 180° + a) always visible, b) optionally, c) only when selected, d) only when in rotation mode? -> c) (Rafael, Sahil) + symbol could be an angle or icon + or use a different color for the (green) dot (Rafael) + could also be a dedicated rotation "icon" like MSO does (Rafael) + show the actual degree of rotation with the cursor (Sahil) => idea accepted OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jun-19
Present: Sahil, Rafael, Heiko Comments: Stephane, Stuart, Mike, Miguel, Ady, Eyal, Cor Tickets/Topics * Allow typing a date directly into the ad-hoc field when creating a custom date property + https://bugs.documentfoundation.org/show_bug.cgi?id=161393 + allow both entering a date by hand, while switching between increasingly large time ranges like decades with the pointer (Stephane) + nice idea (Cor) + just direct editing with some validation on-the-fly (Rafael, Heiko) + date picker with a switch so up/down change the year (Sahil) => do it * Change any style from a single window + https://bugs.documentfoundation.org/show_bug.cgi?id=160735 + implement an additional view mode 'Picked' (Stuart) + unclear request (Mike) + "Save as New" next to Reset, Apply..., which does not overwrites the currently edited style but creates a new children of it (Heiko) + likely detrimental to usability (Mike, Heiko) + offer a primary GUI to perform the style management (Stuart) + -1, changing styles is easy; mourning heading with percentage by default (Cor) + Stylist offers drag 'n drop so creating some style and moving it below another, which takes the attributes, is easy to do (Heiko) + see no obvious improvement in such a feature (Rafael) + create a dummy style, move the styles to change into this parent and change the property of the parent + to create a new children use New from the context menu + run into similar trouble with shapes (Rafael) + same procedure, create a new parent and move the styles into this + but it's moving not copying - we may use an accelerator like ctrl+drag to not move but copy + changing a style other than the current (and all other interactions) should be possible without the Stylist (Sahil) + would add a listview to the organizer tab that allows quick changes of the currently modified style (and maybe remove the name option and have some editing capability on this list) (Sahil) => introduce ctrl+drag to copy a style and make the style name a dropdown so changing any style is possible without the Stylist * Search in both values & formulae + https://bugs.documentfoundation.org/show_bug.cgi?id=161364 + agree (Miguel, Stuart, Sahil) + if implemented it should be labeled and working as "Everything" (Ady) + while FR distinguishes between Values and Formulas the QFS finds Values; OP obviously has not updated for a while + QFS should return Everything => go for the "Everything" option * UI: Hard to tell which side of a shape being used for as reference for rotation + https://bugs.documentfoundation.org/show_bug.cgi?id=161441 + rotation on plain shapes don't matter (Eyal) + leg/pointer extending in the vertical direction when created (Stuart) + reasonable request (Cor) + some kind of indicator on top left sounds good (Rafael) + flipping horizontally keeps the rotation while vertically changes it to 180° + a) always visible, b) optionally, c) only when selected, d) only when in rotation mode? -> c) (Rafael, Sahil) + symbol could be an angle or icon + or use a different color for the (green) dot (Rafael) + could also be a dedicated rotation "icon" like MSO does (Rafael) + show the actual degree of rotation with the cursor (Sahil) => idea accepted OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jun-13
Present: Hossein, Sahil, Rafael, Heiko Comments: Michael, Mike, Khaled, Stephane, Daniel, Jonathan, Caolan, Gabor, Tuomas Tickets/Topics * Wrong editing languages offered + https://bugs.documentfoundation.org/show_bug.cgi?id=95274 + c11: menu should list installed languages (Michael) + checkbox "Do not automatically detect my document language" + "rework document Language Setting into a dedicated dialog" requested in bug 103036 + c44, c45: languageguesser/libexttextcat, see bug 139185#c4 (Mike), some wisdom in c45 (Khaled) + c53: only show matches that have a dictionary installed, feedback if the entry is a suggestion (Stephane) + c55: some examples; suggestions should go into a special section (Daniel) + c58: 1.) document languages, 2) *explicitly* specified languages, 3,4) heuristics (default languages for documents, user interface language), (system configuration) (Johnathan) + c63: libexttextcat was meant for full paragraphs (Caolan) + language guessing is needed by many users and should be improved (Hossein) + drop library and add checkboxes to the language list under tools > options > locales so users can define manually what they speak (Heiko) + perhaps not drop but make it an experimental or optional feature + code likely cannot become better (Rafael) + other lib https://github.com/pemistahl/lingua-py (Hossein) => make suggestions optional by adding "[ ] Detect languages" (off by default), show document languages in the dropdown and require user to pick one from the character dialog (as today and like MSO does), sort results according c55; do not add recent languages (across sessions); in the long run it would be good to improve the detection * Chart Properties sidebar only accommodates 4 chart type previews, but the Pie category now has 6 + https://bugs.documentfoundation.org/show_bug.cgi?id=161093 + a) either add a second row or make the items smaller, or b) list it as an extra chart type, or c) don't treat it as extra chart type but an attribute of pie (on/off, pie/bar currently) (Heiko) + would go with a second row (Rafael) + prefer c) (Heiko) => comment * flag when paging through sheets & the first/last sheet is passed +pageUP/pageDOWN + https://bugs.documentfoundation.org/show_bug.cgi?id=161155 + sheets may fill the space and a message similar to the quickfind toolbar does not fit anymore (Heiko) + infobar with "[x] Show this infobar" (Rafael) + different workflow and rather WF (Sahil) + add UNO commands "To First/Last Sheet" (Heiko) + might not help (Rafael) + add (advanced) option to not loop, off by default for compatibility (Hossein) => go with the option * UI Better wording for ASCII-only characters + https://bugs.documentfoundation.org/show_bug.cgi?id=161411 + Basic Latin is equally difficult to understand as ASCII (Gabor) + tell the user what exact character is not accepted (Hossein) + and tell what is accepted in the help (Rafael) + "Only Unicode 'Basic Latin' characters can be entered" with tooltip "Characters in the Unicode 'Basic Latin' block (also known as ASCII) including the letters A-Z, a-z, numbers 0-9 and the most common punctuation marks." (Tuomas) + "Character not allowed. Read the help page for a list of allowed characters." (Rafael) + "Character not allowed, only basic Latin alphabets, numbers and punctuations can be used." (Hossein) + "Character is not accepted" (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jun-13
Present: Hossein, Sahil, Rafael, Heiko Comments: Michael, Mike, Khaled, Stephane, Daniel, Jonathan, Caolan, Gabor, Tuomas Tickets/Topics * Wrong editing languages offered + https://bugs.documentfoundation.org/show_bug.cgi?id=95274 + c11: menu should list installed languages (Michael) + checkbox "Do not automatically detect my document language" + "rework document Language Setting into a dedicated dialog" requested in bug 103036 + c44, c45: languageguesser/libexttextcat, see bug 139185#c4 (Mike), some wisdom in c45 (Khaled) + c53: only show matches that have a dictionary installed, feedback if the entry is a suggestion (Stephane) + c55: some examples; suggestions should go into a special section (Daniel) + c58: 1.) document languages, 2) *explicitly* specified languages, 3,4) heuristics (default languages for documents, user interface language), (system configuration) (Johnathan) + c63: libexttextcat was meant for full paragraphs (Caolan) + language guessing is needed by many users and should be improved (Hossein) + drop library and add checkboxes to the language list under tools > options > locales so users can define manually what they speak (Heiko) + perhaps not drop but make it an experimental or optional feature + code likely cannot become better (Rafael) + other lib https://github.com/pemistahl/lingua-py (Hossein) => make suggestions optional by adding "[ ] Detect languages" (off by default), show document languages in the dropdown and require user to pick one from the character dialog (as today and like MSO does), sort results according c55; do not add recent languages (across sessions); in the long run it would be good to improve the detection * Chart Properties sidebar only accommodates 4 chart type previews, but the Pie category now has 6 + https://bugs.documentfoundation.org/show_bug.cgi?id=161093 + a) either add a second row or make the items smaller, or b) list it as an extra chart type, or c) don't treat it as extra chart type but an attribute of pie (on/off, pie/bar currently) (Heiko) + would go with a second row (Rafael) + prefer c) (Heiko) => comment * flag when paging through sheets & the first/last sheet is passed +pageUP/pageDOWN + https://bugs.documentfoundation.org/show_bug.cgi?id=161155 + sheets may fill the space and a message similar to the quickfind toolbar does not fit anymore (Heiko) + infobar with "[x] Show this infobar" (Rafael) + different workflow and rather WF (Sahil) + add UNO commands "To First/Last Sheet" (Heiko) + might not help (Rafael) + add (advanced) option to not loop, off by default for compatibility (Hossein) => go with the option * UI Better wording for ASCII-only characters + https://bugs.documentfoundation.org/show_bug.cgi?id=161411 + Basic Latin is equally difficult to understand as ASCII (Gabor) + tell the user what exact character is not accepted (Hossein) + and tell what is accepted in the help (Rafael) + "Only Unicode 'Basic Latin' characters can be entered" with tooltip "Characters in the Unicode 'Basic Latin' block (also known as ASCII) including the letters A-Z, a-z, numbers 0-9 and the most common punctuation marks." (Tuomas) + "Character not allowed. Read the help page for a list of allowed characters." (Rafael) + "Character not allowed, only basic Latin alphabets, numbers and punctuations can be used." (Hossein) + "Character is not accepted" (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'feature/cib_contract49c' - cui/uiconfig
cui/uiconfig/ui/pickbulletpage.ui| 59 +--
cui/uiconfig/ui/pickgraphicpage.ui | 135 +++
cui/uiconfig/ui/picknumberingpage.ui | 59 +--
cui/uiconfig/ui/pickoutlinepage.ui | 59 +--
4 files changed, 118 insertions(+), 194 deletions(-)
New commits:
commit 70ddbaa961321cb1b6ffd7295c22c38032767462
Author: Heiko Tietze
AuthorDate: Wed Mar 13 09:40:51 2024 +0100
Commit: Thorsten Behrens
CommitDate: Fri Jun 7 22:12:46 2024 +0200
Resolves tdf#160167 - Remove pointless frames in bullet & numbering dialog
Solves the issue that the "Selection" label is inappropriate
Change-Id: I1bdaa6922796fcdceec0aac6902011aa21cd9aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164758
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit aacce8abe239ad679f5e9f9ce9bf2d27fb046d5d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168493
Tested-by: allotropia jenkins
Reviewed-by: Thorsten Behrens
diff --git a/cui/uiconfig/ui/pickbulletpage.ui
b/cui/uiconfig/ui/pickbulletpage.ui
index b9749dda540e..589874506853 100644
--- a/cui/uiconfig/ui/pickbulletpage.ui
+++ b/cui/uiconfig/ui/pickbulletpage.ui
@@ -1,58 +1,39 @@
-
+
-
+
True
-False
+True
+6
+6
+6
+6
True
True
-6
-0
-none
+never
+never
+in
-
+
True
-True
-True
-True
-never
-never
-in
-12
-6
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
bullet style that you want to use.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
bullet style that you want to use.
-
-
-True
-False
-Selection
-
-
-
-
-
Displays the different
bullet styles that you can apply.
diff --git a/cui/uiconfig/ui/pickgraphicpage.ui
b/cui/uiconfig/ui/pickgraphicpage.ui
index fd7b9922e950..ea7342844a14 100644
--- a/cui/uiconfig/ui/pickgraphicpage.ui
+++ b/cui/uiconfig/ui/pickgraphicpage.ui
@@ -1,104 +1,85 @@
-
+
-
+
+
True
-False
+False
+6
+6
+6
+6
True
True
-6
-0
-none
+6
-
-
+
True
-False
+True
True
True
-6
-12
-6
+never
+in
-
+
True
-True
-True
-True
-never
-in
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
graphics that you want to use as bullets.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
graphics that you want to use as bullets.
-
-1
-0
-
-
-
-
-False
-True
-The Gallery theme 'Bullets' is empty (no
images).
-True
-
-
-0
-0
-
-
-
-
-Add and Resize
-True
-True
-False
-end
-
-
-1
-2
-
-
-
-
-
-
-
-
-
-
+
+1
+0
+
+
+
+
+False
+True
+The Gallery theme 'Bullets' is empty (no
images).
+True
+
+
+
Minutes from the UX/design meeting 2023-Jun-05
Present: Sahil, Rafael, Eyal, Aditya, John, Heiko Comments: Eike, Ady, Justin, Cor Tickets/Topics * basic HTML cell render + https://bugs.documentfoundation.org/show_bug.cgi?id=161223 + by no means into the formula expression engine (Eike) + another formatting layer might be possible (Eike) + also not working to concatenate cell content with formatting (Heiko) + over-complicate things (Rafael) + could be realized per extension (Sahil) => WF * RecalcOptimalRowHeightMode should be effective for CSV imports also + https://bugs.documentfoundation.org/show_bug.cgi?id=160983 + line-breaking characters should not be modified by the import process (Ady) + request is to make RecalcOptimalRowHeightMode available for every import, maybe with a third state that asks on input; but still for WF (Justin) + makes the import dialog overly complex, WF (Heiko) + probably not so rarely needed (Eyal, John) + if done as Ask it should not be a dialog (Eyal) + RecalcOptimalHeight was recently introduced with yes,no,ask and might be sufficient for the user (Rafael) + though it's not working as expected => NEEDINFO, likely WFM * UI - dashed outline for active cell border + https://bugs.documentfoundation.org/show_bug.cgi?id=161204 + active cell/range indicator is meanwhile shown outside the cell (Ady) + change selection color or line style (eg. dashed with document color) depending on cell background on/off (Heiko) + clashes with marching ants on copy (Eyal) + cells with dashed borders would be another issue (Eyal) + Excel does two lines, one with the selection color and another in white or the cell background; sounds like a good solution (Rafael) + might be ugly as with do draw the focus rectangle only around the focused cell and the selection receives a background too; making the background smaller would be not so nice + merge selection color with the cell and/or document background (Heiko) => assign to Rafael * Support showing combinations of (named) style + direct formatting in Stylist + https://bugs.documentfoundation.org/show_bug.cgi?id=161251 + do not overload simple controls (Cor) + show only on the flat tree like Applied Styles (Eyal) + inspired by MSO's Styles widget which optionally merges all information (PS, CF, DF) into the list (Eyal) + Styles Inspector does the same (Rafael), Styles Highlighter too (Heiko) + reasonable request; feature parity is always good (John) + MSO is not a good example for styling documents (Rafael) + low impact on usability possible, eg. per additional filter that shows applied styles + DF (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Jun-05
Present: Sahil, Rafael, Eyal, Aditya, John, Heiko Comments: Eike, Ady, Justin, Cor Tickets/Topics * basic HTML cell render + https://bugs.documentfoundation.org/show_bug.cgi?id=161223 + by no means into the formula expression engine (Eike) + another formatting layer might be possible (Eike) + also not working to concatenate cell content with formatting (Heiko) + over-complicate things (Rafael) + could be realized per extension (Sahil) => WF * RecalcOptimalRowHeightMode should be effective for CSV imports also + https://bugs.documentfoundation.org/show_bug.cgi?id=160983 + line-breaking characters should not be modified by the import process (Ady) + request is to make RecalcOptimalRowHeightMode available for every import, maybe with a third state that asks on input; but still for WF (Justin) + makes the import dialog overly complex, WF (Heiko) + probably not so rarely needed (Eyal, John) + if done as Ask it should not be a dialog (Eyal) + RecalcOptimalHeight was recently introduced with yes,no,ask and might be sufficient for the user (Rafael) + though it's not working as expected => NEEDINFO, likely WFM * UI - dashed outline for active cell border + https://bugs.documentfoundation.org/show_bug.cgi?id=161204 + active cell/range indicator is meanwhile shown outside the cell (Ady) + change selection color or line style (eg. dashed with document color) depending on cell background on/off (Heiko) + clashes with marching ants on copy (Eyal) + cells with dashed borders would be another issue (Eyal) + Excel does two lines, one with the selection color and another in white or the cell background; sounds like a good solution (Rafael) + might be ugly as with do draw the focus rectangle only around the focused cell and the selection receives a background too; making the background smaller would be not so nice + merge selection color with the cell and/or document background (Heiko) => assign to Rafael * Support showing combinations of (named) style + direct formatting in Stylist + https://bugs.documentfoundation.org/show_bug.cgi?id=161251 + do not overload simple controls (Cor) + show only on the flat tree like Applied Styles (Eyal) + inspired by MSO's Styles widget which optionally merges all information (PS, CF, DF) into the list (Eyal) + Styles Inspector does the same (Rafael), Styles Highlighter too (Heiko) + reasonable request; feature parity is always good (John) + MSO is not a good example for styling documents (Rafael) + low impact on usability possible, eg. per additional filter that shows applied styles + DF (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu |6 ++ 1 file changed, 6 insertions(+) New commits: commit 22cce3ece004a89e1ed9025437d96f150cc98857 Author: Heiko Tietze AuthorDate: Wed Jun 5 12:29:20 2024 +0200 Commit: Heiko Tietze CommitDate: Wed Jun 5 19:38:48 2024 +0200 Resolves tdf#161293 - Alt+9 shortcut for Find sidebar Change-Id: I5ab6916c7cf065f986117b12ebbb9a15b6c2147e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168469 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu index 73419dee1102..c5f32a4af1d8 100644 --- a/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu @@ -6042,6 +6042,12 @@ Ctrl+Shift+u aka U_SHIFT_MOD1 under GTK/IBUS is for unicode key input .uno:SidebarDeck.A11yCheckDeck + + +L10N SHORTCUTS - NO TRANSLATE +.uno:SidebarDeck.FindDeck + + L10N SHORTCUTS - NO TRANSLATE
core.git: sc/inc sc/qa sc/uiconfig
sc/inc/scfuncs.hrc |2 +-
sc/qa/uitest/validity/tdf138134.py |4 ++--
sc/qa/uitest/validity/tdf150098.py |4 ++--
sc/qa/uitest/validity/validity.py |4 ++--
sc/uiconfig/scalc/ui/validationcriteriapage.ui |2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 199ffecd9586d3a8c3365bdbc979c93600f25899
Author: Heiko Tietze
AuthorDate: Tue Jun 4 09:48:21 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue Jun 4 13:55:44 2024 +0200
Resolves tdf#161395 - Rename Whole Number to Integer
Change-Id: Id4cce115823781e5f2a4870d38d1f456cdf417a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168395
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/inc/scfuncs.hrc b/sc/inc/scfuncs.hrc
index 9f8cce9b0090..7a129a046a11 100644
--- a/sc/inc/scfuncs.hrc
+++ b/sc/inc/scfuncs.hrc
@@ -4248,7 +4248,7 @@ const TranslateId SC_OPCODE_RANDARRAY_ARY[] =
NC_("SC_OPCODE_RANDARRAY", "Max"),
NC_("SC_OPCODE_RANDARRAY", "The upper limit of the generated numbers."),
NC_("SC_OPCODE_RANDARRAY", "Integers"),
-NC_("SC_OPCODE_RANDARRAY", "Return whole numbers (TRUE) or decimal values
(FALSE).")
+NC_("SC_OPCODE_RANDARRAY", "Return integer (TRUE) or decimal (FALSE)
values.")
};
// -=*# Resource for function UNIQUE #*=-
diff --git a/sc/qa/uitest/validity/tdf138134.py
b/sc/qa/uitest/validity/tdf138134.py
index b13da491eb40..5d5023a50519 100644
--- a/sc/qa/uitest/validity/tdf138134.py
+++ b/sc/qa/uitest/validity/tdf138134.py
@@ -25,7 +25,7 @@ class DetectiveCircle(UITestCase):
#Select the cells to be validated
gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A3"}))
-#Apply Data > Validity ... > Whole Numbers
+#Apply Data > Validity ... > Integer
with
self.ui_test.execute_dialog_through_command(".uno:Validation") as xDialog:
xTabs = xDialog.getChild("tabcontrol")
select_pos(xTabs, "0")
@@ -34,7 +34,7 @@ class DetectiveCircle(UITestCase):
xdata = xDialog.getChild("data")
xmin = xDialog.getChild("min")
-select_by_text(xallow, "Whole Numbers")
+select_by_text(xallow, "Integer")
xallowempty.executeAction("CLICK", tuple())
select_by_text(xdata, "equal")
xmin.executeAction("TYPE", mkPropertyValues({"TEXT":"5"}))
diff --git a/sc/qa/uitest/validity/tdf150098.py
b/sc/qa/uitest/validity/tdf150098.py
index 5d29a4afaadf..91384fc61ece 100644
--- a/sc/qa/uitest/validity/tdf150098.py
+++ b/sc/qa/uitest/validity/tdf150098.py
@@ -26,7 +26,7 @@ class EvaluateFormulaInputs(UITestCase):
#Select the cells to be validated
gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A4"}))
-#Apply Data > Validity ... > Whole Numbers
+#Apply Data > Validity ... > Integer
with
self.ui_test.execute_dialog_through_command(".uno:Validation") as xDialog:
xTabs = xDialog.getChild("tabcontrol")
select_pos(xTabs, "0")
@@ -35,7 +35,7 @@ class EvaluateFormulaInputs(UITestCase):
xdata = xDialog.getChild("data")
xmin = xDialog.getChild("min")
-select_by_text(xallow, "Whole Numbers")
+select_by_text(xallow, "Integer")
xallowempty.executeAction("CLICK", tuple())
select_by_text(xdata, "equal")
xmin.executeAction("TYPE", mkPropertyValues({"TEXT":"A3"}))
diff --git a/sc/qa/uitest/validity/validity.py
b/sc/qa/uitest/validity/validity.py
index 3112b7afb91e..158b3905eaba 100644
--- a/sc/qa/uitest/validity/validity.py
+++ b/sc/qa/uitest/validity/validity.py
@@ -29,7 +29,7 @@ class validity(UITestCase):
xmin = xDialog.getChild("min")
xmax = xDialog.getChild("max")
-select_by_text(xallow, "Whole Numbers")
+select_by_text(xallow, "Integer")
xallowempty.executeAction("CLICK", tuple())
select_by_text(xdata, "valid range")
xmin.executeAction("TYPE", mkPropertyValues({"TEXT":"1"}))
@@ -42,7 +42,7 @@ class validity(UITestCase):
xmin = xDialog.getChild("min")
xmax = xDialog.getChild("max&quo
core.git: sc/source
sc/source/ui/view/hdrcont.cxx | 31 +--
sc/source/ui/view/tabview.cxx |2 +-
2 files changed, 14 insertions(+), 19 deletions(-)
New commits:
commit 0a0d3d1f8a34e0b8542c71fe9c3bd3b75d974e7c
Author: Heiko Tietze
AuthorDate: Wed May 29 17:36:08 2024 +0200
Commit: Heiko Tietze
CommitDate: Sat Jun 1 08:41:04 2024 +0200
Resolves tdf#152923 - Make column header outstanding from background
* Background color made darker/lighter depending on system settings
* Separator lines with less contrast (ShadowColor instead of
DarkShadowColor)
* Extra line for selection removed as it extends the actual header
* Todo: Vertical header starts at a few pixels distance to the edge
(patchset 4 fails)
Change-Id: If3c47b77ad0bca2db1c25ec46b488a2e338b8133
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168225
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/source/ui/view/hdrcont.cxx b/sc/source/ui/view/hdrcont.cxx
index ec64067f2507..251f9f6f3cf7 100644
--- a/sc/source/ui/view/hdrcont.cxx
+++ b/sc/source/ui/view/hdrcont.cxx
@@ -321,7 +321,12 @@ void ScHeaderControl::Paint( vcl::RenderContext&
/*rRenderContext*/, const tools
if ( nLineEnd * nLayoutSign >= nInitScrPos * nLayoutSign )
{
-GetOutDev()->SetFillColor( rStyleSettings.GetFaceColor() );
+Color aFaceColor(rStyleSettings.GetFaceColor());
+if (bDark)
+aFaceColor.IncreaseLuminance(20);
+else
+aFaceColor.DecreaseLuminance(20);
+GetOutDev()->SetFillColor( aFaceColor );
if ( bVertical )
aFillRect = tools::Rectangle( 0, nInitScrPos, nBarSize-1, nLineEnd
);
else
@@ -374,26 +379,16 @@ void ScHeaderControl::Paint( vcl::RenderContext&
/*rRenderContext*/, const tools
}
}
-GetOutDev()->SetLineColor( rStyleSettings.GetDarkShadowColor() );
+GetOutDev()->SetLineColor( rStyleSettings.GetShadowColor() );
if (bVertical)
{
-tools::Long nDarkPos = bMirrored ? 0 : nBarSize-1;
-GetOutDev()->DrawLine( Point( nDarkPos, nPStart ), Point(
nDarkPos, nLineEnd ) );
+GetOutDev()->DrawLine( Point( 0, nPStart ), Point( 0, nLineEnd )
); //left
+GetOutDev()->DrawLine( Point( nBarSize-1, nPStart ), Point(
nBarSize-1, nLineEnd ) ); //right
}
else
-GetOutDev()->DrawLine( Point( nPStart, nBarSize-1 ), Point(
nLineEnd, nBarSize-1 ) );
-
-// line in different color for selection
-if ( nTransEnd * nLayoutSign >= nTransStart * nLayoutSign &&
!bHighContrast )
{
-GetOutDev()->SetLineColor(aSelLineColor);
-if (bVertical)
-{
-tools::Long nDarkPos = bMirrored ? 0 : nBarSize-1;
-GetOutDev()->DrawLine( Point( nDarkPos, nTransStart ), Point(
nDarkPos, nTransEnd ) );
-}
-else
-GetOutDev()->DrawLine( Point( nTransStart, nBarSize-1 ),
Point( nTransEnd, nBarSize-1 ) );
+GetOutDev()->DrawLine( Point( nPStart, nBarSize-1 ), Point(
nLineEnd, nBarSize-1 ) ); //bottom
+GetOutDev()->DrawLine( Point( nPStart, 0 ), Point( nLineEnd, 0 )
); //top
}
}
@@ -464,10 +459,10 @@ void ScHeaderControl::Paint( vcl::RenderContext&
/*rRenderContext*/, const tools
{
case SC_HDRPAINT_SEL_BOTTOM:
// same as non-selected for high contrast
-GetOutDev()->SetLineColor( bHighContrast ?
rStyleSettings.GetDarkShadowColor() : aSelLineColor );
+GetOutDev()->SetLineColor( bHighContrast ?
rStyleSettings.GetShadowColor() : aSelLineColor );
break;
case SC_HDRPAINT_BOTTOM:
-GetOutDev()->SetLineColor( rStyleSettings.GetDarkShadowColor()
);
+GetOutDev()->SetLineColor( rStyleSettings.GetShadowColor() );
break;
case SC_HDRPAINT_TEXT:
// DrawSelectionBackground is used only for high contrast on
light background
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 17e4d8859231..8eba950c48ce 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -101,7 +101,7 @@ void ScCornerButton::Paint(vcl::RenderContext&
rRenderContext, const tools::Rect
tools::Long nDarkX = bLayoutRTL ? 0 : nPosX;
// both buttons have the same look now - only dark right/bottom lines
-rRenderContext.SetLineColor(rStyleSettings.GetDarkShadowColor());
+rRenderContext.SetLineColor(rStyleSettings.GetShadowColor());
rRenderContext.DrawLine(Point(0, nPosY), Point(nPosX, nPosY));
rRenderContext.DrawLine(Point(nDarkX, 0), Point(nDarkX, nPosY));
}
core.git: vcl/source
vcl/source/window/printdlg.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 0764a44e185d7b940f442cc054f5f1afd8c5cc64 Author: Heiko Tietze AuthorDate: Fri May 31 09:53:48 2024 +0200 Commit: Heiko Tietze CommitDate: Fri May 31 12:54:45 2024 +0200 Resolves tdf#161082 - Set focus on topmost item (Printer) Change-Id: Ib5b8f2587efaa683a28f1d8298eb9bcba2539705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168280 Reviewed-by: Heiko Tietze Tested-by: Jenkins diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx index f642641a0fc2..faa8d7179cb6 100644 --- a/vcl/source/window/printdlg.cxx +++ b/vcl/source/window/printdlg.cxx @@ -635,9 +635,8 @@ PrintDialog::PrintDialog(weld::Window* i_pWindow, std::shared_ptrgrab_focus(); -mxCopyCountField->select_region(0, -1); +// set initial focus to "Printer" +mxPrinters->grab_focus(); // setup sizes for N-Up Size aNupSize( maPController->getPrinter()->PixelToLogic(
core.git: sc/source
sc/source/ui/view/hdrcont.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 2269b418f7af598ff8194acb9929c8bd6c4baeb1
Author: Heiko Tietze
AuthorDate: Wed May 29 14:09:20 2024 +0200
Commit: Heiko Tietze
CommitDate: Fri May 31 08:17:18 2024 +0200
Resolves tdf#160324 - Larger hitarea for column header
Finalizes patch I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5
Change-Id: Iff5cd4f6252e42cf8fad0aa2f37f70db0b8a15ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168210
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/sc/source/ui/view/hdrcont.cxx b/sc/source/ui/view/hdrcont.cxx
index bf97dbb01f95..ec64067f2507 100644
--- a/sc/source/ui/view/hdrcont.cxx
+++ b/sc/source/ui/view/hdrcont.cxx
@@ -628,9 +628,6 @@ void ScHeaderControl::Paint( vcl::RenderContext&
/*rRenderContext*/, const tools
SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos, bool& rBorder) const
{
-// #define nHitArea 5
-const int nHitArea(
officecfg::Office::Common::Misc::ExperimentalMode::get() ? 5 : 2 );
-
boolbFound = false;
SCCOLROWnPos = GetPos();
SCCOLROWnHitNo = nPos;
@@ -654,7 +651,7 @@ SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos,
bool& rBorder) const
nScrPos += GetEntrySize( nEntryNo - 1 ) * nLayoutSign; //!
GetHiddenCount() ??
nDif = nMousePos - nScrPos;
-if (nDif >= -nHitArea && nDif <= +nHitArea)
+if (nDif >= -5 && nDif <= 5)
{
bFound = true;
nHitNo=nEntryNo-1;
Minutes from the UX/design meeting 2023-May-30
Present: Hossein, Sahil, Heiko Comments: Michael, Stuart, Eyal, Stephane Tickets/Topics * UNO Sidebar 'Hide' and 'Show' sidebar deck (splitwin) -- a new function (available for assigning a shortcut key to it) + https://bugs.documentfoundation.org/show_bug.cgi?id=161037 + switch/toggle tab with alt+ combinations (Michael) + provide a keyboard toggle for the splitwin to collapse (Stuart) + ctrl+f5 closes the sidebar, the close button (x) closes, the special sidebar button minimizes it + overly complex interaction, suggest to not change it (Heiko) + interaction is ambiguous, when the window width is smaller than the sidebar width, the sidebar disappears (Hossein, Sahil) => resolve NAB/WF * Special Find presets with regular expression + https://bugs.documentfoundation.org/show_bug.cgi?id=161029 + sounds good but with limited features (Stuart) + good for an extension (Eyal) + https://extensions.libreoffice.org/en/extensions/show/70066 + no room for presets, dropdown fills with previous searches (Heiko) + regex is complex and a few presets wont help (Hossein) + MS Word has a special dropdown to search for a couple of most often used special characters such as page break or soft hyphen => examples are rather suited for documentation * Provide framework to suppress editing with direct formatting of a styled document, or template + https://bugs.documentfoundation.org/show_bug.cgi?id=153309 + must not force people into styles, WF (Dieter) + Tools > Protect > [x] Allow Direct Formatting (Heiko) + rather per-document/template method (Stuart) + however, we provide all means to hide DF interactions and disable it globally might feel broken (Heiko) + it's possible with MSO (Hossein) => go for it * Print dialog: Put initial focus to "Printer" combobox + https://bugs.documentfoundation.org/show_bug.cgi?id=161082 + change the dialog landing to the "Printer" (Stuart) + keep at copies as this is more frequently changed (Heiko) + similar to MSO, move "number of copies" to the top (Hossein) + switching to the number of copies is easy done per alt+n (Heiko) => follow a11y * Add "Apply" button to all tabs of Table Properties dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=160858 + sidebar/toolbar offer relevant functions (Stephane) + immediate feedback from the apply button is important (Sahil) + consistency is prime, Apply is available for styles but not direct formatting (Hossein) + rather remove the Apply buttons than adding to more dialogs (Hossein) => comment with recommendation to resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-30
Present: Hossein, Sahil, Heiko Comments: Michael, Stuart, Eyal, Stephane Tickets/Topics * UNO Sidebar 'Hide' and 'Show' sidebar deck (splitwin) -- a new function (available for assigning a shortcut key to it) + https://bugs.documentfoundation.org/show_bug.cgi?id=161037 + switch/toggle tab with alt+ combinations (Michael) + provide a keyboard toggle for the splitwin to collapse (Stuart) + ctrl+f5 closes the sidebar, the close button (x) closes, the special sidebar button minimizes it + overly complex interaction, suggest to not change it (Heiko) + interaction is ambiguous, when the window width is smaller than the sidebar width, the sidebar disappears (Hossein, Sahil) => resolve NAB/WF * Special Find presets with regular expression + https://bugs.documentfoundation.org/show_bug.cgi?id=161029 + sounds good but with limited features (Stuart) + good for an extension (Eyal) + https://extensions.libreoffice.org/en/extensions/show/70066 + no room for presets, dropdown fills with previous searches (Heiko) + regex is complex and a few presets wont help (Hossein) + MS Word has a special dropdown to search for a couple of most often used special characters such as page break or soft hyphen => examples are rather suited for documentation * Provide framework to suppress editing with direct formatting of a styled document, or template + https://bugs.documentfoundation.org/show_bug.cgi?id=153309 + must not force people into styles, WF (Dieter) + Tools > Protect > [x] Allow Direct Formatting (Heiko) + rather per-document/template method (Stuart) + however, we provide all means to hide DF interactions and disable it globally might feel broken (Heiko) + it's possible with MSO (Hossein) => go for it * Print dialog: Put initial focus to "Printer" combobox + https://bugs.documentfoundation.org/show_bug.cgi?id=161082 + change the dialog landing to the "Printer" (Stuart) + keep at copies as this is more frequently changed (Heiko) + similar to MSO, move "number of copies" to the top (Hossein) + switching to the number of copies is easy done per alt+n (Heiko) => follow a11y * Add "Apply" button to all tabs of Table Properties dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=160858 + sidebar/toolbar offer relevant functions (Stephane) + immediate feedback from the apply button is important (Sahil) + consistency is prime, Apply is available for styles but not direct formatting (Hossein) + rather remove the Apply buttons than adding to more dialogs (Hossein) => comment with recommendation to resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: include/sfx2 sfx2/source sfx2/uiconfig
include/sfx2/dinfdlg.hxx| 31 ++-
sfx2/source/dialog/dinfdlg.cxx | 130 -
sfx2/uiconfig/ui/descriptioninfopage.ui | 299
sfx2/uiconfig/ui/documentinfopage.ui| 78
sfx2/uiconfig/ui/linefragment.ui| 106 +--
5 files changed, 239 insertions(+), 405 deletions(-)
New commits:
commit 2164406a973fd40fcc56b8839a21854f6b50a53b
Author: Heiko Tietze
AuthorDate: Tue May 28 10:15:43 2024 +0200
Commit: Heiko Tietze
CommitDate: Wed May 29 08:59:02 2024 +0200
Resolves tdf#160937 - Improve dialog size for document properties
linefragment.ui and documentinfopage.ui modified to keep
the usual dialog dimension
Change-Id: I1777e4094e584d676a48855717827aaed413e251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168139
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/sfx2/dinfdlg.hxx b/include/sfx2/dinfdlg.hxx
index d4743ed00ef5..c602a940c6f2 100644
--- a/include/sfx2/dinfdlg.hxx
+++ b/include/sfx2/dinfdlg.hxx
@@ -244,16 +244,31 @@ private:
std::unique_ptr m_xTitleEd;
std::unique_ptr m_xThemaEd;
std::unique_ptr m_xKeywordsEd;
-std::unique_ptr m_xContributorEd;
-std::unique_ptr m_xCoverageEd;
-std::unique_ptr m_xIdentifierEd;
-std::unique_ptr m_xPublisherEd;
-std::unique_ptr m_xRelationEd;
-std::unique_ptr m_xRightsEd;
-std::unique_ptr m_xSourceEd;
-std::unique_ptr m_xTypeEd;
+std::unique_ptr m_xMoreTypes;
+std::unique_ptr m_xMoreValue;
std::unique_ptr m_xCommentEd;
+DECL_LINK(MoreTypesHdl, weld::ComboBox&, void);
+DECL_LINK(MoreValueHdl, weld::Entry&, void);
+
+OUString m_sMoreValue_Contributor;
+OUString m_sMoreValue_Coverage;
+OUString m_sMoreValue_Identifier;
+OUString m_sMoreValue_Publisher;
+OUString m_sMoreValue_Relation;
+OUString m_sMoreValue_Rights;
+OUString m_sMoreValue_Source;
+OUString m_sMoreValue_Type;
+
+OUString m_sMoreValue_Contributor_Stored;
+OUString m_sMoreValue_Coverage_Stored;
+OUString m_sMoreValue_Identifier_Stored;
+OUString m_sMoreValue_Publisher_Stored;
+OUString m_sMoreValue_Relation_Stored;
+OUString m_sMoreValue_Rights_Stored;
+OUString m_sMoreValue_Source_Stored;
+OUString m_sMoreValue_Type_Stored;
+
virtual boolFillItemSet( SfxItemSet* ) override;
virtual voidReset( const SfxItemSet* ) override;
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index b1e5dbd92916..80387eacd85e 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -624,18 +624,14 @@ SfxDocumentDescPage::SfxDocumentDescPage(weld::Container*
pPage, weld::DialogCon
, m_xTitleEd(m_xBuilder->weld_entry(u"title"_ustr))
, m_xThemaEd(m_xBuilder->weld_entry(u"subject"_ustr))
, m_xKeywordsEd(m_xBuilder->weld_entry(u"keywords"_ustr))
-, m_xContributorEd(m_xBuilder->weld_entry(u"contributor"_ustr))
-, m_xCoverageEd(m_xBuilder->weld_entry(u"coverage"_ustr))
-, m_xIdentifierEd(m_xBuilder->weld_entry(u"identifier"_ustr))
-, m_xPublisherEd(m_xBuilder->weld_entry(u"publisher"_ustr))
-, m_xRelationEd(m_xBuilder->weld_entry(u"relation"_ustr))
-, m_xRightsEd(m_xBuilder->weld_entry(u"rights"_ustr))
-, m_xSourceEd(m_xBuilder->weld_entry(u"source"_ustr))
-, m_xTypeEd(m_xBuilder->weld_entry(u"type"_ustr))
+, m_xMoreTypes(m_xBuilder->weld_combo_box("cbMoreTypes"))
+, m_xMoreValue(m_xBuilder->weld_entry("edMoreValue"))
, m_xCommentEd(m_xBuilder->weld_text_view(u"comments"_ustr))
{
-m_xCommentEd->set_size_request(m_xKeywordsEd->get_preferred_size().Width(),
- m_xCommentEd->get_height_rows(16));
+m_xCommentEd->set_size_request(-1,
//m_xKeywordsEd->get_preferred_size().Width(),
+ m_xCommentEd->get_height_rows(8));
+m_xMoreTypes->connect_changed(LINK(this, SfxDocumentDescPage,
MoreTypesHdl));
+m_xMoreValue->connect_changed(LINK(this, SfxDocumentDescPage,
MoreValueHdl));
}
SfxDocumentDescPage::~SfxDocumentDescPage()
@@ -653,14 +649,16 @@ bool SfxDocumentDescPage::FillItemSet(SfxItemSet *rSet)
const bool bTitleMod = m_xTitleEd->get_value_changed_from_saved();
const bool bThemeMod = m_xThemaEd->get_value_changed_from_saved();
const bool bKeywordsMod = m_xKeywordsEd->get_value_changed_from_saved();
-const bool bContributorMod =
m_xContributorEd->get_value_changed_from_saved();
-const bool bCoverageMod = m_xCoverageEd->get_value_changed_from_saved();
-const bool bIdentifierMod =
m_xIdentifierEd->get_value_changed_from_saved();
-const bool bPublisher
core.git: sw/source
sw/source/core/text/porexp.cxx | 53 +++-
sw/source/core/text/porrst.cxx |3 +-
sw/source/core/text/txthyph.cxx | 15 ++-
3 files changed, 42 insertions(+), 29 deletions(-)
New commits:
commit 1e9a5ee8671f9a48894849d3cba4d65afa181554
Author: Heiko Tietze
AuthorDate: Thu May 23 14:58:46 2024 +0200
Commit: Heiko Tietze
CommitDate: Fri May 24 16:30:31 2024 +0200
Resolves tdf161196 - Visibility of formatting marks
* Special indicators such as "°" for no-break space but also
"," for zero width space are hidden if non-printable chars
are disabled
* Special indicators use the same color (NON_PRINTING_CHARACTER_COLOR)
* Hard hyphen becomes blueish with non-printable chars on
* Hard blank as well as hard hyphen are controlled by Formatting Aids >
Non-breaking spaces; and both highlighting and indicator are hidden
with non-printable chars off
Change-Id: Ifa29371587ba44d825e04368c5f5c5bf7ed94c7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167987
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/text/porexp.cxx b/sw/source/core/text/porexp.cxx
index 0884db6fce76..377af4671f2b 100644
--- a/sw/source/core/text/porexp.cxx
+++ b/sw/source/core/text/porexp.cxx
@@ -213,35 +213,34 @@ void SwBlankPortion::Paint( const SwTextPaintInfo )
const
rInf.DrawViewOpt(*this, PortionType::Blank);
SwExpandPortion::Paint(rInf);
-if (m_cChar == CHAR_HARDBLANK)
+if (rInf.GetOpt().IsViewMetaChars() && rInf.GetOpt().IsHardBlank())
{
-if (rInf.GetOpt().IsBlank())
-{
-// Draw tilde or degree sign
-OUString aMarker =
(rInf.GetTextFrame()->GetDoc().getIDocumentSettingAccess()
+// Draw tilde or degree sign
+OUString aMarker = (m_cChar == CHAR_HARDBLANK ?
+
rInf.GetTextFrame()->GetDoc().getIDocumentSettingAccess()
.get(DocumentSettingId::USE_VARIABLE_WIDTH_NBSP)
- ? u"~"_ustr
- : u"°"_ustr);
-
-SwPosSize aMarkerSize(rInf.GetTextSize(aMarker));
-Point aPos(rInf.GetPos());
-
-std::shared_ptr pPortionRect = std::make_shared();
-rInf.CalcRect(*this, pPortionRect.get());
-aPos.AdjustX((pPortionRect->Width() / 2) - (aMarkerSize.Width() /
2));
-
-SwTextPaintInfo aInf(rInf, );
-aInf.SetPos(aPos);
-SwTextPortion aMarkerPor;
-aMarkerPor.Width(aMarkerSize.Width());
-aMarkerPor.Height(aMarkerSize.Height());
-aMarkerPor.SetAscent(GetAscent());
-
-Color colorBackup = aInf.GetFont()->GetColor();
-aInf.GetFont()->SetColor(NON_PRINTING_CHARACTER_COLOR);
-aInf.DrawText(aMarkerPor, TextFrameIndex(aMarker.getLength()),
true);
-aInf.GetFont()->SetColor(colorBackup);
-}
+? u"~"_ustr
+: u"°"_ustr
+: u"-"_ustr); //CHAR_HARDHYPHEN
+
+SwPosSize aMarkerSize(rInf.GetTextSize(aMarker));
+Point aPos(rInf.GetPos());
+
+std::shared_ptr pPortionRect = std::make_shared();
+rInf.CalcRect(*this, pPortionRect.get());
+aPos.AdjustX((pPortionRect->Width() / 2) - (aMarkerSize.Width() / 2));
+
+SwTextPaintInfo aInf(rInf, );
+aInf.SetPos(aPos);
+SwTextPortion aMarkerPor;
+aMarkerPor.Width(aMarkerSize.Width());
+aMarkerPor.Height(aMarkerSize.Height());
+aMarkerPor.SetAscent(GetAscent());
+
+Color colorBackup = aInf.GetFont()->GetColor();
+aInf.GetFont()->SetColor(NON_PRINTING_CHARACTER_COLOR);
+aInf.DrawText(aMarkerPor, TextFrameIndex(aMarker.getLength()), true);
+aInf.GetFont()->SetColor(colorBackup);
}
}
diff --git a/sw/source/core/text/porrst.cxx b/sw/source/core/text/porrst.cxx
index ff1e029ae141..8f0b89852450 100644
--- a/sw/source/core/text/porrst.cxx
+++ b/sw/source/core/text/porrst.cxx
@@ -677,7 +677,7 @@ bool SwHiddenTextPortion::Format( SwTextFormatInfo )
bool SwControlCharPortion::DoPaint(SwTextPaintInfo const& rTextPaintInfo,
OUString & rOutString, SwFont & rTmpFont, int &) const
{
-if (mcChar == CHAR_WJ || !rTextPaintInfo.GetOpt().IsFieldShadings())
+if (mcChar == CHAR_WJ || !rTextPaintInfo.GetOpt().IsViewMetaChars())
{
return false;
}
@@ -696,6 +696,7 @@ bool SwControlCharPortion::DoPaint(SwTextPaintInfo const&
rTextPaintInfo,
}
rTmpFont.SetEscapement( CHAR_ZWSP == mcChar ? DFLT_ESC_AUTO_SUB : -25 );
+rTmpFont.SetColor( NON_PRINTING_CHARACTER_COLOR );
const sal_uInt16 nProp = 40;
r
Minutes from the UX/design meeting 2023-May-22
Present: Eyal, Sahil, John, Heiko Comments: Aron, Jan Tickets/Topics * When you select part of a column with merged cells, all columns that are part of the merged cell are selected + https://bugs.documentfoundation.org/show_bug.cgi?id=158288 + NAB (Aron), + selection should denote/depict the merged cells (Eyal) vs. selection starts on top-left to bottom-right + we are Excel compatible, and actually even better (Heiko) + is a range-selection (not to confuse with multiple cells) meant to include all from x1 to y2; if so the behavior is correct + merged cells take actually the content from the top-left cell + copying of multi-selections is not possible + unclear use case, potentially impacting the workflow of many users (John) => comment with needinfo * Want MS-Word like auto-formatting of beginning of list item + https://bugs.documentfoundation.org/show_bug.cgi?id=158874 + cool stuff (John) + could it be done via extension (Sahil) => do it * Form creating is too niche to merit a main menu item visible by default + https://bugs.documentfoundation.org/show_bug.cgi?id=161031 + rarely used; conditional logic tricky to maintain and test (Jan) + was done to align with other modules, IIRC (Heiko) + changing the main menu is a PITA for users, showing conditionally like "View > [ ] Show Forms Menu" and also "[ ] Show Shapes Menu" is possible but would be quite uncommon; = NAB/WF (Heiko) + no strong opinion (John, Sahil) => resolve WF to safe users from the annoyance of changing menus * FORMCONTROLS: Add ability to Find and Replace field names + https://bugs.documentfoundation.org/show_bug.cgi?id=160938 + intention is to (batch) rename fields, which is not needed (Heiko) + finding controls might make sense for a huge number of items, which is not so likely; and the Navigator lists the content nicely plus will have different sort methods (Heiko, John) + being an ODF editor requires a place to find everything which is defined (Eyal) + F with RegEx works well and might be handy for object names in some cases (Eyal) => both points are valid, keep ticket OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-22
Present: Eyal, Sahil, John, Heiko Comments: Aron, Jan Tickets/Topics * When you select part of a column with merged cells, all columns that are part of the merged cell are selected + https://bugs.documentfoundation.org/show_bug.cgi?id=158288 + NAB (Aron), + selection should denote/depict the merged cells (Eyal) vs. selection starts on top-left to bottom-right + we are Excel compatible, and actually even better (Heiko) + is a range-selection (not to confuse with multiple cells) meant to include all from x1 to y2; if so the behavior is correct + merged cells take actually the content from the top-left cell + copying of multi-selections is not possible + unclear use case, potentially impacting the workflow of many users (John) => comment with needinfo * Want MS-Word like auto-formatting of beginning of list item + https://bugs.documentfoundation.org/show_bug.cgi?id=158874 + cool stuff (John) + could it be done via extension (Sahil) => do it * Form creating is too niche to merit a main menu item visible by default + https://bugs.documentfoundation.org/show_bug.cgi?id=161031 + rarely used; conditional logic tricky to maintain and test (Jan) + was done to align with other modules, IIRC (Heiko) + changing the main menu is a PITA for users, showing conditionally like "View > [ ] Show Forms Menu" and also "[ ] Show Shapes Menu" is possible but would be quite uncommon; = NAB/WF (Heiko) + no strong opinion (John, Sahil) => resolve WF to safe users from the annoyance of changing menus * FORMCONTROLS: Add ability to Find and Replace field names + https://bugs.documentfoundation.org/show_bug.cgi?id=160938 + intention is to (batch) rename fields, which is not needed (Heiko) + finding controls might make sense for a huge number of items, which is not so likely; and the Navigator lists the content nicely plus will have different sort methods (Heiko, John) + being an ODF editor requires a place to find everything which is defined (Eyal) + F with RegEx works well and might be handy for object names in some cases (Eyal) => both points are valid, keep ticket OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/inc cui/Library_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk extras/source include/sfx2 include/unotools officecfg/registry Repository.mk sfx2/sdi sfx2/source vcl/Module_vcl.mk vcl
Repository.mk |1
cui/Library_cui.mk |1
cui/UIConfig_cui.mk|1
cui/inc/whatsnew.hrc | 42 -
cui/source/dialogs/whatsnew.cxx| 172
cui/source/factory/dlgfact.cxx | 14
cui/source/factory/dlgfact.hxx |2
cui/source/inc/whatsnew.hxx| 79 ---
cui/uiconfig/ui/whatsnewdialog.ui | 131 --
dev/null |binary
include/sfx2/sfxdlg.hxx|2
include/sfx2/sfxsids.hrc |3
include/sfx2/strings.hrc |2
include/sfx2/viewfrm.hxx |1
include/unotools/VersionConfig.hxx |5
officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs |6
officecfg/registry/schema/org/openoffice/Setup.xcs |2
sfx2/sdi/appslots.sdi |4
sfx2/sdi/sfx.sdi | 16
sfx2/source/appl/appserv.cxx |9
sfx2/source/dialog/infobar.cxx |2
sfx2/source/view/viewfrm.cxx | 212
+-
vcl/Module_vcl.mk |1
vcl/Package_whatsnew.mk| 20
24 files changed, 124 insertions(+), 604 deletions(-)
New commits:
commit 1bd9747a126a3e82b6093c2b4af3b3a74774a3e9
Author: Heiko Tietze
AuthorDate: Wed May 22 13:18:27 2024 +0200
Commit: Heiko Tietze
CommitDate: Wed May 22 21:19:46 2024 +0200
tdf#161209 - Reverts WhatsNew/Welcome dialog
dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1
Change-Id: Idf0594c546e4d9ca263272ed1534b27948e8e930
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167956
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/Repository.mk b/Repository.mk
index b86eb1bc5646..4a505655d209 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -925,7 +925,6 @@ $(eval $(call gb_Helper_register_packages_for_install,sdk,\
ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE)
$(eval $(call gb_Helper_register_packages_for_install,ooo,\
tipoftheday_images \
- whatsnew_images \
))
endif
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 3ee744e32d0f..e01e33ecb4ec 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -114,7 +114,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
cui/source/customize/SvxNotebookbarConfigPage \
cui/source/customize/CustomNotebookbarGenerator \
cui/source/dialogs/about \
-cui/source/dialogs/whatsnew \
$(call gb_Helper_optional,EXTENSIONS, \
cui/source/dialogs/AdditionsDialog) \
cui/source/dialogs/colorpicker \
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index 79ff7696a93a..10acd83c8c39 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -18,7 +18,6 @@ endif
ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE)
$(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/tipofthedaydialog \
- cui/uiconfig/ui/whatsnewdialog \
))
endif
diff --git a/cui/inc/whatsnew.hrc b/cui/inc/whatsnew.hrc
deleted file mode 100644
index e155a597bcf2..
--- a/cui/inc/whatsnew.hrc
+++ /dev/null
@@ -1,42 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#pragma once
-
-#define NC_(Context, String) TranslateId(Context, u8##String)
-
-#include
-#include
-#include
-#include
-
-/*
- * std:tuple consists of
- * image:
- * place new images at extra/source/whatsnew
- * do not forget to add the files to vcl/Package_whatsnew.mk
- * images are cut-off at 600x400px
-*/
-
-const std::tuple WELCOME_STRINGARRAY[] =
-{
- { NC_("RID_CUI_WHATSNEW", "%PRODUCTNAME is a powerful and free office
suite, used by millions of people around the world."), "LibreOffice.gif"},
- { NC_("RID_CUI_WHATSNEW", "%PRODUCTNAME uses the reliable and trustworthy
standard open document format."), "ODF.png"},
- { NC_("RID_CUI_WHATSNEW", "%PRODUCTNAME blends into every operation
system and provides full customization."), "Configurability.png"},
- { NC
core.git: sw/source sw/uiconfig
sw/source/ui/config/optpage.cxx | 57 -
sw/source/uibase/inc/optpage.hxx|5 -
sw/uiconfig/swriter/ui/optcomparison.ui | 85 +++-
3 files changed, 10 insertions(+), 137 deletions(-)
New commits:
commit 6ddb49bc32c534d196ff3913835aceb88cbc8dfc
Author: Heiko Tietze
AuthorDate: Tue May 21 10:00:44 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue May 21 15:33:34 2024 +0200
Resolves tdf#160834 - Unclear meaning of "Ignore pieces of length"
Access in the UI removed
Find the options under ooO.Writer.Comparison.IgnoreLength and IgnorePieces
Change-Id: Ic76277ba6838bf5cf858089303f4882bc9a7c2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167888
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/sw/source/ui/config/optpage.cxx b/sw/source/ui/config/optpage.cxx
index 6ca432acc34e..089942b5eeb0 100644
--- a/sw/source/ui/config/optpage.cxx
+++ b/sw/source/ui/config/optpage.cxx
@@ -2577,10 +2577,6 @@
SwCompareOptionsTabPage::SwCompareOptionsTabPage(weld::Container* pPage, weld::D
, m_xCompareModeImg(m_xBuilder->weld_widget("lockcomparemode"))
, m_xRsidCB(m_xBuilder->weld_check_button("useRSID"))
, m_xRsidImg(m_xBuilder->weld_widget("lockuseRSID"))
-, m_xIgnoreCB(m_xBuilder->weld_check_button("ignore"))
-, m_xIgnoreImg(m_xBuilder->weld_widget("lockignore"))
-, m_xLenNF(m_xBuilder->weld_spin_button("ignorelen"))
-, m_xLenImg(m_xBuilder->weld_widget("lockignorelen"))
, m_xStoreRsidCB(m_xBuilder->weld_check_button("storeRSID"))
, m_xStoreRsidImg(m_xBuilder->weld_widget("lockstoreRSID"))
{
@@ -2588,8 +2584,6 @@
SwCompareOptionsTabPage::SwCompareOptionsTabPage(weld::Container* pPage, weld::D
m_xAutoRB->connect_toggled( aLnk );
m_xWordRB->connect_toggled( aLnk );
m_xCharRB->connect_toggled( aLnk );
-
-m_xIgnoreCB->connect_toggled( LINK( this, SwCompareOptionsTabPage,
IgnoreHdl) );
}
SwCompareOptionsTabPage::~SwCompareOptionsTabPage()
@@ -2612,14 +2606,6 @@ OUString SwCompareOptionsTabPage::GetAllStrings()
sAllStrings += pString->get_label() + " ";
}
-OUString checkButton[] = { "useRSID", "ignore", "storeRSID" };
-
-for (const auto& check : checkButton)
-{
-if (const auto& pString = m_xBuilder->weld_check_button(check))
-sAllStrings += pString->get_label() + " ";
-}
-
OUString radioButton[] = { "auto", "byword", "bycharacter" };
for (const auto& radio : radioButton)
@@ -2656,18 +2642,6 @@ bool SwCompareOptionsTabPage::FillItemSet( SfxItemSet* )
bRet = true;
}
-if( m_xIgnoreCB->get_state_changed_from_saved() )
-{
-pOpt->SetIgnorePieces( m_xIgnoreCB->get_active() );
-bRet = true;
-}
-
-if( m_xLenNF->get_value_changed_from_saved() )
-{
-pOpt->SetPieceLen( m_xLenNF->get_value() );
-bRet = true;
-}
-
if (m_xStoreRsidCB->get_state_changed_from_saved())
{
pOpt->SetStoreRsid(m_xStoreRsidCB->get_active());
@@ -2686,22 +2660,16 @@ void SwCompareOptionsTabPage::Reset( const SfxItemSet* )
{
m_xAutoRB->set_active(true);
m_xRsidCB->set_sensitive(false);
-m_xIgnoreCB->set_sensitive(false);
-m_xLenNF->set_sensitive(false);
}
else if( eCmpMode == SwCompareMode::ByWord )
{
m_xWordRB->set_active(true);
m_xRsidCB->set_sensitive(true);
-m_xIgnoreCB->set_sensitive(true);
-m_xLenNF->set_sensitive(true);
}
else if( eCmpMode == SwCompareMode::ByChar)
{
m_xCharRB->set_active(true);
m_xRsidCB->set_sensitive(true);
-m_xIgnoreCB->set_sensitive(true);
-m_xLenNF->set_sensitive(true);
}
if (officecfg::Office::Writer::Comparison::Mode::isReadOnly())
@@ -2724,24 +2692,6 @@ void SwCompareOptionsTabPage::Reset( const SfxItemSet* )
}
m_xRsidCB->save_state();
-m_xIgnoreCB->set_active( pOpt->IsIgnorePieces() );
-if (officecfg::Office::Writer::Comparison::IgnorePieces::isReadOnly())
-{
-m_xIgnoreCB->set_sensitive(false);
-m_xIgnoreImg->set_visible(true);
-}
-m_xIgnoreCB->save_state();
-
-m_xLenNF->set_sensitive( m_xIgnoreCB->get_active() && eCmpMode !=
SwCompareMode::Auto );
-
-m_xLenNF->set_value( pOpt->GetPieceLen() );
-if (officecfg::Office::Writer::Comparison::IgnoreLength::isReadOnly())
-{
-m_xLenNF->set_sensitive(false);
-m_xLenImg->set_visible(true);
-}
-m_xLenNF->save_value();
-
m_xStoreRsidCB->set_active(pOpt->
Re: Build fail in mariadb on fedora 40
On 18.05.24 2:51 PM, Dr. David Alan Gilbert wrote: It looks like others started hitting it; see: https://gerrit.libreoffice.org/c/core/+/167806 Run into the same issue on a VM with Arch Linux. Latest master compiles now flawless. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-16
Present: Rafael, Sahil, Cor, Heiko, Hossein Comments: Stuart, Eyal, Ady Tickets/Topics * Add .uno:VRuler button to NB Tabbed/Tabbed Compact cutomize View list + https://bugs.documentfoundation.org/show_bug.cgi?id=160694 + use main menu (Stuart) + suggest to split uno:Rulers into VRuler and HRuler and make the two individual settings in tools > options > view as well as a dropdown with both options in the tabbed NB (and the classic UI) (Rafael, Hossein) + If you click on the button, it enable/disable both. But it you choose dropdown, you should be able to select horizontal/vertical separately and check/uncheck them. + vertical ruler are rather a frequently changed option and don't deserve a main spot on the UI (Heiko) => majority for the dropdown solution * Quickfind sidebar: Make the sidebar the default for ctrl+F + https://bugs.documentfoundation.org/show_bug.cgi?id=160544 + not replacement but supplement; unfinished and not appealing (Stuart, Eyal) + matter of how the state of the sidebar is preserved after using (Cor) + option to switch makes sense (Rafael, Cor) + unfinished, at least accessibility needs improvements (Rafael) => add the option but leave the current quickfind as default * Allow choosing the page style from the sheets tab + https://bugs.documentfoundation.org/show_bug.cgi?id=160920 + simplifying not needed as this is an expert workflow (Stuart) + page style can be changed via status bar > page style dialog (Ady) + but not picked, which is the case in Writer (right click on status bar) (Cor) + Writer lists the available PgS per right click on the SB and allows to pick one; makes sense to add in Calc too (Rafael) + easy hackable (Sahil) + willing to look into this one (Cor) => do it * Right clicking on selected text unselects it if the cursor is on a misspelled word + https://bugs.documentfoundation.org/show_bug.cgi?id=98902 + same workflow as LibO in MS Word (Hossein) + suggested selection of the misspelled word is superior (Hossein) + drawback is that we cannot check phrases anymore, or can we? (Heiko) + maybe ctrl + right click for spell checking (Sahil) + bug reporter was unhappy with Impress, which is wrong and WF (Rafael, Hossein) + but rather unhappy about the inconsistency, which is an issue (Sahil) + to remove the selection might be "surprising" to users and we could add some additional overlay color as MSO does (grey for select + red on hover for spellcheck issue) (Hossein) => needsDevAdvice OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-16
Present: Rafael, Sahil, Cor, Heiko, Hossein Comments: Stuart, Eyal, Ady Tickets/Topics * Add .uno:VRuler button to NB Tabbed/Tabbed Compact cutomize View list + https://bugs.documentfoundation.org/show_bug.cgi?id=160694 + use main menu (Stuart) + suggest to split uno:Rulers into VRuler and HRuler and make the two individual settings in tools > options > view as well as a dropdown with both options in the tabbed NB (and the classic UI) (Rafael, Hossein) + If you click on the button, it enable/disable both. But it you choose dropdown, you should be able to select horizontal/vertical separately and check/uncheck them. + vertical ruler are rather a frequently changed option and don't deserve a main spot on the UI (Heiko) => majority for the dropdown solution * Quickfind sidebar: Make the sidebar the default for ctrl+F + https://bugs.documentfoundation.org/show_bug.cgi?id=160544 + not replacement but supplement; unfinished and not appealing (Stuart, Eyal) + matter of how the state of the sidebar is preserved after using (Cor) + option to switch makes sense (Rafael, Cor) + unfinished, at least accessibility needs improvements (Rafael) => add the option but leave the current quickfind as default * Allow choosing the page style from the sheets tab + https://bugs.documentfoundation.org/show_bug.cgi?id=160920 + simplifying not needed as this is an expert workflow (Stuart) + page style can be changed via status bar > page style dialog (Ady) + but not picked, which is the case in Writer (right click on status bar) (Cor) + Writer lists the available PgS per right click on the SB and allows to pick one; makes sense to add in Calc too (Rafael) + easy hackable (Sahil) + willing to look into this one (Cor) => do it * Right clicking on selected text unselects it if the cursor is on a misspelled word + https://bugs.documentfoundation.org/show_bug.cgi?id=98902 + same workflow as LibO in MS Word (Hossein) + suggested selection of the misspelled word is superior (Hossein) + drawback is that we cannot check phrases anymore, or can we? (Heiko) + maybe ctrl + right click for spell checking (Sahil) + bug reporter was unhappy with Impress, which is wrong and WF (Rafael, Hossein) + but rather unhappy about the inconsistency, which is an issue (Sahil) + to remove the selection might be "surprising" to users and we could add some additional overlay color as MSO does (grey for select + red on hover for spellcheck issue) (Hossein) => needsDevAdvice OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/source
cui/source/dialogs/whatsnew.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 7fc7d3b9fe6eabeddf43fbf72a041854fda51b27
Author: Heiko Tietze
AuthorDate: Thu May 16 10:24:20 2024 +0200
Commit: Heiko Tietze
CommitDate: Thu May 16 12:49:47 2024 +0200
Related tdf#159573 - WhatsNew dialog: 1px glitch with Wayland
Change-Id: I6565fa32f4484e74abecc795c67e7afa13f7f55b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167734
Reviewed-by: Heiko Tietze
Tested-by: Jenkins
diff --git a/cui/source/dialogs/whatsnew.cxx b/cui/source/dialogs/whatsnew.cxx
index 6092b7e4af50..5136c62f33ca 100644
--- a/cui/source/dialogs/whatsnew.cxx
+++ b/cui/source/dialogs/whatsnew.cxx
@@ -155,7 +155,7 @@ void WhatsNewProgress::Paint(vcl::RenderContext&
rRenderContext, const tools::Re
rRenderContext.Erase();
rRenderContext.SetAntialiasing(AntialiasingFlags::Enable);
-tools::Rectangle aRect(Point(0, 0), Size(PROGRESS_DOTSIZE,
PROGRESS_DOTSIZE));
+tools::Rectangle aRect(Point(1, 1), Size(PROGRESS_DOTSIZE,
PROGRESS_DOTSIZE));
for (sal_Int32 i = 0; i < m_nTotal; i++)
{
if (i == m_nCurrent)
Re: [libreoffice-design] Re: behavior of new functions XLOOKUP and XMATCH
Re-adding the dev ML; Regina's full reply at https://listarchives.libreoffice.org/global/design/2024/msg00045.html On 15.05.24 2:03 AM, Regina Henschel wrote: The problem is, what should be the output, when the user sets Match_mode 2 together with Search_mode 2 or -2. Excel returns #VALUE! for the combination =XLOOKUP(C3;A$1:A$3;B$1:B$3;"INV";2;2) while we do some processing. On 14.05.24 5:04 AM, Mike Kaganski wrote: Emitting error is the only sane way here.Absolutely. It is not some kind of interruptive error box but a typical way to give feedback on typos or for unspecified content. Silently switching to some other way of processing is almost impossible to understand for users. And I cannot follow the arguments that no error message makes the handling easier. If you want, we can run a poll what users prefer. OpenPGP_signature.asc Description: OpenPGP digital signature
Re: behavior of new functions XLOOKUP and XMATCH
Correct me but =XLOOKUP(C3;A$1:A$3;B$1:B$3;"INV";_3_;1) returns #VALUE! (Excel) or Err:504 (LO) =_Y_LOOKUP(C4;A$1:A$3;B$1:B$3;"INV";0;1) returns #NAME? (both) What exactly will change? PS: ux-advice@ is the forward mailing list from Bugzilla and I'm not sure how many people have registered. Rather use design@ for input from the UI/UX group. On 14.05.24 12:23 AM, Regina Henschel wrote: Hi UX-experts, the new function XLOOKUP and XMATCH have a Match_mode with values 0, 1, -1, 2 and a Search_mode with values 1, -1, 2, -2. The Match_mode 2 means wildcard mode, that is ? * search or regular expressions search. The Search_modes 2 and -2 mean binary search in a sorted array. Combining parameter values for wildcard mode and binary search is possible. But there exist no way to actually do it. Excel gives an error messages in such cases. LibreOffice silently switches to linear search. The ODF TC is currently working on the specification for these new functions. The TC could either follow Excel's way or LibreOffice's way. From a developer state of view it is no large effort to change the current behavior of LibreOffice. The TC does not know yet whether Microsoft would be willing to switch to LibreOffice's behavior. I write to you for to get your opinion what will be the best solution from a _user_ point of view. Some arguments so far: * No error message would make use of the functions in macros and forms easier. * No error message might be better for using the functions in automatically calculations without UI. * Using linear search can be unexpected slow on a huge Lookup_array. An error message makes the problem visible to the user. I would love to hear your opinion. Kind regards, Regina -- Dr. Heiko Tietze, UX-Architect and UI-Designer Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-08
Present: Sahil, John, Hossein, Cor, Eyal, Heiko Comments: Stuart, Stephane, Dieter Tickets/Topics * Major design changes ongoing for "Better handling for multiline tabs + https://bugs.documentfoundation.org/show_bug.cgi?id=99528 * List images in order of document appearance in Calc Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=160353 + at least four different sort orders: row first, col first, alphabetically, by insertion time (Heiko) + limited use case (John) + Navigator lists objects from all sheets making the sort order problematic (John) + maybe reported somewhere; unclear if users accept when the Navigator restricts objects to the current sheet => keep with low priority * Icons for promote / demote outline level should be improved + https://bugs.documentfoundation.org/show_bug.cgi?id=158932 + clear depiction of the action (Stuart) + there are issues with RTL UI (Hossein) + dup at https://bugs.documentfoundation.org/show_bug.cgi?id=154523 + see also https://bugs.documentfoundation.org/show_bug.cgi?id=70102 => duplicate * Print multiple non-contiguous print ranges on a single page in LibreOffice Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=160610 + prone to complications; (cumbersome) alternatives possible (Stephané) + hiding rows is possibly a proper workaround for the rare need (Cor) => suggest WF if there's no clear response * Print (or export) only tracked changes + https://bugs.documentfoundation.org/show_bug.cgi?id=160497 + sidebar lists all TC (Dieter) + macro on ask.libo solves the use case (Heiko) + reasonable use case for some (Cor, John) + but macro is a good solution => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-08
Present: Sahil, John, Hossein, Cor, Eyal, Heiko Comments: Stuart, Stephane, Dieter Tickets/Topics * Major design changes ongoing for "Better handling for multiline tabs + https://bugs.documentfoundation.org/show_bug.cgi?id=99528 * List images in order of document appearance in Calc Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=160353 + at least four different sort orders: row first, col first, alphabetically, by insertion time (Heiko) + limited use case (John) + Navigator lists objects from all sheets making the sort order problematic (John) + maybe reported somewhere; unclear if users accept when the Navigator restricts objects to the current sheet => keep with low priority * Icons for promote / demote outline level should be improved + https://bugs.documentfoundation.org/show_bug.cgi?id=158932 + clear depiction of the action (Stuart) + there are issues with RTL UI (Hossein) + dup at https://bugs.documentfoundation.org/show_bug.cgi?id=154523 + see also https://bugs.documentfoundation.org/show_bug.cgi?id=70102 => duplicate * Print multiple non-contiguous print ranges on a single page in LibreOffice Calc + https://bugs.documentfoundation.org/show_bug.cgi?id=160610 + prone to complications; (cumbersome) alternatives possible (Stephané) + hiding rows is possibly a proper workaround for the rare need (Cor) => suggest WF if there's no clear response * Print (or export) only tracked changes + https://bugs.documentfoundation.org/show_bug.cgi?id=160497 + sidebar lists all TC (Dieter) + macro on ask.libo solves the use case (Heiko) + reasonable use case for some (Cor, John) + but macro is a good solution => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sc/source
sc/source/ui/view/hdrcont.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit f1d69a84ac82034d7f98877780c549f06d93792d
Author: Heiko Tietze
AuthorDate: Fri May 3 11:16:40 2024 +0200
Commit: Heiko Tietze
CommitDate: Tue May 7 15:49:22 2024 +0200
Resolves tdf#160324 - Larger hit area for col/row resize actions
Tentative solution made optional depending on experimental settings
Change-Id: I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167041
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/source/ui/view/hdrcont.cxx b/sc/source/ui/view/hdrcont.cxx
index 98ebabb702c3..bf97dbb01f95 100644
--- a/sc/source/ui/view/hdrcont.cxx
+++ b/sc/source/ui/view/hdrcont.cxx
@@ -35,6 +35,7 @@
#include
#include
#include
+#include
#define SC_DRAG_MIN 2
@@ -627,6 +628,9 @@ void ScHeaderControl::Paint( vcl::RenderContext&
/*rRenderContext*/, const tools
SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos, bool& rBorder) const
{
+// #define nHitArea 5
+const int nHitArea(
officecfg::Office::Common::Misc::ExperimentalMode::get() ? 5 : 2 );
+
boolbFound = false;
SCCOLROWnPos = GetPos();
SCCOLROWnHitNo = nPos;
@@ -650,7 +654,7 @@ SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos,
bool& rBorder) const
nScrPos += GetEntrySize( nEntryNo - 1 ) * nLayoutSign; //!
GetHiddenCount() ??
nDif = nMousePos - nScrPos;
-if (nDif >= -2 && nDif <= 2)
+if (nDif >= -nHitArea && nDif <= +nHitArea)
{
bFound = true;
nHitNo=nEntryNo-1;
core.git: officecfg/registry sc/inc sc/source sc/uiconfig
officecfg/registry/schema/org/openoffice/Office/Calc.xcs | 10 ++ sc/inc/ViewSettingsSequenceDefines.hxx | 35 +- sc/inc/unonames.hxx |1 sc/inc/viewopti.hxx |1 sc/source/core/data/postit.cxx |4 - sc/source/core/tool/viewopti.cxx | 21 -- sc/source/ui/inc/tpview.hxx |2 sc/source/ui/optdlg/tpview.cxx | 11 +++ sc/source/ui/unoobj/confuno.cxx |5 + sc/source/ui/unoobj/viewuno.cxx |4 + sc/source/ui/view/viewdata.cxx |4 + sc/uiconfig/scalc/ui/tpviewpage.ui | 52 +++ 12 files changed, 112 insertions(+), 38 deletions(-) New commits: commit a5d0114bbb40f5bffcb19d6e6b3a5bf43aab1446 Author: Heiko Tietze AuthorDate: Tue May 7 08:56:07 2024 +0200 Commit: Heiko Tietze CommitDate: Tue May 7 15:48:04 2024 +0200 Resolves tdf#156885 - Make comment authorship optional Change-Id: I3422c9e5606fa9eb9aa450f518af8426e598ab8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167260 Tested-by: Jenkins Reviewed-by: Balazs Varga Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs index fb6edf076f17..7303d1bacd00 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs @@ -106,13 +106,21 @@ true - + If less than 1, the size of comment indicator is calculated dynamically; otherwise this value will be used. Comment indicator size 0 + + + +Indicates whether authorship metadata for comments on hover are shown. +Comment authorship + + true + diff --git a/sc/inc/ViewSettingsSequenceDefines.hxx b/sc/inc/ViewSettingsSequenceDefines.hxx index 0c04aa594e68..1cb2b59eb9fc 100644 --- a/sc/inc/ViewSettingsSequenceDefines.hxx +++ b/sc/inc/ViewSettingsSequenceDefines.hxx @@ -24,7 +24,7 @@ // this are the defines for the position of the settings in the // ViewSettingsSequence -#define SC_VIEWSETTINGS_COUNT 26 +#define SC_VIEWSETTINGS_COUNT 27 #define SC_VIEW_ID 0 #define SC_TABLE_VIEWSETTINGS 1 @@ -36,22 +36,23 @@ #define SC_PAGE_BREAK_PREVIEW 7 #define SC_SHOWZERO 8 #define SC_SHOWNOTES9 -#define SC_SHOWFORMULASMARKS10 -#define SC_SHOWGRID 11 -#define SC_GRIDCOLOR12 -#define SC_SHOWPAGEBR 13 -#define SC_COLROWHDR14 -#define SC_SHEETTABS15 -#define SC_OUTLSYMB 16 -#define SC_VALUE_HIGHLIGHTING 17 -#define SC_SNAPTORASTER 18 -#define SC_RASTERVIS19 -#define SC_RASTERRESX 20 -#define SC_RASTERRESY 21 -#define SC_RASTERSUBX 22 -#define SC_RASTERSUBY 23 -#define SC_RASTERSYNC 24 -#define SC_FORMULA_BAR_HEIGHT 25 +#define SC_SHOWNOTEAUTHOR 10 +#define SC_SHOWFORMULASMARKS11 +#define SC_SHOWGRID 12 +#define SC_GRIDCOLOR13 +#define SC_SHOWPAGEBR 14 +#define SC_COLROWHDR15 +#define SC_SHEETTABS16 +#define SC_OUTLSYMB 17 +#define SC_VALUE_HIGHLIGHTING 18 +#define SC_SNAPTORASTER 19 +#define SC_RASTERVIS20 +#define SC_RASTERRESX 21 +#define SC_RASTERRESY 22 +#define SC_RASTERSUBX 23 +#define SC_RASTERSUBY 24 +#define SC_RASTERSYNC 25 +#define SC_FORMULA_BAR_HEIGHT 26 // this are the defines for the position of the settings in the // TableViewSettingsSequence diff --git a/sc/inc/unonames.hxx b/sc/inc/unonames.hxx index 07c9c39ace30..13bb2600f471 100644 --- a/sc/inc/unonames.hxx +++ b/sc/inc/unonames.hxx @@ -561,6 +561,7 @@ inline constexpr OUString SC_UNO_SHOWFORM = u"ShowFormulas"_ustr; inline constexpr OUString SC_UNO_SHOWGRID = u"ShowGrid"_ustr; inline constexpr OUString SC_UNO_SHOWHELP = u"ShowHelpLines"_ustr; inline constexpr OUString S
core.git: svtools/source
svtools/source/control/valueset.cxx | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
New commits:
commit abccf22947294cfc2d9c4b727b7fd059bed55f0b
Author: Heiko Tietze
AuthorDate: Tue Apr 30 10:23:34 2024 +0200
Commit: Heiko Tietze
CommitDate: Mon May 6 16:26:13 2024 +0200
Resolves tdf#136917 - Focus rectangle barely visible on toolbar widgets
eg. Toggle Unordered List
Change-Id: I9298fcbcbf715402a59c7a8ccaa2cd341e7cda8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166916
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/svtools/source/control/valueset.cxx
b/svtools/source/control/valueset.cxx
index 0127ea7a1901..58364b4aebfc 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -29,6 +29,7 @@
#include
#include
#include
+#include
#include
#include
@@ -1255,9 +1256,15 @@ void ValueSet::ImplDrawSelect(vcl::RenderContext&
rRenderContext,
if (bDrawSel)
{
rRenderContext.SetLineColor(aDoubleColor);
-tools::PolyPolygon aPolyPoly(1);
-aPolyPoly.Insert(tools::Polygon(aRect));
-rRenderContext.DrawTransparent(aPolyPoly, nTransparencePercent);
+aRect.AdjustLeft( -1 );
+aRect.AdjustTop( -1 );
+aRect.AdjustRight( -2 );
+aRect.AdjustBottom( -2 );
+
+const tools::Polygon aPoly(aRect);
+LineInfo aLineInfo;
+aLineInfo.SetWidth(3);
+rRenderContext.DrawPolyLine(aPoly, aLineInfo); // tdf#136917
}
}
else
@@ -1343,6 +1350,7 @@ void ValueSet::ImplDrawSelect(vcl::RenderContext&
rRenderContext,
rRenderContext.SetLineColor(aSingleColor);
else
rRenderContext.SetLineColor(COL_LIGHTGRAY);
+
rRenderContext.DrawRect(aFocusRect);
}
}
Re: [TDF Community] [Board Discuss] LibreOffice - peer2peer collaboration bits
On 05.05.24 12:51 PM, Julien Nabet wrote: Before talking about technical architecture, is there a real will about this? Are there enough financial resources for this? There is will by at least some, see https://community.documentfoundation.org/t/budget-request-for-a-p2p-libreoffice-project/12016 The numbers are purely random to me as long we have no idea of the scope. And I believe it's an average "Eve" end-user scenario since users with free and open LibreOffice can connect to business environment such as COOL using the desktop or mobile application. OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [TDF Community] [Board Discuss] LibreOffice - peer2peer collaboration bits
On 04.05.24 12:05 PM, Thorsten Behrens wrote: Heiko wrote: How to connect two or more individuals? It requires routing ... What could be achievable on TDF infrastructure? Given what I've said above - let's try to make this completely independent of TDF infrastructure. Either with no switching-server at all or with something minimal that hopefully might not even need TDF continuously maintaining a server. Note that maintenance by us also has privacy implications, much more so than third-party-less P2P. Yup. At any rate, requiring any kind of centralized server infrastructure has inevitable scalability challenges. It would still be useful if TDF could help with bootstrapping whatever server infrastructure will be needed, though. I believe it's crucial for the success to have this networking open and free for everyone. And I cannot think of many alternatives to TDF, hosting the discovery and handshake around LibreOffice Technology. While we clearly should not route the actual content through the server for privacy and performance reason, it needs to be some kind of registration to allow connections at a random end-point and to join one and more other to this address. Probably not a big deal to do the connection and to establish some kind of server-client networking, and maybe existing protocols provide all the necessary stuff but I wonder how well it scales. Is average customer hardware capable to keep track of 1M users at the same time? Or 100M? Given all that is possible, are there non-technical implications that requires us to govern the process? OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-02
Present: Sahil, Eyal, Cor, Heiko Comments: Seth, Stephane, Stuart, Jim Tickets/Topics * Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Recency" + https://bugs.documentfoundation.org/show_bug.cgi?id=160732 + "Position History" (Seth, Stuart, Jim, Eyal) + also in the Navigator dropdown (Stephane, Jim, Stuart) => no concerns, do it * Implement "recency" navigation for Calc module and make available from TB or Sidebar Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=160505 + limit to named ranges, objects, etc. but not every cell (Heiko) + request does not seem to have a significant/compelling use case (Cor) + Can identify a reasonable use case, not sure about how frequently it's encountered. Would like to have heard more from Petros (Eyal) + no harm in having such a feature though => keep it with low priority * Column resize handle touch-target too small + https://bugs.documentfoundation.org/show_bug.cgi?id=160324 + it is about 3-4 px and should be larger (Miguel, Michael, Eyal) + perhaps make it zoom dependent (Heiko) + wonder if the hit-area is dpi-dependent (Heiko) + might be problematic for hidden or small columns (Heiko) + we should test it (Cor) => give it a try * Offer to download & install missing fonts from online sources + https://bugs.documentfoundation.org/show_bug.cgi?id=159950 + TDF cannot host non-free fonts, cloud-sharing might work (Stuart) + unclear what 'relevant online sources' means (Cor) + ideally to be done per extension, either storing content on the TDF site or as forward request (Heiko) + font management is rather up to the OS/DE; we may support this (Heiko) + extension is not least not the solution therefore since we would download the ttf/otf and execute the system's installer (Eyal) + repository should allow downloading of plain font to make easy installation possible (Eyal) + topic has been discussed extensively before, eg in tdf#78186, 91886, 113496, or 146291 (Heiko) + see also https://design.blog.documentfoundation.org/2016/10/21/dealing-with-missing-fonts/ => feature is definitely desirable and ideally become combined with a previously filed ticket OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-May-02
Present: Sahil, Eyal, Cor, Heiko Comments: Seth, Stephane, Stuart, Jim Tickets/Topics * Rename "Navigation" toolbar to clarify its role, avoid confusion, and relate to "Recency" + https://bugs.documentfoundation.org/show_bug.cgi?id=160732 + "Position History" (Seth, Stuart, Jim, Eyal) + also in the Navigator dropdown (Stephane, Jim, Stuart) => no concerns, do it * Implement "recency" navigation for Calc module and make available from TB or Sidebar Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=160505 + limit to named ranges, objects, etc. but not every cell (Heiko) + request does not seem to have a significant/compelling use case (Cor) + Can identify a reasonable use case, not sure about how frequently it's encountered. Would like to have heard more from Petros (Eyal) + no harm in having such a feature though => keep it with low priority * Column resize handle touch-target too small + https://bugs.documentfoundation.org/show_bug.cgi?id=160324 + it is about 3-4 px and should be larger (Miguel, Michael, Eyal) + perhaps make it zoom dependent (Heiko) + wonder if the hit-area is dpi-dependent (Heiko) + might be problematic for hidden or small columns (Heiko) + we should test it (Cor) => give it a try * Offer to download & install missing fonts from online sources + https://bugs.documentfoundation.org/show_bug.cgi?id=159950 + TDF cannot host non-free fonts, cloud-sharing might work (Stuart) + unclear what 'relevant online sources' means (Cor) + ideally to be done per extension, either storing content on the TDF site or as forward request (Heiko) + font management is rather up to the OS/DE; we may support this (Heiko) + extension is not least not the solution therefore since we would download the ttf/otf and execute the system's installer (Eyal) + repository should allow downloading of plain font to make easy installation possible (Eyal) + topic has been discussed extensively before, eg in tdf#78186, 91886, 113496, or 146291 (Heiko) + see also https://design.blog.documentfoundation.org/2016/10/21/dealing-with-missing-fonts/ => feature is definitely desirable and ideally become combined with a previously filed ticket OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-24-2' - cui/uiconfig
cui/uiconfig/ui/optviewpage.ui |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 77be21b5bd0bd339b2e629f5ec5ee00887033781 Author: Heiko Tietze AuthorDate: Tue Apr 30 09:33:22 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Thu May 2 05:25:26 2024 +0200 Resolves tdf#141778 - Size issues on view options UI Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166894 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/cui/uiconfig/ui/optviewpage.ui b/cui/uiconfig/ui/optviewpage.ui index ce89f11d4d2c..6ad847830136 100644 --- a/cui/uiconfig/ui/optviewpage.ui +++ b/cui/uiconfig/ui/optviewpage.ui @@ -1,5 +1,5 @@ - + @@ -27,7 +27,6 @@ True False -True 12
core.git: cui/uiconfig
cui/uiconfig/ui/optviewpage.ui |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 358b281a39c6599aa2054a9cf60aa6712e832150 Author: Heiko Tietze AuthorDate: Tue Apr 30 09:33:22 2024 +0200 Commit: Heiko Tietze CommitDate: Wed May 1 09:26:29 2024 +0200 Resolves tdf#141778 - Size issues on view options UI Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166885 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/optviewpage.ui b/cui/uiconfig/ui/optviewpage.ui index ce89f11d4d2c..6ad847830136 100644 --- a/cui/uiconfig/ui/optviewpage.ui +++ b/cui/uiconfig/ui/optviewpage.ui @@ -1,5 +1,5 @@ - + @@ -27,7 +27,6 @@ True False -True 12
core.git: sc/source
sc/source/ui/view/gridwin.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 9e7d70230212ab95cda957a0fe51e37f7ca95021 Author: Heiko Tietze AuthorDate: Mon Apr 29 16:29:57 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Tue Apr 30 09:21:45 2024 +0200 Related tdf#143733 - Cell focus must not cover content This patch moves the cell focus rectangle outside the active cell, relative to the zoom factor Change-Id: I9df98125d5c0e571af841442d4db8f02d3c05487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166870 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index 1b7c16f1884b..2762929ccb9b 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -6589,11 +6589,15 @@ void ScGridWindow::UpdateCursorOverlay() tools::Long nSizeYPix; mrViewData.GetMergeSizePixel( nX, nY, nSizeXPix, nSizeYPix ); +const double nAdjustBorder(mrViewData.GetZoomX() * 3); +aScrPos.AdjustX(-nAdjustBorder); +aScrPos.AdjustY(-nAdjustBorder); + if (bLayoutRTL) aScrPos.AdjustX( -(nSizeXPix - 2) ); // move instead of mirroring // show the cursor as 4 (thin) rectangles -tools::Rectangle aRect(aScrPos, Size(nSizeXPix - 1, nSizeYPix - 1)); +tools::Rectangle aRect(aScrPos, Size(nSizeXPix + 2*nAdjustBorder, nSizeYPix + 2*nAdjustBorder)); float fScaleFactor = GetDPIScaleFactor();
core.git: Branch 'libreoffice-24-2' - sc/uiconfig
sc/uiconfig/scalc/ui/conditionalentry.ui | 343 ++- 1 file changed, 160 insertions(+), 183 deletions(-) New commits: commit 32f7ef29615b25e91a73fe33632bb3b7ca506d04 Author: Heiko Tietze AuthorDate: Wed Apr 24 11:38:51 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Apr 24 21:48:39 2024 +0200 Resolves tdf#159569 - Conditional Formatting dialog jumps with message string Some defined width solves the issue Change-Id: I1f92815e690828e283c275a58a71dd07613642fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit 9d29a2a6aad679129218ab4c5020c92bb3ce9cb3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166520 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui b/sc/uiconfig/scalc/ui/conditionalentry.ui index 1ff40d10460f..6e40f6cc6acc 100644 --- a/sc/uiconfig/scalc/ui/conditionalentry.ui +++ b/sc/uiconfig/scalc/ui/conditionalentry.ui @@ -1,216 +1,217 @@ - + True -True +True True -never -never -in +never +never +in True -False +False True - + True -False +False True -6 -6 -12 +6 +6 +12 - + True -False +False True -12 +12 True -False +False -0 -0 +0 +0 -10 +10 True -False +False True end -1 -0 +1 +0 -0 -0 +0 +0 - + True -False +False True -6 -12 -True +6 +12 +True -False -True +False +True Apply Style: -True -style +True +style 0 -0 -2 +0 +2 -False -True +False +True New Style... -1 -2 +1 +2 -False -True +100 +False +True Enter a value: 0 -0 -3 +0 +3 3 -True -True +True +True +True True -True -0 -4 +0 +4 -True -True +True +True +True True -True -1 -4 +1 +4 -True -True +True +True
Minutes from the UX/design meeting 2023-Apr-24
Present: Cor, Sahil, John, Ring, Heiko Comments: Stephane, Eyal, Stuart Tickets/Topics * Bullets and Numbering dialog in Writer does not say it's about an implicit list style + https://bugs.documentfoundation.org/show_bug.cgi?id=160629 + list styles created and applied via toolbar are hard to identify as such in the B dialog + no label substitutes the need to learn how this works; we may drop all shortcuts and ease functions but the cost is too high (Heiko, Cor) => suggest WF * Want indication of whether a master slide is in use or not + https://bugs.documentfoundation.org/show_bug.cgi?id=160403 + MSO Powerpoints shows the number of slides in a tooltip (Stephane) + additional boolean indication would be nice (Eyal) + tooltip sounds good and is not harmful (John) + not much useful since "Delete Master" is only available if the slide master is not in use (Cor) => no objection, low priority * When right-clicking a font family combo-box, offer font meta-data + https://bugs.documentfoundation.org/show_bug.cgi?id=152487 + unclear use case and much likely off-topic being available in font management tools (Heiko) + info dialog sounds good but rather via special characters or in the character properties dialog (Stuart) + only use case is compatibility with some other font (John) + likely not part of the meta data + the Internet returns all search results (Cor) => idea does not find support; WF * Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable independently with user-defined hotkeys per each file + https://bugs.documentfoundation.org/show_bug.cgi?id=160242 + start Impress twice (Stephane), workflow is supported with a third monitor (John) + too niche, better suited for an extension (Stephane, Sahil) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-24
Present: Cor, Sahil, John, Ring, Heiko Comments: Stephane, Eyal, Stuart Tickets/Topics * Bullets and Numbering dialog in Writer does not say it's about an implicit list style + https://bugs.documentfoundation.org/show_bug.cgi?id=160629 + list styles created and applied via toolbar are hard to identify as such in the B dialog + no label substitutes the need to learn how this works; we may drop all shortcuts and ease functions but the cost is too high (Heiko, Cor) => suggest WF * Want indication of whether a master slide is in use or not + https://bugs.documentfoundation.org/show_bug.cgi?id=160403 + MSO Powerpoints shows the number of slides in a tooltip (Stephane) + additional boolean indication would be nice (Eyal) + tooltip sounds good and is not harmful (John) + not much useful since "Delete Master" is only available if the slide master is not in use (Cor) => no objection, low priority * When right-clicking a font family combo-box, offer font meta-data + https://bugs.documentfoundation.org/show_bug.cgi?id=152487 + unclear use case and much likely off-topic being available in font management tools (Heiko) + info dialog sounds good but rather via special characters or in the character properties dialog (Stuart) + only use case is compatibility with some other font (John) + likely not part of the meta data + the Internet returns all search results (Cor) => idea does not find support; WF * Make possible 2 or more impress in fullscreen each on a dedicated monitor AND each seekable independently with user-defined hotkeys per each file + https://bugs.documentfoundation.org/show_bug.cgi?id=160242 + start Impress twice (Stephane), workflow is supported with a third monitor (John) + too niche, better suited for an extension (Stephane, Sahil) => WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sw/qa sw/source sw/uiconfig
sw/qa/uitest/writer_tests2/formatCharacter.py | 47 -
sw/source/ui/chrdlg/chardlg.cxx | 211 --
sw/source/uibase/inc/chrdlg.hxx | 30 ---
sw/uiconfig/swriter/ui/characterproperties.ui | 30 ---
4 files changed, 3 insertions(+), 315 deletions(-)
New commits:
commit 63315d601296f7c188e920f73b12260d018807d0
Author: Heiko Tietze
AuthorDate: Tue Apr 23 17:20:47 2024 +0200
Commit: Heiko Tietze
CommitDate: Wed Apr 24 16:13:15 2024 +0200
Resolves tdf#132253 - Remove hyperlink tab from character dialog
Change-Id: Idb7fa74dbe196262cea64946452043f7de6fa20c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166553
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/qa/uitest/writer_tests2/formatCharacter.py
b/sw/qa/uitest/writer_tests2/formatCharacter.py
index 265f7b4df92e..724b8813029e 100644
--- a/sw/qa/uitest/writer_tests2/formatCharacter.py
+++ b/sw/qa/uitest/writer_tests2/formatCharacter.py
@@ -65,8 +65,6 @@ class formatCharacter(UITestCase):
xLangFontCTL = xDialog.getChild("cbCTLLanguage")
self.assertEqual(get_state_as_dict(xLangFontCTL)["Text"],
"[None]")
-
-
def test_format_character_tab_font_effects(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -115,47 +113,6 @@ class formatCharacter(UITestCase):
self.assertEqual(get_state_as_dict(xEmphasis)["SelectEntryText"], "Dot")
self.assertEqual(get_state_as_dict(xPosition)["SelectEntryText"], "Below text")
-
-
- def test_format_character_tab_hyperlink(self):
-with self.ui_test.create_doc_in_start_center("writer") as document:
-
-with
self.ui_test.execute_dialog_through_command(".uno:FontDialog") as xDialog:
-xTabs = xDialog.getChild("tabcontrol")
-select_pos(xTabs, "4")
-
-xURL = xDialog.getChild("urled")
-xURL.executeAction("TYPE",
mkPropertyValues({"TEXT":"libreoffice.org"}))
-xTexted = xDialog.getChild("texted")
-xTexted.executeAction("TYPE",
mkPropertyValues({"TEXT":"LibreOffice"}))
-xName = xDialog.getChild("nameed")
-xName.executeAction("TYPE",
mkPropertyValues({"TEXT":"hyperlink"}))
-
-xVisited = xDialog.getChild("visitedlb")
-select_by_text(xVisited, "Bullets")
-xUnVisited = xDialog.getChild("unvisitedlb")
-select_by_text(xUnVisited, "Bullets")
-
-
-self.xUITest.executeCommand(".uno:GoLeft")
-self.assertEqual(document.Text.String[0:11], "LibreOffice")
-
-with
self.ui_test.execute_dialog_through_command(".uno:FontDialog",
close_button="cancel") as xDialog:
-xTabs = xDialog.getChild("tabcontrol")
-select_pos(xTabs, "4")
-xURL = xDialog.getChild("urled")
-xTexted = xDialog.getChild("texted")
-xName = xDialog.getChild("nameed")
-xVisited = xDialog.getChild("visitedlb")
-xUnVisited = xDialog.getChild("unvisitedlb")
-
-self.assertEqual(get_state_as_dict(xURL)["Text"],
"http://libreoffice.org/;)
-self.assertEqual(get_state_as_dict(xTexted)["Text"],
"LibreOffice")
-self.assertEqual(get_state_as_dict(xName)["Text"], "hyperlink")
-
self.assertEqual(get_state_as_dict(xVisited)["SelectEntryText"], "Bullets")
-
self.assertEqual(get_state_as_dict(xUnVisited)["SelectEntryText"], "Bullets")
-
-
def test_format_character_tab_asian_layout(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -221,8 +178,6 @@ class formatCharacter(UITestCase):
self.assertEqual(get_state_as_dict(xFitToLine)["Selected"],
"true")
self.assertEqual(get_state_as_dict(xNoHyphenation)["Selected"], "true")
-
-
def test_format_character_tab_position_scalewidthsb(self):
with self.ui_test.create_doc_in_start_center("writer"):
@@ -240,6 +195,4 @@ class formatCharacter(UITestCase):
xScalewidth = xDialog.getChild("scalewidthsb")
self.assertEqual(get_state_as_dict(xScalewidth)["Text"],
"101%")
-
-
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/s
core.git: sc/uiconfig
sc/uiconfig/scalc/ui/conditionalentry.ui | 343 ++- 1 file changed, 160 insertions(+), 183 deletions(-) New commits: commit 9d29a2a6aad679129218ab4c5020c92bb3ce9cb3 Author: Heiko Tietze AuthorDate: Wed Apr 24 11:38:51 2024 +0200 Commit: Heiko Tietze CommitDate: Wed Apr 24 14:58:11 2024 +0200 Resolves tdf#159569 - Conditional Formatting dialog jumps with message string Some defined width solves the issue Change-Id: I1f92815e690828e283c275a58a71dd07613642fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui b/sc/uiconfig/scalc/ui/conditionalentry.ui index 1ff40d10460f..6e40f6cc6acc 100644 --- a/sc/uiconfig/scalc/ui/conditionalentry.ui +++ b/sc/uiconfig/scalc/ui/conditionalentry.ui @@ -1,216 +1,217 @@ - + True -True +True True -never -never -in +never +never +in True -False +False True - + True -False +False True -6 -6 -12 +6 +6 +12 - + True -False +False True -12 +12 True -False +False -0 -0 +0 +0 -10 +10 True -False +False True end -1 -0 +1 +0 -0 -0 +0 +0 - + True -False +False True -6 -12 -True +6 +12 +True -False -True +False +True Apply Style: -True -style +True +style 0 -0 -2 +0 +2 -False -True +False +True New Style... -1 -2 +1 +2 -False -True +100 +False +True Enter a value: 0 -0 -3 +0 +3 3 -True -True +True +True +True True -True -0 -4 +0 +4 -True -True +True +True +True True -True -1 -4 +1 +4 -True -True +True +True +True True -True -2 -4 +2 +4
core.git: sw/uiconfig
sw/uiconfig/swriter/ui/characterproperties.ui | 272 -- 1 file changed, 50 insertions(+), 222 deletions(-) New commits: commit e60ded9773673c356a88fa02867cb3692ee74c87 Author: Heiko Tietze AuthorDate: Tue Apr 23 16:42:56 2024 +0200 Commit: Heiko Tietze CommitDate: Wed Apr 24 11:48:28 2024 +0200 Bump Glade version Change-Id: I53c7c6cab10663b50391a45c18e09dc3e81c87cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166546 Reviewed-by: Heiko Tietze Tested-by: Jenkins diff --git a/sw/uiconfig/swriter/ui/characterproperties.ui b/sw/uiconfig/swriter/ui/characterproperties.ui index 1ba9823a1c74..414edb773b86 100644 --- a/sw/uiconfig/swriter/ui/characterproperties.ui +++ b/sw/uiconfig/swriter/ui/characterproperties.ui @@ -1,36 +1,33 @@ - + -False -False -6 +False +6 Character +False True -0 -0 -dialog - - - +0 +0 +dialog -False +False vertical 12 -False -end +False +end _Reset True -True -True +True +True +Unsaved modifications to this tab are reverted. True -Unsaved modifications to this tab are reverted. Revert any changes made on the tab shown here to the settings that were present when this dialog was opened. @@ -45,12 +42,11 @@ -_Standard -False -True -True -True -True +_Standard +True +True +True +True False @@ -62,10 +58,10 @@ _OK True -True -True -True -True +True +True +True +True True @@ -78,8 +74,8 @@ _Cancel True -True -True +True +True True @@ -92,8 +88,8 @@ _Help True -True -True +True +True True @@ -107,47 +103,23 @@ False True -end +end 0 True -True +True True True True -True +True True -False - - - - - - - - - - - - - - - - - - - - - - - - +False @@ -156,42 +128,18 @@ True -False +False Font -False +False True -False - - - - - - - - - - - - - - - - - - - - - - - - +False @@ -203,43 +151,19 @@ True -False +False Font Effects 1 -False +False True -False
core.git: svx/uiconfig
svx/uiconfig/ui/themecoloreditdialog.ui |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 8f3a19ce3a2dea548f644a8925bfe0718424ac21 Author: Heiko Tietze AuthorDate: Tue Apr 23 15:45:20 2024 +0200 Commit: Heiko Tietze CommitDate: Tue Apr 23 17:22:12 2024 +0200 Resolves tdf#160050 - Overlapping controls in 'add themes' dialog Change-Id: I196ef4b445dcae5d6fc9891c8f9c0d0b2976d583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166541 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/svx/uiconfig/ui/themecoloreditdialog.ui b/svx/uiconfig/ui/themecoloreditdialog.ui index 96276093a75a..ac0114ab4be1 100644 --- a/svx/uiconfig/ui/themecoloreditdialog.ui +++ b/svx/uiconfig/ui/themecoloreditdialog.ui @@ -3,13 +3,12 @@ -400 -300 False True True 6 Theme Color Edit +False True dialog
core.git: sw/source
sw/source/core/text/inftxt.cxx| 90 +++---
sw/source/uibase/uiview/view0.cxx |6 --
2 files changed, 47 insertions(+), 49 deletions(-)
New commits:
commit b79e0dd7fc8bc620420ed65edbc105eec3648b34
Author: Heiko Tietze
AuthorDate: Fri Apr 12 15:26:41 2024 +0200
Commit: Heiko Tietze
CommitDate: Sun Apr 21 12:40:23 2024 +0200
Resolves tdf#58434 - Show formatting marks independently from fields
Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc.
and Tab, SoftHyphen, Blank, as well as ControlChar depends now on
Formatting Marks / .uno:ControlCodes. Field Shading also does not
toggle HardBlank and SoftHyphen, and what control character is shown
respect the options under Formatting Aids
Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 18ad3d1144e0..b293f18f824a 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1407,54 +1407,56 @@ void SwTextPaintInfo::DrawViewOpt( const SwLinePortion
,
return;
bool bDraw = false;
-switch( nWhich )
-{
-case PortionType::Footnote:
-case PortionType::QuoVadis:
-case PortionType::Number:
-case PortionType::Field:
-case PortionType::Hidden:
-case PortionType::Tox:
-case PortionType::Ref:
-case PortionType::Meta:
-case PortionType::ContentControl:
-case PortionType::ControlChar:
-if ( !GetOpt().IsPagePreview()
- && !GetOpt().IsReadonly()
- && GetOpt().IsFieldShadings()
- && ( PortionType::Number != nWhich
- || m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
-{
-bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
-bDraw &= GetOpt().IsHardBlank();
-}
-break;
-case PortionType::Bookmark:
-// no shading
-break;
-case PortionType::InputField:
-// input field shading also in read-only mode
-if ( !GetOpt().IsPagePreview()
- && GetOpt().IsFieldShadings() )
-{
-bDraw = true;
-}
-break;
-case PortionType::Tab:
-if ( GetOpt().IsTab() ) bDraw = true;
-break;
-case PortionType::SoftHyphen:
-if ( GetOpt().IsSoftHyph() )bDraw = true;
-break;
-case PortionType::Blank:
-if ( GetOpt().IsHardBlank())bDraw = true;
-break;
-default:
+if ( !GetOpt().IsPagePreview()
+ && !GetOpt().IsReadonly() )
+{
+switch( nWhich )
{
-OSL_ENSURE( false, "SwTextPaintInfo::DrawViewOpt: don't know how
to draw this" );
+case PortionType::Tab:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsTab();
+break;
+case PortionType::SoftHyphen:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsSoftHyph();
break;
+case PortionType::Blank:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = GetOpt().IsHardBlank();
+break;
+case PortionType::ControlChar:
+if ( GetOpt().IsViewMetaChars() )
+bDraw = true;
+break;
+case PortionType::Bookmark:
+// no shading
+break;
+case PortionType::Footnote:
+case PortionType::QuoVadis:
+case PortionType::Number:
+case PortionType::Hidden:
+case PortionType::Tox:
+case PortionType::Ref:
+case PortionType::Meta:
+case PortionType::ContentControl:
+case PortionType::Field:
+case PortionType::InputField:
+// input field shading also in read-only mode
+if (GetOpt().IsFieldShadings()
+&& ( PortionType::Number != nWhich
+|| m_pFrame->GetTextNodeForParaProps()->HasMarkedLabel()))
// #i27615#
+{
+bDraw = PortionType::Footnote != nWhich ||
m_pFrame->IsFootnoteAllowed();
+}
+break;
+default:
+{
+OSL_ENSURE( false, "SwTextPaintInfo::DrawViewOpt: don't know
how to draw this" );
+break;
+}
}
}
+
if ( bDraw )
DrawBackground( rPor, pColor );
}
diff --git a/sw/source/uibase/uiview/view0.cxx
b/sw/source/uibase/uiview/view0.cxx
index 70c9882e0d2e..488b32cc5fee 100644
--- a/sw/source/uibase/uiview/view0.cxx
+++ b/sw/source/uibase/uiview/view0.cxx
@@ -128,14 +128,10 @@ std::shared_ptr const &
SwView::GetMailMergeConfigItem()
static bool lcl_IsViewMarks( co
Minutes from the UX/design meeting 2023-Apr-18
Present: Hossein, Sahil, ring, Heiko Comments: Ady, Brian, Cor, Eyal, Rafael, Jeff, Stephane Tickets/Topics * Calc: default anchor everything to CELL + https://bugs.documentfoundation.org/show_bug.cgi?id=160452 + change default needs to have good reasons (Heiko) + add option to define the default is over-engineering (Heiko) + behavior my have changed in the past (Hossein) => resolve WF; suggest to change the topic into "remember last setting" * When opening Advanced filter dialog the "From" field should be filled with the address of current selection + https://bugs.documentfoundation.org/show_bug.cgi?id=150937 + reasonable request (Ady) + confusing label "Read Filter Criteria From" (Ady) + more common label is possible, eg. "Select Range" but unlikely to be more clear (Heiko) + prefilling data does not harm (Hossein, Heiko) => go for it * Using clone formatting enables scrolling with the mouse -- but it shouldn't + https://bugs.documentfoundation.org/show_bug.cgi?id=99608 + "issue" happens only when moving slowly from top, where moving the cursor on top makes sense + smooth scrolling rather than to jump to a certain position could be a solution (Hossein) => suggest to duplicate with 46988 * Turn on "Range contains column labels" by default + https://bugs.documentfoundation.org/show_bug.cgi?id=150027 + different scenarios, requires more intelligent function (Brian) + remember last user choice for this option (Eyal) + controls got moved to the same tab for bug 131155 (Heiko) + option is checked if header-like data is detected (Cor) + apparently only on Windows, on Linux the last settings are remembered + the dialog has always stored the last settings, unclear report (Cor) => keep the smart functionality, resolve invalid * Add timer/clock to single-screen presentation + https://bugs.documentfoundation.org/show_bug.cgi?id=160227 + makes sense (Rafael) + unclear why the timer needs to be shown for the audience + presenter console uses own class/control + neither available in Excel, feature would lack compatibility => resolve WF in favor of 3rd party extension/macro * Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it + https://bugs.documentfoundation.org/show_bug.cgi?id=160290 + to hide the object first requires additional clicks (Ady) + it's not necessary to hide the comment, one can move it easily (Sahil) + right click to select is not common interaction (Heiko) + respect the z-order (Jeff, Stephane, Heiko, Hossein) => do as requested OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-18
Present: Hossein, Sahil, ring, Heiko Comments: Ady, Brian, Cor, Eyal, Rafael, Jeff, Stephane Tickets/Topics * Calc: default anchor everything to CELL + https://bugs.documentfoundation.org/show_bug.cgi?id=160452 + change default needs to have good reasons (Heiko) + add option to define the default is over-engineering (Heiko) + behavior my have changed in the past (Hossein) => resolve WF; suggest to change the topic into "remember last setting" * When opening Advanced filter dialog the "From" field should be filled with the address of current selection + https://bugs.documentfoundation.org/show_bug.cgi?id=150937 + reasonable request (Ady) + confusing label "Read Filter Criteria From" (Ady) + more common label is possible, eg. "Select Range" but unlikely to be more clear (Heiko) + prefilling data does not harm (Hossein, Heiko) => go for it * Using clone formatting enables scrolling with the mouse -- but it shouldn't + https://bugs.documentfoundation.org/show_bug.cgi?id=99608 + "issue" happens only when moving slowly from top, where moving the cursor on top makes sense + smooth scrolling rather than to jump to a certain position could be a solution (Hossein) => suggest to duplicate with 46988 * Turn on "Range contains column labels" by default + https://bugs.documentfoundation.org/show_bug.cgi?id=150027 + different scenarios, requires more intelligent function (Brian) + remember last user choice for this option (Eyal) + controls got moved to the same tab for bug 131155 (Heiko) + option is checked if header-like data is detected (Cor) + apparently only on Windows, on Linux the last settings are remembered + the dialog has always stored the last settings, unclear report (Cor) => keep the smart functionality, resolve invalid * Add timer/clock to single-screen presentation + https://bugs.documentfoundation.org/show_bug.cgi?id=160227 + makes sense (Rafael) + unclear why the timer needs to be shown for the audience + presenter console uses own class/control + neither available in Excel, feature would lack compatibility => resolve WF in favor of 3rd party extension/macro * Right-clicking to select an always-shown comment in Calc "clicks through" and selects the cell behind it + https://bugs.documentfoundation.org/show_bug.cgi?id=160290 + to hide the object first requires additional clicks (Ady) + it's not necessary to hide the comment, one can move it easily (Sahil) + right click to select is not common interaction (Heiko) + respect the z-order (Jeff, Stephane, Heiko, Hossein) => do as requested OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: Branch 'libreoffice-7-6' - sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 1bc57f8d02f7b9a2b4e5d16018ac06edce162688 Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Apr 5 16:08:15 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165724 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 140b4e48d0a0..3cca2d4011d2 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -440,6 +440,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
core.git: Branch 'libreoffice-24-2' - sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d3871c6ac05bb9553aed1cc951ba18efcb06082a Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Apr 5 08:02:19 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165722 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 8a6f74b86ee8..03d5733a87ad 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -441,6 +441,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
Minutes from the UX/design meeting 2023-Apr-04
Present: Felix, Cor, Hossein, Rafael, Heiko
Comments: Mike, Regina, Bogdan, Timur, Cor, Stephane
Tickets/Topics
* "Page number" automatic field stops counting before last page if offset >0
+ https://bugs.documentfoundation.org/show_bug.cgi?id=35694
+ help is clear on the function (Regina)
+ just a wording issue but rather introduce another field "page reference",
which would have the offset attribute (Mike, Regina)
+ comment 70 and 78 are wisdom; missing a good proposal (Cor)
+ compatibility is prime (Hossein)
+ neither prev/next nor offset are stored with docx
+ MSO offsets per field code like "{={PAGE}-10} of {={NUMPAGES}*20}"
showing "-9 of 80" (not stored as a field on saving as ODT)
+ offset for pagee count is via set variable > page + x (Heiko)
=> comment on ticket
* Replies to comment are in reverse order
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160350
+ chat-like order D, C, B, A (latest on top) vs. book style
A, B, C, D (latest at bottom) (Bogdan)
+ latest on top makes sense (Heiko)
+ current implementation shows comments on the place where they
are made, i.e. below the comment where one chooses: reply,
which makes sense to me (Cor)
+ all other applications do it book-like (Timur, Bogdan, Felix)
=> do it (consider an expert option)
* Add toolbar icons to change UI and scheme to switch Light/Dark
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160349
+ useful for tester and user (Rafael)
+ switching only tools > application colors via the new control (Rafael)
+ fixes fallout from bug 160445
+ strongly against adding rarely used functions to the primary UI,
options would also be hard-coded and not easy to remove later (Heiko)
+ MS has a "Switch Modes" option in the View ribbon (Hossein, Felix)
=> majority are for the option
* Pressing Tab with partially selected numbered paragraphs deletes content
instead of changing level
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160317
+ agree on the expectation (Stephane, Felix)
+ inconsistent with inserting a literal tab (Heiko)
+ compatibility is prime (Hossein)
+ tab overwrites in MSO; but tab on the first list item indents
the whole list anyway (only second increases the level we do)
+ literal tab is inserted on any position >0, ie. inside the text
+ otherwise the level for the whole selection is increased
+ always indent for selection over multiple paragraphs (Rafael, Felix)
+ current behavior depends on selection mode, ie. adding selection inserts
at the beginning while extend does on the end (Heiko)
=> majority agrees with the request
OpenPGP_signature.asc
Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Apr-04
Present: Felix, Cor, Hossein, Rafael, Heiko
Comments: Mike, Regina, Bogdan, Timur, Cor, Stephane
Tickets/Topics
* "Page number" automatic field stops counting before last page if offset >0
+ https://bugs.documentfoundation.org/show_bug.cgi?id=35694
+ help is clear on the function (Regina)
+ just a wording issue but rather introduce another field "page reference",
which would have the offset attribute (Mike, Regina)
+ comment 70 and 78 are wisdom; missing a good proposal (Cor)
+ compatibility is prime (Hossein)
+ neither prev/next nor offset are stored with docx
+ MSO offsets per field code like "{={PAGE}-10} of {={NUMPAGES}*20}"
showing "-9 of 80" (not stored as a field on saving as ODT)
+ offset for pagee count is via set variable > page + x (Heiko)
=> comment on ticket
* Replies to comment are in reverse order
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160350
+ chat-like order D, C, B, A (latest on top) vs. book style
A, B, C, D (latest at bottom) (Bogdan)
+ latest on top makes sense (Heiko)
+ current implementation shows comments on the place where they
are made, i.e. below the comment where one chooses: reply,
which makes sense to me (Cor)
+ all other applications do it book-like (Timur, Bogdan, Felix)
=> do it (consider an expert option)
* Add toolbar icons to change UI and scheme to switch Light/Dark
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160349
+ useful for tester and user (Rafael)
+ switching only tools > application colors via the new control (Rafael)
+ fixes fallout from bug 160445
+ strongly against adding rarely used functions to the primary UI,
options would also be hard-coded and not easy to remove later (Heiko)
+ MS has a "Switch Modes" option in the View ribbon (Hossein, Felix)
=> majority are for the option
* Pressing Tab with partially selected numbered paragraphs deletes content
instead of changing level
+ https://bugs.documentfoundation.org/show_bug.cgi?id=160317
+ agree on the expectation (Stephane, Felix)
+ inconsistent with inserting a literal tab (Heiko)
+ compatibility is prime (Hossein)
+ tab overwrites in MSO; but tab on the first list item indents
the whole list anyway (only second increases the level we do)
+ literal tab is inserted on any position >0, ie. inside the text
+ otherwise the level for the whole selection is increased
+ always indent for selection over multiple paragraphs (Rafael, Felix)
+ current behavior depends on selection mode, ie. adding selection inserts
at the beginning while extend does on the end (Heiko)
=> majority agrees with the request
OpenPGP_signature.asc
Description: OpenPGP digital signature
core.git: sw/source
sw/source/ui/index/swuiidxmrk.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc Author: Heiko Tietze AuthorDate: Thu Apr 4 12:09:33 2024 +0200 Commit: Heiko Tietze CommitDate: Thu Apr 4 15:30:30 2024 +0200 Resolves tdf#154209 - Fixes resize issue in Index Entry dialog Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 6b6e9f10536f..2ca5d673712b 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -441,6 +441,7 @@ IMPL_LINK_NOARG(SwIndexMarkPane, SyncSelectionHdl, weld::Button&, void) m_xApplyToAllCB->show(); m_xSearchCaseSensitiveCB->show(); m_xSearchCaseWordOnlyCB->show(); +m_xDialog->resize_to_request(); m_xApplyToAllCB->set_sensitive(!m_aOrgStr.isEmpty() && !(nFrameType & ( FrameTypeFlags::HEADER | FrameTypeFlags::FOOTER | FrameTypeFlags::FLY_ANY ))); SearchTypeHdl(*m_xApplyToAllCB);
Re: error: this member function can be declared static [loplugin:staticmethods] when adding a event function in a dialog
On 28.03.24 6:09 PM, Caolán McNamara wrote: On Fri, 2024-03-29 at 00:16 +0800, Sakura286 wrote: https://gerrit.libreoffice.org/c/core/+/165391 You might want DECL_STATIC_LINK instead of DECL_LINK. The matching IMPL_LINK then needs to be IMPL_STATIC_LINK etc. Curious to learn why this needs to be static. What makes the one button different from the other? OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-27
Present: Sahil, Antonio, Cor, Bogdan, John, Eyal, Heiko Comments: Stephane, Stuart, Timur Tickets/Topics * A11Y sidebar: Too many issue reports about direct character formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=159906 + group by paragraph (+ 0.5 Stephane) + maybe list per paragraph under one root node (Heiko, Antonio) + offer an action button (+1 Stephane, Heiko, -1 Stuart) + action is not necessarily to remove DF; could also be "Dismiss" (Cor) + could be a more complex UI with more interactions, filters, batch operations etc. (Sahil, Antonio) + could be done in a later patch (Cor) => let's go with the extra tree node per paragraph and maybe page too and no action button for now * Add all 3 Spotlight commands (PS, CS, DF) to Style Inspector + https://bugs.documentfoundation.org/show_bug.cgi?id=160194 + maybe per icon-only toggle button (Stephane) + agree with the proposal as it matches the workflow (Stuart) + clutters the UI and is not in scope of the workflow (Heiko) + it's not uncommon to have those buttons in the UIs (Cor, John) + neither a big improvement nor a huge impact on UX (John) + customization is sufficient (Antonio) => let's do it * Use "Delete unused master slides" independently from "Minimize Presentation" tool + https://bugs.documentfoundation.org/show_bug.cgi?id=159860 + warn in case of an excessive number of master slides + rather fix bug 158773 than alert user on some high number (Heiko) + MSO is loading quickly but still warns (Timur) + warning could offer to delete unused master slides (Antonio) + warning should happen on load; covers also issues with import from other applications (Antonio) + realize per infobar to not block the workflow (user may click away the confirmation box), OTOH depending on severity it should interrupt + label could be "You have an unreasonable number of unused slide master. [Clean Up] [x]" (Heiko) + hesitate to delete a lot of content with just a click, so - suggest a confirmation dialog when pressing cleanup (Eyal) + add a button "Inspect" to the infobar (Cor) + strongly disagree with different actions on the infobar (Heiko) + add Help button to educate the user (Antonio) => do so * MRU Recent files list entries numbered, no need to be + https://bugs.documentfoundation.org/show_bug.cgi?id=160230 + number seems to be useless (Bogdan) + actual date/time like MSO makes more sense (John) + handy for a11y resp. keyboard only access (Stuart,Antonio) + Alt+F + U + 1 opens the latest pinned item, for example + numbers above 10 take the first character from the filename + number indicates the recency (Eyal) + mnemonics inside the filename are hard to spot (Cor) + alternatively we could go with alphanumeric characters A..Z (Sahil) + this would require using different alphabeta in different localized UIs (Eyal) => no good argument to remove the numbers -> WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-27
Present: Sahil, Antonio, Cor, Bogdan, John, Eyal, Heiko Comments: Stephane, Stuart, Timur Tickets/Topics * A11Y sidebar: Too many issue reports about direct character formatting + https://bugs.documentfoundation.org/show_bug.cgi?id=159906 + group by paragraph (+ 0.5 Stephane) + maybe list per paragraph under one root node (Heiko, Antonio) + offer an action button (+1 Stephane, Heiko, -1 Stuart) + action is not necessarily to remove DF; could also be "Dismiss" (Cor) + could be a more complex UI with more interactions, filters, batch operations etc. (Sahil, Antonio) + could be done in a later patch (Cor) => let's go with the extra tree node per paragraph and maybe page too and no action button for now * Add all 3 Spotlight commands (PS, CS, DF) to Style Inspector + https://bugs.documentfoundation.org/show_bug.cgi?id=160194 + maybe per icon-only toggle button (Stephane) + agree with the proposal as it matches the workflow (Stuart) + clutters the UI and is not in scope of the workflow (Heiko) + it's not uncommon to have those buttons in the UIs (Cor, John) + neither a big improvement nor a huge impact on UX (John) + customization is sufficient (Antonio) => let's do it * Use "Delete unused master slides" independently from "Minimize Presentation" tool + https://bugs.documentfoundation.org/show_bug.cgi?id=159860 + warn in case of an excessive number of master slides + rather fix bug 158773 than alert user on some high number (Heiko) + MSO is loading quickly but still warns (Timur) + warning could offer to delete unused master slides (Antonio) + warning should happen on load; covers also issues with import from other applications (Antonio) + realize per infobar to not block the workflow (user may click away the confirmation box), OTOH depending on severity it should interrupt + label could be "You have an unreasonable number of unused slide master. [Clean Up] [x]" (Heiko) + hesitate to delete a lot of content with just a click, so - suggest a confirmation dialog when pressing cleanup (Eyal) + add a button "Inspect" to the infobar (Cor) + strongly disagree with different actions on the infobar (Heiko) + add Help button to educate the user (Antonio) => do so * MRU Recent files list entries numbered, no need to be + https://bugs.documentfoundation.org/show_bug.cgi?id=160230 + number seems to be useless (Bogdan) + actual date/time like MSO makes more sense (John) + handy for a11y resp. keyboard only access (Stuart,Antonio) + Alt+F + U + 1 opens the latest pinned item, for example + numbers above 10 take the first character from the filename + number indicates the recency (Eyal) + mnemonics inside the filename are hard to spot (Cor) + alternatively we could go with alphanumeric characters A..Z (Sahil) + this would require using different alphabeta in different localized UIs (Eyal) => no good argument to remove the numbers -> WF OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/inc cui/Library_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk desktop/source extras/source include/sfx2 include/unotools officecfg/registry Repository.mk sfx2/sdi sfx2/source vcl/Mo
Repository.mk |1 cui/Library_cui.mk |1 cui/UIConfig_cui.mk|1 cui/inc/whatsnew.hrc | 42 ++ cui/source/dialogs/whatsnew.cxx| 172 ++ cui/source/factory/dlgfact.cxx | 13 cui/source/factory/dlgfact.hxx |2 cui/source/inc/whatsnew.hxx| 75 cui/uiconfig/ui/whatsnewdialog.ui | 131 +++ desktop/source/app/app.cxx |2 extras/source/whatsnew/Community.png |binary extras/source/whatsnew/Configurability.png |binary extras/source/whatsnew/LibreOffice.gif |binary extras/source/whatsnew/ODF.png |binary extras/source/whatsnew/whatsnew1.png |binary include/sfx2/sfxdlg.hxx|2 include/sfx2/sfxsids.hrc |5 include/sfx2/strings.hrc |2 include/sfx2/viewfrm.hxx |1 include/unotools/VersionConfig.hxx | 24 - officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs |6 officecfg/registry/schema/org/openoffice/Setup.xcs |8 sfx2/sdi/appslots.sdi |4 sfx2/sdi/sfx.sdi | 16 sfx2/source/appl/appserv.cxx | 10 sfx2/source/dialog/infobar.cxx |2 sfx2/source/view/viewfrm.cxx | 43 +- vcl/Module_vcl.mk |1 vcl/Package_whatsnew.mk| 20 + 29 files changed, 533 insertions(+), 51 deletions(-) New commits: commit dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1 Author: Heiko Tietze AuthorDate: Thu Feb 22 12:56:01 2024 +0100 Commit: Heiko Tietze CommitDate: Wed Mar 27 09:41:44 2024 +0100 Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog To test the new dialog, change org.openoffice.Setup > Product > ooSetupLastVersion to some lesser value for the WhatsNew dialog or clear the entry for the Welcome version. Change-Id: Iec6de50edba0e5430e82f1db85e61d1e4501771d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163739 Reviewed-by: Michael Weghorn Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/Repository.mk b/Repository.mk index 5b60bd66cfcc..9317a29975df 100644 --- a/Repository.mk +++ b/Repository.mk @@ -925,6 +925,7 @@ $(eval $(call gb_Helper_register_packages_for_install,sdk,\ ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE) $(eval $(call gb_Helper_register_packages_for_install,ooo,\ tipoftheday_images \ + whatsnew_images \ )) endif diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk index e01e33ecb4ec..3ee744e32d0f 100644 --- a/cui/Library_cui.mk +++ b/cui/Library_cui.mk @@ -114,6 +114,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\ cui/source/customize/SvxNotebookbarConfigPage \ cui/source/customize/CustomNotebookbarGenerator \ cui/source/dialogs/about \ +cui/source/dialogs/whatsnew \ $(call gb_Helper_optional,EXTENSIONS, \ cui/source/dialogs/AdditionsDialog) \ cui/source/dialogs/colorpicker \ diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk index 10acd83c8c39..79ff7696a93a 100644 --- a/cui/UIConfig_cui.mk +++ b/cui/UIConfig_cui.mk @@ -18,6 +18,7 @@ endif ifneq ($(ENABLE_WASM_STRIP_PINGUSER),TRUE) $(eval $(call gb_UIConfig_add_uifiles,cui,\ cui/uiconfig/ui/tipofthedaydialog \ + cui/uiconfig/ui/whatsnewdialog \ )) endif diff --git a/cui/inc/whatsnew.hrc b/cui/inc/whatsnew.hrc new file mode 100644 index ..e155a597bcf2 --- /dev/null +++ b/cui/inc/whatsnew.hrc @@ -0,0 +1,42 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#define NC_(Context, String) TranslateId(Context, u8##String) + +#include +#include +#include +#include + +/* + * std:tuple consists of + * image: + * place new images at extra/source/whatsnew + * do not forget to add the files to vcl/Package_whatsnew.mk + * images are cut-off at 600x400px +*/ + +const std::tuple WELCOME_STRIN
Re: Adding support for the Common Print Dialog Backends (CPDB)
On 26.03.24 6:26 PM, Till Kamppeter wrote: This requires changes on the print dialog: - List IPP print destinations, independent whether there is a CUPS queue for them or not (if not, CUPS would create a temporary queue) - Obtain printer capabilities and options via IPP, do not try to download the PPD file via CUPS or even try to directly access it in the file system. Our users are quite picky with the print dialog. Most of the redesign was done by Daniel Silva for GSoC 2019 with numerous follow-up, see https://bugs.documentfoundation.org/show_bug.cgi?id=103309. One of the discussion was whether the option to print odd/even pages from a range is important enough to be on the primary view (bug 127680). The CPDB does not have this option, as far I can see. OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: include/vcl sfx2/source vcl/source vcl/unx
include/vcl/settings.hxx |9 +
sfx2/source/dialog/infobar.cxx| 12 +++
vcl/source/app/salvtables.cxx |8 +++--
vcl/source/app/settings.cxx | 53 +-
vcl/unx/gtk3/gtkinst.cxx |4 +-
vcl/unx/gtk3/salnativewidgets-gtk.cxx |5 ---
6 files changed, 75 insertions(+), 16 deletions(-)
New commits:
commit d7fd378b533c42f51d1d363f5da30b1fa1281f67
Author: Heiko Tietze
AuthorDate: Fri Mar 22 12:58:07 2024 +0100
Commit: Heiko Tietze
CommitDate: Sat Mar 23 08:02:18 2024 +0100
Harmonization of warning and error colors
* hard-coded colors from infobar moved to settings
* weld::LabelType::Warning and ::Error uses these colors
* gtk3 native configuration removed
Change-Id: Ia80584e9267b8385f7f6b25322f5a85a2570af68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165161
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx
index 0787fe98b6cc..e21091385bc7 100644
--- a/include/vcl/settings.hxx
+++ b/include/vcl/settings.hxx
@@ -353,6 +353,15 @@ public:
voidSetWarningColor( const Color& rColor );
const Color&GetWarningColor() const;
+voidSetWarningTextColor( const Color& rColor );
+const Color&GetWarningTextColor() const;
+
+voidSetErrorColor( const Color& rColor );
+const Color&GetErrorColor() const;
+
+voidSetErrorTextColor( const Color& rColor );
+const Color&GetErrorTextColor() const;
+
voidSetHelpColor( const Color& rColor );
const Color&GetHelpColor() const;
diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx
index 38a510a2589c..26dfc0af26c0 100644
--- a/sfx2/source/dialog/infobar.cxx
+++ b/sfx2/source/dialog/infobar.cxx
@@ -44,6 +44,8 @@ void GetInfoBarColors(InfobarType ibType, BColor&
rBackgroundColor, BColor& rFor
{
rMessageColor = basegfx::BColor(0.0, 0.0, 0.0);
+const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
+
switch (ibType)
{
case InfobarType::INFO: // blue; #004785/0,71,133; #BDE5F8/189,229,248
@@ -55,17 +57,15 @@ void GetInfoBarColors(InfobarType ibType, BColor&
rBackgroundColor, BColor& rFor
rForegroundColor = basegfx::BColor(0.196, 0.333, 0.047);
break;
case InfobarType::WARNING: // orange; #704300/112,67,0;
#FEEFB3/254,239,179
-rBackgroundColor = basegfx::BColor(0.996, 0.937, 0.702);
-rForegroundColor = basegfx::BColor(0.439, 0.263, 0.0);
+rBackgroundColor = rSettings.GetWarningColor().getBColor();
+rForegroundColor = rSettings.GetWarningTextColor().getBColor();
break;
case InfobarType::DANGER: // red; #7A0006/122,0,6; #FFBABA/255,186,186
-rBackgroundColor = basegfx::BColor(1.0, 0.729, 0.729);
-rForegroundColor = basegfx::BColor(0.478, 0.0, 0.024);
+rBackgroundColor = rSettings.GetErrorColor().getBColor();
+rForegroundColor = rSettings.GetErrorTextColor().getBColor();
break;
}
-//remove this?
-const StyleSettings& rSettings =
Application::GetSettings().GetStyleSettings();
if (rSettings.GetHighContrastMode())
{
rBackgroundColor = rSettings.GetLightColor().getBColor();
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 4469978be626..3f007783498d 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -5949,14 +5949,16 @@ void SalInstanceLabel::set_label_type(weld::LabelType
eType)
m_xLabel->SetControlBackground();
break;
case weld::LabelType::Warning:
-m_xLabel->SetControlForeground();
+m_xLabel->SetControlForeground(
+
m_xLabel->GetSettings().GetStyleSettings().GetWarningTextColor());
m_xLabel->SetControlBackground(
m_xLabel->GetSettings().GetStyleSettings().GetWarningColor());
break;
case weld::LabelType::Error:
-m_xLabel->SetControlForeground();
+m_xLabel->SetControlForeground(
+
m_xLabel->GetSettings().GetStyleSettings().GetErrorTextColor());
m_xLabel->SetControlBackground(
-
m_xLabel->GetSettings().GetStyleSettings().GetHighlightColor());
+m_xLabel->GetSettings().GetStyleSettings().GetErrorColor());
break;
case weld::LabelType::Title:
m_xLabel->SetControlForeground(
diff --git a/vcl/source/app/settings.cxx
core.git: sc/source
sc/source/ui/app/rfindlst.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 9c8b240e7cad6ef74e16ad83d45957737389aa90
Author: Heiko Tietze
AuthorDate: Thu Mar 21 11:50:40 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Mar 22 13:06:37 2024 +0100
Resolves tdf#160282 - Ranges references text colors for dark backgrounds
Change-Id: I3d3bb22302ad5016c962d606e80c2e9942301fbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165095
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/sc/source/ui/app/rfindlst.cxx b/sc/source/ui/app/rfindlst.cxx
index ba17bf006ea1..be521f65dea8 100644
--- a/sc/source/ui/app/rfindlst.cxx
+++ b/sc/source/ui/app/rfindlst.cxx
@@ -20,18 +20,25 @@
#include
#include
#include
+#include
+#include
#define SC_RANGECOLORS 8
const Color aColNames[SC_RANGECOLORS] =
{ COL_LIGHTBLUE, COL_LIGHTRED, COL_LIGHTMAGENTA, COL_GREEN,
COL_BLUE, COL_RED, COL_MAGENTA, COL_BROWN };
+const Color aDarkColNames[SC_RANGECOLORS] =
+{ COL_LIGHTBLUE, COL_LIGHTRED, COL_LIGHTMAGENTA, COL_GREEN,
+Color(0xb4c7dc), Color(0xffa6a6), Color(0xffb66c), Color(0xafd095) };
//light blue/red/orange/green 3
+static bool bIsDark;
ScRangeFindList::ScRangeFindList(OUString aName) :
aDocName(std::move( aName )),
bHidden( false ),
nIndexColor( 0 )
{
+bIsDark =
SC_MOD()->GetColorConfig().GetColorValue(svtools::DOCCOLOR).nColor.IsDark();
}
Color ScRangeFindList::Insert( const ScRangeFindData )
@@ -48,7 +55,8 @@ Color ScRangeFindList::Insert( const ScRangeFindData )
Color ScRangeFindList::GetColorName( const size_t nIndex )
{
-return aColNames[nIndex % SC_RANGECOLORS];
+return bIsDark ? aDarkColNames[nIndex % SC_RANGECOLORS]
+ : aColNames[nIndex % SC_RANGECOLORS];
}
Color ScRangeFindList::FindColor( const ScRange& rRef, const size_t nIndex )
Minutes from the UX/design meeting 2023-Mar-21
Present: Sahil, Andres, Rhesa, Heiko Comments: Miguel, Ady, Eyal, Cor, Csongor, Eike, Laszlo Tickets/Topics * Hidden columns should not prevent text from preceding columns from overflowing over their cells + https://bugs.documentfoundation.org/show_bug.cgi?id=160011 + potentially breaks current workflow (Miguel) + could be done as (compatibility) flag (Ady) + afraid of performance issues (Ady) + support the request (Eyal, Cor, Sahil) + make it the default, and revert optionally (Sahil) + might be not so easy to find as compatibility flag but clutters the lengthy list of options under view on the other hand (Heiko) => do it * FORMATTING create a means to represent an integer as an IP Address + https://bugs.documentfoundation.org/show_bug.cgi?id=148184 + implement per function (Csongor) + solutions are spread over the Internet, https://superuser.com/questions/1764387/how-do-i-convert-an-ip-address-to-binary-representation-in-excel + https://www.browserling.com/tools/ip-to-dec + already have some number formatting types and another one would fit well (Eyal) + not simply one for all option considering IPv4/v6 (Heiko) + has a solution, if needed we should invest in the user-defined formatting (Sahil, Heiko) => resolve WF * AutoCorrect: Many symbol replacements should be defined for [All], not language-by-language, and work in [None] + https://bugs.documentfoundation.org/show_bug.cgi?id=153979 + extras/source/autocorr/*/DocumentList.xml entirely controlled by the local community (Heiko) + [None] means _no language tool processing at all_, [All] should be processed in all languages except [None] (Eike) + [All] would be useful, but only for a dozen of the replacements, but by moving we can lose educating the users (Laszlo) + adding a button to show only the items added by the user optionally (Laszlo) + adding some replacement to the [ALL] category makes it effective for paragraphs with language = None but not en_US, for example; apparently it's working for empty lists but not if the lang list has some content + if [All] items would be effective, users wont see those in their language depending list (Heiko) + if [All] has the same content as the actual language list it's unclear which one is used (eg. [All] --> = -> vs. [Hebrew] --> = <-) (Sahil) => remove [All] from the dropdown menu (at this tab), and make [None] none (Heiko) * personal / custom dictionaries should be easily portable + https://bugs.documentfoundation.org/show_bug.cgi?id=157981 + allow a dictionary to be saved as /.dic (Cor) + placing a dictionary (*.dic/aff) in some folder which is added via options > path to the dictionary locations does not make it available as writing aid; apparently it needs some registration + export/import could be a nice task for a macro (Heiko) + it's a generic use case for the majority of users and adding this to the core makes sense (Sahil) + if so, we could add export/import buttons to the options dialog (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-21
Present: Sahil, Andres, Rhesa, Heiko Comments: Miguel, Ady, Eyal, Cor, Csongor, Eike, Laszlo Tickets/Topics * Hidden columns should not prevent text from preceding columns from overflowing over their cells + https://bugs.documentfoundation.org/show_bug.cgi?id=160011 + potentially breaks current workflow (Miguel) + could be done as (compatibility) flag (Ady) + afraid of performance issues (Ady) + support the request (Eyal, Cor, Sahil) + make it the default, and revert optionally (Sahil) + might be not so easy to find as compatibility flag but clutters the lengthy list of options under view on the other hand (Heiko) => do it * FORMATTING create a means to represent an integer as an IP Address + https://bugs.documentfoundation.org/show_bug.cgi?id=148184 + implement per function (Csongor) + solutions are spread over the Internet, https://superuser.com/questions/1764387/how-do-i-convert-an-ip-address-to-binary-representation-in-excel + https://www.browserling.com/tools/ip-to-dec + already have some number formatting types and another one would fit well (Eyal) + not simply one for all option considering IPv4/v6 (Heiko) + has a solution, if needed we should invest in the user-defined formatting (Sahil, Heiko) => resolve WF * AutoCorrect: Many symbol replacements should be defined for [All], not language-by-language, and work in [None] + https://bugs.documentfoundation.org/show_bug.cgi?id=153979 + extras/source/autocorr/*/DocumentList.xml entirely controlled by the local community (Heiko) + [None] means _no language tool processing at all_, [All] should be processed in all languages except [None] (Eike) + [All] would be useful, but only for a dozen of the replacements, but by moving we can lose educating the users (Laszlo) + adding a button to show only the items added by the user optionally (Laszlo) + adding some replacement to the [ALL] category makes it effective for paragraphs with language = None but not en_US, for example; apparently it's working for empty lists but not if the lang list has some content + if [All] items would be effective, users wont see those in their language depending list (Heiko) + if [All] has the same content as the actual language list it's unclear which one is used (eg. [All] --> = -> vs. [Hebrew] --> = <-) (Sahil) => remove [All] from the dropdown menu (at this tab), and make [None] none (Heiko) * personal / custom dictionaries should be easily portable + https://bugs.documentfoundation.org/show_bug.cgi?id=157981 + allow a dictionary to be saved as /.dic (Cor) + placing a dictionary (*.dic/aff) in some folder which is added via options > path to the dictionary locations does not make it available as writing aid; apparently it needs some registration + export/import could be a nice task for a macro (Heiko) + it's a generic use case for the majority of users and adding this to the core makes sense (Sahil) + if so, we could add export/import buttons to the options dialog (Heiko) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [GSoC] Expressing interest in contributing to LibreOffice projects
Hi Mohit, thanks a lot for your interest in LibreOffice and in particular in topics around UI/UX. You should start with the requested easyhacks to prove your skills, see https://wiki.documentfoundation.org/Development/GSoC In case of questions don't hesitate to ask on IRC or this mailinglist. Looking forward your contributions, Heiko On 20.03.24 14:16, Mohit Marathe wrote: Dear LibreOffice community, Myself Mohit Marathe, a 3rd year undergraduate at Indian Institute of Technology (BHU), Varanasi and I want to express my interest in contributing to LibreOffice as a part of Google Summer of Code 2024. I have been a GSoC last year for the project: https://summerofcode.withgoogle.com/archive/2023/projects/z26bcE5j. I can see there are multiple projects in C++ in the Ideas page. Personally, I found **Improvement to the functions deck** and **Comments in sidebar** projects to be interesting. In case, if these two projects have already gotten a lot of response from other contributors, I would really appreciate it if you could recommend some other projects which didn't get much attention and which is at a high priority for the LibreOffice community. I have already build LibreOffice and read all the relevant documentation that will help me get started in contributing. Currently, I am working on some easy hacks, for which I'll be submitting patches soon. Best Regards, Mohit Marathe -- Dr. Heiko Tietze, UX-Designer and UX-Mentor Tel: +49 30 5557992-63 | Mail: heiko.tie...@documentfoundation.org The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts Legal details: https://www.documentfoundation.org/imprint OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: cui/uiconfig
cui/uiconfig/ui/pickbulletpage.ui| 59 +--
cui/uiconfig/ui/pickgraphicpage.ui | 135 +++
cui/uiconfig/ui/picknumberingpage.ui | 59 +--
cui/uiconfig/ui/pickoutlinepage.ui | 59 +--
4 files changed, 118 insertions(+), 194 deletions(-)
New commits:
commit aacce8abe239ad679f5e9f9ce9bf2d27fb046d5d
Author: Heiko Tietze
AuthorDate: Wed Mar 13 09:40:51 2024 +0100
Commit: Heiko Tietze
CommitDate: Fri Mar 15 16:12:42 2024 +0100
Resolves tdf#160167 - Remove pointless frames in bullet & numbering dialog
Solves the issue that the "Selection" label is inappropriate
Change-Id: I1bdaa6922796fcdceec0aac6902011aa21cd9aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164758
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/cui/uiconfig/ui/pickbulletpage.ui
b/cui/uiconfig/ui/pickbulletpage.ui
index b9749dda540e..589874506853 100644
--- a/cui/uiconfig/ui/pickbulletpage.ui
+++ b/cui/uiconfig/ui/pickbulletpage.ui
@@ -1,58 +1,39 @@
-
+
-
+
True
-False
+True
+6
+6
+6
+6
True
True
-6
-0
-none
+never
+never
+in
-
+
True
-True
-True
-True
-never
-never
-in
-12
-6
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
bullet style that you want to use.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
bullet style that you want to use.
-
-
-True
-False
-Selection
-
-
-
-
-
Displays the different
bullet styles that you can apply.
diff --git a/cui/uiconfig/ui/pickgraphicpage.ui
b/cui/uiconfig/ui/pickgraphicpage.ui
index fd7b9922e950..ea7342844a14 100644
--- a/cui/uiconfig/ui/pickgraphicpage.ui
+++ b/cui/uiconfig/ui/pickgraphicpage.ui
@@ -1,104 +1,85 @@
-
+
-
+
+
True
-False
+False
+6
+6
+6
+6
True
True
-6
-0
-none
+6
-
-
+
True
-False
+True
True
True
-6
-12
-6
+never
+in
-
+
True
-True
-True
-True
-never
-in
+False
-
+
True
-False
-
-
-True
-True
-GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
-True
-True
-
-
-Click the
graphics that you want to use as bullets.
-
-
+True
+GDK_BUTTON_PRESS_MASK |
GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK |
GDK_STRUCTURE_MASK
+True
+True
+
+
+Click the
graphics that you want to use as bullets.
-
-1
-0
-
-
-
-
-False
-True
-The Gallery theme 'Bullets' is empty (no
images).
-True
-
-
-0
-0
-
-
-
-
-Add and Resize
-True
-True
-False
-end
-
-
-1
-2
-
-
-
-
-
-
-
-
-
-
+
+1
+0
+
+
+
+
+False
+True
+The Gallery theme 'Bullets' is empty (no
images).
+True
+
+
+0
+0
+
-
-
+
+
+Add and Resize
True
-False
-Selection
-
-
-
+True
+False
+end
+
+
Minutes from the UX/design meeting 2023-Mar-13
Present: Sahil, Rafel, (John), Nameless, Heiko Comments: Bob, Cor, Mike, Eyal Tickets/Topics * Cannot resize graphical objects that overlap header/footer + https://bugs.documentfoundation.org/show_bug.cgi?id=159543 + change drag handles (Bob, Cor) + UI should give proper feedback (Sahil) + could be done by disabling the vertical and diagonal resize capability (which hides the size cursor then) + people may complain handles disappear; suggest NAB/WF (Rafael) + rather than hiding the handles we should block resizing before drag happens so the lower edge remains at the bottom (Rafael) + looks like a bug to me; suggest to show an infobar when the mouse is released but resize not accepted (Sahil) + infobar is disruptive here (Rafael) + change the drag frame color if the new size is not accepted/possible (Rafael) => do this * Changing Macro Security level should warn about the need to reload the file to apply the settings + https://bugs.documentfoundation.org/show_bug.cgi?id=159985 + Reload in the background for all documents is not possible since changes may have been made (Mike) + show infobar requesting the user to reload (Eyal) + show a label in the macros security option dialog (Rafael, Sahil) + could also be the restart now confirmation box (Heiko) => majority votes for the label * close all (documents / windows) Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=159380 + add new command but just for customization (Eyal, Rafael) + quit and restart (Cor) + close documents from all modules (Heiko) + alternatively show the start center while modules are open + closing all documents becomes more important if we have a tabbed UI (Sahil) => comment * Add max shrink and space width customization options to upcoming smart justification feature + https://bugs.documentfoundation.org/show_bug.cgi?id=159923 + as a compatibility feature any customization would deviate from DOCX (Heiko, Rafael, Nameless) + control on the paragraph level makes sense (Mike) + over-engineering is seldom good usability; no use case and no user request (yet) (Heiko) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-13
Present: Sahil, Rafel, (John), Nameless, Heiko Comments: Bob, Cor, Mike, Eyal Tickets/Topics * Cannot resize graphical objects that overlap header/footer + https://bugs.documentfoundation.org/show_bug.cgi?id=159543 + change drag handles (Bob, Cor) + UI should give proper feedback (Sahil) + could be done by disabling the vertical and diagonal resize capability (which hides the size cursor then) + people may complain handles disappear; suggest NAB/WF (Rafael) + rather than hiding the handles we should block resizing before drag happens so the lower edge remains at the bottom (Rafael) + looks like a bug to me; suggest to show an infobar when the mouse is released but resize not accepted (Sahil) + infobar is disruptive here (Rafael) + change the drag frame color if the new size is not accepted/possible (Rafael) => do this * Changing Macro Security level should warn about the need to reload the file to apply the settings + https://bugs.documentfoundation.org/show_bug.cgi?id=159985 + Reload in the background for all documents is not possible since changes may have been made (Mike) + show infobar requesting the user to reload (Eyal) + show a label in the macros security option dialog (Rafael, Sahil) + could also be the restart now confirmation box (Heiko) => majority votes for the label * close all (documents / windows) Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=159380 + add new command but just for customization (Eyal, Rafael) + quit and restart (Cor) + close documents from all modules (Heiko) + alternatively show the start center while modules are open + closing all documents becomes more important if we have a tabbed UI (Sahil) => comment * Add max shrink and space width customization options to upcoming smart justification feature + https://bugs.documentfoundation.org/show_bug.cgi?id=159923 + as a compatibility feature any customization would deviate from DOCX (Heiko, Rafael, Nameless) + control on the paragraph level makes sense (Mike) + over-engineering is seldom good usability; no use case and no user request (yet) (Heiko) => resolve WF OpenPGP_signature.asc Description: OpenPGP digital signature
Re: Digression from [libreoffice-design] Minutes from the UX/design meeting 2023-Mar-07
On 08.03.24 17:08, paul hofseth wrote: I repeat my resultless calling for concentration on overall function without crashing, rather than on small improvements to appearance and efficiency of use. We are many volunteers and not everyone is able to fix bugs. And I miss links to your bugreports where you have added the test documents. please do create a "life vest"- rescue button mode: which will enable users to copy existing text while waiting to shut it down...Ticket or nothing happened :-). But your idea sounds not like a solution but rather a and-aid. Besides, OpenOffice is ancient software with a lot of security holes. Perhaps you find something appropriate in our archive at https://downloadarchive.documentfoundation.org/libreoffice/old/ Cross-posting to mailing lists is not recommended. Just the QA list would have been enough - but Bugzilla is the better place to share issues and ideas anyway. OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-07
Present: Cor, Sahil, Felix, Rafael, Hossein, Heiko Comments: Stephane, Ady, Stuart Tickets/Topics * Auto-size the "Search Results" dialog (after a find & replace across multiple sheets) to avoid scrolling + https://bugs.documentfoundation.org/show_bug.cgi?id=157207 + use ellipsis too (Stephane) + emphasizing the text that is explicitly being searched (Ady) + bug 157227 + agree with the request to use more of the display (Stuart) + wrapping might be another idea (Rafael) + rather not because makes reading more difficult (Sahil) + ellipsis at start and end to bring the search term into the view (Felix) + simple solution covers most cases (and can be done as easyhack) (Cor) + ellipsis hinders reading the text, eg. if the search term is near end (Cor) + dialog is good as it, width should be adjusted carefully (Hossein) + With various scaling factors (2x, 3x, etc.) and different DPIs (HiDPI) these days, the issue of too big / too small dialogs and the need to add scrolling can also be seen elsewhere (Hossein) => resize the dialog if the content takes more space but only up to a reasonable width * CALC UI: Menu item "View headers" in menu "View" named wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=159738 + changed because of the Notebookbar a) have a dedicated NotebookbarLabel b) change back and accept the longer label + or hide the View Header command in the NB variant c) change the UI label to "View Headers" d) accept the situation, ie. NAB/WF + a) sounds good but c) could be a quick solution here (Rafael) + probably with some tooltip (Heiko) + a) is okay but prefer d) rather than c) (Cor) + nitpicking anyway; tooltip is good (Rafael) + icon on the command would be nice (Felix) => add a tooltip "Toggle row/column header on/off" to command and the tools > options dialog * UI: A button to expand the animation picker dialog to dedicated dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=145038 + icons may help, even in the current form, in sidebar (Hossein) + icon view like at the transition deck sounds good (Rafael) + dedicated dialog needed for notebookbar-only variants (Sahil) + on the long run we should add some styles-like widget for animations as known from MSO (Hossein) => comment * Reworking of dialogues Organize macros (make from 5 existing only one) + https://bugs.documentfoundation.org/show_bug.cgi?id=120658 + Issue is worse than that considering Python, and APSO (Hossein) + Most things (editing, etc.) are not usable for Python, even with 5 dialogs (Hossein) + Every change should have in mind that it is about macro programming in general, and not only BASIC scripting (Hossein) + unified dialogs are not always easier to use (Cor) + suggested proposal is difficult to implement and suspect a lot of side effects (Rafael) + APSO is the way to go for Python at least (Rafael, Hossein) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Mar-07
Present: Cor, Sahil, Felix, Rafael, Hossein, Heiko Comments: Stephane, Ady, Stuart Tickets/Topics * Auto-size the "Search Results" dialog (after a find & replace across multiple sheets) to avoid scrolling + https://bugs.documentfoundation.org/show_bug.cgi?id=157207 + use ellipsis too (Stephane) + emphasizing the text that is explicitly being searched (Ady) + bug 157227 + agree with the request to use more of the display (Stuart) + wrapping might be another idea (Rafael) + rather not because makes reading more difficult (Sahil) + ellipsis at start and end to bring the search term into the view (Felix) + simple solution covers most cases (and can be done as easyhack) (Cor) + ellipsis hinders reading the text, eg. if the search term is near end (Cor) + dialog is good as it, width should be adjusted carefully (Hossein) + With various scaling factors (2x, 3x, etc.) and different DPIs (HiDPI) these days, the issue of too big / too small dialogs and the need to add scrolling can also be seen elsewhere (Hossein) => resize the dialog if the content takes more space but only up to a reasonable width * CALC UI: Menu item "View headers" in menu "View" named wrong + https://bugs.documentfoundation.org/show_bug.cgi?id=159738 + changed because of the Notebookbar a) have a dedicated NotebookbarLabel b) change back and accept the longer label + or hide the View Header command in the NB variant c) change the UI label to "View Headers" d) accept the situation, ie. NAB/WF + a) sounds good but c) could be a quick solution here (Rafael) + probably with some tooltip (Heiko) + a) is okay but prefer d) rather than c) (Cor) + nitpicking anyway; tooltip is good (Rafael) + icon on the command would be nice (Felix) => add a tooltip "Toggle row/column header on/off" to command and the tools > options dialog * UI: A button to expand the animation picker dialog to dedicated dialog + https://bugs.documentfoundation.org/show_bug.cgi?id=145038 + icons may help, even in the current form, in sidebar (Hossein) + icon view like at the transition deck sounds good (Rafael) + dedicated dialog needed for notebookbar-only variants (Sahil) + on the long run we should add some styles-like widget for animations as known from MSO (Hossein) => comment * Reworking of dialogues Organize macros (make from 5 existing only one) + https://bugs.documentfoundation.org/show_bug.cgi?id=120658 + Issue is worse than that considering Python, and APSO (Hossein) + Most things (editing, etc.) are not usable for Python, even with 5 dialogs (Hossein) + Every change should have in mind that it is about macro programming in general, and not only BASIC scripting (Hossein) + unified dialogs are not always easier to use (Cor) + suggested proposal is difficult to implement and suspect a lot of side effects (Rafael) + APSO is the way to go for Python at least (Rafael, Hossein) => comment OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: sfx2/source
sfx2/source/dialog/infobar.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 06d8c1e9d8ba1d04914d1c48c94732cdb5c68846 Author: Heiko Tietze AuthorDate: Wed Mar 6 10:35:53 2024 +0100 Commit: Heiko Tietze CommitDate: Wed Mar 6 11:58:07 2024 +0100 Resolves tdf#159486 - Larger hitbox for close button on infobar Change-Id: I83582c0c1ec7dd5e8f82bdf327e68ce88122ad03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164450 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx index ca848813f09e..38a510a2589c 100644 --- a/sfx2/source/dialog/infobar.cxx +++ b/sfx2/source/dialog/infobar.cxx @@ -103,9 +103,12 @@ void SfxInfoBarWindow::SetCloseButtonImage() aSize = Size(aSize.Width() * 1.5, aSize.Height() * 1.5); ScopedVclPtr xDevice(m_xCloseBtn->create_virtual_device()); -xDevice->SetOutputSizePixel(aSize); +xDevice->SetOutputSizePixel(Size(24, 24)); +xDevice->SetBackground(Color(m_aBackgroundColor)); +xDevice->Erase(); -Point aBtnPos(0, 0); +const int nPos = (24 - aSize.getWidth()) / 2; +Point aBtnPos(nPos, nPos); const ViewInformation2D aNewViewInfos; const std::unique_ptr pProcessor(
core.git: Branch 'libreoffice-7-6' - sfx2/source
sfx2/source/view/viewfrm.cxx | 173 ++-
1 file changed, 92 insertions(+), 81 deletions(-)
New commits:
commit 8f3fb27880d6374f531cb012fe3b53179ecd4313
Author: Heiko Tietze
AuthorDate: Wed Feb 28 10:30:48 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 28 22:49:55 2024 +0100
Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible
Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 607740654f2264e13469e4da1d020448217d7222)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164115
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 4bfb58a724ec..e6f81d53e873 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1450,88 +1450,8 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/,
const SfxHint& rHint )
rBind.Invalidate( SID_RELOAD );
rBind.Invalidate( SID_EDITDOC );
-#if !ENABLE_WASM_STRIP_PINGUSER
-bool bIsHeadlessOrUITest =
SfxApplication::IsHeadlessOrUITest(); //uitest.uicheck fails when the dialog is
open
-
-//what's new infobar
-if (utl::isProductVersionUpgraded(true) &&
!bIsHeadlessOrUITest)
-{
-VclPtr pInfoBar =
AppendInfoBar("whatsnew", "", SfxResId(STR_WHATSNEW_TEXT), InfobarType::INFO);
-if (pInfoBar)
-{
-weld::Button& rWhatsNewButton = pInfoBar->addButton();
-
rWhatsNewButton.set_label(SfxResId(STR_WHATSNEW_BUTTON));
-rWhatsNewButton.connect_clicked(LINK(this,
SfxViewFrame, WhatsNewHandler));
-}
-}
-
-// show tip-of-the-day dialog if it due, but not if there is
the impress modal template dialog
-// open where SdModule::ExecuteNewDocument will launch it
instead when that dialog is dismissed
-if (SfxApplication::IsTipOfTheDayDue() && !bIsHeadlessOrUITest
&& !IsInModalMode())
-{
-// tdf#127946 pass in argument for dialog parent
-SfxUnoFrameItem aDocFrame(SID_FILLFRAME,
GetFrame().GetFrameInterface());
-GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY,
SfxCallMode::SLOT, {}, { });
-}
-
-// inform about the community involvement
-const auto t0 =
std::chrono::system_clock::now().time_since_epoch();
-const sal_Int64 nLastGetInvolvedShown =
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow =
std::chrono::duration_cast(t0).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow +
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getinvolved", "", SfxResId(STR_GET_INVOLVED_TEXT),
InfobarType::INFO);
-
-if (pInfoBar)
-{
-weld::Button& rGetInvolvedButton =
pInfoBar->addButton();
-
rGetInvolvedButton.set_label(SfxResId(STR_GET_INVOLVED_BUTTON));
-rGetInvolvedButton.connect_clicked(LINK(this,
SfxViewFrame, GetInvolvedHandler));
-}
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&&
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown =
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow -
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonate
core.git: Branch 'libreoffice-24-2' - sfx2/source
sfx2/source/view/viewfrm.cxx | 173 ++-
1 file changed, 92 insertions(+), 81 deletions(-)
New commits:
commit 9b0ec6639e7218b93551fc680b0929a73ac1fd90
Author: Heiko Tietze
AuthorDate: Wed Feb 28 10:30:48 2024 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 28 22:27:07 2024 +0100
Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible
Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit 607740654f2264e13469e4da1d020448217d7222)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164114
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index c6b25637ccf3..b14ff206fa96 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1496,88 +1496,8 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/,
const SfxHint& rHint )
rBind.Invalidate( SID_RELOAD );
rBind.Invalidate( SID_EDITDOC );
-#if !ENABLE_WASM_STRIP_PINGUSER
-bool bIsHeadlessOrUITest =
SfxApplication::IsHeadlessOrUITest(); //uitest.uicheck fails when the dialog is
open
-
-//what's new infobar
-if (utl::isProductVersionUpgraded(true) &&
!bIsHeadlessOrUITest)
-{
-VclPtr pInfoBar =
AppendInfoBar("whatsnew", "", SfxResId(STR_WHATSNEW_TEXT), InfobarType::INFO);
-if (pInfoBar)
-{
-weld::Button& rWhatsNewButton = pInfoBar->addButton();
-
rWhatsNewButton.set_label(SfxResId(STR_WHATSNEW_BUTTON));
-rWhatsNewButton.connect_clicked(LINK(this,
SfxViewFrame, WhatsNewHandler));
-}
-}
-
-// show tip-of-the-day dialog if it due, but not if there is
the impress modal template dialog
-// open where SdModule::ExecuteNewDocument will launch it
instead when that dialog is dismissed
-if (SfxApplication::IsTipOfTheDayDue() && !bIsHeadlessOrUITest
&& !IsInModalMode())
-{
-// tdf#127946 pass in argument for dialog parent
-SfxUnoFrameItem aDocFrame(SID_FILLFRAME,
GetFrame().GetFrameInterface());
-GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY,
SfxCallMode::SLOT, {}, { });
-}
-
-// inform about the community involvement
-const auto t0 =
std::chrono::system_clock::now().time_since_epoch();
-const sal_Int64 nLastGetInvolvedShown =
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow =
std::chrono::duration_cast(t0).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 180); // 180 days in
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastGetInvolvedShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastGetInvolvedShown < (nNow +
nPeriodSec/2) - nPeriodSec) // 90d alternating with donation
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar =
AppendInfoBar("getinvolved", "", SfxResId(STR_GET_INVOLVED_TEXT),
InfobarType::INFO);
-
-if (pInfoBar)
-{
-weld::Button& rGetInvolvedButton =
pInfoBar->addButton();
-
rGetInvolvedButton.set_label(SfxResId(STR_GET_INVOLVED_BUTTON));
-rGetInvolvedButton.connect_clicked(LINK(this,
SfxViewFrame, GetInvolvedHandler));
-}
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&&
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
-{
-std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
-batch->commit();
-}
-
-// inform about donations
-const sal_Int64 nLastDonateShown =
officecfg::Setup::Product::LastTimeDonateShown::get();
-bool bUpdateLastTimeDonateShown = false;
-
-if (nLastDonateShown == 0)
-bUpdateLastTimeDonateShown = true;
-else if (nPeriodSec < nNow && nLastDonateShown < nNow -
nPeriodSec) // 90d alternating with getinvolved
-{
-bUpdateLastTimeDonate
Minutes from the UX/design meeting 2023-Feb-28
Present: Sahil, John, Eyal, Heiko Comments: Ady, Mike, Rainer, Timur, Stuart, Tomaz Tickets/Topics * Lowercase "a" and uppercase "A" wrongly shows as one "a" in Autofilter dropdown + https://bugs.documentfoundation.org/show_bug.cgi?id=159737 + AutoFilter follows the setting in the Standard Filter (Ady) + a) WF/NAB, b) description, c) configuration (Mike) + not so clear whether case-sensitivity works (Rainer) + would expect case-sensitivity (John) + users might be not aware of uppercase character/word if we hide it; rather let the user uncheck (Heiko) + all options better go to the full filter dialog (Sahil) + Excel shows items case-sensitive (John) + make it independent from standard filter option (Heiko) => comment * UI: Cell protection dialog reference menu that don't exist + https://bugs.documentfoundation.org/show_bug.cgi?id=159748 + remove this part from the string (Heiko, Timur) + menu does exists; against changing the string (Ady, Stuart) + point to the help page (Tomaz) + against this hint to "use the help content" (Ady) + link to the appropriate help pages is reasonable (Stuart) + idea was probably to have a hyperlink in the string + alternatively change the label depending on the UI mode, or amend the existing text with the Notebookbar solution (Eyal) + sheet/cell protection is not for beginners and we can expect users to learn the function (Sahil) => preferably use a more generic description * Manage changes dialog should allow action on all filtered changes + https://bugs.documentfoundation.org/show_bug.cgi?id=115515 + WFM/INV, at least from the sidebar (Heiko) => resolve ticket * Consistent polygon tool behavior in Draw + https://bugs.documentfoundation.org/show_bug.cgi?id=131758 + (1) how to finish the input: easy to miss and hard to undo (Eyal) + perhaps have some interaction to undo the last point + edit points allow to remove unwanted + (2) finishing methods: MSO ends polygon as well per double-click but also on escape + (3) close a polyline: by ctrl+click? in any case up to documentation + (4) how to enter PolyPoly-mode: same answer as above + (5) Is it really intended... obviously no user has joined the discussion + users tend to accept shortcomings and we might do better (Eyal) + would rather think of a list that takes all points and allows to edit independently from the interaction method (Heiko) + giving a hint on the interaction at the command label? not so good (John) + any change needs to be a convincing improvement (Eyal) + Inkscape behavior is similar to our workflow => comment OpenPGP_signature.asc Description: OpenPGP digital signature
Minutes from the UX/design meeting 2023-Feb-28
Present: Sahil, John, Eyal, Heiko Comments: Ady, Mike, Rainer, Timur, Stuart, Tomaz Tickets/Topics * Lowercase "a" and uppercase "A" wrongly shows as one "a" in Autofilter dropdown + https://bugs.documentfoundation.org/show_bug.cgi?id=159737 + AutoFilter follows the setting in the Standard Filter (Ady) + a) WF/NAB, b) description, c) configuration (Mike) + not so clear whether case-sensitivity works (Rainer) + would expect case-sensitivity (John) + users might be not aware of uppercase character/word if we hide it; rather let the user uncheck (Heiko) + all options better go to the full filter dialog (Sahil) + Excel shows items case-sensitive (John) + make it independent from standard filter option (Heiko) => comment * UI: Cell protection dialog reference menu that don't exist + https://bugs.documentfoundation.org/show_bug.cgi?id=159748 + remove this part from the string (Heiko, Timur) + menu does exists; against changing the string (Ady, Stuart) + point to the help page (Tomaz) + against this hint to "use the help content" (Ady) + link to the appropriate help pages is reasonable (Stuart) + idea was probably to have a hyperlink in the string + alternatively change the label depending on the UI mode, or amend the existing text with the Notebookbar solution (Eyal) + sheet/cell protection is not for beginners and we can expect users to learn the function (Sahil) => preferably use a more generic description * Manage changes dialog should allow action on all filtered changes + https://bugs.documentfoundation.org/show_bug.cgi?id=115515 + WFM/INV, at least from the sidebar (Heiko) => resolve ticket * Consistent polygon tool behavior in Draw + https://bugs.documentfoundation.org/show_bug.cgi?id=131758 + (1) how to finish the input: easy to miss and hard to undo (Eyal) + perhaps have some interaction to undo the last point + edit points allow to remove unwanted + (2) finishing methods: MSO ends polygon as well per double-click but also on escape + (3) close a polyline: by ctrl+click? in any case up to documentation + (4) how to enter PolyPoly-mode: same answer as above + (5) Is it really intended... obviously no user has joined the discussion + users tend to accept shortcomings and we might do better (Eyal) + would rather think of a list that takes all points and allows to edit independently from the interaction method (Heiko) + giving a hint on the interaction at the command label? not so good (John) + any change needs to be a convincing improvement (Eyal) + Inkscape behavior is similar to our workflow => comment OpenPGP_signature.asc Description: OpenPGP digital signature
