[Libreoffice-commits] core.git: chart2/qa chart2/source
chart2/qa/extras/chart2import.cxx| 17 - chart2/source/tools/InternalDataProvider.cxx |7 ++- 2 files changed, 14 insertions(+), 10 deletions(-) New commits: commit 18b3138a7ac4da823e41640bed8a4707029b8fb0 Author: Jean-Tiare Le Bigot Date: Mon Nov 28 09:09:55 2016 +0100 tdf#102621: import empty chart cells as NaN instead of 0 Change-Id: I574c3f719e52bc2244597532783130564621a891 Reviewed-on: https://gerrit.libreoffice.org/31303 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index b508f3e..be36047 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -25,7 +25,6 @@ #include - class Chart2ImportTest : public ChartTest { public: @@ -413,13 +412,13 @@ void Chart2ImportTest::testPPTXSparseChartSeries() std::vector > aValues = getDataSeriesYValuesFromChartType(xCT); CPPUNIT_ASSERT_EQUAL(size_t(2), aValues.size()); -CPPUNIT_ASSERT_EQUAL(0.0, aValues[0][0]); +CPPUNIT_ASSERT( rtl::math::isNan( aValues[0][0] ) ); CPPUNIT_ASSERT_EQUAL(2.5, aValues[0][1]); CPPUNIT_ASSERT_EQUAL(3.5, aValues[0][2]); -CPPUNIT_ASSERT_EQUAL(0.0, aValues[0][3]); +CPPUNIT_ASSERT( rtl::math::isNan( aValues[0][3] ) ); CPPUNIT_ASSERT_EQUAL(-2.4, aValues[1][0]); -CPPUNIT_ASSERT_EQUAL(0.0, aValues[1][1]); -CPPUNIT_ASSERT_EQUAL(0.0, aValues[1][2]); +CPPUNIT_ASSERT( rtl::math::isNan( aValues[1][1] ) ); +CPPUNIT_ASSERT( rtl::math::isNan( aValues[1][2] ) ); CPPUNIT_ASSERT_EQUAL(-2.8, aValues[1][3]); } @@ -1169,17 +1168,17 @@ void Chart2ImportTest::testInternalDataProvider() { // Parse empty first and last xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{\"\";42;42;\"\"}"); xSequence = xDataSeq->getData(); -CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(0)), xSequence[0]); +CPPUNIT_ASSERT( rtl::math::isNan( *static_cast(xSequence[0].getValue(; CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(42)), xSequence[1]); CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(42)), xSequence[2]); -CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(0)), xSequence[3]); +CPPUNIT_ASSERT( rtl::math::isNan( *static_cast(xSequence[3].getValue(; // Parse empty middle xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{42;\"\";\"\";42}"); xSequence = xDataSeq->getData(); CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(42)), xSequence[0]); -CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(0)), xSequence[1]); -CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(0)), xSequence[2]); +CPPUNIT_ASSERT( rtl::math::isNan( *static_cast(xSequence[1].getValue())) ); +CPPUNIT_ASSERT( rtl::math::isNan( *static_cast(xSequence[2].getValue())) ); CPPUNIT_ASSERT_EQUAL(uno::Any(sal_Int32(42)), xSequence[3]); // Parse mixed types, numeric only role diff --git a/chart2/source/tools/InternalDataProvider.cxx b/chart2/source/tools/InternalDataProvider.cxx index ef6facd..9f5f318 100644 --- a/chart2/source/tools/InternalDataProvider.cxx +++ b/chart2/source/tools/InternalDataProvider.cxx @@ -573,7 +573,12 @@ InternalDataProvider::createDataSequenceFromArray( const OUString& rArrayStr, co std::vector aValues; aValues.reserve(aRawElems.size()); for (OUString & aRawElem : aRawElems) -aValues.push_back(aRawElem.toDouble()); +{ +if (aRawElem.isEmpty()) +aValues.push_back(NAN); +else +aValues.push_back(aRawElem.toDouble()); +} sal_Int32 n = m_aInternalData.appendColumn(); m_aInternalData.setColumnValues(n, aValues); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/chart/titlecontext.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 9a86bf76fe1d8457c12026b9f96c0ce971b29b53 Author: Jean-Tiare Le Bigot Date: Mon Nov 14 00:15:15 2016 +0100 chartx: (regression) fix crash on label import The sparse chart import moved from assuming that the number of elements in the list parsed from ooxml is the same as the real number of elements. For this, the patch relies on a new member that was not always initialized. This patch fixes a missing initialization. According to 'grep' this should be the last one. Change-Id: I31d8a653f227100436360deef4a53c9418de9d93 Reviewed-on: https://gerrit.libreoffice.org/30838 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/oox/source/drawingml/chart/titlecontext.cxx b/oox/source/drawingml/chart/titlecontext.cxx index 6064178..6bbdf0f 100644 --- a/oox/source/drawingml/chart/titlecontext.cxx +++ b/oox/source/drawingml/chart/titlecontext.cxx @@ -78,6 +78,7 @@ void TextContext::onCharacters( const OUString& rChars ) // Also store it as a single element type for non-Excel document. mrModel.mxDataSeq->maData[0] <<= rChars; +mrModel.mxDataSeq->mnPointCount = 1; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Crash test update
OK, this is the same pattern as the case handled in: git show 4bcf1872 oox/source/drawingml/chart/typegroupconverter.cxx There might similar bugs hanging around. In a nutshell, some fallback code in the importer forgot to init some part of the structure. This was fine until we moved from relying on the element count to relying on the last element index. Here is a tentative fix: https://gerrit.libreoffice.org/30838 Le 11/11/2016 à 17:20, Caolán McNamara a écrit : On Thu, 2016-11-10 at 21:38 +0100, Jean-Tiare LE BIGOT wrote: Thanks for the explanations ! Unfortunately, I can't access https://bugzilla.novell.com/show_bug.cgi?id=403458. Can someone grant access to 'yadutaf' / ad...@jtlebi.fr or send me privately a copy of this file to troubleshoot ? I tried to reproduce the crashes with some of the files I have access to: - fdo58197-1.pptx fdo58197-1.pptx will do fine to reproduce it, they're all the same issue. They all seem to crash somewhere in libxmlreaderlo.so. It seems unlikely to be related to commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c It crashes in libxmlreaderlo.so because an unexpected std::length_error exception is thrown and it dies through std::terminate. My commit "fixes" this by making those methods allow std::exception derived exceptions to be thrown through them, so it doesn't crash. if you... gdb --args ./instdir/program/soffice.bin --headless --convert-to pdf fdo58197-1.pptx (gdb) catch throw std::length_error (gdb) run (gdb) up... a bunch of times until you get to chartconverter.cxx you'll see that chartconverter.cxx:136 is Matrix< Any > aMatrix( rDataSeq.mnPointCount, 1 ) and rDataSeq.mnPointCount is -1, which doesn't make sense as a length argument to vector::resize C. -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Crash test update
Thanks for the explanations ! Unfortunately, I can't access https://bugzilla.novell.com/show_bug.cgi?id=403458. Can someone grant access to 'yadutaf' / ad...@jtlebi.fr or send me privately a copy of this file to troubleshoot ? I tried to reproduce the crashes with some of the files I have access to: - tdf78296-1.pptx - tdf95549-3.xlsm - tdf90979-2.xlsx - fdo43711-1.xlsx - fdo58197-1.pptx - fdo54460-1.pptx They all seem to crash somewhere in libxmlreaderlo.so. It seems unlikely to be related to commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c I'll double check with a full rebuild with the patch reverted. Le 09/11/2016 à 10:25, Caolán McNamara a écrit : On Tue, 2016-11-08 at 23:08 +, Crashtest VM wrote: New crashtest update available at http://dev- builds.libreoffice.org/crashtest/64a708cba9b954afe3331f63c58218eb53b3 d0ce/ Lots of new pptx failures since... commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c Date: Thu Oct 13 23:43:41 2016 +0200 chartx: fix sparse chart import e.g. novell403458-1.pptx -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Crash test update
The list of files triggering the crash appears to be in http://dev-builds.libreoffice.org/crashtest/64a708cba9b954afe3331f63c58218eb53b3d0ce/crashlog.txt. Can you point at the actual files location ? Le 09/11/2016 à 10:25, Caolán McNamara a écrit : On Tue, 2016-11-08 at 23:08 +, Crashtest VM wrote: New crashtest update available at http://dev- builds.libreoffice.org/crashtest/64a708cba9b954afe3331f63c58218eb53b3 d0ce/ Lots of new pptx failures since... commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c Date: Thu Oct 13 23:43:41 2016 +0200 chartx: fix sparse chart import e.g. novell403458-1.pptx -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: chart2/qa oox/source
chart2/qa/extras/chart2import.cxx | 24 + chart2/qa/extras/data/pptx/sparse-chart.pptx |binary oox/source/drawingml/chart/chartconverter.cxx |9 +++ oox/source/drawingml/chart/datasourceconverter.cxx |2 - oox/source/drawingml/chart/typegroupconverter.cxx |1 5 files changed, 30 insertions(+), 6 deletions(-) New commits: commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c Author: Jean-Tiare Le Bigot Date: Thu Oct 13 23:43:41 2016 +0200 chartx: fix sparse chart import Change-Id: I1bcd2257da900c6a88bc78040fabe5696e2bab7d Reviewed-on: https://gerrit.libreoffice.org/29801 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index c8137b9..b508f3e 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -40,6 +40,7 @@ public: void testDOCChartSeries(); void testDOCXChartSeries(); void testPPTXChartSeries(); +void testPPTXSparseChartSeries(); /** * Original data contains 3 series but 2 of them are hidden. For now, we * detect and skip those hidden series on import (since we don't support @@ -105,6 +106,7 @@ public: CPPUNIT_TEST(testDOCXChartSeries); CPPUNIT_TEST(testPPTChartSeries); CPPUNIT_TEST(testPPTXChartSeries); +CPPUNIT_TEST(testPPTXSparseChartSeries); CPPUNIT_TEST(testPPTXHiddenDataSeries); CPPUNIT_TEST(testPPTXPercentageNumberFormats); CPPUNIT_TEST(testPPTXStackedNonStackedYAxis); @@ -399,6 +401,28 @@ void Chart2ImportTest::testPPTXChartSeries() CPPUNIT_ASSERT_EQUAL(OUString("Column 3"), aLabels[2][0].get()); } +void Chart2ImportTest::testPPTXSparseChartSeries() +{ +//test chart series sparse data for pptx +load("/chart2/qa/extras/data/pptx/", "sparse-chart.pptx"); +Reference xChartDoc(getChartDocFromDrawImpress(0, 0), uno::UNO_QUERY); +CPPUNIT_ASSERT(xChartDoc.is()); + +Reference xCT = getChartTypeFromDoc(xChartDoc, 0); +CPPUNIT_ASSERT(xCT.is()); + +std::vector > aValues = getDataSeriesYValuesFromChartType(xCT); +CPPUNIT_ASSERT_EQUAL(size_t(2), aValues.size()); +CPPUNIT_ASSERT_EQUAL(0.0, aValues[0][0]); +CPPUNIT_ASSERT_EQUAL(2.5, aValues[0][1]); +CPPUNIT_ASSERT_EQUAL(3.5, aValues[0][2]); +CPPUNIT_ASSERT_EQUAL(0.0, aValues[0][3]); +CPPUNIT_ASSERT_EQUAL(-2.4, aValues[1][0]); +CPPUNIT_ASSERT_EQUAL(0.0, aValues[1][1]); +CPPUNIT_ASSERT_EQUAL(0.0, aValues[1][2]); +CPPUNIT_ASSERT_EQUAL(-2.8, aValues[1][3]); +} + void Chart2ImportTest::testPPTXHiddenDataSeries() { load("/chart2/qa/extras/data/pptx/", "stacked-bar-chart-hidden-series.pptx"); diff --git a/chart2/qa/extras/data/pptx/sparse-chart.pptx b/chart2/qa/extras/data/pptx/sparse-chart.pptx new file mode 100755 index 000..d91e8f5 Binary files /dev/null and b/chart2/qa/extras/data/pptx/sparse-chart.pptx differ diff --git a/oox/source/drawingml/chart/chartconverter.cxx b/oox/source/drawingml/chart/chartconverter.cxx index d494302..ff43fa7 100644 --- a/oox/source/drawingml/chart/chartconverter.cxx +++ b/oox/source/drawingml/chart/chartconverter.cxx @@ -133,11 +133,10 @@ Reference< XDataSequence > ChartConverter::createDataSequence( if( !rDataSeq.maData.empty() ) { // create a single-row array from constant source data -Matrix< Any > aMatrix( rDataSeq.maData.size(), 1 ); -Matrix< Any >::iterator aMIt = aMatrix.begin(); -// TODO: how to handle missing values in the map? -for( DataSequenceModel::AnyMap::const_iterator aDIt = rDataSeq.maData.begin(), aDEnd = rDataSeq.maData.end(); aDIt != aDEnd; ++aDIt, ++aMIt ) -*aMIt = aDIt->second; +Matrix< Any > aMatrix( rDataSeq.mnPointCount, 1 ); +for( DataSequenceModel::AnyMap::const_iterator aDIt = rDataSeq.maData.begin(), aDEnd = rDataSeq.maData.end(); aDIt != aDEnd; ++aDIt ) +*aMatrix.at(aDIt->first, 0) = aDIt->second; + aRangeRep = lclGenerateApiArray( aMatrix ); } diff --git a/oox/source/drawingml/chart/datasourceconverter.cxx b/oox/source/drawingml/chart/datasourceconverter.cxx index 2c3dbcf..738e705 100644 --- a/oox/source/drawingml/chart/datasourceconverter.cxx +++ b/oox/source/drawingml/chart/datasourceconverter.cxx @@ -69,7 +69,7 @@ Reference< XDataSequence > DataSequenceConverter::createDataSequence( const OUSt if(!bFirst) { mrModel.maData.clear(); -mrModel.maData.insert(std::make_pair(1, Any(aTitle.makeStringAndClear(; +mrModel.maData.insert(std::make_pair(0, Any(aTitle.makeStringAndClear(; } } xDataSeq = getChartConverter().createDataSequence(getChartDocument()->getDataProvider(), mrModel,
[Libreoffice-commits] core.git: chart2/qa chart2/source
chart2/qa/extras/chart2import.cxx| 50 +++ chart2/source/tools/InternalDataProvider.cxx | 11 + 2 files changed, 52 insertions(+), 9 deletions(-) New commits: commit 27a4fb657fad157d26d07934ecd0cce578a99f38 Author: Jean-Tiare Le Bigot Date: Tue Oct 18 23:36:51 2016 +0200 chart2: fix unserialization of empty cells Change-Id: Ib7e5c8c4db6cac7ef1255246eea13325cf7cca69 Reviewed-on: https://gerrit.libreoffice.org/30030 Reviewed-by: jan iversen Tested-by: jan iversen diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx index 7d0f8f2..bff7e81 100644 --- a/chart2/qa/extras/chart2import.cxx +++ b/chart2/qa/extras/chart2import.cxx @@ -90,6 +90,8 @@ public: void testSecondaryAxisTitleDefaultRotationXLSX(); void testAxisTitleRotationXLSX(); +void testInternalDataProvider(); + CPPUNIT_TEST_SUITE(Chart2ImportTest); CPPUNIT_TEST(Fdo60083); CPPUNIT_TEST(testSteppedLines); @@ -139,6 +141,9 @@ public: CPPUNIT_TEST(testAxisTitleDefaultRotationXLSX); CPPUNIT_TEST(testSecondaryAxisTitleDefaultRotationXLSX); CPPUNIT_TEST(testAxisTitleRotationXLSX); + +CPPUNIT_TEST(testInternalDataProvider); + CPPUNIT_TEST_SUITE_END(); private: @@ -1125,6 +1130,51 @@ void Chart2ImportTest::testAxisTitleRotationXLSX() } +void Chart2ImportTest::testInternalDataProvider() { +uno::Reference< chart2::XChartDocument > xChartDoc(getChartDocFromImpress("/chart2/qa/extras/data/odp/", "chart.odp"), uno::UNO_QUERY_THROW); +const uno::Reference< chart2::data::XDataProvider >& rxDataProvider = xChartDoc->getDataProvider(); + +// Parse 42 array +Reference xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{42;42;42;42}"); +Sequence xSequence = xDataSeq->getData(); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[0]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[1]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[2]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[3]); + +// Parse empty first and last +xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{\"\";42;42;\"\"}"); +xSequence = xDataSeq->getData(); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[0]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[1]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[2]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[3]); + +// Parse empty middle +xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{42;\"\";\"\";42}"); +xSequence = xDataSeq->getData(); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[0]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[1]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[2]); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[3]); + +// Parse mixed types, numeric only role +xDataSeq = rxDataProvider->createDataSequenceByValueArray("values-y", "{42;\"hello\";0;\"world\"}"); +xSequence = xDataSeq->getData(); +CPPUNIT_ASSERT_EQUAL(uno::Any(42), xSequence[0]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[1]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[2]); +CPPUNIT_ASSERT_EQUAL(uno::Any(0), xSequence[3]); + +// Parse mixed types, mixed role +xDataSeq = rxDataProvider->createDataSequenceByValueArray("categories", "{42;\"hello\";0;\"world\"}"); +xSequence = xDataSeq->getData(); +CPPUNIT_ASSERT_EQUAL(uno::Any(OUString("42")),xSequence[0]); +CPPUNIT_ASSERT_EQUAL(uno::Any(OUString("hello")), xSequence[1]); +CPPUNIT_ASSERT_EQUAL(uno::Any(OUString("0")), xSequence[2]); +CPPUNIT_ASSERT_EQUAL(uno::Any(OUString("world")), xSequence[3]); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/chart2/source/tools/InternalDataProvider.cxx b/chart2/source/tools/InternalDataProvider.cxx index 32dd3c7..7bcb65f0 100644 --- a/chart2/source/tools/InternalDataProvider.cxx +++ b/chart2/source/tools/InternalDataProvider.cxx @@ -533,10 +533,7 @@ InternalDataProvider::createDataSequenceFromArray( const OUString& rArrayStr, co { // Opening quote. bAllNumeric = false; -++p; -if (p == pEnd) -break; -pElem = p; +pElem = nullptr; } else { @@ -552,11 +549,7 @@ InternalDataProvider::createDataSequenceFromArray( const OUString& rArrayStr, co break; } } -else if (bInQuote) -{ -// Do nothing. -} -else
[Libreoffice-commits] core.git: Changes to 'refs/changes/37/337/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/90/390/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/90/390/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/85/385/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/77/377/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/85/385/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/77/377/4'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/77/377/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/77/377/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/99/399/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/99/399/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] Modified the wording of the Save-on-Exit-Dialog
Wow, Much nicer this way ! Le 2012-08-23 21:47, Samuel Mehrbrodt a écrit : Hi, I have a suggestion to change the wording of the Dialog which appears when you close a document and unsaved changes exist. See attached images with the difference before/after. I wrote a mail to the ux-advise list [1] before and asked if this could be changed, but there was no reply (except one came to me directly, he was ok with it). I would also like to change the button order (move the Save button to the right), but I don't know how it fits with Windows/Mac. I needed to create a new translation string for the dialog title, is that ok the way I did it? Did I forget something? Thanks, Samuel [1] http://nabble.documentfoundation.org/Libreoffice-ux-advise-Exit-Dialog-Button-Order-and-Wording-tp4001483.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: pptx import filter
Hi all, Thanks for the tip. I spend hours tracing the bug with GDB but I stuck. I can not figure out where to fix it. Here is the situation: I have a pptx file with - title (fine) - 4 items in a list (buggy) In Powerpoint, all the text in the list is 18p but a signe word is 8p. In Impress, the begin of the text is 20p, the word at 8p is 8p an the remaining text is 8p also. After bisecting the pptx file, it appears that there is an empty "span" at the very beginning of the first list item. It's size is set to 20p. The only other "span" with a size specified is the one at 8p. All other elements have no size information on them. When an element has no size specified, it is imported with the same size as the immediate previous element whereas it should take the default size specified in the theme. In my case, the size is specified in the MasterSlide->OtherStyle->lvl1pPr. in the import filter, there is a file oox/source/drawingml/textrun.cxx:63 This is the only line where the size appears to be used in a computation. Ideed, manually forcing the size to 18 when at 0 fixes the problem for me. But... It's really not the right place nor the right way to do it since it would orverride the theme... I also know the themes in the master slide are imported properly. I also traced the code down to pptshape.cxx where the text seems to be imported into the core. I obviously missed something... My question is: where can I fix this Thanks a lot for your help (and patient reading) Le 2012-08-17 15:31, Miklos Vajna a écrit : On Fri, Aug 17, 2012 at 03:54:25PM +0200, Jean-Tiare LE BIGOT wrote: Is there anyone already working on the pptx import filter ? I'd like to work on the font size import. Is there any code shared between the pptx/docx/... filters ? Hi, Look under the oox/ module, that's shared between docx/xlsx/pptx. Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
pptx import filter
Hi ! Is there anyone already working on the pptx import filter ? I'd like to work on the font size import. Is there any code shared between the pptx/docx/... filters ? Regards, -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: the inevitable C formatting/brace style flamewar
Hi, Since the flamewar is already going on :p, is it OK not put a space after '(' nor before ')' in test and calls? I find this more readable whitout the spaces... Le 2012-08-16 20:12, Bjoern Michaelsen a écrit : Hi Michael, first: Thanks for keeping an old StarDivision tradition alive! On Thu, Aug 16, 2012 at 07:07:38PM +0200, Michael Stahl wrote: apparently somebody thought it a great idea to mandate Allman style for Someone has an evil grin on his face. 1) if the condition is long, then put the opening brace on a new line. rationale: in this case it's good to visually separate the condition from the compound statement, e.g. this is a PITA to read: > if ( !pFly->Lower() || !pFly->Lower()->IsNoTxtFrm() || > !((SwNoTxtFrm*)pFly->Lower())->HasAnimation()) > pFly->RefreshLaySubsidiary( pPage, rRect ); > if (bCalledFromShell && !lcl_IsItemSet(*pNewTxtNd, RES_PARATR_ADJUST) && > SFX_ITEM_SET == pAnchorNode->GetSwAttrSet(). > GetItemState(RES_PARATR_ADJUST, sal_True, &pItem)) > static_cast*>(pNewTxtNd)->SetAttr(*pItem); IMHO, these monster conditions deserve local static inline functions with a name that says what the heck they are testing for anyway. Best, Bjoern P.S.: Here is a fish for the trollbait: <0(< ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Fwd: LineEnding issues, .md > .docx
Hi, I generated a simple document with Microsoft Word and read the generated file. It seems that the bug comes from your sample document. In your sample, apears outside any while on my reference document it is the first element of the immediate following . sample: Line 1 Line 2 instead of: Line 1 Line 2 Regards, Le 2012-08-14 09:28, Joop Kiefte a écrit : FYI, just interested if there is a known issue here and/or compliance errors you can help pandoc with... -- Forwarded message -- From: Oliver Schrenk Date: 2012/8/14 Subject: Re: LineEnding issues, .md > .docx To: "pandoc-disc...@googlegroups.com" Cc: "pandoc-disc...@googlegroups.com" I currently have only access to OpenOffice 3.0. What would be a good approach to debug this? My plan is to create native docx with something like code blocks and see how this is formatted and how it fairs in OO, but I suspect that this is what you did in the first place. Am 13.08.2012 um 18:51 schrieb John MacFarlane : I wasn't aware of this issue. I just confirmed it with LibreOffice on Mac OS X. So it seems that the docx pandoc produces is fine for Word, but somehow confuses the Libre/OpenOffice converter. If anyone has insight on this, it would be welcome. This is how pandoc renders a verbatim section in docx: Markdown: A level-two header -- Docx: A level-two header -- Note, there's an explicit (line break) between the first line and the second. The LibreOffice converter seems to be ignoring this. This may be a bug in LibreOffice, though it's also possible that I'm doing it wrong. +++ Oliver Schrenk [Aug 13 12 04:05 ]: I mainly want to use pandoc to generate documentation for software and often use code examples. In markdown I format codeblocks using tabs as indentation and use `pandoc *.md -o book.docx`) to convert the files. When I open the result file in OpenOffice (on Linux and Windows) all line endings are gone, in Word all line endings are displayed correctly. I suspected issues with converting LF to CRLF and ran `unix2dos *.md` but it didn't help. Does anybody know a way around this? -- You received this message because you are subscribed to the Google Groups "pandoc-discuss" group. To post to this group, send email to pandoc-disc...@googlegroups.com. To unsubscribe from this group, send email to pandoc-discuss+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msg/pandoc-discuss/-/5W53P-rv6lgJ. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "pandoc-discuss" group. To post to this group, send email to pandoc-disc...@googlegroups.com. To unsubscribe from this group, send email to pandoc-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "pandoc-discuss" group. To post to this group, send email to pandoc-disc...@googlegroups.com. To unsubscribe from this group, send email to pandoc-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC 2012][Collaboration] brief status
Hello, Wow! That's great! How do you detect offline? In fact, it does not work as expected :-(. Because when the contact closes the document, he is still online, so we don't know about closed channel. My 2 cents: Could you use something like a "keepalive" signal ? A timeout could then be used to detect that other end has quit either by crashing, loosing network or just by closing the document. -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Set sizer color to dark grey; was dark black
Hi ! I forgot to mention in the commit message that it visually impacts (enhances) Calc's window splitters and, more visibly, the Basic IDE which now looks much nicer :) If I have some time, I will see if it's possible to move Basic IDE to SplitWindow instead of Split. 'SplitWindow' is the one used by Impress and seems more powerful. Regards, On 12/08/2012 17:17, Gerrit wrote: >>From Jean-Tiare Le Bigot : > > Jean-Tiare Le Bigot has uploaded a new change for review. > > Change subject: Set sizer color to dark grey; was dark black > .. > > Set sizer color to dark grey; was dark black > > The color setting was picked from SplitWindow::Paint() > for visual consistency with the sizers used in Impress > for example. > > This commit also resurects presumably dead code. > In fact GDB let me see that only the short path > was taken. > > Change-Id: I9a051fd894feccff4bbc7db7efe1160cb2c3a2c6 > --- > M vcl/source/window/split.cxx > 1 file changed, 30 insertions(+), 35 deletions(-) > > > git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/399/1 > -- > To view, visit https://gerrit.libreoffice.org/399 > To unsubscribe, visit https://gerrit.libreoffice.org/settings > > Gerrit-MessageType: newchange > Gerrit-Change-Id: I9a051fd894feccff4bbc7db7efe1160cb2c3a2c6 > Gerrit-PatchSet: 1 > Gerrit-Project: core > Gerrit-Branch: master > Gerrit-Owner: Jean-Tiare Le Bigot > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Good way of submitting patches
Hi ! What is the good way of submitting contributions ? It seems that sending the raw patch on the list leads to a faster a review/integration but the recommended way is still gerrit ? -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: new style UNO port
Ok, I actually forgot one step in the file re-generation. Sorry for asking a silly question :s Le 2012-08-07 21:37, Jean-Tiare LE BIGOT a écrit : Hi ! I'm trying to work on Bug 46808 - [Easy Hack] Adapt UNO services to new-style. I started with the first unported module: offapi->accessibility. This probably was not the best idea I ever had sinc it's used in something like 1300 files... Anyway. I've updated the IDL files, the .mk file and regenerated the types.rdb file as explained in the bug report. But, when I try to $ make offapi.clean #OK $ male offapi #FAILS I am warned about an incompatible change. This is obviously true since this is a "published" API. Anyway, the bug report states that this incompatibility is fine. How can I workaround it before starting the actual port ? Here is the error: [ build PKG ] offapi_inc mkdir -p /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/Package/ && touch /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/Package/offapi_inc /bin/cp --remove-destination --no-dereference --force --preserve=timestamps /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/offapi.rdb /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/offapi.rdb [ build UNO ] types [ build DBc ] types mkdir -p /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/ && RESPONSEFILE=/tmp/gbuild.UdsjMu && LD_LIBRARY_PATH="/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/lib" SOLARBINDIR=/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regmerge @${RESPONSEFILE} && rm -f ${RESPONSEFILE} && LD_LIBRARY_PATH="/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/lib" SOLARBINDIR=/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regcompare -f -t -r1 /home/jean-tiare/dev/libreoffice/offapi/type_reference/types.rdb -r2 /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb SERVICE: /UCR/com/sun/star/accessibility/AccessBridge service1 contains 1 more references as service2 incompatible change: Reference 0 ('XInitialization') in 'r1' is not longer a reference of this service in 'r2' SERVICE: /UCR/com/sun/star/accessibility/Accessible service1 contains 1 more references as service2 incompatible change: Reference 0 ('XAccessible') in 'r1' is not longer a reference of this service in 'r2' /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regcompare: registries are incompatible: 2 differences! make: *** [/home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb] Erreur 11 make: *** Destruction du fichier « /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb » Thanks ! -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
new style UNO port
Hi ! I'm trying to work on Bug 46808 - [Easy Hack] Adapt UNO services to new-style. I started with the first unported module: offapi->accessibility. This probably was not the best idea I ever had sinc it's used in something like 1300 files... Anyway. I've updated the IDL files, the .mk file and regenerated the types.rdb file as explained in the bug report. But, when I try to $ make offapi.clean #OK $ male offapi #FAILS I am warned about an incompatible change. This is obviously true since this is a "published" API. Anyway, the bug report states that this incompatibility is fine. How can I workaround it before starting the actual port ? Here is the error: [ build PKG ] offapi_inc mkdir -p /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/Package/ && touch /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/Package/offapi_inc /bin/cp --remove-destination --no-dereference --force --preserve=timestamps /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/offapi.rdb /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/offapi.rdb [ build UNO ] types [ build DBc ] types mkdir -p /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/ && RESPONSEFILE=/tmp/gbuild.UdsjMu && LD_LIBRARY_PATH="/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/lib" SOLARBINDIR=/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regmerge @${RESPONSEFILE} && rm -f ${RESPONSEFILE} && LD_LIBRARY_PATH="/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/lib" SOLARBINDIR=/home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regcompare -f -t -r1 /home/jean-tiare/dev/libreoffice/offapi/type_reference/types.rdb -r2 /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb SERVICE: /UCR/com/sun/star/accessibility/AccessBridge service1 contains 1 more references as service2 incompatible change: Reference 0 ('XInitialization') in 'r1' is not longer a reference of this service in 'r2' SERVICE: /UCR/com/sun/star/accessibility/Accessible service1 contains 1 more references as service2 incompatible change: Reference 0 ('XAccessible') in 'r1' is not longer a reference of this service in 'r2' /home/jean-tiare/dev/libreoffice/solver/unxlngi6.pro/bin/regcompare: registries are incompatible: 2 differences! make: *** [/home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb] Erreur 11 make: *** Destruction du fichier « /home/jean-tiare/dev/libreoffice/workdir/unxlngi6.pro/UnoApiTarget/types.rdb » Thanks ! -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: core dump when compiling LibreOffice ~master
I had the same problem. The crash is in sot_test_sot. from what I remember, there is a test throwing a RuntimeException. An important point is that It occurred to me only in Ubuntu 12.10 *alpha*. Moving back to the previous stable version "fixed" the problem. Sadly, I've not been able to find the exact source of the problem. Le 2012-08-07 16:56, John Smith a écrit : On Tue, Aug 7, 2012 at 4:53 PM, John Smith wrote: On Tue, Aug 7, 2012 at 3:37 PM, Caolán McNamara wrote: It's be helpful to find the core.* of the coredump and get a backtrace from it. I was under the impression that I already attached a trace with my first email ? Anyway, here it is again. Please ignore that email; I forgot I created a bug in bugzilla for it. https://bugs.freedesktop.org/show_bug.cgi?id=53155 Please use that instead. Thanks, John Smith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build fails 'RuntimeException'
Hi, I've finally been able to build LO after switching back to a fresh Lubuntu 10.04 but I'd like to help track down the build issue. Sadly, I have no idea where to start the investigations... I was suggested to (cd sot && make $(readlink -f ../workdir/unxlngx6/CppunitTest/sot_test_sot.test) DEBUGCPPUNIT=TRUE ) But this file does not even exist :/ Le 2012-07-30 14:56, Michael Stahl a écrit : On 30/07/12 04:43, Jean-Tiare LE BIGOT wrote: I really have no idea of what to do. It appears that the exception is intentionally thrown from a test but never caught. i guess something is different about your system that LO code isn't prepared for, and the result is this exception. On 29/07/2012 19:34, julien2412 wrote: Hi, It could be useful you give these info: - which branch do you use (master, 3.6, 3.5?) fresh master clone from less than 6 hours - which env (Linux, Mac os, windows?) (32, 64?) Ubuntu 12.10 32 bits that sounds like it's not even released yet? if you want to use bleeding edge distributions then you should be prepared to fix breakages. you can try to find out what throws the exception like so: (cd sot && make $(readlink -f ../workdir/unxlngx6/CppunitTest/sot_test_sot.test) DEBUGCPPUNIT=TRUE ) if you want something that is known to work then build on a OS that's not currently undergoing active development. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Jean-Tiare LE BIGOT ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build fails 'RuntimeException'
Thanks for your answer. I tried from a fresh clone, removed ccache and even LO rc-2 which was normally installed (not as dev) I really have no idea of what to do. It appears that the exception is intentionally thrown from a test but never caught. On 29/07/2012 19:34, julien2412 wrote: > Hi, > > It could be useful you give these info: > - which branch do you use (master, 3.6, 3.5?) fresh master clone from less than 6 hours > - which env (Linux, Mac os, windows?) (32, 64?) Ubuntu 12.10 32 bits > - gcc version gcc (Ubuntu/Linaro 4.7.1-5ubuntu1) 4.7.1 > - content of autogen.lastrun only '--enable-debug' > > Julien > > > > -- > View this message in context: > http://nabble.documentfoundation.org/Build-fails-RuntimeException-tp3998344p3998388.html > Sent from the Dev mailing list archive at Nabble.com. > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build fails 'RuntimeException'
It appears to produce the same error from a fresh git clone. Any idea ? On 29/07/2012 14:24, Jean-Tiare LE BIGOT wrote: > Hi ! > > I'm trying to do some changes in LibreOffice and I can not manage to > build LibreOffice anymore. I get this exception : > > terminate called after throwing an instance of > 'com::sun::star::uno::RuntimeException' > > It seems to be caused in "[ build CUT ] sot_test_sot" > > I suspect it is related to /testtools/source/bridgetest/cppobj.cxx:306 > after running: > > S=/home/jean-tiare/dev/libreoffice && O=$S/solver/unxlngi6.pro && > W=$S/workdir/unxlngi6.pro && gdb --args $O/bin/uno -ro > $O/xml/uno_services.rdb -ro $O/bin/udkapi.rdb -ro > $W/UnoApiTarget/bridgetest.rdb -s com.sun.star.test.bridge.BridgeTest -- > com.sun.star.test.bridge.CppTestObject > > I tried everything including cleaning all, pulling, re-run autogen.sh > and reverting all my changes with a global "git checkout". Any clue > what's wrong ? > > > -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build fails 'RuntimeException'
Hi ! I'm trying to do some changes in LibreOffice and I can not manage to build LibreOffice anymore. I get this exception : terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException' It seems to be caused in "[ build CUT ] sot_test_sot" I suspect it is related to /testtools/source/bridgetest/cppobj.cxx:306 after running: S=/home/jean-tiare/dev/libreoffice && O=$S/solver/unxlngi6.pro && W=$S/workdir/unxlngi6.pro && gdb --args $O/bin/uno -ro $O/xml/uno_services.rdb -ro $O/bin/udkapi.rdb -ro $W/UnoApiTarget/bridgetest.rdb -s com.sun.star.test.bridge.BridgeTest -- com.sun.star.test.bridge.CppTestObject I tried everything including cleaning all, pulling, re-run autogen.sh and reverting all my changes with a global "git checkout". Any clue what's wrong ? -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: License statement
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 "All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL1.1+ / GPLv3+ / LGPLv3+" - -- Jean-Tiare -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQDeKIAAoJENsOhxLjiWV2y3MH/jLkv9CGggy0vQ1kjlDzsc2k HgveLr4YqCAgxADgCTV0NCThMrauGb7VsBnRJYOdxapkaGRUbPQU403+AZbf19Y2 zFb3dfWcowv/nCmeXBEJ/RkIl2IglMc2mmGCId1rkBnMCP9gU8+fMdTY1E4u/LTG ZK/Ds1VJreDowFuQ1M1vklJcVD+yriu07V7/65bAScl5dwUUl9TYyIaBiZFmR4gG D3XjatgKTRB09H4j4He+wmiu+entKa9TkBvQknC+2Jjrnyd5Sd6tvT8B4qgoFFpL aCgGSbfzU5rCQban6aAqQhr/+Q5+Qt3jxXd5tO6dDxgsSHg3k2bE27o5Gc9RxbM= =QoIv -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Code documentation
I'm new to LibreOffice code base and I'm working on one of the easy hacks to get started. It seems that most functions are note documented. Is that OK if I add some doxygen style comments ? If this is OK, where should I add them ? In the header files or in the implementation files ? -- Jean-Tiare ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice