Re: [Libreoffice-qa] R: Re: hi, i find high bug for calc 6.2 until 6.4 (factory)

[Korrawit Pruegsanusak]

Hello Manuel,

Please see an update in the bugzilla system
and follow this issue from there.

Best Regards,

On Mon, May 11, 2020 at 3:33 PM Manuel Muzzurru
 wrote:
>
> good morning
> i added the attached the file ODS, i did try with LO 6.4.2 ( this is third 
> testing different version and confirm can reproduce BUG or ISSUE.. high 
> process task, memory growing up until full of stack memory GB).. please : 
> Imari, korrawit, buovjaga: please make new testing with my file ODS..
> https://bugs.documentfoundation.org/show_bug.cgi?id=132694#c3
>
> thank you
>
> Il domenica 10 maggio 2020, 20:17:56 CEST, Ilmari Lauhakangas 
>  ha scritto:
>
>
> I attached the image to
> https://bugs.documentfoundation.org/show_bug.cgi?id=132694
>
> Ilmari
>
> Korrawit Pruegsanusak kirjoitti 10.5.2020 klo 19.57:
> > Hello Manuel,
> >
> > Thank you for reporting this issue.
> >
> > Could you please upload your ODS file to the bugzilla system?
> > I mean the file that you posted a mega.nz link in your first email,
> > and also the image file that you demonstrated in the video.
> > Because the files should be accessible to the developers
> > even after you deleted the mega.nz link.
> >
> > Please also note that after uploading, the files will be public.
> > So, please remove any sensitive information before doing so.
> >
> > Thank you again for helping us!
> > Best Regards,
> > -- Korrawit
> >
> >
> > On Tue, May 5, 2020 at 8:57 PM Manuel Muzzurru  
> > wrote:
> >>
> >> Ciao italo, io sempre uso libreoffice e installato altri computer su altro 
> >> lavori.. Sempre dire nuove persone di consigliare e loro hanno ascoltato.. 
> >> Ok?
> >> Per bug devo pure verificare Linux e 6.2 e 6.4 ripetere e sempre stessa 
> >> problema.. Oggi farò screen record così potete capire facilmente ok? Oggi 
> >> farò sicuro ok? Grazie del pensiero
> >>
> >> Io penso consiglio di nuovo portale per report bug motivo già complicato e 
> >> pesante e brutto.. Usare qualcosa simile phabricator o gitlab o github 
> >> (Microsoft) o altro modo facile per accesso.. Ho visto pagina di LO troppo 
> >> lungo e faticoso così facilmente "non mi viene voglia di farlo xke troppo 
> >> fegato.." ok?
> >>
> >> Inviato da Yahoo Mail su Android
> >>
> >> Il dom, 3 mag, 2020 alle 16:52, Italo Vignoli
> >>  ha scritto:
> >> Ciao Manuel, come stai? Sono contento di vedere che continui a usare
> >> LibreOffice. Per prima cosa, proviamo a riprodurre il bug per verificare
> >> che il problema sia lo stesso su tutti i sistemi, e non solo con KDE.
> >>
> >> Come ti ha scritto Ilmari, che non ti conosce, i bug bisognerebbe
> >> inserirli su Bugzilla, che però non è facile da utilizzare. Per questo
> >> motivo noi consigliamo agli utenti italiani di scrivere a questa mailing
> >> list: us...@it.libreoffice.org, descrivendo il problema, perché possiamo
> >> inserirlo noi dopo aver fatto una prima verifica.
> >>
> >> Ciao, Italo
> >>
> >> On 5/3/20 3:44 PM, Manuel Muzzurru wrote:
> >>> hi
> >>>
> >>> i find true bug for calc from 6.2 until 6.4(Versione: 6.4.3.2  Build ID:
> >>> 40(Build:2) )
> >>>
> >>> i insert image from firefox: copy image from firefox and paste in calc,
> >>> works for inserted image but when i start to scale (dimension) this is
> >>> start frozen but ram is growing up from 2gb to 20gb of ram but i must to
> >>> kill process in task (kde5 )..same version 6.2 until 6.4.. nothing
> >>> detect from you (team developers)?
> >>>
> >>> i leave here link my file attach..
> >>> https://mega.nz/file/nspVFDoQ#FQ6sRh-1JC4CCpkVryIrWdYC8kg2xAw9qe1CsIa_qeA
> >>>
> >>> good luck for fix it
> >>
> >>
> >>
> >> --
> >> Italo Vignoli - LibreOffice Marketing & PR
> >> mobile/signal +39.348.5653829 - email it...@libreoffice.org
> >> hangout/jabber italo.vign...@gmail.com - skype italovignoli
> >> GPG Key ID - 0xAAB8D5C0
> >> DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0
> >>
> >> ___
> >> List Name: Libreoffice-qa mailing list
> >> Mail address: Libreoffice-qa@lists.freedesktop.org
> >> Change settings: 
> >> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> >> Problems? 
> >> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> >> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> >> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
> >
> >
> >



-- 
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] R: Re: hi, i find high bug for calc 6.2 until 6.4 (factory)

[Korrawit Pruegsanusak]

Hello Manuel,

Thank you for reporting this issue.

Could you please upload your ODS file to the bugzilla system?
I mean the file that you posted a mega.nz link in your first email,
and also the image file that you demonstrated in the video.
Because the files should be accessible to the developers
even after you deleted the mega.nz link.

Please also note that after uploading, the files will be public.
So, please remove any sensitive information before doing so.

Thank you again for helping us!
Best Regards,
-- Korrawit


On Tue, May 5, 2020 at 8:57 PM Manuel Muzzurru  wrote:
>
> Ciao italo, io sempre uso libreoffice e installato altri computer su altro 
> lavori.. Sempre dire nuove persone di consigliare e loro hanno ascoltato.. Ok?
> Per bug devo pure verificare Linux e 6.2 e 6.4 ripetere e sempre stessa 
> problema.. Oggi farò screen record così potete capire facilmente ok? Oggi 
> farò sicuro ok? Grazie del pensiero
>
> Io penso consiglio di nuovo portale per report bug motivo già complicato e 
> pesante e brutto.. Usare qualcosa simile phabricator o gitlab o github 
> (Microsoft) o altro modo facile per accesso.. Ho visto pagina di LO troppo 
> lungo e faticoso così facilmente "non mi viene voglia di farlo xke troppo 
> fegato.." ok?
>
> Inviato da Yahoo Mail su Android
>
> Il dom, 3 mag, 2020 alle 16:52, Italo Vignoli
>  ha scritto:
> Ciao Manuel, come stai? Sono contento di vedere che continui a usare
> LibreOffice. Per prima cosa, proviamo a riprodurre il bug per verificare
> che il problema sia lo stesso su tutti i sistemi, e non solo con KDE.
>
> Come ti ha scritto Ilmari, che non ti conosce, i bug bisognerebbe
> inserirli su Bugzilla, che però non è facile da utilizzare. Per questo
> motivo noi consigliamo agli utenti italiani di scrivere a questa mailing
> list: us...@it.libreoffice.org, descrivendo il problema, perché possiamo
> inserirlo noi dopo aver fatto una prima verifica.
>
> Ciao, Italo
>
> On 5/3/20 3:44 PM, Manuel Muzzurru wrote:
> > hi
> >
> > i find true bug for calc from 6.2 until 6.4(Versione: 6.4.3.2  Build ID:
> > 40(Build:2) )
> >
> > i insert image from firefox: copy image from firefox and paste in calc,
> > works for inserted image but when i start to scale (dimension) this is
> > start frozen but ram is growing up from 2gb to 20gb of ram but i must to
> > kill process in task (kde5 )..same version 6.2 until 6.4.. nothing
> > detect from you (team developers)?
> >
> > i leave here link my file attach..
> > https://mega.nz/file/nspVFDoQ#FQ6sRh-1JC4CCpkVryIrWdYC8kg2xAw9qe1CsIa_qeA
> >
> > good luck for fix it
>
>
>
> --
> Italo Vignoli - LibreOffice Marketing & PR
> mobile/signal +39.348.5653829 - email it...@libreoffice.org
> hangout/jabber italo.vign...@gmail.com - skype italovignoli
> GPG Key ID - 0xAAB8D5C0
> DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0
>
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems? 
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/



-- 
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: bin/get-bugzilla-attachments-by-mimetype

[Korrawit Pruegsanusak]

 bin/get-bugzilla-attachments-by-mimetype |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 051130e25b0e133667a39b3e7a8c758c1cb5240f
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Mon Oct 23 20:41:32 2017 +0700

get-bugzilla-attachments-by-mimetype: add some duplicated mimetypes ...

that are really used in our TDF bugzilla

Change-Id: I5945cbf10ad2698471a3a74be8773ee1b5d81656
Reviewed-on: https://gerrit.libreoffice.org/43722
Reviewed-by: Adolfo Jayme Barrientos <fit...@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fit...@ubuntu.com>

diff --git a/bin/get-bugzilla-attachments-by-mimetype 
b/bin/get-bugzilla-attachments-by-mimetype
index 1450d215b548..fe81fa673350 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -479,16 +479,21 @@ mimetypes = {
 # relatively uncommon image mimetypes
 'image/x-freehand': 'fh',
 'image/cgm': 'cgm',
+'image/tif': 'tiff',
 'image/tiff': 'tiff',
 'image/vnd.dxf': 'dxf',
+'image/emf': 'emf',
 'image/x-emf': 'emf',
 'image/x-targa': 'tga',
 'image/x-sgf': 'sgf',
 'image/x-svm': 'svm',
+'image/wmf': 'wmf',
 'image/x-wmf': 'wmf',
 'image/x-pict': 'pict',
 'image/x-cmx': 'cmx',
 'image/svg+xml': 'svg',
+'image/bmp': 'bmp',
+'image/x-ms-bmp': 'bmp',
 'image/x-MS-bmp': 'bmp',
 'image/x-wpg': 'wpg',
 'image/x-eps': 'eps',
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: README.md

[Korrawit Pruegsanusak]

 README.md |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit beff25128c7f53125d487a11caa70a3060dcc785
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Mon Oct 23 19:37:10 2017 +0700

README.md: markdown use 4 spaces for list indentation

Change-Id: I5ac151877f0bccfdc955171b26fecefcacfbe117
Reviewed-on: https://gerrit.libreoffice.org/43720
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fit...@ubuntu.com>

diff --git a/README.md b/README.md
index fa614b033d38..4b5d9ed0d81d 100644
--- a/README.md
+++ b/README.md
@@ -33,17 +33,17 @@ These are the current minimal operating system and compiler 
versions to
 run and compile LibreOffice, also used by the TDF builds:
 
 * Windows:
- * Runtime: Windows 7
- * Build: Cygwin + Visual Studio 2015 Update 3
+* Runtime: Windows 7
+* Build: Cygwin + Visual Studio 2015 Update 3
 * macOS:
- * Runtime: 10.9
- * Build: 10.12 + Xcode 8
+* Runtime: 10.9
+* Build: 10.12 + Xcode 8
 * Linux:
- * Runtime: RHEL 6 or CentOS 6
- * Build: GCC 4.8.1 or Clang
+* Runtime: RHEL 6 or CentOS 6
+* Build: GCC 4.8.1 or Clang
 * iOS (only for LibreOfficeKit):
- * Runtime: 11.0 (only support for newer i devices == 64 bit)
- * Build: Xcode 9.0 and iPhone SDK 11.0
+* Runtime: 11.0 (only support for newer i devices == 64 bit)
+* Build: Xcode 9.0 and iPhone SDK 11.0
 
 If you want to use Clang with the LibreOffice compiler plugins, the minimal
 version of Clang is 3.4. Since Xcode doesn't provide the compiler plugin
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/rtl

[Korrawit Pruegsanusak]

 include/rtl/bootstrap.hxx |   12 ++--
 include/rtl/cipher.h  |   46 +++---
 include/rtl/crc.h |6 +++---
 3 files changed, 32 insertions(+), 32 deletions(-)

New commits:
commit adc20182157c604e702a4af4e73e63be614ae6d8
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sat Oct 21 12:03:45 2017 +0700

correct doxygen syntax

Change-Id: I9e0ae4f9adadf58b99228d64a316d279043151f2
Reviewed-on: https://gerrit.libreoffice.org/43638
Reviewed-by: Michael Stahl <mst...@redhat.com>
Tested-by: Michael Stahl <mst...@redhat.com>

diff --git a/include/rtl/bootstrap.hxx b/include/rtl/bootstrap.hxx
index 4c1ce0e29a3b..7820ecef3c01 100644
--- a/include/rtl/bootstrap.hxx
+++ b/include/rtl/bootstrap.hxx
@@ -43,7 +43,7 @@ namespace rtl
 
 /** Retrieves a bootstrap parameter
@param sName name of the bootstrap value. case insensitive.
-   @param outValue (out parameter). On success contains the value, 
otherwise
+   @param[out] outValue On success contains the value, otherwise
   an empty string.
@return false, if no value could be retrieved, otherwise true
@see rtl_bootstrap_get()
@@ -55,9 +55,9 @@ namespace rtl
 /** Retrieves a bootstrap parameter
 
@param sName name of the bootstrap value. case insensitive.
-   @param outValue (out parameter). Contains the value associated with 
sName.
-   @param aDefault if none of the other methods retrieved a value, 
outValue
-   is assigned to a Default.
+   @param[out] outValue Contains the value associated with 
sName.
+   @param aDefault if none of the other methods retrieved a value,
+   outValue is assigned to 
aDefault.
 
@see rtl_bootstrap_get()
  */
@@ -118,14 +118,14 @@ namespace rtl
 
 /** Expands a macro using bootstrap variables.
 
-@param macro[inout]  The macro to be expanded
+@param[in,out] macro The macro to be expanded
 */
 void expandMacrosFrom( ::rtl::OUString & macro ) const
 { rtl_bootstrap_expandMacros_from_handle( _handle,  ); 
}
 
 /** Expands a macro using default bootstrap variables.
 
-@param macro[inout]  The macro to be expanded
+@param[in,out] macro The macro to be expanded
 */
 static void expandMacros( ::rtl::OUString & macro )
 { rtl_bootstrap_expandMacros(  ); }
diff --git a/include/rtl/cipher.h b/include/rtl/cipher.h
index 961fb582763f..2b442c2cebd0 100644
--- a/include/rtl/cipher.h
+++ b/include/rtl/cipher.h
@@ -105,8 +105,8 @@ typedef enum __rtl_CipherError rtlCipherError;
 @see rtlCipherAlgorithm
 @see rtlCipherMode
 
-@param  Algorithm [in] cipher algorithm.
-@param  Mode  [in] cipher mode.
+@param[in] Algorithm cipher algorithm.
+@param[in] Mode  cipher mode.
 @return Cipher handle, or 0 upon failure.
  */
 SAL_DLLPUBLIC rtlCipher SAL_CALL rtl_cipher_create (
@@ -117,13 +117,13 @@ SAL_DLLPUBLIC rtlCipher SAL_CALL rtl_cipher_create (
 /** Inititialize a cipher for the given direction.
 @see rtlCipherDirection
 
-@param  Cipher[in] cipher handle.
-@param  Direction [in] cipher direction.
-@param  pKeyData  [in] key material buffer.
-@param  nKeyLen   [in] key material length in bytes.
-@param  pArgData  [in] initialization vector buffer.
-@param  nArgLen   [in] initialization vector length in bytes.
-@return rtl_Cipher_E_None upon success.
+@param[in] Ciphercipher handle.
+@param[in] Direction cipher direction.
+@param[in] pKeyData  key material buffer.
+@param[in] nKeyLen   key material length in bytes.
+@param[in] pArgData  initialization vector buffer.
+@param[in] nArgLen   initialization vector length in bytes.
+@retval rtl_Cipher_E_None upon success.
  */
 SAL_DLLPUBLIC rtlCipherError SAL_CALL rtl_cipher_init (
 rtlCipher   Cipher,
@@ -136,12 +136,12 @@ SAL_DLLPUBLIC rtlCipherError SAL_CALL rtl_cipher_init (
 @pre Initialized for a compatible cipher direction.
 @see rtl_cipher_init()
 
-@param  Cipher  [in]  cipher handle.
-@param  pData   [in]  plaintext buffer.
-@param  nDatLen [in]  plaintext length in bytes.
-@param  pBuffer [out] ciphertext buffer.
-@param  nBufLen [in]  ciphertext length in bytes.
-@return rtl_Cipher_E_None upon success.
+@param[in]  Cipher  cipher handle.
+@param[in]  pData   plaintext buffer.
+@param[in]  nDatLen plaintext length in bytes.
+@param[out] pBuffer ciphertext buffer.
+@param[in]  nBufLen ciphertext length in bytes.
+@retval rtl_Cipher_E_None upon success.
  */
 SAL_DLLPUBLIC rtlCipherError SAL_CALL rtl_cipher_encode (
 rtlCipher   Cipher,
@@ -153,12 +153,12 @@ SAL_DLLPUBL

[Libreoffice-commits] core.git: include/comphelper include/rtl

[Korrawit Pruegsanusak]

 include/comphelper/extract.hxx |   17 +++--
 include/rtl/alloc.h|  118 +++--
 include/rtl/bootstrap.h|  109 +
 3 files changed, 115 insertions(+), 129 deletions(-)

New commits:
commit 167afafaf5dab7645ef6efd12528eaa0389d
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Thu Oct 12 22:40:51 2017 +0700

correct wrong doxygen syntax; also comments clean-up

Change-Id: I6074241dfcdcd4ca8a365ab6e03f01028d2c1a7b
Reviewed-on: https://gerrit.libreoffice.org/43344
Reviewed-by: Michael Stahl <mst...@redhat.com>
Tested-by: Michael Stahl <mst...@redhat.com>

diff --git a/include/comphelper/extract.hxx b/include/comphelper/extract.hxx
index 4f4072145e71..4330faa1a625 100644
--- a/include/comphelper/extract.hxx
+++ b/include/comphelper/extract.hxx
@@ -34,7 +34,7 @@ namespace cppu
 
 /**
  * Sets enum from int32 value.  This function does NOT check for valid enum 
values!
- *
+ *
  * @param nEnum int32 enum value
  * @param rType enum type
  * @return enum or empty any.
@@ -48,10 +48,11 @@ inline css::uno::Any SAL_CALL int2enum(
 
 /**
  * Sets int32 from enum or int in any.
- *
- * @param rnEnum[out] int32 enum value
+ *
+ * @param[out] rnEnum   int32 enum value
  * @param rAny  enum or int
- * @param sal_True if enum or int value was set else sal_False.
+ * @retval true if enum or int value was set
+ * @retval false otherwise
  */
 inline bool enum2int( sal_Int32 & rnEnum, const css::uno::Any & rAny )
 {
@@ -66,10 +67,10 @@ inline bool enum2int( sal_Int32 & rnEnum, const 
css::uno::Any & rAny )
 
 /**
  * Sets int32 from enum or int in any with additional typecheck
- * 
- * @param rAny  enum or int
- * @param eRet  the enum value as int. If there is not enum of the 
given type or
+ *
+ * @param[out] eRet the enum value as int. If there is no enum of the 
given type
  *  a css::lang::IllegalArgumentException is thrown
+ * @param rAny  enum or int
  * @throws css::lang::IllegalArgumentException
  */
 template< typename E >
@@ -88,7 +89,7 @@ inline void any2enum( E & eRet, const css::uno::Any & rAny )
 }
 
 /**
- * extracts a boolean either as a bool or an integer from
+ * Extracts a boolean either as a bool or an integer from
  * an any. If there is no bool or integer inside the any
  * a css::lang::IllegalArgumentException is thrown
  *
diff --git a/include/rtl/alloc.h b/include/rtl/alloc.h
index ccb8d4183b20..8e59f4b8712d 100644
--- a/include/rtl/alloc.h
+++ b/include/rtl/alloc.h
@@ -35,8 +35,8 @@ extern "C" {
 A call to this function will return NULL upon the requested
 memory size being either zero or larger than currently allocatable.
 
-@param  Bytes [in] memory size.
-@return pointer to allocated memory.
+@param[in] Bytes memory size.
+@return pointer to the allocated memory.
  */
 SAL_DLLPUBLIC void * SAL_CALL rtl_allocateMemory (
 sal_Size Bytes
@@ -53,9 +53,9 @@ SAL_DLLPUBLIC void * SAL_CALL rtl_allocateMemory (
 @see rtl_allocateMemory()
 @see rtl_freeMemory()
 
-@param  Ptr   [in] pointer to previously allocated memory.
-@param  Bytes [in] new memory size.
-@return pointer to reallocated memory. May differ from Ptr.
+@param[in] Ptr   pointer to the previously allocated memory.
+@param[in] Bytes new memory size.
+@return pointer to the reallocated memory. May differ from Ptr.
  */
 SAL_DLLPUBLIC void * SAL_CALL rtl_reallocateMemory (
 void *   Ptr,
@@ -64,7 +64,7 @@ SAL_DLLPUBLIC void * SAL_CALL rtl_reallocateMemory (
 
 
 /** Free memory.
-@param  Ptr   [in] pointer to previously allocated memory.
+@param[in] Ptr pointer to the previously allocated memory.
 @return none. Memory is released. Ptr is invalid.
  */
 SAL_DLLPUBLIC void SAL_CALL rtl_freeMemory (
@@ -76,8 +76,8 @@ SAL_DLLPUBLIC void SAL_CALL rtl_freeMemory (
 A call to this function will return NULL upon the requested
 memory size being either zero or larger than currently allocatable.
 
-@param  Bytes [in] memory size.
-@return pointer to allocated and zero'ed memory.
+@param[in] Bytes memory size.
+@return pointer to the allocated and zero'ed memory.
  */
 SAL_DLLPUBLIC void * SAL_CALL rtl_allocateZeroMemory (
 sal_Size Bytes
@@ -87,8 +87,8 @@ SAL_DLLPUBLIC void * SAL_CALL rtl_allocateZeroMemory (
 
 Fills a block of memory with zeros in a way that is guaranteed to be secure
 
-@param  Ptr   [in] pointer to previously allocated memory.
-@param  Bytes [in] memory size.
+@param[in] Ptr   pointer to the previously allocated memory.
+@param[in] Bytes memory size.
 
 @since LibreOffice 5.0
  */
@@ -99,10 +99,10 @@ SAL_DLLPUBLIC void SAL_CALL rtl_secureZeroMemory (
 
 
 /** Zero and free memory.
-@param  Ptr   [in] pointer to previously allocated

[Libreoffice-commits] core.git: ucb/source

[Korrawit Pruegsanusak]

 ucb/source/ucp/webdav/webdavcontent.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 25638e24191936be443cccb6d70121a77b795477
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sat Nov 12 21:06:20 2016 +0700

Change remaining sal_Int32 to ContinuationFlags ...

from 7f97b5e72c61066ea1ddd0f782e50070ce5f6363

Change-Id: I064e35f879ecba61d7ef71a0a177e760c3d263c4
Reviewed-on: https://gerrit.libreoffice.org/30793
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
Tested-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/ucb/source/ucp/webdav/webdavcontent.cxx 
b/ucb/source/ucp/webdav/webdavcontent.cxx
index f01598a..6a07cd3 100644
--- a/ucb/source/ucp/webdav/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav/webdavcontent.cxx
@@ -2439,7 +2439,7 @@ void Content::insert(
 | ContinuationFlags::Disapprove );
 xIH->handle( xRequest.get() );
 
-const sal_Int32 nResp = xRequest->getResponse();
+const ContinuationFlags nResp = xRequest->getResponse();
 
 switch ( nResp )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Advise needed for fixing tdf#41253

[Korrawit Pruegsanusak]

Hello everyone,

I just have some times to look at tdf#41253.
(https://bugs.documentfoundation.org/41253) But I don't promise I
could finish it, so I still didn't assign myself into a bug. Anyway,
let me explain (and ask) about it:

The bug is about importing pptx file which has shadowed text (one of
the text effects apart from bold, italic, underlined), but LibO can't
import "shadowing text".

The problem is, in OOXML structure, shadowing is declared in
 element, which is a child of . For more
info, please see http://www.datypic.com/sc/ooxml/e-a_effectLst-1.html

This is the OOXML sample comparing shadowed and non-shadowed text
(cropped from slide1.xml of an extracted pptx file):
---cut---









Text with shadow





 Text without shadow



---cut---

And the code parsing  is still unsupported, see:
http://opengrok.libreoffice.org/xref/core/oox/source/drawingml/textcharacterpropertiescontext.cxx#101

This is my patch (also attached to this email). It compiled
successfully, but the shadowing still didn't work:

---cut---
diff --git a/oox/inc/drawingml/textcharacterproperties.hxx
b/oox/inc/drawingml/textcharacterproperties.hxx
index 055e58f..2dca075 100644
--- a/oox/inc/drawingml/textcharacterproperties.hxx
+++ b/oox/inc/drawingml/textcharacterproperties.hxx
@@ -56,6 +56,7 @@ struct TextCharacterProperties
 OptValue< bool >moUnderlineLineFollowText;
 OptValue< bool >moUnderlineFillFollowText;
 FillProperties  maFillProperties;
+OptValue< bool >moCharShadowed;

 std::vector maTextEffectsProperties;

diff --git a/oox/source/drawingml/textcharacterproperties.cxx
b/oox/source/drawingml/textcharacterproperties.cxx
index 48803de..c5e1253 100644
--- a/oox/source/drawingml/textcharacterproperties.cxx
+++ b/oox/source/drawingml/textcharacterproperties.cxx
@@ -151,6 +151,10 @@ void TextCharacterProperties::pushToPropMap(
PropertyMap& rPropMap, const XmlFil
 rPropMap.setProperty( PROP_CharUnderlineHasColor, true);
 rPropMap.setProperty( PROP_CharUnderlineColor,
maUnderlineColor.getColor( rFilter.getGraphicHelper() ));
 }
+
+bool bCharShadowed = moCharShadowed.get(false);
+SAL_DEBUG(bCharShadowed);
+rPropMap.setProperty( PROP_CharShadowed, /*true */bCharShadowed);
 }

 void pushToGrabBag( PropertySet& rPropSet, const
std::vector& aVectorOfProperyValues )
---cut---

In textcharacterproperties.cxx, it is where the shadowing process
done. If I change the argument to "true", like this:
rPropMap.setProperty( PROP_CharShadowed, true);
Then all texts will got shadowed. The problem is, bCharShadowed is
never "true" in current patch, and I couldn't get it to be "true".

---cut---
diff --git a/oox/source/drawingml/textcharacterpropertiescontext.cxx
b/oox/source/drawingml/textcharacterpropertiescontext.cxx
index 1c62c1d..ef24ab1 100644
--- a/oox/source/drawingml/textcharacterpropertiescontext.cxx
+++ b/oox/source/drawingml/textcharacterpropertiescontext.cxx
@@ -217,6 +223,10 @@ ContextHandlerRef
TextCharacterPropertiesContext::onCreateContext( sal_Int32 aEl
 return new TextEffectsContext( *this, aElementToken,
mrTextCharacterProperties.maTextEffectsProperties );
 }
 break;
+case A_TOKEN(outerShdw):
+SAL_DEBUG("A_TOKEN now True");
+mrTextCharacterProperties.moCharShadowed = true;
+break;
 default:
 SAL_WARN("oox",
"TextCharacterPropertiesContext::onCreateContext: unhandled element: "
<< getBaseToken(aElementToken));
 break;
---cut---

I don't know why bCharShadowed is never "true". But I think this
approach is likely inappropriate because we already have these:

---cut---
// EG_EffectProperties
case A_TOKEN( effectDag ):  // CT_EffectContainer 5.1.10.25
case A_TOKEN( effectLst ):  // CT_EffectList 5.1.10.26
break;
---cut---

in textcharacterpropertiescontext.cxx line 99-102, which I think it's
more correct to start from these codes.

So, should I start over from the line:
case A_TOKEN( effectLst ):  // CT_EffectList 5.1.10.26
or any advise about my patch would be much appreciated.


Thank you very much.
Best Regards,
-- 
Korrawit Pruegsanusak
diff --git a/oox/inc/drawingml/textcharacterproperties.hxx 
b/oox/inc/drawingml/textcharacterproperties.hxx
index 055e58f..2dca075 100644
--- a/oox/inc/drawingml/textcharacterproperties.hxx
+++ b/oox/inc/drawingml/textcharacterproperties.hxx
@@ -56,6 +56,7 @@ struct TextCharacterProperties
 OptValue< bool >moUnderlineLineFollowText;
 OptValue< bool >moUnderlineFillFollowText;
 FillProperties  maFillProperties;
+OptValue< bool >moCharShadowed;
 
 std::vector maText

[Libreoffice-commits] core.git: Changes to 'feature/fixes21'

[Korrawit Pruegsanusak]

New branch 'feature/fixes21' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/unx

[Korrawit Pruegsanusak]

 vcl/unx/generic/gdi/openglx11cairotextrender.cxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit b0b85e3154183f18fa9d2b82fe5edb5f70094b0b
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Wed Mar 23 13:26:05 2016 +0700

Change #include  to 

Since we don't need cairo's svg feature, and we build internal cairo
with --disable-svg. Also remove commented-out codes which use svg.

Change-Id: I5a8e8c672588bb6eca28696f21221770972ec3d3
Reviewed-on: https://gerrit.libreoffice.org/23456
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>
(cherry picked from commit f9ddd6e317a7bfd662516d197c3caea976aef3b3)
Reviewed-on: https://gerrit.libreoffice.org/24890

diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
index 885145c..bc4e012 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
@@ -13,7 +13,7 @@
 #include "salbmp.hxx"
 #include 
 
-#include 
+#include 
 
 OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(X11SalGraphics& rParent)
 : X11CairoTextRender(rParent)
@@ -22,9 +22,6 @@ 
OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(X11SalGraphics& rParent)
 
 cairo_t* OpenGLX11CairoTextRender::getCairoContext()
 {
-// static size_t id = 0;
-// OString aFileName = OString("/tmp/libo_logs/text_rendering") + 
OString::number(id++) + OString(".svg");
-// cairo_surface_t* surface = cairo_svg_surface_create(aFileName.getStr(), 
GetWidth(), GetHeight());
 cairo_surface_t* surface = nullptr;
 OpenGLSalGraphicsImpl *pImpl = dynamic_cast< OpenGLSalGraphicsImpl* 
>(mrParent.GetImpl());
 if( pImpl )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

[Korrawit Pruegsanusak]

 configure.ac |  195 +--
 1 file changed, 57 insertions(+), 138 deletions(-)

New commits:
commit 97725c3a1fa020fb3562e5fbcb1ac348c2138434
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sun Mar 20 21:38:30 2016 +0700

cleanup AS_HELP_STRING in configure.ac

Change-Id: Ie3492616ea885961933b812820bf65f6b051b868
Reviewed-on: https://gerrit.libreoffice.org/23375
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: jan iversen <j...@documentfoundation.org>

diff --git a/configure.ac b/configure.ac
index 3c61c9d..6e80a96 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1209,14 +1209,14 @@ AC_ARG_ENABLE(split-app-modules,
 
 AC_ARG_ENABLE(split-opt-features,
 AS_HELP_STRING([--enable-split-opt-features],
-[Split file lists for some optional features, .e.g. pyuno, testtool.
+[Split file lists for some optional features, e.g. pyuno, testtool.
  Has effect only with make distro-pack-install]),
 ,)
 
 AC_ARG_ENABLE(cairo-canvas,
-[  --disable-cairo-canvas  Determines whether to build the Cairo canvas on
-  platforms where Cairo is available.
-])
+AS_HELP_STRING([--disable-cairo-canvas],
+[Determines whether to build the Cairo canvas on platforms where Cairo 
is available.]),
+,)
 
 AC_ARG_ENABLE(dbus,
 AS_HELP_STRING([--disable-dbus],
@@ -1318,10 +1318,7 @@ AC_ARG_ENABLE(chart-tests,
 AC_ARG_ENABLE(build-unowinreg,
 AS_HELP_STRING([--enable-build-unowinreg],
 [Do not use the prebuilt unowinreg.dll. Build it instead. The MinGW C++
- compiler is needed on Linux.])
-[
-  Usage: --enable-build-unowinreg
-],
+ compiler is needed on Linux.]),
 ,)
 
 AC_ARG_ENABLE(dependency-tracking,
@@ -1582,10 +1579,10 @@ AC_ARG_WITH(theme,
 ,)
 
 AC_ARG_WITH(helppack-integration,
-[
-  --without-helppack-integration  It will not integrate the helppacks to 
the installer
-  of the product.
-  Please use this switch to use the online help or 
separate help packages.],
+AS_HELP_STRING([--without-helppack-integration],
+[It will not integrate the helppacks to the installer
+ of the product. Please use this switch to use the online help
+ or separate help packages.]),
 ,)
 
 AC_ARG_WITH(fonts,
@@ -1763,13 +1760,9 @@ AC_ARG_WITH(system-postgresql,
 [with_system_postgresql="$with_system_libs"])
 
 AC_ARG_WITH(libpq-path,
-AS_HELP_STRING([--with-libpq-path],
+AS_HELP_STRING([--with-libpq-path=],
 [Use this PostgreSQL C interface (libpq) installation for building
- the PostgreSQL-SDBC extension.])
-[
-  Usage: --with-libpq-path=
-],
+ the PostgreSQL-SDBC extension.]),
 ,)
 
 AC_ARG_WITH(system-firebird,
@@ -1987,13 +1980,10 @@ AC_ARG_WITH(linker-hash-style,
  if supported on the build system, and "sysv" otherwise.]))
 
 AC_ARG_WITH(jdk-home,
-AS_HELP_STRING([--with-jdk-home],
+AS_HELP_STRING([--with-jdk-home=],
 [If you have installed JDK 1.3 or later on your system please supply 
the
  path here. Note that this is not the location of the java command but 
the
- location of the entire distribution.])
-[
-  Usage: --with-jdk-home=
-],
+ location of the entire distribution.]),
 ,)
 
 AC_ARG_WITH(help,
@@ -2010,99 +2000,68 @@ AC_ARG_WITH(help,
 ,)
 
 AC_ARG_WITH(java,
-AS_HELP_STRING([--with-java],
+AS_HELP_STRING([--with-java=],
 [Specify the name of the Java interpreter command. Typically "java"
  which is the default.
 
  To build without support for Java components, applets, accessibility
- or the XML filters written in Java, use --without-java or 
--with-java=no.])
-[
-  Usage: --with-java==
- --without-java
-],
+ or the XML filters written in Java, use --without-java or 
--with-java=no.]),
 [ test -z "$with_java" -o "$with_java" = "yes" && with_java=java ],
 [ with_java=java ]
 )
 
 AC_ARG_WITH(jvm-path,
-AS_HELP_STRING([--with-jvm-path],
-[Use a specific JVM search path at runtime.])
-[
-  Usage: --with-jvm-path=
-
-  e. g.: --with-jvm-path=/usr/lib/
- to find JRE/JDK in /usr/lib/jvm/
-],
+AS_HELP_STRING([--with-jvm-path=],
+[Use a specific JVM search path at runtime.
+ e.g. use --with-jvm-path=/usr/lib/ to find JRE/JDK in /usr/lib/jvm/]),
 ,)
 
 AC_ARG_WITH(ant-home,
-AS_HELP_STRING([--with-ant-home],
+AS_HELP_STRING([--with-ant-home=],
 [If you have installed Jakarta Ant on your system, please supply the 
path

[Libreoffice-commits] core.git: vcl/unx

[Korrawit Pruegsanusak]

 vcl/unx/generic/gdi/openglx11cairotextrender.cxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit f9ddd6e317a7bfd662516d197c3caea976aef3b3
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Wed Mar 23 13:26:05 2016 +0700

Change #include  to 

Since we don't need cairo's svg feature, and we build internal cairo
with --disable-svg. Also remove commented-out codes which use svg.

Change-Id: I5a8e8c672588bb6eca28696f21221770972ec3d3
Reviewed-on: https://gerrit.libreoffice.org/23456
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
index 0c8ac0d..2710b6a 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
@@ -13,7 +13,7 @@
 #include "salbmp.hxx"
 #include 
 
-#include 
+#include 
 
 OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(X11SalGraphics& rParent)
 : X11CairoTextRender(rParent)
@@ -22,9 +22,6 @@ 
OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(X11SalGraphics& rParent)
 
 cairo_t* OpenGLX11CairoTextRender::getCairoContext()
 {
-// static size_t id = 0;
-// OString aFileName = OString("/tmp/libo_logs/text_rendering") + 
OString::number(id++) + OString(".svg");
-// cairo_surface_t* surface = cairo_svg_surface_create(aFileName.getStr(), 
GetWidth(), GetHeight());
 cairo_surface_t* surface = nullptr;
 OpenGLSalGraphicsImpl *pImpl = dynamic_cast< OpenGLSalGraphicsImpl* 
>(mrParent.GetImpl());
 if( pImpl )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/null

[Korrawit Pruegsanusak]

 vcl/null/printerinfomanager.cxx |   15 ---
 1 file changed, 15 deletions(-)

New commits:
commit ce28ed09efd9ff831e502f079facef3d442f159a
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sat Mar 26 10:47:16 2016 +0700

Revert "vcl: fix Android build"

This reverts commit 8058189b53394fe335735cfd04f822f46b1a35b3 because
these functions are now removed by dea0abc58c558d3c62e806d06035b1a30420264e

Change-Id: I69b19319b645879edec04a47b16f78ab07fc9bcf
Reviewed-on: https://gerrit.libreoffice.org/23516
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Miklos Vajna <vmik...@collabora.co.uk>

diff --git a/vcl/null/printerinfomanager.cxx b/vcl/null/printerinfomanager.cxx
index e79701e..8be70af 100644
--- a/vcl/null/printerinfomanager.cxx
+++ b/vcl/null/printerinfomanager.cxx
@@ -131,19 +131,4 @@ void PrinterInfoManager::setDefaultPaper( PPDContext& /* 
rContext */ ) const
 
 }
 
-bool PrinterInfoManager::startBatchPrint()
-{
-return false;
-}
-
-bool PrinterInfoManager::flushBatchPrint()
-{
-return false;
-}
-
-bool PrinterInfoManager::supportsBatchPrint() const
-{
-return false;
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - external/cairo

[Korrawit Pruegsanusak]

 external/cairo/ExternalProject_cairo.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7a973748f8080117bac908edb385de1c9c5e8179
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sun Mar 20 15:07:00 2016 +0700

FREETYPE_CFLAGS is already set when using external freetype

When you're on Debian derivatives, using internal cairo but external
(system's) freetype, the "ft2build.h" is in /usr/include/freetype2/,
not /usr/include/, which is already in FREETYPE_CFLAGS since configure.ac

Change-Id: I24c697776bd77d423ebeafd38315cb76cad28f9b
Reviewed-on: https://gerrit.libreoffice.org/23334
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>
(cherry picked from commit 856038857f566269d8b21fc1c86aa4b5eb7ae048)
Signed-off-by: Michael Stahl <mst...@redhat.com>

diff --git a/external/cairo/ExternalProject_cairo.mk 
b/external/cairo/ExternalProject_cairo.mk
index d204514..61a7097 100644
--- a/external/cairo/ExternalProject_cairo.mk
+++ b/external/cairo/ExternalProject_cairo.mk
@@ -40,7 +40,7 @@ $(call gb_ExternalProject_get_state_target,cairo,build) :
ZLIB3RDLIB="$(if 
$(SYSTEM_ZLIB),,-L$(WORKDIR)/LinkTarget/StaticLibrary) -lz" \
png_REQUIRES="trick_configure_into_using_png_CFLAGS_and_LIBS" \
png_CFLAGS="$(LIBPNG_CFLAGS)" png_LIBS="$(LIBPNG_LIBS)" \
-   FREETYPE_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,freetype)/include" \
+   $(if $(SYSTEM_FREETYPE),,FREETYPE_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,freetype)/include") \
FONTCONFIG_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,fontconfig)" \
$(if $(filter IOS,$(OS)),--disable-shared,--disable-static) \
$(if $(filter ANDROID,$(OS)),--disable-shared,--disable-static) 
\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/cairo

[Korrawit Pruegsanusak]

 external/cairo/ExternalProject_cairo.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 856038857f566269d8b21fc1c86aa4b5eb7ae048
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sun Mar 20 15:07:00 2016 +0700

FREETYPE_CFLAGS is already set when using external freetype

When you're on Debian derivatives, using internal cairo but external
(system's) freetype, the "ft2build.h" is in /usr/include/freetype2/,
not /usr/include/, which is already in FREETYPE_CFLAGS since configure.ac

Change-Id: I24c697776bd77d423ebeafd38315cb76cad28f9b
Reviewed-on: https://gerrit.libreoffice.org/23334
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/external/cairo/ExternalProject_cairo.mk 
b/external/cairo/ExternalProject_cairo.mk
index e74f5f0..6bbe957 100644
--- a/external/cairo/ExternalProject_cairo.mk
+++ b/external/cairo/ExternalProject_cairo.mk
@@ -45,7 +45,7 @@ $(call gb_ExternalProject_get_state_target,cairo,build) :
ZLIB3RDLIB="$(if 
$(SYSTEM_ZLIB),,-L$(WORKDIR)/LinkTarget/StaticLibrary) -lz" \
png_REQUIRES="trick_configure_into_using_png_CFLAGS_and_LIBS" \
png_CFLAGS="$(LIBPNG_CFLAGS)" png_LIBS="$(LIBPNG_LIBS)" \
-   FREETYPE_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,freetype)/include" \
+   $(if $(SYSTEM_FREETYPE),,FREETYPE_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,freetype)/include") \
FONTCONFIG_CFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,fontconfig)" \
$(if $(filter IOS,$(OS)),--disable-shared,--disable-static) \
$(if $(filter ANDROID,$(OS)),--disable-shared,--disable-static) 
\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Korrawit Pruegsanusak]

 vcl/inc/unx/salgdi.h |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit ea04b2a7dc878cdfccef0110a9a40ff1b728965d
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sun Mar 20 15:15:15 2016 +0700

These functions are defined only when ENABLE_CAIRO_CANVAS

Class X11SalGraphics are derived from class SalGraphics, which is
defined in vcl/inc/salgdi.hxx. So these override functions should be
defined in the same condition as the base class.

Change-Id: I5af0ee9c89c74e66b8f2dbd44890606fc5e41b14
Reviewed-on: https://gerrit.libreoffice.org/23373
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/vcl/inc/unx/salgdi.h b/vcl/inc/unx/salgdi.h
index 9b77c70..b7aac7a 100644
--- a/vcl/inc/unx/salgdi.h
+++ b/vcl/inc/unx/salgdi.h
@@ -259,12 +259,15 @@ public:
 long nHeight, sal_uInt8 nTransparency 
) override;
 
 virtual SystemGraphicsData  GetGraphicsData() const override;
+
+#if ENABLE_CAIRO_CANVAS
 virtual boolSupportsCairo() const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const 
cairo::CairoSurfaceSharedPtr& rSurface) const override;
 virtual cairo::SurfaceSharedPtr CreateSurface(const OutputDevice& 
rRefDevice, int x, int y, int width, int height) const override;
 virtual cairo::SurfaceSharedPtr CreateBitmapSurface(const OutputDevice& 
rRefDevice, const BitmapSystemData& rData, const Size& rSize) const override;
 virtual css::uno::Any   
GetNativeSurfaceHandle(cairo::SurfaceSharedPtr& rSurface, const 
basegfx::B2ISize& rSize) const override;
 virtual SystemFontData  GetSysFontData( int nFallbackLevel ) const 
override;
+#endif
 
 bool TryRenderCachedNativeControl(ControlCacheKey& aControlCacheKey,
   int nX, int nY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

[Korrawit Pruegsanusak]

 configure.ac |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e5d83653e78965a876b2ac1119736c4726bd783d
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Sat Mar 19 18:55:27 2016 +0700

Explicitly check for libGL before building

Change-Id: I5a84bc396925828a11d3c680d1a52e99321547a1
Reviewed-on: https://gerrit.libreoffice.org/23335
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Michael Stahl <mst...@redhat.com>

diff --git a/configure.ac b/configure.ac
index 62ee6bf..6e455d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10438,6 +10438,7 @@ elif test $_os = WINNT; then
 else
 if test "$USING_X11" = TRUE; then
 ENABLE_OPENGL=TRUE
+AC_CHECK_LIB(GL, glBegin, [:], AC_MSG_ERROR([libGL required.]))
 fi
 ENABLE_OPENGL_CANVAS=TRUE
 fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: ucb/source

[Korrawit Pruegsanusak]

 ucb/source/ucp/webdav/webdavcontent.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cd6d590e2e687c3852a4e7bda9571d499b86d8d4
Author: Korrawit Pruegsanusak <detective.conan.1...@gmail.com>
Date:   Fri Mar 18 15:39:35 2016 +0700

Remaining argument from loplugin:constantparam in ucb

Still one remaining after b47cb646ff2a62fcd3fac0e453a7261bbaefbcb7

Change-Id: If1dfaa6bbc9f8582f7b2a7dab49815a0a4c6a7b8
Reviewed-on: https://gerrit.libreoffice.org/23355
Reviewed-by: Noel Grandin <noelgran...@gmail.com>
Tested-by: Noel Grandin <noelgran...@gmail.com>

diff --git a/ucb/source/ucp/webdav/webdavcontent.cxx 
b/ucb/source/ucp/webdav/webdavcontent.cxx
index c5b033e..d549d7a 100644
--- a/ucb/source/ucp/webdav/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav/webdavcontent.cxx
@@ -642,7 +642,7 @@ uno::Any SAL_CALL Content::execute(
 destroy( bDeletePhysical );
 
 // Remove own and all children's Additional Core Properties.
-removeAdditionalPropertySet( true );
+removeAdditionalPropertySet();
 }
 else if ( aCommand.Name == "transfer" && isFolder( Environment ) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/30/2630/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/21/6821/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/30/2630/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/23/723/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/21/6821/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/85/6985/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/64/264/3'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/85/6985/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/79/2079/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/64/264/4'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/64/264/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/64/264/5'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/42/2642/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/73/1473/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/6822/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/50/5950/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/42/2642/3'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/722/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/21/421/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/21/421/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/73/1473/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/50/5950/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/42/2642/4'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/64/264/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/22/6822/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/84/6984/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/84/6984/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/2896/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/2896/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/1596/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/78/2078/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/78/2078/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/14/6814/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/96/1596/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/831/1'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/14/6814/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/31/831/2'

[Korrawit Pruegsanusak]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] Git error with bibisect40

[Korrawit Pruegsanusak]

Hello Ken, all,

On Wed, Dec 11, 2013 at 12:09 PM, Ken Biondi kenbio...@hotmail.com wrote:
 Unfortunately neither git checkout . nor git clean -fd, git reset --hard
 solved my problem.

I wonder what is your output of git status.

Anyway, I would try delete everything except one .git/ hidden folder,
and do git checkout oldest.

Note: I didn't try bibisect40 yet, so this may not work. :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: sd/qa

[Korrawit Pruegsanusak]

 sd/qa/unit/data/fdo71434.pptx  |binary
 sd/qa/unit/data/xml/fdo71434_0.xml |   11 +++
 sd/qa/unit/import-tests.cxx|1 +
 3 files changed, 12 insertions(+)

New commits:
commit 6fd352dc3ad32078188537aa8849758735391f46
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Dec 8 14:28:37 2013 +0700

unittest for fdo#71434

Change-Id: I4ef376e048aa0ba37e5c1bc7664e9e8cd3e283b6
Reviewed-on: https://gerrit.libreoffice.org/6985
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sd/qa/unit/data/fdo71434.pptx b/sd/qa/unit/data/fdo71434.pptx
new file mode 100755
index 000..384f1f3
Binary files /dev/null and b/sd/qa/unit/data/fdo71434.pptx differ
diff --git a/sd/qa/unit/data/xml/fdo71434_0.xml 
b/sd/qa/unit/data/xml/fdo71434_0.xml
new file mode 100644
index 000..1605ba5
--- /dev/null
+++ b/sd/qa/unit/data/xml/fdo71434_0.xml
@@ -0,0 +1,11 @@
+?xml version=1.0?
+XShapes
+ XShape positionX=2823 positionY=-75 sizeX=19753 sizeY=19045 
type=com.sun.star.drawing.GraphicObjectShape name=Picture 5 
fontHeight=18.00 fontColor= textAutoGrowHeight=false 
textAutoGrowWidth=false textContourFrame=false textFitToSize=NONE 
textHorizontalAdjust=BLOCK textVerticalAdjust=TOP textLeftDistance=250 
textRightDistance=250 textUpperDistance=125 textLowerDistance=125 
textMaximumFrameHeight=0 textMaximumFrameWidth=0 textMinimumFrameHeight=0 
textMinimumFrameWidth=0 textAnimationAmount=0 textAnimationCount=0 
textAnimationDelay=0 textAnimationDirection=LEFT textAnimationKind=NONE 
textAnimationStartInside=false textAnimationStopInside=false 
textWritingMode=LR_TB shadow=false shadowColor=808080 
shadowTransparence=0 shadowXDistance=200 shadowYDistance=200 zOrder=0 
layerID=0 layerName=layout visible=true printable=true 
moveProtect=false sizeProtect=false
+  Transformation
+   Line1 column1=19754.00 column2=0.00 column3=2823.00/
+   Line2 column1=0.00 column2=19046.00 column3=-75.00/
+   Line3 column1=0.00 column2=0.00 column3=1.00/
+  /Transformation
+  InteropGrabBag/
+ /XShape
+/XShapes
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 63b8056..9b00403 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -106,6 +106,7 @@ void SdFiltersTest::testDocumentLayout()
 { n820786.pptx, xml/n820786_, -1 },
 { n762695.pptx, xml/n762695_, -1 },
 { n593612.pptx, xml/n593612_, -1 },
+{ fdo71434.pptx, xml/fdo71434_, -1 },
 // { pptx/n828390.pptx, pptx/xml/n828390_, PPTX }, // Example
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - drawinglayer/source sd/qa

[Korrawit Pruegsanusak]

 dev/null   |binary
 drawinglayer/source/dumper/EnhancedShapeDumper.cxx |2 
 drawinglayer/source/dumper/EnhancedShapeDumper.hxx |2 
 drawinglayer/source/dumper/XShapeDumper.cxx|5 
 sd/qa/unit/data/fdo47434.pptx  |binary
 sd/qa/unit/data/pptx/xml/fdo47434_page0.xml|  247 -
 sd/qa/unit/data/xml/fdo47434_0.xml |  247 +
 sd/qa/unit/data/xml/shapes-test_page7.xml  |2 
 sd/qa/unit/import-tests.cxx|2 
 9 files changed, 256 insertions(+), 251 deletions(-)

New commits:
commit a9562d5e3c91b04214013bf296de3156f891e167
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Dec 8 14:15:39 2013 +0700

XShapeDumper: empty name should not be dumped

Change-Id: Ic1ab8840c9e543cebf322de922b01739684789ad

diff --git a/drawinglayer/source/dumper/XShapeDumper.cxx 
b/drawinglayer/source/dumper/XShapeDumper.cxx
index 75b7bd3..089640b 100644
--- a/drawinglayer/source/dumper/XShapeDumper.cxx
+++ b/drawinglayer/source/dumper/XShapeDumper.cxx
@@ -1007,8 +1007,8 @@ void dumpMoveProtectAsAttribute(sal_Bool bMoveProtect, 
xmlTextWriterPtr xmlWrite
 
 void dumpNameAsAttribute(OUString sName, xmlTextWriterPtr xmlWriter)
 {
-xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST(name), %s,
-OUStringToOString(sName, RTL_TEXTENCODING_UTF8).getStr());
+if(!sName.isEmpty())
+xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST(name), %s, 
OUStringToOString(sName, RTL_TEXTENCODING_UTF8).getStr());
 }
 
 void dumpSizeProtectAsAttribute(sal_Bool bSizeProtect, xmlTextWriterPtr 
xmlWriter)
diff --git a/sd/qa/unit/data/xml/shapes-test_page7.xml 
b/sd/qa/unit/data/xml/shapes-test_page7.xml
index 0a31e99..367b054 100644
--- a/sd/qa/unit/data/xml/shapes-test_page7.xml
+++ b/sd/qa/unit/data/xml/shapes-test_page7.xml
@@ -1,6 +1,6 @@
 ?xml version=1.0?
 XShapes
- XShape positionX=1361 positionY=9000 sizeX=24639 sizeY=7858 
type=com.sun.star.presentation.GraphicObjectShape fontHeight=18.00 
fontColor= textAutoGrowHeight=true textAutoGrowWidth=false 
textContourFrame=false textFitToSize=NONE textHorizontalAdjust=CENTER 
textVerticalAdjust=CENTER textLeftDistance=250 textRightDistance=250 
textUpperDistance=125 textLowerDistance=125 textMaximumFrameHeight=0 
textMaximumFrameWidth=0 textMinimumFrameHeight=0 textMinimumFrameWidth=0 
textAnimationAmount=0 textAnimationCount=0 textAnimationDelay=0 
textAnimationDirection=LEFT textAnimationKind=NONE 
textAnimationStartInside=false textAnimationStopInside=false 
textWritingMode=LR_TB shadow=false shadowColor=808080 
shadowTransparence=0 shadowXDistance=200 shadowYDistance=200 zOrder=0 
layerID=0 layerName=layout visible=true printable=true 
moveProtect=false name= sizeProtect=false
+ XShape positionX=1361 positionY=9000 sizeX=24639 sizeY=7858 
type=com.sun.star.presentation.GraphicObjectShape fontHeight=18.00 
fontColor= textAutoGrowHeight=true textAutoGrowWidth=false 
textContourFrame=false textFitToSize=NONE textHorizontalAdjust=CENTER 
textVerticalAdjust=CENTER textLeftDistance=250 textRightDistance=250 
textUpperDistance=125 textLowerDistance=125 textMaximumFrameHeight=0 
textMaximumFrameWidth=0 textMinimumFrameHeight=0 textMinimumFrameWidth=0 
textAnimationAmount=0 textAnimationCount=0 textAnimationDelay=0 
textAnimationDirection=LEFT textAnimationKind=NONE 
textAnimationStartInside=false textAnimationStopInside=false 
textWritingMode=LR_TB shadow=false shadowColor=808080 
shadowTransparence=0 shadowXDistance=200 shadowYDistance=200 zOrder=0 
layerID=0 layerName=layout visible=true printable=true 
moveProtect=false sizeProtect=false
   Transformation
Line1 column1=24640.00 column2=0.00 column3=1361.00/
Line2 column1=0.00 column2=7859.00 column3=9000.00/
commit 4db9ae4479dc6470d0f5c0c5b9b0be6d6dd59de9
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Dec 8 14:13:14 2013 +0700

sd/qa/unit: move and rename some files for consistency

diff --git a/sd/qa/unit/data/pptx/fdo47434-all.pptx 
b/sd/qa/unit/data/fdo47434.pptx
similarity index 100%
rename from sd/qa/unit/data/pptx/fdo47434-all.pptx
rename to sd/qa/unit/data/fdo47434.pptx
diff --git a/sd/qa/unit/data/pptx/xml/fdo47434_page0.xml 
b/sd/qa/unit/data/xml/fdo47434_0.xml
similarity index 100%
rename from sd/qa/unit/data/pptx/xml/fdo47434_page0.xml
rename to sd/qa/unit/data/xml/fdo47434_0.xml
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index bd65a30..63b8056 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -99,7 +99,7 @@ void SdFiltersTest::testDocumentLayout()
 struct { const char *pInput, *pDump; sal_Int32 nExportType; } 
aFilesToCompare[] =
 {
 { odp/shapes-test.odp, xml/shapes-test_page, -1 },
-{ pptx/fdo47434-all.pptx, pptx/xml/fdo47434_page, -1

[Libreoffice-commits] core.git: drawinglayer/source

[Korrawit Pruegsanusak]

 drawinglayer/source/dumper/XShapeDumper.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit a78f683b1e53d1328af11abdcd362e93db837701
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Dec 8 14:26:25 2013 +0700

fdo#72260: guard against duplicate name attribute

Change-Id: I1ee4b82e04318a50db8bb54bd5c7e00c79177d37
Reviewed-on: https://gerrit.libreoffice.org/6984
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/drawinglayer/source/dumper/XShapeDumper.cxx 
b/drawinglayer/source/dumper/XShapeDumper.cxx
index 089640b..accb18a 100644
--- a/drawinglayer/source/dumper/XShapeDumper.cxx
+++ b/drawinglayer/source/dumper/XShapeDumper.cxx
@@ -172,6 +172,8 @@ int closeCallback(void* )
 return 0;
 }
 
+bool m_bNameDumped;
+
 // 
 // -- FillProperties.idl --
 // 
@@ -1007,8 +1009,11 @@ void dumpMoveProtectAsAttribute(sal_Bool bMoveProtect, 
xmlTextWriterPtr xmlWrite
 
 void dumpNameAsAttribute(OUString sName, xmlTextWriterPtr xmlWriter)
 {
-if(!sName.isEmpty())
+if(!sName.isEmpty()  !m_bNameDumped)
+{
 xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST(name), %s, 
OUStringToOString(sName, RTL_TEXTENCODING_UTF8).getStr());
+m_bNameDumped = true;
+}
 }
 
 void dumpSizeProtectAsAttribute(sal_Bool bSizeProtect, xmlTextWriterPtr 
xmlWriter)
@@ -1806,6 +1811,7 @@ void dumpXShape(uno::Reference drawing::XShape  xShape, 
xmlTextWriterPtr xmlWr
 uno::Reference beans::XPropertySet  xPropSet(xShape, 
uno::UNO_QUERY_THROW);
 uno::Referencebeans::XPropertySetInfo xPropSetInfo = 
xPropSet-getPropertySetInfo();
 OUString aName;
+m_bNameDumped = false;
 
 dumpPositionAsAttribute(xShape-getPosition(), xmlWriter);
 dumpSizeAsAttribute(xShape-getSize(), xmlWriter);
@@ -1823,7 +1829,10 @@ void dumpXShape(uno::Reference drawing::XShape  
xShape, xmlTextWriterPtr xmlWr
 if (aAny = aName)
 {
 if (!aName.isEmpty())
+{
 xmlTextWriterWriteFormatAttribute( xmlWriter, 
BAD_CAST(name), %s, OUStringToOString(aName, 
RTL_TEXTENCODING_UTF8).getStr());
+m_bNameDumped = true;
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - oox/source

[Korrawit Pruegsanusak]

 oox/source/ppt/pptgraphicshapecontext.cxx |   23 ---
 1 file changed, 20 insertions(+), 3 deletions(-)

New commits:
commit 0f4a452be3342d0206d6724faf170fa2786a
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Tue Nov 26 22:31:51 2013 +0700

fdo#71434: don't show master text if PlaceHolder types defined

I've added all of valid PlaceHolder types from
http://www.schemacentral.com/sc/ooxml/t-p_ST_PlaceholderType.html

(cherry picked from commit bb1213a740b3b3b2b1967639939dd7a72c6d4237)

Change-Id: I038fe43ff83699f92ff5eb9945bce12540058478
Reviewed-on: https://gerrit.libreoffice.org/6821
Reviewed-by: Muthu Subramanian K muthus...@gmail.com
Tested-by: Muthu Subramanian K muthus...@gmail.com
Reviewed-by: Thorsten Behrens t...@documentfoundation.org
Tested-by: Thorsten Behrens t...@documentfoundation.org

diff --git a/oox/source/ppt/pptgraphicshapecontext.cxx 
b/oox/source/ppt/pptgraphicshapecontext.cxx
index e21b9a1..fec7785 100644
--- a/oox/source/ppt/pptgraphicshapecontext.cxx
+++ b/oox/source/ppt/pptgraphicshapecontext.cxx
@@ -149,9 +149,26 @@ Reference XFastContextHandler  
PPTGraphicShapeContext::createFastChildContext(
 if ( pPlaceholder.get() )
 {
 bool bUseText = true;
-// TODO: Check if pPlaceholder-getSubType is none (i.e. 
none explicitly specified)
-if( pPlaceholder-getSubType() == XML_obj )
-bUseText = false;
+switch( pPlaceholder-getSubType() )
+{
+case XML_title :
+case XML_body :
+case XML_ctrTitle :
+case XML_subTitle :
+case XML_dt :
+case XML_sldNum :
+case XML_ftr :
+case XML_hdr :
+case XML_obj :
+case XML_chart :
+case XML_tbl :
+case XML_clipArt :
+case XML_dgm :
+case XML_media :
+case XML_sldImg :
+case XML_pic :
+bUseText = false;
+}
 mpShapePtr-applyShapeReference( *pPlaceholder.get(), 
bUseText );
 PPTShape* pPPTShape = dynamic_cast PPTShape* ( 
pPlaceholder.get() );
 if ( pPPTShape )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - oox/source

[Korrawit Pruegsanusak]

 oox/source/ppt/pptgraphicshapecontext.cxx |   23 ---
 1 file changed, 20 insertions(+), 3 deletions(-)

New commits:
commit a06bc4102934c47e1aebe53ea24415fafb7c506a
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Tue Nov 26 22:45:07 2013 +0700

fdo#71434: don't show master text if PlaceHolder types defined

I've added all of valid PlaceHolder types from
http://www.schemacentral.com/sc/ooxml/t-p_ST_PlaceholderType.html

(cherry picked from commit bb1213a740b3b3b2b1967639939dd7a72c6d4237)

Change-Id: I038fe43ff83699f92ff5eb9945bce12540058478
Reviewed-on: https://gerrit.libreoffice.org/6822
Reviewed-by: Muthu Subramanian K muthus...@gmail.com
Tested-by: Muthu Subramanian K muthus...@gmail.com
Reviewed-by: Thorsten Behrens t...@documentfoundation.org
Tested-by: Thorsten Behrens t...@documentfoundation.org

diff --git a/oox/source/ppt/pptgraphicshapecontext.cxx 
b/oox/source/ppt/pptgraphicshapecontext.cxx
index 99c7328..730ce23 100644
--- a/oox/source/ppt/pptgraphicshapecontext.cxx
+++ b/oox/source/ppt/pptgraphicshapecontext.cxx
@@ -147,9 +147,26 @@ ContextHandlerRef PPTGraphicShapeContext::onCreateContext( 
sal_Int32 aElementTok
 if ( pPlaceholder.get() )
 {
 bool bUseText = true;
-// TODO: Check if pPlaceholder-getSubType is none (i.e. 
none explicitly specified)
-if( pPlaceholder-getSubType() == XML_obj )
-bUseText = false;
+switch( pPlaceholder-getSubType() )
+{
+case XML_title :
+case XML_body :
+case XML_ctrTitle :
+case XML_subTitle :
+case XML_dt :
+case XML_sldNum :
+case XML_ftr :
+case XML_hdr :
+case XML_obj :
+case XML_chart :
+case XML_tbl :
+case XML_clipArt :
+case XML_dgm :
+case XML_media :
+case XML_sldImg :
+case XML_pic :
+bUseText = false;
+}
 mpShapePtr-applyShapeReference( *pPlaceholder.get(), 
bUseText );
 PPTShape* pPPTShape = dynamic_cast PPTShape* ( 
pPlaceholder.get() );
 if ( pPPTShape )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: oox/source

[Korrawit Pruegsanusak]

 oox/source/ppt/pptgraphicshapecontext.cxx |   23 ---
 1 file changed, 20 insertions(+), 3 deletions(-)

New commits:
commit bb1213a740b3b3b2b1967639939dd7a72c6d4237
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Tue Nov 26 18:34:32 2013 +0700

fdo#71434: don't show master text if PlaceHolder types defined

I've added all of valid PlaceHolder types from
http://www.schemacentral.com/sc/ooxml/t-p_ST_PlaceholderType.html

Change-Id: I038fe43ff83699f92ff5eb9945bce12540058478
Reviewed-on: https://gerrit.libreoffice.org/6814
Reviewed-by: Muthu Subramanian K muthus...@gmail.com
Tested-by: Muthu Subramanian K muthus...@gmail.com

diff --git a/oox/source/ppt/pptgraphicshapecontext.cxx 
b/oox/source/ppt/pptgraphicshapecontext.cxx
index 99c7328..730ce23 100644
--- a/oox/source/ppt/pptgraphicshapecontext.cxx
+++ b/oox/source/ppt/pptgraphicshapecontext.cxx
@@ -147,9 +147,26 @@ ContextHandlerRef PPTGraphicShapeContext::onCreateContext( 
sal_Int32 aElementTok
 if ( pPlaceholder.get() )
 {
 bool bUseText = true;
-// TODO: Check if pPlaceholder-getSubType is none (i.e. 
none explicitly specified)
-if( pPlaceholder-getSubType() == XML_obj )
-bUseText = false;
+switch( pPlaceholder-getSubType() )
+{
+case XML_title :
+case XML_body :
+case XML_ctrTitle :
+case XML_subTitle :
+case XML_dt :
+case XML_sldNum :
+case XML_ftr :
+case XML_hdr :
+case XML_obj :
+case XML_chart :
+case XML_tbl :
+case XML_clipArt :
+case XML_dgm :
+case XML_media :
+case XML_sldImg :
+case XML_pic :
+bUseText = false;
+}
 mpShapePtr-applyShapeReference( *pPlaceholder.get(), 
bUseText );
 PPTShape* pPPTShape = dynamic_cast PPTShape* ( 
pPlaceholder.get() );
 if ( pPPTShape )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svl/qa

[Korrawit Pruegsanusak]

 svl/qa/unit/svl.cxx |   45 +
 1 file changed, 45 insertions(+)

New commits:
commit e231e6bf27b8f6741ba0a8d3779fd293e5acb1e6
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Thu Mar 21 22:57:37 2013 +0700

unit test for i#116701

Change-Id: Id9a9532d0e02b478f7913bc4a687c38f79a3a322
Reviewed-on: https://gerrit.libreoffice.org/2896
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Reviewed-by: Luboš Luňák l.lu...@suse.cz
Tested-by: Luboš Luňák l.lu...@suse.cz

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 0b481b8..0b72db3 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -87,10 +87,12 @@ public:
 
 void testNumberFormat();
 void testFdo60915();
+void testI116701();
 
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testNumberFormat);
 CPPUNIT_TEST(testFdo60915);
+CPPUNIT_TEST(testI116701);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -361,6 +363,49 @@ void Test::testFdo60915()
 }
 }
 
+// https://issues.apache.org/ooo/show_bug.cgi?id=116701
+void Test::testI116701()
+{
+LanguageType eLang = LANGUAGE_CHINESE_TRADITIONAL;
+OUString sCode, sExpected;
+double fPreviewNumber = 40573; // equals 30/01/2011
+SvNumberFormatter aFormatter(m_xContext, eLang);
+// DateFormatskey25 in i18npool/source/localedata/data/zh_TW.xml
+sal_Unicode CODE1[] =
+{
+0x0047, 0x0047, 0x0047, 0x0045, 0x0045, // GGGEE
+0x0022, 0x5E74, 0x0022,
+0x004D, // M
+0x0022, 0x6708, 0x0022,
+0x0044, // D
+0x0022, 0x65E5, 0x0022
+};
+sCode = OUString(CODE1, SAL_N_ELEMENTS(CODE1));
+sal_Unicode EXPECTED[] =
+{
+0x4E2D, 0x83EF, 0x6C11, 0x570B,
+0x0031, 0x0030, 0x0030, // 100
+0x5E74,
+0x0031, // 1
+0x6708,
+0x0033, 0x0030, // 30
+0x65E5
+};
+sExpected = OUString(EXPECTED, SAL_N_ELEMENTS(EXPECTED));
+checkPreviewString(aFormatter, sCode, fPreviewNumber, eLang, sExpected);
+sal_Unicode CODE2[] =
+{
+0x0047, 0x0047, 0x0047, 0x0045, // GGGE
+0x0022, 0x5E74, 0x0022,
+0x004D, // M
+0x0022, 0x6708, 0x0022,
+0x0044, // D
+0x0022, 0x65E5, 0x0022
+};
+sCode = OUString(CODE2, SAL_N_ELEMENTS(CODE2));
+checkPreviewString(aFormatter, sCode, fPreviewNumber, eLang, sExpected);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] unit test for i#116701

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2896

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/2896/1

unit test for i#116701

Change-Id: Id9a9532d0e02b478f7913bc4a687c38f79a3a322
---
M svl/qa/unit/svl.cxx
1 file changed, 45 insertions(+), 0 deletions(-)



diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 26a0b8d..b002e01 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -87,10 +87,12 @@
 
 void testNumberFormat();
 void testFdo60915();
+void testI116701();
 
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testNumberFormat);
 CPPUNIT_TEST(testFdo60915);
+CPPUNIT_TEST(testI116701);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -361,6 +363,49 @@
 }
 }
 
+// https://issues.apache.org/ooo/show_bug.cgi?id=116701
+void Test::testI116701()
+{
+LanguageType eLang = LANGUAGE_CHINESE_TRADITIONAL;
+OUString sCode, sExpected;
+double fPreviewNumber = 40573; // equals 30/01/2011
+SvNumberFormatter aFormatter(m_xContext, eLang);
+// DateFormatskey25 in i18npool/source/localedata/data/zh_TW.xml
+sal_Unicode CODE1[] =
+{
+0x0047, 0x0047, 0x0047, 0x0045, 0x0045, // GGGEE
+0x0022, 0x5E74, 0x0022,
+0x004D, // M
+0x0022, 0x6708, 0x0022,
+0x0044, // D
+0x0022, 0x65E5, 0x0022
+};
+sCode = OUString(CODE1, SAL_N_ELEMENTS(CODE1));
+sal_Unicode EXPECTED[] =
+{
+0x4E2D, 0x83EF, 0x6C11, 0x570B,
+0x0031, 0x0030, 0x0030, // 100
+0x5E74,
+0x0031, // 1
+0x6708,
+0x0033, 0x0030, // 30
+0x65E5
+};
+sExpected = OUString(EXPECTED, SAL_N_ELEMENTS(EXPECTED));
+checkPreviewString(aFormatter, sCode, fPreviewNumber, eLang, sExpected);
+sal_Unicode CODE2[] =
+{
+0x0047, 0x0047, 0x0047, 0x0045, // GGGE
+0x0022, 0x5E74, 0x0022,
+0x004D, // M
+0x0022, 0x6708, 0x0022,
+0x0044, // D
+0x0022, 0x65E5, 0x0022
+};
+sCode = OUString(CODE2, SAL_N_ELEMENTS(CODE2));
+checkPreviewString(aFormatter, sCode, fPreviewNumber, eLang, sExpected);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }

-- 
To view, visit https://gerrit.libreoffice.org/2896
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9a9532d0e02b478f7913bc4a687c38f79a3a322
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svl/CppunitTest_svl_qa_cppunit.mk svl/Module_svl.mk svl/qa

[Korrawit Pruegsanusak]

 svl/CppunitTest_svl_qa_cppunit.mk |   62 ++
 svl/Module_svl.mk |2 +
 svl/qa/unit/svl.cxx   |   20 +---
 3 files changed, 80 insertions(+), 4 deletions(-)

New commits:
commit 148c5451bae2d4edb9981baad66f78d2857ee038
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Mar 10 15:39:30 2013 +0700

resurrect svl/qa/unit/svl.cxx

Change-Id: I44659688794436dd97ca5f72cfa969db889d1bc1
Reviewed-on: https://gerrit.libreoffice.org/2642
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org

diff --git a/svl/CppunitTest_svl_qa_cppunit.mk 
b/svl/CppunitTest_svl_qa_cppunit.mk
new file mode 100644
index 000..827d918
--- /dev/null
+++ b/svl/CppunitTest_svl_qa_cppunit.mk
@@ -0,0 +1,62 @@
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# This file incorporates work covered by the following license notice:
+#
+#   Licensed to the Apache Software Foundation (ASF) under one or more
+#   contributor license agreements. See the NOTICE file distributed
+#   with this work for additional information regarding copyright
+#   ownership. The ASF licenses this file to you under the Apache
+#   License, Version 2.0 (the License); you may not use this file
+#   except in compliance with the License. You may obtain a copy of
+#   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,svl_qa_cppunit))
+
+$(eval $(call gb_CppunitTest_use_api,svl_qa_cppunit, \
+   offapi \
+   udkapi \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,svl_qa_cppunit, \
+   boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,svl_qa_cppunit, \
+   svl/qa/unit/svl \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,svl_qa_cppunit, \
+   comphelper \
+   cppu \
+   cppuhelper \
+   cppunit \
+   i18nisolang1 \
+   sal \
+   sot \
+   svl \
+   tl \
+   unoidl \
+   unotest \
+   utl \
+   $(gb_STDLIBS) \
+))
+
+$(eval $(call gb_CppunitTest_set_include,svl_qa_cppunit,\
+   $$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_components,svl_qa_cppunit,\
+   i18npool/util/i18npool \
+   configmgr/source/configmgr \
+))
+
+$(eval $(call gb_CppunitTest_use_ure,svl_qa_cppunit))
+$(eval $(call gb_CppunitTest_use_configuration,svl_qa_cppunit))
+
+# vim: set noet sw=4:
diff --git a/svl/Module_svl.mk b/svl/Module_svl.mk
index d12fa3a..a3a9203 100644
--- a/svl/Module_svl.mk
+++ b/svl/Module_svl.mk
@@ -29,7 +29,9 @@ $(eval $(call gb_Module_add_targets,svl,\
 
 $(eval $(call gb_Module_add_check_targets,svl,\
CppunitTest_svl_lngmisc \
+   CppunitTest_svl_qa_cppunit \
 ))
+
 #TODO: CppunitTest_svl_urihelper depends on ucb, can only be added once svl is
 # in tail build
 #FIXME: fails on MSVC
diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 8ca0473..805992e 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -150,8 +150,12 @@ void Test::testNumberFormat()
 const char* pFraction[] = {
 # \?/\?,
 # \?\?/\?\?,
+#if 0
+// TODO: Followings aren't in range of NF_FRACTION_START and NF_FRACTION_END
+// see enum NfIndexTableOffset in svl/inc/svl/zforlist.hxx
 # \?/4,
 # \?\?/100,
+#endif
 0
 };
 
@@ -167,6 +171,7 @@ void Test::testNumberFormat()
 };
 #endif
 
+#if 0 // TODO: This currently fails
 const char* pDate[] = {
 MM/DD/YY,
 MM/DD/,
@@ -191,23 +196,26 @@ void Test::testNumberFormat()
 WW,
 0
 };
+#endif
 
 const char* pTime[] = {
+HH:MM,
+HH:MM:SS,
 HH:MM AM/PM,
 HH:MM:SS AM/PM,
 [HH]:MM:SS,
 MM:SS.00,
 [HH]:MM:SS.00,
-HH:MM:SS AM/PM,
-HH:MM:SS AM/PM,
 0
 };
 
+#if 0 // TODO: This currently fails
 const char* pDateTime[] = {
 MM/DD/YY HH:MM AM/PM,
 MM/DD/YY HH:MM AM/PM,
 0
 };
+#endif
 
 const char* pBoolean[] = {
 BOOLEAN,
@@ -228,18 +236,22 @@ void Test::testNumberFormat()
 { NF_NUMBER_START, NF_NUMBER_END, 6, pNumber },
 { NF_SCIENTIFIC_START, NF_SCIENTIFIC_END, 2, pScientific },
 { NF_PERCENT_START, NF_PERCENT_END, 2, pPercent },
-{ NF_FRACTION_START, NF_FRACTION_END, 4, pFraction },
+{ NF_FRACTION_START, NF_FRACTION_END, 2, pFraction },
 #if 0 // TODO: Find out why on some systems the last two currency format codes 
differ.
 { NF_CURRENCY_START, NF_CURRENCY_END, 6, pCurrency },
 #endif
+#if 0 // TODO: This currently fails
 { NF_DATE_START, NF_DATE_END, 21, pDate },
+#endif
 { NF_TIME_START, NF_TIME_END, 7

[PATCH] Add back subsequencecheck targets accidentally removed ...

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2630

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2630/1

Add back subsequencecheck targets accidentally removed ...

... in c95e3fb64695cedfa40bfe5472879ee8a692d73f

Change-Id: I89b34ae414b8c02d4f015e52047a232fefda2d4b
---
M sc/Module_sc.mk
1 file changed, 17 insertions(+), 0 deletions(-)



diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index b4cfcb5..4a4fc41 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -59,7 +59,24 @@
 # CppunitTest_sc_annotationshapeobj \
 
 $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\
+JunitTest_sc_complex \
+JunitTest_sc_unoapi \
+CppunitTest_sc_outlineobj \
+CppunitTest_sc_annotationobj \
+CppunitTest_sc_annotationsobj \
+CppunitTest_sc_cellrangeobj \
+$(if $(filter-out $(OS),IOS), \
+   CppunitTest_sc_databaserangeobj) \
+CppunitTest_sc_datapilottableobj \
+CppunitTest_sc_datapilotfieldobj \
 CppunitTest_sc_macros_test \
+CppunitTest_sc_namedrangeobj \
+CppunitTest_sc_namedrangesobj \
+CppunitTest_sc_tablesheetobj \
+CppunitTest_sc_tablesheetsobj \
+CppunitTest_sc_editfieldobj_cell \
+CppunitTest_sc_editfieldobj_header \
+CppunitTest_sc_modelobj \
 ))
 
 # vim: set noet sw=4 ts=4:

-- 
To view, visit https://gerrit.libreoffice.org/2630
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89b34ae414b8c02d4f015e52047a232fefda2d4b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/Module_sc.mk

[Korrawit Pruegsanusak]

 sc/Module_sc.mk |   17 +
 1 file changed, 17 insertions(+)

New commits:
commit 9fd65685560b4fb8dcd4c05f5ff53c64db831f61
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Mar 10 15:19:50 2013 +0700

Add back subsequencecheck targets accidentally removed ...

... in c95e3fb64695cedfa40bfe5472879ee8a692d73f

Change-Id: I89b34ae414b8c02d4f015e52047a232fefda2d4b
Reviewed-on: https://gerrit.libreoffice.org/2630
Reviewed-by: Matúš Kukan matus.ku...@gmail.com
Tested-by: Matúš Kukan matus.ku...@gmail.com

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index b4cfcb5..4a4fc41 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -59,7 +59,24 @@ $(eval $(call gb_Module_add_slowcheck_targets,sc, \
 # CppunitTest_sc_annotationshapeobj \
 
 $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\
+JunitTest_sc_complex \
+JunitTest_sc_unoapi \
+CppunitTest_sc_outlineobj \
+CppunitTest_sc_annotationobj \
+CppunitTest_sc_annotationsobj \
+CppunitTest_sc_cellrangeobj \
+$(if $(filter-out $(OS),IOS), \
+   CppunitTest_sc_databaserangeobj) \
+CppunitTest_sc_datapilottableobj \
+CppunitTest_sc_datapilotfieldobj \
 CppunitTest_sc_macros_test \
+CppunitTest_sc_namedrangeobj \
+CppunitTest_sc_namedrangesobj \
+CppunitTest_sc_tablesheetobj \
+CppunitTest_sc_tablesheetsobj \
+CppunitTest_sc_editfieldobj_cell \
+CppunitTest_sc_editfieldobj_header \
+CppunitTest_sc_modelobj \
 ))
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: gerrit: can't use the draft queue

[Korrawit Pruegsanusak]

Hello David,

On Sun, Mar 10, 2013 at 5:22 PM, David Ostrovsky david.ostrov...@gmx.de wrote:
 my bad, sorry: I missed s in drafts. The correct path is:
 refs/drafts/master
 Note: you must add reviewer manually, otherwise he wouldn't see your patch.

Works fine with this. Thanks :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] add unittest for fdo#59240

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2078

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2078/1

add unittest for fdo#59240

Change-Id: Ic287228f578c9ecb0f69a47380c890e337203b31
---
A sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv
M sc/qa/unit/data/ods/bug-fixes.ods
M sc/qa/unit/subsequent_filters-test.cxx
3 files changed, 8 insertions(+), 0 deletions(-)



diff --git a/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv 
b/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv
new file mode 100644
index 000..ffd5da6
--- /dev/null
+++ b/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv
@@ -0,0 +1 @@
+๑.๐๐
diff --git a/sc/qa/unit/data/ods/bug-fixes.ods 
b/sc/qa/unit/data/ods/bug-fixes.ods
index b7c0539..f40141b 100644
--- a/sc/qa/unit/data/ods/bug-fixes.ods
+++ b/sc/qa/unit/data/ods/bug-fixes.ods
Binary files differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 09d6373..84f52ef 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -903,6 +903,13 @@
 CPPUNIT_ASSERT(!pDBData-HasHeader());
 }
 
+{
+// fdo#59240
+OUString aCSVFileName;
+createCSVPath(bugFix_Sheet4., aCSVFileName);
+testFile(aCSVFileName, pDoc, 3);
+}
+
 xDocSh-DoClose();
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/2078
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic287228f578c9ecb0f69a47380c890e337203b31
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] sc_subsequent_filters-test: add bug number

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2079

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/2079/1

sc_subsequent_filters-test: add bug number

from 84ae3c9853b7b90d7b859fd562dabc7b31e8deb8

Change-Id: I1768bfb7a68affe423485eff77b6005abde2e2a7
---
M sc/qa/unit/subsequent_filters-test.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 09d6373..63261f9 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -886,7 +886,7 @@
 ScDocument* pDoc = xDocSh-GetDocument();
 
 {
-// fdo
+// fdo#40967
 OUString aCSVFileName;
 createCSVPath(OUString(RTL_CONSTASCII_USTRINGPARAM(bugFix_Sheet2.)), 
aCSVFileName);
 testFile(aCSVFileName, pDoc, 1);

-- 
To view, visit https://gerrit.libreoffice.org/2079
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1768bfb7a68affe423485eff77b6005abde2e2a7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/qa

[Korrawit Pruegsanusak]

 sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv |1 +
 sc/qa/unit/data/ods/bug-fixes.ods|binary
 sc/qa/unit/subsequent_filters-test.cxx   |7 +++
 3 files changed, 8 insertions(+)

New commits:
commit 97642ab568861444b95bddac63d4a41729934efc
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Feb 10 14:45:15 2013 +0700

add unittest for fdo#59240

Change-Id: Ic287228f578c9ecb0f69a47380c890e337203b31
Reviewed-on: https://gerrit.libreoffice.org/2078
Reviewed-by: Tor Lillqvist t...@iki.fi
Tested-by: Tor Lillqvist t...@iki.fi

diff --git a/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv 
b/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv
new file mode 100644
index 000..ffd5da6
--- /dev/null
+++ b/sc/qa/unit/data/contentCSV/bugFix_Sheet4.csv
@@ -0,0 +1 @@
+๑.๐๐
diff --git a/sc/qa/unit/data/ods/bug-fixes.ods 
b/sc/qa/unit/data/ods/bug-fixes.ods
index b7c0539..f40141b 100644
Binary files a/sc/qa/unit/data/ods/bug-fixes.ods and 
b/sc/qa/unit/data/ods/bug-fixes.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 63261f9..16db954 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -903,6 +903,13 @@ void ScFiltersTest::testBugFixesODS()
 CPPUNIT_ASSERT(!pDBData-HasHeader());
 }
 
+{
+// fdo#59240
+OUString aCSVFileName;
+createCSVPath(bugFix_Sheet4., aCSVFileName);
+testFile(aCSVFileName, pDoc, 3);
+}
+
 xDocSh-DoClose();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Korrawit Pruegsanusak]

 sc/qa/unit/subsequent_filters-test.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 80cbc04c2cbe25ebdfe2f22bb2e5ba62728e9632
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Feb 10 15:00:49 2013 +0700

sc_subsequent_filters-test: add bug number

from 84ae3c9853b7b90d7b859fd562dabc7b31e8deb8

Change-Id: I1768bfb7a68affe423485eff77b6005abde2e2a7
Reviewed-on: https://gerrit.libreoffice.org/2079
Reviewed-by: Thomas Arnhold tho...@arnhold.org
Tested-by: Thomas Arnhold tho...@arnhold.org

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 09d6373..63261f9 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -886,7 +886,7 @@ void ScFiltersTest::testBugFixesODS()
 ScDocument* pDoc = xDocSh-GetDocument();
 
 {
-// fdo
+// fdo#40967
 OUString aCSVFileName;
 createCSVPath(OUString(RTL_CONSTASCII_USTRINGPARAM(bugFix_Sheet2.)), 
aCSVFileName);
 testFile(aCSVFileName, pDoc, 1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] doc export: add unit test for bug i106749

[Korrawit Pruegsanusak]

Hello all,

On Fri, Jan 11, 2013 at 8:44 PM, Pierre-Eric Pelloux-Prayer (via Code
Review) ger...@gerrit.libreoffice.org wrote:
 I have submitted a patch for review:
 https://gerrit.libreoffice.org/1646
 doc export: add unit test for bug i106749

IMHO it's great to have many unit tests as possible :), but I wonder ...

 diff --git a/sw/qa/extras/ww8export/data/new-page-styles.doc 
 b/sw/qa/extras/ww8export/data/new-page-styles.doc
 new file mode 100644
 index 000..c3886fd
 --- /dev/null
 +++ b/sw/qa/extras/ww8export/data/new-page-styles.doc

Do we have a license to use this file? (no offense of course! :) Or in
general, what about any bugzilla attachments? Because it seems you
have taken this file from apache bugzilla ...

What about another patch at https://gerrit.libreoffice.org/1644, doc
export: add unit test for fdo#56513 ? It's an attachment from Luke
Deller, which we already have a license statement from him. Does the
license statement include this file? Does this differ to the first
case? or is this file simple enough that it doesn't have copyright?

OK, maybe I'm wrong, because I'm not a lawyer, but ... :)

Michael Meeks, since you are rebasing the code from apache, do you
have any opinions?

Best Regards,
--
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: fdo#58671: Remove accelerators from Undo action texts

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1596

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1596/1

fdo#58671: Remove accelerators from Undo action texts

These three texts appear in Undo dropdown list, so they don't need accelerators

(cherry picked from commit 93a9e52dccf15b53fc1935145df24306e3a4fc3e)

Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb
---
M editeng/source/editeng/editeng.src
M sc/source/ui/src/globstr.src
M sw/source/core/undo/undo.src
3 files changed, 3 insertions(+), 3 deletions(-)



diff --git a/editeng/source/editeng/editeng.src 
b/editeng/source/editeng/editeng.src
index 2bea4aa..66f6eb4 100644
--- a/editeng/source/editeng/editeng.src
+++ b/editeng/source/editeng/editeng.src
@@ -61,7 +61,7 @@
 
 String RID_EDITUNDO_TRANSLITERATE
 {
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
 };
 
 
diff --git a/sc/source/ui/src/globstr.src b/sc/source/ui/src/globstr.src
index 79ad06e..a5ac8b2 100644
--- a/sc/source/ui/src/globstr.src
+++ b/sc/source/ui/src/globstr.src
@@ -354,7 +354,7 @@
 };
 String STR_UNDO_TRANSLITERATE
 {
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
 };
 String STR_DBNAME_IMPORT
 {
diff --git a/sw/source/core/undo/undo.src b/sw/source/core/undo/undo.src
index aebd3b8..d5c1ac4 100644
--- a/sw/source/core/undo/undo.src
+++ b/sw/source/core/undo/undo.src
@@ -267,7 +267,7 @@
 
 String STR_TRANSLITERATE
 {
-Text [ en-US ] = ~Change Case;
+Text [ en-US ] = Change Case;
 };
 
 String STR_DELNUM

-- 
To view, visit https://gerrit.libreoffice.org/1596
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#58671: Remove accelerators from Undo action texts

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1473

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1473/1

fdo#58671: Remove accelerators from Undo action texts

These three texts appear in Undo dropdown list, so they don't need accelerators

Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb
---
M editeng/source/editeng/editeng.src
M sc/source/ui/src/globstr.src
M sw/source/core/undo/undo.src
3 files changed, 3 insertions(+), 3 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1473
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Anyone got error 500 from fdo bugzilla?

[Korrawit Pruegsanusak]

Hello,

First, sorry for very late reply. And thanks for your reply.

On Mon, Nov 26, 2012 at 10:47 PM, dE . de.tec...@gmail.com wrote:
 This happens when Apache is overloaded.

Currently, I still got hit by this bug. As I noticed, it happened on
every other page load (good, error, good, error), so I don't think
it's Apache overload, though.

Best Regards,
--
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [ANN] LibreOffice 4.0.0 ALPHA1 test builds available

[Korrawit Pruegsanusak]

Hello all,

On Thu, Nov 22, 2012 at 8:47 PM, Fridrich Strba
fridrich.st...@graduateinstitute.ch wrote:
 If you've a bit of time, please give them a try  report bugs not yet in
 bugzilla.

I've found that Options  Language Settings  Languages lead to CRASH
on Win7 x64.
Could someone, especially from l10n team, confirm this? :)

I've reported this at https://bugs.freedesktop.org/show_bug.cgi?id=57413

P.S. I didn't check whether older master builds have this problem.

Best Regards,
--
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: config.log for failed build in tinderbox Win-x86_6

[Korrawit Pruegsanusak]

Hello,

On Mon, Nov 12, 2012 at 1:29 PM, Korrawit Pruegsanusak
detective.conan.1...@gmail.com wrote:
 I just built master updated today at
 a1ac2538e9b287444500618ab4d2f0f06c25cf34, and it failed with same
 error as tinderbox Win-x86_6 -- liblangtag configure failed [1].

Seems fixed with Tor Lillqvist's
http://cgit.freedesktop.org/libreoffice/core/commit/?id=40e9afbf745bdac5f8fb27fd8f2205cde6683697
Thanks Tor! :-)

Best Regards,
--
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-6, 3-6-3] fix fdo#47669: check for started hyperlink before closing

[Korrawit Pruegsanusak]

Hello all,

I'd like to propose the attached patch fixing fdo#47669 into -3-6 and
-3-6-3 branches. Explanation is in commit message.

I've compiled and tested on -3-6 branch at
0eee6469304ba15f42bcafb6707cc98bcbff9112, and it worked fine.

Best Regards,
-- 
Korrawit Pruegsanusak


0001-Fix-fdo-47669-also-check-if-we-started-the-tag-befor.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#47669: also check if we started the tag before endin...

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/831

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/831/1

Fix fdo#47669: also check if we started the tag before ending it

The problem is we created imbalance end tag /w:hyperlink which shouldn't
be there. So, place a check before inserting end tag should help.

Inspired by (read: copied from) c1c2688912e769dfd7654e11e87dae380a8ce1eb ;)

Change-Id: Ic933f6da44c788cba48bb2fe6fa29658985310b6
---
A sw/qa/extras/ooxmlexport/data/fdo47669.docx
M sw/qa/extras/ooxmlexport/ooxmlexport.cxx
M sw/source/filter/ww8/docxattributeoutput.cxx
3 files changed, 21 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/831
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic933f6da44c788cba48bb2fe6fa29658985310b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: FDO Font Size (Email)

[Korrawit Pruegsanusak]

Hello Joel, all,

On Tue, Oct 2, 2012 at 10:05 PM, Joel Madero jmadero@gmail.com wrote:
 Anyone else seeing that the updated FDO font size for comments (for bugs you
 are CC'ed on) are tiny?

Me too! :-)

I just found https://bugs.freedesktop.org/userprefs.cgi, that you may
set Preferred email format to Text Only. This should help, but I
didn't try yet. So, could you please report back if it really helps?
;) Thanks.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] configure.in: edit message checking for new GStreamer 1.0

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/722

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/722/1

configure.in: edit message checking for new GStreamer 1.0

to not duplicate the message checking for old one
and be consistent with the help message in AS_HELP_STRING

Change-Id: I91e0a5ed0e2278de013d7872eadc6f93b970c231
---
M configure.in
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/722
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91e0a5ed0e2278de013d7872eadc6f93b970c231
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] sc/qa/unit: recover xDocSh-DoClose()

[Korrawit Pruegsanusak (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/723

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/723/1

sc/qa/unit: recover xDocSh-DoClose()

which was removed in fde638b3ac35997aa3e38a37fed56d6eb661806b

Change-Id: I57caf615f0ca49d0b90cb4c68b8ce8edf8f72a97
---
M sc/qa/unit/subsequent_filters-test.cxx
1 file changed, 2 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/723
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57caf615f0ca49d0b90cb4c68b8ce8edf8f72a97
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: 'load' functions in cpp unittest - are they unused?

[Korrawit Pruegsanusak]

Hello Caolán,

First, sorry for a late reply.

On Fri, Aug 17, 2012 at 11:33 PM, Caolán McNamara caol...@redhat.com wrote:
 On Fri, 2012-08-17 at 23:19 +0700, Korrawit Pruegsanusak wrote:
 Hello all,

 While I tried to create unittest with UNO API for fdo#47434 [1], I
 came across a function 'load' defined in
 sd/qa/unit/regression-test.cxx line #80:

 virtual bool load( const rtl::OUString rFilter, const
 rtl::OUString rURL, const rtl::OUString rUserData);

 and the function code is defined in line #239-253. Also, opengrok [2]
 showed this 'load' functions *seem* to be unused, because the result
 shown only the function definitions, without function call.

 SdFiltersTest inherits from test::FiltersTest and that has a
 FiltersTest::testDir which calls recursiveScan which calls the virtual
 load. In this specific case the SdFiltersTest::load isn't being used.
 But that's more an oversight and someone should get around to filling a
 dir like sw/qa/core/data/ww8 and do the same as SwFiltersTest::testCVEs
 for sd

Thanks for the info. :-)

Anyway, this sd/qa/unit/regression-test.cxx doesn't have 'testDir'
function. This 'testDir', though, is in sd/qa/unit/filters-test.cxx.

So, I browsed through each file in [1] and found that: the files that
have 'load' function will also have 'testDir'. *Except* only two
files:

sd/qa/unit/regression-test.cxx (line #80)
sc/qa/unit/subsequent_filters-test.cxx (line #246)

which I think they are unused. Is it ok to remove both of them?

[1] 
http://opengrok.libreoffice.org/search?q=loadproject=coredefs=refs=path=-java+-idl+-osl+qa+cxxhist=

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

'load' functions in cpp unittest - are they unused?

[Korrawit Pruegsanusak]

Hello all,

While I tried to create unittest with UNO API for fdo#47434 [1], I
came across a function 'load' defined in
sd/qa/unit/regression-test.cxx line #80:

virtual bool load( const rtl::OUString rFilter, const
rtl::OUString rURL, const rtl::OUString rUserData);

and the function code is defined in line #239-253. Also, opengrok [2]
showed this 'load' functions *seem* to be unused, because the result
shown only the function definitions, without function call.

Are these functions are actually unused? They are defined 'virtual',
so are there any classes that inherit them?
I might have missed something, and probably I had. Sorry if I used
incorrect word or if this question sound dumb.

[1] https://gerrit.libreoffice.org/421
[2] 
http://opengrok.libreoffice.org/search?q=loadproject=coredefs=refs=path=-java+-idl+-osl+qa+cxxhist=

Have a nice weekend everyone :-)
Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: image rendering regression ?

[Korrawit Pruegsanusak]

Hello Tomaž, Michael, all,

On Tue, Aug 14, 2012 at 9:53 PM, Michael Meeks michael.me...@suse.com wrote:

 On Tue, 2012-08-14 at 13:14 +0200, Tomaž Vajngerl wrote:
 I know about this problem and I am working on it. There seems to be a
 problem with rendering of transparent images in grfmgr2.cxx.

 Oh great ! :-) thanks for digging into that - just trying to raise
 master regressions here quickly.

First, Tomaž, thanks for the fix!

Anyway, looking at
http://cgit.freedesktop.org/libreoffice/core/diff/svtools/source/graphic/grfmgr2.cxx?id=42801a0e690a63c3a94b1d8256b6c7cd64856bd2ignorews=1
I saw this:

-if( !pResultBitmapEx )
+if( true || !pResultBitmapEx )

Is this intended?

Last, if you want some more testcase, you may see fdo#53138.

Thanks again!
Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-5, 3-6, 3-6-1?] fdo#47434 pptx arrow import

[Korrawit Pruegsanusak]

Hello all,

I'd like to propose [1] which fix fdo#47434 to be included in -3-5,
3-6, and 3-6-1 if possible.

For the detailed explanation, please see in bugzilla starting from comment #13.

Also, the unit test waiting in gerrit [2] couldn't be backported
because I use XShapeDumper available only in master, and my skill
isn't enough to use UNO API. ;)

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3acf19c0502b0758359b56abda81e504d167630
[2] https://gerrit.libreoffice.org/421

Thanks!

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

[Korrawit Pruegsanusak]

Hello all,

Bumping this one, would be nice to get it backported :-)
Please find patches attached in the first mail of this thread.

Thanks very much!
Best Regards,

On Mon, Jul 16, 2012 at 12:08 PM, Korrawit Pruegsanusak
detective.conan.1...@gmail.com wrote:
 Hello all,

 On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak
 detective.conan.1...@gmail.com wrote:
 The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
 on master, so I propose this review for the inclusion in both -3-6 and
 -3-5 branches.
 [snip]
 Last, sorry to say this, but I didn't have time to test if it could be
 build or even fix the problem. (I didn't test in both branches, but
 tested in master that this really fixes the problem, please see
 comment 11 in fdo bugzilla).

 I've tested a build in -3-6 branch, with the attached patch on top of
 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b
 and it really fix fdo#50907.

 I didn't test with other pptx files, nor in -3-5 branch.


-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] fdo#50633 IDE: select current module in Object Catalog on open

[Korrawit Pruegsanusak]

Hello,

On Tue, Jul 24, 2012 at 4:31 PM, János Uray uray.ja...@gmail.com wrote:
 This patch solves this bug:

Seems you forgot to attach the patch? :-)

Bets Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

[Korrawit Pruegsanusak]

Hello all,

On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak
detective.conan.1...@gmail.com wrote:
 The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
 on master, so I propose this review for the inclusion in both -3-6 and
 -3-5 branches.
[snip]
 Last, sorry to say this, but I didn't have time to test if it could be
 build or even fix the problem. (I didn't test in both branches, but
 tested in master that this really fixes the problem, please see
 comment 11 in fdo bugzilla).

I've tested a build in -3-6 branch, with the attached patch on top of
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b
and it really fix fdo#50907.

I didn't test with other pptx files, nor in -3-5 branch.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

[Korrawit Pruegsanusak]

Hello all,

First, sorry for not using gerrit. I've tried it but got invalid
author error as I tried to push Muthu's patch.

The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
on master, so I propose this review for the inclusion in both -3-6 and
-3-5 branches.

Branch -3-5 didn't apply cleanly, because conflict by getLength() to
isEmpty() change, so patch attached, for both branches. I also deleted
code-indent change, which is already in master, in
oox/source/ppt/pptshapegroupcontext.cxx.

Last, sorry to say this, but I didn't have time to test if it could be
build or even fix the problem. (I didn't test in both branches, but
tested in master that this really fixes the problem, please see
comment 11 in fdo bugzilla).

Thanks :-)
Best Regards,
-- 
Korrawit Pruegsanusak


0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-5.patch
Description: Binary data


0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-6.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sd/source

[Korrawit Pruegsanusak]

 sd/source/ui/docshell/docshel4.cxx |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 7119c94f78f8160ee502fc4277bdaaf0b5ddf138
Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com
Date:   Sun Jul 8 17:16:27 2012 +0700

fdo#51179: SearchAscii() is equal to indexOf(), not match()

regression from 8adec08d56a9ad46d3550e43b115e916c4cf783f

Change-Id: Ic1c3160be1c61162f6a62a7e14c4efb7bedccdcc

diff --git a/sd/source/ui/docshell/docshel4.cxx 
b/sd/source/ui/docshell/docshel4.cxx
index 5b0d4c5..df97c37 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -469,7 +469,8 @@ sal_Bool DrawDocShell::ConvertFrom( SfxMedium rMedium )
 mpDoc-StopWorkStartupDelay();
 bRet = SdPPTFilter( rMedium, *this, sal_True ).Import();
 }
-else if (aFilterName.match(impress8 ) || aFilterName.match(draw8))
+else if (aFilterName.indexOf(impress8) = 0 ||
+ aFilterName.indexOf(draw8) = 0)
 {
 // TODO/LATER: nobody is interested in the error code?!
 mpDoc-CreateFirstPages();
@@ -478,7 +479,8 @@ sal_Bool DrawDocShell::ConvertFrom( SfxMedium rMedium )
 bRet = SdXMLFilter( rMedium, *this, sal_True ).Import( nError );
 
 }
-else if (aFilterName.match(StarOffice XML (Draw)) || 
aFilterName.match(StarOffice XML (Impress)))
+else if (aFilterName.indexOf(StarOffice XML (Draw)) = 0 ||
+ aFilterName.indexOf(StarOffice XML (Impress)) = 0)
 {
 // TODO/LATER: nobody is interested in the error code?!
 mpDoc-CreateFirstPages();
@@ -595,25 +597,27 @@ sal_Bool DrawDocShell::ConvertTo( SfxMedium rMedium )
 const rtl::OUString aTypeName( pMediumFilter-GetTypeName() );
 SdFilter*   pFilter = NULL;
 
-if( aTypeName.match( graphic_HTML ) )
+if( aTypeName.indexOf( graphic_HTML ) = 0 )
 {
 pFilter = new SdHTMLFilter( rMedium, *this, sal_True );
 }
-else if( aTypeName.match( MS_PowerPoint_97 ) )
+else if( aTypeName.indexOf( MS_PowerPoint_97 ) = 0 )
 {
 pFilter = new SdPPTFilter( rMedium, *this, sal_True );
 ((SdPPTFilter*)pFilter)-PreSaveBasic();
 }
-else if ( aTypeName.match( CGM_Computer_Graphics_Metafile ) )
+else if ( aTypeName.indexOf( CGM_Computer_Graphics_Metafile ) = 0 )
 {
 pFilter = new SdCGMFilter( rMedium, *this, sal_True );
 }
-else if( aTypeName.match( draw8 ) || aTypeName.match( impress8 ) )
+else if( aTypeName.indexOf( draw8 ) = 0 ||
+ aTypeName.indexOf( impress8 ) = 0 )
 {
 pFilter = new SdXMLFilter( rMedium, *this, sal_True );
 UpdateDocInfoForSave();
 }
-else if( aTypeName.match( StarOffice_XML_Impress ) || 
aTypeName.match( StarOffice_XML_Draw ) )
+else if( aTypeName.indexOf( StarOffice_XML_Impress ) = 0 ||
+ aTypeName.indexOf( StarOffice_XML_Draw ) = 0 )
 {
 pFilter = new SdXMLFilter( rMedium, *this, sal_True, 
SDXMLMODE_Normal, SOFFICE_FILEFORMAT_60 );
 UpdateDocInfoForSave();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] Online update in 3.6

[Korrawit Pruegsanusak]

Hello Thorsten, Kendy, all,

On Sun, Jul 8, 2012 at 4:11 AM, klaus-jürgen weghorn ol
o...@sophia-louise.de wrote:
 No LODev3.6 Beta3

I've created and attached a patch at
https://bugs.freedesktop.org/show_bug.cgi?id=51858.
Please push and deploy it. Thanks! :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [REVIEW] fdo#50896 and typo in fdo#47044

[Korrawit Pruegsanusak]

Hello again,

On Sun, Jun 17, 2012 at 11:40 AM, Korrawit Pruegsanusak
detective.conan.1...@gmail.com wrote:
 * 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=02d9bd3b14575442a6532915cdb18bb4a69ad35f
 This fixed a typo in fdo#47044 and should go into both -3-5 and -3-6 branch.

and to -3-5-5 if possible. :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW] fdo#50896 and typo in fdo#47044

[Korrawit Pruegsanusak]

Hello David, all,

I'd like to propose 2 patches for including in stable branch as follows.

* 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b3473b9d227df79a383d09c2f2ebf6d6eebf3697
This fixed fdo#50896 and should go into -3-6 branch.

* 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=02d9bd3b14575442a6532915cdb18bb4a69ad35f
This fixed a typo in fdo#47044 and should go into both -3-5 and -3-6 branch.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW] Muthu's patches for pptx import fixes

[Korrawit Pruegsanusak]

Hello Muthu, all,

I'd like to propose two Muthu's patches to include in stable branch as follow:

* 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=90352e5f1e50291960c944f9a1f44ab3e91d6503
This also fixed long-standing fdo#35372 and its duplicate fdo#37311,
although there is still a problem in fdo#46594, but it's an
improvement and I think it's better than nothing.
This should go to only -3-5 branch because it's pushed before -3-6 branching.

* 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=25dd603fe2044f35341fe0c6d0b632c9295a824e
This also fixed fdo#49806 and its duplicates fdo#49808 and fdo#50283.
Although official build didn't suffer from this bug, but daily builds
did.
This should go to -3-5 and -3-6 branch.

If I shouldn't do this proposal in the future, please feel free to tell. :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW] fdo#43989 first launch terminates after splash

[Korrawit Pruegsanusak]

Hello Stephan, all,

I'd like to propose Stephan's patch into stable branch:

* 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=55836370ffb70a34b888f81cdacdfede8fee29cf
This fixed fdo#43989, which is 3.5 MAB, but we already have Andras'
8783ead70cc2bc2a83bf473b0dfb51f3ee10b6da backported, so I'm not sure
whether we should have Stephan's patch backported too.

Also, from the commit message, Stephan committed new fix for
bnc#524250 at b5ad981518f4407243f89507b2561dd0b1ef28ee. Should this
patch backported as well?

These two patches, if appropriate, should go to both -3-5 and -3-6 branches.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [BUILD] consistent test failures under windows

[Korrawit Pruegsanusak]

Hello Mat,

On Sat, Jun 9, 2012 at 7:29 PM, Mat M m...@gmx.fr wrote:
 Or what should I do to be sure the test is really broken and not my build ?

I think you should disable your antivirus during the build. It
captures CVE files as a threat, and delete / quarantine them.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Cleaning bug list

[Korrawit Pruegsanusak]

Hello Joel, all,

First, a big thank you from me! :-)

On Fri, Jun 8, 2012 at 1:49 PM, Joel Madero jmadero@gmail.com wrote:
 2. If two or more people have said that they do not have the bug I'm doing
 the following if there hasn't been action for 30+ days:
 a. If it's stated that the bug was fixed in a recent release, I'm putting
 RESOLVED with a comment that if it's not for the author or someone else to
 open it back up

If there is an explicit fix linked / posted, it's good to use FIXED.
If not, that is the bug is just not reproducible with recent release,
we prefer WORKSFORME instead.

 3. If it's confirmed by other people I'm changing it to confirmed

Could you please give some details about this confirmed? Because we
don't have an explicit confirmed, we just change UNCONFIRMED to NEW.

Anyway, these process / rules / ... could be changed if / when
appropriate, of course.

And yes, the we here is now including you, Joel. :-)

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] New Bugzilla Version Picker items – 2

[Korrawit Pruegsanusak]

Hello Rainer,

On Wed, Jun 6, 2012 at 11:49 AM, Rainer Bielefeld
libreoff...@bielefeldundbuss.de wrote:
 I will prepare a mass change of all Versions today, don’t worry, there will
 be no mass e-mails for the bugs.

Thanks for this! :-)

But what will we do with current LibO Master bugs [1]? (~500 items)
Do we have to change them to correct version manually?

[1] 
https://bugs.freedesktop.org/buglist.cgi?list_id=82804query_format=advancedversion=LibO%20Masterproduct=LibreOffice

Best Regards,
-- 
Korrawit Pruegsanusak
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/