Re: Context Menu - Writer

[Marcos Souza]

Thank you guys!


2014-08-16 9:02 GMT-03:00 Tomaž Vajngerl :

> Hi,
>
> On Sat, Aug 16, 2014 at 12:16 AM, Marcos Souza 
> wrote:
> > Hello guys,
> >
> > I'm trying to contribute to LibreOffice. But I can not find the piece of
> > code that refers to the 'context menu' in writer module.
> > I would like to do what suggests Bug 62947 in bugzilla.
> > Could anyone help me with this? I really want to contribute but can not
> find
> > me in the code.
> > I already have the code on my computer.
> > Thank you.
> >
> > PS: Sorry for my English.
> >
>
> I gave some code pointers as comment in the bug.
>
> Regards, Tomaž
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context Menu - Writer

[Marcos Souza]

Hello guys,

I'm trying to contribute to LibreOffice. But I can not find the piece of
code that refers to the 'context menu' in writer module.
I would like to do what suggests Bug 62947 in bugzilla.
Could anyone help me with this? I really want to contribute but can not find
me in the code.
I already have the code on my computer.
Thank you.

PS: Sorry for my English.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Help in the issue fdo#70807

[Marcos Souza]

Hi guys!

I'm trying to solve the issues fdo#70807. I putted some points in the
bug, but I need to understand where the code set a style as used.

Can someone point to me where a style is set as used inside the code base?

Thanks since now!



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: Problem while moving oox to autoinstallation

[Marcos Souza]

Sending to list, because maybe _mst is very busy and some other guy can
help me on this :)

 Mensagem original 
Assunto: Problem while moving oox to autoinstallation
Data: Tue, 19 Nov 2013 09:07:13 -0200
De: Marcos Souza 
Para: mst...@redhat.com

Hi Michail, how are you?

I hope fine :)

So, I told you when I was in Germany about an problem while I tried to
move oox module to autoinstallation. Attached is a patch that I did
yesterday moving this an another libs.

I got this errror:
: *
: ERROR: Could not find file gid_File_Lib_Oox in list of files! at
/home/marcos/gitroot/core/solenv/bin/modules/installer/profiles.pm line 84.
: *

And, I did and git grep:
marcos@jedi:~/gitroot/core$ git grep gid_File_Lib_Oox
instsetoo_native/util/openoffice.lst.in:GLOBALFILEGID
gid_File_Lib_Oox
instsetoo_native/util/openoffice.lst.in:GLOBALFILEGID
gid_File_Lib_Oox
solenv/bin/modules/installer/profiles.pm:# Taking the base data from
the "gid_File_Lib_Oox"
solenv/bin/modules/installer/profiles.pm:my $vclgid =
"gid_File_Lib_Oox";

So, it seems to use oox as base to another libs to move or I'm missing
something?

Thanks a lot for looking at this!

PATCH:
diff --git a/Repository.mk b/Repository.mk
index eca28ce..c4a6b57 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -305,6 +305,7 @@ $(eval $(call
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
odbcbase \
odfflatxml \
offacc \
+   oox \
passwordcontainer \
pcr \
$(if $(ENABLE_NPAPI_FROM_BROWSER),pl) \
@@ -323,6 +324,12 @@ $(eval $(call
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
simplecanvas \
slideshow \
sot \
+$(if $(and $(filter unx,$(GUIBASE)),$(filter-out MACOSX,$(OS))), \
+$(if $(ENABLE_HEADLESS),, \
+spa \
+spl_unx \
+) \
+) \
spell \
$(if $(ENABLE_HEADLESS),,spl) \
$(if $(DISABLE_SCRIPTING),,stringresource) \
@@ -352,7 +359,13 @@ $(eval $(call
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
$(if $(DISABLE_SCRIPTING),,vbahelper) \
vcl \
vclcanvas \
-   $(if $(and $(filter unx,$(GUIBASE)),$(filter-out
MACOSX,$(OS))),vclplug_gen) \
+   $(if $(and $(filter unx,$(GUIBASE)),$(filter-out MACOSX,$(OS))), \
+vclplug_gen \
+$(if $(ENABLE_TDE),vclplug_tde) \
+$(if $(ENABLE_KDE),vclplug_kde) \
+$(if $(ENABLE_KDE4),vclplug_kde4) \
+$(if $(ENABLE_HEADLESS),,vclplug_svp) \
+) \
xmlscript \
xmlfa \
xmlfd \
@@ -404,7 +417,6 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
basebmp \
) \
communi \
-   oox \
ooxml \
sdbc \
avmediaQuickTime \
@@ -413,12 +425,7 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
rptui \
rptxml \
simplecm \
-   spa \
sts \
-   vclplug_tde \
-   vclplug_kde \
-   vclplug_kde4 \
-   vclplug_svp \
 ))

 ifneq (,$(filter ANDROID IOS,$(OS)))
@@ -429,14 +436,6 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \

 endif

-ifeq ($(filter MACOSX WNT,$(OS)),)
-
-$(eval $(call gb_Helper_register_libraries,OOOLIBS, \
-   spl_unx \
-))
-
-endif
-
 $(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE, \
getuid \
smoketest \
@@ -528,6 +527,7 @@ $(eval $(call
gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \
) \
$(if $(filter WNT-TRUE,$(OS)-$(DISABLE_ATL)),,emboleobj) \
package2 \
+   $(if $(and $(filter unx,$(GUIBASE)),$(filter-out
MACOSX,$(OS))),recentfile) \
$(if $(DISABLE_SCRIPTING),,scriptframe) \
sdbc2 \
sofficeapp \
@@ -563,7 +563,6 @@ $(eval $(call
gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \
 $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \
pyuno \
pyuno_wrapper \
-   recentfile \
ucpdav1 \
xsec_xmlsec \
$(if $(filter $(OS),ANDROID), \
diff --git a/scp2/source/ooo/file_library_ooo.scp
b/scp2/source/ooo/file_library_ooo.scp
index d8245c9..10ab3ce 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -244,27 +244,6 @@ End

 #endif

-#if defined(UNX) && ! defined(MACOSX)
-#ifdef ENABLE_TDE
-File gid_File_Lib_Vclplug_Tde
-Name = LIBNAME(vclplug_tde);
-PACKED_LIB_FILE_BODY;
-End
-#endif
-#ifdef ENABLE_KDE
-File gid_File_Lib_Vclplug_Kde
-Name = LIBNAME(vclplug_kde);
-PACKED_LIB_FILE_BODY;
-End
-#endif
-#ifdef ENABLE_KDE4
-File gid_File_Lib_Vclplug_Kde4
-Name = LIBNAME(vclplug_kde4);
-PACKED_LIB_FILE_BODY;
-End
-#endif
-#endif
-
 #if defined(MACOSX)
 File gid_File_Lib_Basebmp
 Name = LIBNAME(basebmp);
@@ -273,36 +252,9

Re: Need for starmath expert

[Marcos Souza]

Hi abdulaziz,

Em 11/14/2013 01:41 PM, abdulaziz escreveu:
> so many thanks Marcos , 
You're welcome :)

> 
> you really help me ...
> 
> I'll let you know if I need help 
> 
> again , Thank you...
I would love to help you guys to port Math to RTL :)
> 
> 
> 
> --
> View this message in context: 
> http://nabble.documentfoundation.org/Need-for-starmath-expert-tp4082485p4083140.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need for starmath expert

[Marcos Souza]

Hi abdulaziz,

Em 11/11/2013 07:11 AM, abdulaziz escreveu:
> Hi all ;
> 
> we have an idea for RTL (arabic) support in Math and we want someone who 
> expert in starmath to answering   the following questions : 
I'm not the expert, but maybe I know somethings that can help you :)

> 
> 1- is it possible to add an arabic mathematical unicode (*nowadays , there
> is no full mathematical  unicode for arabic* )to the module /starmath ?
If I understood it correctly, it seems to be our OLD problem of adding
new symbols to Math. Currently we're using the OpenSymbol to draw the
Math symbols, and OpenSymbol don't have all Math symbols. Maybe we need
to exchange OpenSymbol (and do a LOT of tests on it, because OpenSymbol
is used in bullets too) to STIX fonts... just an idea. This topic is
very old, and we talked about this maybe 4 months ago, or more...

> 
> 2-is it possible to rearrange the formula from Right to Left in both edit
> and formula windows?
I believe yes. There are some parts of Math edit that we disables the
RTL support. Maybe we can add RTL support by changing all pieces of Math
that read/write data to edits... Math is a very small module so maybe
this is not a difficult task.

> 
> 3- what is the good way to add this feature to /starmath module , as an
> extiontion or as optsion in menu ?
As I said above, maybe we can put this as an option.

It's nice to see that others guys are thinking about to improve Math :)

If I could help in this task, please let me know!

Sorry for the late reply...

> 
> 
> *Thanks in advance ...*
> 
> 
> 
> 
> --
> View this message in context: 
> http://nabble.documentfoundation.org/Need-for-starmath-expert-tp4082485.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Thank

[Marcos Souza]

Hi Eike,

Em 11/11/2013 05:16 PM, Eike Rathke escreveu:
> Hi Marcos,
> 
> On Monday, 2013-11-11 08:00:58 -0200, Marcos Souza wrote:
> 
>> So, again, a HUGE THANKS YOU for all you guys that helped me in Germany,
>> and to the guys who invited me to visit them in their houses!
> 
> You're welcome!
> I hope you had a calm / not too stormy flight and the cold didn't catch
> you too badly ... if it did, blame Sweetshark and St. Nikolai ;-)
Yes, our flight was very calm :) I could sleep this time!

And, my flu is under control, so I can't blame St. Nikolai or Bjoern :)
> 
>   Eike
> 
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Thank

[Marcos Souza]

Hi LO people!

I'm here to say a HUGE THANKS YOU about my travel to Germany. It's
awesome when we can link faces and names, to know nice people and work
together in some tasks!

I just want to say a "I'm sorry" if I did less than you expected for
you, but I really enjoyed!

So, I just need to learn more about LO, and in next time I'm planning to
do more and to solve more bugs!

So, again, a HUGE THANKS YOU for all you guys that helped me in Germany,
and to the guys who invited me to visit them in their houses!

Cheers,
Marcos



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: error in unit test

[Marcos Souza]

Now it worked for me...

I don't know why. I pulled this afternoon(in Brazil) and it worked. I
did a make clean and compiled this again.

Thanks a lot for helping me in this issue.

@Cor, can you try this now? Do a pull and try to build again? Maybe do a
make clean.

Em 10/16/2013 07:09 PM, Thorsten Behrens escreveu:
> Cor Nouws wrote:
>> - Sixth pixel is not green
>>
> Interesting - are you per chance running under some reduced color
> depth mode? It is possible that the bitmaps generated are not
> truecolor then.
> 
> Cheers,
> 
> -- Thorsten
> 
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Error in languagetag unittest

[Marcos Souza]

Hi LO guys,

I'm getting this error since last week, I did a lot of pulls and it's
still broken:

/languagetag.cxx:674: LanguageTag::registerOnTheFly: not cross-inserted
0x51 for 'dz' have 'bo'
canvasbitmaptest.cxx:183:Assertion
Test name: (anonymous namespace)::CanvasBitmapTest::runTest
assertion failed
- Expression: pRGBStart[5].Red ==
vcl::unotools::toDoubleColor(aCol.GetRed()) &
& pRGBStart[5].Green == vcl::unotools::toDoubleColor(aCol.GetGreen()) &&
pRGBSt
art[5].Blue == vcl::unotools::toDoubleColor(aCol.GetBlue())
- Sixth pixel is not green

Failures !!!
Run: 2   Failure total: 1   Failures: 1   Errors: 0
warn:legacy.osl:19433:1:unotools/source/config/configmgr.cxx:167:
OSL_ASSERT: items_.empty()

This is a know issue, or maybe my environ is causing this?

Thanks since now!



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Can't access logerrit buildbot logs

[Marcos Souza]

Stephan,

Em 10/07/2013 08:43 AM, Stephan Bergmann escreveu:

Just had the following IRC conversation; can anybody help?

Oct 07 12:33:40  floeff, getting 
 keeps timing out here; 
that sth for you to look at?
Oct 07 13:16:26  sberg: for the machine, imho david is 
responsible - no clue how that thing is set up

Oct 07 13:17:12  is that thingie used in production already?
Oct 07 13:18:41  i just checked our intranet, sberg - reinsle 
is listed as responsible contact for the CI machine
Oct 07 13:19:12  and the IP this points to is on a machine 
labeled as testing, it looks like
Oct 07 13:19:39  reinsle, ^^^ getting 
 keeps timing out here; 
that sth for you to look at?
Oct 07 13:34:51  sberg: i rebooted the vm, but it seems to no 
avail - machine runs, but ci doesn't yield anything, although web 
server on port 80 runs. you need to poke david i think, he set that 
machine up. maybe also reinsle or shm_get have an idea

Oct 07 13:37:06  floeff, ok, thx
Oct 07 13:37:19  sorry i can't be of more help here :-(
Oct 07 13:37:33  it seems to be related to the service 
itself, as load on the machine is just fine
I was trying right now to see that log, thanks for verifying this issue! 
I'm getting timing out here too...

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Code pointer for fdo#67534

[Marcos Souza]

Hi guys,

Can someone give me some tips of bug 
https://bugs.freedesktop.org/show_bug.cgi?id=67534 ?


Thanks since now!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

Hello Michael Stahl,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5631

to look at the new patch set (#5).

Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO
..

fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

Change-Id: Ibb2c27a75d8cbaf5177f392930cc9e6effa48d1d
---
M Repository.mk
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 21 insertions(+), 102 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/5631/5
-- 
To view, visit https://gerrit.libreoffice.org/5631
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb2c27a75d8cbaf5177f392930cc9e6effa48d1d
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

Hello Michael Stahl,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5631

to look at the new patch set (#4).

Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO
..

fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

Change-Id: Ibb2c27a75d8cbaf5177f392930cc9e6effa48d1d
---
M Repository.mk
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 21 insertions(+), 102 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/5631/4
-- 
To view, visit https://gerrit.libreoffice.org/5631
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb2c27a75d8cbaf5177f392930cc9e6effa48d1d
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot, Björn Michaelsen,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5571

to look at the new patch set (#4).

Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO
..

fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
---
M Repository.mk
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 15 insertions(+), 134 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/5571/4
-- 
To view, visit https://gerrit.libreoffice.org/5571
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Björn Michaelsen 
Gerrit-Reviewer: LibreOffice gerrit bot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot, Björn Michaelsen,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5571

to look at the new patch set (#3).

Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO
..

fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
---
M Repository.mk
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 17 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/5571/3
-- 
To view, visit https://gerrit.libreoffice.org/5571
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Björn Michaelsen 
Gerrit-Reviewer: LibreOffice gerrit bot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/5571

to look at the new patch set (#2).

Change subject: fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO
..

fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
---
M Repository.mk
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 17 insertions(+), 145 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/5571/2
-- 
To view, visit https://gerrit.libreoffice.org/5571
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: LibreOffice gerrit bot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Want to get started with libreoffice development

[Marcos Souza]

Hi Sonakshi!

Nice to know that you want to help LO!

So, a nice place to start maybe could be the String -> OUString conversion,
or maybe the chained appends! The're quite  easy, and a nice start point. A
did a lot of patches with this target!

Bug from String -> OUString conversion:
https://bugs.freedesktop.org/show_bug.cgi?id=38838
Bug from chained appends: https://bugs.freedesktop.org/show_bug.cgi?id=57950

Here are some commits about these issues, maybe them can help you to start:
http://cgit.freedesktop.org/libreoffice/core/log/?qt=author&q=Marcos+Paulo+de+Souza&ofs=50

If you have any more question, don't be shy :)

Happy hacking!


2013/6/22 Sonakshi Nathani 

> Hello,
> I really want to contribute for libreoffice. For that I went through
> https://wiki.documentfoundation.org/Development/Easy_Hacks ,but i m
> really confused from where to begin and how to begin. If anyone can help ?
>
>
>
> Regards
> Sonakshi Nathani
> BTECH 2nd year
> CSE - IIIT-HYD
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>


-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fixes fdo#59642

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4314

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/4314/1

Fixes fdo#59642

By making just the one test, the most generic one,  and not nesting strstr 
functions calls.

Change-Id: I1b49e9faea6742594eaa900a87a03c4dd86c0b5c
---
M starmath/source/smdetect.cxx
1 file changed, 1 insertion(+), 2 deletions(-)



diff --git a/starmath/source/smdetect.cxx b/starmath/source/smdetect.cxx
index e6a2ef8..7962f7a 100644
--- a/starmath/source/smdetect.cxx
+++ b/starmath/source/smdetect.cxx
@@ -317,8 +317,7 @@
 sal_Char aBuffer2[200];
 nBytesRead = pStrm->Read( aBuffer2, 
sizeof(aBuffer2) - 1);
 aBuffer2[nBytesRead] = 0;
-if (strstr( aBuffer2, "" ) != NULL ||
-strstr( aBuffer2, "https://gerrit.libreoffice.org/4314
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b49e9faea6742594eaa900a87a03c4dd86c0b5c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove useless attributions in starmath

[Marcos Souza (via Code Review)]

 aToken.nLevel = 5;
 aToken.eType = TNEWLINE;
 aRelationArray[0] = new SmLineNode(aToken);
@@ -2452,8 +2426,6 @@
 {
 SmToken aToken;
 aToken.cMathChar = '\0';
-aToken.nGroup = 0;
-aToken.nLevel = 0;
 aToken.eType = bIsPrescript ? TLSUB : TRSUB;
 
 SmNodeStack aReverseStack;
@@ -2555,7 +2527,6 @@
 SmToken aToken;
 aToken.cMathChar = '\0';
 aToken.nGroup = TRGROUP;
-aToken.nLevel = 0;
 aToken.eType = TMATRIX;
 SmMatrixNode *pSNode = new SmMatrixNode(aToken);
 pSNode->SetSubNodes(aExpressionArray);

-- 
To view, visit https://gerrit.libreoffice.org/4282
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68508f7f7132a2f43b99da3e7cdef9709fd62598
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: still more libs to OOO

[Marcos Souza (via Code Review)]

les = (PACKED, BINARYTABLE, BINARYTABLE_ONLY);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "reg4allmsdoc.dll";
-End
-
-File gid_File_Lib_Qslnkmsi
-LIB_FILE_BODY;
-Styles = (PACKED, BINARYTABLE, BINARYTABLE_ONLY);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "qslnkmsi.dll";
-End
-
-
-File gid_File_Lib_Sdqsmsi
-LIB_FILE_BODY;
-Styles = (PACKED, BINARYTABLE, BINARYTABLE_ONLY);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "sdqsmsi.dll";
-End
-
-#endif /* WNT && HAVE_WINDOWS_SDK */
-
 STD_LIB_FILE( gid_File_Lib_Oox , oox)
-
-#if defined(WNT) && defined(HAVE_WINDOWS_SDK)
-
-File gid_File_Lib_Instooofiltmsi
-LIB_FILE_BODY;
-Styles = (PACKED, BINARYTABLE, BINARYTABLE_ONLY);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "instooofiltmsi.dll";
-End
-
-#endif
 
 #if defined(UNX) && !defined(MACOSX) && !defined(LIBO_HEADLESS)
 
@@ -619,17 +507,6 @@
 #endif
 
 #ifdef WNT
-File gid_File_Lib_LibXMLSec_xmlseccore
-LIB_FILE_BODY;
-#ifdef _gcc3
-  Name = "libxmlsec1.dll";
-#else
-  Name = "libxmlsec.dll";
-#endif
-Dir = SCP2_OOO_BIN_DIR;
-Styles = (PACKED);
-End
-
 #ifdef CROSS_COMPILING
 File gid_File_Lib_LibXMLSec_xmlsecnss
 LIB_FILE_BODY;
@@ -759,14 +636,3 @@
   #endif
 End
 #endif // SYSTEM_REDLAND
-
-#if defined(WNT) && defined(HAVE_WINDOWS_SDK)
-
-File gid_File_Lib_sellangmsi
-LIB_FILE_BODY;
-Styles = (PACKED, BINARYTABLE, BINARYTABLE_ONLY);
-Dir = gid_Brand_Dir_Program;
-Name = "sellangmsi.dll";
-End
-
-#endif
diff --git a/scp2/source/ooo/module_hidden_ooo.scp 
b/scp2/source/ooo/module_hidden_ooo.scp
index 6f5325e..d2e3c43 100644
--- a/scp2/source/ooo/module_hidden_ooo.scp
+++ b/scp2/source/ooo/module_hidden_ooo.scp
@@ -110,7 +110,6 @@
Files = (gid_File_Dat_Root3,
gid_File_Jar_Unoil,
gid_File_Jar_Hsqldb_Sdbc,
-   gid_File_Jar_Accessbridge,
gid_File_Jar_Officebean,
gid_File_Jar_Report,
gid_File_Jar_Smoketest,
@@ -212,24 +211,13 @@
gid_Unixlink_File_Lib_Xslt,
gid_Unixlink_File_Lib_eXslt,
gid_File_Lib_LibXMLSec_xmlsecnss,
-   gid_File_Lib_LibXMLSec_xmlseccore,
gid_File_Lib_LibXMLSec_xmlsecmscrypto,
gid_File_Lib_XSec_XmlSec,
gid_File_Lib_Cmdmail,
gid_File_Lib_I18n,
gid_File_Lib_Accessbridge,
gid_File_Lib_Dl,
-   gid_File_Lib_Dnd,
-   gid_File_Lib_Dtrans,
-   gid_File_Lib_Inprocserv,
-   gid_File_Lib_Fps,
-   gid_File_Lib_Ftransl,
-gid_File_Lib_sn_tools,
 GID_FILE_LIB_WPD,
-   gid_File_Lib_Reg4allmsdoc,
-   gid_File_Lib_Qslnkmsi,
-   gid_File_Lib_Sdqsmsi,
-   gid_File_Lib_Instooofiltmsi,
gid_File_Lib_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Config);

-- 
To view, visit https://gerrit.libreoffice.org/4268
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3a0a740263e92752115665ab5e25c5063b1858a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

doc,
gid_File_Lib_Qslnkmsi,
gid_File_Lib_Sdqsmsi,
gid_File_Lib_Instooofiltmsi,
-   gid_File_Lib_Smplmail,
-   gid_File_Lib_Wininetbe,
-   gid_File_Lib_Macbe,
gid_File_Lib_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Config);

-- 
To view, visit https://gerrit.libreoffice.org/4267
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a3511172ac8ddd060c51c0339a4b9ff16216668
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Marcos Souza (via Code Review)]

ip,
@@ -171,19 +168,12 @@
Default = YES;
Styles = (HIDDEN_ROOT);
Files = (gid_File_Dat_Root5,
-   gid_File_Lib_Dict_Ja,
-   gid_File_Lib_Dict_Zh,
-gid_File_Lib_Collator_Data,
-gid_File_Lib_Index_Data,
-gid_File_Lib_Textconv_Dict,
gid_File_Lib_Crypto,
 #if ! defined SYSTEM_CLUCENE
 gid_File_Lib_CLucene,
 #endif
gid_File_Lib_Curl,
gid_Unixlink_File_Lib_Curl,
-   gid_File_Lib_Dbpool,
-   gid_File_Lib_Embobj,
gid_File_Lib_Emboleobj,
gid_File_Lib_Macab_1,
 gid_File_Lib_Macab_Drv_1,
@@ -197,14 +187,9 @@
gid_File_Lib_Mozbootstrap,
gid_File_Lib_Officebean,
gid_File_Lib_Openssl,
-   gid_File_Lib_DeploymentGui,
gid_File_Lib_Recentfile,
-   gid_File_Lib_Srtrs1,
gid_File_Lib_Tab,
gid_File_Lib_Tab2,
-   gid_File_Lib_Migrationoo2,
-   gid_File_Lib_Migrationoo3,
-   gid_File_Ucptdoc1,
gid_File_Lib_Raptor,
gid_Unixlink_File_Lib_Raptor,
gid_File_Lib_Rasqal,
@@ -224,20 +209,14 @@
gid_File_Lib_Sqlite3,
gid_File_Lib_Ssl3,
gid_File_Lib_Sndfile,
-   gid_File_Lib_Ucpchelp1,
gid_File_Lib_Ucpdav1,
gid_File_Lib_Neon,
-   gid_File_Lib_Ucpftp1,
-   gid_File_Lib_Ucphier1,
-   gid_File_Lib_Ucppkg1,
gid_File_Lib_Xslt,
gid_Unixlink_File_Lib_Xslt,
gid_Unixlink_File_Lib_eXslt,
gid_File_Lib_LibXMLSec_xmlsecnss,
gid_File_Lib_LibXMLSec_xmlseccore,
gid_File_Lib_LibXMLSec_xmlsecmscrypto,
-   gid_File_Lib_XSec_XMLSecurity,
-   gid_File_Lib_XSec_Framework,
gid_File_Lib_XSec_XmlSec,
gid_File_Lib_Cmdmail,
gid_File_Lib_I18n,
@@ -259,7 +238,6 @@
gid_File_Lib_Smplmail,
gid_File_Lib_Wininetbe,
gid_File_Lib_Macbe,
-gid_File_Lib_Updatefeed,
gid_File_Lib_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Config);

-- 
To view, visit https://gerrit.libreoffice.org/4232
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1553317afe8df9877a41b1d4087c96d861ed1377
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: Move some libs to OOO a...

[Marcos Souza (via Code Review)]

d_File_Lib_Slideshow, slideshow )
-
-File gid_File_Lib_Sdbc_2
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(libsdbc2,UNXSUFFIX));
-  #else
-Name = "sdbc2.dll";
-  #endif
-End
 
 #if defined(WNT) && defined(HAVE_WINDOWS_SDK)
 
@@ -769,13 +620,6 @@
 
 #endif
 
-File gid_File_Lib_Spell
-LIB_FILE_BODY;
-Styles = (PACKED);
-Name = LIBNAME(spell);
-Dir = SCP2_OOO_BIN_DIR;
-End
-
 #if defined UNX && !defined MACOSX && !defined LIBO_HEADLESS
 STD_LIB_FILE( gid_File_Lib_Spl_Unx, spl_unx)
 #endif
@@ -791,7 +635,6 @@
 End
 #endif
 
-STD_LIB_FILE( gid_File_Lib_Syssh, syssh )
 
 #ifdef WNT
 STD_LIB_FILE( gid_File_Lib_Wininetbe, wininetbe1 )
@@ -800,19 +643,6 @@
 #ifdef MACOSX
 STD_LIB_FILE( gid_File_Lib_Macbe, macbe1 )
 #endif
-
-STD_LIB_FILE( gid_File_Lib_Acc, acc )
-
-File gid_File_Lib_Tvhlp1
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(libtvhlp1,UNXSUFFIX));
-  #else
-Name = "tvhlp1.dll";
-  #endif
-End
 
 File gid_File_Lib_Ucpchelp1
 LIB_FILE_BODY;
diff --git a/scp2/source/ooo/module_hidden_ooo.scp 
b/scp2/source/ooo/module_hidden_ooo.scp
index d8a0a5f..3fe65c8 100644
--- a/scp2/source/ooo/module_hidden_ooo.scp
+++ b/scp2/source/ooo/module_hidden_ooo.scp
@@ -110,7 +110,6 @@
Styles = (HIDDEN_ROOT);
Files = (gid_File_Dat_Root3,
gid_File_Jar_Unoil,
-   gid_File_Jar_Hsqldb,
gid_File_Jar_Hsqldb_Sdbc,
gid_File_Jar_Accessbridge,
gid_File_Jar_Officebean,
@@ -154,7 +153,6 @@
gid_File_Lib_AVMediaGStreamer,
gid_File_Lib_AVMediaGStreamer_0_10,
gid_File_Lib_Sysdtrans,
-   gid_File_Lib_Acc,
gid_File_Lib_BaseBmp,
gid_File_Lib_Zip,
gid_File_Lib_Vclplug_Tde,
@@ -178,12 +176,7 @@
 gid_File_Lib_Collator_Data,
 gid_File_Lib_Index_Data,
 gid_File_Lib_Textconv_Dict,
-   gid_File_Lib_Basprov,
gid_File_Lib_Crypto,
-   gid_File_Lib_Dlgprov,
-   gid_File_Lib_Stringresource,
-   gid_File_Lib_Ldapbe2,
-   gid_File_Lib_Cached1,
 #if ! defined SYSTEM_CLUCENE
 gid_File_Lib_CLucene,
 #endif
@@ -194,15 +187,10 @@
gid_File_Lib_Emboleobj,
gid_File_Lib_Macab_1,
 gid_File_Lib_Macab_Drv_1,
-   gid_File_Lib_I18nsearch,
gid_File_Lib_Icudata,
gid_File_Lib_Icui18n,
gid_File_Lib_Icule,
gid_File_Lib_Icuuc,
-   gid_File_Lib_Localedata_En,
-   gid_File_Lib_Localedata_Es,
-   gid_File_Lib_Localedata_Euro,
-   gid_File_Lib_Localedata_Others,
gid_File_Lib_Hsqldb_2,
gid_File_Lib_Mork,
gid_File_Lib_Mozabdrv,
@@ -210,18 +198,12 @@
gid_File_Lib_Officebean,
gid_File_Lib_Openssl,
gid_File_Lib_DeploymentGui,
-   gid_File_Lib_Expwrap_Uno,
-   gid_File_Lib_Fastsax_Uno,
-   gid_File_Lib_Slideshow,
gid_File_Lib_Recentfile,
-   gid_File_Lib_Scriptframe,
-   gid_File_Lib_Sdbc_2,
gid_File_Lib_Srtrs1,
gid_File_Lib_Tab,
gid_File_Lib_Tab2,
gid_File_Lib_Migrationoo2,
gid_File_Lib_Migrationoo3,
-   gid_File_Lib_Syssh,
gid_File_Ucptdoc1,
gid_File_Lib_Raptor,
gid_Unixlink_File_Lib_Raptor,
@@ -242,7 +224,6 @@
gid_File_Lib_Sqlite3,
gid_File_Lib_Ssl3,
gid_File_Lib_Sndfile,
-   gid_File_Lib_Tvhlp1,
gid_File_Lib_Ucpchelp1,
gid_File_Lib_Ucpdav1,
gid_File_Lib_Neon,
@@ -278,10 +259,6 @@
gid_File_Lib_Smplmail,
gid_File_Lib_Wininetbe,
gid_File_Lib_Macbe,
-   gid_File_Lib_Fps_Office,
-   gid_File_Lib_Fpicker,
-   gid_File_Lib_Hatchwindowfactory,
-   gid_File_Lib_Passwordcontainer,
 gid_File_Lib_Updatefeed,
gid_File_Lib_Cli_Oootypes_Assembly,
gid_File_Lib_Policy_Cli_Oootypes_Assembly,
diff --git a/scp2/source/writer/module_writer.scp 
b/scp2/source/writer/module_writer.scp
index c141fa1..6ffc167 100644
--- a/scp2/source/writer/module_writer.scp
+++ b/scp2/source/writer/module_writer.scp
@@ -38,7 +38,6 @@
 Files = 
(gid_File_Bin_Cde_Sagenda,gid_File_Bin_Cde_Sfax,gid_File_Bin_Cde_Slabel,
 gid_File_Bin_Cde_Sletter,gid_File_Bin_Cde_Smemo,gid_File_Bin_Cde_Svcard,
 auto_writer_ALL
-gid_File_Lib_Vbaswobj,
 gid_File_Jar_Email, 
 gid_File_Jar_Mail, 
 gid_File_Jar_Activation,

-- 
To view, visit https://gerrit.libreoffice.org/4231
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52ecc75e26f5f1997d3a575682b78fbd673e4591
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add calc module

[Marcos Souza (via Code Review)]

--git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index d6af980..046bae7 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -109,7 +109,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := BASE ONLINEUPDATE GRAPHICFILTER GNOME TDE 
IMPRESS KDE MATH OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := BASE CALC ONLINEUPDATE GRAPHICFILTER GNOME 
TDE IMPRESS KDE MATH OOO URE WRITER
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 
 $$(foreach group,$$(gb_Executable_VALIDGROUPS),$$(eval gb_Executable_$$(group) 
:=))

-- 
To view, visit https://gerrit.libreoffice.org/4225
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89e87f2e107bdb31f19262c83f8e20be9642a4eb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Doubt about OpenSymbol and Math

[Marcos Souza]

Hi Noel,

Em 06/04/2013 06:43 AM, Noel Grandin escreveu:

On 2013-06-04 10:41, Michael Meeks wrote:
>
> On Mon, 2013-06-03 at 19:20 -0300, Marcos Souza wrote:
>> Some after looking at all Math bugs, I saw something interesting:
>> About 30 % of bugs are about Symbols. Someone asking to put new 
symbols,

>> another guys asking about a "Symbol manager" to add new symbols by UI
>> and more.
>
> Sounds interesting.
> Either way - if you'd like to get stuck into adding math symbols, I
> imagine the best thing (for now) is to follow Olivier's lead, and 
(if MS


I think the question that Marcos is asking is a little different.

Math typography is slightly weird in that people like to invent their 
own symbols, and symbols are often very particular to quite a small 
group of mathematicians.
Lots of the more common symbols have local variants that are only used 
within a specific nation, or within a grouping of academic institutions.
So no font is ever going to be able to capture more than the most 
widely used variants of the symbols.


So what I think he wants is the ability to define custom new shapes at 
runtime and add them to some kind of gallery, and to be able to embed 
them into a document.
This can be another improvement(there is a way to do this???) but 
for now, if we can add new symbols to Math, could be in source code, but 
without the pain of fontforge.


So, maybe use some finished fonts, to no need to build our own fonts :)

What do you think Noel?



Disclaimer: http://www.peralex.com/disclaimer.html




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Doubt about OpenSymbol and Math

[Marcos Souza]

Hi Michael,

Em 06/04/2013 05:41 AM, Michael Meeks escreveu:

Hi Marcos,

On Mon, 2013-06-03 at 19:20 -0300, Marcos Souza wrote:

Some after looking at all Math bugs, I saw something interesting:

:-)


About 30 % of bugs are about Symbols. Someone asking to put new symbols,
another guys asking about a "Symbol manager" to add new symbols by UI
and more.

Sounds interesting.


So, I saw this commit of Olivier:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=15f5d766837329baa8deff31e9da33cef87f7a98
adding new symbols...
So, this is a "little unfriendly" way to add new symbols :)

Heh - well, the commit looks horrible, but the .sfd file is edited by a
GUI tool 'fontforge', which makes it not so hard (I hope) to edit them.
But really the commit that added the game-theory symbols is:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cfc84011b3fb609ac78f35666d9aecda4ca34678

Which as you can see is worse ;-) there are code changes needed.

Thanks, now I saw the fontforge and how it works :)



My questions are: How can we manage this, there is another way to add
new symbols? This OpenSymbol is still necessary? Can we change this to
another fonts, like XTIS or another?

Interesting questions; ideally we would add the symbols to OpenSymbol -
and distribute that everywhere so that we know that people have them (I
guess), presumably with mappings - in the horrible VCL mapping table to
turn them into Microsoft symbols in their distributed fonts on
import/export [ if there are equivalents ]:

unotools/source/misc/fontcvt.cxx

Has those tables.

Either way - if you'd like to get stuck into adding math symbols, I
imagine the best thing (for now) is to follow Olivier's lead, and (if MS
font equivalents exist) add the entries to 'fontcvt.cxx' to ensure that
if we export to / import from MS formats on Windows that we get the
right mappings.

Does that make sense ?

HTH,

Michael.
Yeah makes sense! But, there is another way to not make our homebrew 
fonts? It seems to be needed a lot of work just to add a new unicode 
symbol...




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Fix fdo#32062: Math overwrites selected area when new elemen...

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: Fix fdo#32062: Math overwrites selected area when new element
..


Patch Set 1: Abandoned

Forgive this by now

-- 
To view, visit https://gerrit.libreoffice.org/3982
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If1623b5bc1ae5c491d67b4a21c76a08c928b50b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Luboš Luňák 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Ricardo Montania 
Gerrit-Reviewer: Rodolfo Ribeiro Gomes 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Doubt about OpenSymbol and Math

[Marcos Souza]

Rodolfo,

Em 06/03/2013 10:45 PM, Rodolfo escreveu:

Marcos,

IMO first thing to do is to check if the symbol already exists in the
OpenSymbol.
Maybe you just need to create interface stuff

The better commit to learn how to add new symbols is this:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cfc84011b3fb609ac78f35666d9aecda4ca34678
(new symbols in font and how to setup tool/buttons)

Yeah, seems to be a nice example!


About the replacement of OpenSymbol with STIX (not XTIS ;) there were

Sorry, this is XITS(http://typophile.com/node/71171)


a discussion about that a lng time ago:
http://nabble.documentfoundation.org/How-to-add-new-commands-for-Math-td3048280.html

Thanks for the reference :)



For editing/creating a font, try to use FontForge : http://fontforge.org

I hope I helped you.

Yes, you did :)

I never used fontforge, and I need to take a look at this, but don't you 
think that editing OpenSymbol is a little painful? I believe we need 
something more flexible. If we can do this, a new Math can born, with 
more Symbols, maybe have a section with expressions, like Baskara and 
some other things.


Maybe take the ideia of Caolan and make some scripts to test if we the 
matrics are the same in both fonts...?




Regards.


2013/6/3 Marcos Souza :

Hi LO guys,

Some after looking at all Math bugs(I looked at AOO bugs too), I saw
something interesting:

About 30 % of bugs are about Symbols. Someone asking to put new symbols,
another guys asking about a "Symbol manager" to add new symbols by UI and
more.

So, I saw this commit of Olivier:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=15f5d766837329baa8deff31e9da33cef87f7a98
adding new symbols...

So, this is a "little unfriendly" way to add new symbols :)

My questions are: How can we manage this, there is another way to add new
symbols? This OpenSymbol is still necessary? Can we change this to another
fonts, like XTIS or another?

Thanks since now!

(If I said something wrong here please forgive me, I'm trying to help ^^')
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Doubt about OpenSymbol and Math

[Marcos Souza]

Hi LO guys,

Some after looking at all Math bugs(I looked at AOO bugs too), I saw 
something interesting:


About 30 % of bugs are about Symbols. Someone asking to put new symbols, 
another guys asking about a "Symbol manager" to add new symbols by UI 
and more.


So, I saw this commit of Olivier: 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=15f5d766837329baa8deff31e9da33cef87f7a98 
adding new symbols...


So, this is a "little unfriendly" way to add new symbols :)

My questions are: How can we manage this, there is another way to add 
new symbols? This OpenSymbol is still necessary? Can we change this to 
another fonts, like XTIS or another?


Thanks since now!

(If I said something wrong here please forgive me, I'm trying to help ^^')
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Fix fdo#32720: limit buttons doesn't add the sum sign

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: Fix fdo#32720: limit buttons doesn't add the sum sign
..


Patch Set 1: Abandoned

So, leave it as is.

-- 
To view, visit https://gerrit.libreoffice.org/4067
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9086707f14335ea26bb94c36ee0f87e770c9418b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Luboš Luňák 
Gerrit-Reviewer: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#32720: limit buttons doesn't add the sum sign

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4067

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/4067/1

Fix fdo#32720: limit buttons doesn't add the sum sign

Change-Id: I9086707f14335ea26bb94c36ee0f87e770c9418b
---
M starmath/source/commands.src
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/starmath/source/commands.src b/starmath/source/commands.src
index e6a002f..26ece56 100644
--- a/starmath/source/commands.src
+++ b/starmath/source/commands.src
@@ -149,9 +149,9 @@
 String RID_LLLINT_FROMX { Text = "lllint from{}  " ; };
 String RID_LLLINT_TOX   { Text = "lllint to{}  " ; };
 String RID_LLLINT_FROMTOX   { Text = "lllint from{} to{}  " ; };
-String RID_FROMX{ Text = "from{}  " ; };
-String RID_TOX  { Text = "to{}  " ; };
-String RID_FROMXTOY { Text = "from{} to{}  " ; };
+String RID_FROMX{ Text = "sum from{}  " ; };
+String RID_TOX  { Text = "sum to{}  " ; };
+String RID_FROMXTOY { Text = "sum from{} to{}  " ; };
 String RID_ACUTEX   { Text = "acute  " ; };
 String RID_BARX { Text = "bar  " ; };
 String RID_BREVEX   { Text = "breve  " ; };

-- 
To view, visit https://gerrit.libreoffice.org/4067
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9086707f14335ea26bb94c36ee0f87e770c9418b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add math module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4065

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/4065/1

fdo#60924 autoinstall - gbuild/scp2: add math module

Change-Id: I466dd68069576d57740ef34b8f6fcd8f9025c5c8
---
M Repository.mk
A scp2/AutoInstallLibs_math.mk
M scp2/InstallModule_math.mk
M scp2/Module_scp2.mk
M scp2/source/math/file_math.scp
M scp2/source/math/module_math.scp
M solenv/gbuild/Helper.mk
7 files changed, 25 insertions(+), 8 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 723d7a3..2b4a3de 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -252,6 +252,11 @@
 $(if $(ENABLE_KDE4),kde4be1) \
 ))
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,MATH, \
+sm \
+smd \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,OOO, \
avmedia \
$(if $(DISABLE_SCRIPTING),,basctl) \
@@ -419,8 +424,6 @@
 scfilt \
 scui \
 simplecm \
-sm \
-smd \
 solver \
 spa \
 spell \
diff --git a/scp2/AutoInstallLibs_math.mk b/scp2/AutoInstallLibs_math.mk
new file mode 100644
index 000..a7ceda8
--- /dev/null
+++ b/scp2/AutoInstallLibs_math.mk
@@ -0,0 +1,12 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_AutoInstallLibs_AutoInstallLibs,math,MATH,LIBO_LIB_FILE,auto_Math_Lib))
+
+# vim: set noet sw=4 ts=4:
diff --git a/scp2/InstallModule_math.mk b/scp2/InstallModule_math.mk
index 57f5c2d..e25c25e 100644
--- a/scp2/InstallModule_math.mk
+++ b/scp2/InstallModule_math.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/math))
 
+$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/math,math))
+
 $(eval $(call gb_InstallModule_add_templates,scp2/math,\
 scp2/source/templates/module_langpack_math \
 ))
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index f34449f..3178920 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -15,6 +15,7 @@
AutoInstallLibs_tde \
AutoInstallLibs_gnome \
AutoInstallLibs_kde \
+   AutoInstallLibs_math \
AutoInstallLibs_ooo \
AutoInstallLibs_ure \
AutoInstallLibs_writer \
diff --git a/scp2/source/math/file_math.scp b/scp2/source/math/file_math.scp
index 0c016ee..d9ccc96 100644
--- a/scp2/source/math/file_math.scp
+++ b/scp2/source/math/file_math.scp
@@ -27,10 +27,6 @@
 
 #include "macros.inc"
 
-STD_LIB_FILE( gid_File_Lib_Sm , sm)
-
-STD_LIB_FILE( gid_File_Lib_Smd , smd)
-
 STD_RES_FILE( gid_File_Res_Sm, sm )
 
 File gid_File_Share_Registry_Math_Xcd
diff --git a/scp2/source/math/module_math.scp b/scp2/source/math/module_math.scp
index f222441..1626623 100644
--- a/scp2/source/math/module_math.scp
+++ b/scp2/source/math/module_math.scp
@@ -27,6 +27,8 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/math"
+
 Module gid_Module_Prg_Math
 MOD_NAME_DESC ( MODULE_PRG_MATH );
 ParentID = gid_Module_Prg;
@@ -42,7 +44,8 @@
 Minimal = YES;
 Default = YES;
 Styles = (HIDDEN_ROOT);
-Files = 
(gid_File_Lib_Sm,gid_File_Lib_Smd,gid_File_Extra_Urlmore_Math,gid_File_Extra_Urlnew_Math,gid_File_Extra_Urltasks_Math,
+Files = (auto_Math_Lib_ALL
+   
gid_File_Extra_Urlmore_Math,gid_File_Extra_Urlnew_Math,gid_File_Extra_Urltasks_Math,
 gid_File_Share_Registry_Math_Xcd,
 gid_File_Tmp_Userinstall_Math_Inf);
 End
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index 1a1befc..f60ac36 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := ONLINEUPDATE GRAPHICFILTER GNOME TDE KDE OOO 
URE WRITER
+gb_Library_VALIDINSTALLMODULES := ONLINEUPDATE GRAPHICFILTER GNOME TDE KDE 
MATH OOO URE WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/4065
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I466dd68069576d57740ef34b8f6fcd8f9025c5c8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#60924 autoinstall - gbuild/scp2: add math module

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: fdo#60924 autoinstall - gbuild/scp2: add math module
..


Patch Set 1: Abandoned

Will send a new rebased patch

-- 
To view, visit https://gerrit.libreoffice.org/3919
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0ee6ac3fc32356dac6b3cc498d98ab71fdea29ad
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Fridrich Strba 
Gerrit-Reviewer: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#60924: autoinstall onlineupdate libraries

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: fdo#60924: autoinstall onlineupdate libraries
..


Patch Set 1: Abandoned

This change is merged with other commit related to onlineupdate

-- 
To view, visit https://gerrit.libreoffice.org/3878
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9e06d165351161ff144b7605094a3e490d13d5f2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Fridrich Strba 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Matúš Kukan 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove dead log-area

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3992

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/3992/1

Remove dead log-area

The nullcanvas was removed in 1cd9b5d859a6468164b043b0fcaaf49c1907500c

Change-Id: I2d718d1a18bb405e72b198ced548fc7cb885c6d7
---
M include/sal/log-areas.dox
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 90eeecd..6db37e5 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -42,7 +42,6 @@
 
 @li @c canvas
 @li @c canvas.cairo
-@li @c canvas.null
 @li @c canvas.vcl
 
 @section chart2

-- 
To view, visit https://gerrit.libreoffice.org/3992
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d718d1a18bb405e72b198ced548fc7cb885c6d7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#32059: Commands merge with variables

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3983

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/3983/1

Fix fdo#32059: Commands merge with variables

Verify if there is a space before insert a new command to not merge
variables.

Change-Id: Ia5ddb4c4c8233b3779c0ee0c7009e181cfe5d1c3
---
M starmath/source/edit.cxx
1 file changed, 6 insertions(+), 0 deletions(-)



diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index fc88ba7..2c452ca 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -714,6 +714,12 @@
 
 OSL_ENSURE( pEditView, "NULL pointer" );
 OUString aText = SM_RESSTR(nCommand);
+
+// put an space before put a new command
+OUString aTerm(pEditView->GetEditEngine()->GetText());
+if (!aTerm.endsWith(" "))
+aText = " " + aText;
+
 pEditView->InsertText(aText);
 
 if (HasMark(aText))

-- 
To view, visit https://gerrit.libreoffice.org/3983
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5ddb4c4c8233b3779c0ee0c7009e181cfe5d1c3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#32062: Math overwrites selected area when new elemen...

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3982

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3982/1

Fix fdo#32062: Math overwrites selected area when new element

We're appending the new simbol in front of the selected formula.

Change-Id: If1623b5bc1ae5c491d67b4a21c76a08c928b50b6
---
M starmath/source/edit.cxx
1 file changed, 6 insertions(+), 0 deletions(-)



diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index fc88ba7..d6608db 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -714,6 +714,12 @@
 
 OSL_ENSURE( pEditView, "NULL pointer" );
 OUString aText = SM_RESSTR(nCommand);
+
+OUString selected(pEditView->GetSelected());
+// if we have a formula selected, apply the command around the formula
+if (selected.getLength())
+aText = aText.replaceAll("", selected);
+
 pEditView->InsertText(aText);
 
 if (HasMark(aText))

-- 
To view, visit https://gerrit.libreoffice.org/3982
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1623b5bc1ae5c491d67b4a21c76a08c928b50b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add math module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3919

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/3919/1

fdo#60924 autoinstall - gbuild/scp2: add math module

Change-Id: I0ee6ac3fc32356dac6b3cc498d98ab71fdea29ad
---
M Repository.mk
A scp2/AutoInstallLibs_math.scp
M scp2/InstallModule_math.mk
M scp2/Module_scp2.mk
M scp2/source/math/module_math.scp
M solenv/gbuild/Helper.mk
6 files changed, 23 insertions(+), 2 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 3cbed03..e3af12e 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -240,6 +240,9 @@
 $(if $(ENABLE_KDE4),kde4be1) \
 ))
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,MATH, \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,OOO, \
avmedia \
$(if $(DISABLE_SCRIPTING),,basctl) \
diff --git a/scp2/AutoInstallLibs_math.scp b/scp2/AutoInstallLibs_math.scp
new file mode 100644
index 000..a7ceda8
--- /dev/null
+++ b/scp2/AutoInstallLibs_math.scp
@@ -0,0 +1,12 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_AutoInstallLibs_AutoInstallLibs,math,MATH,LIBO_LIB_FILE,auto_Math_Lib))
+
+# vim: set noet sw=4 ts=4:
diff --git a/scp2/InstallModule_math.mk b/scp2/InstallModule_math.mk
index 57f5c2d..e25c25e 100644
--- a/scp2/InstallModule_math.mk
+++ b/scp2/InstallModule_math.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/math))
 
+$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/math,math))
+
 $(eval $(call gb_InstallModule_add_templates,scp2/math,\
 scp2/source/templates/module_langpack_math \
 ))
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index 9dc1cb6..1c7fdec 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -14,6 +14,7 @@
AutoInstallLibs_tde \
AutoInstallLibs_gnome \
AutoInstallLibs_kde \
+   AutoInstallLibs_math \
AutoInstallLibs_ooo \
AutoInstallLibs_ure \
AutoInstallLibs_writer \
diff --git a/scp2/source/math/module_math.scp b/scp2/source/math/module_math.scp
index f222441..a6fcb62 100644
--- a/scp2/source/math/module_math.scp
+++ b/scp2/source/math/module_math.scp
@@ -27,6 +27,8 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/math"
+
 Module gid_Module_Prg_Math
 MOD_NAME_DESC ( MODULE_PRG_MATH );
 ParentID = gid_Module_Prg;
@@ -42,7 +44,8 @@
 Minimal = YES;
 Default = YES;
 Styles = (HIDDEN_ROOT);
-Files = 
(gid_File_Lib_Sm,gid_File_Lib_Smd,gid_File_Extra_Urlmore_Math,gid_File_Extra_Urlnew_Math,gid_File_Extra_Urltasks_Math,
+Files = (auto_Math_Lib_ALL
+   
gid_File_Lib_Sm,gid_File_Lib_Smd,gid_File_Extra_Urlmore_Math,gid_File_Extra_Urlnew_Math,gid_File_Extra_Urltasks_Math,
 gid_File_Share_Registry_Math_Xcd,
 gid_File_Tmp_Userinstall_Math_Inf);
 End
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index aa87379..5ca9b31 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := GRAPHICFILTER GNOME TDE KDE OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := GRAPHICFILTER GNOME TDE KDE MATH OOO URE 
WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/3919
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ee6ac3fc32356dac6b3cc498d98ab71fdea29ad
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Asking about math issue

[Marcos Souza]

Hi guys!

I was looking at this old issue in math. I can reproduce this behavior, and
it maybe be simple to fix:
https://bugs.freedesktop.org/show_bug.cgi?id=32062

So, my idea:
If we have the formula selected, and we insert a new unary operator
operator(+- , -+, ¬, +, -) we will prepend the current formula with the new
unary operator.

Else If we don't have anything selected, just add the unary operator.

Else // if we have text selected
replace the formula with the new operator

What you guys think?

If you agree, I'll ask for code pointers to make this works :)

Thanks since now!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Big ISDigit method and use isAsciiDigit from CharClass

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3888

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3888/1

Big ISDigit method and use isAsciiDigit from CharClass

Also remove the unused function strnccmp.

Change-Id: Ie857dfca1e52b1251f85abfba3cd0e12e509974f
---
M starmath/source/parse.cxx
1 file changed, 3 insertions(+), 17 deletions(-)



diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 04278e1..9ae5dff 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -50,12 +50,6 @@
 }
 }
 
-static inline bool strnccmp(const String &u1, xub_StrLen nIdx,
-  const sal_Char *s2, xub_StrLen nLen)
-{
-return u1.EqualsIgnoreCaseAscii( s2, nIdx, nLen );
-}
-
 static const sal_Unicode aDelimiterTable[] =
 {
 ' ','\t',   '\n',   '\r',   '+','-','*','/','=',
'#',
@@ -63,14 +57,6 @@
 ')','{','}','[',']','^','_',
 '\0'// end of list symbol
 };
-
-
-static inline bool IsDigit( sal_Unicode cChar )
-{
-return '0' <= cChar && cChar <= '9';
-}
-
-///
 
 SmToken::SmToken() :
 eType   (TUNKNOWN),
@@ -432,7 +418,7 @@
 // #i45779# parse numbers correctly
 // i.e. independent from the locale setting.
 // (note that #i11752# remains fixed)
-if ((aRes.TokenType & KParseType::IDENTNAME) && IsDigit( cFirstChar ))
+if ((aRes.TokenType & KParseType::IDENTNAME) && 
CharClass::isAsciiDigit( cFirstChar ))
 {
 ParseResult aTmpRes;
 LanguageTag aOldLoc( aCC.getLanguageTag() );
@@ -928,7 +914,7 @@
 {
 cChar = m_aBufferString.GetChar( ++m_nBufferIndex 
);
 }
-while ( cChar == '.' || IsDigit( cChar ) );
+while ( cChar == '.' || CharClass::isAsciiDigit( cChar 
) );
 
 m_aCurToken.aText = m_aBufferString.Copy( 
sal::static_int_cast< xub_StrLen >(nTxtStart),
 
sal::static_int_cast< xub_StrLen >(m_nBufferIndex - nTxtStart) );
@@ -1915,7 +1901,7 @@
 else
 bPoint = true;
 }
-else if ( !IsDigit( cChar ) )
+else if ( !CharClass::isAsciiDigit( cChar ) )
 return false;
 }
 return true;

-- 
To view, visit https://gerrit.libreoffice.org/3888
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie857dfca1e52b1251f85abfba3cd0e12e509974f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: autoinstall onlineupdate libraries

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3878

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/3878/1

fdo#60924: autoinstall onlineupdate libraries

Change-Id: I9e06d165351161ff144b7605094a3e490d13d5f2
---
M Repository.mk
M scp2/InstallModule_onlineupdate.mk
M scp2/source/onlineupdate/file_onlineupdate.scp
M scp2/source/onlineupdate/module_onlineupdate.scp
4 files changed, 2 insertions(+), 28 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index f419beb..e9e9480 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -233,6 +233,8 @@
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ONLINEUPDATE, \
+updatecheckui \
+updchk \
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,GNOME, \
@@ -419,7 +421,6 @@
 spell \
 sts \
 textfd \
-updatecheckui \
 $(if $(DISABLE_SCRIPTING),,vbahelper) \
 vclplug_gtk \
 vclplug_gtk3 \
@@ -554,7 +555,6 @@
 ucphier1 \
 ucppkg1 \
 unopkgapp \
-updchk \
 xmlsecurity \
 xsec_fw \
 xsec_xmlsec \
diff --git a/scp2/InstallModule_onlineupdate.mk 
b/scp2/InstallModule_onlineupdate.mk
index fa9fe75..feb6e1b 100644
--- a/scp2/InstallModule_onlineupdate.mk
+++ b/scp2/InstallModule_onlineupdate.mk
@@ -11,10 +11,6 @@
 
 $(eval $(call 
gb_InstallModule_InstallModule_use_auto_install_libs,scp2/onlineupdate,onlineupdate))
 
-$(eval $(call gb_InstallModule_add_scpfiles,scp2/onlineupdate,\
-scp2/source/onlineupdate/file_onlineupdate \
-))
-
 $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/onlineupdate,\
 scp2/source/onlineupdate/module_onlineupdate \
 ))
diff --git a/scp2/source/onlineupdate/file_onlineupdate.scp 
b/scp2/source/onlineupdate/file_onlineupdate.scp
index 023097f..f157ac2 100644
--- a/scp2/source/onlineupdate/file_onlineupdate.scp
+++ b/scp2/source/onlineupdate/file_onlineupdate.scp
@@ -27,16 +27,6 @@
 
 #include "macros.inc"
 
-File gid_File_Lib_Updchk
-BIN_FILE_BODY;
-Styles = (PACKED);
-Dir = gid_Brand_Dir_Program;
-Name = SPECIAL_NAME(updchk);
-ComponentCondition="ISCHECKFORPRODUCTUPDATES=1";
-End
-
-STD_LIB_FILE(gid_File_Lib_Updchkui, updatecheckui)
-
 File gid_File_Share_Registry_Onlineupdate_Xcd
 TXT_FILE_BODY;
 Styles = (PACKED);
@@ -44,12 +34,3 @@
 Name = "onlineupdate.xcd";
 ComponentCondition="ISCHECKFORPRODUCTUPDATES=1";
 End
-
-#if defined LINUX || defined SOLARIS
-File gid_File_Bin_UnpackUpdate
-BIN_FILE_BODY;
-Dir = gid_Brand_Dir_Program;
-Name = "unpack_update";
-Styles = (PACKED);
-End
-#endif
diff --git a/scp2/source/onlineupdate/module_onlineupdate.scp 
b/scp2/source/onlineupdate/module_onlineupdate.scp
index 586edfe..ce19716 100644
--- a/scp2/source/onlineupdate/module_onlineupdate.scp
+++ b/scp2/source/onlineupdate/module_onlineupdate.scp
@@ -37,8 +37,5 @@
 Default = YES;
 Styles = ();
 Files = (auto_Onlineupdate_lib_ALL
- gid_File_Bin_UnpackUpdate,
- gid_File_Lib_Updchk,
- gid_File_Lib_Updchkui,
  gid_File_Share_Registry_Onlineupdate_Xcd);
 End

-- 
To view, visit https://gerrit.libreoffice.org/3878
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e06d165351161ff144b7605094a3e490d13d5f2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3877

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3877/1

fdo#60924 autoinstall - gbuild/scp2: add onlineupdate module

Change-Id: Ib541799e5bd8c95878d61dadbad2bcca80d44367
---
M Repository.mk
M scp2/InstallModule_onlineupdate.mk
M scp2/Module_scp2.mk
M scp2/source/onlineupdate/module_onlineupdate.scp
M solenv/gbuild/Helper.mk
5 files changed, 11 insertions(+), 2 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 3cbed03..f419beb 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -232,6 +232,9 @@
 $(if $(ENABLE_TDE),tdebe1) \
 ))
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ONLINEUPDATE, \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,GNOME, \
 ))
 
diff --git a/scp2/InstallModule_onlineupdate.mk 
b/scp2/InstallModule_onlineupdate.mk
index 76b1b78..fa9fe75 100644
--- a/scp2/InstallModule_onlineupdate.mk
+++ b/scp2/InstallModule_onlineupdate.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/onlineupdate))
 
+$(eval $(call 
gb_InstallModule_InstallModule_use_auto_install_libs,scp2/onlineupdate,onlineupdate))
+
 $(eval $(call gb_InstallModule_add_scpfiles,scp2/onlineupdate,\
 scp2/source/onlineupdate/file_onlineupdate \
 ))
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index 5bccae0..4c1880b 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -10,6 +10,7 @@
 $(eval $(call gb_Module_Module,scp2))
 
 $(eval $(call gb_Module_add_targets,scp2,\
+   AutoInstallLibs_onlineupdate \
AutoInstallLibs_graphicfilter \
AutoInstallLibs_tde \
AutoInstallLibs_gnome \
diff --git a/scp2/source/onlineupdate/module_onlineupdate.scp 
b/scp2/source/onlineupdate/module_onlineupdate.scp
index 29da635..586edfe 100644
--- a/scp2/source/onlineupdate/module_onlineupdate.scp
+++ b/scp2/source/onlineupdate/module_onlineupdate.scp
@@ -27,6 +27,8 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/onlineupdate"
+
 Module gid_Module_Optional_Onlineupdate
 PackageInfo = "packinfo_office.txt";
 MOD_NAME_DESC(MODULE_OPT_ONLINEUPDATE);
@@ -34,7 +36,8 @@
 ParentID = gid_Module_Optional;
 Default = YES;
 Styles = ();
-Files = (gid_File_Bin_UnpackUpdate,
+Files = (auto_Onlineupdate_lib_ALL
+ gid_File_Bin_UnpackUpdate,
  gid_File_Lib_Updchk,
  gid_File_Lib_Updchkui,
  gid_File_Share_Registry_Onlineupdate_Xcd);
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index aa87379..1a1befc 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := GRAPHICFILTER GNOME TDE KDE OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := ONLINEUPDATE GRAPHICFILTER GNOME TDE KDE OOO 
URE WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/3877
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib541799e5bd8c95878d61dadbad2bcca80d44367
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: autoinstall graphicfilter libraries

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3829

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/3829/1

fdo#60924: autoinstall graphicfilter libraries

Change-Id: I406ecef9bc1865d0cd17e3428bff137d972f
---
M Repository.mk
M scp2/InstallModule_graphicfilter.mk
D scp2/source/graphicfilter/file_graphicfilter.scp
M scp2/source/graphicfilter/module_graphicfilter.scp
4 files changed, 4 insertions(+), 56 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index fc6e737..3cbed03 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -222,6 +222,10 @@
 endif
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,GRAPHICFILTER, \
+svgfilter \
+flash \
+wpftdraw \
+graphicfilter \
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,TDE, \
@@ -388,8 +392,6 @@
 dbu \
 evoab \
filtertracer \
-   flash \
-graphicfilter \
 log \
MacOSXSpell \
 mork \
@@ -413,7 +415,6 @@
 spa \
 spell \
 sts \
-svgfilter \
 textfd \
 updatecheckui \
 $(if $(DISABLE_SCRIPTING),,vbahelper) \
@@ -423,7 +424,6 @@
 vclplug_kde \
 vclplug_kde4 \
 vclplug_svp \
-wpftdraw \
 ))
 
 ifneq (,$(filter ANDROID IOS,$(OS)))
diff --git a/scp2/InstallModule_graphicfilter.mk 
b/scp2/InstallModule_graphicfilter.mk
index 1858d93..f166e25 100644
--- a/scp2/InstallModule_graphicfilter.mk
+++ b/scp2/InstallModule_graphicfilter.mk
@@ -11,10 +11,6 @@
 
 $(eval $(call 
gb_InstallModule_use_auto_install_libs,scp2/graphicfilter,graphicfilter))
 
-$(eval $(call gb_InstallModule_add_scpfiles,scp2/graphicfilter,\
-scp2/source/graphicfilter/file_graphicfilter \
-))
-
 $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/graphicfilter,\
 scp2/source/graphicfilter/module_graphicfilter \
 ))
diff --git a/scp2/source/graphicfilter/file_graphicfilter.scp 
b/scp2/source/graphicfilter/file_graphicfilter.scp
deleted file mode 100644
index 535688d..000
--- a/scp2/source/graphicfilter/file_graphicfilter.scp
+++ /dev/null
@@ -1,44 +0,0 @@
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org.  If not, see
- * <http://www.openoffice.org/license.html>
- * for a copy of the LGPLv3 License.
- *
- /
-
-#include "macros.inc"
-
-File gid_File_Share_Registry_Graphicfilter_Xcd
-TXT_FILE_BODY;
-Styles = (PACKED);
-Dir = gid_Brand_Dir_Share_Registry;
-Name = "graphicfilter.xcd";
-End
-
-STD_LIB_FILE( gid_File_Lib_Flash, flash )
-STD_RES_FILE( gid_File_Res_Flash, flash )
-
-STD_LIB_FILE( gid_File_Lib_Svg, svgfilter )
-
-STD_LIB_FILE( gid_File_Lib_Graphic, graphicfilter )
-
-STD_LIB_FILE( gid_File_Lib_WpftDraw, wpftdraw )
diff --git a/scp2/source/graphicfilter/module_graphicfilter.scp 
b/scp2/source/graphicfilter/module_graphicfilter.scp
index bd148a8..9ebfcc2 100644
--- a/scp2/source/graphicfilter/module_graphicfilter.scp
+++ b/scp2/source/graphicfilter/module_graphicfilter.scp
@@ -36,9 +36,5 @@
 ParentID = gid_Module_Optional;
 Default = YES;
 Files = (auto_Graphicfilter_Lib_ALL
-gid_File_Lib_Svg,
-gid_File_Lib_Flash,
-gid_File_Lib_WpftDraw,
-gid_File_Lib_Graphic,
 gid_File_Share_Registry_Graphicfilter_Xcd);
 End

-- 
To view, visit https://gerrit.libreoffice.org/3829
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I406ecef9bc1865d0cd17e3428bff137d972f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add graphicfilter modul...

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3827

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/3827/1

fdo#60924 autoinstall - gbuild/scp2: add graphicfilter module

Change-Id: I7823b4f0d8b7ab99ef549361a89f12036bf63270
---
M Repository.mk
A scp2/AutoInstallLibs_graphicfilter.mk
M scp2/InstallModule_graphicfilter.mk
M scp2/Module_scp2.mk
M scp2/source/graphicfilter/module_graphicfilter.scp
M solenv/gbuild/Helper.mk
6 files changed, 22 insertions(+), 2 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 7e6c051..fc6e737 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -221,6 +221,9 @@
 
 endif
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,GRAPHICFILTER, \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,TDE, \
 $(if $(ENABLE_TDE),tdebe1) \
 ))
diff --git a/scp2/AutoInstallLibs_graphicfilter.mk 
b/scp2/AutoInstallLibs_graphicfilter.mk
new file mode 100644
index 000..08efa78
--- /dev/null
+++ b/scp2/AutoInstallLibs_graphicfilter.mk
@@ -0,0 +1,12 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_AutoInstallLibs_AutoInstallLibs,graphicfilter,GRAPHICFILTER,LIBO_LIB_FILE,auto_Graphicfilter_Lib))
+
+# vim: set noet sw=4 ts=4:
diff --git a/scp2/InstallModule_graphicfilter.mk 
b/scp2/InstallModule_graphicfilter.mk
index b7f2a8c..1858d93 100644
--- a/scp2/InstallModule_graphicfilter.mk
+++ b/scp2/InstallModule_graphicfilter.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/graphicfilter))
 
+$(eval $(call 
gb_InstallModule_use_auto_install_libs,scp2/graphicfilter,graphicfilter))
+
 $(eval $(call gb_InstallModule_add_scpfiles,scp2/graphicfilter,\
 scp2/source/graphicfilter/file_graphicfilter \
 ))
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index 67e8a81..5bccae0 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -10,6 +10,7 @@
 $(eval $(call gb_Module_Module,scp2))
 
 $(eval $(call gb_Module_add_targets,scp2,\
+   AutoInstallLibs_graphicfilter \
AutoInstallLibs_tde \
AutoInstallLibs_gnome \
AutoInstallLibs_kde \
diff --git a/scp2/source/graphicfilter/module_graphicfilter.scp 
b/scp2/source/graphicfilter/module_graphicfilter.scp
index cd7e4a6..bd148a8 100644
--- a/scp2/source/graphicfilter/module_graphicfilter.scp
+++ b/scp2/source/graphicfilter/module_graphicfilter.scp
@@ -27,13 +27,15 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/graphicfilter"
+
 Module gid_Module_Optional_Grfflt
 PackageInfo = "packinfo_office.txt";
 MOD_NAME_DESC ( MODULE_OPTIONAL_GRFFLT );
 Sortkey = "600";
 ParentID = gid_Module_Optional;
 Default = YES;
-Files = (
+Files = (auto_Graphicfilter_Lib_ALL
 gid_File_Lib_Svg,
 gid_File_Lib_Flash,
 gid_File_Lib_WpftDraw,
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index 168cdf7..aa87379 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := GNOME TDE KDE OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := GRAPHICFILTER GNOME TDE KDE OOO URE WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/3827
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7823b4f0d8b7ab99ef549361a89f12036bf63270
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add gnome module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3812

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3812/1

fdo#60924 autoinstall - gbuild/scp2: add gnome module

Change-Id: I37570787815d85d30eed3b5291e1e4450e5ffd51
---
M Repository.mk
A scp2/AutoInstallLibs_gnome.mk
M scp2/InstallModule_gnome.mk
M scp2/Module_scp2.mk
M scp2/source/gnome/module_gnome.scp
M solenv/gbuild/Helper.mk
6 files changed, 22 insertions(+), 2 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index e04e7ec..9b8b3a4 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -221,6 +221,9 @@
 
 endif
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,GNOME, \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,KDE, \
 $(if $(ENABLE_KDE),kdebe1) \
 $(if $(ENABLE_KDE4),kde4be1) \
diff --git a/scp2/AutoInstallLibs_gnome.mk b/scp2/AutoInstallLibs_gnome.mk
new file mode 100644
index 000..c388a29
--- /dev/null
+++ b/scp2/AutoInstallLibs_gnome.mk
@@ -0,0 +1,12 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_AutoInstallLibs_AutoInstallLibs,gnome,GNOME,LIBO_LIB_FILE,auto_Gnome_Lib))
+
+# vim: set noet sw=4 ts=4:
diff --git a/scp2/InstallModule_gnome.mk b/scp2/InstallModule_gnome.mk
index 816f3b2..3a8dd51 100644
--- a/scp2/InstallModule_gnome.mk
+++ b/scp2/InstallModule_gnome.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/gnome))
 
+$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/gnome,gnome))
+
 $(eval $(call gb_InstallModule_define_if_set,scp2/gnome,\
ENABLE_EVOAB2 \
ENABLE_GCONF \
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index 4173445..ca236c1 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -10,6 +10,7 @@
 $(eval $(call gb_Module_Module,scp2))
 
 $(eval $(call gb_Module_add_targets,scp2,\
+   AutoInstallLibs_gnome \
AutoInstallLibs_kde \
AutoInstallLibs_ooo \
AutoInstallLibs_ure \
diff --git a/scp2/source/gnome/module_gnome.scp 
b/scp2/source/gnome/module_gnome.scp
index 3a2604d..b496ced 100644
--- a/scp2/source/gnome/module_gnome.scp
+++ b/scp2/source/gnome/module_gnome.scp
@@ -27,6 +27,8 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/gnome"
+
 Module gid_Module_Optional_Gnome
 ParentID = gid_Module_Optional;
 Default = YES;
@@ -36,7 +38,7 @@
 #ifdef ENABLE_GNOMEVFS
 XpdCheckSolaris = "SUNWgnome-vfs";
 #endif
-Files = (
+Files = (auto_Gnome_lib_ALL
 #ifdef ENABLE_EVOAB2
   gid_File_Lib_Evoab,
 #endif
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index ded46b9..b67c1f7 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := KDE OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := GNOME KDE OOO URE WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/3812
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37570787815d85d30eed3b5291e1e4450e5ffd51
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: autoinstall gnome libraries

[Marcos Souza (via Code Review)]

   gid_File_Lib_Vclplug_Gtk,
-#endif
-#ifdef ENABLE_GTK3
-  gid_File_Lib_Vclplug_Gtk3,
-#endif
-#ifdef ENABLE_SYSTRAY_GTK
-  gid_File_Lib_QStart_Gtk,
 #endif
 #ifdef ENABLE_GNOMEVFS
   gid_File_Lib_Gnomevfs, gid_File_Bin_Gnome_Set_Default_Application,
 #endif
 #ifdef ENABLE_GIO
   gid_File_Lib_GIO,
-  gid_File_Lib_Losessioninstall,
-#endif
-#ifdef ENABLE_GCONF
-  gid_File_Lib_Gconfbe,
 #endif
 #if (defined ENABLE_GNOMEVFS && defined ENABLE_LOCKDOWN) || defined ENABLE_GIO
   gid_File_Share_Registry_Gnome_Xcd,

-- 
To view, visit https://gerrit.libreoffice.org/3813
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fd872d15a0c938d32aac185c3c00c5fb14a091a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: autoinstall tde libraries

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3809

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3809/1

fdo#60924: autoinstall tde libraries

Change-Id: Id986bc7f9f09902dfda849bc86f9c48ccb0f30c3
---
M Repository.mk
M scp2/InstallModule_tde.mk
D scp2/source/tde/file_tde.scp
M scp2/source/tde/module_tde.scp
4 files changed, 1 insertion(+), 43 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 18ce81b..a68ed5f 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -222,6 +222,7 @@
 endif
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,TDE, \
+$(if $(ENABLE_TDE),tdebe1) \
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,KDE, \
@@ -627,7 +628,6 @@
 slideshow \
 stringresource \
 syssh \
-tdebe1 \
 ucpcmis1 \
 ucpext \
 ucpgio1 \
diff --git a/scp2/InstallModule_tde.mk b/scp2/InstallModule_tde.mk
index ad7655e..0e5dae6 100644
--- a/scp2/InstallModule_tde.mk
+++ b/scp2/InstallModule_tde.mk
@@ -11,15 +11,6 @@
 
 $(eval $(call gb_InstallModule_use_auto_install_libs,scp2/tde,tde))
 
-$(eval $(call gb_InstallModule_define_if_set,scp2/tde,\
-   ENABLE_TDE \
-   ENABLE_TDEAB \
-))
-
-$(eval $(call gb_InstallModule_add_scpfiles,scp2/tde,\
-scp2/source/tde/file_tde \
-))
-
 $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/tde,\
 scp2/source/tde/module_tde \
 ))
diff --git a/scp2/source/tde/file_tde.scp b/scp2/source/tde/file_tde.scp
deleted file mode 100644
index 945b0de..000
--- a/scp2/source/tde/file_tde.scp
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * Version: MPL 1.1 / GPLv3+ / LGPLv3+
- *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the specific language governing rights and limitations under the
- * License.
- *
- * The Initial Developer of the Original Code is
- * Timothy Pearson  (C) 2012, All Rights Reserved.
- *
- * Alternatively, the contents of this file may be used under the terms of
- * either the GNU General Public License Version 3 or later (the "GPLv3+"), or
- * the GNU Lesser General Public License Version 3 or later (the "LGPLv3+"),
- * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
- * instead of those above.
- *
- /
-#include "macros.inc"
-
-#ifdef ENABLE_TDE
-STD_LIB_FILE( gid_File_Lib_Tdebe, tdebe1 )
-#endif
diff --git a/scp2/source/tde/module_tde.scp b/scp2/source/tde/module_tde.scp
index 2cadd97..d3ff16b 100644
--- a/scp2/source/tde/module_tde.scp
+++ b/scp2/source/tde/module_tde.scp
@@ -26,7 +26,6 @@
 
 #include "AutoInstallLibs/tde"
 
-#if defined( ENABLE_TDE )
 Module gid_Module_Optional_Tde
 ParentID = gid_Module_Optional;
 Default = YES;
@@ -34,10 +33,6 @@
 MOD_NAME_DESC(MODULE_OPTIONAL_TDE);
 Styles = ();
 Files = (auto_Tde_Lib_ALL
-#ifdef ENABLE_TDE
-gid_File_Lib_Tdebe
-#endif // ENABLE_TDE
 );
 End
-#endif
 

-- 
To view, visit https://gerrit.libreoffice.org/3809
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id986bc7f9f09902dfda849bc86f9c48ccb0f30c3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924 autoinstall - gbuild/scp2: add tde module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3808

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3808/1

fdo#60924 autoinstall - gbuild/scp2: add tde module

Change-Id: I4c13d1cd4b7490a0b4db8f0dd40d823a5906c8aa
---
M Repository.mk
A scp2/AutoInstallLibs_tde.mk
M scp2/InstallModule_tde.mk
M scp2/Module_scp2.mk
M scp2/source/tde/module_tde.scp
M solenv/gbuild/Helper.mk
6 files changed, 22 insertions(+), 2 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index e04e7ec..18ce81b 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -221,6 +221,9 @@
 
 endif
 
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,TDE, \
+))
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,KDE, \
 $(if $(ENABLE_KDE),kdebe1) \
 $(if $(ENABLE_KDE4),kde4be1) \
diff --git a/scp2/AutoInstallLibs_tde.mk b/scp2/AutoInstallLibs_tde.mk
new file mode 100644
index 000..daea3c3
--- /dev/null
+++ b/scp2/AutoInstallLibs_tde.mk
@@ -0,0 +1,12 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_AutoInstallLibs_AutoInstallLibs,tde,TDE,LIBO_LIB_FILE,auto_Tde_Lib))
+
+# vim: set noet sw=4 ts=4:
diff --git a/scp2/InstallModule_tde.mk b/scp2/InstallModule_tde.mk
index f42ef03..ad7655e 100644
--- a/scp2/InstallModule_tde.mk
+++ b/scp2/InstallModule_tde.mk
@@ -9,6 +9,8 @@
 
 $(eval $(call gb_InstallModule_InstallModule,scp2/tde))
 
+$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/tde,tde))
+
 $(eval $(call gb_InstallModule_define_if_set,scp2/tde,\
ENABLE_TDE \
ENABLE_TDEAB \
diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk
index 4173445..b5bb1f0 100644
--- a/scp2/Module_scp2.mk
+++ b/scp2/Module_scp2.mk
@@ -10,6 +10,7 @@
 $(eval $(call gb_Module_Module,scp2))
 
 $(eval $(call gb_Module_add_targets,scp2,\
+   AutoInstallLibs_tde \
AutoInstallLibs_kde \
AutoInstallLibs_ooo \
AutoInstallLibs_ure \
diff --git a/scp2/source/tde/module_tde.scp b/scp2/source/tde/module_tde.scp
index e302c54..2cadd97 100644
--- a/scp2/source/tde/module_tde.scp
+++ b/scp2/source/tde/module_tde.scp
@@ -24,6 +24,8 @@
 
 #include "macros.inc"
 
+#include "AutoInstallLibs/tde"
+
 #if defined( ENABLE_TDE )
 Module gid_Module_Optional_Tde
 ParentID = gid_Module_Optional;
@@ -31,7 +33,7 @@
 PackageInfo = "packinfo_office.txt";
 MOD_NAME_DESC(MODULE_OPTIONAL_TDE);
 Styles = ();
-Files = (
+Files = (auto_Tde_Lib_ALL
 #ifdef ENABLE_TDE
 gid_File_Lib_Tdebe
 #endif // ENABLE_TDE
diff --git a/solenv/gbuild/Helper.mk b/solenv/gbuild/Helper.mk
index ded46b9..fd395f7 100644
--- a/solenv/gbuild/Helper.mk
+++ b/solenv/gbuild/Helper.mk
@@ -118,7 +118,7 @@
 define gb_Helper_init_registries
 gb_Executable_VALIDGROUPS := UREBIN SDK OOO NONE
 gb_Library_VALIDGROUPS := OOOLIBS PLAINLIBS_NONE PLAINLIBS_URE PLAINLIBS_OOO 
RTVERLIBS UNOLIBS_URE UNOVERLIBS EXTENSIONLIBS
-gb_Library_VALIDINSTALLMODULES := KDE OOO URE WRITER
+gb_Library_VALIDINSTALLMODULES := TDE KDE OOO URE WRITER
 gb_StaticLibrary_VALIDGROUPS := PLAINLIBS
 gb_Jar_VALIDGROUPS := URE OOO OXT NONE
 

-- 
To view, visit https://gerrit.libreoffice.org/3808
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c13d1cd4b7490a0b4db8f0dd40d823a5906c8aa
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: Move some more libs to autoinstallation

[Marcos Souza (via Code Review)]

bj,
-   gid_File_Lib_Tdeab_1,
-gid_File_Lib_Tdeab_Drv_1,
-   gid_File_Lib_Kab_1,
-gid_File_Lib_Kab_Drv_1,
gid_File_Lib_Macab_1,
 gid_File_Lib_Macab_Drv_1,
gid_File_Lib_I18nsearch,
@@ -225,7 +217,6 @@
gid_File_Lib_Localedata_Euro,
gid_File_Lib_Localedata_Others,
gid_File_Lib_Hsqldb_2,
-   gid_File_Lib_Jdbc,
gid_File_Lib_Mork,
gid_File_Lib_Mozabdrv,
gid_File_Lib_Mozbootstrap,

-- 
To view, visit https://gerrit.libreoffice.org/3758
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7383da4390995ad9ea2d4fb494098dab6287609f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Remove _CL and _LF from solar.h

[Marcos Souza (via Code Review)]

;GetLen() );
-DBG_ASSERT( aLine.Search( _CR ) == STRING_NOTFOUND, "ImplGetTextLines 
- Found CR!" );
-DBG_ASSERT( aLine.Search( _LF ) == STRING_NOTFOUND, "ImplGetTextLines 
- Found LF!" );
+DBG_ASSERT( aLine.Search( RTL_CHAR_CR ) == STRING_NOTFOUND, 
"ImplGetTextLines - Found CR!" );
+DBG_ASSERT( aLine.Search( RTL_CHAR_LF ) == STRING_NOTFOUND, 
"ImplGetTextLines - Found LF!" );
 }
 #endif
 
@@ -6253,7 +6253,7 @@
 xub_StrLen nLastLineLen = aLastLine.Len();
 for ( i = 0; i < nLastLineLen; i++ )
 {
-if ( aLastLine.GetChar( i ) == _LF )
+if ( aLastLine.GetChar( i ) == RTL_CHAR_LF )
 aLastLine.SetChar( i, ' ' );
 }
 aLastLine = ImplGetEllipsisString( rTargetDevice, 
aLastLine, nWidth, nStyle, _rLayout );
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 6eefa3c..dcd9af9 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8134,7 +8134,7 @@
 pLineInfo = aMultiLineInfo.GetLine( nFormatLines );
 aLastLine = 
convertLineEnd(aStr.Copy(pLineInfo->GetIndex()), LINEEND_LF);
 // replace line feed by space
-aLastLine = aLastLine.replace(_LF, ' ');
+aLastLine = aLastLine.replace(RTL_CHAR_LF, ' ');
 aLastLine = m_pReferenceDevice->GetEllipsisString( 
aLastLine, nWidth, nStyle );
 nStyle &= ~(TEXT_DRAW_VCENTER | TEXT_DRAW_BOTTOM);
 nStyle |= TEXT_DRAW_TOP;
diff --git a/vcl/source/window/status.cxx b/vcl/source/window/status.cxx
index cb82af6..e900d96 100644
--- a/vcl/source/window/status.cxx
+++ b/vcl/source/window/status.cxx
@@ -364,7 +364,7 @@
 {
 // Position ermitteln
 XubString aStr = GetText();
-sal_uInt16 nPos = aStr.Search( _LF );
+sal_uInt16 nPos = aStr.Search( RTL_CHAR_LF );
 if ( nPos != STRING_NOTFOUND )
 aStr.Erase( nPos );
 

-- 
To view, visit https://gerrit.libreoffice.org/3740
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05b0325006845e48eb5483485a9042aa7b0cd22a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: Move more libs to autoinstallation

[Marcos Souza (via Code Review)]

 )
-STD_LIB_FILE( gid_File_Lib_Xmlfd, xmlfd )
 STD_LIB_FILE( gid_File_Lib_Textfd, textfd )
-STD_LIB_FILE( gid_File_Lib_Odfflatxml, odfflatxml )
 
 #ifndef SYSTEM_LIBXSLT
 File gid_File_Lib_Xslt
diff --git a/scp2/source/ooo/module_hidden_ooo.scp 
b/scp2/source/ooo/module_hidden_ooo.scp
index 43ddeef..a00355f 100644
--- a/scp2/source/ooo/module_hidden_ooo.scp
+++ b/scp2/source/ooo/module_hidden_ooo.scp
@@ -158,7 +158,6 @@
Files = (gid_File_Dat_Root4,
auto_File_Lib_ALL
gid_File_Lib_Bib,
-   gid_File_Lib_Flat,
gid_File_Lib_J,
gid_File_Lib_Offacc,
gid_File_Lib_Oox,
@@ -167,26 +166,14 @@
gid_File_Lib_Pl,
gid_File_Lib_Sf_Prothdlr,
gid_File_Lib_Res,
-   gid_File_Lib_Scn,
-   gid_File_Lib_Sd,
-   gid_File_Lib_Sdd,
-   gid_File_Lib_Sdui,
gid_File_Lib_Spa,
gid_File_Lib_AVMediaWin,
gid_File_Lib_AVMediaGStreamer,
gid_File_Lib_AVMediaGStreamer_0_10,
-   gid_File_Lib_BaseGfx,
gid_File_Lib_Sysdtrans,
-   gid_File_Lib_Sw,
gid_File_Lib_TextConversionDlgs,
gid_File_Lib_Acc,
gid_File_Lib_BaseBmp,
-   gid_File_Lib_Xmlfa,
-   gid_File_Lib_Xmlfd,
-   gid_File_Lib_Xof,
-   gid_File_Lib_Xsltdlg,
-   gid_File_Lib_Xsltfilter,
-   gid_File_Lib_Odfflatxml,
gid_File_Lib_Zip,
gid_File_Lib_Vclplug_Gen,
gid_File_Lib_Vclplug_Tde,
@@ -246,7 +233,6 @@
gid_File_Lib_Mork,
gid_File_Lib_Mozabdrv,
gid_File_Lib_Mozbootstrap,
-   gid_File_Lib_Mysql,
gid_File_Lib_Odbc,
gid_File_Lib_Officebean,
gid_File_Lib_Openssl,
@@ -618,7 +604,5 @@
 Default = YES;
 Styles = (HIDDEN_ROOT);
 Files = (gid_File_Lib_Spell,
-gid_File_Lib_Hyph,
-gid_File_Lib_Lnth,
 gid_File_Share_Registry_Lingucomponent_Xcd);
 End

-- 
To view, visit https://gerrit.libreoffice.org/3689
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c136760ca59278ba6bfcd1d11c56d810e9cfa76
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Remove last UNOLIBS_OOO

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3682

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3682/1

fdo#60949: Remove last UNOLIBS_OOO

Change-Id: I79af32f188a0e7de71ec8e6743fe73b3bb030a3f
---
M Repository.mk
1 file changed, 8 insertions(+), 11 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 296ffc8..76d6662 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -225,6 +225,7 @@
 chartcore \
 chartcontroller \
 cppcanvas \
+configmgr \
 ctl \
 cui \
 dba \
@@ -232,8 +233,9 @@
 dbmm \
 $(if $(DISABLE_DBCONNECTIVITY),,dbtools) \
 dbaxml \
-   deploymentmisc \
-   $(if $(filter unx,$(GUIBASE)),desktop_detector) \
+deploymentmisc \
+$(if $(filter-out MACOSX WNT,$(OS)),desktopbe1) \
+$(if $(filter unx,$(GUIBASE)),desktop_detector) \
 drawinglayer \
 editeng \
 egi \
@@ -252,12 +254,14 @@
 for \
 forui \
 frm \
+fsstorage \
 fwe \
fwi \
 fwk \
 fwl \
fwm \
 $(if $(filter DESKTOP,$(BUILD_TYPE)),helplinker) \
+i18npool \
 icd \
 icg \
 idx \
@@ -270,6 +274,7 @@
 ira \
 itg \
 iti \
+localebe1 \
 lng \
 $(if $(MERGELIBS),merged) \
 msfilter \
@@ -289,6 +294,7 @@
 tk \
 tl \
$(if $(ENABLE_TELEPATHY),tubes) \
+ucpexpand1 \
 unordf \
 unoxml \
 utl \
@@ -632,15 +638,6 @@
 smplmail \
 wininetbe1 \
 ) \
-))
-
-$(eval $(call gb_Helper_register_libraries_for_install,UNOLIBS_OOO,OOO, \
-   configmgr \
-   $(if $(filter-out MACOSX WNT,$(OS)),desktopbe1) \
-   fsstorage \
-   i18npool \
-   localebe1 \
-   ucpexpand1 \
 ))
 
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_URE, \

-- 
To view, visit https://gerrit.libreoffice.org/3682
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79af32f188a0e7de71ec8e6743fe73b3bb030a3f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: Move some libs to autoinstallation

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/3630

to look at the new patch set (#2).

Change subject: fdo#60924: Move some libs to autoinstallation
..

fdo#60924: Move some libs to autoinstallation

Change-Id: I58421587784260bd88994926bca031ab26a6214f
---
M Repository.mk
M scp2/source/ooo/file_ooo.scp
M scp2/source/ooo/module_hidden_ooo.scp
3 files changed, 24 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3630/2
-- 
To view, visit https://gerrit.libreoffice.org/3630
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58421587784260bd88994926bca031ab26a6214f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Matúš Kukan 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60924: Move some libs to autoinstallation

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3630

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3630/1

fdo#60924: Move some libs to autoinstallation

Change-Id: I58421587784260bd88994926bca031ab26a6214f
---
M Repository.mk
M scp2/source/ooo/file_ooo.scp
2 files changed, 24 insertions(+), 74 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 6a0e297..60c0170 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -236,7 +236,17 @@
$(if $(filter unx,$(GUIBASE)),desktop_detector) \
 drawinglayer \
 editeng \
+egi \
+eme \
 $(if $(filter WNT,$(OS)),$(if $(DISABLE_ATL),,emser)) \
+epb \
+epg \
+epp \
+eps \
+ept \
+era \
+eti \
+exp \
file \
filterconfig \
 for \
@@ -248,6 +258,18 @@
 fwl \
fwm \
 $(if $(filter DESKTOP,$(BUILD_TYPE)),helplinker) \
+icd \
+icg \
+idx \
+ime \
+ipb \
+ipd \
+ips \
+ipt \
+ipx \
+ira \
+itg \
+iti \
 lng \
 $(if $(MERGELIBS),merged) \
 msfilter \
@@ -255,9 +277,11 @@
 sax \
 sb \
 sdbt \
+sdfilt \
 sfx \
 sot \
 $(if $(ENABLE_HEADLESS),,spl) \
+svgio \
 svl \
 svt \
 svx \
@@ -310,35 +334,13 @@
 calc \
 dbp \
 dbu \
-egi \
-eme \
-epb \
-epg \
-epp \
-eps \
-ept \
-era \
-eti \
 evoab \
-exp \
filtertracer \
flash \
flat \
 graphicfilter \
 guesslang \
 hyphen \
-   icd \
-   icg \
-   idx \
-   ime \
-   ipb \
-   ipd \
-   ips \
-   ipt \
-   ipx \
-   ira \
-   itg \
-   iti \
jdbc \
kab1 \
kabdrv1 \
@@ -368,7 +370,6 @@
 scui \
 sd \
 sdd \
-sdfilt \
 sdui \
 simplecm \
 sm \
@@ -378,7 +379,6 @@
 spell \
 sts \
 svgfilter \
-   svgio \
 sw \
tdeab1 \
tdeabdrv1 \
diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 1b3dd8a..0eb299e 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -347,56 +347,6 @@
 Name = "toolbar.dtd";
 End
 
-STD_LIB_FILE( gid_File_Filter_Sdfilt, sdfilt)
-
-STD_LIB_FILE( git_File_Filter_Svgio, svgio)
-
-STD_LIB_FILE( gid_File_Filter_Eme, eme)
-
-STD_LIB_FILE( gid_File_Filter_Icg, icg)
-
-STD_LIB_FILE( gid_File_Filter_Egi, egi)
-
-STD_LIB_FILE( gid_File_Filter_Epb, epb)
-
-STD_LIB_FILE( gid_File_Filter_Epg, epg)
-
-STD_LIB_FILE( gid_File_Filter_Epp, epp)
-
-STD_LIB_FILE( gid_File_Filter_Eps, eps)
-
-STD_LIB_FILE( gid_File_Filter_Ept, ept)
-
-STD_LIB_FILE( gid_File_Filter_Era, era)
-
-STD_LIB_FILE( gid_File_Filter_Eti, eti)
-
-STD_LIB_FILE( gid_File_Filter_Exp, exp)
-
-STD_LIB_FILE( gid_File_Filter_Icd, icd)
-
-STD_LIB_FILE( gid_File_Filter_Idx, idx)
-
-STD_LIB_FILE( gid_File_Filter_Ime, ime)
-
-STD_LIB_FILE( gid_File_Filter_Ipb, ipb)
-
-STD_LIB_FILE( gid_File_Filter_Ipd, ipd)
-
-STD_LIB_FILE( gid_File_Filter_Ips, ips)
-
-STD_LIB_FILE( gid_File_Filter_Ipt, ipt)
-
-STD_LIB_FILE( gid_File_Filter_Ipx, ipx)
-
-STD_LIB_FILE( gid_File_Filter_Ira, ira)
-
-STD_LIB_FILE( gid_File_Filter_Itg, itg)
-
-STD_LIB_FILE( gid_File_Filter_Iti, iti)
-
-STD_RES_FILE( gid_File_Res_Eps, eps )
-
 File gid_File_Help_Help_Zip
 Dir = gid_Dir_Help;
 ARCHIVE_TXT_FILE_BODY;

-- 
To view, visit https://gerrit.libreoffice.org/3630
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58421587784260bd88994926bca031ab26a6214f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Remove UNOLIBS_OOO

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3626

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3626/1

fdo#60949: Remove UNOLIBS_OOO

By removing the last two libs: nullcanvas and directx5canvas.

directx5canvas seems to be dead and nullcanvas don't have entries in scp2.

Change-Id: Ib8fc1da123f8374fb83192f14db730638213f564
---
M Repository.mk
D canvas/Library_nullcanvas.mk
M canvas/Module_canvas.mk
3 files changed, 0 insertions(+), 65 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 6a0e297..f20519e 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -642,10 +642,6 @@
localebe1 \
ucpexpand1 \
 ))
-$(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
-directx5canvas \
-nullcanvas \
-))
 
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_URE, \
 testtools_cppobj \
diff --git a/canvas/Library_nullcanvas.mk b/canvas/Library_nullcanvas.mk
deleted file mode 100644
index 863696f..000
--- a/canvas/Library_nullcanvas.mk
+++ /dev/null
@@ -1,60 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#*
-#
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-# 
-# Copyright 2000, 2011 Oracle and/or its affiliates.
-#
-# OpenOffice.org - a multi-platform office productivity suite
-#
-# This file is part of OpenOffice.org.
-#
-# OpenOffice.org is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License version 3
-# only, as published by the Free Software Foundation.
-#
-# OpenOffice.org is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Lesser General Public License version 3 for more details
-# (a copy is included in the LICENSE file that accompanied this code).
-#
-# You should have received a copy of the GNU Lesser General Public License
-# version 3 along with OpenOffice.org.  If not, see
-# <http://www.openoffice.org/license.html>
-# for a copy of the LGPLv3 License.
-#
-#*
-
-$(eval $(call gb_Library_Library,nullcanvas))
-
-$(eval $(call 
gb_Library_set_componentfile,nullcanvas,canvas/source/null/nullcanvas))
-
-$(eval $(call gb_Library_use_external,nullcanvas,boost_headers))
-
-$(eval $(call gb_Library_use_sdk_api,nullcanvas))
-
-$(eval $(call gb_Library_use_libraries,nullcanvas,\
-   basegfx \
-   canvastools \
-   comphelper \
-   cppu \
-   cppuhelper \
-   sal \
-   vcl \
-   $(gb_UWINAPI) \
-))
-
-$(eval $(call gb_Library_add_exception_objects,nullcanvas,\
-   canvas/source/null/null_canvasbitmap \
-   canvas/source/null/null_canvascustomsprite \
-   canvas/source/null/null_canvasfont \
-   canvas/source/null/null_canvashelper \
-   canvas/source/null/null_devicehelper \
-   canvas/source/null/null_spritecanvas \
-   canvas/source/null/null_spritecanvashelper \
-   canvas/source/null/null_spritehelper \
-   canvas/source/null/null_textlayout \
-))
-
-# vim: set noet sw=4 ts=4:
diff --git a/canvas/Module_canvas.mk b/canvas/Module_canvas.mk
index a678faf..59acf96 100644
--- a/canvas/Module_canvas.mk
+++ b/canvas/Module_canvas.mk
@@ -31,7 +31,6 @@
 $(eval $(call gb_Module_add_targets,canvas,\
Library_canvasfactory \
Library_canvastools \
-   Library_nullcanvas \
Library_simplecanvas \
Library_vclcanvas \
 ))

-- 
To view, visit https://gerrit.libreoffice.org/3626
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8fc1da123f8374fb83192f14db730638213f564
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Remove all usages of the macro EXTERN_C

[Marcos Souza (via Code Review)]

ce ::com::sun::star;
 
-#define EXTERN_C extern "C"
-
 /**
  * @brief
  * Implements the XFilter interface.
diff --git a/sal/systools/win32/uwinapi/legacy.c 
b/sal/systools/win32/uwinapi/legacy.c
index ec0b80a..777df2b 100644
--- a/sal/systools/win32/uwinapi/legacy.c
+++ b/sal/systools/win32/uwinapi/legacy.c
@@ -14,7 +14,7 @@
 #pragma warning(disable:4273)   // inconsistent dll linkage
 #endif
 
-EXTERN_C DWORD WINAPI GetShortPathNameW(LPCWSTR lpszLongPath,LPWSTR 
lpszShortPath,DWORD cchBuffer)
+extern "C" DWORD WINAPI GetShortPathNameW(LPCWSTR lpszLongPath,LPWSTR 
lpszShortPath,DWORD cchBuffer)
 {
 typedef DWORD (WINAPI * GetShortPathNameW_t) (LPCWSTR,LPWSTR,DWORD);
 
diff --git a/sfx2/source/control/dispatch.cxx b/sfx2/source/control/dispatch.cxx
index 3ba81de..f77cae4 100644
--- a/sfx2/source/control/dispatch.cxx
+++ b/sfx2/source/control/dispatch.cxx
@@ -1734,7 +1734,7 @@
 }
 
 //
-EXTERN_C
+extern "C"
 #ifdef WNT
 int _cdecl
 #else
diff --git a/sfx2/source/control/objface.cxx b/sfx2/source/control/objface.cxx
index 2d48db3..09870ea 100644
--- a/sfx2/source/control/objface.cxx
+++ b/sfx2/source/control/objface.cxx
@@ -35,7 +35,7 @@
 
 //
 
-EXTERN_C
+extern "C"
 #ifdef WNT
 int _cdecl
 #else

-- 
To view, visit https://gerrit.libreoffice.org/3621
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25b7f509ba5d1007a16c84ad05870a8174c094ec
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move the last libs to OOOLIBS

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/3561

to look at the new patch set (#3).

Change subject: fdo#60949: Move the last libs to OOOLIBS
..

fdo#60949: Move the last libs to OOOLIBS

Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3
---
M Repository.mk
M scp2/source/base/postgresqlsdbc.scp
M scp2/source/canvas/canvascommons.scp
M scp2/source/canvas/directxcanvas.scp
M scp2/source/canvas/vclcanvas.scp
M scp2/source/gnome/file_gnome.scp
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_pdfimport.scp
8 files changed, 52 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3561/3
-- 
To view, visit https://gerrit.libreoffice.org/3561
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Björn Michaelsen 
Gerrit-Reviewer: David Tardon 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Matúš Kukan 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move the last libs to OOOLIBS

[Marcos Souza (via Code Review)]

Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/3561

to look at the new patch set (#2).

Change subject: fdo#60949: Move the last libs to OOOLIBS
..

fdo#60949: Move the last libs to OOOLIBS

Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3
---
M Repository.mk
M scp2/source/base/postgresqlsdbc.scp
M scp2/source/canvas/canvascommons.scp
M scp2/source/canvas/directxcanvas.scp
M scp2/source/canvas/vclcanvas.scp
M scp2/source/gnome/file_gnome.scp
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/module_pdfimport.scp
8 files changed, 52 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/3561/2
-- 
To view, visit https://gerrit.libreoffice.org/3561
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Björn Michaelsen 
Gerrit-Reviewer: David Tardon 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 
Gerrit-Reviewer: Matúš Kukan 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Removed all usages of SVLIBRARY

[Marcos Souza (via Code Review)]

 msword library");
 }
 if (msword_.is())
diff --git a/sw/source/ui/dbui/swdbtoolsclient.cxx 
b/sw/source/ui/dbui/swdbtoolsclient.cxx
index 14cce3b..789a5eb 100644
--- a/sw/source/ui/dbui/swdbtoolsclient.cxx
+++ b/sw/source/ui/dbui/swdbtoolsclient.cxx
@@ -104,7 +104,7 @@
 OSL_ENSURE(NULL == getDbToolsClientFactoryFunction(), 
"SwDbtoolsClient::registerClient: inconsistence: already have a factory 
function!");
 
 #ifndef DISABLE_DYNLOADING
-const OUString 
sModuleName(RTL_CONSTASCII_USTRINGPARAM(SVLIBRARY("dbtools")));
+const OUString sModuleName(SAL_MODULENAME("dbtools" "lo"));
 
 // load the dbtools library
 getDbToolsClientModule() = osl_loadModuleRelative(
diff --git a/toolkit/source/helper/accessibilityclient.cxx 
b/toolkit/source/helper/accessibilityclient.cxx
index 9ab29d0..f4ebc06 100644
--- a/toolkit/source/helper/accessibilityclient.cxx
+++ b/toolkit/source/helper/accessibilityclient.cxx
@@ -21,7 +21,6 @@
 #include 
 #include 
 #include 
-#include 
 
 // #define UNLOAD_ON_LAST_CLIENT_DYING
 // this is not recommended currently. If enabled, the implementation will 
log
@@ -201,7 +200,7 @@
 if ( !s_pFactory.get() )
 {
 #ifndef DISABLE_DYNLOADING
-const OUString sModuleName( SVLIBRARY( "acc" ) );
+const OUString sModuleName( SAL_MODULENAME( "acc" "lo" ) );
 s_hAccessibleImplementationModule = osl_loadModuleRelative( 
&thisModule, sModuleName.pData, 0 );
 if ( s_hAccessibleImplementationModule != NULL )
 {
diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
index 58d5849..d880e28 100644
--- a/tools/inc/tools/solar.h
+++ b/tools/inc/tools/solar.h
@@ -131,24 +131,6 @@
 #define XubString   String
 #define xub_StrLen  sal_uInt16
 
-#define STRING_CONCAT3( s1, s2, s3 ) \
-s1 s2 s3
-
-// dll file extensions
-
-#if defined WNT
-#define SVLIBRARY( Base ) \
-STRING_CONCAT3( Base, "lo", ".dll" )
-#elif defined MACOSX
-#define SVLIBRARY( Base ) \
-STRING_CONCAT3( "lib", Base, "lo.dylib" )
-#elif defined UNX
-#define SVLIBRARY( Base ) \
-STRING_CONCAT3( "lib", Base, "lo.so" )
-#else
-  #error unknown platform
-#endif
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/filter/FilterConfigCache.cxx 
b/vcl/source/filter/FilterConfigCache.cxx
index fea57af..063fbe0 100644
--- a/vcl/source/filter/FilterConfigCache.cxx
+++ b/vcl/source/filter/FilterConfigCache.cxx
@@ -19,6 +19,7 @@
 
 #include "FilterConfigCache.hxx"
 
+#include 
 #include 
 #include 
 #include 
@@ -87,7 +88,7 @@
 if ( sFilterName.EqualsIgnoreCaseAscii( *pPtr ) )
 bIsPixelFormat = sal_True;
 }
-OUString sTemp(SVLIBRARY("?"));
+OUString sTemp(SAL_MODULENAME("?" "lo"));
 sal_Int32 nIndex = sTemp.indexOf(static_cast('?'));
 sFilterName = sTemp.replaceAt(nIndex, 1, sFilterName);
 }

-- 
To view, visit https://gerrit.libreoffice.org/3574
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1b6ba1220657343a264525d1cb55138e481f4fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move the last libs to OOOLIBS

[Marcos Souza (via Code Review)]

 
-SPECIAL_COMPONENT_LIB_FILE(gid_File_Lib_Losessioninstall, losessioninstall.uno)
+SPECIAL_COMPONENT_LIB_FILE(gid_File_Lib_Losessioninstall, losessioninstall)
 #endif
 
 #ifdef ENABLE_GNOMEVFS
diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 17f4668..bea5d03 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -138,7 +138,7 @@
 
 
 #if ! defined WNT // no longer supported on Windows
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Cmdmail, cmdmail.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Cmdmail, cmdmail )
 #endif
 
 
@@ -392,12 +392,7 @@
 #endif
 
 #ifdef MACOSX
-File gid_File_Lib_Fps_Aqua
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = SPECIAL_COMPONENT_LIB_NAME(fps_aqua.uno);
-End
+STD_LIB_FILE( gid_File_Lib_Fps_Aqua, fps_aqua )
 
 File gid_File_Lib_MacOSXSpell
LIB_FILE_BODY;
@@ -416,8 +411,8 @@
 #endif
 #endif
 
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Fps_Office, fps_office.uno )
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Fpicker, fpicker.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Fps_Office, fps_office )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Fpicker, fpicker )
 
 
 #ifndef SYSTEM_LCMS2
@@ -494,7 +489,7 @@
 
 #endif
 
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Hatchwindowfactory, 
hatchwindowfactory.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Hatchwindowfactory, 
hatchwindowfactory )
 
 STD_LIB_FILE( gid_File_Lib_I18nsearch, i18nsearch )
 
@@ -697,17 +692,10 @@
 #endif
 
 #if defined(WNT) && !defined(DISABLE_ATL)
-
-File gid_File_Lib_Ole
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "oleautobridge.uno.dll";
-End
-
+STD_LIB_FILE( gid_File_Lib_Ole, oleautobridge )
 #endif
 
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Passwordcontainer, 
passwordcontainer.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Passwordcontainer, passwordcontainer )
 
 STD_LIB_FILE( gid_File_Lib_Pcr, pcr)
 
@@ -886,14 +874,7 @@
 #endif
 
 #ifdef WNT
-
-File gid_File_Lib_Smplmail
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = "smplmail.uno.dll";
-End
-
+STD_LIB_FILE( gid_File_Lib_Smplmail, smplmail )
 #endif
 
 #if defined(UNX) && !defined(MACOSX) && !defined(LIBO_HEADLESS)
@@ -933,14 +914,14 @@
 End
 #endif
 
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Syssh, syssh.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Syssh, syssh )
 
 #ifdef WNT
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Wininetbe, wininetbe1.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Wininetbe, wininetbe1 )
 #endif
 
 #ifdef MACOSX
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Macbe, macbe1.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Macbe, macbe1 )
 #endif
 
 STD_LIB_FILE( gid_File_Lib_Acc, acc )
@@ -1023,11 +1004,11 @@
 
 SPECIAL_LIB_FILE(gid_File_Lib_Ucppkg1,ucppkg1)
 
-SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucptdoc1, ucptdoc1.uno)
+SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucptdoc1, ucptdoc1)
 
-SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucpext, ucpext.uno)
+SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucpext, ucpext)
 
-SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucpcmis, ucpcmis1.uno)
+SPECIAL_COMPONENT_LIB_FILE(gid_File_Ucpcmis, ucpcmis1)
 
 File gid_File_Lib_Lnth
 LIB_FILE_BODY;
@@ -1168,7 +1149,7 @@
 
 STD_LIB_FILE( gid_File_Lib_Guesslang, guesslang )
 
-SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Updatefeed , updatefeed.uno )
+SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Updatefeed , updatefeed )
 
 #ifndef SYSTEM_OPENSSL
 File gid_File_Lib_Openssl
diff --git a/scp2/source/ooo/module_pdfimport.scp 
b/scp2/source/ooo/module_pdfimport.scp
index 06f4583..0d42536 100644
--- a/scp2/source/ooo/module_pdfimport.scp
+++ b/scp2/source/ooo/module_pdfimport.scp
@@ -56,12 +56,7 @@
 Styles = (PACKED);
 End
 
-File gid_File_Lib_PdfimportUno
-TXT_FILE_BODY;
-Dir = gid_Brand_Dir_Program;
-Name = SCP2_URE_DL_BARE("pdfimport.uno");
-Styles = (PACKED);
-End
+STD_LIB_FILE( gid_File_Lib_PdfimportUno, pdfimport )
 
 File gid_File_Xcd_Pdfimport
 TXT_FILE_BODY;

-- 
To view, visit https://gerrit.libreoffice.org/3561
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieec4edf41140f9c5af3dcc227c917b06157a26f3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move more libs to OOOLIBS

[Marcos Souza (via Code Review)]

45b0de 100644
--- a/scp2/source/tde/file_tde.scp
+++ b/scp2/source/tde/file_tde.scp
@@ -24,10 +24,5 @@
 #include "macros.inc"
 
 #ifdef ENABLE_TDE
-File gid_File_Lib_Tdebe
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(tdebe1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Tdebe, tdebe1 )
 #endif

-- 
To view, visit https://gerrit.libreoffice.org/3511
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd45f7004f8eaa151b9a60d7369d396411f60a2b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

[Marcos Souza (via Code Review)]

fldui/fldmgr.cxx
M sw/source/ui/frmdlg/column.cxx
M sw/source/ui/frmdlg/frmmgr.cxx
M sw/source/ui/frmdlg/frmpage.cxx
M sw/source/ui/frmdlg/wrap.cxx
M sw/source/ui/misc/outline.cxx
M sw/source/ui/misc/redlndlg.cxx
M sw/source/ui/ribbar/inputwin.cxx
M sw/source/ui/shells/tabsh.cxx
M sw/source/ui/table/swtablerep.cxx
M sw/source/ui/table/tabledlg.cxx
M sw/source/ui/table/tablemgr.cxx
M sw/source/ui/uiview/pview.cxx
M sw/source/ui/uiview/view2.cxx
M sw/source/ui/uiview/viewmdi.cxx
M sw/source/ui/uiview/viewport.cxx
M sw/source/ui/uiview/viewtab.cxx
M sw/source/ui/utlui/prcntfld.cxx
M sw/source/ui/vba/vbatablehelper.cxx
M toolkit/source/awt/vclxmenu.cxx
M tools/inc/tools/gen.hxx
M tools/inc/tools/solar.h
M tools/source/datetime/ttime.cxx
M tools/source/generic/fract.cxx
M tools/source/generic/gen.cxx
M tools/source/generic/poly.cxx
M uui/source/secmacrowarnings.cxx
M vcl/inc/vcl/salbtype.hxx
M vcl/source/control/edit.cxx
M vcl/source/control/field2.cxx
M vcl/source/control/ilstbox.cxx
M vcl/source/control/spinfld.cxx
M vcl/source/edit/textdata.cxx
M vcl/source/edit/texteng.cxx
M vcl/source/edit/vclmedit.cxx
M vcl/source/filter/graphicfilter.cxx
M vcl/source/filter/igif/gifread.cxx
M vcl/source/gdi/alpha.cxx
M vcl/source/gdi/animate.cxx
M vcl/source/gdi/bitmap.cxx
M vcl/source/gdi/bitmap3.cxx
M vcl/source/gdi/bmpacc.cxx
M vcl/source/gdi/cvtsvm.cxx
M vcl/source/gdi/gdimtf.cxx
M vcl/source/gdi/impanmvw.cxx
M vcl/source/gdi/impgraph.cxx
M vcl/source/gdi/impvect.cxx
M vcl/source/gdi/outdev3.cxx
M vcl/source/gdi/outdev4.cxx
M vcl/source/gdi/outdev6.cxx
M vcl/source/gdi/outmap.cxx
M vcl/source/gdi/region.cxx
M vcl/source/window/decoview.cxx
M vcl/source/window/menu.cxx
M vcl/source/window/scrwnd.cxx
M vcl/source/window/splitwin.cxx
M vcl/source/window/status.cxx
M vcl/source/window/window.cxx
M vcl/source/window/window2.cxx
M vcl/source/window/winproc.cxx
M vcl/unx/generic/gdi/salbmp.cxx
M vcl/win/source/gdi/salbmp.cxx
M vcl/win/source/gdi/salgdi.cxx
M vcl/win/source/gdi/salgdi3.cxx
M vcl/win/source/gdi/winlayout.cxx
M vcl/win/source/window/salframe.cxx
M xmloff/source/draw/shapeexport4.cxx
M xmlsecurity/source/dialogs/certificateviewer.cxx
339 files changed, 1,214 insertions(+), 1,226 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3326/3
-- 
To view, visit https://gerrit.libreoffice.org/3326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Eike Rathke 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move more libs to OOOLIBS

[Marcos Souza (via Code Review)]

_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(migrationoo2.uno,UNXSUFFIX));
-  #else
-Name = "migrationoo2.uno.dll";
-  #endif
-End
+STD_LIB_FILE( gid_File_Lib_Migrationoo2, migrationoo2 )
 
-File gid_File_Lib_Migrationoo3
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(migrationoo3.uno,UNXSUFFIX));
-  #else
-Name = "migrationoo3.uno.dll";
-  #endif
-End
+STD_LIB_FILE( gid_File_Lib_Migrationoo3, migrationoo3 )
 
 STD_LIB_FILE( gid_File_Lib_Guesslang, guesslang )
 

-- 
To view, visit https://gerrit.libreoffice.org/3484
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I566602028556aa954bcbd116c375b9b61cc3df6f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#57950: Chained appends in postgresql driver

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: fdo#57950: Chained appends in postgresql driver
..


Patch Set 1: Abandoned

Needs a rework.

-- 
To view, visit https://gerrit.libreoffice.org/3170
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic7bc35f5e65292d2d8a9d51418760c702676e478
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Luboš Luňák 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

[Marcos Souza (via Code Review)]

fldui/fldmgr.cxx
M sw/source/ui/frmdlg/column.cxx
M sw/source/ui/frmdlg/frmmgr.cxx
M sw/source/ui/frmdlg/frmpage.cxx
M sw/source/ui/frmdlg/wrap.cxx
M sw/source/ui/misc/outline.cxx
M sw/source/ui/misc/redlndlg.cxx
M sw/source/ui/ribbar/inputwin.cxx
M sw/source/ui/shells/tabsh.cxx
M sw/source/ui/table/swtablerep.cxx
M sw/source/ui/table/tabledlg.cxx
M sw/source/ui/table/tablemgr.cxx
M sw/source/ui/uiview/pview.cxx
M sw/source/ui/uiview/view2.cxx
M sw/source/ui/uiview/viewmdi.cxx
M sw/source/ui/uiview/viewport.cxx
M sw/source/ui/uiview/viewtab.cxx
M sw/source/ui/utlui/prcntfld.cxx
M sw/source/ui/vba/vbatablehelper.cxx
M toolkit/source/awt/vclxmenu.cxx
M tools/inc/tools/gen.hxx
M tools/inc/tools/solar.h
M tools/source/datetime/ttime.cxx
M tools/source/generic/fract.cxx
M tools/source/generic/gen.cxx
M tools/source/generic/poly.cxx
M uui/source/secmacrowarnings.cxx
M vcl/inc/vcl/salbtype.hxx
M vcl/source/control/edit.cxx
M vcl/source/control/field2.cxx
M vcl/source/control/ilstbox.cxx
M vcl/source/control/spinfld.cxx
M vcl/source/edit/textdata.cxx
M vcl/source/edit/texteng.cxx
M vcl/source/edit/vclmedit.cxx
M vcl/source/filter/graphicfilter.cxx
M vcl/source/filter/igif/gifread.cxx
M vcl/source/gdi/alpha.cxx
M vcl/source/gdi/animate.cxx
M vcl/source/gdi/bitmap.cxx
M vcl/source/gdi/bitmap3.cxx
M vcl/source/gdi/bmpacc.cxx
M vcl/source/gdi/cvtsvm.cxx
M vcl/source/gdi/gdimtf.cxx
M vcl/source/gdi/impanmvw.cxx
M vcl/source/gdi/impgraph.cxx
M vcl/source/gdi/impvect.cxx
M vcl/source/gdi/outdev3.cxx
M vcl/source/gdi/outdev4.cxx
M vcl/source/gdi/outdev6.cxx
M vcl/source/gdi/outmap.cxx
M vcl/source/gdi/region.cxx
M vcl/source/window/decoview.cxx
M vcl/source/window/menu.cxx
M vcl/source/window/scrwnd.cxx
M vcl/source/window/splitwin.cxx
M vcl/source/window/status.cxx
M vcl/source/window/window.cxx
M vcl/source/window/window2.cxx
M vcl/source/window/winproc.cxx
M vcl/unx/generic/gdi/salbmp.cxx
M vcl/win/source/gdi/salbmp.cxx
M vcl/win/source/gdi/salgdi.cxx
M vcl/win/source/gdi/winlayout.cxx
M xmloff/source/draw/shapeexport4.cxx
M xmlsecurity/source/dialogs/certificateviewer.cxx
337 files changed, 1,212 insertions(+), 1,224 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/3326/2
-- 
To view, visit https://gerrit.libreoffice.org/3326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Eike Rathke 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#60949: Move some libs to OOOLIBS

[Marcos Souza (via Code Review)]

Marcos Souza has abandoned this change.

Change subject: fdo#60949: Move some libs to OOOLIBS
..


Patch Set 1: Abandoned

A new change-id was generated(my bad) so abandoning this

-- 
To view, visit https://gerrit.libreoffice.org/3467
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I14a64ba0b61933372c2e3c99666d74f3d115d134
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Björn Michaelsen 
Gerrit-Reviewer: LibreOffice gerrit bot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move some libs to OOOLIBS

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3476

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/3476/1

fdo#60949: Move some libs to OOOLIBS

Compile test only :)

Change-Id: I1e546b824ec027bb1321e36fb060af5b4cfd1bf1
---
M Repository.mk
M scp2/source/canvas/cairocanvas.scp
M scp2/source/ooo/file_library_ooo.scp
3 files changed, 10 insertions(+), 56 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 15c3481..22e03be 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -559,8 +559,13 @@
 ))
 
 $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
+cairocanvas \
+msforms \
 mtfrenderer \
 OGLTrans \
+vbaevents \
+vbaobj \
+vbaswobj \
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,UNOLIBS_OOO,OOO, \
@@ -574,7 +579,6 @@
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
 PresenterScreen \
 basprov \
-cairocanvas \
 canvasfactory \
 cmdmail \
 directx5canvas \
@@ -595,7 +599,6 @@
 macbe1 \
 migrationoo2 \
 migrationoo3 \
-msforms \
 nullcanvas \
 passwordcontainer \
 pdfimport \
@@ -613,9 +616,6 @@
 ucpgvfs1 \
 ucptdoc1 \
 updatefeed \
-vbaevents \
-vbaobj \
-vbaswobj \
 vclcanvas \
 $(if $(filter $(OS),MACOSX), \
 fps_aqua \
diff --git a/scp2/source/canvas/cairocanvas.scp 
b/scp2/source/canvas/cairocanvas.scp
index 4b313bc..de5742a 100644
--- a/scp2/source/canvas/cairocanvas.scp
+++ b/scp2/source/canvas/cairocanvas.scp
@@ -27,14 +27,4 @@
 
 #include "macros.inc"
 
-File gid_File_Lib_CairoCanvas
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(cairocanvas.uno,UNXSUFFIX));
-  #else
-Name = "cairocanvas.uno.dll";
-  #endif
-End
-
+STD_LIB_FILE(gid_File_Lib_CairoCanvas, cairocanvas)
diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 5aafd04..a993630 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -55,16 +55,7 @@
   #endif
 End
 
-File gid_File_Lib_Vbaevent
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaevents,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaevents,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaevent, vbaevents)
 
 File gid_File_Lib_Scriptframe
 LIB_FILE_BODY;
@@ -306,38 +297,11 @@
   #endif
 End
 
-File gid_File_Lib_Vbaobj
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaobj,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaobj,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaobj, vbaobj)
 
-File gid_File_Lib_Vbaswobj
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaswobj,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaswobj,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaswobj, vbaswobj)
 
-File gid_File_Lib_Vbamsforms
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(msforms,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(msforms,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbamsforms, msforms)
 
 File gid_File_Lib_Vbahelper
 LIB_FILE_BODY;

-- 
To view, visit https://gerrit.libreoffice.org/3476
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e546b824ec027bb1321e36fb060af5b4cfd1bf1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#62699: Drop wrapper header

[Marcos Souza (via Code Review)]

svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -21,7 +21,6 @@
 #include 
 
 #include 
-#include "svx/svditext.hxx"
 #include 
 #include 
 #include 
@@ -31,6 +30,7 @@
 #include "svx/svdstr.hrc"   // names taken from the resource
 #include "svx/svdglob.hxx"  // StringCache
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index 6ed282d..4d0ee93 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -18,13 +18,13 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 

-- 
To view, visit https://gerrit.libreoffice.org/3473
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21e91ab136c944c6dc77a90500b1bcebbf7cf851
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move some libs to OOOLIBS

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3467

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3467/1

fdo#60949: Move some libs to OOOLIBS

Compile test only :)

Change-Id: I14a64ba0b61933372c2e3c99666d74f3d115d134
---
M Repository.mk
M scp2/source/canvas/cairocanvas.scp
M scp2/source/ooo/file_library_ooo.scp
3 files changed, 10 insertions(+), 56 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 15c3481..22e03be 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -559,8 +559,13 @@
 ))
 
 $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
+cairocanvas \
+msforms \
 mtfrenderer \
 OGLTrans \
+vbaevents \
+vbaobj \
+vbaswobj \
 ))
 
 $(eval $(call gb_Helper_register_libraries_for_install,UNOLIBS_OOO,OOO, \
@@ -574,7 +579,6 @@
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
 PresenterScreen \
 basprov \
-cairocanvas \
 canvasfactory \
 cmdmail \
 directx5canvas \
@@ -595,7 +599,6 @@
 macbe1 \
 migrationoo2 \
 migrationoo3 \
-msforms \
 nullcanvas \
 passwordcontainer \
 pdfimport \
@@ -613,9 +616,6 @@
 ucpgvfs1 \
 ucptdoc1 \
 updatefeed \
-vbaevents \
-vbaobj \
-vbaswobj \
 vclcanvas \
 $(if $(filter $(OS),MACOSX), \
 fps_aqua \
diff --git a/scp2/source/canvas/cairocanvas.scp 
b/scp2/source/canvas/cairocanvas.scp
index 4b313bc..de5742a 100644
--- a/scp2/source/canvas/cairocanvas.scp
+++ b/scp2/source/canvas/cairocanvas.scp
@@ -27,14 +27,4 @@
 
 #include "macros.inc"
 
-File gid_File_Lib_CairoCanvas
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT2(cairocanvas.uno,UNXSUFFIX));
-  #else
-Name = "cairocanvas.uno.dll";
-  #endif
-End
-
+STD_LIB_FILE(gid_File_Lib_CairoCanvas, cairocanvas)
diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 5aafd04..9846d56 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -55,16 +55,7 @@
   #endif
 End
 
-File gid_File_Lib_Vbaevent
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaevents,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaevents,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaevent, vbaevent)
 
 File gid_File_Lib_Scriptframe
 LIB_FILE_BODY;
@@ -306,38 +297,11 @@
   #endif
 End
 
-File gid_File_Lib_Vbaobj
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaobj,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaobj,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaobj, vbaobj)
 
-File gid_File_Lib_Vbaswobj
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(vbaswobj,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(vbaswobj,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbaswobj, vbaswobj)
 
-File gid_File_Lib_Vbamsforms
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-  #ifdef UNX
-Name = STRING(CONCAT3(msforms,.uno,UNXSUFFIX));
-  #else
-Name = STRING(CONCAT3(msforms,.uno,.dll));
-  #endif
-End
+STD_LIB_FILE(gid_File_Lib_Vbamsforms, msforms)
 
 File gid_File_Lib_Vbahelper
 LIB_FILE_BODY;

-- 
To view, visit https://gerrit.libreoffice.org/3467
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I14a64ba0b61933372c2e3c99666d74f3d115d134
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Change macros Min/Max for std::min/max

[Marcos Souza (via Code Review)]

/source/ui/frmdlg/wrap.cxx
M sw/source/ui/misc/outline.cxx
M sw/source/ui/misc/redlndlg.cxx
M sw/source/ui/ribbar/inputwin.cxx
M sw/source/ui/shells/tabsh.cxx
M sw/source/ui/table/swtablerep.cxx
M sw/source/ui/table/tabledlg.cxx
M sw/source/ui/table/tablemgr.cxx
M sw/source/ui/uiview/pview.cxx
M sw/source/ui/uiview/view2.cxx
M sw/source/ui/uiview/viewmdi.cxx
M sw/source/ui/uiview/viewport.cxx
M sw/source/ui/uiview/viewtab.cxx
M sw/source/ui/utlui/prcntfld.cxx
M sw/source/ui/vba/vbatablehelper.cxx
M toolkit/source/awt/vclxmenu.cxx
M tools/inc/tools/gen.hxx
M tools/inc/tools/solar.h
M tools/source/datetime/ttime.cxx
M tools/source/generic/fract.cxx
M tools/source/generic/gen.cxx
M tools/source/generic/poly.cxx
M uui/source/secmacrowarnings.cxx
M vcl/inc/vcl/salbtype.hxx
M vcl/source/control/edit.cxx
M vcl/source/control/field2.cxx
M vcl/source/control/ilstbox.cxx
M vcl/source/control/spinfld.cxx
M vcl/source/edit/textdata.cxx
M vcl/source/edit/texteng.cxx
M vcl/source/edit/vclmedit.cxx
M vcl/source/filter/graphicfilter.cxx
M vcl/source/filter/igif/gifread.cxx
M vcl/source/gdi/alpha.cxx
M vcl/source/gdi/animate.cxx
M vcl/source/gdi/bitmap.cxx
M vcl/source/gdi/bitmap3.cxx
M vcl/source/gdi/bmpacc.cxx
M vcl/source/gdi/cvtsvm.cxx
M vcl/source/gdi/gdimtf.cxx
M vcl/source/gdi/impanmvw.cxx
M vcl/source/gdi/impgraph.cxx
M vcl/source/gdi/impvect.cxx
M vcl/source/gdi/outdev3.cxx
M vcl/source/gdi/outdev4.cxx
M vcl/source/gdi/outdev6.cxx
M vcl/source/gdi/outmap.cxx
M vcl/source/gdi/region.cxx
M vcl/source/window/decoview.cxx
M vcl/source/window/menu.cxx
M vcl/source/window/scrwnd.cxx
M vcl/source/window/splitwin.cxx
M vcl/source/window/status.cxx
M vcl/source/window/window.cxx
M vcl/source/window/window2.cxx
M vcl/source/window/winproc.cxx
M vcl/unx/generic/gdi/salbmp.cxx
M xmloff/source/draw/shapeexport4.cxx
M xmlsecurity/source/dialogs/certificateviewer.cxx
334 files changed, 1,207 insertions(+), 1,219 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/3326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Redland - Build error in Ubuntu 12.10 x86

[Marcos Souza]

Thanks Caolan!

Now it's working :)


2013/4/3 Caolán McNamara 

> On Wed, 2013-04-03 at 14:45 -0300, Marcos Souza wrote:
> > Hi guys,
> >
> >
> > In master , I'm getting this error:
>
> > /home/marcos/gitroot/core/solver/unxlngi6/inc/external/rasqal.h:672:81:
> error: unknown type name 'raptor_message_handler'
> > /home/marcos/gitroot/core/solver/unxlngi6/inc/external/rasqal.h:674:75:
> error: unknown type name 'raptor_message_handler'
>
> Try...
> rm /home/marcos/gitroot/core/solver/unxlngi6/inc/external/rasqal.h
> and make again.
>
> C.
>
>
>


-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Redland - Build error in Ubuntu 12.10 x86

[Marcos Souza]

Hi guys,

In master , I'm getting this error:

Redland build summary:

  Using monolithic storage backends

  Oracle Berkeley DB (BDB) : Missing
  Triple stores available  : memory file hashes(memory) trees
  Triple stores enabled: memory file hashes trees
  RDF parsers  : raptor(system )
  RDF query: rasqal(system )
  Content digests  : md5 sha1

Making all in libltdl
Making all in src
Making all in win32
libtool: compile:  gcc -DHAVE_CONFIG_H -I.
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/raptor/src
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/rasqal/src
-DPKGDATADIR=\"/usr/local/share/redland\"
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/raptor/src
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/rasqal/src
-DLIBRDF_INTERNAL=1 -MT rdf_init.lo -MD -MP -MF .deps/rdf_init.Tpo -c
rdf_init.c  -fPIC -DPIC -o .libs/rdf_init.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I.
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/raptor/src
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/rasqal/src
-DPKGDATADIR=\"/usr/local/share/redland\"
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/solver/unxlngi6/inc/external
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/raptor/src
-I/home/marcos/gitroot/core/workdir/unxlngi6/UnpackedTarball/rasqal/src
-DLIBRDF_INTERNAL=1 -MT rdf_raptor.lo -MD -MP -MF .deps/rdf_raptor.Tpo -c
rdf_raptor.c  -fPIC -DPIC -o .libs/rdf_raptor.o
In file included from ./librdf.h:33:0,
 from ./redland.h:30,
 from rdf_raptor.c:37:
/home/marcos/gitroot/core/solver/unxlngi6/inc/external/rasqal.h:672:81:
error: unknown type name 'raptor_message_handler'
/home/marcos/gitroot/core/solver/unxlngi6/inc/external/rasqal.h:674:75:
error: unknown type name 'raptor_message_handler'

If you need more info, please ask :)

Thanks guys!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57950: Chained appends in postgresql driver

[Marcos Souza (via Code Review)]

ture->getPropertyValue( st.TABLE_NAME ) ||
-// past->getPropertyValue( st.SCHEMA_NAME ) != 
future->getPropertyValue( st.SCHEMA_NAME ))
-// {
-// OUStringBuffer buf(128);
-// buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "Can't move column " ) 
);
-// buf.append( extractStringProperty( past, st.COLUMN_NAME ) );
-// buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( " from table " ) );
-// buf.append( extractStringProperty( past, st.TABLE_NAME ) );
-// buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( " to table " ) );
-// buf.append( extractStringProperty( past, st.TABLE_NAME ) );
-//     throw SQLException( buf.makeStringAndClear(), Reference< XInterface 
> () );
-// }
-
-// OUString tableName = extractStringProperty( past, st.TABLE_NAME );
-// OUString schemaName = extractStringProperty( past, st.SCHEMA_NAME );
 OUString pastColumnName = extractStringProperty( past, st.NAME );
 OUString futureColumnName = extractStringProperty( future, st.NAME );
 OUString pastTypeName = sqltype2string( past );
@@ -475,11 +375,6 @@
 transaction.executeUpdate( buf.makeStringAndClear() );
 }
 
-// OUString futureComment = extractStringProperty( future, st.HELP_TEXT );
-// OUString pastComment = extractStringProperty( past, st.HELP_TEXT );
-// printf( "past Comment %s, futureComment %s\n",
-// OUStringToOString( pastComment, RTL_TEXTENCODING_ASCII_US 
).getStr(),
-// OUStringToOString( futureComment, RTL_TEXTENCODING_ASCII_US 
).getStr() );
 OUString futureComment = extractStringProperty( future, st.DESCRIPTION );
 OUString pastComment = extractStringProperty( past, st.DESCRIPTION );
 
@@ -510,28 +405,6 @@
 
 refresh();
 }
-
-// void Columns::dropByName( const ::rtl::OUString& elementName )
-// throw (::com::sun::star::sdbc::SQLException,
-//::com::sun::star::container::NoSuchElementException,
-//::com::sun::star::uno::RuntimeException)
-// {
-// String2IntMap::const_iterator ii = m_name2index.find( elementName );
-// if( ii == m_name2index.end() )
-// {
-// OUStringBuffer buf( 128 );
-// buf.appendAscii( "Column " );
-// buf.append( elementName );
-// buf.appendAscii( " is unknown in table " );
-// buf.append( m_schemaName );
-// buf.appendAscii( "." );
-// buf.append( m_tableName );
-// buf.appendAscii( ", so it can't be dropped" );
-// throw com::sun::star::container::NoSuchElementException(
-// buf.makeStringAndClear(), *this );
-// }
-// dropByIndex( ii->second );
-// }
 
 void Columns::dropByIndex( sal_Int32 index )
 throw (::com::sun::star::sdbc::SQLException,
@@ -592,8 +465,6 @@
 return ret;
 }
 
-
-//_
 ColumnDescriptors::ColumnDescriptors(
 const ::rtl::Reference< RefCountedMutex > & refMutex,
 const ::com::sun::star::uno::Reference< 
com::sun::star::sdbc::XConnection >  & origin,

-- 
To view, visit https://gerrit.libreoffice.org/3170
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7bc35f5e65292d2d8a9d51418760c702676e478
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build error - testFdo60915

[Marcos Souza]

Same content as Rodolfo:

export SYSTEM_ICU=NO


2013/3/22 Rodolfo 

> I have the same issue here.
>
> Yes, timezone is America/Sao Paulo.
>
> But, aside the bug report, I'm a Debian-Wheezy user.
>
> About ./config_host.mk contains:
> export SYSTEM_ICU=NO
>
> =/
>
> Att,
> Rodolfo
>
> 2013/3/22 Eike Rathke :
> > Hi Marcos,
> >
> > On Friday, 2013-03-22 17:01:12 -0300, Marcos Souza wrote:
> >
> >> AHuahUAHauhAUAHU
> >>
> >> Brazil makes me laught in LO too T.T
> >
> > Glad you had a good laugh ;-)
> >
> >> Yes this is my timezone
> >
> > Ok, could you please tell me which ICU library version you use
> >
> > * the internally provided 49.1.1, ./config_host.mk contains
> >   SYSTEM_ICU=NO in this case
> > * a system one, which version? ./config_host.mk contains SYSTEM_ICU=YES
> >   in this case
> >
> > The version numbers are in ./config_host.mk variables ICU_MAJOR,
> > ICU_MINOR and ICU_MICRO
> >
> >   Eike
> >
> > --
> > LibreOffice Calc developer. Number formatter stricken i18n
> transpositionizer.
> > New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563
> 2D3A
> > Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C
> 05FD
> > Support the FSFE, care about Free Software!
> https://fsfe.org/support/?erack
> >
> > ___
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
> >
>



-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build error - testFdo60915

[Marcos Souza]

AHuahUAHauhAUAHU

Brazil makes me laught in LO too T.T

Yes this is my timezone


2013/3/22 Eike Rathke 

> Hi Marcos,
>
> On Friday, 2013-03-22 14:34:45 -0300, Marcos Souza wrote:
>
> > [build CXX] svx/source/unodraw/unopool.cxx
> > svl.cxx:321:Assertion
> > Test name: (anonymous namespace)::Test::testFdo60915
> > equality assertion failed
> > - Expected: 18/05/2446
> > - Actual  : 17/05/2446
>
> Let me guess, your environment is in timezone TZ=America/Sao_Paulo and
> a victim of https://bugs.freedesktop.org/show_bug.cgi?id=44286 ? Or
> something similar related..
>
> Anyhow, please try this patch
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=70f1f6cd90d8e9a571959c41f88c9ae376846d0f
>
>   Eike
>
> --
> LibreOffice Calc developer. Number formatter stricken i18n
> transpositionizer.
> New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563
> 2D3A
> Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C
> 05FD
> Support the FSFE, care about Free Software!
> https://fsfe.org/support/?erack
>



-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Build error - testFdo60915

[Marcos Souza]

Hi guys,

I'm trying to build LO with head 683142294f291a77329a2d266124432aeba8522b
and I'm getting the following error message:

[build CXX] svx/source/unodraw/unopool.cxx
svl.cxx:321:Assertion
Test name: (anonymous namespace)::Test::testFdo60915
equality assertion failed
- Expected: 18/05/2446
- Actual  : 17/05/2446

Failures !!!
Run: 2   Failure total: 1   Failures: 1   Errors: 0

Anybody knows how to solve this?

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Code pointers for replace HSQLDB for Firebird

[Marcos Souza]

Hi Lionel!


2013/3/21 Lionel Elie Mamane 

> On Thu, Mar 21, 2013 at 08:26:42AM +0100, David Ostrovsky wrote:
> > On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote:
> > > Hi guys!
> > >
> > >
> > > As suggested by Cecric and Muthu, I'm here to ask some code pointers
> > > to work in the HSQLDB replacement for Firebird.
> > >
> > >
> > > I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=51781 from
> > > Lionel, and trying to understand what needs to be done to achieve
> > > this, but some code pointers are better!
>
> > To be frankly i would divide that task in 2:
> > 1. create native connectivity driver for Firebird.
> > 2. default to Firebird driver.
>
> I'd add another step between 1 and 2:
>
> 1.5: make Firebird embedded in LibreOffice
>  subtasks:
>a) redirect Firebird "to disk" writes to our internal ZIP file
>   structure; see how it is done for HSQLDB in
>
>   connectivity/com/sun/star/sdbcx/comp/hsqldb/*.java
>   connectivity/source/drivers/hsqldb/StorageFileAccess.cxx
>   connectivity/source/drivers/hsqldb/StorageNativeInputStream.cxx
>   connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx
>
>   if that's not possible, write to some temporary file and
>   copy that into our internal zip file structure. Can we do
>   something intelligent based on mmapped files shared between
>   process or some such on each platform?
>
>b) create sdbc scheme sdbc:embedded:firebird and have it
>   recognised; "git grep -i embedded|grep -i hsql" will give
>   you code pointers.
>
>
Thanks for all these code pointers! I will read them and after I will ask
again for some information!



> --
> Lionel
>



-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Code pointers for replace HSQLDB for Firebird

[Marcos Souza]

Hi David,


2013/3/21 David Ostrovsky 

> On Wed, 2013-03-20 at 22:44 -0300, Marcos Souza wrote:
> > Hi guys!
> >
> >
> > As suggested by Cecric and Muthu, I'm here to ask some code pointers
> > to work in the HSQLDB replacement for Firebird.
> >
> >
> > I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=51781 from
> > Lionel, and trying to understand what needs to be done to achieve
> > this, but some code pointers are better!
>
> You find tons of documentation in this bug description
> https://bugs.freedesktop.org/show_bug.cgi?id=51780
>

> To be frankly i would divide that task in 2:
> 1. create native connectivity driver for Firebird.
> 2. default to Firebird driver.
>
> In connectivity/source/drivers you can find the current drivers.
> Your best choice would be to follow the newest postgresql driver.
>
> First steps would be:
> 1. create a git/gerrit branch, say feature/firebird
> 2. include firebird in our build machinery, start with system one, and
> add internal one later:
>  sudo zypper search firebird | grep devel
>  firebird-devel | UDF suppperaoort library for Firebird SQL server
>  (if you need help with setting things up, just ask on that list)
> 3. create small cpp unit test that does some CRUD operations against
> firebird and include it in the build process, so
>  make CppunitTest_connectivity_firebird
> just works (check manually that it really did with isql ;-).
> 4. create FServices, FDriver, FConnection, FStatement, FTables...
> classes for the native driver.
> 5. ask again at this point ;-)
>
>
Thanks a lot for all this information! I'll read some code of postgresql
and try to understand that code.

After some read, I will ask again about the branch and others things!


Thanks again foe the detailed explanation!


> David
>
>


-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Code pointers for replace HSQLDB for Firebird

[Marcos Souza]

Hi guys!

As suggested by Cecric and Muthu, I'm here to ask some code pointers to
work in the HSQLDB replacement for Firebird.

I'm reading https://bugs.freedesktop.org/show_bug.cgi?id=51781 from Lionel,
and trying to understand what needs to be done to achieve this, but some
code pointers are better!

I know that this task is not easy, but, if someone could help me, I believe
we can remove some Java code from base :)

Thanks since now guys!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fod#57950: Removed some chained appends from sw

[Marcos Souza (via Code Review)]

-git a/sw/source/ui/fldui/changedb.cxx b/sw/source/ui/fldui/changedb.cxx
index e4dc8e9..b5bd607 100644
--- a/sw/source/ui/fldui/changedb.cxx
+++ b/sw/source/ui/fldui/changedb.cxx
@@ -196,14 +196,10 @@
 {
 if( m_pUsedDBTLB->GetParent( pEntry ))
 {
-OUStringBuffer sTmp;
-
-sTmp.append(m_pUsedDBTLB->GetEntryText( m_pUsedDBTLB->GetParent( 
pEntry )));
-sTmp.append(DB_DELIM);
-sTmp.append(m_pUsedDBTLB->GetEntryText( pEntry ));
-sTmp.append(DB_DELIM);
-
sTmp.append(OUString::number((int)(sal_uLong)pEntry->GetUserData()));
-aDBNames.push_back(sTmp.makeStringAndClear());
+OUString sTmp(m_pUsedDBTLB->GetEntryText( m_pUsedDBTLB->GetParent( 
pEntry )) +
+  OUString(DB_DELIM) + m_pUsedDBTLB->GetEntryText( 
pEntry ) + OUString(DB_DELIM) +
+  
OUString::number((int)(sal_uLong)pEntry->GetUserData()));
+aDBNames.push_back(sTmp);
 }
 pEntry = m_pUsedDBTLB->NextSelected(pEntry);
 }
diff --git a/sw/source/ui/uiview/pview.cxx b/sw/source/ui/uiview/pview.cxx
index 9bb6018..6506dfd 100644
--- a/sw/source/ui/uiview/pview.cxx
+++ b/sw/source/ui/uiview/pview.cxx
@@ -423,11 +423,9 @@
 sal_uInt16 nVirtPageNum = mpPgPrevwLayout->GetVirtPageNumByPageNum( 
nPageNum );
 if( nVirtPageNum && nVirtPageNum != nPageNum )
 {
-aStatusStr.append( static_cast(nVirtPageNum) ).append( ' ' 
);
+aStatusStr.append( OUString::number(nVirtPageNum) + " " );
 }
-aStatusStr.append( static_cast(nPageNum) );
-aStatusStr.append( " / " );
-aStatusStr.append( static_cast(nPageCnt) );
+aStatusStr.append( OUString::number(nPageNum) + " / " + 
OUString::number(nPageCnt) );
 return aStatusStr.makeStringAndClear();
 }
 
diff --git a/sw/source/ui/uiview/viewsrch.cxx b/sw/source/ui/uiview/viewsrch.cxx
index 181a148..b6a6d68 100644
--- a/sw/source/ui/uiview/viewsrch.cxx
+++ b/sw/source/ui/uiview/viewsrch.cxx
@@ -426,10 +426,7 @@
 #if OSL_DEBUG_LEVEL > 1
 if(nSlot)
 {
-rtl::OStringBuffer sStr(RTL_CONSTASCII_STRINGPARAM("nSlot: "));
-sStr.append(static_cast(nSlot));
-sStr.append(RTL_CONSTASCII_STRINGPARAM(
-" wrong Dispatcher (viewsrch.cxx)"));
+OString sStr("nSlot: " + OString::number(nSlot) + " wrong 
Dispatcher (viewsrch.cxx)");
 OSL_FAIL(sStr.getStr());
 }
 #endif
diff --git a/sw/source/ui/utlui/content.cxx b/sw/source/ui/utlui/content.cxx
index 65c0138..9389982 100644
--- a/sw/source/ui/utlui/content.cxx
+++ b/sw/source/ui/utlui/content.cxx
@@ -3091,14 +3091,11 @@
 {
 rtl_TextEncoding eSysCSet = osl_getThreadTextEncoding();
 
-rtl::OStringBuffer sStrBuf(rtl::OUStringToOString(aUrl, eSysCSet));
-sStrBuf.append(static_cast(NAVI_BOOKMARK_DELIM));
-sStrBuf.append(rtl::OUStringToOString(aDescr, eSysCSet));
-sStrBuf.append(static_cast(NAVI_BOOKMARK_DELIM));
-sStrBuf.append(static_cast(nDefDrag));
-sStrBuf.append(static_cast(NAVI_BOOKMARK_DELIM));
-sStrBuf.append(static_cast(nDocSh));
-rData.CopyByteString(SOT_FORMATSTR_ID_SONLK, sStrBuf.makeStringAndClear());
+OString sStrBuf(OUStringToOString(aUrl, eSysCSet) + 
OString(NAVI_BOOKMARK_DELIM) +
+OUStringToOString(aDescr, eSysCSet) + 
OString(NAVI_BOOKMARK_DELIM) +
+OString::number(nDefDrag) + OString(NAVI_BOOKMARK_DELIM) +
+OString(nDocSh));
+rData.CopyByteString(SOT_FORMATSTR_ID_SONLK, sStrBuf);
 }
 
 sal_Bool NaviContentBookmark::Paste( TransferableDataHelper& rData )
diff --git a/sw/source/ui/wrtsh/wrtundo.cxx b/sw/source/ui/wrtsh/wrtundo.cxx
index 7760525..88da0d6 100644
--- a/sw/source/ui/wrtsh/wrtundo.cxx
+++ b/sw/source/ui/wrtsh/wrtundo.cxx
@@ -114,10 +114,9 @@
 default:;//prevent warning
 }
 
-::rtl::OUStringBuffer buf = ::rtl::OUStringBuffer( String( SvtResId( 
nResStr ) ) );
-buf.append(aUndoStr);
+OUStringBuffer buf = ::rtl::OUStringBuffer( String( SvtResId( nResStr ) ) 
);
 
-return buf.makeStringAndClear();
+return buf.makeStringAndClear() + aUndoStr;
 }
 
 sal_uInt16 SwWrtShell::GetDoStrings( DoType eDoType, SfxStringListItem& rStrs 
) const
@@ -134,12 +133,11 @@
 default:;//prevent warning
 }
 
-::rtl::OUStringBuffer buf;
+OUStringBuffer buf;
 for (size_t i = 0; i < comments.size(); ++i)
 {
 OSL_ENSURE(!comments[i].isEmpty(), "no Undo/Redo Text set");
-buf.append(comments[i]);
-buf.append(sal_Unicode('\n'));
+buf.append(comments[i] + "\n");
 }
 rStrs.SetString(buf.makeStringAndClear());
 return static_cast(comments.size());
@@ -156,8 +154,7 @@
 return str;
 }
 
-::rtl::OUStringBuffer buf( String(SvtResId(STR_REPEAT)) );
-buf.append(str);
+::rtl::OUStringBuffer buf( String(SvtResId(STR_REPEAT)) + str);
 return buf.makeStringAndClear();
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/2643
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b78b4a8f2fc0fb0c4a67042ac4924e375c2d63a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Removed last RTL_CONST* macros from codemaker

[Marcos Souza (via Code Review)]

CppuOptions* pOptions)
 throw( CannotDumpException )
 {
-if (typeName.equals("/") || typeName.equals(typeMgr.getBase()) ||
+if (typeName == "/" || typeName == typeMgr.getBase() ||
 TypeManager::isBaseType(typeName) || generated.contains(typeName))
 {
 return true;
@@ -4425,7 +4425,7 @@
 {
 OString typeName = typeMgr.getTypeName(rTypeKey);
 
-if (typeName.equals("/") ||typeName.equals(typeMgr.getBase()) ||
+if (typeName == "/" ||typeName == typeMgr.getBase() ||
 TypeManager::isBaseType(typeName) || generated.contains(typeName))
 {
 return true;
diff --git a/codemaker/source/javamaker/classfile.cxx 
b/codemaker/source/javamaker/classfile.cxx
index e9d1b91..0f115b2 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -475,9 +475,7 @@
 m_superClass = addClassInfo(superClass);
 if (!signature.isEmpty()) {
 ++m_attributesCount;
-appendU2(
-m_attributes,
-
addUtf8Info(rtl::OString(RTL_CONSTASCII_STRINGPARAM("Signature";
+appendU2(m_attributes, addUtf8Info("Signature"));
 appendU4(m_attributes, 2);
 appendU2(m_attributes, addUtf8Info(signature));
 }
@@ -582,10 +580,7 @@
 ((constantValueIndex == 0 ? 0 : 1)
  + (signature.isEmpty() ? 0 : 1)));
 if (constantValueIndex != 0) {
-appendU2(
-m_fields,
-addUtf8Info(
-rtl::OString(RTL_CONSTASCII_STRINGPARAM("ConstantValue";
+appendU2(m_fields, addUtf8Info("ConstantValue"));
 appendU4(m_fields, 2);
 appendU2(m_fields, constantValueIndex);
 }
@@ -624,9 +619,7 @@
 {
 throw CannotDumpException("Code block is too big for Java class 
file format");
 }
-appendU2(
-m_methods,
-addUtf8Info(rtl::OString(RTL_CONSTASCII_STRINGPARAM("Code";
+appendU2(m_methods, addUtf8Info("Code"));
 appendU4(
 m_methods,
 (2 + 2 + 4 + static_cast< sal_uInt32 >(codeSize) + 2
@@ -640,10 +633,7 @@
 appendU2(m_methods, 0);
 }
 if (!exceptions.empty()) {
-appendU2(
-m_methods,
-addUtf8Info(
-rtl::OString(RTL_CONSTASCII_STRINGPARAM("Exceptions";
+appendU2(m_methods, addUtf8Info("Exceptions"));
 appendU4(
 m_methods,
 static_cast< sal_uInt32 >(2 + 2 * static_cast< sal_uInt32 
>(excs)));
@@ -848,9 +838,7 @@
 std::vector< unsigned char > & stream, rtl::OString const & signature)
 {
 if (!signature.isEmpty()) {
-appendU2(
-stream,
-
addUtf8Info(rtl::OString(RTL_CONSTASCII_STRINGPARAM("Signature";
+appendU2(stream, addUtf8Info("Signature"));
 appendU4(stream, 2);
 appendU2(stream, addUtf8Info(signature));
 }
diff --git a/codemaker/source/javamaker/javamaker.cxx 
b/codemaker/source/javamaker/javamaker.cxx
index af4796d..182eb2d 100644
--- a/codemaker/source/javamaker/javamaker.cxx
+++ b/codemaker/source/javamaker/javamaker.cxx
@@ -179,7 +179,7 @@
 if (tmpName == "*")
 {
 // produce this type and his scope.
-if (typeName.equals("*"))
+if (typeName == "*")
 {
 tmpName = "/";
 } else
diff --git a/codemaker/source/javamaker/javatype.cxx 
b/codemaker/source/javamaker/javatype.cxx
index b5662bb..108dc6c 100644
--- a/codemaker/source/javamaker/javatype.cxx
+++ b/codemaker/source/javamaker/javatype.cxx
@@ -2474,9 +2474,7 @@
 codemaker::GeneratedTypeSet & generated, JavaOptions * options)
 {
 OSL_ASSERT(options != 0);
-if (type.equals("/")
-|| type.equals(manager.getBase())
-|| generated.contains(type))
+if (type == "/" || type == manager.getBase() || generated.contains(type))
 {
 return true;
 }
@@ -2548,9 +2546,7 @@
 ::rtl::OString typeName = manager.getTypeName(rTypeKey);
 
 OSL_ASSERT(options != 0);
-if (typeName.equals("/")
-|| typeName.equals(manager.getBase())
-|| generated.contains(typeName))
+if (typeName == "/" || typeName == manager.getBase() || 
generated.contains(typeName))
 {
 return true;
 }

-- 
To view, visit https://gerrit.libreoffice.org/2605
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ce4fd2cc7c62a18e059e945b42cc01425802aa0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57950: Remove chained appends in codemaker

[Marcos Souza (via Code Review)]

not create "));
-msg.append(filename);
-msg.append(RTL_CONSTASCII_STRINGPARAM(" from temporary file "));
-msg.append(tempname);
-throw CannotDumpException(msg.makeStringAndClear());
+throw CannotDumpException("Cannot create " + filename + " from 
temporary file " + tempname);
 }
 }
 
@@ -1029,13 +1010,8 @@
 SpecialType specialType;
 PolymorphicUnoType polymorphicUnoType;
 if (typeParameterIndex >= 0) {
-descriptor = rtl::OString(
-RTL_CONSTASCII_STRINGPARAM("Ljava/lang/Object;"));
-rtl::OStringBuffer buf;
-buf.append('T');
-buf.append(type);
-buf.append(';');
-signature = buf.makeStringAndClear();
+descriptor = "Ljava/lang/Object;";
+signature = "T" + type + ";";
 specialType = SPECIAL_TYPE_NONE; //TODO: SPECIAL_TYPE_TYPE_PARAMETER?
 } else {
 specialType = getFieldDescriptor(
@@ -1894,26 +1870,21 @@
 if (reader.getReferenceFlags(i) != RT_ACCESS_INVALID
 || reader.getReferenceSort(i) != RT_REF_TYPE_PARAMETER)
 {
-throw CannotDumpException(
-rtl::OString(
-RTL_CONSTASCII_STRINGPARAM("Bad type information")));
+throw CannotDumpException("Bad type information");
 //TODO
 }
 rtl::OString name(
 codemaker::convertString(reader.getReferenceTypeName(i)));
-buf.append(name);
-buf.append(RTL_CONSTASCII_STRINGPARAM(":Ljava/lang/Object;"));
+buf.append(name + ":Ljava/lang/Object;");
 if (!typeParameters.insert(
 std::map< rtl::OString, sal_Int32 >::value_type(name, i)).
 second)
 {
-throw CannotDumpException(
-rtl::OString(
-RTL_CONSTASCII_STRINGPARAM("Bad type information")));
+throw CannotDumpException("Bad type information");
 //TODO
 }
 }
-buf.append(RTL_CONSTASCII_STRINGPARAM(">Ljava/lang/Object;"));
+buf.append(">Ljava/lang/Object;");
 sig = buf.makeStringAndClear();
 }
 SAL_WNODEPRECATED_DECLARATIONS_PUSH
@@ -2571,9 +2542,7 @@
 rtl::OString(RTL_CONSTASCII_STRINGPARAM("Bad type information")));
 //TODO
 }
-rtl::OStringBuffer buf(codemaker::convertString(reader.getTypeName()));
-buf.append('/');
-rtl::OString prefix(buf.makeStringAndClear());
+rtl::OString prefix(codemaker::convertString(reader.getTypeName()) + "/");
 sal_uInt16 fields = reader.getFieldCount();
 for (sal_uInt16 i = 0; i < fields; ++i) {
 rtl::OString className(
@@ -2774,15 +2743,8 @@
 // stack: ex
 code->instrDup();
 // stack: ex ex
-rtl::OStringBuffer msg;
-msg.append(
-RTL_CONSTASCII_STRINGPARAM(
-"component context fails to supply service "));
-msg.append(unoName);
-msg.append(RTL_CONSTASCII_STRINGPARAM(" of type "));
-msg.append(realJavaBaseName);
-msg.append(RTL_CONSTASCII_STRINGPARAM(": "));
-code->loadStringConstant(msg.makeStringAndClear());
+code->loadStringConstant("component context fails to supply service " 
+ unoName +
+ " of type " + realJavaBaseName + ": ");
 // stack: ex ex "..."
 code->loadLocalReference(1);
 // stack: ex ex "..." str
@@ -2957,14 +2919,8 @@
 // stack: ex
 code->instrDup();
 // stack: ex ex
-rtl::OStringBuffer msg;
-msg.append(
-RTL_CONSTASCII_STRINGPARAM(
-"component context fails to supply service "));
-msg.append(unoName);
-msg.append(RTL_CONSTASCII_STRINGPARAM(" of type "));
-msg.append(realJavaBaseName);
-code->loadStringConstant(msg.makeStringAndClear());
+code->loadStringConstant("component context fails to supply 
service " + unoName +
+ " of type " + realJavaBaseName);
     // stack: ex ex "..."
 code->loadLocalReference(1);
 // stack: ex ex "..." context
@@ -3152,14 +3108,8 @@
 // stack: ex
 code->instrDup();
 // stack: ex ex
-rtl::OStringBuffer msg;
-msg.append(
-RTL_CONSTASCII_STRINGPARAM(
-"component context fails to supply singleton "));
-msg.append(unoName);
-msg.append(RTL_CONSTASCII_STRINGPARAM(" of type "));
-msg.append(realJavaBaseName);
-code->loadStringConstant(msg.makeStringAndClear());
+code->loadStringConstant("component context fails to supply singleton " + 
unoName +
+ " of type " + realJavaBaseName);
 // stack: ex ex "..."
 code->loadLocalReference(0);
 // stack: ex ex "..." context

-- 
To view, visit https://gerrit.libreoffice.org/2583
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I338e1c0e88558124741c6202896355533535a129
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#61513: Remove FSysFailOnErrorImpl macro

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2535

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/2535/1

fdo#61513: Remove FSysFailOnErrorImpl macro

This patch removes all used of this useless macro.

Change-Id: Ib3842ef28ea676e75b18c192f8d9610dcb3c3d0c
---
M tools/source/fsys/dirent.cxx
M tools/source/fsys/tdir.cxx
M tools/source/fsys/unx.hxx
M tools/source/fsys/wntmsc.cxx
M tools/source/fsys/wntmsc.hxx
5 files changed, 0 insertions(+), 18 deletions(-)



diff --git a/tools/source/fsys/dirent.cxx b/tools/source/fsys/dirent.cxx
index c4ae7a9..d00ed7c 100644
--- a/tools/source/fsys/dirent.cxx
+++ b/tools/source/fsys/dirent.cxx
@@ -768,7 +768,6 @@
 return sal_True;
 #endif
 
-FSysFailOnErrorImpl();
 DirEntryKind eKind = FileStat( *this, nAccess ).GetKind();
 if ( eKind & ( FSYS_KIND_FILE | FSYS_KIND_DIR ) )
 {
@@ -787,8 +786,6 @@
 
 sal_Bool DirEntry::First()
 {
-FSysFailOnErrorImpl();
-
 StringaUniPathName( GetPath().GetFull() );
 rtl::OString aPathName(rtl::OUStringToOString(aUniPathName, 
osl_getThreadTextEncoding()));
 
@@ -1454,7 +1451,6 @@
 return sal_True;
 else
 {
-FSysFailOnErrorImpl();
 String aDirName(pNewDir->GetFull());
 rtl::OString 
bDirName(rtl::OUStringToOString(aDirName, osl_getThreadTextEncoding()));
 
@@ -1518,7 +1514,6 @@
 return FSYS_ERR_ALREADYEXISTS;
 }
 
-FSysFailOnErrorImpl();
 String aFrom( GetFull() );
 
 String aTo( aDest.GetFull() );
@@ -1649,7 +1644,6 @@
 DBG_CHKTHIS( DirEntry, ImpCheckDirEntry );
 
 FSysError eError = FSYS_ERR_OK;
-FSysFailOnErrorImpl();
 
 // Terminate name string with two '0'
 String aTmpName( GetFull() );
diff --git a/tools/source/fsys/tdir.cxx b/tools/source/fsys/tdir.cxx
index b33c9cf..5e6ed05 100644
--- a/tools/source/fsys/tdir.cxx
+++ b/tools/source/fsys/tdir.cxx
@@ -289,7 +289,6 @@
 {
 
 sal_uInt16 nRead = 0; // Number of read entries in this round
-FSysFailOnErrorImpl();
 
 // did not complete
 if ( pReader )
diff --git a/tools/source/fsys/unx.hxx b/tools/source/fsys/unx.hxx
index 9728d71..8a3ee3b 100644
--- a/tools/source/fsys/unx.hxx
+++ b/tools/source/fsys/unx.hxx
@@ -71,8 +71,6 @@
 rDate = Date( pTime->tm_mday, pTime->tm_mon + 1, pTime->tm_year + 1900 );
 }
 
-#define FSysFailOnErrorImpl()
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/tools/source/fsys/wntmsc.cxx b/tools/source/fsys/wntmsc.cxx
index 7c74ed4..f6c9e0e 100644
--- a/tools/source/fsys/wntmsc.cxx
+++ b/tools/source/fsys/wntmsc.cxx
@@ -114,7 +114,6 @@
 char *pOld;
 rtl::OString aFullName(rtl::OUStringToOString(GetFull(),
 osl_getThreadTextEncoding()));
-FSysFailOnErrorImpl();
 if ( GetFullPathName(aFullName.getStr(), 256, sBuf, &pOld) > 511 )
 return sal_False;
 
@@ -143,7 +142,6 @@
 DWORD nMaxCompLen[2];
 DWORD nFlags[2];
 rtl::OString aRootDir = pTop->aName;
-FSysFailOnErrorImpl();
 
 // Try network device first due to slow samba drives
 if ( !WNetGetConnection( aRootDir.getStr(),
@@ -168,8 +166,6 @@
 sal_Bool DirEntry::SetCWD( sal_Bool bSloppy ) const
 {
 DBG_CHKTHIS( DirEntry, ImpCheckDirEntry );
-
-FSysFailOnErrorImpl();
 
 if ( eFlag == FSYS_FLAG_CURRENT && !aName.getLength() )
 return sal_True;
@@ -593,9 +589,6 @@
 nError = FSYS_ERR_OK;
 return sal_True;
 }
-
-// Don't show error boxes
-FSysFailOnErrorImpl();
 
 // Redirect
 String aPath( rDirEntry.GetFull() );
diff --git a/tools/source/fsys/wntmsc.hxx b/tools/source/fsys/wntmsc.hxx
index bb1dbac..bf83941 100644
--- a/tools/source/fsys/wntmsc.hxx
+++ b/tools/source/fsys/wntmsc.hxx
@@ -63,8 +63,6 @@
 return GetDriveType( aDriveRoot.getStr() ) > 1;
 }
 
-#define FSysFailOnErrorImpl()
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

-- 
To view, visit https://gerrit.libreoffice.org/2535
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3842ef28ea676e75b18c192f8d9610dcb3c3d0c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove not needed function in calc

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2187

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2187/1

Remove not needed function in calc

Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
---
M sc/source/ui/collab/sendfunc.hxx
1 file changed, 7 insertions(+), 15 deletions(-)



diff --git a/sc/source/ui/collab/sendfunc.hxx b/sc/source/ui/collab/sendfunc.hxx
index f7fcca9..6bd9a1e 100644
--- a/sc/source/ui/collab/sendfunc.hxx
+++ b/sc/source/ui/collab/sendfunc.hxx
@@ -34,17 +34,12 @@
 // method name ';' then arguments ; separated
 class ScChangeOpWriter
 {
-rtl::OUStringBuffer aMessage;
-void appendSeparator()
-{
-aMessage.append( sal_Unicode( ';' ) );
-}
+OUStringBuffer aMessage;
 
 public:
 ScChangeOpWriter( const char *pName )
 {
-aMessage.appendAscii( pName );
-appendSeparator();
+aMessage.append( OUString(pName ) + ";");
 }
 
 void appendString( const rtl::OUString &rStr )
@@ -58,27 +53,24 @@
 }
 else
 aMessage.append( rStr );
-appendSeparator();
+aMessage.append(";");
 }
 
 void appendAddress( const ScAddress &rPos )
 {
-rtl::OUString aStr;
+OUString aStr;
 rPos.Format( aStr, SCA_VALID );
-aMessage.append( aStr );
-appendSeparator();
+aMessage.append( aStr + ";" );
 }
 
 void appendInt( sal_Int32 i )
 {
-aMessage.append( i );
-appendSeparator();
+aMessage.append( OUString::number(i) + ";" );
 }
 
 void appendBool( sal_Bool b )
 {
-aMessage.appendAscii( b ? "true" : "false" );
-appendSeparator();
+aMessage.append( OUString(b ? "true" : "false" ) + ";";
 }
 
 void appendCell( ScBaseCell *pCell )

-- 
To view, visit https://gerrit.libreoffice.org/2187
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57950: Remove more chained appends in filter

[Marcos Souza (via Code Review)]

);
-OUStringBuffer sType;
-sType.append(static_cast(nType));
+OUStringBuffer sType(OUString::number(nType));
 if (pAction && (nType == META_COMMENT_ACTION))
 {
 sType.append(": ");
@@ -2944,9 +2943,8 @@
 rtl::OString sComment = pA->GetComment();
 if (!sComment.isEmpty())
 {
-OUString ssComment = OUString( sComment.getStr(),
+sType.append(OUString( sComment.getStr(),
 sComment.getLength(), RTL_TEXTENCODING_UTF8 );
-sType.append(ssComment);
 }
 if (sComment.equalsIgnoreAsciiCaseL(
 RTL_CONSTASCII_STRINGPARAM("FIELD_SEQ_BEGIN")))
diff --git a/filter/source/svg/test/odfserializer.cxx 
b/filter/source/svg/test/odfserializer.cxx
index 77c9971..fbba017 100644
--- a/filter/source/svg/test/odfserializer.cxx
+++ b/filter/source/svg/test/odfserializer.cxx
@@ -76,32 +76,19 @@
 void SAL_CALL ODFSerializer::startElement( const ::rtl::OUString& aName,
const uno::Reference< 
xml::sax::XAttributeList >& xAttribs ) throw (xml::sax::SAXException, 
uno::RuntimeException)
 {
-rtl::OUStringBuffer aElement;
-aElement.appendAscii("<");
-aElement.append(aName);
-aElement.appendAscii(" ");
+OUStringBuffer aElement("<" + aName + " ");
 
 const sal_Int16 nLen=xAttribs->getLength();
 for( sal_Int16 i=0; igetNameByIndex(i));
-aElement.appendAscii("=\"");
-aElement.append(xAttribs->getValueByIndex(i));
-aElement.appendAscii("\" ");
-}
+aElement.append(xAttribs->getNameByIndex(i) + "=\"" +
+xAttribs->getValueByIndex(i) + "\" ");
 
-aElement.appendAscii(">");
-characters(aElement.makeStringAndClear());
+characters(aElement.makeStringAndClear() + ">");
 }
 
 void SAL_CALL ODFSerializer::endElement( const ::rtl::OUString& aName ) throw 
(xml::sax::SAXException, uno::RuntimeException)
 {
-rtl::OUStringBuffer aElement;
-aElement.appendAscii("");
-characters(aElement.makeStringAndClear());
+characters("");
 }
 
 void SAL_CALL ODFSerializer::characters( const ::rtl::OUString& aChars ) throw 
(xml::sax::SAXException, uno::RuntimeException)
diff --git a/filter/source/xsltfilter/XSLTFilter.cxx 
b/filter/source/xsltfilter/XSLTFilter.cxx
index 30f7e0d..a16627f 100644
--- a/filter/source/xsltfilter/XSLTFilter.cxx
+++ b/filter/source/xsltfilter/XSLTFilter.cxx
@@ -241,9 +241,7 @@
 Exception e;
 if (a >>= e)
 {
-rtl::OStringBuffer 
aMessage(RTL_CONSTASCII_STRINGPARAM("XSLTFilter::error was called: "));
-aMessage.append(rtl::OUStringToOString(e.Message, 
RTL_TEXTENCODING_ASCII_US));
-OSL_FAIL(aMessage.getStr());
+OSL_FAIL("XSLTFilter::error was called: " + 
OUStringToOString(e.Message, RTL_TEXTENCODING_ASCII_US));
 }
 m_bError = sal_True;
 osl_setCondition(m_cTransformed);

-- 
To view, visit https://gerrit.libreoffice.org/2186
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I338b18981e1f925d76c0d640159de30bab219122
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Help with fdo#60471

[Marcos Souza]

I tried to get the error message from uno::Exception using a SAL_WARN, but
this is the message:

[ line 4]: error

This don't say anything to me : )


2013/2/12 Marcos Souza 

> Hi Kendy and list!
>
> This is the point where we get this issue:
>
> // finally, parse the stream to a hierarchy of
> // SVGGraphicPrimitive2D which will be embedded to the
> // primitive sequence. Their decompositions will in the
> // end create local low-level primitives, thus SVG will
> // be processable from all our processors
> xParser->parseStream(myInputSource);
>
> I will take a look at this more closer, and try to understand why this
> happens
>
> Thanks a lot Kendy for the tip about debug=true!!
>
>
> 2013/2/12 Jan Holesovsky 
>
>> Hi Marcos,
>>
>> Marcos Souza píše v Út 12. 02. 2013 v 16:04 -0200:
>>
>> > I was trying to solve this issue, but I need some code pointers...
>> >
>> > Can you guys point to me some places to start?
>>
>> Yes - so please rebuild svgio with debugging info (make svgio.clean ;
>> make debug=true svgio), and when you open the presentation from the bug,
>> it seems to produce:
>>
>> warn:legacy.osl:52198:1:svgio/source/svguno/xsvgparser.cxx:147: Parse
>> error (!)
>>
>> I guess it might be related - I'd put a breakpoint in
>>
>> svgio/source/svguno/xsvgparser.cxx
>>
>> and I'd try to catch the exception that is being thrown there during the
>> parsing - hopefully that will lead you to the cause; if not, please poke
>> for more pointers :-)
>>
>> All the best,
>> Kendy
>>
>>
>>
>
>
> --
> Att,
>
> Marcos Paulo de Souza
> Acadêmico de Ciencia da Computação - FURB - SC
> Github: https://github.com/marcosps/
> "Uma vida sem desafios é uma vida sem razão"
> "A life without challenges, is a non reason life"
>



-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Help with fdo#60471

[Marcos Souza]

Hi Kendy and list!

This is the point where we get this issue:

// finally, parse the stream to a hierarchy of
// SVGGraphicPrimitive2D which will be embedded to the
// primitive sequence. Their decompositions will in the
// end create local low-level primitives, thus SVG will
// be processable from all our processors
xParser->parseStream(myInputSource);

I will take a look at this more closer, and try to understand why this
happens

Thanks a lot Kendy for the tip about debug=true!!


2013/2/12 Jan Holesovsky 

> Hi Marcos,
>
> Marcos Souza píše v Út 12. 02. 2013 v 16:04 -0200:
>
> > I was trying to solve this issue, but I need some code pointers...
> >
> > Can you guys point to me some places to start?
>
> Yes - so please rebuild svgio with debugging info (make svgio.clean ;
> make debug=true svgio), and when you open the presentation from the bug,
> it seems to produce:
>
> warn:legacy.osl:52198:1:svgio/source/svguno/xsvgparser.cxx:147: Parse
> error (!)
>
> I guess it might be related - I'd put a breakpoint in
>
> svgio/source/svguno/xsvgparser.cxx
>
> and I'd try to catch the exception that is being thrown there during the
> parsing - hopefully that will lead you to the cause; if not, please poke
> for more pointers :-)
>
> All the best,
> Kendy
>
>
>


-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Help with fdo#60471

[Marcos Souza]

Hi guys!

I was trying to solve this issue, but I need some code pointers...

Can you guys point to me some places to start?

And one more thing, there is a place for "learn" how UNO works and how this
is used inside LO? I believe UNO is used in every case that we handle files
right?

Thanks since now!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57950: Remove some chained appends in filter

[Marcos Souza (via Code Review)]

 css::uno::Reference< 
css::uno::XInterface >());
+OUString sMsg("item \"" + pItems[i] + "\" not found for 
update!");
+throw css::uno::Exception(sMsg, css::uno::Reference< 
css::uno::XInterface >());
 }
 try
 {
@@ -1680,14 +1642,10 @@
 return;
 ::rtl::OUString sName = rItem.getUnpackedValueOrDefault(PROPNAME_NAME, 
::rtl::OUString());
 
-::rtl::OUStringBuffer sMsg(256);
-sMsg.appendAscii("Fallback scenario for filter or type '"   );
-sMsg.append (sName  );
-sMsg.appendAscii("' and locale '"   );
-sMsg.append (sActLocale );
-sMsg.appendAscii("' failed. Please check your filter configuration.");
+OUString sMsg("Fallback scenario for filter or type '" + sName + "' 
and locale '" +
+  sActLocale + "' failed. Please check your filter 
configuration.");
 
-OSL_FAIL(_FILTER_CONFIG_TO_ASCII_(sMsg.makeStringAndClear()));
+OSL_FAIL(_FILTER_CONFIG_TO_ASCII_(sMsg));
 #endif
 return;
 }
@@ -1745,12 +1703,8 @@
 css::uno::Any aVal = xSet->getByName(sItem);
 if (!(aVal >>= xItem) || !xItem.is())
 {
-::rtl::OUStringBuffer sMsg(256);
-sMsg.appendAscii("found corrupted item \"");
-sMsg.append (sItem);
-sMsg.appendAscii("\".");
-throw css::uno::Exception(sMsg.makeStringAndClear()
,
-  css::uno::Reference< 
css::uno::XInterface >());
+OUString sMsg("found corrupted item \"" + sItem + "\".");
+throw css::uno::Exception(sMsg, css::uno::Reference< 
css::uno::XInterface >());
 }
 #ifdef WORKAROUND_EXCEPTION_PROBLEM
 }
diff --git a/filter/source/config/cache/filterfactory.cxx 
b/filter/source/config/cache/filterfactory.cxx
index d55b3c4..020fd13 100644
--- a/filter/source/config/cache/filterfactory.cxx
+++ b/filter/source/config/cache/filterfactory.cxx
@@ -199,10 +199,8 @@
 if (pos != -1)
 {
 OSL_FAIL("DEPRECATED!\nPlease use new query format: 
'matchByDocumentService=...'");
-::rtl::OUStringBuffer sPatchedQuery(256);
-sPatchedQuery.appendAscii("matchByDocumentService=");
-sPatchedQuery.append (sNewQuery.copy(7));
-sNewQuery = sPatchedQuery.makeStringAndClear();
+OUString sPatchedQuery("matchByDocumentService=" + sNewQuery.copy(7));
+sNewQuery = sPatchedQuery;
 }
 
 // analyze query and split it into its tokens
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 36fc03f..8ba1446 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -138,15 +138,8 @@
 rColorStr = "none";
 else
 {
-::rtl::OUStringBuffer aStyle;
-aStyle.appendAscii( "rgb(" );
-aStyle.append( (sal_Int32) rColor.GetRed() );
-aStyle.appendAscii( "," );
-aStyle.append( (sal_Int32) rColor.GetGreen() );
-aStyle.appendAscii( "," );
-aStyle.append( (sal_Int32) rColor.GetBlue() );
-aStyle.appendAscii( ")" );
-rColorStr = aStyle.makeStringAndClear();
+rColorStr = "rgb(" + OUString::number(rColor.GetRed()) + "," + 
OUString::number(rColor.GetGreen()) +
+"," + OUString::number(rColor.GetBlue()) + ")";
 }
 }
 
@@ -2871,8 +2864,7 @@
 PointaPt;
 Size aSz;
 Sequence< sal_Int8 > aSeq( (sal_Int8*) aOStm.GetData(), 
aOStm.Tell() );
-rtl::OUStringBuffer aBuffer;
-aBuffer.appendAscii( "data:image/png;base64," );
+OUStringBuffer aBuffer( "data:image/png;base64," );
 ::sax::Converter::encodeBase64( aBuffer, aSeq );
 
 if( bApplyMapping )
diff --git a/helpcontent2 b/helpcontent2
index f614280..5df1183 16
--- a/helpcontent2
+++ b/helpcontent2
-Subproject commit f6142808eb98d363d48a0c661206f98571df0203
+Subproject commit 5df11836790b705261ba5cc72f3e52a4569472a4

-- 
To view, visit https://gerrit.libreoffice.org/2117
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2386eb47ad7190d626966020e96c1a7ddc07ab4a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Base tests are disabled?

[Marcos Souza]

Hi guys,

while I was looking some code that implement it's own version of
createFileURL, I saw that dbaccess have some test files, but it seems
that's disabled:

[marcos@jedi core]$ make dbaccess.subsequentcheck
cd dbaccess && make -j 2 -rs subsequentcheck
/mnt/dados/gitroot/core/solenv/gbuild/Package.mk:44: ***
gb_Deliver_deliver: file does not exist in solver, and cannot be delivered:
/mnt/dados/gitroot/core/solver/unxlngi6/bin/ConnectivityTools.jar.  Stop.
make: *** [dbaccess.subsequentcheck] Error 2

There is something that we can do for enable these tests again? Or threy're
useless(I doubt...)?

Thanks guys!!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Change in core[master]: Use a method from UnoApitest instead of implement a new one ...

[Marcos Souza (via Code Review)]

ing aSep(RTL_CONSTASCII_USTRINGPARAM("/"));
-rtl::OUStringBuffer aBuffer( getSrcRootURL() );
-rtl::OUString aFileExtension(RTL_CONSTASCII_USTRINGPARAM("ods"));
-aBuffer.append(m_aBaseString).append(aSep);
-aBuffer.append(aFileBase);
-rFilePath = aBuffer.makeStringAndClear();
+rFilePath = getSrcRootURL() + m_aBaseString + "/" + aFileBase;
 }
 
 void UnoApiTest::closeDocument( uno::Reference< lang::XComponent > xDocument )

-- 
To view, visit https://gerrit.libreoffice.org/1923
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic02f13777503729ac70da590f4a42866f17ea9b2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Same function implemented 6 times in calc tests

[Marcos Souza]

Hi guys!

While I was looking at some STRINGPARAM macros in calc, I saw the function
createFileURL is implemented several times:

http://opengrok.libreoffice.org/search?q=void+createFileURL&project=core&defs=&refs=&path=sc&hist=

And they are all equal. In UnoApiTest exists a createFileURL too, and this
is used just in one place in all LO code...

Can I get ride of all this and make just one function and call it in every
place?

If yes, how can I proceed? Where can I create this function?

Thanks since now!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Change in core[master]: Remove more STRINGPARAM macros form dbaccess

[Marcos Souza (via Code Review)]

@@
 void SettingsExportContext::StartElement( enum 
::xmloff::token::XMLTokenEnum i_eName, const sal_Bool i_bIgnoreWhitespace )
 {
 if ( i_bIgnoreWhitespace )
-m_rDelegator.ignorableWhitespace( ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( " " ) ) );
+m_rDelegator.ignorableWhitespace( " " );
 
 m_rDelegator.startElement( impl_prefix( i_eName ) );
 }
@@ -258,7 +256,7 @@
 void SettingsExportContext::EndElement( const sal_Bool i_bIgnoreWhitespace 
)
 {
 if ( i_bIgnoreWhitespace )
-m_rDelegator.ignorableWhitespace( ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( " " ) ) );
+m_rDelegator.ignorableWhitespace( " " );
 m_rDelegator.endElement();
 }
 
@@ -398,11 +396,11 @@
 //
 const ::rtl::OUString SubComponentRecovery::getComponentsStorageName( 
const SubComponentType i_eType )
 {
-static const ::rtl::OUString s_sFormsStorageName( 
RTL_CONSTASCII_USTRINGPARAM( "forms" ) );
-static const ::rtl::OUString s_sReportsStorageName( 
RTL_CONSTASCII_USTRINGPARAM( "reports" ) );
-static const ::rtl::OUString s_sTablesStorageName( 
RTL_CONSTASCII_USTRINGPARAM( "tables" ) );
-static const ::rtl::OUString s_sQueriesStorageName( 
RTL_CONSTASCII_USTRINGPARAM( "queries" ) );
-static const ::rtl::OUString s_sRelationsStorageName( 
RTL_CONSTASCII_USTRINGPARAM( "relations" ) );
+static const OUString s_sFormsStorageName( "forms" );
+static const OUString s_sReportsStorageName( "reports" );
+static const OUString s_sTablesStorageName( "tables" );
+static const OUString s_sQueriesStorageName( "queries" );
+static const OUString s_sRelationsStorageName( "relations" );
 
 switch ( i_eType )
 {
@@ -487,11 +485,11 @@
 switch ( m_eType )
 {
 case TABLE:
-m_aCompDesc.bForEditing = sModuleIdentifier.equalsAsciiL( 
RTL_CONSTASCII_STRINGPARAM( "com.sun.star.sdb.TableDesign" ) );
+m_aCompDesc.bForEditing = sModuleIdentifier == 
"com.sun.star.sdb.TableDesign";
 break;
 
 case QUERY:
-m_aCompDesc.bForEditing = sModuleIdentifier.equalsAsciiL( 
RTL_CONSTASCII_STRINGPARAM( "com.sun.star.sdb.QueryDesign" ) );
+m_aCompDesc.bForEditing = sModuleIdentifier == 
"com.sun.star.sdb.QueryDesign";
 break;
 
 case REPORT:
@@ -534,15 +532,15 @@
 // the latter is updated only upon successful save of the design)
 Reference< XPropertySet > xDesignerProps( m_xComponent, 
UNO_QUERY_THROW );
 Sequence< PropertyValue > aCurrentQueryDesign;
-OSL_VERIFY( xDesignerProps->getPropertyValue( ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( "CurrentQueryDesign" ) ) ) >>= aCurrentQueryDesign 
);
+OSL_VERIFY( xDesignerProps->getPropertyValue( "CurrentQueryDesign" ) 
>>= aCurrentQueryDesign );
 
 // write the query design
 StorageXMLOutputStream aDesignOutput( m_rContext, i_rObjectStorage, 
lcl_getSettingsStreamName() );
 SettingsExportContext aSettingsExportContext( m_rContext, 
aDesignOutput );
 
-const ::rtl::OUString sWhitespace( ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( " " ) ) );
+const OUString sWhitespace( " " );
 
-aDesignOutput.startElement( ::rtl::OUString( 
RTL_CONSTASCII_USTRINGPARAM( "office:settings" ) ) );
+aDesignOutput.startElement( "office:settings" );
 aDesignOutput.ignorableWhitespace( sWhitespace );
 
 XMLSettingsExportHelper aSettingsExporter( aSettingsExportContext );

-- 
To view, visit https://gerrit.libreoffice.org/1878
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Only call getScDocument when needed

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1861

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/1861/1

Only call getScDocument when needed

Change-Id: I2dca76af46e63b5dd833f5a60549d4b1a7b03d84
---
M sc/source/filter/oox/stylesbuffer.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sc/source/filter/oox/stylesbuffer.cxx 
b/sc/source/filter/oox/stylesbuffer.cxx
index bb3672d..3657f9b 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -2715,11 +2715,11 @@
 if( !mbCreated )
 mbCreated = maFinalName.isEmpty();
 
-::ScDocument& rDoc = getScDocument();
 if( !mbCreated && !mpStyleSheet )
 {
 bool bCreatePattern = false;
 Xf* pXF = getStyles().getStyleXf( maModel.mnXfId ).get();
+::ScDocument& rDoc = getScDocument();
 
 bool bDefStyle = maModel.isDefaultStyle();
 if( bDefStyle )

-- 
To view, visit https://gerrit.libreoffice.org/1861
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dca76af46e63b5dd833f5a60549d4b1a7b03d84
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSoC 2013 and LO

[Marcos Souza]

Thanks guys!

I have an idea for base, and I sent an email to Muthu and to Lionel talking
abou this idea.

I'm still waiting for their response!

Thanks again!


2013/1/15 Simos Xenitellis 

> On Tue, Jan 15, 2013 at 9:01 PM, Marcos Souza
>  wrote:
> > Hi LO guys!
> >
> > Can anybody tells me when GSoC will start?
> >
>
> You can apply as a student sometime in early March.
>
> I suppose that GSoC 2013 with the full timetable will be announced
> sometime in February,
> so watch the website at http://code.google.com/soc/
>
> It helps a lot if you start preparing now.
>
> Simos
>



-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove some unneeded variables in filter

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1773

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1773/1

Remove some unneeded variables in filter

Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
---
M filter/source/graphicfilter/eps/eps.cxx
1 file changed, 7 insertions(+), 12 deletions(-)



diff --git a/filter/source/graphicfilter/eps/eps.cxx 
b/filter/source/graphicfilter/eps/eps.cxx
index 9405328..58c56f5 100644
--- a/filter/source/graphicfilter/eps/eps.cxx
+++ b/filter/source/graphicfilter/eps/eps.cxx
@@ -298,26 +298,21 @@
 
 if( pResMgr )
 {
-String aPreviewStr( "Preview" );
-String aVersionStr( "Version" );
-String aColorStr( "ColorFormat" );
-String aComprStr( "CompressionMode" );
 #ifdef UNX // don't put binary tiff preview ahead of postscript code by 
default on unix as ghostscript is unable to read it
-mnPreview = pFilterConfigItem->ReadInt32( aPreviewStr, 0 );
+mnPreview = pFilterConfigItem->ReadInt32( "Preview", 0 );
 #else
-mnPreview = pFilterConfigItem->ReadInt32( aPreviewStr, 1 );
+mnPreview = pFilterConfigItem->ReadInt32( "Preview", 1 );
 #endif
-mnLevel = pFilterConfigItem->ReadInt32( aVersionStr, 2 );
+mnLevel = pFilterConfigItem->ReadInt32( "Version", 2 );
 if ( mnLevel != 1 )
 mnLevel = 2;
-mbGrayScale = pFilterConfigItem->ReadInt32( aColorStr, 1 ) == 2;
+mbGrayScale = pFilterConfigItem->ReadInt32( "ColorFormat", 1 ) == 
2;
 #ifdef UNX // don't compress by default on unix as ghostscript is unable to 
read LZW compressed eps
-mbCompression = pFilterConfigItem->ReadInt32( aComprStr, 0 ) != 0;
+mbCompression = pFilterConfigItem->ReadInt32( "CompressionMode", 0 
) != 0;
 #else
-mbCompression = pFilterConfigItem->ReadInt32( aComprStr, 1 ) == 1;
+mbCompression = pFilterConfigItem->ReadInt32( "CompressionMode", 1 
) == 1;
 #endif
-String sTextMode( "TextMode" );
-mnTextMode = pFilterConfigItem->ReadInt32( sTextMode, 0 );
+mnTextMode = pFilterConfigItem->ReadInt32( "TextMode", 0 );
 if ( mnTextMode > 2 )
 mnTextMode = 0;
 delete pResMgr;

-- 
To view, visit https://gerrit.libreoffice.org/1773
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove more STRINGPARAM macros from dbaccess

[Marcos Souza (via Code Review)]

 
DataAccessDescriptor::getSupportedServiceNames(  ) throw (RuntimeException)
+Sequence< OUString > SAL_CALL 
DataAccessDescriptor::getSupportedServiceNames(  ) throw (RuntimeException)
 {
-Sequence< ::rtl::OUString > aServices(1);
-aServices[0] = ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.sdb.DataAccessDescriptor" ) );
+Sequence< OUString > aServices(1);
+aServices[0] = "com.sun.star.sdb.DataAccessDescriptor";
 return aServices;
 }
 
@@ -260,9 +260,9 @@
 {
 }
 
-::rtl::OUString DataAccessDescriptorFactory::getSingletonName_static()
+OUString DataAccessDescriptorFactory::getSingletonName_static()
 {
-return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.sdb.DataAccessDescriptorFactory" ) );
+return OUString( "com.sun.star.sdb.DataAccessDescriptorFactory" );
 }
 
 Sequence< ::rtl::OUString > 
DataAccessDescriptorFactory::getSupportedServiceNames_static() throw( 
RuntimeException )
@@ -272,9 +272,9 @@
 return aServices;
 }
 
-::rtl::OUString 
DataAccessDescriptorFactory::getImplementationName_static() throw( 
RuntimeException )
+OUString DataAccessDescriptorFactory::getImplementationName_static() 
throw( RuntimeException )
 {
-return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
"com.sun.star.comp.dba.DataAccessDescriptorFactory" ) );
+return OUString( "com.sun.star.comp.dba.DataAccessDescriptorFactory" );
 }
 
 Reference< XInterface > DataAccessDescriptorFactory::Create( const 
Reference< XComponentContext >& _rxContext )

-- 
To view, visit https://gerrit.libreoffice.org/1771
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57950: Remove some chained appends in connectivity and..

[Marcos Souza (via Code Review)]

id = 
ev_class "
+ "AND relkind=\'v\'" );
 
 Reference< XRow > xRow( rs , UNO_QUERY );
 
@@ -157,7 +155,7 @@
 m_values.realloc( viewIndex );
 m_values[currentViewIndex] = makeAny( prop );
 OUStringBuffer buf( table.getLength() + schema.getLength() + 
1);
-buf.append( schema ).appendAscii( "." ).append( table );
+buf.append( schema + "." + table );
 map[ buf.makeStringAndClear() ] = currentViewIndex;
 }
 }
@@ -189,10 +187,9 @@
 
 OUStringBuffer buf( 128 );
 
-buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "CREATE VIEW " ) );
+buf.append( "CREATE VIEW ");
 bufferQuoteQualifiedIdentifier( buf, schema, name, m_pSettings );
-buf.appendAscii( RTL_CONSTASCII_STRINGPARAM( " AS " ) );
-buf.append( command );
+buf.append(" AS " + command );
 
 stmt->executeUpdate( buf.makeStringAndClear() );
 
@@ -202,18 +199,6 @@
 {
 m_pSettings->pTablesImpl->refresh();
 }
-// increase the vector
-// sal_Int32 index = m_values.getLength();
-// m_values.realloc( index + 1 );
-
-// View * pView =
-// new View( m_refMutex, m_origin, m_pSettings, false /*modifiable*/ );
-// Reference< com::sun::star::beans::XPropertySet > prop = pTable;
-// copyProperties( pTable, descriptor );
-// m_values[index] = makeAny( prop );
-// OUStringBuffer buf( name.getLength() + 1 + schema.getLength() );
-// buf.append( schema ).appendAscii( "." ).append( name );
-// m_name2index[ buf.makeStringAndClear() ] = index;
 }
 
 void Views::dropByName( const ::rtl::OUString& elementName )
@@ -225,9 +210,7 @@
 if( ii == m_name2index.end() )
 {
 OUStringBuffer buf( 128 );
-buf.appendAscii( "View " );
-buf.append( elementName );
-buf.appendAscii( " is unknown, so it can't be dropped" );
+buf.append( "View " + elementName + " is unknown, so it can't be 
dropped" );
 throw com::sun::star::container::NoSuchElementException(
 buf.makeStringAndClear(), *this );
 }
@@ -239,17 +222,12 @@
::com::sun::star::lang::IndexOutOfBoundsException,
::com::sun::star::uno::RuntimeException)
 {
-// throw SQLException(
-// ASCII_STR( "view deletion not supported" ), *this, OUString(), 1, 
Any() );
 osl::MutexGuard guard( m_refMutex->mutex );
 if( index < 0 ||  index >= m_values.getLength() )
 {
 OUStringBuffer buf( 128 );
-buf.appendAscii( "VIEWS: Index out of range (allowed 0 to " );
-buf.append( (sal_Int32) (m_values.getLength() -1) );
-buf.appendAscii( ", got " );
-buf.append( index );
-buf.appendAscii( ")" );
+buf.append( "VIEWS: Index out of range (allowed 0 to " + 
OUString::number(m_values.getLength() -1) +
+", got " + OUString::number( index ) + ")");
 throw com::sun::star::lang::IndexOutOfBoundsException(
 buf.makeStringAndClear(), *this );
 }
@@ -262,8 +240,7 @@
 set->getPropertyValue( st.NAME ) >>= name;
 
 OUStringBuffer update( 128 );
-update.appendAscii( "DROP VIEW \"" ).append( schema ).appendAscii( "\".\"" 
);
-update.append( name ).appendAscii( "\"" );
+update.append( "DROP VIEW \"" + schema + "\".\"" + name + "\"" );
 
 Reference< XStatement > stmt = m_origin->createStatement( );
 

-- 
To view, visit https://gerrit.libreoffice.org/1768
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I919d17e14334c9220b47775355512df8dfa00bca
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove some RTL_* macdros from connectivity and..

[Marcos Souza (via Code Review)]

ASCII_USTRINGPARAM("TABLE_CAT")),
-ColumnValue::NULLABLE,
-0,0,0,
-DataType::VARCHAR);
-}
-// -
-void ODatabaseMetaDataResultSetMetaData::setSchemasMap()
-{
-m_mColumns[1] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("TABLE_SCHEM")),
-ColumnValue::NULLABLE,
-0,0,0,
-DataType::VARCHAR);
-}
-// -
-void ODatabaseMetaDataResultSetMetaData::setVersionColumnsMap()
-{
-   m_mColumns[1] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("SCOPE")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::INTEGER);
-m_mColumns[2] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("COLUMN_NAME")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::VARCHAR);
-m_mColumns[3] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("DATA_TYPE")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::INTEGER);
-m_mColumns[4] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("TYPE_NAME")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::VARCHAR);
-m_mColumns[5] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("COLUMN_SIZE")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::INTEGER);
-m_mColumns[6] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("BUFFER_LENGTH")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::INTEGER);
-m_mColumns[7] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("DECIMAL_DIGITS")),
-ColumnValue::NULLABLE,
-0,0,0,
-DataType::INTEGER);
-m_mColumns[8] = 
OColumn(::rtl::OUString(),::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("PSEUDO_COLUMN")),
-ColumnValue::NO_NULLS,
-0,0,0,
-DataType::INTEGER);
+m_mColumns[4] = OColumn(OUString(),"RESERVED1", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+m_mColumns[5] = OColumn(OUString(),"RESERVED2", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+m_mColumns[6] = OColumn(OUString(),"RESERVED3", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+m_mColumns[7] = OColumn(OUString(),"REMARKS", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+m_mColumns[8] = OColumn(OUString(),"PROCEDURE_TYPE", 
ColumnValue::NO_NULLS, 1,1,0, DataType::INTEGER);
 }
 
+void ODatabaseMetaDataResultSetMetaData::setTableTypes()
+{
+m_mColumns[1] = OColumn(OUString(),"TABLE_TYPE", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+}
+
+void ODatabaseMetaDataResultSetMetaData::setCatalogsMap()
+{
+m_mColumns[1] = OColumn(OUString(),"TABLE_CAT", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+}
+
+void ODatabaseMetaDataResultSetMetaData::setSchemasMap()
+{
+m_mColumns[1] = OColumn(OUString(),"TABLE_SCHEM", ColumnValue::NULLABLE, 
0,0,0, DataType::VARCHAR);
+}
+
+void ODatabaseMetaDataResultSetMetaData::setVersionColumnsMap()
+{
+   m_mColumns[1] = OColumn(OUString(),"SCOPE", ColumnValue::NO_NULLS, 0,0,0, 
DataType::INTEGER);
+m_mColumns[2] = OColumn(OUString(),"COLUMN_NAME", ColumnValue::NO_NULLS, 
0,0,0, DataType::VARCHAR);
+m_mColumns[3] = OColumn(OUString(),"DATA_TYPE", ColumnValue::NO_NULLS, 
0,0,0, DataType::INTEGER);
+m_mColumns[4] = OColumn(OUString(),"TYPE_NAME", ColumnValue::NO_NULLS, 
0,0,0, DataType::VARCHAR);
+m_mColumns[5] = OColumn(OUString(),"COLUMN_SIZE", ColumnValue::NO_NULLS, 
0,0,0, DataType::INTEGER);
+m_mColumns[6] = OColumn(OUString(),"BUFFER_LENGTH", ColumnValue::NO_NULLS, 
0,0,0, DataType::INTEGER);
+m_mColumns[7] = OColumn(OUString(),"DECIMAL_DIGITS", 
ColumnValue::NULLABLE, 0,0,0, DataType::INTEGER);
+m_mColumns[8] = OColumn(OUString(),"PSEUDO_COLUMN", ColumnValue::NO_NULLS, 
0,0,0, DataType::INTEGER);
+}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

-- 
To view, visit https://gerrit.libreoffice.org/1767
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07029055a7cbe0d1ea2e6c891e6c7347e3a370a9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice