[PATCH] bDocumentDone is always false
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3538 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3538/1 bDocumentDone is always false Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3 --- M editeng/source/misc/hangulhanja.cxx 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx index a1493fe..4f7189a 100644 --- a/editeng/source/misc/hangulhanja.cxx +++ b/editeng/source/misc/hangulhanja.cxx @@ -535,9 +535,8 @@ bool HangulHanjaConversion_Impl::ContinueConversion( bool _bRepeatCurrentUnit ) { bool bNeedUserInteraction = false; // when we leave here, do we need user interaction? -bool bDocumentDone = false; // did we already check the whole document? -while ( !bDocumentDone && !bNeedUserInteraction && implNextConvertible( _bRepeatCurrentUnit ) ) +while ( !bNeedUserInteraction && implNextConvertible( _bRepeatCurrentUnit ) ) { OUString sCurrentUnit( GetCurrentUnit() ); @@ -581,7 +580,7 @@ } } -return bDocumentDone || !bNeedUserInteraction; +return !bNeedUserInteraction; } bool HangulHanjaConversion_Impl::implGetConversionDirectionForCurrentPortion( HHC::ConversionDirection& rDirection ) -- To view, visit https://gerrit.libreoffice.org/3538 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifde4d9235d3eacf0317b19885f5ea57e1c695cb3 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Do not store return value for later, just exit
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3541 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3541/1 Do not store return value for later, just exit Change-Id: If71398ee5a29652303ae492d23e3910526307d3c --- M editeng/source/editeng/textconv.cxx 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/editeng/source/editeng/textconv.cxx b/editeng/source/editeng/textconv.cxx index e309441..b9324c5 100644 --- a/editeng/source/editeng/textconv.cxx +++ b/editeng/source/editeng/textconv.cxx @@ -96,8 +96,6 @@ } -bool bGoOn = false; - if ( m_bStartDone && m_bEndDone ) { if ( ConvMore_impl() ) // examine another document? @@ -112,9 +110,10 @@ { m_bStartChk = !m_bStartDone; ConvStart_impl( m_bStartChk ? SVX_SPELL_BODY_START : SVX_SPELL_BODY_END ); -bGoOn = true; +return true; } -return bGoOn; + +return false; } -- To view, visit https://gerrit.libreoffice.org/3541 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If71398ee5a29652303ae492d23e3910526307d3c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Prefer standard prefix for data members
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3540 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3540/1 Prefer standard prefix for data members Change-Id: Ic0d0cdc88ee17bdeeb53855162085c30b25f9004 --- M editeng/source/editeng/textconv.cxx M editeng/source/editeng/textconv.hxx 2 files changed, 88 insertions(+), 90 deletions(-) diff --git a/editeng/source/editeng/textconv.cxx b/editeng/source/editeng/textconv.cxx index 16e702a..e309441 100644 --- a/editeng/source/editeng/textconv.cxx +++ b/editeng/source/editeng/textconv.cxx @@ -52,22 +52,20 @@ bool bIsStart, EditView* pView ) : HangulHanjaConversion( pWindow, rxContext, rSourceLocale, rTargetLocale, pTargetFont, nOptions, bIsInteractive ) +, m_nConvTextLang(LANGUAGE_NONE) +, m_nUnitOffset(0) +, m_nLastPos(0) +, m_aConvSel(pView->GetSelection()) +, m_pEditView(pView) +, m_pWin(pWindow) +, m_bStartChk(false) +, m_bStartDone(bIsStart) +, m_bEndDone(false) +, m_bAllowChange(false) { DBG_ASSERT( pWindow, "TextConvWrapper: window missing" ); -nConvTextLang = LANGUAGE_NONE; -nUnitOffset = 0; - -bStartChk = false; -bStartDone = bIsStart; -bEndDone= false; -pWin= pWindow; -pEditView = pView; - -aConvSel= pEditView->GetSelection(); -aConvSel.Adjust(); // make Start <= End - -bAllowChange = false; +m_aConvSel.Adjust(); // make Start <= End } @@ -80,17 +78,17 @@ { // modified version of SvxSpellWrapper::SpellNext -if( bStartChk ) -bStartDone = true; +if( m_bStartChk ) +m_bStartDone = true; else -bEndDone = true; +m_bEndDone = true; -if ( bStartDone && bEndDone ) +if ( m_bStartDone && m_bEndDone ) { if ( ConvMore_impl() ) // examine another document? { -bStartDone = true; -bEndDone = false; +m_bStartDone = true; +m_bEndDone = false; ConvStart_impl( SVX_SPELL_BODY ); return true; } @@ -100,20 +98,20 @@ bool bGoOn = false; -if ( bStartDone && bEndDone ) +if ( m_bStartDone && m_bEndDone ) { if ( ConvMore_impl() ) // examine another document? { -bStartDone = true; -bEndDone = false; +m_bStartDone = true; +m_bEndDone = false; ConvStart_impl( SVX_SPELL_BODY ); return true; } } -else if (!aConvSel.HasRange()) +else if (!m_aConvSel.HasRange()) { -bStartChk = !bStartDone; -ConvStart_impl( bStartChk ? SVX_SPELL_BODY_START : SVX_SPELL_BODY_END ); +m_bStartChk = !m_bStartDone; +ConvStart_impl( m_bStartChk ? SVX_SPELL_BODY_START : SVX_SPELL_BODY_END ); bGoOn = true; } return bGoOn; @@ -126,7 +124,7 @@ bool bFound = false; -pWin->EnterWait(); +m_pWin->EnterWait(); bool bConvert = true; while ( bConvert ) @@ -142,7 +140,7 @@ bConvert = ConvNext_impl(); } } -pWin->LeaveWait(); +m_pWin->LeaveWait(); return bFound; } @@ -152,8 +150,8 @@ // modified version of SvxSpellWrapper::SpellMore bool bMore = false; -EditEngine* pEE = pEditView->GetEditEngine(); -ImpEditEngine* pImpEE = pEditView->GetImpEditEngine(); +EditEngine* pEE = m_pEditView->GetEditEngine(); +ImpEditEngine* pImpEE = m_pEditView->GetImpEditEngine(); ConvInfo* pConvInfo = pImpEE->GetConvInfo(); if ( pConvInfo->bMultipleDoc ) { @@ -161,7 +159,7 @@ if ( bMore ) { // The text has been entered in this engine ... -pEditView->GetImpEditView()->SetEditSelection( +m_pEditView->GetImpEditView()->SetEditSelection( pEE->GetEditDoc().GetStartPaM() ); } } @@ -173,19 +171,19 @@ { // modified version of EditSpellWrapper::SpellStart -EditEngine* pEE = pEditView->GetEditEngine(); -ImpEditEngine* pImpEE = pEditView->GetImpEditEngine(); +EditEngine* pEE = m_pEditView->GetEditEngine(); +ImpEditEngine* pImpEE = m_pEditView->GetImpEditEngine(); ConvInfo* pConvInfo = pImpEE->GetConvInfo(); if ( eArea == SVX_SPELL_BODY_START ) { // Is called when Spell-forward has reached the end, and to start over -if ( bEndDone ) +if ( m_bEndDone ) { pConvInfo->bConvToEnd = false; pConvInfo->aConvTo = pConvInfo->aConvStart; pConvInfo->aConvContinue = EPaM( 0, 0 ); -pEditView->GetImpEditView()->SetEditSelection( +m_pEditView->GetImpEditView()->SetEditSelection( pEE->GetEditDoc().GetStartPaM() ); } else @@ -199,11 +197,11 @@ { // Is called when Spell-forward starts pConvInfo->b
[PATCH] Slightly simplify loop
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3539 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3539/1 Slightly simplify loop Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1 --- M editeng/source/misc/hangulhanja.cxx 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx index 4f7189a..7d2c01e 100644 --- a/editeng/source/misc/hangulhanja.cxx +++ b/editeng/source/misc/hangulhanja.cxx @@ -534,9 +534,7 @@ bool HangulHanjaConversion_Impl::ContinueConversion( bool _bRepeatCurrentUnit ) { -bool bNeedUserInteraction = false; // when we leave here, do we need user interaction? - -while ( !bNeedUserInteraction && implNextConvertible( _bRepeatCurrentUnit ) ) +while ( implNextConvertible( _bRepeatCurrentUnit ) ) { OUString sCurrentUnit( GetCurrentUnit() ); @@ -576,11 +574,11 @@ // do not look for the next convertible: We have to wait for the user to interactivly // decide what happens with the current convertible -bNeedUserInteraction = true; +return false; } } -return !bNeedUserInteraction; +return true; } bool HangulHanjaConversion_Impl::implGetConversionDirectionForCurrentPortion( HHC::ConversionDirection& rDirection ) -- To view, visit https://gerrit.libreoffice.org/3539 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] OUString: remove namespace and chained appends
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1833 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1833/1 OUString: remove namespace and chained appends Change-Id: I1eb7e61f3151c0469db26c69439e16be0f7063df --- M sw/inc/hhcwrp.hxx M sw/source/ui/lingu/hhcwrp.cxx 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/sw/inc/hhcwrp.hxx b/sw/inc/hhcwrp.hxx index 18fcd65..be20aa2 100644 --- a/sw/inc/hhcwrp.hxx +++ b/sw/inc/hhcwrp.hxx @@ -66,7 +66,7 @@ voidSelectNewUnit_impl( const sal_Int32 nUnitStart, const sal_Int32 nUnitEnd ); voidChangeText( const String &rNewText, -const ::rtl::OUString& rOrigText, +const OUString& rOrigText, const ::com::sun::star::uno::Sequence< sal_Int32 > *pOffsets, SwPaM *pCrsr ); voidChangeText_impl( const String &rNewText, sal_Bool bKeepAttributes ); @@ -75,15 +75,15 @@ inline void SetDrawObj( sal_Bool bNew ) { m_bIsDrawObj = bNew; } protected: -virtual voidGetNextPortion( ::rtl::OUString& rNextPortion, +virtual voidGetNextPortion( OUString& rNextPortion, LanguageType& rLangOfPortion, sal_Bool bAllowImplicitChangesForNotConvertibleText ); virtual voidHandleNewUnit( const sal_Int32 nUnitStart, const sal_Int32 nUnitEnd ); virtual voidReplaceUnit( const sal_Int32 nUnitStart, const sal_Int32 nUnitEnd, -const ::rtl::OUString& rOrigText, -const ::rtl::OUString& rReplaceWith, +const OUString& rOrigText, +const OUString& rReplaceWith, const ::com::sun::star::uno::Sequence< sal_Int32 > &rOffsets, ReplacementAction eAction, LanguageType *pNewUnitLanguage ); diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index 260afda..fb0615c 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -49,7 +49,6 @@ #include -using ::rtl::OUString; using namespace ::com::sun::star; using namespace ::com::sun::star::text; using namespace ::com::sun::star::uno; @@ -169,7 +168,7 @@ void SwHHCWrapper::GetNextPortion( -::rtl::OUString&rNextPortion, +OUString& rNextPortion, LanguageType& rLangOfPortion, sal_Bool bAllowChanges ) { @@ -380,15 +379,12 @@ void SwHHCWrapper::ReplaceUnit( const sal_Int32 nUnitStart, const sal_Int32 nUnitEnd, - const ::rtl::OUString& rOrigText, + const OUString& rOrigText, const OUString& rReplaceWith, const uno::Sequence< sal_Int32 > &rOffsets, ReplacementAction eAction, LanguageType *pNewUnitLanguage ) { -static OUString aBracketedStart( "(" ); -static OUString aBracketedEnd( ")" ); - OSL_ENSURE( nUnitStart >= 0 && nUnitEnd >= nUnitStart, "wrong arguments" ); if (!(nUnitStart >= 0 && nUnitEnd >= nUnitStart)) return; @@ -413,12 +409,12 @@ break; case eReplacementBracketed : { -(((aNewTxt = aOrigTxt) += aBracketedStart) += rReplaceWith) += aBracketedEnd; +aNewTxt = aOrigTxt + "(" + rReplaceWith + ")"; } break; case eOriginalBracketed : { -(((aNewTxt = rReplaceWith) += aBracketedStart) += aOrigTxt) += aBracketedEnd; +aNewTxt = rReplaceWith + "(" + aOrigTxt + ")"; } break; case eReplacementAbove : -- To view, visit https://gerrit.libreoffice.org/1833 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1eb7e61f3151c0469db26c69439e16be0f7063df Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Prefix class data members
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1639 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/1639/1 Prefix class data members Change-Id: I6734df58b589088809c712c3906f0cee3fd6a103 --- M sw/inc/hhcwrp.hxx M sw/source/ui/lingu/hhcwrp.cxx 2 files changed, 131 insertions(+), 131 deletions(-) diff --git a/sw/inc/hhcwrp.hxx b/sw/inc/hhcwrp.hxx index 0d0c6b1..c3e1443 100644 --- a/sw/inc/hhcwrp.hxx +++ b/sw/inc/hhcwrp.hxx @@ -31,27 +31,27 @@ class SwHHCWrapper : public editeng::HangulHanjaConversion { -SwView *pView; -Window* pWin; -SwWrtShell &rWrtShell; +SwView *mpView; +Window* mpWin; +SwWrtShell &mrWrtShell; -SwConversionArgs *pConvArgs;/**< object for arguments (and results) needed +SwConversionArgs *mpConvArgs;/**< object for arguments (and results) needed to find of next convertible text portion */ -xub_StrLen nLastPos; /**< starting position of the last found text part +xub_StrLen mnLastPos; /**< starting position of the last found text part (needs to be sth that gets not moved like SwPaM or SwPosition by replace operations!) */ -sal_Int32 nUnitOffset; +sal_Int32 mnUnitOffset; -sal_uInt16 nPageCount; ///< page count for progress bar -sal_uInt16 nPageStart; ///< first checked page +sal_uInt16 mnPageCount; ///< page count for progress bar +sal_uInt16 mnPageStart; ///< first checked page -sal_BoolbIsDrawObj; -sal_BoolbIsOtherCntnt; -sal_BoolbStartChk; -sal_BoolbIsSelection; ///< true if only the selected text should be converted -sal_BoolbStartDone; -sal_BoolbEndDone; +sal_BoolmbIsDrawObj; +sal_BoolmbIsOtherCntnt; +sal_BoolmbStartChk; +sal_BoolmbIsSelection; ///< true if only the selected text should be converted +sal_BoolmbStartDone; +sal_BoolmbEndDone; /// from SvxSpellWrapper copied and modified sal_BoolConvNext_impl();///< former SpellNext @@ -71,8 +71,8 @@ SwPaM *pCrsr ); voidChangeText_impl( const String &rNewText, sal_Bool bKeepAttributes ); -inline sal_Bool IsDrawObj() { return bIsDrawObj; } -inline void SetDrawObj( sal_Bool bNew ) { bIsDrawObj = bNew; } +inline sal_Bool IsDrawObj() { return mbIsDrawObj; } +inline void SetDrawObj( sal_Bool bNew ) { mbIsDrawObj = bNew; } protected: virtual voidGetNextPortion( ::rtl::OUString& rNextPortion, diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index 03bdc7a..f1ec1d5 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -103,56 +103,56 @@ pTargetFont, nConvOptions, bIsInteractive ), -rWrtShell( pSwView->GetWrtShell() ) +mrWrtShell( pSwView->GetWrtShell() ) { -pConvArgs = 0; -nLastPos= 0; -nUnitOffset = 0; +mpConvArgs = 0; +mnLastPos = 0; +mnUnitOffset= 0; -pView = pSwView; -pWin= &pSwView->GetEditWin(); -bIsDrawObj = sal_False; -bIsOtherCntnt = bStartChk = bOther; -bIsSelection= bSelection; -bStartDone = bOther || bStart; -bEndDone= sal_False; +mpView = pSwView; +mpWin = &pSwView->GetEditWin(); +mbIsDrawObj = sal_False; +mbIsOtherCntnt = mbStartChk = bOther; +mbIsSelection = bSelection; +mbStartDone = bOther || bStart; +mbEndDone= sal_False; //bLastRet= sal_True; -nPageCount = nPageStart = 0; +mnPageCount = mnPageStart = 0; } SwHHCWrapper::~SwHHCWrapper() { -delete pConvArgs; +delete mpConvArgs; -rWrtShell.SetCareWin( NULL ); +mrWrtShell.SetCareWin( NULL ); // check for existence of a draw view which means that there are // (or previously were) draw objects present in the document. // I.e. we like to check those too. -if ( IsDrawObj() /*&& bLastRet*/ && pView->GetWrtShell().HasDrawView() ) +if ( IsDrawObj() /*&& bLastRet*/ && mpView->GetWrtShell().HasDrawView() ) { -Cursor *pSave = pView->GetWindow()->GetCursor(); +Cursor *pSave = mpView->GetWindow()->GetCursor(); { SwKeepConversionDirectionStateContext aContext; -SdrHHCWrapper aSdrConvWrap( pView, GetSourceLanguage(), +SdrHHCWrapper aSdrConvWrap( mpView, GetSourceLanguage(), GetTargetLanguage(), GetTargetFont(), GetConversionOptions(), IsInteractive() ); aSdrConvWrap.
[PATCH] Use forward declaration instead of (doubled) #include
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1642 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/1642/1 Use forward declaration instead of (doubled) #include Change-Id: I1cfb65a809e5dd56fb395c2f801bce5e5d75acfe --- M sw/inc/hhcwrp.hxx 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sw/inc/hhcwrp.hxx b/sw/inc/hhcwrp.hxx index c3e1443..1ab2251 100644 --- a/sw/inc/hhcwrp.hxx +++ b/sw/inc/hhcwrp.hxx @@ -20,12 +20,12 @@ #define _HHCWRP_HXX #include -#include class SwView; class Window; class SwWrtShell; struct SwConversionArgs; +class SwPaM; // -- To view, visit https://gerrit.libreoffice.org/1642 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1cfb65a809e5dd56fb395c2f801bce5e5d75acfe Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused #define
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1641 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/1641/1 Remove unused #define Change-Id: Ic92663d13892d7e4978b5f3a10ed7f473e091835 --- M sw/source/ui/lingu/hhcwrp.cxx 1 file changed, 0 insertions(+), 2 deletions(-) diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index 82e7d3a..4d9a0d4 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -56,8 +56,6 @@ using namespace ::com::sun::star::linguistic2; using namespace ::com::sun::star::i18n; -#define CHAR_PAR_BRK((sal_Char) 0x0D) - // // Description: Turn off frame/object shell if applicable -- To view, visit https://gerrit.libreoffice.org/1641 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic92663d13892d7e4978b5f3a10ed7f473e091835 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Character conversion: do not destroy sequence while iteratin...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1636 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/1636/1 Character conversion: do not destroy sequence while iterating on it Change-Id: Ib77e15b776384cc75880a907a6425c6105bc3fab --- M sw/source/core/txtnode/txtedt.cxx 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/sw/source/core/txtnode/txtedt.cxx b/sw/source/core/txtnode/txtedt.cxx index d5bc382..82c6cf8 100644 --- a/sw/source/core/txtnode/txtedt.cxx +++ b/sw/source/core/txtnode/txtedt.cxx @@ -74,6 +74,7 @@ #include #include +#include using rtl::OUString; using namespace ::com::sun::star; @@ -1073,6 +1074,12 @@ { SwLanguageIterator aIter( *this, nBegin ); +// Implicit changes require setting new attributes, which in turn destroys +// the attribute sequence on which aIter iterates. We store the necessary +// coordinates and apply those changes after iterating through the text. +typedef std::pair ImplicitChangesRange; +std::vector aImplicitChanges; + // find non zero length text portion of appropriate language do { nLangFound = aIter.GetLanguage(); @@ -1108,13 +1115,22 @@ if (!bIsAsianScript && rArgs.bAllowImplicitChangesForNotConvertibleText) { -SetLanguageAndFont( aCurPaM, -rArgs.nConvTargetLang, RES_CHRATR_CJK_LANGUAGE, -rArgs.pTargetFont, RES_CHRATR_CJK_FONT ); +// Store for later use +aImplicitChanges.push_back(ImplicitChangesRange(nBegin, nBegin+nLen)); } nBegin = nChPos;// start of next language portion } } while (!bFound && aIter.Next()); /* loop while nothing was found and still sth is left to be searched */ + +// Apply implicit changes, if any, now that aIter is no longer used +for (size_t i = 0; i < aImplicitChanges.size(); ++i) +{ +SwPaM aPaM( *this, aImplicitChanges[i].first ); +aPaM.SetMark(); +aPaM.GetPoint()->nContent = aImplicitChanges[i].second; +SetLanguageAndFont( aPaM, rArgs.nConvTargetLang, RES_CHRATR_CJK_LANGUAGE, rArgs.pTargetFont, RES_CHRATR_CJK_FONT ); +} + } // keep resulting text within selection / range of text to be converted -- To view, visit https://gerrit.libreoffice.org/1636 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib77e15b776384cc75880a907a6425c6105bc3fab Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused class members
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1638 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/1638/1 Remove unused class members Change-Id: I44fe6ad3dacc65e28256aca98588b7dfe92d73ae --- M sw/inc/hhcwrp.hxx M sw/source/ui/lingu/hhcwrp.cxx 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/sw/inc/hhcwrp.hxx b/sw/inc/hhcwrp.hxx index 0be12b5..0d0c6b1 100644 --- a/sw/inc/hhcwrp.hxx +++ b/sw/inc/hhcwrp.hxx @@ -47,12 +47,9 @@ sal_uInt16 nPageStart; ///< first checked page sal_BoolbIsDrawObj; -sal_BoolbIsStart; sal_BoolbIsOtherCntnt; sal_BoolbStartChk; sal_BoolbIsSelection; ///< true if only the selected text should be converted -sal_BoolbInfoBox; ///< true if message should be displayed at the end -sal_BoolbIsConvSpecial; ///< true if special regions: header, footer, ... should be converted sal_BoolbStartDone; sal_BoolbEndDone; diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index 953fdc7..03bdc7a 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -112,11 +112,8 @@ pView = pSwView; pWin= &pSwView->GetEditWin(); bIsDrawObj = sal_False; -bIsStart= bStart; bIsOtherCntnt = bStartChk = bOther; -bIsConvSpecial = sal_True; bIsSelection= bSelection; -bInfoBox= sal_False; bStartDone = bOther || bStart; bEndDone= sal_False; //bLastRet= sal_True; @@ -662,7 +659,6 @@ if( bIsOtherCntnt && bStartDone && bEndDone ) // document completely checked? { -bInfoBox = sal_True; return sal_False; } @@ -677,13 +673,11 @@ else if ( bStartDone && bEndDone ) { // body region done, ask about special region -if( bIsConvSpecial && HasOtherCnt_impl() ) +if( HasOtherCnt_impl() ) { ConvStart_impl( pConvArgs, SVX_SPELL_OTHER ); bIsOtherCntnt = bGoOn = sal_True; } -else -bInfoBox = sal_True; } else { -- To view, visit https://gerrit.libreoffice.org/1638 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44fe6ad3dacc65e28256aca98588b7dfe92d73ae Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use member initializer list in constructor
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/1640/1 Use member initializer list in constructor Change-Id: I8d4f8b95909b91917b456f49d7a3ac270703cc96 --- M sw/source/ui/lingu/hhcwrp.cxx 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/sw/source/ui/lingu/hhcwrp.cxx b/sw/source/ui/lingu/hhcwrp.cxx index f1ec1d5..82e7d3a 100644 --- a/sw/source/ui/lingu/hhcwrp.cxx +++ b/sw/source/ui/lingu/hhcwrp.cxx @@ -103,21 +103,21 @@ pTargetFont, nConvOptions, bIsInteractive ), -mrWrtShell( pSwView->GetWrtShell() ) +mpView( pSwView ), +mpWin( &pSwView->GetEditWin() ), +mrWrtShell( pSwView->GetWrtShell() ), +mpConvArgs( 0 ), +mnLastPos( 0 ), +mnUnitOffset( 0 ), +mnPageCount( 0 ), +mnPageStart( 0 ), +mbIsDrawObj( sal_False ), +mbIsOtherCntnt( bOther ), +mbStartChk( bOther ), +mbIsSelection( bSelection ), +mbStartDone( bOther || bStart ), +mbEndDone( sal_False ) { -mpConvArgs = 0; -mnLastPos = 0; -mnUnitOffset= 0; - -mpView = pSwView; -mpWin = &pSwView->GetEditWin(); -mbIsDrawObj = sal_False; -mbIsOtherCntnt = mbStartChk = bOther; -mbIsSelection = bSelection; -mbStartDone = bOther || bStart; -mbEndDone= sal_False; -//bLastRet= sal_True; -mnPageCount = mnPageStart = 0; } -- To view, visit https://gerrit.libreoffice.org/1640 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d4f8b95909b91917b456f49d7a3ac270703cc96 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unneeded #include
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1637 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1637/1 Remove unneeded #include Change-Id: Ic0c82079aeb586af97c864aebf966f01643ebfd6 --- M sw/source/core/doc/docedt.cxx 1 file changed, 0 insertions(+), 1 deletion(-) diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx index 693e2bf..5aa66f3 100644 --- a/sw/source/core/doc/docedt.cxx +++ b/sw/source/core/doc/docedt.cxx @@ -60,7 +60,6 @@ #include #include #include -#include #include #include "comcore.hrc" #include "editsh.hxx" -- To view, visit https://gerrit.libreoffice.org/1637 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0c82079aeb586af97c864aebf966f01643ebfd6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Avoid unnecessary operations on an OUString
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1537 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/1537/1 Avoid unnecessary operations on an OUString Change-Id: I1820711664a6aa18587e1e4a3d74a8e4cbfcc07e --- M sd/source/ui/annotations/annotationmanager.cxx 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sd/source/ui/annotations/annotationmanager.cxx b/sd/source/ui/annotations/annotationmanager.cxx index 3ddcd33..2fc9492 100644 --- a/sd/source/ui/annotations/annotationmanager.cxx +++ b/sd/source/ui/annotations/annotationmanager.cxx @@ -160,11 +160,11 @@ Date aSysDate( Date::SYSTEM ); Date aDate = Date( aDateTime.Day, aDateTime.Month, aDateTime.Year ); if (aDate==aSysDate) -sRet = sRet + String(SdResId(STR_ANNOTATION_TODAY)); +sRet = SdResId(STR_ANNOTATION_TODAY); else if (aDate == Date(aSysDate-1)) -sRet = sRet + String(SdResId(STR_ANNOTATION_YESTERDAY)); +sRet = SdResId(STR_ANNOTATION_YESTERDAY); else if (aDate.IsValidAndGregorian() ) -sRet = sRet + rLocalData.getDate(aDate); +sRet = rLocalData.getDate(aDate); Time aTime( aDateTime.Hours, aDateTime.Minutes, aDateTime.Seconds, aDateTime.HundredthSeconds ); if(aTime.GetTime() != 0) -- To view, visit https://gerrit.libreoffice.org/1537 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1820711664a6aa18587e1e4a3d74a8e4cbfcc07e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Cleanup: #include
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1484 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/1484/1 Cleanup: #include Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530 --- M accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx M accessibility/source/helper/characterattributeshelper.cxx M basctl/source/basicide/iderdll2.hxx M cppcanvas/source/mtfrenderer/pointaction.cxx M cppcanvas/source/mtfrenderer/polypolyaction.cxx M cppcanvas/source/mtfrenderer/textaction.hxx M dbaccess/inc/ToolBoxHelper.hxx M desktop/source/deployment/gui/dp_gui_dependencydialog.cxx M editeng/inc/editeng/svxfont.hxx M editeng/source/items/svxfont.cxx M editeng/source/misc/swafopt.cxx M filter/source/graphicfilter/idxf/dxfvec.cxx M filter/source/graphicfilter/idxf/dxfvec.hxx M idl/inc/bastype.hxx M idl/inc/lex.hxx M lotuswordpro/source/filter/lwpgrfobj.hxx M sc/inc/postit.hxx M sc/source/core/data/postit.cxx M sc/source/filter/excel/xechart.cxx M sc/source/filter/inc/imp_op.hxx M sc/source/filter/inc/xechart.hxx M sc/source/ui/inc/formdata.hxx M sd/inc/sdfilter.hxx M sd/source/filter/eppt/eppt.hxx M sd/source/filter/ppt/propread.hxx M sd/source/ui/inc/undoheaderfooter.hxx M sd/source/ui/slidesorter/cache/SlsBitmapCompressor.hxx M sd/source/ui/slidesorter/cache/SlsPageCache.cxx M sd/source/ui/slidesorter/inc/cache/SlsPageCache.hxx M sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx M sd/source/ui/slidesorter/inc/controller/SlsScrollBarManager.hxx M sd/source/ui/slidesorter/inc/controller/SlsSelectionObserver.hxx M sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx M sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx M sfx2/inc/sfx2/imgmgr.hxx M slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionerImpl.cxx M slideshow/source/engine/OGLTrans/win/OGLTrans_TransitionerImpl.cxx M svl/source/items/szitem.cxx M svtools/inc/svtools/fltcall.hxx M svtools/inc/svtools/javainteractionhandler.hxx M svtools/inc/svtools/scriptedtext.hxx M svtools/source/control/scriptedtext.cxx M svx/inc/svx/EnhancedCustomShape2d.hxx M svx/inc/svx/IAccessibleViewForwarderListener.hxx M svx/inc/svx/framelink.hxx M svx/inc/svx/msdffdef.hxx M svx/inc/svx/sdr/contact/objectcontactofpageview.hxx M svx/inc/svx/sdr/contact/viewcontact.hxx M svx/inc/svx/sdr/contact/viewcontactofsdrmediaobj.hxx M svx/inc/svx/sdr/contact/viewobjectcontact.hxx M svx/inc/svx/sdr/contact/viewobjectcontactofsdrmediaobj.hxx M svx/inc/svx/sdr/overlay/overlayhatchrect.hxx M svx/inc/svx/sdr/overlay/overlayobjectlist.hxx M svx/inc/svx/unoshape.hxx M svx/inc/xpolyimp.hxx M svx/source/dialog/framelink.cxx M svx/source/gallery2/codec.hxx M svx/source/mnuctrls/clipboardctl.cxx M svx/source/sdr/overlay/overlaycrosshair.cxx M svx/source/sdr/overlay/overlayhelpline.cxx M svx/source/sdr/overlay/overlayline.cxx M svx/source/sdr/overlay/overlayobjectlist.cxx M svx/source/sdr/overlay/overlayrollingrectangle.cxx M svx/source/svdraw/gradtrns.hxx M svx/source/table/tablelayouter.cxx M svx/source/table/tablelayouter.hxx M svx/source/table/tablemodel.cxx M svx/source/table/tablemodel.hxx M svx/source/tbxctrls/lboxctrl.cxx M svx/source/unodraw/unoshape.cxx M svx/source/xoutdev/_xpoly.cxx M sw/inc/anchoreddrawobject.hxx M sw/inc/frmfmt.hxx M sw/inc/node.hxx M sw/inc/numrule.hxx M sw/inc/pam.hxx M sw/source/core/crsr/pam.cxx M sw/source/core/docnode/node.cxx M sw/source/core/fields/postithelper.cxx M sw/source/core/inc/fntcache.hxx M sw/source/core/inc/swfont.hxx M sw/source/core/layout/anchoreddrawobject.cxx M toolkit/inc/toolkit/awt/vclxaccessiblecomponent.hxx M tools/inc/poly.h M tools/inc/tools/svborder.hxx M tools/source/generic/poly.cxx M tools/source/generic/poly2.cxx M vcl/generic/print/glyphset.cxx M vcl/generic/print/glyphset.hxx M vcl/inc/generic/gendisp.hxx M vcl/inc/outfont.hxx M vcl/inc/svdata.hxx M vcl/inc/unx/i18n_status.hxx M vcl/inc/unx/salstd.hxx M vcl/inc/vcl/font.hxx M vcl/inc/vcl/gradient.hxx M vcl/inc/vcl/lineinfo.hxx M vcl/inc/vcl/wall.hxx M vcl/source/app/svdata.cxx M vcl/source/gdi/font.cxx M vcl/source/gdi/gradient.cxx 101 files changed, 121 insertions(+), 81 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1484 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Kill set_oenv remnants (by just renaming the required timest...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1026 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1026/1 Kill set_oenv remnants (by just renaming the required timestamp file) Change-Id: I779128111a4f69235a4c8cc6510018fc61d1b24b --- M .gitignore M Makefile.top M configure.ac M odk/source/unowinreg/win/makefile.mk M scp2/CustomTarget_langmacros.mk M scp2/macros/macro.pl 6 files changed, 11 insertions(+), 13 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1026 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I779128111a4f69235a4c8cc6510018fc61d1b24b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Make HangulHanjaConversion an abstract class
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/987 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/987/1 Make HangulHanjaConversion an abstract class Change-Id: Ie39801fc14a66af8b338188c74af9f6e52031e60 --- M editeng/inc/editeng/hangulhanja.hxx M editeng/source/misc/hangulhanja.cxx 2 files changed, 4 insertions(+), 31 deletions(-) -- To view, visit https://gerrit.libreoffice.org/987 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie39801fc14a66af8b338188c74af9f6e52031e60 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unnecessary #include
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/980 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/980/1 Remove unnecessary #include Change-Id: I3c33ce1eecad649c3d23719b51d51057d41d9a2e --- M sw/source/ui/lingu/hhcwrp.cxx 1 file changed, 0 insertions(+), 1 deletion(-) -- To view, visit https://gerrit.libreoffice.org/980 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c33ce1eecad649c3d23719b51d51057d41d9a2e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] sal_Bool to bool
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/979 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/979/1 sal_Bool to bool Change-Id: I8a4890c6b0e466417387a09259e32dff57c640d6 --- M sw/inc/txatritr.hxx M sw/source/core/txtnode/txatritr.cxx 2 files changed, 16 insertions(+), 16 deletions(-) -- To view, visit https://gerrit.libreoffice.org/979 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a4890c6b0e466417387a09259e32dff57c640d6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Don't play dirty tricks for const objects
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/973 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/973/1 Don't play dirty tricks for const objects Change-Id: I92c2362b71cf3614b091c893c0fdb3248edb3ddd --- M sw/inc/bparr.hxx M sw/source/core/bastyp/bparr.cxx 2 files changed, 12 insertions(+), 17 deletions(-) -- To view, visit https://gerrit.libreoffice.org/973 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92c2362b71cf3614b091c893c0fdb3248edb3ddd Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Enforce information hiding on gen.hxx structures
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/936 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/936/1 Enforce information hiding on gen.hxx structures Change-Id: Icd1b2937fdeaba6de1877258731f53ddf996002e --- M filter/source/flash/swfwriter1.cxx M filter/source/flash/swfwriter2.cxx M filter/source/graphicfilter/epict/epict.cxx M sc/qa/unit/ucalc.cxx M sd/source/filter/eppt/pptx-text.cxx M sd/source/filter/html/htmlattr.cxx M sd/source/ui/animations/CustomAnimationList.cxx M sd/source/ui/annotations/annotationmanager.cxx M sd/source/ui/dlg/headerfooterdlg.cxx M sd/source/ui/slideshow/slideshowimpl.cxx M sd/source/ui/unoidl/unomodel.cxx M sd/source/ui/view/frmview.cxx M svx/source/accessibility/ChildrenManagerImpl.cxx M svx/source/dialog/dlgctrl.cxx M svx/source/svdraw/svddrgmt.cxx M svx/source/table/cell.cxx M svx/source/table/svdotable.cxx M svx/source/table/tablelayouter.cxx M svx/source/table/tablertfimporter.cxx M sw/source/core/access/accmap.cxx M sw/source/core/bastyp/swrect.cxx M sw/source/core/layout/paintfrm.cxx M sw/source/ui/uiview/viewport.cxx M tools/inc/tools/gen.hxx M tools/inc/tools/vector2d.hxx M vcl/aqua/source/window/salframe.cxx M vcl/aqua/source/window/salmenu.cxx M vcl/ios/source/window/salframe.cxx M vcl/source/control/button.cxx M vcl/source/control/imgctrl.cxx M vcl/source/control/tabctrl.cxx M vcl/source/gdi/outdev.cxx M vcl/source/gdi/outdev3.cxx M vcl/source/gdi/pdfwriter_impl.cxx M vcl/source/window/brdwin.cxx M vcl/source/window/dockmgr.cxx M vcl/source/window/splitwin.cxx M vcl/source/window/syswin.cxx M vcl/source/window/window.cxx M vcl/win/source/window/salframe.cxx M vcl/workben/vcldemo.cxx 41 files changed, 216 insertions(+), 204 deletions(-) -- To view, visit https://gerrit.libreoffice.org/936 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd1b2937fdeaba6de1877258731f53ddf996002e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matteo Casalin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice