[PATCH] Update pt-BR dictionary and grammar checker

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4146

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/dictionaries 
refs/changes/46/4146/1

Update pt-BR dictionary and grammar checker

Version 3.1.0.9

The pt-BR Lightproof grammar checker contains more rules than the english 
version.

Change-Id: I45a52713318dc3dc3ccdb1ac96972ff670272317
---
M pt_BR/Lightproof.components
M pt_BR/Lightproof.py
M pt_BR/README_hyph_pt_BR.txt
M pt_BR/README_pt_BR.txt
M pt_BR/description.xml
M pt_BR/dialog/pt_BR.xdl
M pt_BR/dialog/registry/schema/org/openoffice/Lightproof_pt_BR.xcs
M pt_BR/hyph_pt_BR.dic
M pt_BR/pt_BR.aff
M pt_BR/pt_BR.dic
M pt_BR/pythonpath/lightproof_handler_pt_BR.py
M pt_BR/pythonpath/lightproof_impl_pt_BR.py
M pt_BR/pythonpath/lightproof_opts_pt_BR.py
M pt_BR/pythonpath/lightproof_pt_BR.py
14 files changed, 29,552 insertions(+), 20,113 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/4146
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45a52713318dc3dc3ccdb1ac96972ff670272317
Gerrit-PatchSet: 1
Gerrit-Project: dictionaries
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Update pt-BR dictionary and grammar checker

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4120

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/dictionaries 
refs/changes/20/4120/1

Update pt-BR dictionary and grammar checker

Change-Id: Ic30dcf8588b3408d59cb960956e9e1cf8d6a330b
---
M pt_BR/Lightproof.py
M pt_BR/README_pt_BR.txt
M pt_BR/description.xml
M pt_BR/dialog/pt_BR.xdl
M pt_BR/dialog/registry/data/org/openoffice/Office/OptionsDialog.xcu
M pt_BR/dialog/registry/schema/org/openoffice/Lightproof_pt_BR.xcs
M pt_BR/pt_BR.aff
M pt_BR/pt_BR.dic
M pt_BR/pythonpath/lightproof_handler_pt_BR.py
M pt_BR/pythonpath/lightproof_impl_pt_BR.py
M pt_BR/pythonpath/lightproof_opts_pt_BR.py
M pt_BR/pythonpath/lightproof_pt_BR.py
12 files changed, 20,381 insertions(+), 19,033 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/4120
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic30dcf8588b3408d59cb960956e9e1cf8d6a330b
Gerrit-PatchSet: 1
Gerrit-Project: dictionaries
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] String to OUString in calc header & footer edit

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3911

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3911/1

String to OUString in calc header & footer edit

Change-Id: I6aa0f055f89c05c3d799b5ed1b21188f7f3a8268
---
M sc/inc/scabstdlg.hxx
M sc/source/ui/attrdlg/scdlgfact.cxx
M sc/source/ui/attrdlg/scdlgfact.hxx
M sc/source/ui/inc/hfedtdlg.hxx
M sc/source/ui/pagedlg/hfedtdlg.cxx
5 files changed, 8 insertions(+), 11 deletions(-)



diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 5190c9a..f96344a 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -491,7 +491,7 @@
 virtual SfxAbstractTabDialog * CreateScHFEditDlg( SfxViewFrame* 
pFrame, //add for ScHFEditDlg
 Window* pParent,
 const SfxItemSet&   
rCoreSet,
-const String&   
rPageStyle,
+const OUString&   
rPageStyle,
 int nId,
 sal_uInt16  
nResId = RID_SCDLG_HFEDIT ) = 0;
 
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx 
b/sc/source/ui/attrdlg/scdlgfact.cxx
index e9945b8..6be8ac4 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -1237,7 +1237,7 @@
 SfxAbstractTabDialog * ScAbstractDialogFactory_Impl::CreateScHFEditDlg( 
SfxViewFrame*   pFrame,
 
Window* pParent,
 const 
SfxItemSet&   rCoreSet,
-const 
String&   rPageStyle,
+const 
OUString& rPageStyle,
 int 
nId,
 
sal_uInt16  nResId )
 {
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx 
b/sc/source/ui/attrdlg/scdlgfact.hxx
index a18767c..b622f42 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -558,7 +558,7 @@
 virtual SfxAbstractTabDialog * CreateScHFEditDlg( SfxViewFrame* 
pFrame, //add for ScHFEditDlg
 Window* pParent,
 const SfxItemSet&   
rCoreSet,
-const String&   
rPageStyle,
+const OUString& 
rPageStyle,
 int nId,
 sal_uInt16  
nResId = RID_SCDLG_HFEDIT );
 
diff --git a/sc/source/ui/inc/hfedtdlg.hxx b/sc/source/ui/inc/hfedtdlg.hxx
index 56a50a9..0ec88c3 100644
--- a/sc/source/ui/inc/hfedtdlg.hxx
+++ b/sc/source/ui/inc/hfedtdlg.hxx
@@ -36,7 +36,7 @@
 ScHFEditDlg( SfxViewFrame*  pFrame,
  Window*pParent,
  const SfxItemSet&  rCoreSet,
- const String&  rPageStyle,
+ const OUString&rPageStyle,
  sal_uInt16 nResId = RID_SCDLG_HFEDIT );
 
 ~ScHFEditDlg();
diff --git a/sc/source/ui/pagedlg/hfedtdlg.cxx 
b/sc/source/ui/pagedlg/hfedtdlg.cxx
index a74e267..4f095d3 100644
--- a/sc/source/ui/pagedlg/hfedtdlg.cxx
+++ b/sc/source/ui/pagedlg/hfedtdlg.cxx
@@ -53,19 +53,16 @@
 ScHFEditDlg::ScHFEditDlg( SfxViewFrame* pFrameP,
   Window*   pParent,
   const SfxItemSet& rCoreSet,
-  const String& rPageStyle,
+  const OUString&   rPageStyle,
   sal_uInt16nResIdP )
 :   SfxTabDialog( pFrameP, pParent, ScResId( nResIdP ), &rCoreSet )
 {
 eNumType = ((const SvxPageItem&)rCoreSet.Get(ATTR_PAGE)).GetNumType();
 
-String aTmp = GetText();
+OUString aTmp = GetText();
 
-aTmp.AppendAscii(RTL_CONSTASCII_STRINGPARAM( " (" ));
-aTmp += ScGlobal::GetRscString( STR_PAGESTYLE );
-aTmp.AppendAscii(RTL_CONSTASCII_STRINGPARAM( ": " ));
-aTmp += rPageStyle;
-aTmp += ')';
+aTmp += " (" + ScGlobal::GetRscString( STR_PAGESTYLE ) + ": " + rPageStyle 
+ ")";
+
 SetText( aTmp );
 
 switch ( nResIdP )

-- 
To view, visit https://gerrit.libreoffice.org/3911
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6aa0f055f89c05c3d799b5ed1b21188f7f3a8268
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch:

[PATCH] Simple string cleanup in backingwindow.cxx

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3377

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3377/1

Simple string cleanup in backingwindow.cxx

Change-Id: I5bd7152f0dfdc5459e9a754af1e8c65234ff606d
---
M framework/source/services/backingwindow.cxx
1 file changed, 22 insertions(+), 22 deletions(-)



diff --git a/framework/source/services/backingwindow.cxx 
b/framework/source/services/backingwindow.cxx
index 652b6c6..be33173 100644
--- a/framework/source/services/backingwindow.cxx
+++ b/framework/source/services/backingwindow.cxx
@@ -160,16 +160,16 @@
 Reference xConfig = 
configuration::theDefaultProvider::get( 
comphelper::getProcessComponentContext() );
 Sequence args(1);
 PropertyValue val(
-OUString( "nodepath" ),
+"nodepath",
 0,
-Any(OUString( "/org.openoffice.Office.Common/Help/StartCenter")),
+Any(OUString("/org.openoffice.Office.Common/Help/StartCenter"),
 PropertyState_DIRECT_VALUE);
 args.getArray()[0] <<= val;
 Reference 
xNameAccess(xConfig->createInstanceWithArguments(SERVICENAME_CFGREADACCESS,args),
 UNO_QUERY);
 if( xNameAccess.is() )
 {
 //throws css::container::NoSuchElementException, 
css::lang::WrappedTargetException
-Any value( 
xNameAccess->getByName(OUString("StartCenterHideExternalLinks")) );
+Any value( xNameAccess->getByName("StartCenterHideExternalLinks") 
);
 mnHideExternalLinks = value.get();
 }
 }
@@ -177,9 +177,9 @@
 {
 }
 
-String aExtHelpText( FwkResId( STR_BACKING_EXTHELP ) );
-String aInfoHelpText( FwkResId( STR_BACKING_INFOHELP ) );
-String aTplRepHelpText( FwkResId( STR_BACKING_TPLREP ) );
+OUString aExtHelpText( FwkResId( STR_BACKING_EXTHELP ) );
+OUString aInfoHelpText( FwkResId( STR_BACKING_INFOHELP ) );
+OUString aTplRepHelpText( FwkResId( STR_BACKING_TPLREP ) );
 
 // clean up resource stack
 FreeResource();
@@ -328,24 +328,24 @@
 rArgsList.realloc( nArgs );
 
 nArgs--;
-rArgsList[nArgs].Name = OUString( "FilterName" );
+rArgsList[nArgs].Name = "FilterName";
 rArgsList[nArgs].Value = makeAny( aFilter );
 
 if( !aFilterOpt.isEmpty() )
 {
 nArgs--;
-rArgsList[nArgs].Name = OUString( "FilterOptions" );
+rArgsList[nArgs].Name = "FilterOptions";
 rArgsList[nArgs].Value = makeAny( aFilterOpt );
 }
 
 // documents in the picklist will never be opened as templates
 nArgs--;
-rArgsList[nArgs].Name = OUString( "AsTemplate" );
+rArgsList[nArgs].Name = "AsTemplate";
 rArgsList[nArgs].Value = makeAny( (sal_Bool) sal_False );
 
 nArgs--;
-rArgsList[nArgs].Name = OUString( "Referer" );
-rArgsList[nArgs].Value = makeAny( OUString( "private:user"  ) );
+rArgsList[nArgs].Name = "Referer";
+rArgsList[nArgs].Value = makeAny( OUString("private:user") );
 
 // and finally create an entry in the popupmenu
 OUString   aMenuTitle;
@@ -389,7 +389,7 @@
 }
 else
 {
-String aNoDoc( FwkResId( STR_NODOCUMENT ) );
+OUString aNoDoc( FwkResId( STR_NODOCUMENT ) );
 mpRecentMenu->InsertItem( 0x, aNoDoc );
 }
 maOpenButton.SetPopupMenu( mpRecentMenu );
@@ -885,7 +885,7 @@
 Reference xConfig = 
configuration::theDefaultProvider::get( 
comphelper::getProcessComponentContext() );
 Sequence args(1);
 PropertyValue val(
-OUString( "nodepath" ),
+"nodepath",
 0,
 Any(OUString::createFromAscii(pNodePath)),
 PropertyState_DIRECT_VALUE);
@@ -917,27 +917,27 @@
 {
 // dispatch the appropriate URL and end the dialog
 if( pButton == &maWriterButton )
-dispatchURL( OUString( WRITER_URL ) );
+dispatchURL( WRITER_URL );
 else if( pButton == &maCalcButton )
-dispatchURL( OUString( CALC_URL ) );
+dispatchURL( CALC_URL );
 else if( pButton == &maImpressButton )
-dispatchURL( OUString( IMPRESS_WIZARD_URL ) );
+dispatchURL( IMPRESS_WIZARD_URL );
 else if( pButton == &maDrawButton )
-dispatchURL( OUString( DRAW_URL ) );
+dispatchURL( DRAW_URL );
 else if( pButton == &maDBButton )
-dispatchURL( OUString( BASE_URL ) );
+dispatchURL( BASE_URL );
 else if( pButton == &maMathButton )
-dispatchURL( OUString( MATH_URL ) );
+dispatchURL( MATH_URL );
 else if( pButton == &maOpenButton )
 {
 Reference< XDispatchProvider > xFrame( mxFrame, UNO_QUERY );
 
 Sequence< com::sun::star::beans::PropertyValue > aArgs(1);
 

[PUSHED] Drop unused variable

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3282

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3282
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d0d561b6c3f1a6eb3ab237538885e5c48820e6e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Drop unused variable

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3282

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/3282/1

Drop unused variable

Change-Id: I6d0d561b6c3f1a6eb3ab237538885e5c48820e6e
---
M sw/source/ui/inc/pggrid.hxx
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/sw/source/ui/inc/pggrid.hxx b/sw/source/ui/inc/pggrid.hxx
index eda617e..8159126 100644
--- a/sw/source/ui/inc/pggrid.hxx
+++ b/sw/source/ui/inc/pggrid.hxx
@@ -30,7 +30,6 @@
  */
 class SwTextGridPage: public SfxTabPage
 {
-FixedLine*   m_pGridTypeFL;
 RadioButton* m_pNoGridRB;
 RadioButton* m_pLinesGridRB;
 RadioButton* m_pCharsGridRB;

-- 
To view, visit https://gerrit.libreoffice.org/3282
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d0d561b6c3f1a6eb3ab237538885e5c48820e6e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Lightproof and Hunspell updates for pt-BR

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3130

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/dictionaries 
refs/changes/30/3130/1

Lightproof and Hunspell updates for pt-BR

VERO 3.1 beta 2

Change-Id: Iaf871e4ad7de5c51ed55674b742b8f2b20070001
---
M Dictionary_pt-BR.mk
M pt_BR/Lightproof.py
M pt_BR/Linguistic.xcu
M pt_BR/README_Lightproof_pt_BR.txt
M pt_BR/README_en.txt
M pt_BR/README_pt_BR.txt
M pt_BR/description.xml
A pt_BR/dialog/pt_BR_pt_BR.properties
M pt_BR/dialog/registry/schema/org/openoffice/Lightproof_pt_BR.xcs
M pt_BR/package-description.txt
M pt_BR/pt_BR.aff
M pt_BR/pt_BR.dic
M pt_BR/pythonpath/lightproof_handler_pt_BR.py
M pt_BR/pythonpath/lightproof_impl_pt_BR.py
M pt_BR/pythonpath/lightproof_opts_pt_BR.py
M pt_BR/pythonpath/lightproof_pt_BR.py
16 files changed, 782 insertions(+), 424 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/3130
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf871e4ad7de5c51ed55674b742b8f2b20070001
Gerrit-PatchSet: 1
Gerrit-Project: dictionaries
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove now obsolete RTL_CONSTASCII_(U)STRINGPARAM

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2627

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2627
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15ae64d621fd0a1fa178f9a4062b93520628bdb0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removed last RTL_CONST* macros from codemaker

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2605

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2605
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce4fd2cc7c62a18e059e945b42cc01425802aa0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Small improvement in page widget ui

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2590

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/2590/1

Small improvement in page widget ui

Save a coupe of bytes and better use of widget features

Change-Id: I6860339a8b62c7e95605a0abc47e99d7ef49696b
---
M cui/source/inc/page.hxx
M cui/source/tabpages/page.cxx
M cui/uiconfig/ui/pageformatpage.ui
3 files changed, 96 insertions(+), 107 deletions(-)



diff --git a/cui/source/inc/page.hxx b/cui/source/inc/page.hxx
index 64e06de..fa18d96 100644
--- a/cui/source/inc/page.hxx
+++ b/cui/source/inc/page.hxx
@@ -120,14 +120,9 @@
 
 String  sStandardRegister;
 
-FixedText*   m_pInsideText;
-FixedText*   m_pOutsideText;
+FixedText*   m_pInsideLbl;
+FixedText*   m_pOutsideLbl;
 FixedText*   m_pPrintRangeQueryText;
-
-OUStringaInsideText;
-OUStringaOutsideText;
-OUStringaLeftText;
-OUStringaRightText;
 
 longnFirstLeftMargin;
 longnFirstRightMargin;
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index fe2c43d..f04d6a6 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -223,8 +223,8 @@
 
 get(m_pAdaptBox,"checkAdaptBox");
 // Strings stored in UI
-get(m_pInsideText,"labelInner");
-get(m_pOutsideText,"labelOuter");
+get(m_pInsideLbl,"labelInner");
+get(m_pOutsideLbl,"labelOuter");
 get(m_pPrintRangeQueryText,"labelMsg");
 
 bBorderModified = sal_False;
@@ -370,11 +370,6 @@
 
 void SvxPageDescPage::Init_Impl()
 {
-aLeftText = m_pLeftMarginLbl->GetText();
-aRightText = m_pRightMarginLbl->GetText();
-aInsideText = m_pInsideText->GetText();
-aOutsideText = m_pOutsideText->GetText();
-
 // adjust the handler
 m_pLayoutBox->SetSelectHdl( LINK( this, SvxPageDescPage, LayoutHdl_Impl ) 
);
 m_pPaperSizeBox->SetDropDownLineCount(10);
@@ -900,19 +895,17 @@
 
 if ( nPos == SVX_PAGE_MIRROR )
 {
-if ( m_pLeftMarginLbl->GetText() != aInsideText )
-   m_pLeftMarginLbl->SetText( aInsideText );
-
-if ( m_pRightMarginLbl->GetText() != aOutsideText )
-m_pRightMarginLbl->SetText( aOutsideText );
+m_pLeftMarginLbl->Hide();
+m_pRightMarginLbl->Hide();
+m_pInsideLbl->Show();
+m_pOutsideLbl->Show();
 }
 else
 {
-if ( m_pLeftMarginLbl->GetText() != aLeftText )
-m_pLeftMarginLbl->SetText( aLeftText );
-
-if ( m_pRightMarginLbl->GetText() != aRightText )
-m_pRightMarginLbl->SetText( aRightText );
+m_pLeftMarginLbl->Show();
+m_pRightMarginLbl->Show();
+m_pInsideLbl->Hide();
+m_pOutsideLbl->Hide();
 }
 UpdateExample_Impl( true );
 return 0;
diff --git a/cui/uiconfig/ui/pageformatpage.ui 
b/cui/uiconfig/ui/pageformatpage.ui
index 1463671..a3fe196 100644
--- a/cui/uiconfig/ui/pageformatpage.ui
+++ b/cui/uiconfig/ui/pageformatpage.ui
@@ -342,38 +342,6 @@
 6
 12
 
-  
-True
-False
-0
-Left:
-True
-spinMargLeft:0.00cm
-  
-  
-0
-0
-1
-1
-  
-
-
-  
-True
-False
-0
-Right:
-True
-spinMargRight:0.00cm
-  
-  
-0
-1
-1
-1
-  
-
-
   
 True
 False
@@ -457,6 +425,88 @@
   
 1
 3
+1
+1
+  
+
+
+  
+True
+False
+vertical
+
+  
+False
+0
+Right:
+True
+spinMargRight:0.00cm
+  
+  
+False
+True
+0
+  
+
+   

[PUSHED] String::CreateFromAscii drop in sc

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2448

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2448
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb9fda589b309bd850ba2fdd68e7170c28d4c31a
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove unused variable

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2457

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2457
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I054ad7642ed4fcc66ce24923a1c945bedb01ef27
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix page format UI labels witht mirror pages

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2455

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2455
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I793180100764293dacb702b725a282a95a6b6238
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Fix page format UI labels witht mirror pages

[Olivier Hallot (via Code Review)]

Olivier Hallot has abandoned this change.

Change subject: Fix page format UI labels witht mirror pages
..


Patch Set 1: Abandoned

Duplicate submit

-- 
To view, visit https://gerrit.libreoffice.org/2456
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9c4612f6de53e7ab622f823173b7c921fbf45082
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused variable

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2457

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/2457/1

Remove unused variable

Shuffle some assignments

Change-Id: I054ad7642ed4fcc66ce24923a1c945bedb01ef27
---
M cui/source/tabpages/page.cxx
1 file changed, 2 insertions(+), 4 deletions(-)



diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 40c109c..fe2c43d 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -224,9 +224,7 @@
 get(m_pAdaptBox,"checkAdaptBox");
 // Strings stored in UI
 get(m_pInsideText,"labelInner");
-aInsideText = m_pInsideText->GetText();
 get(m_pOutsideText,"labelOuter");
-aOutsideText = m_pOutsideText->GetText();
 get(m_pPrintRangeQueryText,"labelMsg");
 
 bBorderModified = sal_False;
@@ -374,6 +372,8 @@
 {
 aLeftText = m_pLeftMarginLbl->GetText();
 aRightText = m_pRightMarginLbl->GetText();
+aInsideText = m_pInsideText->GetText();
+aOutsideText = m_pOutsideText->GetText();
 
 // adjust the handler
 m_pLayoutBox->SetSelectHdl( LINK( this, SvxPageDescPage, LayoutHdl_Impl ) 
);
@@ -897,8 +897,6 @@
 {
 // switch inside outside
 const sal_uInt16 nPos = PosToPageUsage_Impl( 
m_pLayoutBox->GetSelectEntryPos() );
-
-OUString aAux();
 
 if ( nPos == SVX_PAGE_MIRROR )
 {

-- 
To view, visit https://gerrit.libreoffice.org/2457
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I054ad7642ed4fcc66ce24923a1c945bedb01ef27
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix page format UI labels witht mirror pages

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2456

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/2456/1

Fix page format UI labels witht mirror pages

The recent page format widget UI was not swapping inner<>left and outer<>right 
labels when page mirroring was selected.

Change-Id: I9c4612f6de53e7ab622f823173b7c921fbf45082
---
M cui/source/inc/page.hxx
M cui/source/tabpages/page.cxx
2 files changed, 19 insertions(+), 10 deletions(-)



diff --git a/cui/source/inc/page.hxx b/cui/source/inc/page.hxx
index 1049238..64e06de 100644
--- a/cui/source/inc/page.hxx
+++ b/cui/source/inc/page.hxx
@@ -124,6 +124,11 @@
 FixedText*   m_pOutsideText;
 FixedText*   m_pPrintRangeQueryText;
 
+OUStringaInsideText;
+OUStringaOutsideText;
+OUStringaLeftText;
+OUStringaRightText;
+
 longnFirstLeftMargin;
 longnFirstRightMargin;
 longnFirstTopMargin;
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 9d32f39..40c109c 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -224,7 +224,9 @@
 get(m_pAdaptBox,"checkAdaptBox");
 // Strings stored in UI
 get(m_pInsideText,"labelInner");
+aInsideText = m_pInsideText->GetText();
 get(m_pOutsideText,"labelOuter");
+aOutsideText = m_pOutsideText->GetText();
 get(m_pPrintRangeQueryText,"labelMsg");
 
 bBorderModified = sal_False;
@@ -370,8 +372,8 @@
 
 void SvxPageDescPage::Init_Impl()
 {
-//aLeftText = m_pLeftMarginLbl->GetText();
-//aRightText = m_pRightMarginLbl->GetText();
+aLeftText = m_pLeftMarginLbl->GetText();
+aRightText = m_pRightMarginLbl->GetText();
 
 // adjust the handler
 m_pLayoutBox->SetSelectHdl( LINK( this, SvxPageDescPage, LayoutHdl_Impl ) 
);
@@ -896,21 +898,23 @@
 // switch inside outside
 const sal_uInt16 nPos = PosToPageUsage_Impl( 
m_pLayoutBox->GetSelectEntryPos() );
 
+OUString aAux();
+
 if ( nPos == SVX_PAGE_MIRROR )
 {
-if ( m_pLeftMarginLbl->GetText() != m_pInsideText->GetText() )
-m_pLeftMarginLbl->SetText( m_pInsideText->GetText() );
+if ( m_pLeftMarginLbl->GetText() != aInsideText )
+   m_pLeftMarginLbl->SetText( aInsideText );
 
-if ( m_pRightMarginLbl->GetText() != m_pOutsideText->GetText() )
-m_pRightMarginLbl->SetText( m_pOutsideText->GetText() );
+if ( m_pRightMarginLbl->GetText() != aOutsideText )
+m_pRightMarginLbl->SetText( aOutsideText );
 }
 else
 {
-if ( m_pLeftMarginLbl->GetText() != m_pLeftMarginLbl->GetText() )
-m_pLeftMarginLbl->SetText( m_pLeftMarginLbl->GetText() );
+if ( m_pLeftMarginLbl->GetText() != aLeftText )
+m_pLeftMarginLbl->SetText( aLeftText );
 
-if ( m_pRightMarginLbl->GetText() != m_pRightMarginLbl->GetText() )
-m_pRightMarginLbl->SetText( m_pRightMarginLbl->GetText() );
+if ( m_pRightMarginLbl->GetText() != aRightText )
+m_pRightMarginLbl->SetText( aRightText );
 }
 UpdateExample_Impl( true );
 return 0;

-- 
To view, visit https://gerrit.libreoffice.org/2456
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c4612f6de53e7ab622f823173b7c921fbf45082
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix page format UI labels witht mirror pages

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2455

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/2455/1

Fix page format UI labels witht mirror pages

The recent page format widget UI was not swapping inner<>left and outer<>right 
labels when page mirroring was selected.

Change-Id: I793180100764293dacb702b725a282a95a6b6238
---
M cui/source/inc/page.hxx
M cui/source/tabpages/page.cxx
2 files changed, 19 insertions(+), 10 deletions(-)



diff --git a/cui/source/inc/page.hxx b/cui/source/inc/page.hxx
index 1049238..64e06de 100644
--- a/cui/source/inc/page.hxx
+++ b/cui/source/inc/page.hxx
@@ -124,6 +124,11 @@
 FixedText*   m_pOutsideText;
 FixedText*   m_pPrintRangeQueryText;
 
+OUStringaInsideText;
+OUStringaOutsideText;
+OUStringaLeftText;
+OUStringaRightText;
+
 longnFirstLeftMargin;
 longnFirstRightMargin;
 longnFirstTopMargin;
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 9d32f39..40c109c 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -224,7 +224,9 @@
 get(m_pAdaptBox,"checkAdaptBox");
 // Strings stored in UI
 get(m_pInsideText,"labelInner");
+aInsideText = m_pInsideText->GetText();
 get(m_pOutsideText,"labelOuter");
+aOutsideText = m_pOutsideText->GetText();
 get(m_pPrintRangeQueryText,"labelMsg");
 
 bBorderModified = sal_False;
@@ -370,8 +372,8 @@
 
 void SvxPageDescPage::Init_Impl()
 {
-//aLeftText = m_pLeftMarginLbl->GetText();
-//aRightText = m_pRightMarginLbl->GetText();
+aLeftText = m_pLeftMarginLbl->GetText();
+aRightText = m_pRightMarginLbl->GetText();
 
 // adjust the handler
 m_pLayoutBox->SetSelectHdl( LINK( this, SvxPageDescPage, LayoutHdl_Impl ) 
);
@@ -896,21 +898,23 @@
 // switch inside outside
 const sal_uInt16 nPos = PosToPageUsage_Impl( 
m_pLayoutBox->GetSelectEntryPos() );
 
+OUString aAux();
+
 if ( nPos == SVX_PAGE_MIRROR )
 {
-if ( m_pLeftMarginLbl->GetText() != m_pInsideText->GetText() )
-m_pLeftMarginLbl->SetText( m_pInsideText->GetText() );
+if ( m_pLeftMarginLbl->GetText() != aInsideText )
+   m_pLeftMarginLbl->SetText( aInsideText );
 
-if ( m_pRightMarginLbl->GetText() != m_pOutsideText->GetText() )
-m_pRightMarginLbl->SetText( m_pOutsideText->GetText() );
+if ( m_pRightMarginLbl->GetText() != aOutsideText )
+m_pRightMarginLbl->SetText( aOutsideText );
 }
 else
 {
-if ( m_pLeftMarginLbl->GetText() != m_pLeftMarginLbl->GetText() )
-m_pLeftMarginLbl->SetText( m_pLeftMarginLbl->GetText() );
+if ( m_pLeftMarginLbl->GetText() != aLeftText )
+m_pLeftMarginLbl->SetText( aLeftText );
 
-if ( m_pRightMarginLbl->GetText() != m_pRightMarginLbl->GetText() )
-m_pRightMarginLbl->SetText( m_pRightMarginLbl->GetText() );
+if ( m_pRightMarginLbl->GetText() != aRightText )
+m_pRightMarginLbl->SetText( aRightText );
 }
 UpdateExample_Impl( true );
 return 0;

-- 
To view, visit https://gerrit.libreoffice.org/2455
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I793180100764293dacb702b725a282a95a6b6238
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Convert page format tab page to new widget UI

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2432

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/2432/1

Convert page format tab page to new widget UI

Notes:
* pageformatpage.ui contains 3 hidden labels to hold strings used in page.cxx
* Paper format (A0,A4,...) left in src file.

Change-Id: If22c62558f1644e5f25baffeb3d04b921ec0fe8b
---
M cui/UI_cui.mk
M cui/source/inc/page.hxx
M cui/source/tabpages/page.cxx
D cui/source/tabpages/page.hrc
M cui/source/tabpages/page.src
A cui/uiconfig/ui/pageformatpage.ui
M extras/source/glade/libreoffice-catalog.xml
M svx/inc/svx/frmdirlbox.hxx
M svx/source/dialog/frmdirlbox.cxx
M svx/source/dialog/pagectrl.cxx
10 files changed, 1,427 insertions(+), 904 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/2432
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If22c62558f1644e5f25baffeb3d04b921ec0fe8b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#57950: Remove more chained appends in filter

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2186

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2186
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I338b18981e1f925d76c0d640159de30bab219122
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Widget for asian typography

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2115

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2115/1

Widget for asian typography

Change-Id: I70535593c3e06caca48ae8bc8b9476ae09210df8
---
M cui/source/inc/paragrph.hxx
M cui/source/tabpages/paragrph.cxx
M cui/source/tabpages/paragrph.hrc
M cui/source/tabpages/paragrph.src
4 files changed, 23 insertions(+), 72 deletions(-)



diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index ae9904f..045a29d 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -278,17 +278,15 @@
 //--
 class SvxAsianTabPage : public SfxTabPage
 {
-FixedLine   aOptionsFL;
 
-TriStateBox aForbiddenRulesCB;
-TriStateBox aHangingPunctCB;
-
-TriStateBox aScriptSpaceCB;
+CheckBox* m_pForbiddenRulesCB;
+CheckBox* m_pHangingPunctCB;
+CheckBox* m_pScriptSpaceCB;
 
 SvxAsianTabPage( Window* pParent, const SfxItemSet& rSet );
 
 #ifdef _SVX_PARAGRPH_CXX
-DECL_LINK( ClickHdl_Impl, TriStateBox* );
+DECL_LINK( ClickHdl_Impl, CheckBox* );
 #endif
 public:
 ~SvxAsianTabPage();
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 693012c..5d72269 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -2221,19 +2221,17 @@
 }
 
 SvxAsianTabPage::SvxAsianTabPage( Window* pParent, const SfxItemSet& rSet ) :
-SfxTabPage(pParent, CUI_RES( RID_SVXPAGE_PARA_ASIAN ), rSet),
-aOptionsFL( this, CUI_RES(FL_AS_OPTIONS   )),
-aForbiddenRulesCB(  this, CUI_RES(CB_AS_FORBIDDEN )),
-aHangingPunctCB(this, CUI_RES(CB_AS_HANG_PUNC )),
-aScriptSpaceCB( this, CUI_RES(CB_AS_SCRIPT_SPACE))//,
+SfxTabPage(pParent, "AsianTypography","cui/ui/asiantypography.ui", rSet)
 
 {
-FreeResource();
+get(m_pForbiddenRulesCB,"checkForbidList");
+get(m_pHangingPunctCB,"checkHangPunct");
+get(m_pScriptSpaceCB,"checkApplySpacing");
 
 Link aLink = LINK( this, SvxAsianTabPage, ClickHdl_Impl );
-aHangingPunctCB.SetClickHdl( aLink );
-aScriptSpaceCB.SetClickHdl( aLink );
-aForbiddenRulesCB.SetClickHdl( aLink );
+m_pHangingPunctCB->SetClickHdl( aLink );
+m_pScriptSpaceCB->SetClickHdl( aLink );
+m_pForbiddenRulesCB->SetClickHdl( aLink );
 
 }
 
@@ -2255,34 +2253,34 @@
 };
 return pRanges;
 }
-
+//FIXME: This crash in Calc, but works in Writer/Draw/Impress
 sal_BoolSvxAsianTabPage::FillItemSet( SfxItemSet& rSet )
 {
 sal_Bool bRet = sal_False;
 SfxItemPool* pPool = rSet.GetPool();
-if(aScriptSpaceCB.IsChecked() != aScriptSpaceCB.GetSavedValue())
+if(m_pScriptSpaceCB->IsChecked() != m_pScriptSpaceCB->GetSavedValue())
 {
 SfxBoolItem* pNewItem = (SfxBoolItem*)rSet.Get(
 pPool->GetWhich(SID_ATTR_PARA_SCRIPTSPACE)).Clone();
-pNewItem->SetValue(aScriptSpaceCB.IsChecked());
+pNewItem->SetValue(m_pScriptSpaceCB->IsChecked());
 rSet.Put(*pNewItem);
 delete pNewItem;
 bRet = sal_True;
 }
-if(aHangingPunctCB.IsChecked() != aHangingPunctCB.GetSavedValue())
+if(m_pHangingPunctCB->IsChecked() != m_pHangingPunctCB->GetSavedValue())
 {
 SfxBoolItem* pNewItem = (SfxBoolItem*)rSet.Get(
 pPool->GetWhich(SID_ATTR_PARA_HANGPUNCTUATION)).Clone();
-pNewItem->SetValue(aHangingPunctCB.IsChecked());
+pNewItem->SetValue(m_pHangingPunctCB->IsChecked());
 rSet.Put(*pNewItem);
 delete pNewItem;
 bRet = sal_True;
 }
-if(aForbiddenRulesCB.IsChecked() != aForbiddenRulesCB.GetSavedValue())
+if(m_pForbiddenRulesCB->IsChecked() != 
m_pForbiddenRulesCB->GetSavedValue())
 {
 SfxBoolItem* pNewItem = (SfxBoolItem*)rSet.Get(
 pPool->GetWhich(SID_ATTR_PARA_FORBIDDEN_RULES)).Clone();
-pNewItem->SetValue(aForbiddenRulesCB.IsChecked());
+pNewItem->SetValue(m_pForbiddenRulesCB->IsChecked());
 rSet.Put(*pNewItem);
 delete pNewItem;
 bRet = sal_True;
@@ -2290,7 +2288,7 @@
 return bRet;
 }
 
-static void lcl_SetBox(const SfxItemSet& rSet, sal_uInt16 nSlotId, 
TriStateBox& rBox)
+static void lcl_SetBox(const SfxItemSet& rSet, sal_uInt16 nSlotId, CheckBox& 
rBox)
 {
 sal_uInt16 _nWhich = rSet.GetPool()->GetWhich(nSlotId);
 SfxItemState eState = rSet.GetItemState(_nWhich, sal_True);
@@ -2309,14 +2307,14 @@
 
 void SvxAsianTabPage::Reset( const SfxItemSet& rSet )
 {
-lcl_SetBox(rSet, SID_ATTR_PARA_FORBIDDEN_RULES, aForbiddenRulesCB );
-lcl_SetBox(rSet, SID_ATTR_PARA_HANGPUNCTUATION, aHangingPunctCB );
+lcl_SetBox(rSet, SID_ATTR_PARA_FORBIDDEN_RULES, *m_pForbiddenRulesCB );
+lcl_SetBox(rSet, SID_ATTR_PARA_HANGPUNCTUATION, *m_pHangingPunctCB );
 
 //character distance not yet available
-lcl

[PATCH] Widget for Calc Protect cell tab page (cont)

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2091

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/2091/1

Widget for Calc Protect cell tab page (cont)

* Remove commented FreeResource (as indicated by wiki insrtuctions)

Change-Id: Ia54da0c1388ca3346f6dc7d4e74c4f73899664a3
---
M sc/source/ui/attrdlg/tabpages.cxx
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/sc/source/ui/attrdlg/tabpages.cxx 
b/sc/source/ui/attrdlg/tabpages.cxx
index 1fe9a9d..b0eca20 100644
--- a/sc/source/ui/attrdlg/tabpages.cxx
+++ b/sc/source/ui/attrdlg/tabpages.cxx
@@ -67,7 +67,6 @@
 m_pBtnHideFormula->SetClickHdl( LINK( this, ScTabPageProtection, 
ButtonClickHdl ) );
 m_pBtnHidePrint->SetClickHdl(   LINK( this, ScTabPageProtection, 
ButtonClickHdl ) );
 
-//FreeResource();
 }
 
 // ---

-- 
To view, visit https://gerrit.libreoffice.org/2091
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia54da0c1388ca3346f6dc7d4e74c4f73899664a3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Widget for Calc protect cell tab page

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2075

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/2075/1

Widget for Calc protect cell tab page

* Translated some German comments to English (thanks to David E. Jourdain)
* Moved tab page .ui from sc/ to cui/
* Disabled FreeResource() in tabpages.cxx (need further understanding of the 
consequences)
* Need to address text alignement on the right

Change-Id: I332c263bce7c8f743c60bbe79e23641e9f037474
---
M cui/UI_cui.mk
A cui/uiconfig/ui/cellprotectionpage.ui
M sc/source/ui/attrdlg/tabpages.cxx
M sc/source/ui/inc/attrdlg.hrc
M sc/source/ui/inc/tabpages.hxx
M sc/source/ui/src/attrdlg.src
6 files changed, 275 insertions(+), 149 deletions(-)



diff --git a/cui/UI_cui.mk b/cui/UI_cui.mk
index db290b7..314e526 100644
--- a/cui/UI_cui.mk
+++ b/cui/UI_cui.mk
@@ -11,8 +11,10 @@
 
 $(eval $(call gb_UI_add_uifiles,cui,\
cui/uiconfig/ui/backgroundpage \
+   cui/uiconfig/ui/alignement \
cui/uiconfig/ui/borderpage \
cui/uiconfig/ui/charnamepage \
+   cui/uiconfig/ui/cellprotectionpage \
cui/uiconfig/ui/colorpage \
cui/uiconfig/ui/gradientpage \
cui/uiconfig/ui/colorconfigwin \
diff --git a/cui/uiconfig/ui/cellprotectionpage.ui 
b/cui/uiconfig/ui/cellprotectionpage.ui
new file mode 100644
index 000..1d2fe5e
--- /dev/null
+++ b/cui/uiconfig/ui/cellprotectionpage.ui
@@ -0,0 +1,215 @@
+
+
+  
+  
+False
+6
+15
+6
+
+  
+True
+False
+12
+6
+
+  
+True
+False
+GDK_EXPOSURE_MASK
+True
+0
+none
+
+  
+True
+False
+True
+True
+12
+
+  
+True
+False
+
+  
+True
+False
+vertical
+
+  
+Hide 
_all
+True
+True
+False
+True
+True
+0
+True
+True
+True
+  
+  
+False
+True
+0
+  
+
+
+  
+_Protected
+True
+True
+False
+25
+True
+0
+True
+True
+True
+  
+  
+False
+True
+1
+  
+
+
+  
+Hide 
_formula
+True
+True
+False
+25
+True
+0
+True
+True
+  
+  
+False
+True
+2
+  
+
+  
+  
+0
+0
+1
+1
+  
+
+
+  
+True
+False
+50
+Cell 
protection is only effective after the current sheet has been protected.
+
+Select 'Protect Document' from the 'Tools' menu, and specify 
'Sheet'.
+  
+  
+1
+0
+1
+1
+  
+
+  
+
+  
+
+
+  
+True
+False
+Protection
+
+  
+
+  
+
+  
+  
+0
+0
+1
+1
+  
+
+
+  
+  

Change in core[master]: Remove more STRINGPARAM macros form dbaccess

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1878

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1878
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] String to OUString conversions in filter

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1865

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1865
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I944f4d57aba935e513a3d158a46322874fe0df15
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Only call getScDocument when needed

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1861

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1861
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2dca76af46e63b5dd833f5a60549d4b1a7b03d84
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove some unneeded variables in filter

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1773

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1773
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2963498a197a795155a42b2588f983019d89f35
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove more STRINGPARAM macros from filter

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1772

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1772
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bfed073bd84e4dee4bc7e7b4715e413859beb50
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove more STRINGPARAM macros from dbaccess

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1771

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1771
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5af27d7c980f6b71011c33531a49a82d79fbc8
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#57950: Remove some chained appends in connectivity and..

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1768

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1768
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I919d17e14334c9220b47775355512df8dfa00bca
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove some RTL_* macdros from connectivity and..

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1767

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1767
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07029055a7cbe0d1ea2e6c891e6c7347e3a370a9
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove all rtl:: prefix and RTL_* from basic/qa/cppunit/test...

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1512

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1512
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9bb6018955faa41c359d18c6b2c10b58fd20db9
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove some unused functions

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1517

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1517
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I618de5d34d891b1b183cca12b71aff4128b2f92e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove rtl prefixes and some RTL_CONST* from basic

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1504

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1504
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If15d7c97de5295ea7d7f341e6b34acbfc917218d
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1502

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1502
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bc79699e794de47611d785b9ae48b4badf9f2f6
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove last RTL_CONSTASCII_STRINGPARAM from animations

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1501

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1501
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib774bc7f70492910a2f3e7ac3088c4e07127b563
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove last RTL_CONSTASCII_* from accessibility

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1500

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1500
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in editeng/acessibility

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1471

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1471/1

OUString cleanup in editeng/acessibility

Change-Id: I253444e2859685cae88aa65fae755af2674bd4b4
---
M editeng/source/accessibility/AccessibleImageBullet.cxx
1 file changed, 19 insertions(+), 19 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1471
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I253444e2859685cae88aa65fae755af2674bd4b4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in editeng/acessibility

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1469

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1469/1

OUString cleanup in editeng/acessibility

Change-Id: I5f8b73aab1e67a5ac071427574fa943a844fbf96
---
M editeng/source/accessibility/AccessibleParaManager.cxx
M editeng/source/accessibility/AccessibleSelectionBase.cxx
M editeng/source/accessibility/AccessibleStaticTextBase.cxx
3 files changed, 13 insertions(+), 15 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1469
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f8b73aab1e67a5ac071427574fa943a844fbf96
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanups in editeng/accessibility

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1468

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1468/1

OUString cleanups in editeng/accessibility

Change-Id: Ie280c48cabec4ef9e0c623f8966a65027b975fe4
---
M editeng/source/accessibility/AccessibleComponentBase.cxx
M editeng/source/accessibility/AccessibleContextBase.cxx
M editeng/source/accessibility/AccessibleEditableTextPara.cxx
M editeng/source/accessibility/AccessibleHyperlink.cxx
M editeng/source/accessibility/AccessibleHyperlink.hxx
5 files changed, 70 insertions(+), 79 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1468
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie280c48cabec4ef9e0c623f8966a65027b975fe4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More String cleanup in filter

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1463

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1463
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf628ad51ebe9c841090a5e04c7986c15c726480
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] rtl:: prefixes removal in oox

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1334

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1334
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b24535775df85cc5bb87cc808afcd338ec52df6
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal ::rtl:: prefixes and macros in oxx

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1211

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1211
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12bfb2528e8a9aaf3f119a1e6f0ae0246d16a772
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal ::rtl:: prefixes and macros in oxx

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1212

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1212
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1139b10256387bb71e8a425153d46add181538bc
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal ::rtl:: prefixes and macros in IO

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1210

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1210
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I410016990579e4a05843cfe396832a5fc8435e70
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal ::rtl:: prefixes and macros in IO

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1200

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1200
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9446ddf13ba18d2d80639afc9e1b61234945b115
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo##38838 UniString Removal in dbaccess

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1208

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1208
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c4f8e9834fdd78851f5274ce2b141cfb49e6458
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#38838 UniString -> OUString in cui

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1203

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1203
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16eae4aff2b946421df2b65ecfbd1d9b2e2256b6
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#38838 UniString -> OUString in cui

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1202

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1202
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b629cad4d9b6d4c086bfff47f1d3e9779b2c24d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removed useless method from languagetag

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1204

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1204
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I683c54ed278d5a6ba12eaefb8040c3753a24f119
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Paula Mannes 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Removal ::rtl:: prefixes and macros in IO

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1194

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1194
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I823fcdfe46d4d4093118f6eaab89c1ce42883a6c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Fix missing closing parenthesis

[Olivier Hallot (via Code Review)]

Olivier Hallot has abandoned this change.

Change subject: Fix missing closing parenthesis
..


Patch Set 1: Abandoned

Already fixed in anothe patch

--
To view, visit https://gerrit.libreoffice.org/1182
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3bcfc8bdd771b24d5082a38a7035458e9bc371d1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix missing closing parenthesis

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1182

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1182/1

Fix missing closing parenthesis

breaks make dev-install

Change-Id: I3bcfc8bdd771b24d5082a38a7035458e9bc371d1
---
M solenv/bin/modules/installer/archivefiles.pm
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1182
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bcfc8bdd771b24d5082a38a7035458e9bc371d1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More ::rtl::OUString -> OUString in canvas

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1175

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1175
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If99dfc98ace1bf62cd5ab05c596f4f6ffc5fbd2f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl prefix removal in canvas

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1181

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1181
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab6aaa9f06dfe69c85db5e87f9512db0eb44caa8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] rtl::OUString cleanup in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/872

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/872
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] 766 gerrit patch, fix appendAscii in bastype2.cxx

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/854

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/854
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4409d1b0585a8c52cba14d1e67ccf776c6070c8a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in Chart2

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/830

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/830/1

OUString cleanup in Chart2

Include C2U macro and rtl cleanup

Change-Id: I4543a3a6d6a6971d2c31b8dc36bd2ec95bd892d4
---
M chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx
M chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx
M chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
M chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
M chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx
M chart2/source/controller/main/ChartController.cxx
6 files changed, 196 insertions(+), 199 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/830
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4543a3a6d6a6971d2c31b8dc36bd2ec95bd892d4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in Chart2

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/829

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/829/1

OUString cleanup in Chart2

Include C2U macro and rtl prefix

Change-Id: If930f77179dbf24d43f10a344b68edcf968f7304
---
M chart2/source/controller/dialogs/tp_RangeChooser.cxx
M chart2/source/controller/dialogs/tp_RangeChooser.hxx
M chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
M chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
M chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx
M chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
M chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx
M chart2/source/controller/itemsetwrapper/GraphicPropertyItemConverter.cxx
8 files changed, 231 insertions(+), 236 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/829
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If930f77179dbf24d43f10a344b68edcf968f7304
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in Chart2

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/828

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/828/1

OUString cleanup in Chart2

Include C2U macro and rtl prefix

Change-Id: I01c3224bc21a7f8a03a8562191fbc161032f2a1d
---
M chart2/source/controller/dialogs/res_ErrorBar.cxx
M chart2/source/controller/dialogs/res_LegendPosition.cxx
M chart2/source/controller/dialogs/res_TextSeparator.cxx
M chart2/source/controller/dialogs/res_TextSeparator.hxx
M chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
M chart2/source/controller/dialogs/tp_3D_SceneGeometry.cxx
M chart2/source/controller/dialogs/tp_ChartType.cxx
M chart2/source/controller/dialogs/tp_DataSource.cxx
8 files changed, 43 insertions(+), 43 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/828
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01c3224bc21a7f8a03a8562191fbc161032f2a1d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUString cleanup in Chart2

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/827

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/827/1

OUString cleanup in Chart2

Include C2U macro removal and rtl prefix

Change-Id: I3de75446e53618862e50c69382a7ddaf0d482fa7
---
M chart2/source/controller/dialogs/ChartTypeDialogController.cxx
M chart2/source/controller/dialogs/DataBrowser.cxx
M chart2/source/controller/dialogs/DataBrowserModel.cxx
M chart2/source/controller/dialogs/DialogModel.cxx
M chart2/source/controller/dialogs/ObjectNameProvider.cxx
M chart2/source/controller/dialogs/RangeSelectionHelper.cxx
M chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx
M chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
8 files changed, 220 insertions(+), 225 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/827
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3de75446e53618862e50c69382a7ddaf0d482fa7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More ::rtl::OUString cleanup in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/760

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/760
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7cefe8d2e188e65a465a25a5d5f77e6daebcd17
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString to OUString in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/748

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/748
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34228049e15ee8a899a4c5e1484d7ed3bc541dd4
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString and RTL_CONSTASCII_US... cleanup in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/741

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/741
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I440d245d013873ec2830280ad01a4d0625fc4c1a
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Update in Brazilian autocorrection

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/724

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/724/1

Update in Brazilian autocorrection

Change-Id: Ifcd7410f659a76ac34f18bb561b2eaffa6ecbd3d
---
M extras/source/autotext/lang/pt-BR/acor/DocumentList.xml
M extras/source/autotext/lang/pt-BR/acor/WordExceptList.xml
2 files changed, 18 insertions(+), 17 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/724
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcd7410f659a76ac34f18bb561b2eaffa6ecbd3d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString to OUString in basctl

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/711

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/711
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7be699102eab9cbf7184a5777a4b161db885adec
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused code

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/682

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/682/1

Remove unused code

According to unusedcode.easy

Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9
---
M sd/source/ui/dlg/RemoteDialogClientBox.cxx
1 file changed, 0 insertions(+), 194 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/682
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31edd26d8ee7934b47ed7bf5ec6c07e1b8c5c5e9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] End of ::rtl::OUString to OUString in avmedia

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/675

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/675
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ac8f773ddb72b94d1371fe60948fb2782ddecd4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Autocorrection improvements for pt-BR

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/674

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/674/1

Autocorrection improvements for pt-BR

Change-Id: I55d48590333e7d60fdc34c44c4c9102be6c52f08
---
M extras/source/autotext/lang/pt-BR/acor/DocumentList.xml
M extras/source/autotext/lang/pt-BR/acor/SentenceExceptList.xml
M extras/source/autotext/lang/pt-BR/acor/WordExceptList.xml
3 files changed, 3,665 insertions(+), 5,042 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/674
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55d48590333e7d60fdc34c44c4c9102be6c52f08
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Fix acor_pt-BR build

[Olivier Hallot (via Code Review)]

Olivier Hallot has abandoned this change.

Change subject: Fix acor_pt-BR build
..


Patch Set 1: Abandoned

Already set in master by A. Timar

--
To view, visit https://gerrit.libreoffice.org/669
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia92aaa798a488d35ef9f43d30589ffd5fcd2e16f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Andras Timar 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] rtl::OUString to OUString in unotools

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/670

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/670
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d045c6947fa2acb86befdb9bf43c666f82e8858
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix acor_pt-BR build

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/669

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/669/1

Fix acor_pt-BR build

Fix pt-BR autocorrection build

Change-Id: Ia92aaa798a488d35ef9f43d30589ffd5fcd2e16f
---
M extras/CustomTarget_autocorr.mk
1 file changed, 1 insertion(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/669
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia92aaa798a488d35ef9f43d30589ffd5fcd2e16f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Update acor_pt-PT.dat and fix fdo#54362

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/667

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/667/1

Update acor_pt-PT.dat and fix fdo#54362

Update and fix autocorrection entry for pt-BR, add entries in WordExceptList 
and add SentenceExceptList (borrowed from pt-PT)

Change-Id: I5b38b8a072aefb28ce52710c0b4570123ee1bc12
---
M extras/source/autotext/lang/pt-BR/acor/BlockList.xml
M extras/source/autotext/lang/pt-BR/acor/DocumentList.xml
M extras/source/autotext/lang/pt-BR/acor/META-INF/manifest.xml
A extras/source/autotext/lang/pt-BR/acor/SentenceExceptList.xml
M extras/source/autotext/lang/pt-BR/acor/WordExceptList.xml
5 files changed, 107 insertions(+), 53 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/667
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b38b8a072aefb28ce52710c0b4570123ee1bc12
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More ::rtl::OUString to OUString in avmedia

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/621

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/621
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e49d84b5a7aa47dc315735a8198ba7fdde0b4e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More ::rtl::OUString to OUString in avmedia

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/625

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/625
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5478199d8ff1cd79dc54e680e8a6c257e7d8325
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString to OUString in avmedia

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/609

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/609
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4a7bef339a626fbfa9f0c1cc76801e77626f38f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More ::rtl::OUString to OUString and RTL_CONSTASCII in avmed...

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/610

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/610
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I925862289cf5f9f41af5532bbbaf8ec0a4e5a66b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Finished ::rtl::OUString to OUString in UnoControls

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/601

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/601
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48409908bd1639d6a69217c7f94ebce04464487f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString to OUString in UnoControls

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/597

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/597
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12a95e61e7bf59c64fec7df98617926b774074ee
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fix bug fdo#53520, pt-PT and pt-BR better split

[Olivier Hallot (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/592

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/592/1

fix bug fdo#53520, pt-PT and pt-BR better split

This patch fixes fdo#53520: Portuguese language spelling package names and 
split the files into the proper directories.

Change-Id: Iff10cfee1da2c4775e4cf9050ec154052ee18ac9
---
M scp2/source/ooo/common_brand.scp
M setup_native/source/packinfo/packinfo_office.txt
2 files changed, 7 insertions(+), 7 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/592
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff10cfee1da2c4775e4cf9050ec154052ee18ac9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString cleanup in vbahelper/msforms

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/578

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/578
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I834c5f1f26f941a5db84b677f34ffa686e0c2544
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More OUString cleanup in vbahelper

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/577

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/577
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c650da762e9d5afea9018dd2c6496fcd14ca6f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] More OUString cleanup in vbahelper

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/576

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/576
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf1661c612486a3d5259d0e78dd03294d5eeef76
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Some OUString cleanup in vbahelper

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/574

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/574
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc1411805fcf0a75ea9f660fd9ee8f5fdcda6b1d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Olivier Hallot 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString cleanup in accessibility

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/583

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/583
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifceaa764231306c1f542183afc2e852cc418
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString cleanup in animations

[Olivier Hallot (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/584

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/584
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib858f9fa709d72539f71a6473a4ecb519d68e98e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice