Re: [Libreoffice] [Libreoffice-qa] Improving the QA and Release for 3.5
No those days aren't the only way to test. But it is a way to get more people to test the software and to test the software in ways that the developers won't think about. I think there are enough people that want to help but don't know how, and testing is a easy way to step in. At last I also hear from people around me that LO tests way to little because of all the bugs that have pleaged the 3.4-series. When we shout this around people can see we do test and are doing our best to get bugs out of the software. All in all I would say it is needed to organise these events.. Greetings, Rob Snelders On di 22 nov 2011 20:03:33 CET, Petr Mladek wrote: Cor Nouws píše v So 19. 11. 2011 v 16:56 +0100: Cor Nouws wrote (13-11-11 21:20) Rainer Bielefeld wrote (11-11-11 20:06) https://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5 I'm afraid "Try to get more testers doing the testing earlier" will be the critical/limiting condition. [...] The idea here is the following: When a beta is announced, many people jump in to test. Now it would be great if we could attract (part of) that group to start working with the developer builds asap after feature freeze! (Arrows #1 on slide 23) Would that make sense? So, while at our 4th Dutch LibreOffice (Hackers) event, we discussed this. Since in The Netherlands we have both a busy Sinterklaas fest and a long Christmas time, and we are already in the end of November, there is little change in organising a successful test-event in December, Anyway not for us. A test-event, was one of the ideas from the presentation (1), slide #24 So we think about January 21, convenient for all involved here. But looking at the release plan, that is just after the RC1 for 3.5.0. Which is sad, because the goal is to get more people test early, thus after the first/second build after feature freeze... - Would it be an idea to work parallel in some countries (France, Germany)...? - January 21 is a possibility.. - But another moment earlier too, so that some of us (Nl/Flanders) could join virtual? Heh, the first beta should be available on December 9. I hope that we could do lots testing already in December. We should not need an exact date to do some testing. We are improving the Limus server [1] and fill reasonable test cases there. We will create test run when the beta1 is available. Anyone could jump in and process few tests when time permits. The server will clearly show what was tested, what still needs testing. Testers could work completely independently. Organized events are fine but it can be done other way. We do not need to depend on them. IMPORTANT: We are looking for people creating test cases[2]. Reference: [1] http://wiki.documentfoundation.org/Litmus https://tcm.documentfoundation.org/ [2] http://wiki.documentfoundation.org/QA/Testing/Test_Case Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Problems with mozilla build-tools on WindowsXP
Hi All, I have followed [1] as a guide to build LO on windows. But when I run autogen it comes with "Mozilla build tooling incomplete". I run autogen with the options --with-mozilla-build='/cygwin/c/mozilla-build and --disable-build-mozilla. I have also downloaded the prebuild mozilla modules and set them in moz/zipped When it failed I downloaded the moztools-static.zip from the mozilla-buildtools-ftp and put that in the buildtools-directory. But that also didn't help. Does anybody knows why this error is given? [1] http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [bug fdo#41326] UI: Impossible to select text from the input line in a read-only document
Hi All, I had the same problem as the people in this bug. Isn't it possible to enable the feature to select text in Read-Only-documents by default? I think it will help a lot of people when opening documents from, for example, email. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Patch for Easy Hack 45033
Hi, Are you sure this is the correct file? When I open the file I only see OpenOffice and StarOffice entries. Maybe someone else can check what he/she sees. Greetings, Rob Snelders On 13-02-12 22:06, Italo Vignoli wrote: On 2/13/12 9:44 PM, Jan Holesovsky wrote: If you can attach the file, that would be most helpful. I am unable to reasonably extract the patch from the message - sorry for that, but the way that works for me flawlessly for text-only patches failed on this binary one :-( No problem. You know that I am not familiar with patches, so I was not sure about attaching the file when I have sent the patch. Probably, the file would be transferred by pushing the patch on master, but I do not feel confident about doing this myself. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] patch lib-core/eventattacher
Hi,
Here is a small patch which translates the comments in the
eventattacher from German to English
--
Greetings,
Rob Sneldersdiff --git a/eventattacher/source/eventattacher.cxx b/eventattacher/source/eventattacher.cxx
index 6cae50e..7599431 100644
--- a/eventattacher/source/eventattacher.cxx
+++ b/eventattacher/source/eventattacher.cxx
@@ -253,7 +253,7 @@ private:
Mutexm_aMutex;
Reference< XMultiServiceFactory > m_xSMgr;
-// Services merken
+// Save Services
Reference< XIntrospection >m_xIntrospection;
Reference< XIdlReflection >m_xReflection;
Reference< XTypeConverter >m_xConverter;
@@ -374,11 +374,10 @@ void SAL_CALL EventAttacherImpl::initialize(const Sequence< Any >& Arguments) th
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XIntrospection > EventAttacherImpl::getIntrospection() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xIntrospection.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.beans.Introspection")) ) );
@@ -392,7 +391,6 @@ Reference< XIntrospection > EventAttacherImpl::getIntrospection() throw( Excepti
Reference< XIdlReflection > EventAttacherImpl::getReflection() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xReflection.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.reflection.CoreReflection")) ) );
@@ -402,11 +400,10 @@ Reference< XIdlReflection > EventAttacherImpl::getReflection() throw( Exception
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XInvocationAdapterFactory > EventAttacherImpl::getInvocationAdapterService() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xInvocationAdapterFactory.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.script.InvocationAdapterFactory")) ) );
@@ -417,11 +414,10 @@ Reference< XInvocationAdapterFactory > EventAttacherImpl::getInvocationAdapterSe
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XTypeConverter > EventAttacherImpl::getConverter() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xConverter.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.script.Converter")) ) );
@@ -433,8 +429,8 @@ Reference< XTypeConverter > EventAttacherImpl::getConverter() throw( Exception )
//
//
//
-// Implementation eines EventAttacher-bezogenen AllListeners, der
-// nur einzelne Events an einen allgemeinen AllListener weiterleitet
+// Implementation of a EventAttacher-related AllListeners, which brings
+// a few Events to a general AllListener
class FilterAllListenerImpl : public WeakImplHelper1< XAllListener >
{
public:
@@ -473,7 +469,6 @@ FilterAllListenerImpl::FilterAllListenerImpl( EventAttacherImpl * pEA_, const OU
void SAL_CALL FilterAllListenerImpl::firing(const AllEventObject& Event)
throw( RuntimeException )
{
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod && m_AllListener.is() )
m_AllListener->firing( Event );
}
@@ -529,7 +524,6 @@ Any SAL_CALL FilterAllListenerImpl::approveFiring( const AllEventObject& Event )
{
Any aRet;
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod && m_AllListener.is() )
aRet = m_AllListener->approveFiring( Event );
else
@@ -579,35 +573,30 @@ Reference< XEventListener > EventAttacherImpl::attachListener
Reference< XEventListener > xRet = NULL;
-// InvocationAdapterService holen
Reference< XInvocationAdapterFactory > xInvocationAdapterFactory = getInvocationAdapterService();
if( !xInvocationAdapterFactory.is() )
throw ServiceNotRegisteredException();
-// Listener-Klasse per Reflection besorgen
Reference< XIdlReflection > xReflection = getReflection();
if( !xReflection.is() )
throw ServiceNotRegisteredException();
-// Anmelden, dazu passende addListener-Methode aufrufe
[Libreoffice] patch translating comments
Hi,
I have attached a patch in which the German comments are translated to
English where needed. Also removed some useless comments and empty lines.
It covers the linguistic-, vbahelper-, ucb-directories in the
lib-core-directory of the source.
This patch is submitted under LGPLv3+/MPL-Licence.
I have also send a patch earlier this day, which I also want to submit
under the LGPLv3+/MPL-Licence, but I forgot to mention that.
--
Greetings,
Rob Snelders
diff --git a/eventattacher/source/eventattacher.cxx b/eventattacher/source/eventattacher.cxx
index 6cae50e..7599431 100644
--- a/eventattacher/source/eventattacher.cxx
+++ b/eventattacher/source/eventattacher.cxx
@@ -253,7 +253,7 @@ private:
Mutexm_aMutex;
Reference< XMultiServiceFactory > m_xSMgr;
-// Services merken
+// Save Services
Reference< XIntrospection >m_xIntrospection;
Reference< XIdlReflection >m_xReflection;
Reference< XTypeConverter >m_xConverter;
@@ -374,11 +374,10 @@ void SAL_CALL EventAttacherImpl::initialize(const Sequence< Any >& Arguments) th
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XIntrospection > EventAttacherImpl::getIntrospection() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xIntrospection.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.beans.Introspection")) ) );
@@ -392,7 +391,6 @@ Reference< XIntrospection > EventAttacherImpl::getIntrospection() throw( Excepti
Reference< XIdlReflection > EventAttacherImpl::getReflection() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xReflection.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.reflection.CoreReflection")) ) );
@@ -402,11 +400,10 @@ Reference< XIdlReflection > EventAttacherImpl::getReflection() throw( Exception
}
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XInvocationAdapterFactory > EventAttacherImpl::getInvocationAdapterService() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xInvocationAdapterFactory.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.script.InvocationAdapterFactory")) ) );
@@ -417,11 +414,10 @@ Reference< XInvocationAdapterFactory > EventAttacherImpl::getInvocationAdapterSe
//*
-//*** Private Hilfs-Methoden ***
+//*** Private Hilfs-Methods ***
Reference< XTypeConverter > EventAttacherImpl::getConverter() throw( Exception )
{
Guard< Mutex > aGuard( m_aMutex );
-// Haben wir den Service schon? Sonst anlegen
if( !m_xConverter.is() )
{
Reference< XInterface > xIFace( m_xSMgr->createInstance( rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.script.Converter")) ) );
@@ -433,8 +429,8 @@ Reference< XTypeConverter > EventAttacherImpl::getConverter() throw( Exception )
//
//
//
-// Implementation eines EventAttacher-bezogenen AllListeners, der
-// nur einzelne Events an einen allgemeinen AllListener weiterleitet
+// Implementation of a EventAttacher-related AllListeners, which brings
+// a few Events to a general AllListener
class FilterAllListenerImpl : public WeakImplHelper1< XAllListener >
{
public:
@@ -473,7 +469,6 @@ FilterAllListenerImpl::FilterAllListenerImpl( EventAttacherImpl * pEA_, const OU
void SAL_CALL FilterAllListenerImpl::firing(const AllEventObject& Event)
throw( RuntimeException )
{
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod && m_AllListener.is() )
m_AllListener->firing( Event );
}
@@ -529,7 +524,6 @@ Any SAL_CALL FilterAllListenerImpl::approveFiring( const AllEventObject& Event )
{
Any aRet;
-// Nur durchreichen, wenn es die richtige Methode ist
if( Event.MethodName == m_EventMethod && m_AllListener.is() )
aRet = m_AllListener->approveFiring( Event );
else
@@ -579,35 +573,30 @@ Reference< XEventListener >
[Libreoffice] [PATCH][easy hacks] translation comments
Hi,
Here is a small patch that translates some comments I forgot last patch.
I submit this patch under LGPLv3+/MPL-Licence.
--
M.V.G.
Rob Snelders
diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx
index aed850b..3078a20 100644
--- a/linguistic/source/dlistimp.cxx
+++ b/linguistic/source/dlistimp.cxx
@@ -345,7 +345,7 @@ void DicList::SearchForDictionaries(
if(!::IsVers2OrNewer( aURL, nLang, bNeg ))
{
-// Wenn kein
+// When no
xub_StrLen nPos = aURL.Search('.');
String aExt(aURL.Copy(nPos + 1));
aExt.ToLowerAscii();
@@ -358,9 +358,8 @@ void DicList::SearchForDictionaries(
continue; // andere Files
}
-// Aufnehmen in die Liste der Dictionaries
-// Wenn existent nicht aufnehmen
-//
+// Record in the list of Dictoinaries
+ // When it already exists don't record
INT16 nSystemLanguage = MsLangId::getSystemLanguage();
String aTmp1 = ToLower( aURL, nSystemLanguage );
xub_StrLen nPos = aTmp1.SearchBackward( '/' );
diff --git a/vbahelper/source/vbahelper/vbaapplicationbase.cxx b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
index 3dc77cb..33809cb 100644
--- a/vbahelper/source/vbahelper/vbaapplicationbase.cxx
+++ b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
@@ -89,7 +89,7 @@ public:
Time aTimeNow;
Date aRefDate( 1,1,1900 );
long nDiffDays = (long)(aDateNow - aRefDate);
-nDiffDays += 2; // Anpassung VisualBasic: 1.Jan.1900 == 2
+nDiffDays += 2; // Change VisualBasic: 1.Jan.1900 == 2
long nDiffSeconds = aTimeNow.GetHour() * 3600 + aTimeNow.GetMin() * 60 + aTimeNow.GetSec();
return (double)nDiffDays + ((double)nDiffSeconds)/(double)(24*3600);
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Translate Comments
Hi,
I have translated some comments in the libs-core/connectivity-directory.
I submit this patch under LGPLv3+/MPL-Licence.
--
M.V.G.
Rob Snelders
>From f51e94441d7e7f5f8bd75e9b44a79bf9342cc0cb Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 23 Mar 2011 23:16:24 +0100
Subject: [PATCH] translated comments
---
connectivity/source/drivers/dbase/dindexnode.cxx |2 +-
.../source/drivers/jdbc/ResultSetMetaData.cxx |2 +-
connectivity/source/drivers/jdbc/SQLException.cxx |4 +-
connectivity/source/drivers/jdbc/SQLWarning.cxx|2 +-
connectivity/source/drivers/jdbc/String.cxx|2 +-
connectivity/source/drivers/jdbc/Throwable.cxx |2 +-
connectivity/source/drivers/jdbc/Timestamp.cxx | 18 ++--
connectivity/source/drivers/jdbc/tools.cxx | 22 +++---
.../source/drivers/mozab/MPreparedStatement.cxx| 16 ++--
connectivity/source/drivers/mozab/MResultSet.cxx |3 +-
connectivity/source/drivers/mozab/MStatement.hxx |2 +-
connectivity/source/drivers/odbc/OFunctions.cxx|4 +-
connectivity/source/drivers/odbc/ORealDriver.cxx | 10 +-
connectivity/source/drivers/odbcbase/OTools.cxx| 79 +---
.../inc/FDatabaseMetaDataResultSetMetaData.hxx |1 +
.../source/inc/adabas/BResultSetMetaData.hxx |2 +-
connectivity/source/inc/ado/ACallableStatement.hxx |2 +-
.../source/inc/ado/ADatabaseMetaDataResultSet.hxx |2 +-
.../inc/ado/ADatabaseMetaDataResultSetMetaData.hxx |2 +-
connectivity/source/inc/ado/APreparedStatement.hxx |2 +-
connectivity/source/inc/ado/AResultSet.hxx |2 +-
connectivity/source/inc/ado/AResultSetMetaData.hxx |2 +-
connectivity/source/inc/ado/AStatement.hxx |2 +-
.../inc/dbase/DDatabaseMetaDataResultSet.hxx |2 +-
.../dbase/DDatabaseMetaDataResultSetMetaData.hxx |2 +-
.../source/inc/file/FPreparedStatement.hxx |2 +-
connectivity/source/inc/file/FResultSet.hxx|2 +-
.../source/inc/file/FResultSetMetaData.hxx |2 +-
connectivity/source/inc/file/FStatement.hxx|2 +-
connectivity/source/inc/java/io/InputStream.hxx|8 +-
connectivity/source/inc/java/io/Reader.hxx |5 +-
connectivity/source/inc/java/lang/Boolean.hxx |4 +-
connectivity/source/inc/java/lang/Class.hxx|6 +-
connectivity/source/inc/java/lang/Exception.hxx|4 +-
connectivity/source/inc/java/lang/String.hxx |4 +-
connectivity/source/inc/java/lang/Throwable.hxx|4 +-
connectivity/source/inc/java/math/BigDecimal.hxx |4 +-
37 files changed, 113 insertions(+), 123 deletions(-)
diff --git a/connectivity/source/drivers/dbase/dindexnode.cxx b/connectivity/source/drivers/dbase/dindexnode.cxx
index 89362ca..f928d6e 100755
--- a/connectivity/source/drivers/dbase/dindexnode.cxx
+++ b/connectivity/source/drivers/dbase/dindexnode.cxx
@@ -486,7 +486,7 @@ void ONDXPage::Merge(sal_uInt16 nParentNodePos, ONDXPagePtr xPage)
nMaxNodes_2 = nMaxNodes / 2;
// Determine if page is right or left neighbour
-sal_Bool bRight= ((*xPage)[0].GetKey() > (*this)[0].GetKey()); // sal_True, wenn xPage die rechte Seite ist
+sal_Bool bRight= ((*xPage)[0].GetKey() > (*this)[0].GetKey()); // sal_True, whenn xPage the right side is
sal_uInt16 nNewCount = (*xPage).Count() + Count();
if (IsLeaf())
diff --git a/connectivity/source/drivers/jdbc/ResultSetMetaData.cxx b/connectivity/source/drivers/jdbc/ResultSetMetaData.cxx
index 15ce6fe..a6da067 100755
--- a/connectivity/source/drivers/jdbc/ResultSetMetaData.cxx
+++ b/connectivity/source/drivers/jdbc/ResultSetMetaData.cxx
@@ -63,7 +63,7 @@ java_sql_ResultSetMetaData::~java_sql_ResultSetMetaData()
jclass java_sql_ResultSetMetaData::getMyClass() const
{
RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "jdbc", "ocke.jans...@sun.com", "java_sql_ResultSetMetaData::getMyClass" );
-// die Klasse muss nur einmal geholt werden, daher statisch
+// The class needs to be fetched just once, that is why it is static
if( !theClass )
theClass = findMyClass("java/sql/ResultSetMetaData");
return theClass;
diff --git a/connectivity/source/drivers/jdbc/SQLException.cxx b/connectivity/source/drivers/jdbc/SQLException.cxx
index 26c94f5..a0ebe17 100755
--- a/connectivity/source/drivers/jdbc/SQLException.cxx
+++ b/connectivity/source/drivers/jdbc/SQLException.cxx
@@ -66,7 +66,7 @@ jclass java_sql_SQLException_BASE::getMyClass() const
}
jclass java_sql_SQLException_BASE::st_getMyClass()
{
-// die Klasse muss nur einmal geholt werden, daher statisch
+// The class needs to be fetched just once, that is why it is static
if( !theClass )
theClass = findMyClass("java/sql/SQLException");
return theClass;
@@ -77,7 +77,7 @@ starsdbc::SQLException java_sql_SQLException_BASE::getNextException() c
[Libreoffice] [PATCH] Adding and Removing Color Charts
Hi
I have created a patch that enables users to add and remove Color Charts.
--
Greetings,
Rob Snelders
>From 4188ad2d7911a898a283d6dccdfe84bb1f0ef1ad Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 24 Mar 2011 21:33:46 +0100
Subject: [PATCH] Added the Adding and removing of color charts
---
cui/source/options/cfgchart.cxx | 50 +++---
cui/source/options/cfgchart.hxx |9 +-
cui/source/options/optchart.cxx | 44 +-
cui/source/options/optchart.hrc |3 +-
cui/source/options/optchart.hxx | 14 +++
cui/source/options/optchart.src | 24 ++
6 files changed, 115 insertions(+), 29 deletions(-)
diff --git a/cui/source/options/cfgchart.cxx b/cui/source/options/cfgchart.cxx
index 4b449a0..0d406cd 100644
--- a/cui/source/options/cfgchart.cxx
+++ b/cui/source/options/cfgchart.cxx
@@ -43,7 +43,8 @@ SvxChartColorTable::SvxChartColorTable()
{}
SvxChartColorTable::SvxChartColorTable( const SvxChartColorTable & _rSource ) :
-m_aColorEntries( _rSource.m_aColorEntries )
+m_aColorEntries( _rSource.m_aColorEntries ),
+nNextElementNumber( m_aColorEntries.size() + 1 )
{}
// accessors
@@ -79,6 +80,7 @@ ColorData SvxChartColorTable::getColorData( size_t _nIndex ) const
void SvxChartColorTable::clear()
{
m_aColorEntries.clear();
+nNextElementNumber = 1;
}
void SvxChartColorTable::append( const XColorEntry & _rEntry )
@@ -86,6 +88,12 @@ void SvxChartColorTable::append( const XColorEntry & _rEntry )
m_aColorEntries.push_back( _rEntry );
}
+void SvxChartColorTable::remove( size_t _nIndex )
+{
+if (m_aColorEntries.size() > 0)
+m_aColorEntries.erase( m_aColorEntries.begin() + _nIndex);
+}
+
void SvxChartColorTable::replace( size_t _nIndex, const XColorEntry & _rEntry )
{
DBG_ASSERT( _nIndex <= m_aColorEntries.size(),
@@ -113,25 +121,37 @@ void SvxChartColorTable::useDefault()
clear();
-String aResName( CUI_RES( RID_SVXSTR_DIAGRAM_ROW ) );
-String aPrefix, aPostfix, aName;
-xub_StrLen nPos = aResName.SearchAscii( "$(ROW)" );
-if( nPos != STRING_NOTFOUND )
+for( sal_Int32 i=0; i m_aColorEntries;
+int nNextElementNumber;
+String sDefaultNamePrefix;
+String sDefaultNamePostfix;
public:
SvxChartColorTable();
@@ -57,8 +60,10 @@ public:
// mutators
void clear();
void append( const XColorEntry & _rEntry );
+void remove( size_t _nIndex );
void replace( size_t _nIndex, const XColorEntry & _rEntry );
void useDefault();
+String getNextDefaultName();
// comparison
bool operator==( const SvxChartColorTable & _rOther ) const;
@@ -70,8 +75,8 @@ public:
class SvxChartOptions : public ::utl::ConfigItem
{
private:
-SvxChartColorTable maDefColors;
-sal_Bool mbIsInitialized;
+SvxChartColorTable maDefColors;
+sal_BoolmbIsInitialized;
::com::sun::star::uno::Sequence< ::rtl::OUString >
maPropertyNames;
diff --git a/cui/source/options/optchart.cxx b/cui/source/options/optchart.cxx
index dc3b64a..51d48d4 100644
--- a/cui/source/options/optchart.cxx
+++ b/cui/source/options/optchart.cxx
@@ -60,11 +60,15 @@ SvxDefaultColorOptPage::SvxDefaultColorOptPage( Window* pParent, const SfxItemSe
aLbChartColors ( this, CUI_RES( LB_CHART_COLOR_LIST ) ),
aGbColorBox ( this, CUI_RES( FL_COLOR_BOX ) ),
aValSetColorBox ( this, CUI_RES( CT_COLOR_BOX ) ),
-aPBDefault ( this, CUI_RES( PB_RESET_TO_DEFAULT ) )
+aPBDefault ( this, CUI_RES( PB_RESET_TO_DEFAULT ) ),
+aPBAdd ( this, CUI_RES( PB_ADD_CHART_COLOR ) ),
+aPBRemove ( this, CUI_RES( PB_REMOVE_CHART_COLOR ) )
{
FreeResource();
aPBDefault.SetClickHdl( LINK( this, SvxDefaultColorOptPage, ResetToDefaults ) );
+aPBAdd.SetClickHdl( LINK( this, SvxDefaultColorOptPage, AddChartColor ) );
+aPBRemove.SetClickHdl( LINK( this, SvxDefaultColorOptPage, RemoveChartColor ) );
aLbChartColors.SetSelectHdl( LINK( this, SvxDefaultColorOptPage, ListClickedHdl ) );
aValSetColorBox.SetSelectHdl( LINK( this, SvxDefaultColorOptPage, BoxClickedHdl ) );
@@ -195,6 +199,44 @@ IMPL_LINK( SvxDefaultColorOptPage, ResetToDefaults, void *, EMPTYARG )
return 0L;
}
+// AddChartColor
+//
+
+IMPL_LINK( SvxDefaultColorOptPage, AddChartColor, void *, EMPTYARG )
+{
+if( pColorConfig )
+{
+ColorData black = RGB_COLORDATA( 0x00, 0x00, 0x00 );
+
+pColorConfig->GetColorTable().append (XColorEntry ( black, pColorConfig->GetColorTable().getNextDefaultName()));
+
+aLbChartColors.Clear();
+aLbChartColors.FillBox( pColorConfig->GetColorTable() );
+
+aLbChartColors.GetFocus();
+}
+
+return 0
Re: [Libreoffice] [PUSHED] Adding and Removing Color Charts
On 25-03-11 07:20, Michael Meeks wrote: Hi Rob, On Thu, 2011-03-24 at 21:37 +0100, Rob Snelders wrote: I have created a patch that enables users to add and remove Color Charts. Oooh, nice :-) I had a play with Tools->Options->Chart colors, and it seems to work very nicely - I tried the corner cases of no colors, and so on and they seem to work. Adding black colors is a bit nasty though :-) I wonder if we could clone the previously selected color instead (?) The only problem is that when you select a color it will set that color for the selected item. So you change the color-chart you already had. Also, I guess perhaps we should dynamically renumber / rename the existing colors if we remove colors in the middle (?) although its not perhaps very cricical (thoughts on that ?). I also think that is needed. Also it will be needed to select the added item when you add an item, and select the next item when you delete an item. I'll try to work on that next week. Anyhow - I've pushed it; can you confirm it is licensed LGPLv3+/MPL ? and was this a result of the Netherlands hack-fest ? :-) it should show up in 3.4. Yes, this is a result of that hack-fest. It was fun and enlightning to work there, I there will be another one, there where plans. ATB, Michael. Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Adding and Removing Color Charts
On 26-03-11 01:04, Rob Snelders wrote: Anyhow - I've pushed it; can you confirm it is licensed LGPLv3+/MPL ? Yes, it is licensed under LGPLv3+/MPL Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts
Hi,
I have improved my last patch for the Color Charts.
It now renames the Color Charts, asks a question before removing of a
color and selects a new color when deleting of when setting to default.
This patch is under the LGPLv3+/MPL-licence.
--
Greetings,
Rob Snelders
On 24-03-11 21:37, Rob Snelders wrote:
Hi
I have created a patch that enables users to add and remove Color Charts.
>From c84677e11fc85df12797a8700332961d42ae6b97 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 31 Mar 2011 20:55:53 +0200
Subject: [PATCH] Improvement of adding and removing color charts
---
cui/source/inc/cuires.hrc |2 ++
cui/source/options/cfgchart.cxx | 11 ---
cui/source/options/cfgchart.hxx |2 +-
cui/source/options/optchart.cxx | 32 ++--
cui/source/options/optchart.hxx |3 ++-
cui/source/options/optchart.src | 10 ++
6 files changed, 49 insertions(+), 11 deletions(-)
diff --git a/cui/source/inc/cuires.hrc b/cui/source/inc/cuires.hrc
index 24d3ce2..226b8f7 100644
--- a/cui/source/inc/cuires.hrc
+++ b/cui/source/inc/cuires.hrc
@@ -157,6 +157,8 @@
#define RID_SVXPAGE_ACCESSIBILITYCONFIG (RID_SVX_START + 250)
#define RID_SVXPAGE_ASIAN_LAYOUT(RID_SVX_START + 246)
#define RID_OPTPAGE_CHART_DEFCOLORS (RID_SVX_START + 299)
+#define RID_OPTQB_COLOR_CHART_DELETE(RID_SVX_START + 296)
+#define RID_OPTSTR_COLOR_CHART_DELETE (RID_SVX_START + 289)
#define RID_SVXPAGE_COLORCONFIG (RID_SVX_START + 249)
#define RID_SVXQB_DELETE_COLOR_CONFIG (RID_SVX_START + 324)
#define RID_SVXSTR_COLOR_CONFIG_SAVE1 (RID_SVX_START + 853)
diff --git a/cui/source/options/cfgchart.cxx b/cui/source/options/cfgchart.cxx
index 0d406cd..969eae0 100644
--- a/cui/source/options/cfgchart.cxx
+++ b/cui/source/options/cfgchart.cxx
@@ -92,6 +92,11 @@ void SvxChartColorTable::remove( size_t _nIndex )
{
if (m_aColorEntries.size() > 0)
m_aColorEntries.erase( m_aColorEntries.begin() + _nIndex);
+
+for (size_t i=0 ; i
+#include
#include // for SID_SCH_EDITOPTIONS
//
@@ -194,6 +195,7 @@ IMPL_LINK( SvxDefaultColorOptPage, ResetToDefaults, void *, EMPTYARG )
aLbChartColors.FillBox( pColorConfig->GetColorTable() );
aLbChartColors.GetFocus();
+aLbChartColors.SelectEntryPos( 0 );
}
return 0L;
@@ -208,12 +210,13 @@ IMPL_LINK( SvxDefaultColorOptPage, AddChartColor, void *, EMPTYARG )
{
ColorData black = RGB_COLORDATA( 0x00, 0x00, 0x00 );
-pColorConfig->GetColorTable().append (XColorEntry ( black, pColorConfig->GetColorTable().getNextDefaultName()));
+pColorConfig->GetColorTable().append (XColorEntry ( black, pColorConfig->GetColorTable().getDefaultName(pColorConfig->GetColorTable().size(;
aLbChartColors.Clear();
aLbChartColors.FillBox( pColorConfig->GetColorTable() );
aLbChartColors.GetFocus();
+aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 );
}
return 0L;
@@ -222,16 +225,33 @@ IMPL_LINK( SvxDefaultColorOptPage, AddChartColor, void *, EMPTYARG )
// RemoveChartColor
//
-IMPL_LINK( SvxDefaultColorOptPage, RemoveChartColor, void *, EMPTYARG )
+IMPL_LINK( SvxDefaultColorOptPage, RemoveChartColor, PushButton*, pButton )
{
+size_t nIndex = aLbChartColors.GetSelectEntryPos();
+
+if (aLbChartColors.GetSelectEntryCount() == 0)
+return 0L;
+
if( pColorConfig )
{
-pColorConfig->GetColorTable().remove( aLbChartColors.GetSelectEntryPos() );
+DBG_ASSERT(pColorConfig.size() > 1, "don't delete the last chart color");
+QueryBox aQuery(pButton, CUI_RES(RID_OPTQB_COLOR_CHART_DELETE));
+aQuery.SetText(String(CUI_RES(RID_OPTSTR_COLOR_CHART_DELETE)));
+if(RET_YES == aQuery.Execute())
+{
-aLbChartColors.Clear();
-aLbChartColors.FillBox( pColorConfig->GetColorTable() );
+pColorConfig->GetColorTable().remove( nIndex );
-aLbChartColors.GetFocus();
+aLbChartColors.Clear();
+aLbChartColors.FillBox( pColorConfig->GetColorTable() );
+
+aLbChartColors.GetFocus();
+
+if (nIndex == aLbChartColors.GetEntryCount() && aLbChartColors.GetEntryCount() > 0)
+aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 );
+else if (aLbChartColors.GetEntryCount() > 0)
+aLbChartColors.SelectEntryPos( nIndex );
+}
}
return 0L;
diff --git a/cui/source/options/optchart.hxx b/cui/source/options/optchart.hxx
index 71898e9..1416008 100644
--- a/cui/source/options/optchart.hxx
+++ b/cui/source/options/optchart.hxx
@@ -55,6 +55,7 @@ public:
class SvxDefaultColorOptPage : public SfxTabPage
{
+
private:
FixedLine
Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts
Hi tml, I checked manually if the number was in the file. I didn't check further, as I don't know a way to do that. On Fri, 01 Apr 2011 02:00:51 -0600, Tor Lillqvist wrote: I have improved my last patch for the Color Charts. Thanks! I will commit it, just a question about one thing I don't understand: #define RID_SVXPAGE_ASIAN_LAYOUT(RID_SVX_START + 246) #define RID_OPTPAGE_CHART_DEFCOLORS (RID_SVX_START + 299) +#define RID_OPTQB_COLOR_CHART_DELETE(RID_SVX_START + 296) +#define RID_OPTSTR_COLOR_CHART_DELETE (RID_SVX_START + 289) #define RID_SVXPAGE_COLORCONFIG (RID_SVX_START + 249) #define RID_SVXQB_DELETE_COLOR_CONFIG (RID_SVX_START + 324) Did you just choose these values manually, checking that they don't overlap with any existing one? Or is there some mechanism to do it that is guaranteed to get an unused number? Are these assignments listen in numerical order somewhere? (But why did you not then add your new numbers to that list, too?) Sorry if this is a stupid question... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- -- Met Vriendelijke Groet, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts
Hi, Can somebody tell me if this needs to be changed? and if not can somebody put it in the 3.4-tree because the way the adding and removing of color charts works now is a bit strange. M.V.G. Rob Snelders On 01-04-11 12:36, Tor Lillqvist wrote: I checked manually if the number was in the file. I didn't check further, as I don't know a way to do that. OK. I don't know of any clever direct way either, but using http://opengrok.libreoffice.org/more/libs-core/svx/inc/svx/dialogs.hrc?full=RID_SVX_START++296 and http://opengrok.libreoffice.org/more/libs-core/svx/inc/svx/dialogs.hrc?full=RID_SVX_START++289 I found that the RID_SVX_START+296 and RID_SVX_START+289 values apparently already *are* taken. See http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/dialogs.hrc#108 and http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/dialogs.hrc#188 . Whether this overlap with your added RID_* values is a problem or not, I have no idea, sorry. I hope some of our more clueful list members can enlighten us... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build of master fails on impress
Hi, I tried to build the master but it fails on the sd-map. The problem is in sd/source/ui/framework/factories/ViewShellWrapper.cxx I get the following errors: /home/projecten/libo2/bootstrap/clone/impress/sd/source/ui/framework/factories/ViewShellWrapper.cxx:182: error: 'UnoTunnelIdInit' was not declared in this scope /home/projecten/libo2/bootstrap/clone/impress/sd/source/ui/framework/factories/ViewShellWrapper.cxx:182: error: template argument 1 is invalid /home/projecten/libo2/bootstrap/clone/impress/sd/source/ui/framework/factories/ViewShellWrapper.cxx: In static member function 'static const com::sun::star::uno::Sequence& sd::framework::ViewShellWrapper::getUnoTunnelId()': /home/projecten/libo2/bootstrap/clone/impress/sd/source/ui/framework/factories/ViewShellWrapper.cxx:187: error: 'get' is not a member of 'sd::frameworktheViewShellWrapperUnoTunnelId' dmake: Error code 1, while making '../../../../unxlngx6.pro/slo/ViewShellWrapper.obj What can be done to fix this? -- M.V.G. Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build of master fails on impress
Hi Michael, I did do a pull before building. I'm trying to fix the easy-hack "3.17 VBA support add support for Worksheets.Copy" and I tougth it would be best to do that in the master branch. I am just starting with helping on Libre-office, so I try to find easy-hacks to do, but not all easy-hacks are clear to me. -- Greetings, Rob On Tue, 05 Apr 2011 12:12:46 +0100, Michael Meeks wrote: Hi Rob, On Mon, 2011-04-04 at 23:49 +0200, Rob Snelders wrote: I tried to build the master but it fails on the sd-map. The problem is in sd/source/ui/framework/factories/ViewShellWrapper.cxx Ah ! :-) so I guess we recommend using the libreoffice-3-4 branch at the moment - where much of the fixing and so on is on-going for the 3.4 release. That is - if you want to help out with that :-) Of course, ideally everything should still build ;-) I'll get a master tree building myself to see what's up there, do you still have the problem after a g pull ? Thanks, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable
Hi Albert, I have worked on this bug before I heard that you had already worked on it. Did you work any further on it? Maybe we can callaborate on it? I have found the place where the number of sheets is set. This is in http://opengrok.libreoffice.org/xref/calc/sc/source/core/tool/appoptio.cxx#88 Please let me know. Greetings, Rob Snelders On 18-05-11 08:39, Albert Thuswaldner wrote: Hi Kohei, Thanks for your help. On Mon, May 9, 2011 at 21:19, Kohei Yoshida wrote: On Sun, 2011-05-08 at 17:09 +0200, Albert Thuswaldner wrote: Dear List, As a first attempt to contribute some code to LO, I've started hacking on his: https://bugs.freedesktop.org/show_bug.cgi?id=33293 I think I have come quite far with implementing the changes to the configuration dialog (see the patch). Here there is still some things to do, like figuring out why the contents of the tab page isn't showing up. Any hints? So, when you say the contents of the tag page isn't showing up, do you mean the page entry is not in the tree on the left at all, or the entry is there but the page shows up empty? The page entry was in the tree but the tab page itself showed up empty. However, I have solved this part now! :) There was an additional place in the code that needed to be modified. Also why are many of the same resource id's defined both in libs-core/svx/source/src/app.hrc and libs-core/svx/inc/svx/dialogs.hrc? I have no clue about this. Maybe it's a remnant of one of those code relocation efforts that took place awhile ago in the OOo code? For the other part of problem i.e, how to actually set the number of sheets for a new spreadsheet, I am completely lost. I haven't found where in the code this should be done, (using opengrok.+ guessing). Could someone please give me a hint on how to go about finding this? How is a new spreadsheet generated? xml template? through using the internal api? Check around the ScTable class. That's the class that implements each sheet instance. Especially pay close attention to its constructor, and assuming that it gets called three times during the startup of Calc, you can perhaps set a break point in there to see who instaniates it 3 times, and trace back from there. I've mostly focused on the configuration part as of yet, now I will focus on this part. Thanks for the hint. Great to see you working on this, BTW. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] fdo#34872
Hi,
Here is a really small patch to solve fdo#34872.
This patch is submitted under LGPLv3+/MPL-Licence.
--
Greetings,
Rob Snelders
>From 84bb33ac77c0f7967690635d4c41e8ca7d818e44 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sat, 28 May 2011 20:37:08 +0200
Subject: [PATCH] Cross-References-Tab now displays the items correctly. fdo#34872
---
sw/source/core/fields/expfld.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sw/source/core/fields/expfld.cxx b/sw/source/core/fields/expfld.cxx
index 07e9bdd..ac02cf1 100644
--- a/sw/source/core/fields/expfld.cxx
+++ b/sw/source/core/fields/expfld.cxx
@@ -609,7 +609,7 @@ sal_uInt16 SwSetExpFieldType::GetSeqFldList( SwSeqFldList& rList )
pNd->GetNodes().IsDocNodes() )
{
_SeqFldLstElem* pNew = new _SeqFldLstElem(
-pNd->GetExpandTxt( 0, (*pF->GetTxtFld()->GetStart()) + 1 ),
+pNd->GetExpandTxt( 1, (*pF->GetTxtFld()->GetStart()) ),
((SwSetExpField*)pF->GetFld())->GetSeqNumber() );
rList.InsertSort( pNew );
}
--
1.7.0.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [WIP] Bug 33293 - [EasyHack] Make starting count of worksheets configurable
Hi Albert, Then you are a lot further then I am. I'll leave you to it. Please state in the ticket when you are working on it. That way nobody will work on the ticket when you are busy with it. Greetings, Rob Snelders On 28-05-11 21:46, Albert Thuswaldner wrote: Hi Rob, On Sat, May 28, 2011 at 01:01, Rob Snelders wrote: Hi Albert, I have worked on this bug before I heard that you had already worked on it. Did you work any further on it? Maybe we can callaborate on it? Oh, how far did you come? I think I basically have done most of it by now. I have found the place where the number of sheets is set. This is in http://opengrok.libreoffice.org/xref/calc/sc/source/core/tool/appoptio.cxx#88 No I don't think that is where you set it. The methods: SetTabCountInNewSpreadsheet GetTabCountInNewSpreadsheet are used by the vba scripting api to set/get the number of sheets. But using these methods will not save the the number of sheets to the configuration file. I did a failled implementation of that, see the attached files: tpinit.cxx.appoptio tpinit.hxx.appoptio That's at least what I have managed to figure out. So instead I have basically implemented the same methods in docoptio.cxx/hxx though I have some bugs to straighten out. Attached the diff on what I have done so far. /Albert Please let me know. Greetings, Rob Snelders On 18-05-11 08:39, Albert Thuswaldner wrote: Hi Kohei, Thanks for your help. On Mon, May 9, 2011 at 21:19, Kohei Yoshidawrote: On Sun, 2011-05-08 at 17:09 +0200, Albert Thuswaldner wrote: Dear List, As a first attempt to contribute some code to LO, I've started hacking on his: https://bugs.freedesktop.org/show_bug.cgi?id=33293 I think I have come quite far with implementing the changes to the configuration dialog (see the patch). Here there is still some things to do, like figuring out why the contents of the tab page isn't showing up. Any hints? So, when you say the contents of the tag page isn't showing up, do you mean the page entry is not in the tree on the left at all, or the entry is there but the page shows up empty? The page entry was in the tree but the tab page itself showed up empty. However, I have solved this part now! :) There was an additional place in the code that needed to be modified. Also why are many of the same resource id's defined both in libs-core/svx/source/src/app.hrc and libs-core/svx/inc/svx/dialogs.hrc? I have no clue about this. Maybe it's a remnant of one of those code relocation efforts that took place awhile ago in the OOo code? For the other part of problem i.e, how to actually set the number of sheets for a new spreadsheet, I am completely lost. I haven't found where in the code this should be done, (using opengrok.+ guessing). Could someone please give me a hint on how to go about finding this? How is a new spreadsheet generated? xml template? through using the internal api? Check around the ScTable class. That's the class that implements each sheet instance. Especially pay close attention to its constructor, and assuming that it gets called three times during the startup of Calc, you can perhaps set a break point in there to see who instaniates it 3 times, and trace back from there. I've mostly focused on the configuration part as of yet, now I will focus on this part. Thanks for the hint. Great to see you working on this, BTW. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Disable Removebutton in optchart
Hi, I have here a small patch to disable the remove-button at the chart-colors if there is no color to remove. This makes it more consistent for the GUI. -- Greetings, Rob Snelders >From 0f64b62344f6c0fdc2f6d1460bdfb1cb3bd3f2ed Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Wed, 8 Jun 2011 18:21:02 +0200 Subject: [PATCH] Disable Removebutton in optchart --- cui/source/options/optchart.cxx |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cui/source/options/optchart.cxx b/cui/source/options/optchart.cxx index 422c720..6293a8f 100644 --- a/cui/source/options/optchart.cxx +++ b/cui/source/options/optchart.cxx @@ -196,6 +196,7 @@ IMPL_LINK( SvxDefaultColorOptPage, ResetToDefaults, void *, EMPTYARG ) aLbChartColors.GetFocus(); aLbChartColors.SelectEntryPos( 0 ); +aPBRemove.Enable( sal_True ); } return 0L; @@ -217,6 +218,7 @@ IMPL_LINK( SvxDefaultColorOptPage, AddChartColor, void *, EMPTYARG ) aLbChartColors.GetFocus(); aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 ); +aPBRemove.Enable( sal_True ); } return 0L; @@ -251,6 +253,8 @@ IMPL_LINK( SvxDefaultColorOptPage, RemoveChartColor, PushButton*, pButton ) aLbChartColors.SelectEntryPos( pColorConfig->GetColorTable().size() - 1 ); else if (aLbChartColors.GetEntryCount() > 0) aLbChartColors.SelectEntryPos( nIndex ); +else +aPBRemove.Enable( sal_False ); } } -- 1.7.0.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Funding Wishlist
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi All, As far as I think LibreOffice has a big shortage on Marketing, I don't want to disrespect the marketing-team of LibreOffice, but I think there are to few people doing marketing, and the tools they have are limited. I think we can make a huge jump forward with a Website that people can update without HTML-skills and easily from a web-based back-end. I don't know how to do that, as there are also people there needed. - -- Greetings, Rob Snelders Op 13-10-12 22:45, marc.p...@libreoffice.org schreef: > Hi everyone, > > In trying to better assess the TDF/LibreOffice funding > requirements, we are compiling a wishlist of funding request > particular to your team's needs. While there is no guarantee that > this will get you funding for any particular item, it will help to > better assess and prioritize the project's needs. > > I have volunteered to take care of setting up, as well as, > document (facilitate) the proposal from Florian (below)[1] > > snip == > > "What we effectively need now is a (senseful) wishlist from the > various teams. Think of it as a Christmas wishlist: You write a > dozen things on it, eventually you get two or three, which is > fantastic! > > Besides the infrastructure and cost for ongoing operations, I can > also imagine some developer machines are required, more travel > funding, a marketing campaign, funds to produce collaterals and > swags for giving them away, and many more. > > My proposal is to create a wiki page, asking the various groups to > write down their wishes, and eventually "distill" a wishlist out of > that. > > Does that sound senseful? Are there any volunteers for mailing the > various lists and compiling an initial wiki page? " (Florian > Effenberger) > > == > > I think the key words in Florian's proposal are > "senseful-whishlist". If there are multiple items, you may want to > prioritize them in the right order. > > I have set up a wiki page to collect your team's list[2]. Feel free > to add these to the wiki page after discussing it with your team, > or, I can also help out with collecting your suggestions by > re-visiting this thread and then add them to the wiki page. > > Cheers, > > Marc > > [1] > http://permalink.gmane.org/gmane.comp.documentation.libreoffice.marketing/6143 > > [2] > http://wiki.documentfoundation.org/Marketing/Funding_Priorities > -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJQq44HAAoJEGs78UIq7mKymVwH/23Nlq4JETrjcYQU6fm3NdNw 8ylehoWJiSRwRwFNy308KlwbJUL8VOJK8QmkPOqHKq+JOAq/LJQaLm5GFG8+IorA sOsok01mnvX2he9cUhFghPP0Uqi2YoWoGZZaqaFcPXu0UP9ssk9IYzeqNtHQvGFc qKjU8alR4c3GEzEZlMzl5TWHM07y925D8JU1wprucJz0S41pP5Eg3LyA0mImt2Vh Yjp5BD+PkHfkQUBv5m6OK+XQJmaVTAPO4TcoGogwBDRxwB7QgzYoO5/CjBXqjkPw 578Jiv2JRRSXG+dQMIpCKS9lAER6rnCYyx2XeLsqTXRpnzZDiJcCFGzJD8iigV4= =DIaO -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - bug/bug bug/bug.xhtml
bug/bug.xhtml | 11 +--
bug/bug/skin.js |1 -
2 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit d7a14b32fcd2fc84dba67d011aede6ed0fe11a24
Author: Rob Snelders
Date: Fri Nov 23 16:25:10 2012 +0100
[fdo#59199] BUGZILLAASSISTANT: Ask bug reporters for help
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index fe365be..1e21e5e 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -94,8 +94,15 @@
-The bug report has been successfully submitted.
-You can edit it or add attachments using the
corresponding bugzilla page.
+The bug report has been successfully submitted.
+You can edit it or add attachments using the
corresponding bugzilla page.
+
+Thank you for reporting a problem with LibreOffice.
+Your help is very appreciated.
+
+Nobody is perfect and more bugs have been reported.
+Join us in making this release even better.
+You could help with http://wiki.documentfoundation.org/Triage_For_Beginners";>sorting
bugs.
commit e4973d31f0d7170b92c5175ab268fc487f4967f9
Author: Rob Snelders
Date: Fri Nov 23 16:04:20 2012 +0100
fixing the skin-view of the submitted state
diff --git a/bug/bug/skin.js b/bug/bug/skin.js
index 7858f67..a33de59 100644
--- a/bug/bug/skin.js
+++ b/bug/bug/skin.js
@@ -61,7 +61,6 @@
} else if(location.search.indexOf('skin=submit') >= 0) {
submit();
} else if(location.search.indexOf('skin=complete') >= 0) {
- submit();
$.bug.state_success();
}
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug
bug/bug/bug.js | 10 +++---
bug/bug/test.js |1 +
2 files changed, 8 insertions(+), 3 deletions(-)
New commits:
commit 1944a962db3153f87a9265e5bb932de14ff0e342
Author: Rob Snelders
Date: Fri Nov 23 17:52:11 2012 +0100
Fixing the tests after the adding of the token-variable.
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index c6f5966..5bcad72 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -235,9 +235,12 @@
state_submit: function() {
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
-$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
-$.bug.token = data.match(//)[1];
-});
+
+if ($.bug.token == '') {
+$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
+$.bug.token = data.match(//)[1];
+});
+}
var form = $('.submission_form form');
$.bug.error_clear();
@@ -258,6 +261,7 @@
$('input[name="version"]', form).val(version);
$('input[name="short_desc"]', form).val(short_desc);
$('input[name="comment"]', form).val(comment);
+$.bug.token = '';
return true;
});
diff --git a/bug/bug/test.js b/bug/bug/test.js
index f6a3e24..4b33c6b 100644
--- a/bug/bug/test.js
+++ b/bug/bug/test.js
@@ -238,6 +238,7 @@ test("state_submit", function() {
$.bug.state_success = function() { ok(true, 'state_success'); };
var element = $('.state_submit');
+$.bug.token = 'AA';
equal(element.css('display'), 'none');
ok(!element.hasClass('initialized'), 'is not initialized');
$.bug.state_submit();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug bug/bug.xhtml
bug/bug.xhtml |3 +++
bug/bug/bug.css |8 +++-
2 files changed, 10 insertions(+), 1 deletion(-)
New commits:
commit bdd0f9effd21660cd29d54973bb23152fb31ccdc
Author: Rob Snelders
Date: Fri Nov 23 18:09:40 2012 +0100
fdo#57333 - BUGZILLAASSISTANT: Add privacy hint nearby submit button
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 1e21e5e..3fef2ef 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -70,6 +70,9 @@
5Description
6Submit
+
+All your contributions will be public in WWW! By clicking the
'Submit' button you irrevocably agree to release your contribution under the
CC-BY-SA 3.0 License and the GFDL. If you can't agree to these terms for
documents you planned to attach you can state in this report that such a
document exists. QA team will discuss with you further proceeding in the bug.
+
http://wiki.documentfoundation.org/Bug_Submission_Assistant";>Bug
Submission Assistant is copyright (C) 2011 Loic Dachary published under http://www.gnu.org/licenses/gpl.txt";>GNU GPLv3+.
Download the sources with git clone http://cgit.freedesktop.org/libreoffice/website";>http://cgit.freedesktop.org/libreoffice/website.
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index f81aa9b..920b72a 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -133,12 +133,18 @@ body {
/* copyright */
-.copyright {
+.legal {
padding: 100px 30px 10px 20px;
font-size: 8px;
color: #1ca608;
}
+.copyright {
+padding: 10px 30px 10px 20px;
+font-size: 8px;
+color: #1ca608;
+}
+
.copyright a {
color: #7bd16e;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug
bug/bug/bug.css |4
1 file changed, 4 insertions(+)
New commits:
commit aef7a7ec14301e9a6eccbf8ad5b7251fa0304499
Author: Rob Snelders
Date: Fri Nov 23 19:10:58 2012 +0100
fdo#57266 - BUGZILLAASSISTANT: increase width of Version picker
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 920b72a..4b9736e 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -564,6 +564,10 @@ body {
color: #b8af9e;
}
+.select ul {
+width: 225px;
+}
+
.select li.choice:hover {
background-color: #9ceb90;
color: #32b21f;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 6 commits - bug/bug bug/bug.xhtml bug/query.pl
bug/bug.xhtml |2 +-
bug/bug/bug.css|8 +++-
bug/bug/bug.js |4 ++--
bug/bug/select.css |2 +-
bug/query.pl | 12 +++-
5 files changed, 18 insertions(+), 10 deletions(-)
New commits:
commit 6b799019fd4c6471961aa7761e9752b364f4f09f
Author: Rob Snelders
Date: Fri Nov 23 20:58:07 2012 +0100
fdo#43446 - BUGZILLAASSISTANT: Drop-down lists properties need fine tuning
diff --git a/bug/query.pl b/bug/query.pl
index ad79e00..c56a2b5 100644
--- a/bug/query.pl
+++ b/bug/query.pl
@@ -14,6 +14,9 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see .
#
+
+use Scalar::Util qw(looks_like_number);
+
while() {
eval $_ if(s/(cpts|vers)\[(\d+)\]\s+=/\$$1\[$2\]=/);
if(/) {
print "\n";
-@versions = sort(@{$vers[$libreoffice]});
+@versions = sort {
+if (looks_like_number(substr($a, 0, 1)) == 0) {
+return 1;
+} elsif (looks_like_number(substr($b, 0, 1)) == 0) {
+return -1;
+} else {
+return lc($b) cmp lc($a);
+} } @{$vers[$libreoffice]};
print <
commit a37ad9d7635343d987d1f13f5abaf5dd07e30c23
Author: Rob Snelders
Date: Fri Nov 23 20:31:06 2012 +0100
Change the css-file so the width of the select is in the correct place
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 8b27146..41936e2 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -566,10 +566,6 @@ body {
color: #b8af9e;
}
-.select ul {
-width: 225px;
-}
-
.select li.choice:hover {
background-color: #9ceb90;
color: #32b21f;
diff --git a/bug/bug/select.css b/bug/bug/select.css
index 68718c1..540576f 100644
--- a/bug/bug/select.css
+++ b/bug/bug/select.css
@@ -26,7 +26,7 @@
margin: 0;
padding: 0;
max-height: 180px;
-width: 190px;
+width: 225px;
overflow: auto;
}
commit c725259b7170c50c0aa5ed074472cabe2e1d89a3
Author: Rob Snelders
Date: Fri Nov 23 20:19:28 2012 +0100
scroll to the top of the BSA after submit or error.
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 5bcad72..55312ed 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -52,7 +52,7 @@
}
}
$.bug.error_set(message);
-window.scrollTo(0,0);
+$.bug.window.scrollTo(0,225);
throw error;
});
},
@@ -288,7 +288,7 @@
var bug = $('.state_submit .bug').text();
$('.bug', element).attr('href', $.bug.url + '/show_bug.cgi?id=' +
bug);
element.show();
-window.scrollTo(0,0);
+$.bug.window.scrollTo(0,225);
},
// if this string is found in the page returned when
commit 925c0e72041cf4819c76530cd97206f4be9c0f43
Author: Rob Snelders
Date: Fri Nov 23 20:15:08 2012 +0100
hide the horizontal scrollbar
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index a6279c2..8b27146 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -35,6 +35,7 @@ body {
color: #616161;
height: 1024px;
font-family: helvetica, arial;
+overflow-x: hidden;
}
.input-label {
@@ -447,6 +448,7 @@ body {
.state_duplicates .related_bugs {
padding-top: 10px;
+width: 560px;
}
.state_duplicates a {
commit a877a0b07559ae97f431dcbc1f348317f20b4fe0
Author: Rob Snelders
Date: Fri Nov 23 19:29:01 2012 +0100
don't display who wrote it as multiple people work on it
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 3fef2ef..1d30563 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -74,7 +74,7 @@
All your contributions will be public in WWW! By clicking the
'Submit' button you irrevocably agree to release your contribution under the
CC-BY-SA 3.0 License and the GFDL. If you can't agree to these terms for
documents you planned to attach you can state in this report that such a
document exists. QA team will discuss with you further proceeding in the bug.
-http://wiki.documentfoundation.org/Bug_Submission_Assistant";>Bug
Submission Assistant is copyright (C) 2011 Loic Dachary published under http://www.gnu.org/licenses/gpl.txt";>GNU GPLv3+.
Download the sources with git clone http://cgit.freedesktop.org/libreoffice/website";>http://cgit.freedesktop.org/libreoffice/website.
+http://wiki.documentfoundation.org/Bug_Submission_Assistant";>Bug
Submission Assistant is published under http://www.gnu.org/licenses/gpl.txt";>GNU GPLv3+. Download the sources
with git clone http://cgit.freedesktop.org/libreoffice/website";>http://cgit.freedesktop.org/libreoffice/website.
commit cd93f4d47d947f72c343ca72dba330bd3d1c912f
Author: Rob Snelders
Date: Fri Nov 23 19:26:24 2012 +0100
don't display the loginname after the login.
diff --git
[Libreoffice-commits] .: bug/bug bug/bug.xhtml bug/Makefile bug/op_sys.pl bug/op_sys.txt
bug/Makefile |1 +
bug/bug.xhtml | 16 +---
bug/bug/bug.css| 12 +++-
bug/bug/bug.js | 21 ++---
bug/bug/select.css |4
bug/bug/skin.js|8 +++-
bug/op_sys.pl | 37 +
bug/op_sys.txt | 12
8 files changed, 103 insertions(+), 8 deletions(-)
New commits:
commit a9ce76f1d769f71defd659bded4f0a315a08314d
Author: C. Koppelt
Date: Sat Nov 24 14:10:11 2012 +0100
new patch for 41256
diff --git a/bug/Makefile b/bug/Makefile
index 358d33c..d294009 100644
--- a/bug/Makefile
+++ b/bug/Makefile
@@ -24,6 +24,7 @@ extract:
xsltproc --encoding UTF-8 --novalid subcomponents.xsl
build/BugReport_Details.xhtml > build/subcomponents.xhtml
xsltproc --encoding UTF-8 --novalid components.xsl
build/BugReport_Details.xhtml > build/components.xhtml
curl --silent
'https://bugs.freedesktop.org/query.cgi?product=LibreOffice&query_format=advanced'
> build/query.xhtml
+ perl op_sys.pl < op_sys.txt > build/op_sys.xhtml
perl query.pl < build/query.xhtml > build/versions.xhtml
perl sanity.pl build/query.xhtml build/components.xhtml
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 1d30563..565668e 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -5,6 +5,7 @@
+
]
>
@@ -67,8 +68,9 @@
2Component
3Subcomponent
4Version
-5Description
-6Submit
+5Operating System
+6Description
+7Submit
All your contributions will be public in WWW! By clicking the
'Submit' button you irrevocably agree to release your contribution under the
CC-BY-SA 3.0 License and the GFDL. If you can't agree to these terms for
documents you planned to attach you can state in this report that such a
document exists. QA team will discuss with you further proceeding in the bug.
@@ -157,6 +159,15 @@
+
+
+
+ Operating System
+&op_sys;
+
+
+
+
Subject:
@@ -173,7 +184,6 @@ Current behavior:
Expected behavior:
-Platform (if different from the browser):
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 41936e2..7fee712 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -123,7 +123,7 @@ body {
}
.left .label {
-padding-left: 40px;
+padding-left: 20px;
display: inline-block;
color: #9d9d9d;
}
@@ -395,6 +395,16 @@ body {
display: none;
}
+/* state_subcomponent */
+.operating_system > div {
+display: inline-block;
+}
+
+/* state_op_sys */
+.state_op_sys {
+display: none;
+}
+
/* state_description */
.state_description {
display: none;
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 55312ed..40114a9 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -176,17 +176,28 @@
element.show();
$('.select', element).select();
$(".select .choice", element).click(function() {
-$.bug.state_description();
+$.bug.state_op_sys();
});
}
},
+state_op_sys: function() {
+var element = $('.state_op_sys');
+if(!element.hasClass('initialized')) {
+element.addClass('initialized');
+$.bug.current_step('op_sys');
+element.show();
+$('.select', element).select();
+$(".select .choice", element).click(function() {
+$.bug.state_description();
+});
+ }
+},
+
state_description: function() {
var element = $('.state_description');
var template = $(".long", element).val();
if(!element.hasClass('initialized')) {
-template = template + '\nBrowser: ' +
window.navigator.userAgent;
-$(".long", element).val(template);
var validate = function() {
if($(".short", element).val().length > 3 &&
$(".long", element).val() != template) {
@@ -252,13 +263,17 @@
$(element).addClass('inprogress');
}
var version = $('.state_version .chosen').attr('data');
+var op_sys = $('.state_op_sys .chosen').attr('data');
var component = $('.state_component
.chosen').attr('data').replace('_',' ');
var short_desc = $('.state_subcomponent
.active_subcomponent .chosen').attr('data') + ': ' + $('.state_description
.short').val();
+//Add Operating System
var comment = $(
[Libreoffice-commits] .: bug/bug bug/bug.xhtml
bug/bug.xhtml | 35 +---
bug/bug/bug.css | 31 +-
bug/bug/bug.js| 63 -
bug/bug/skin.js | 27 +---
bug/bug/test.html | 91 --
bug/bug/test.js | 65 +-
6 files changed, 141 insertions(+), 171 deletions(-)
New commits:
commit 0e3239f21a4fd6545c8d65f7db53f07308821eba
Author: Rob Snelders
Date: Sat Nov 24 17:53:22 2012 +0100
Merging subcomponents, versions and op_sys to 1 step.
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 565668e..f50b2da 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -49,7 +49,7 @@
-login component subcomponent version
description submit
complete
+login component details description submit complete
@@ -66,11 +66,9 @@
1Sign in
2Component
-3Subcomponent
-4Version
-5Operating System
-6Description
-7Submit
+3Details
+4Description
+5Submit
All your contributions will be public in WWW! By clicking the
'Submit' button you irrevocably agree to release your contribution under the
CC-BY-SA 3.0 License and the GFDL. If you can't agree to these terms for
documents you planned to attach you can state in this report that such a
document exists. QA team will discuss with you further proceeding in the bug.
@@ -144,26 +142,25 @@
-
-
-
+
+
+
Sub component
-
-
+
+
Version
&versions;
-
-
-
-
- Operating System
-&op_sys;
+
+
+
+ Operating System
+ &op_sys;
@@ -238,12 +235,12 @@ Expected behavior:
-
+
Related bug reports
-
+
&subcomponents;
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 7fee712..915e37c 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -29,6 +29,10 @@
background: url('images/noscript.png') no-repeat top left;
}
+.inlineblock {
+display: inline-block;
+}
+
body {
margin: 0;
background-color: #fff;
@@ -311,7 +315,6 @@ body {
}
/* state_component */
-
.state_component {
display: none;
}
@@ -377,31 +380,16 @@ body {
background: url('icons/icon-selected.png') no-repeat;
}
-/* state_subcomponent */
-.version_and_subcomponent > div {
-display: inline-block;
-}
-
-.state_subcomponent {
+/* state_details */
+.state_details {
display: none;
}
-.state_subcomponent .subcomponents {
-display: none;
+.state_details .active_subcomponent {
+display: block;
}
-/* state_version */
-.state_version {
-display: none;
-}
-
-/* state_subcomponent */
-.operating_system > div {
-display: inline-block;
-}
-
-/* state_op_sys */
-.state_op_sys {
+.state_details .subcomponents {
display: none;
}
@@ -454,6 +442,7 @@ body {
.state_duplicates {
padding-left: 10px;
+display: none;
}
.state_duplicates .related_bugs {
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 40114a9..07658bd 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -95,6 +95,9 @@
url: '',
token: '',
+sub_component: 'EMPTY',
+version: '',
+op_sys: '',
state_signin_error_regexps: [/CLASS="THROW_ERROR">([^<]*)/i],
state_signin_success_regexp: /LOG&NBSP;OUT<\/A>([^<]*)/i,
@@ -140,7 +143,7 @@
var component = $(this).attr('data');
$('img', element).removeClass('selected');
$('img[data="' + component + '"]').addClass('selected');
-$.bug.state_subcomponent();
+$.bug.state_details();
});
$('img', element).click(function() {
var component = $(this).attr('data');
@@ -151,47 +154,38 @@
});
},
-state_subcomponent: function() {
-var element = $('.state_subcomponent');
+state_details: function() {
+var element = $('.state_details');
var componen
[Libreoffice-commits] .: bug/bug bug/bug.xhtml bug/query.pl
bug/bug.xhtml | 11 +--
bug/bug/bug.js | 25 -
bug/bug/select.css |4
bug/bug/skin.js|2 +-
bug/query.pl |4 ++--
5 files changed, 36 insertions(+), 10 deletions(-)
New commits:
commit f51b7d5fb781e110a394bb6cb2b6549d4b6bebef
Author: Rob Snelders
Date: Sat Nov 24 21:59:08 2012 +0100
Adding regression-option to the BSA
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index f50b2da..748377b 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -152,17 +152,24 @@
Version
- &versions;
+ &versions;
+
-
+
Operating System
&op_sys;
+
+
+ Last worked in:
+ &versions;
+
+
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 07658bd..131f396 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -98,6 +98,7 @@
sub_component: 'EMPTY',
version: '',
op_sys: '',
+regression: '',
state_signin_error_regexps: [/CLASS="THROW_ERROR">([^<]*)/i],
state_signin_success_regexp: /LOG&NBSP;OUT<\/A>([^<]*)/i,
@@ -168,24 +169,35 @@
$('.active_subcomponent .select .choice',
element).click(function() {
$.bug.refresh_related_bugs();
$.bug.subcomponent = $('.state_details .active_subcomponent
.chosen').attr('data');
-if ($.bug.version != '' && $.bug.op_sys != '') {
+if ($.bug.version != '' && $.bug.op_sys != '' &&
$.bug.regression != '') {
$.bug.state_description();
}
});
-$('.select', element).select();
+$(".select", element).select();
+$(".state_details .versions .choice[data='NONE']").remove();
$(".versions .select .choice", element).click(function() {
$.bug.version = $('.state_details .version
.chosen').attr('data');
-if ($.bug.subcomponent != 'EMPTY' && $.bug.op_sys != '') {
+if ($.bug.subcomponent != 'EMPTY' && $.bug.op_sys != '' &&
$.bug.regression != '') {
$.bug.state_description();
}
});
-$('.select', element).select();
+$(".select", element).select();
$(".op_sys .select .choice", element).click(function() {
$.bug.op_sys = $('.state_details .op_sys
.chosen').attr('data');
-if ($.bug.subcomponent != 'EMPTY' && $.bug.version != '') {
+if ($.bug.subcomponent != 'EMPTY' && $.bug.version != '' &&
$.bug.regression != '') {
$.bug.state_description();
}
});
+$(".select", element).select();
+$(".regression .select .choice", element).click(function() {
+$.bug.regression = $('.state_details .regression
.chosen').attr('data');
+if ($.bug.subcomponent != 'EMPTY' && $.bug.version != '' &&
$.bug.op_sys != '') {
+$.bug.state_description();
+}
+ });
+ $(".state_details .regression .choice[data='NONE']").click();
+
+
},
state_description: function() {
@@ -261,7 +273,9 @@
//Add Operating System
var op_sys = $('.state_op_sys .chosen').attr('data');
var comment = $('.state_description .long').val();
+var regression = (($.bug.regression != "NONE" &&
$.bug.regression != "")?$.bug.regression:"");
comment = comment + "\nOperating System: " + $(".op_sys
.chosen").text();
+comment = comment + (regression != "")?"\nLast worked in:
" + regression:"";
$("body").css("cursor", "progress");
$('input[name="token"]', form).val($.bug.token);
$('input[name="component"]', form).val(component
[Libreoffice-commits] .: bug/bug
bug/bug/bug.js | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
New commits:
commit 292c96ac19a9a930225ae47b9ece6269c10bb63a
Author: Rob Snelders
Date: Sun Nov 25 12:24:11 2012 +0100
fixing bug with token and versions
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 131f396..21df0c8 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -176,7 +176,7 @@
$(".select", element).select();
$(".state_details .versions .choice[data='NONE']").remove();
$(".versions .select .choice", element).click(function() {
-$.bug.version = $('.state_details .version
.chosen').attr('data');
+$.bug.version = $('.state_details .versions
.chosen').attr('data');
if ($.bug.subcomponent != 'EMPTY' && $.bug.op_sys != '' &&
$.bug.regression != '') {
$.bug.state_description();
}
@@ -253,12 +253,6 @@
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
-if ($.bug.token == '') {
-$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
-$.bug.token = data.match(//)[1];
-});
-}
-
var form = $('.submission_form form');
$.bug.error_clear();
form.attr('action', $.bug.url + '/post_bug.cgi');
@@ -268,6 +262,11 @@
} else {
$(element).addClass('inprogress');
}
+if ($.bug.token == '') {
+$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
+$.bug.token = data.match(//)[1];
+});
+}
var component = $('.state_component
.chosen').attr('data').replace('_',' ');
var short_desc = $.bug.subcomponent + ': ' +
$('.state_description .short').val();
//Add Operating System
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug bug/bug.xhtml
bug/bug.xhtml |1 +
bug/bug/bug.js | 14 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
New commits:
commit cd764b2fd0149e3075aa77aa365d3a2ef55730d4
Author: Rob Snelders
Date: Sun Nov 25 13:04:41 2012 +0100
more minor bugfixes
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 748377b..7521e1f 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -209,6 +209,7 @@ Expected behavior:
+
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 21df0c8..755b8d8 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -251,6 +251,11 @@
state_submit: function() {
var element = $('.state_submit');
+if ($.bug.token == '') {
+$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
+$.bug.token = data.match(//)[1];
+});
+}
if(!element.hasClass('initialized')) {
var form = $('.submission_form form');
@@ -262,11 +267,6 @@
} else {
$(element).addClass('inprogress');
}
-if ($.bug.token == '') {
-$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
-$.bug.token = data.match(//)[1];
-});
-}
var component = $('.state_component
.chosen').attr('data').replace('_',' ');
var short_desc = $.bug.subcomponent + ': ' +
$('.state_description .short').val();
//Add Operating System
@@ -274,7 +274,7 @@
var comment = $('.state_description .long').val();
var regression = (($.bug.regression != "NONE" &&
$.bug.regression != "")?$.bug.regression:"");
comment = comment + "\nOperating System: " + $(".op_sys
.chosen").text();
-comment = comment + (regression != "")?"\nLast worked in:
" + regression:"";
+comment = comment + ((regression != "")?"\nLast worked in:
" + regression:"");
$("body").css("cursor", "progress");
$('input[name="token"]', form).val($.bug.token);
$('input[name="component"]', form).val(component);
@@ -282,7 +282,7 @@
$('input[name="op_sys"]', form).val($.bug.op_sys);
$('input[name="short_desc"]', form).val(short_desc);
$('input[name="comment"]', form).val(comment);
-$('input[name="keywords"]', form).val((regression !=
"")?"regression":"");
+$('input[name="keywords"]', form).val(((regression !=
"")?"regression":""));
$.bug.token = '';
return true;
});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Christine, My journey home wasn't good.. as the trains didn't ride when I got back in the Netherlands. So I had 2 hours of extra travel-time. But I'm home. I don't have really time today to import your patch but I will do it tomorrow. But I saw that we haven't have a license statement for your patches. Can you send a blanket license-statement (MPL/LGPLv3+ dual license) to the developers-list of Libreoffice (I have cc'ed them). Something like: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license I think the REST API for bugzilla is on bugs.freedesktop.org as far as I know. But maybe Kendy can tell us for sure. - -- Greetings, Rob Snelders Op di 27 nov 2012 02:14:10 CET, Christine Koppelt schreef: > Hi Rob, > > Hope you had a smooth journey back home. > > Here is the patch for the request parameters again, this time with > correct author settings. > > Could you send me the URL for the Bugzilla REST API? > > Kind regards > > Christine -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJQtltwAAoJEGs78UIq7mKyZswH/3RLtp15wtKtH7bqyj185p/b aFuwW8zBXdFzgTJcndntXpXATja+34VVSREBtU1YxublSNYJPJVwlrWQmXub8SuJ vPPE8tCgHkM8EbFSh6Y1ztiW1fIzdnf46oOXVB4gMNlZtdWNaOsdTmVE+MQ/wkLm 7nNKE/7lJmkIcDWb9Xp0P5tjgo5U3FOuQfPF3MhHeT9+4p15gnMNa9puxZEkXHq/ HL2PMiF1yXIRlyLY6OpXr6NbuiR84ExtYq2uvLSp3ZLv4hnJjeo8ejjC0b1gsnnZ iQAXQJ0w05w5zdm6rvJDg6IMrrVF1o7dfgyR4pHKW3Wvv9g0KD/Y9GNtGq1ddNE= =0Y8y -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: rename the URL for feedback to something more positive
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
It is changed for that idea, also discussed in fdo#44795[1]. But
creating the full as mozilla has for 4.0 isn't possible. My idea is a
first setup for this. For now I would like to create a page with links
to Bugzilla, ask.libreoffice.org, users-mailinglist with nabble and
maybe a web IRC-client pointing to #libreoffice. But I wanted to ask
the Design and QA-team for their ideas also.
This weekend I added the URL with Florian to the configuration that it
points for now to the BSA.
I went forward with pushing this as I would like to use the new URL in
4.0. I also didn't know of the problem you discribe. But the name of
the link it points to wil now also be consistent with the name used in
the menu of LibreOffice. In the menu we are suggesting that you can
send any feedback to the URL we send you to. As the URL is a
rewrite-rule not many people see the URL. So I thought this wouldn't
differ much.
- --
Greetings,
Rob Snelders
[1]: https://bugs.freedesktop.org/show_bug.cgi?id=44795
Op 28-11-12 21:24, bfo [via Document Foundation Mail Archive] schreef:
> rename the URL for feedback to something more positive Change-Id:
> Iea248eeb3c3eacf9b0f123daa52516f5c1f0259c
>
> - ::rtl::OUString
> sURL("http://hub.libreoffice.org/file-a-bug/?version="; +
> utl::ConfigManager::getAboutBoxProductVersion() + +
> ::rtl::OUString
> sURL("http://hub.libreoffice.org/send-feedback/?version="; +
> utl::ConfigManager::getAboutBoxProductVersion()
>
> Hi! I have a question for a code above: what is a purpose of this
> change? This Send feedback instead of File a bug ATM redirects to
> Bug Submission Assistant anyway and IMHO Bugzilla is a bug tracker
> software, not a feedback system. Does this mean that preparations
> for a LibreOffice Feedback system started and it is going to be
> available in near future like for instance
> http://input.mozilla.org/en-US/feedback? I triaged many support
> only questions or complaints in Bugzilla and hope to not get more
> of them in the future (this is unnecessary noise). If this is not
> what is happening then we should use the right words in the source
> code. Bug is a negative word if not fixed only :). Best regards.
>
>
>
>
>
If you reply to this email, your message will be added to the discussion
> below:
> http://nabble.documentfoundation.org/rename-the-URL-for-feedback-to-something-more-positive-tp4021342.html
>
> This email was sent by bfo
> <http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=user_nodes&user=481817>
>
>
(via Nabble)
> To receive all replies by email, subscribe to this discussion
> <http://nabble.documentfoundation.org/template/NamlServlet.jtp?macro=subscribe_by_code&node=4021342&code=cHJvZ3JhbW1pbmdAZXJ0YWkubmx8NDAyMTM0Mnw1NTYzMzQzMjg=>
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQEcBAEBAgAGBQJQtpyDAAoJEGs78UIq7mKytfgH/AnFEpNSQ5qwE13zy88ylx9v
hmpyPv/fJLwdmNqFCtuI6X2HrFzIXtvpYJVhiSvrk6yVQ38zvs0Nv8aNd6+veJgO
5ygkKWvD995OXlnxu4YpoM9AninrB+yrqaMqCJ/uW8RLvDFxRCpF5Dl8ZtluSiiQ
uQUTg0YFF9LXn8GvARcTlVXYa8Ki+fFQz3tu9/E+0jyiaUlsMO0BthPNGgpBQuTU
M8X5JROQCaddO2O127Au7v8sHBDJYmIVoq4PJc9/Mv8h5+HTwm1gzyixK4vy5R9J
zOewCudBqGipDYCMItbisei1e5rFv0XVik6lLA3eecwbITzBtZwvm0SGsAOD2Mc=
=Ij0P
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Desktopintegratie op Fedora
as it is a dutch question I forwarded it to the dutch list. M.V.G. Rob Snelders On 14-07-11 23:51, Ben Engbers wrote: Ik heb zojuist LibreOffice 3.4.1 inclusief Nederlands taalpakket en help geïnstalleerd op mijn Fedora 14 systeem en zo te zien is daar niets mis mee. Ik vind het echter wel slordig dat na uitvoering van libreoffice3.4-redhat-menus-3.4-103.noarch.rpm, LibreOffice terug te vinden is onder kantoortoepassingen/OpenOffice.org. Dit zou toch beter moeten kunnen :-) Ben ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Hackers/Users-meeting 10 September, Eindhoven, The Netherlands
Hi All, On the 10th of September we are organising a Hackers/Users-meeting for LibreOffice and OpenOffice.org. The meeting is at MADlab in Eindhoven, The Netherlands. The meeting will begin at 10 o'clock. For more information see http://wiki.documentfoundation.org/NL/bijeenkomst_11-09-10 or email me. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] New Config Variable in Impress
Hi, I'm looking into bug fdo#35973. But I have trouble finding out how I can add config-variables for Impress. Can anybody give me any pointers? -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] patch for scan-diialog
Hi, I created a patch for the scan-dialog for Linux. It allows to scan a image directly from the scan-dialog without needing to select first the dialog and then the "request"-menuitem. The patch is submitted under the LGPLv3+/MPL-licence. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] patch for scan-diialog
Here is the patch.
M.V.G.
Rob Snelders
On 06-10-11 01:28, Miklos Vajna wrote:
On Wed, Oct 05, 2011 at 09:57:43PM +0200, Rob Snelders
wrote:
I created a patch for the scan-dialog for Linux. It allows to scan a
image directly from the scan-dialog without needing to select first the
dialog and then the "request"-menuitem.
The patch is submitted under the LGPLv3+/MPL-licence.
Forgot to attach the patch?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 2e6180eb49ec4886550ea105cf7149d6ff307c3e Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 5 Oct 2011 21:52:08 +0200
Subject: [PATCH] Added a scan-button to the SaneDlg
---
extensions/source/scanner/sanedlg.cxx | 12 +++-
extensions/source/scanner/sanedlg.hrc |1 +
extensions/source/scanner/sanedlg.hxx |4
extensions/source/scanner/sanedlg.src |7 +++
extensions/source/scanner/scanner.hxx |2 +-
extensions/source/scanner/scanunx.cxx |7 ++-
extensions/source/scanner/scanwin.cxx |2 +-
offapi/com/sun/star/scanner/XScannerManager.idl |5 +++--
sd/source/ui/view/drviews8.cxx |2 +-
sw/source/ui/uiview/uivwimp.cxx |6 --
10 files changed, 39 insertions(+), 9 deletions(-)
diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx
index 39b8862..2e55050 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -58,6 +58,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maCancelButton( this, SaneResId( RID_SCAN_CANCEL ) ),
maDeviceInfoButton( this, SaneResId( RID_DEVICEINFO_BTN ) ),
maPreviewButton( this, SaneResId( RID_PREVIEW_BTN ) ),
+maScanButton( this, SaneResId( RID_SCAN_BTN ) ),
maButtonOption( this, SaneResId( RID_SCAN_BUTTON_OPTION_BTN ) ),
maOptionsTxt( this, SaneResId( RID_SCAN_OPTION_TXT ) ),
maOptionTitle( this, SaneResId( RID_SCAN_OPTIONTITLE_TXT ) ),
@@ -88,6 +89,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maOptionBox( this, SaneResId( RID_SCAN_OPTION_BOX ) ),
mpRange( 0 )
{
+doScan = sal_False;
if( Sane::IsSane() )
{
InitDevices(); // opens first sane device
@@ -97,6 +99,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maDeviceInfoButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maPreviewButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
+maScanButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maButtonOption.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maDeviceBox.SetSelectHdl( LINK( this, SaneDlg, SelectHdl ) );
maOptionBox.SetSelectHdl( LINK( this, SaneDlg, OptionsBoxSelectHdl ) );
@@ -476,13 +479,15 @@ IMPL_LINK( SaneDlg, ClickBtnHdl, Button*, pButton )
ReloadSaneOptionsHdl( NULL );
}
}
-if( pButton == &maOKButton )
+if( pButton == &maOKButton || pButton == &maScanButton )
{
double fRes = (double)maReslBox.GetValue();
SetAdjustedNumericalValue( "resolution", fRes );
UpdateScanArea( sal_True );
SaveState();
EndDialog( mrSane.IsOpen() ? 1 : 0 );
+if (pButton == &maScanButton)
+doScan = sal_True;
}
else if( pButton == &maCancelButton )
{
@@ -1376,4 +1381,9 @@ sal_Bool SaneDlg::SetAdjustedNumericalValue(
return sal_True;
}
+sal_Bool SaneDlg::getDoScan()
+{
+return doScan;
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/extensions/source/scanner/sanedlg.hrc b/extensions/source/scanner/sanedlg.hrc
index ca89312..1e468c9 100644
--- a/extensions/source/scanner/sanedlg.hrc
+++ b/extensions/source/scanner/sanedlg.hrc
@@ -62,6 +62,7 @@
#define RID_SCAN_BITMAP_MINUS 32
#define RID_SCAN_ADVANCED_BOX 33
#define RID_SCAN_ADVANCED_TXT 34
+#define RID_SCAN_BTN 35
#define RID_SANE_DEVICEINFO_TXT 1001
#define RID_SANE_SCANERROR_TXT 1002
diff --git a/extensions/source/scanner/sanedlg.hxx b/extensions/source/scanner/sanedlg.hxx
index c3f72ea..a008655 100644
--- a/extensions/source/scanner/sanedlg.hxx
+++ b/extensions/source/scanner/sanedlg.hxx
@@ -65,6 +65,7 @@ private:
CancelButtonmaCancelButton;
PushButton maDeviceInfoButton;
PushButton maPreviewButton;
+PushButton maScanButton;
PushButton maButtonOption;
FixedText maOptionsTxt;
@@ -107,6 +108,8 @@ private:
double* mpRange;
double mfMin, mfMax;
+sal_BooldoScan;
+
DECL_LINK( ClickBtnHdl, Button* );
DECL_LINK( SelectHdl, ListBox* );
DECL_LINK( ModifyHdl, Edit* );
@@ -
[Libreoffice] Fwd: Re: patch for scan-diialog
Can somebody add this patch to the git?
Original Message
Subject: Re: [Libreoffice] patch for scan-diialog
Date: Thu, 06 Oct 2011 17:59:04 +0200
From: Rob Snelders
To: Miklos Vajna
CC: libreoffice@lists.freedesktop.org
Here is the patch.
M.V.G.
Rob Snelders
On 06-10-11 01:28, Miklos Vajna wrote:
On Wed, Oct 05, 2011 at 09:57:43PM +0200, Rob Snelders
wrote:
I created a patch for the scan-dialog for Linux. It allows to scan a
image directly from the scan-dialog without needing to select first the
dialog and then the "request"-menuitem.
The patch is submitted under the LGPLv3+/MPL-licence.
Forgot to attach the patch?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 2e6180eb49ec4886550ea105cf7149d6ff307c3e Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 5 Oct 2011 21:52:08 +0200
Subject: [PATCH] Added a scan-button to the SaneDlg
---
extensions/source/scanner/sanedlg.cxx | 12 +++-
extensions/source/scanner/sanedlg.hrc |1 +
extensions/source/scanner/sanedlg.hxx |4
extensions/source/scanner/sanedlg.src |7 +++
extensions/source/scanner/scanner.hxx |2 +-
extensions/source/scanner/scanunx.cxx |7 ++-
extensions/source/scanner/scanwin.cxx |2 +-
offapi/com/sun/star/scanner/XScannerManager.idl |5 +++--
sd/source/ui/view/drviews8.cxx |2 +-
sw/source/ui/uiview/uivwimp.cxx |6 --
10 files changed, 39 insertions(+), 9 deletions(-)
diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx
index 39b8862..2e55050 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -58,6 +58,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maCancelButton( this, SaneResId( RID_SCAN_CANCEL ) ),
maDeviceInfoButton( this, SaneResId( RID_DEVICEINFO_BTN ) ),
maPreviewButton( this, SaneResId( RID_PREVIEW_BTN ) ),
+maScanButton( this, SaneResId( RID_SCAN_BTN ) ),
maButtonOption( this, SaneResId( RID_SCAN_BUTTON_OPTION_BTN ) ),
maOptionsTxt( this, SaneResId( RID_SCAN_OPTION_TXT ) ),
maOptionTitle( this, SaneResId( RID_SCAN_OPTIONTITLE_TXT ) ),
@@ -88,6 +89,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maOptionBox( this, SaneResId( RID_SCAN_OPTION_BOX ) ),
mpRange( 0 )
{
+doScan = sal_False;
if( Sane::IsSane() )
{
InitDevices(); // opens first sane device
@@ -97,6 +99,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) :
maDeviceInfoButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maPreviewButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
+maScanButton.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maButtonOption.SetClickHdl( LINK( this, SaneDlg, ClickBtnHdl ) );
maDeviceBox.SetSelectHdl( LINK( this, SaneDlg, SelectHdl ) );
maOptionBox.SetSelectHdl( LINK( this, SaneDlg, OptionsBoxSelectHdl ) );
@@ -476,13 +479,15 @@ IMPL_LINK( SaneDlg, ClickBtnHdl, Button*, pButton )
ReloadSaneOptionsHdl( NULL );
}
}
-if( pButton == &maOKButton )
+if( pButton == &maOKButton || pButton == &maScanButton )
{
double fRes = (double)maReslBox.GetValue();
SetAdjustedNumericalValue( "resolution", fRes );
UpdateScanArea( sal_True );
SaveState();
EndDialog( mrSane.IsOpen() ? 1 : 0 );
+if (pButton == &maScanButton)
+doScan = sal_True;
}
else if( pButton == &maCancelButton )
{
@@ -1376,4 +1381,9 @@ sal_Bool SaneDlg::SetAdjustedNumericalValue(
return sal_True;
}
+sal_Bool SaneDlg::getDoScan()
+{
+return doScan;
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/extensions/source/scanner/sanedlg.hrc b/extensions/source/scanner/sanedlg.hrc
index ca89312..1e468c9 100644
--- a/extensions/source/scanner/sanedlg.hrc
+++ b/extensions/source/scanner/sanedlg.hrc
@@ -62,6 +62,7 @@
#define RID_SCAN_BITMAP_MINUS 32
#define RID_SCAN_ADVANCED_BOX 33
#define RID_SCAN_ADVANCED_TXT 34
+#define RID_SCAN_BTN 35
#define RID_SANE_DEVICEINFO_TXT 1001
#define RID_SANE_SCANERROR_TXT 1002
diff --git a/extensions/source/scanner/sanedlg.hxx b/extensions/source/scanner/sanedlg.hxx
index c3f72ea..a008655 100644
--- a/extensions/source/scanner/sanedlg.hxx
+++ b/extensions/source/scanner/sanedlg.hxx
@@ -65,6 +65,7 @@ private:
CancelButtonmaCancelButton;
PushButton maDeviceInfoButton;
PushButton maPreviewButton;
+PushButton maScanButton;
PushButton maButtonOption;
FixedText maOptionsTxt;
@@
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Thank you for the reply and the explenation. I'll try to make the changes next week. M.V.G. Rob Snelders On do 13 okt 2011 16:59:58 CEST, Stephan Bergmann wrote: On 10/12/2011 06:32 PM, Rob Snelders wrote: Can somebody add this patch to the git? Hi Rob, sorry for stepping in so late, just apparently missed your great patch somehow. One thing I'm uneasy with is changing (published) XScannerManager.idl incompatibly. The standard routine for doing such API changes would be to introduce a new interface, say XScannerManager2 (that may or may not derive from XScannerManager, depending on what's more convenient) and a new method with another name there. This may appear a lot of work for dubious benefit (does anybody out there actually use the old interface, so would break?) -- which it is... Still, if you were happy with such a change (and I could lend you a helping hand latest next week when I'm back in Hamburg), that would keep us in line with our existing compatibility practice. So, if you do not object, I'll see to get this integrated with the proposed change (either if you do the change yourself, or else I can do it with a little more delay). Thanks a lot for your patience, -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Hi Stephan, I tried to add the XScannerManager2. But when I try with this patch then the menu-items are disabled. I have tried to search where the problem was but I can´t find it. Can you help me? M.V.G. Rob Snelders On 13-10-11 16:59, Stephan Bergmann wrote: On 10/12/2011 06:32 PM, Rob Snelders wrote: Can somebody add this patch to the git? Hi Rob, sorry for stepping in so late, just apparently missed your great patch somehow. One thing I'm uneasy with is changing (published) XScannerManager.idl incompatibly. The standard routine for doing such API changes would be to introduce a new interface, say XScannerManager2 (that may or may not derive from XScannerManager, depending on what's more convenient) and a new method with another name there. This may appear a lot of work for dubious benefit (does anybody out there actually use the old interface, so would break?) -- which it is... Still, if you were happy with such a change (and I could lend you a helping hand latest next week when I'm back in Hamburg), that would keep us in line with our existing compatibility practice. So, if you do not object, I'll see to get this integrated with the proposed change (either if you do the change yourself, or else I can do it with a little more delay). Thanks a lot for your patience, -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice >From e000495fa09833d57f3897a4e08acc43df6f6e60 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Wed, 19 Oct 2011 22:19:16 +0200 Subject: [PATCH] Added a scanbutton to the scan-dialog --- extensions/inc/pch/precompiled_extensions.hxx |1 + extensions/source/scanner/sanedlg.cxx | 16 ++-- extensions/source/scanner/sanedlg.hrc |1 + extensions/source/scanner/sanedlg.hxx |7 ++- extensions/source/scanner/sanedlg.src |7 +++ extensions/source/scanner/scanner.cxx | 10 -- extensions/source/scanner/scanner.hxx |3 ++- extensions/source/scanner/scanunx.cxx |9 +++-- extensions/source/scanner/scanwin.cxx |2 +- extensions/source/scanner/scn.component |4 ++-- offapi/UnoApi_offapi.mk |2 ++ sd/inc/pch/precompiled_sd.hxx |1 + sd/source/ui/inc/DrawViewShell.hxx|4 ++-- sd/source/ui/view/drviews8.cxx|2 +- sd/source/ui/view/drviewsa.cxx|4 ++-- sw/inc/pch/precompiled_sw.hxx |1 + sw/inc/swmodule.hxx |6 +++--- sw/source/ui/app/swmodule.cxx |8 sw/source/ui/uiview/uivwimp.cxx | 12 +++- sw/source/ui/uiview/view.cxx |4 ++-- 20 files changed, 74 insertions(+), 30 deletions(-) diff --git a/extensions/inc/pch/precompiled_extensions.hxx b/extensions/inc/pch/precompiled_extensions.hxx index 4582abb..abf2a4d 100644 --- a/extensions/inc/pch/precompiled_extensions.hxx +++ b/extensions/inc/pch/precompiled_extensions.hxx @@ -272,6 +272,7 @@ #include "com/sun/star/resource/XResourceBundleLoader.hpp" #include "com/sun/star/scanner/ScannerException.hpp" #include "com/sun/star/scanner/XScannerManager.hpp" +#include "com/sun/star/scanner/XScannerManager2.hpp" #include "com/sun/star/script/ContextInformation.hpp" #include "com/sun/star/script/FailReason.hpp" #include "com/sun/star/script/FinishEngineEvent.hpp" diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx index 39b8862..acec566 100644 --- a/extensions/source/scanner/sanedlg.cxx +++ b/extensions/source/scanner/sanedlg.cxx @@ -48,16 +48,18 @@ ResId SaneResId( sal_uInt32 nID ) return ResId( nID, *pResMgr ); } -SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) : +SaneDlg::SaneDlg( Window* pParent, Sane& rSane, sal_Bool bScanEnabled ) : ModalDialog( pParent, SaneResId( RID_SANE_DIALOG ) ), mrSane( rSane ), mbIsDragging( sal_False ), +mbScanEnabled( bScanEnabled ), mbDragDrawn( sal_False ), maMapMode( MAP_APPFONT ), maOKButton( this, SaneResId( RID_SCAN_OK ) ), maCancelButton( this, SaneResId( RID_SCAN_CANCEL ) ), maDeviceInfoButton( this, SaneResId( RID_DEVICEINFO_BTN ) ), maPreviewButton( this, SaneResId( RID_PREVIEW_BTN ) ), +maScanButton( this, SaneResId( RID_SCAN_BTN ) ), maButtonOption( this, SaneResId( RID_SCAN_BUTTON_OPTION_BTN ) ), maOptionsTxt( this, SaneResId( RID_SCAN_OPTION_TXT ) ), maOptionTitle( this, SaneResId( RID_SCAN_OPTIONTITLE_TXT ) ), @@ -88,6 +90,7 @@ SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) : maOptionBox( this, SaneResId( RID_SCAN_OPTION_BOX ) ), m
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Hi, Here are 3 patches that together make the code for adding the scan-button to the sanedlg. These patches are submitted under the LGPLv3+/MPL-licence. M.V.G. Rob Snelders On 20-10-11 09:39, Stephan Bergmann wrote: On 10/19/2011 10:30 PM, Rob Snelders wrote: I tried to add the XScannerManager2. But when I try with this patch then the menu-items are disabled. I have tried to search where the problem was but I can´t find it. Can you help me? Hi Rob, The new file offapi/com/sun/star/scanner/XScannerManager2.idl is missing from the patch (I guess you did not git add it before you created the git diff). Then, as Markus already pointed out, the ScannerManager class needs to be adapted, to derive from XScannerManager2. Further, I noted that when configureScannerAndScan in scanunx.cxx calls the SaneDlg constructor, it should pass "listener.is()" instead of "(listener != NULL)" for bScanEnabled. While the latter (happens to) work as well, the former is much cleaner and the preferred idiom when working with com::sun::star::uno::Reference. And finally, the scanwin.cxx case does not support the new feature at all, right? Then we should at least change the end of the changed line in that file from "const uno::Reference< lang::XEventListener >& rxListener )" to "const uno::Reference< lang::XEventListener >& )", to avoid warnings about unused parameters. Better yet, the button should be hidden. (Or even better yet, the new functionality should be implemented...) If you provide the missing XScannerManager2.idl, I can tweak the above issues in the patch for you, if you like. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice >From e000495fa09833d57f3897a4e08acc43df6f6e60 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Wed, 19 Oct 2011 22:19:16 +0200 Subject: [PATCH] Added a scanbutton to the scan-dialog --- extensions/inc/pch/precompiled_extensions.hxx |1 + extensions/source/scanner/sanedlg.cxx | 16 ++-- extensions/source/scanner/sanedlg.hrc |1 + extensions/source/scanner/sanedlg.hxx |7 ++- extensions/source/scanner/sanedlg.src |7 +++ extensions/source/scanner/scanner.cxx | 10 -- extensions/source/scanner/scanner.hxx |3 ++- extensions/source/scanner/scanunx.cxx |9 +++-- extensions/source/scanner/scanwin.cxx |2 +- extensions/source/scanner/scn.component |4 ++-- offapi/UnoApi_offapi.mk |2 ++ sd/inc/pch/precompiled_sd.hxx |1 + sd/source/ui/inc/DrawViewShell.hxx|4 ++-- sd/source/ui/view/drviews8.cxx|2 +- sd/source/ui/view/drviewsa.cxx|4 ++-- sw/inc/pch/precompiled_sw.hxx |1 + sw/inc/swmodule.hxx |6 +++--- sw/source/ui/app/swmodule.cxx |8 sw/source/ui/uiview/uivwimp.cxx | 12 +++- sw/source/ui/uiview/view.cxx |4 ++-- 20 files changed, 74 insertions(+), 30 deletions(-) diff --git a/extensions/inc/pch/precompiled_extensions.hxx b/extensions/inc/pch/precompiled_extensions.hxx index 4582abb..abf2a4d 100644 --- a/extensions/inc/pch/precompiled_extensions.hxx +++ b/extensions/inc/pch/precompiled_extensions.hxx @@ -272,6 +272,7 @@ #include "com/sun/star/resource/XResourceBundleLoader.hpp" #include "com/sun/star/scanner/ScannerException.hpp" #include "com/sun/star/scanner/XScannerManager.hpp" +#include "com/sun/star/scanner/XScannerManager2.hpp" #include "com/sun/star/script/ContextInformation.hpp" #include "com/sun/star/script/FailReason.hpp" #include "com/sun/star/script/FinishEngineEvent.hpp" diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx index 39b8862..acec566 100644 --- a/extensions/source/scanner/sanedlg.cxx +++ b/extensions/source/scanner/sanedlg.cxx @@ -48,16 +48,18 @@ ResId SaneResId( sal_uInt32 nID ) return ResId( nID, *pResMgr ); } -SaneDlg::SaneDlg( Window* pParent, Sane& rSane ) : +SaneDlg::SaneDlg( Window* pParent, Sane& rSane, sal_Bool bScanEnabled ) : ModalDialog( pParent, SaneResId( RID_SANE_DIALOG ) ), mrSane( rSane ), mbIsDragging( sal_False ), +mbScanEnabled( bScanEnabled ), mbDragDrawn( sal_False ), maMapMode( MAP_APPFONT ), maOKButton( this, SaneResId( RID_SCAN_OK ) ), maCancelButton( this, SaneResId( RID_SCAN_CANCEL ) ), maDeviceInfoButton( this, SaneResId( RID_DEVICEINFO_BTN ) ), maPreviewButton( this, SaneResId( RID_PREVIEW_BTN ) ), +maScanButton( this, SaneResId( RID_SCAN_B
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
Hi, I have added the feature with screenshot to the ReleaseNotes. Stephan: I'm compiling the code and will test the patch when it is done. M.V.G. Rob Snelders On vr 21 okt 2011 17:53:31 CEST, Michael Meeks wrote: Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. Great to see that :-) Any chance you could drop a nice screenshot / feature note and your name at: http://wiki.documentfoundation.org/ReleaseNotes/3.5 which saves lots of time later when it comes to building the 3.5 release notes. Thanks again, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: Re: patch for scan-diialog
I've tested the code as it is in git now. And it still works here. M.V.G. Rob Snelders On 21-10-11 22:31, Rob Snelders wrote: Hi, I have added the feature with screenshot to the ReleaseNotes. Stephan: I'm compiling the code and will test the patch when it is done. M.V.G. Rob Snelders On vr 21 okt 2011 17:53:31 CEST, Michael Meeks wrote: Hi Rob, On Thu, 2011-10-20 at 20:37 +0200, Rob Snelders wrote: Here are 3 patches that together make the code for adding the scan-button to the sanedlg. Great to see that :-) Any chance you could drop a nice screenshot / feature note and your name at: http://wiki.documentfoundation.org/ReleaseNotes/3.5 which saves lots of time later when it comes to building the 3.5 release notes. Thanks again, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hackfest Netherlands March 31st
Hi All, At the 31st of March the Dutch user-group will organize a Hackfest. Also will there be some translators. We will organize it in Woerden near Utrecht. It is close by a station so easy to get there by train. For anyone interested we have more information on the wiki: https://wiki.documentfoundation.org/NL/bijeenkomst_12-03-31 or contact me for more information. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
Hi, All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#46390: EasyHack: Move VERBOSE to OSL_DEBUG_LEVEL
Hi,
I have created 2 little patches. The first one is to start on the bug
fdo#46390.
The other patch solves also some build-errors I got when turning on the
debug-mode. Also is rRequestData removed. It isn't defined in the class
as far as I can see. It should be the aKey because that holds the SdrPage.
License is on file.
--
Greetings,
Rob Snelders
>From 59364eb861dfa8eb4d1a5a630b1a55b42d962e44 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Mon, 2 Apr 2012 22:54:08 +0200
Subject: [PATCH] Removal of VERBOSE define
---
sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx | 21 ++---
.../ui/slidesorter/cache/SlsCacheCompactor.cxx | 14 +-
sd/source/ui/view/ToolBarManager.cxx | 46 +---
sd/source/ui/view/ViewShellManager.cxx | 44 ---
4 files changed, 35 insertions(+), 90 deletions(-)
diff --git a/sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx b/sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx
index f369079..d556c5c 100644
--- a/sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx
+++ b/sd/source/ui/slidesorter/cache/SlsBitmapCache.cxx
@@ -35,11 +35,6 @@
#include "sdpage.hxx"
#include "drawdoc.hxx"
-// Uncomment the following define for some more OSL_TRACE messages.
-#ifdef DEBUG
-//#define VERBOSE
-#endif
-
// Define the default value for the maximal cache size that is used for
// previews that are currently not visible. The visible previews are all
// held in memory at all times. This default is used only when the
@@ -421,9 +416,7 @@ void BitmapCache::ReCalculateTotalCacheSize (void)
}
mbIsFull = (mnNormalCacheSize >= mnMaximalNormalCacheSize);
-#ifdef VERBOSE
-OSL_TRACE("cache size is %d/%d", mnNormalCacheSize, mnPreciousCacheSize);
-#endif
+SAL_INFO("sd.sls", OSL_THIS_FUNC << ": cache size is " << mnNormalCacheSize << "/" << mnPreciousCacheSize);
}
@@ -527,9 +520,7 @@ void BitmapCache::UpdateCacheSize (const CacheEntry& rEntry, CacheOperation eOpe
if ( ! rEntry.IsPrecious() && mnNormalCacheSize>mnMaximalNormalCacheSize)
{
mbIsFull = true;
-#ifdef VERBOSE
-OSL_TRACE("cache size is %d > %d", mnNormalCacheSize,mnMaximalNormalCacheSize);
-#endif
+SAL_INFO("sd.sls", OSL_THIS_FUNC << ": cache size is " << mnNormalCacheSize << " > " << mnMaximalNormalCacheSize);
mpCacheCompactor->RequestCompaction();
}
break;
@@ -618,17 +609,13 @@ void BitmapCache::CacheEntry::Compress (const ::boost::shared_ptrCompress(maPreview);
-#ifdef VERBOSE
+#if OSL_DEBUG_LEVEL > 2
sal_uInt32 nOldSize (maPreview.GetSizeBytes());
sal_uInt32 nNewSize (mpReplacement.get()!=NULL ? mpReplacement->GetMemorySize() : 0);
if (nOldSize == 0)
nOldSize = 1;
sal_Int32 nRatio (100L * nNewSize / nOldSize);
-OSL_TRACE("compressing bitmap for %x from %d to %d bytes (%d%%)",
-this,
-nOldSize,
-nNewSize,
-nRatio);
+SAL_INFO("sd.sls", OSL_THIS_FUNC << ": compressing bitmap for " << %x << " from " << nOldSize << " to " << nNewSize << " bytes (" << nRatio << "%)");
#endif
mpCompressor = rpCompressor;
diff --git a/sd/source/ui/slidesorter/cache/SlsCacheCompactor.cxx b/sd/source/ui/slidesorter/cache/SlsCacheCompactor.cxx
index 3f8b2b4..3a59eca 100644
--- a/sd/source/ui/slidesorter/cache/SlsCacheCompactor.cxx
+++ b/sd/source/ui/slidesorter/cache/SlsCacheCompactor.cxx
@@ -39,11 +39,6 @@
using namespace ::com::sun::star::uno;
-// Uncomment the definition of VERBOSE to get some more OSL_TRACE messages.
-#ifdef DEBUG
-//#define VERBOSE
-#endif
-
namespace {
/** This is a trivial implementation of the CacheCompactor interface class.
@@ -211,10 +206,7 @@ void CacheCompactionByCompression::Run (void)
{
if (mrCache.GetSize() > mnMaximalCacheSize)
{
-#ifdef VERBOSE
-OSL_TRACE ("bitmap cache uses to much space: %d > %d",
-mrCache.GetSize(), mnMaximalCacheSize);
-#endif
+SAL_INFO("sd.sls", OSL_THIS_FUNC << ": bitmap cache uses to much space: " << mrCache.GetSize() << " > " << mnMaximalCacheSize);
SAL_WNODEPRECATED_DECLARATIONS_PUSH
::std::auto_ptr< ::sd::slidesorter::cache::BitmapCache::CacheIndex> pIndex (
@@ -231,9 +223,7 @@ void CacheCompactionByCompression::Run (void)
break;
}
mrCache.ReCalculateTotalCacheSize();
-#ifdef VERBOSE
-OSL_TRACE ("there a
[PATCH] fdo#46390: EasyHack: Move VERBOSE to OSL_DEBUG_LEVEL (part 2)
Hi All,
This patch removes the VERBOSE for the rest of the sd/-directory.
--
Greetings,
Rob Snelders
>From 4072d09239c4bea7000e6366ec313a6dad5e4b3e Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 4 Apr 2012 19:57:05 +0200
Subject: [PATCH] Removal VERBOSE
---
.../configuration/ChangeRequestQueueProcessor.cxx | 29
.../ui/framework/configuration/Configuration.cxx | 18 +++-
.../configuration/ConfigurationClassifier.cxx | 24 +++
.../configuration/ConfigurationController.cxx | 32 --
.../ConfigurationControllerResourceManager.cxx | 47
.../configuration/ConfigurationUpdater.cxx | 43 ++
sd/source/ui/framework/module/ModuleController.cxx | 15 +-
sd/source/ui/tools/TimerBasedTaskExecution.cxx | 15 ++-
sd/source/ui/view/ToolBarManager.cxx |8 +---
9 files changed, 72 insertions(+), 159 deletions(-)
diff --git a/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx b/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx
index 92982b7..cbefb08 100644
--- a/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx
+++ b/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx
@@ -42,18 +42,15 @@ using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::drawing::framework;
-#undef VERBOSE
-//#define VERBOSE 1
-
namespace {
-#ifdef VERBOSE
+#if OSL_DEBUG_LEVEL > 0
void TraceRequest (const Reference& rxRequest)
{
Reference xNamed (rxRequest, UNO_QUERY);
if (xNamed.is())
-OSL_TRACE("%s\n",
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ":" <<
::rtl::OUStringToOString(xNamed->getName(), RTL_TEXTENCODING_UTF8).getStr());
}
@@ -105,14 +102,14 @@ void ChangeRequestQueueProcessor::AddRequest (
{
::osl::MutexGuard aGuard (maMutex);
-#ifdef VERBOSE
+#if OSL_DEBUG_LEVEL >= 2
if (maQueue.empty())
{
-OSL_TRACE("Adding requests to empty queue");
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ": Adding requests to empty queue");
ConfigurationTracer::TraceConfiguration(
mxConfiguration, "current configuration of queue processor");
}
-OSL_TRACE("Adding request");
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ": Adding request");
TraceRequest(rxRequest);
#endif
@@ -131,9 +128,7 @@ void ChangeRequestQueueProcessor::StartProcessing (void)
&& mxConfiguration.is()
&& ! maQueue.empty())
{
-#ifdef VERBOSE
-OSL_TRACE("ChangeRequestQueueProcessor scheduling processing");
-#endif
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ": ChangeRequestQueueProcessor scheduling processing");
mnUserEventId = Application::PostUserEvent(
LINK(this,ChangeRequestQueueProcessor,ProcessEvent));
}
@@ -168,9 +163,7 @@ void ChangeRequestQueueProcessor::ProcessOneEvent (void)
{
::osl::MutexGuard aGuard (maMutex);
-#ifdef VERBOSE
-OSL_TRACE("ProcessOneEvent");
-#endif
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ": ProcessOneEvent");
if (mxConfiguration.is()
&& ! maQueue.empty())
@@ -182,7 +175,7 @@ void ChangeRequestQueueProcessor::ProcessOneEvent (void)
// Execute the change request.
if (xRequest.is())
{
-#ifdef VERBOSE
+#if OSL_DEBUG_LEVEL >= 2
TraceRequest(xRequest);
#endif
xRequest->execute(mxConfiguration);
@@ -190,14 +183,12 @@ void ChangeRequestQueueProcessor::ProcessOneEvent (void)
if (maQueue.empty())
{
-#ifdef VERBOSE
-OSL_TRACE("All requests are processed");
-#endif
+SAL_INFO("sd.fwk", OSL_THIS_FUNC << ": All requests are processed");
// The queue is empty so tell the ConfigurationManager to update
// its state.
if (mpConfigurationUpdater.get() != NULL)
{
-#ifdef VERBOSE
+#if OSL_DEBUG_LEVEL >= 2
ConfigurationTracer::TraceConfiguration (
mxConfiguration, "updating to configuration");
#endif
diff --git a/sd/source/ui/framework/configuration/Configuration.cxx b/sd/source/ui/framework/configuration/Configuration.cxx
index 16b25eb..0e01cc9 100644
--- a/sd/source/ui/framework/configuration/Configuration.cxx
+++ b/sd/source/ui/framework/configuration/Configuration.cxx
@@ -40,8 +40,6 @@ using namespace ::com::sun::star::drawing::framework;
using ::sd::framework::FrameworkHelper;
using ::rtl::OUString;
-#undef VERBOSE
-
namespace {
/** Use the XResourceId::compareTo() method to implement a compare operator
for STL containers.
@@ -163,1
[PATCH] fdo#46390: EasyHack: Move VERBOSE to OSL_DEBUG_LEVEL (part 3)
Hi,
Here is the last part of the remove of the VERBOSE-defines.
There are 2 howevers:
- in svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx I get
the warning as attached in warning.txt
- in slideshow/source/engine/slideview.cxx I have changed the
debug-function at line 222. I changed *(pCanvas->GetClip) to aPoly. The
old one didn't build.
The problem is that I don't know if the debug-draw is still usefull this
way. I don't understand why this was done.
--
Greetings,
Rob Snelders
>From 36d9a2769ffc498fdef6f36460201767352095fc Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 5 Apr 2012 22:40:21 +0200
Subject: [PATCH] Remove VERBOSE part 3
---
.../source/commontools/RowFunctionParser.cxx |2 +-
sdext/source/presenter/PresenterAccessibility.cxx | 16 +++-
.../engine/animationnodes/animationbasenode.cxx|2 +-
.../engine/animationnodes/animationbasenode.hxx|2 +-
.../engine/animationnodes/animationcolornode.hxx |2 +-
.../engine/animationnodes/animationnodefactory.cxx |2 +-
.../animationnodes/animationpathmotionnode.hxx |2 +-
.../engine/animationnodes/animationsetnode.hxx |2 +-
.../animationnodes/animationtransformnode.hxx |2 +-
.../animationtransitionfilternode.hxx |2 +-
.../engine/animationnodes/basecontainernode.cxx|2 +-
.../engine/animationnodes/basecontainernode.hxx|2 +-
.../source/engine/animationnodes/basenode.cxx |2 +-
.../source/engine/animationnodes/basenode.hxx |2 +-
.../source/engine/animationnodes/nodetools.cxx |2 +-
.../source/engine/animationnodes/nodetools.hxx |4 ++--
.../animationnodes/paralleltimecontainer.hxx |2 +-
.../animationnodes/propertyanimationnode.hxx |2 +-
.../animationnodes/sequentialtimecontainer.hxx |2 +-
slideshow/source/engine/shapes/viewshape.cxx |2 +-
slideshow/source/engine/slideshowimpl.cxx |2 +-
slideshow/source/engine/slideview.cxx |6 +++---
slideshow/source/engine/smilfunctionparser.cxx |2 +-
slideshow/source/inc/animationnodefactory.hxx |2 +-
.../EnhancedCustomShapeFunctionParser.cxx |2 +-
25 files changed, 30 insertions(+), 40 deletions(-)
diff --git a/connectivity/source/commontools/RowFunctionParser.cxx b/connectivity/source/commontools/RowFunctionParser.cxx
index 077f9bd..0bb5f60 100644
--- a/connectivity/source/commontools/RowFunctionParser.cxx
+++ b/connectivity/source/commontools/RowFunctionParser.cxx
@@ -32,7 +32,7 @@
// But watch out, the parser might have
// state not visible to this code!
#define BOOST_SPIRIT_SINGLE_GRAMMAR_INSTANCE
-#if defined(VERBOSE) && defined(DBG_UTIL)
+#if OSL_DEBUG_LEVEL >= 2 && defined(DBG_UTIL)
#include
#define BOOST_SPIRIT_DEBUG
#endif
diff --git a/sdext/source/presenter/PresenterAccessibility.cxx b/sdext/source/presenter/PresenterAccessibility.cxx
index 18ba0e7..ff90539 100644
--- a/sdext/source/presenter/PresenterAccessibility.cxx
+++ b/sdext/source/presenter/PresenterAccessibility.cxx
@@ -59,8 +59,6 @@ using ::rtl::OUString;
#define A2S(s) (::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(s)))
-#define VERBOSE
-
//= PresenterAccessibleObject =
namespace sdext { namespace presenter {
@@ -784,12 +782,8 @@ void SAL_CALL PresenterAccessible::focusGained (const css::awt::FocusEvent& rEve
throw (cssu::RuntimeException)
{
(void)rEvent;
-
-#ifdef VERBOSE
-OSL_TRACE("PresenterAccessible::focusGained at %x and window %x\r", this,
-mxMainWindow.get());
-#endif
-
+SAL_INFO("sdext.presenter", OSL_THIS_FUNC << ": PresenterAccessible::focusGained at " << this
+<< " and window " << mxMainWindow.get());
AccessibleFocusManager::Instance()->FocusObject(mpAccessibleConsole);
}
@@ -797,11 +791,7 @@ void SAL_CALL PresenterAccessible::focusLost (const css::awt::FocusEvent& rEvent
throw (cssu::RuntimeException)
{
(void)rEvent;
-
-#ifdef VERBOSE
-OSL_TRACE("PresenterAccessible::focusLost at %x\r", this);
-#endif
-
+SAL_INFO("sdext.presenter", OSL_THIS_FUNC << ": PresenterAccessible::focusLost at " << this);
AccessibleFocusManager::Instance()->FocusObject(NULL);
}
diff --git a/slideshow/source/engine/animationnodes/animationbasenode.cxx b/slideshow/source/engine/animationnodes/animationbasenode.cxx
index 06ec310..df1bcc5 100644
--- a/slideshow/source/engine/animationnodes/animationbasenode.cxx
+++ b/slideshow/source/engine/animationnodes/animationbasenode.cxx
@@ -377,7 +377,7 @@ bool AnimationBaseNode::hasPendingAnimation() const
return true;
}
-#if defined(VERBOSE) && defined(DBG_UTIL)
+#if OSL_DEBUG_LEVEL >= 2 && defined(DBG_UTIL)
void Ani
[PATCH] [fdo#40778] Remove dictionary choice when adding new entry to the spellchecker
Hereby the patch to fix bug fdo#40778. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] [fdo#40778] Remove dictionary choice when adding new entry to the spellchecker
Ah yes.. sorry about that..
On 14-04-12 13:52, Markus Mohrhard wrote:
Hey
2012/4/14 Rob Snelders:
Hereby the patch to fix bug fdo#40778.
--
did you forget to attach the patch?
Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 6a7d65d968e83bdfdcf2e681dc8d35813eac019e Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sat, 14 Apr 2012 13:17:04 +0200
Subject: [PATCH] fdo#40778 Remove dictionary choice when adding new entry to
the spellchecker
---
cui/source/dialogs/SpellDialog.cxx | 21 +
cui/source/inc/SpellDialog.hxx |4 +++-
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx
index 23b3aa4..1681d67 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -324,7 +324,10 @@ void SpellDialog::Init_Impl()
aSuggestionLB.SetDoubleClickHdl( LINK( this, SpellDialog, ChangeHdl ) );
aSentenceED.SetModifyHdl(LINK ( this, SpellDialog, ModifyHdl) );
-aAddToDictMB.SetSelectHdl(LINK ( this, SpellDialog, AddToDictionaryHdl ) );
+
+aAddToDictMB.SetMenuMode( MENUBUTTON_MENUMODE_TIMED );
+aAddToDictMB.SetSelectHdl(LINK ( this, SpellDialog, AddToDictSelectHdl ) );
+aAddToDictMB.SetClickHdl(LINK ( this, SpellDialog, AddToDictClickHdl ) );
aLanguageLB.SetSelectHdl(LINK( this, SpellDialog, LanguageSelectHdl ) );
aExplainLink.SetClickHdl( LINK( this, SpellDialog, HandleHyperlink ) );
@@ -1009,7 +1012,19 @@ void SpellDialog::InitUserDicts()
}
//---
-IMPL_LINK(SpellDialog, AddToDictionaryHdl, MenuButton*, pButton )
+IMPL_LINK(SpellDialog, AddToDictClickHdl, MenuButton*, pButton )
+{
+return AddToDictionaryExecute(1, pButton->GetPopupMenu());
+}
+
+//---
+IMPL_LINK(SpellDialog, AddToDictSelectHdl, MenuButton*, pButton )
+{
+return AddToDictionaryExecute(pButton->GetCurItemId(), pButton->GetPopupMenu());
+}
+
+//---
+int SpellDialog::AddToDictionaryExecute( sal_uInt16 nItemId, PopupMenu *pMenu )
{
aSentenceED.UndoActionStart( SPELLUNDO_CHANGE_GROUP );
@@ -1017,8 +1032,6 @@ IMPL_LINK(SpellDialog, AddToDictionaryHdl, MenuButton*, pButton )
//manually changed
const String aNewWord= aSentenceED.GetErrorText();
-sal_uInt16 nItemId = pButton->GetCurItemId();
-PopupMenu *pMenu = pButton->GetPopupMenu();
String aDicName ( pMenu->GetItemText( nItemId ) );
uno::Reference< linguistic2::XDictionary > xDic;
diff --git a/cui/source/inc/SpellDialog.hxx b/cui/source/inc/SpellDialog.hxx
index 2d9383b..f302e1f 100644
--- a/cui/source/inc/SpellDialog.hxx
+++ b/cui/source/inc/SpellDialog.hxx
@@ -212,13 +212,15 @@ private:
DECL_LINK(CancelHdl, void *);
DECL_LINK( ModifyHdl, SentenceEditWindow_Impl *);
DECL_LINK(UndoHdl, void *);
-DECL_LINK( AddToDictionaryHdl, MenuButton* );
+DECL_LINK( AddToDictSelectHdl, MenuButton* );
+DECL_LINK( AddToDictClickHdl, MenuButton* );
DECL_LINK( LanguageSelectHdl, SvxLanguageBox* );
DECL_LINK( DialogUndoHdl, SpellUndoAction_Impl* );
DECL_LINK( HandleHyperlink, svt::FixedHyperlink * );
DECL_STATIC_LINK( SpellDialog, InitHdl, SpellDialog * );
+int AddToDictionaryExecute( sal_uInt16 ItemId, PopupMenu *pMenu );
voidStartSpellOptDlg_Impl();
voidInitUserDicts();
voidUpdateBoxes_Impl();
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[patch] [fdo#42986] Presentations in Wide-screen
Hi,
Patches for bug fdo#42986
--
Greetings,
Rob Snelders
>From b7e5a0d1ec7fdd4371f50b0ff101f4b37aa0ce1f Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sat, 14 Apr 2012 17:26:27 +0200
Subject: [PATCH] fdo#42986 Add Presentationsize 16:9 Widescreen
---
cui/source/tabpages/page.cxx | 10 +-
cui/source/tabpages/page.h|3 ++-
cui/source/tabpages/page.src |3 ++-
i18nutil/inc/i18nutil/paper.hxx |5 +++--
i18nutil/source/utility/paper.cxx |6 --
sd/source/core/drawdoc2.cxx |2 +-
vcl/source/gdi/print.cxx |2 +-
7 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index a0b5cc8..13e32e3 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -995,13 +995,13 @@ IMPL_LINK( SvxPageDescPage, PaperSizeSelect_Impl, ListBox *, pBox )
if ( eMode == SVX_PAGE_MODE_PRESENTATION )
{
-// Draw: bei Papierformat soll der Rand 1cm betragen
+// Draw: With on screen no border
long nTmp = 0;
-sal_Bool bScreen = ( PAPER_SCREEN == ePaper );
+sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )|| ( PAPER_SCREEN_16_9 == ePaper));
if ( !bScreen )
-// bei Bildschirm keinen Rand
-nTmp = 1; // entspr. 1cm
+// with paper take a borden
+nTmp = 1; //cm
// Abfragen, ob fuer Raender 0 gesetzt ist:
if ( bScreen || aRightMarginEdit.GetValue() == 0 )
@@ -1410,7 +1410,7 @@ int SvxPageDescPage::DeactivatePage( SfxItemSet* _pSet )
sal_uInt16 nPos = aPaperSizeBox.GetSelectEntryPos();
Paper ePaper = (Paper)(sal_uLong)aPaperSizeBox.GetEntryData( nPos );
-if ( ePaper != PAPER_SCREEN && IsMarginOutOfRange() )
+if ( (ePaper != PAPER_SCREEN_4_3 || ePaper != PAPER_SCREEN_16_9) && IsMarginOutOfRange() )
{
if ( QueryBox( this, WB_YES_NO | WB_DEF_NO, aPrintRangeQueryText ).Execute() == RET_NO )
{
diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index bc7ad78..87858fe 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -54,7 +54,7 @@
#define PAPERSIZE_C65 16
#define PAPERSIZE_DL17
#define PAPERSIZE_DIA 18
-#define PAPERSIZE_SCREEN19
+#define PAPERSIZE_SCREEN_4_319
#define PAPERSIZE_C 20
#define PAPERSIZE_D 21
#define PAPERSIZE_E 22
@@ -74,6 +74,7 @@
#define PAPERSIZE_B6_JIS36
#define PAPERSIZE_POSTCARD_JP 46
#define PAPERSIZE_A656
+#define PAPERSIZE_SCREEN_16_9 78
#endif
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index 91873c7..8f81d65 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -452,7 +452,8 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
< "C5 Envelope" ; PAPERSIZE_C5 ; > ;
< "C4 Envelope" ; PAPERSIZE_C4 ; > ;
< "Dia Slide" ; PAPERSIZE_DIA ; > ;
-< "Screen" ; PAPERSIZE_SCREEN ; > ;
+< "Screen 4:3" ; PAPERSIZE_SCREEN_4_3 ; > ;
+ < "Screen 16:9" ; PAPERSIZE_SCREEN_16_9 ; > ;
< "Japanese Postcard" ; PAPERSIZE_POSTCARD_JP; > ;
};
};
diff --git a/i18nutil/inc/i18nutil/paper.hxx b/i18nutil/inc/i18nutil/paper.hxx
index d5be9ec..5c08661 100644
--- a/i18nutil/inc/i18nutil/paper.hxx
+++ b/i18nutil/inc/i18nutil/paper.hxx
@@ -58,7 +58,7 @@ enum Paper
PAPER_ENV_C65,
PAPER_ENV_DL,
PAPER_SLIDE_DIA,
-PAPER_SCREEN,
+PAPER_SCREEN_4_3,
PAPER_C,
PAPER_D,
PAPER_E,
@@ -116,7 +116,8 @@ enum Paper
PAPER_ARCHB,
PAPER_ARCHC,
PAPER_ARCHD,
-PAPER_ARCHE
+PAPER_ARCHE,
+PAPER_SCREEN_16_9
};
// defined for 'equal size' test with the implementation array
diff --git a/i18nutil/source/utility/paper.cxx b/i18nutil/source/utility/paper.cxx
index 63b5cff..a79089d 100644
--- a/i18nutil/source/utility/paper.cxx
+++ b/i18nutil/source/utility/paper.cxx
@@ -93,7 +93,7 @@ static PageDesc aDinTab[] =
{ MM2MM100( 114 ), MM2MM100( 229 ),"EnvC65", NULL },
{ MM2MM100( 110 ), MM2MM100( 220 ),"EnvDL", "DL" },
{ MM2MM100( 180),MM2MM100( 270 ),NULL, NULL }, //Dia
-{ MM2MM100( 210),MM2MM100( 280 ),NULL, NULL }, //Screen
+{ MM2MM100( 210),MM2MM100( 280 ),NULL, NULL }, //Screen 4:3
{ IN2MM100( 17 ),IN2MM100( 22 ), "AnsiC", "CSheet" },
{ IN2MM100( 22 ),IN2MM100( 34 ), "AnsiD", "DSheet" },
{ IN2MM100( 34 ),IN2MM100( 44 ), "AnsiE", "ESheet" },
@@ -155,7 +155,9 @@ static PageDesc aDinTab[] =
{ IN2MM100( 12 ),IN2MM100( 18 ),
Re: [patch] [fdo#42986] Presentations in Wide-screen
Hi,
Here is a corrected patch, without tab's in it.
--
Greetings,
Rob Snelders
On 14-04-12 18:58, Rob Snelders wrote:
Hi,
Patches for bug fdo#42986
--
Greetings,
Rob Snelders
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From eaf512ac6d636f13b2574edeef118cd816f5d5da Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sat, 14 Apr 2012 21:21:25 +0200
Subject: [PATCH] fdo#42986 Add Presentationsize 16:9 Widescreen
---
cui/source/tabpages/page.cxx | 10 +-
cui/source/tabpages/page.h|3 ++-
cui/source/tabpages/page.src |3 ++-
i18nutil/inc/i18nutil/paper.hxx |5 +++--
i18nutil/source/utility/paper.cxx |6 --
sd/inc/sdenumdef.hxx |2 +-
sd/source/core/drawdoc2.cxx |2 +-
sd/source/ui/app/sdmod1.cxx | 10 ++
sd/source/ui/dlg/dlgass.cxx |6 ++
sd/source/ui/dlg/dlgass.src | 10 ++
sd/source/ui/inc/dlgass.hrc |1 +
vcl/source/gdi/print.cxx |2 +-
12 files changed, 46 insertions(+), 14 deletions(-)
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index a0b5cc8..13e32e3 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -995,13 +995,13 @@ IMPL_LINK( SvxPageDescPage, PaperSizeSelect_Impl, ListBox *, pBox )
if ( eMode == SVX_PAGE_MODE_PRESENTATION )
{
-// Draw: bei Papierformat soll der Rand 1cm betragen
+// Draw: With on screen no border
long nTmp = 0;
-sal_Bool bScreen = ( PAPER_SCREEN == ePaper );
+sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )|| ( PAPER_SCREEN_16_9 == ePaper));
if ( !bScreen )
-// bei Bildschirm keinen Rand
-nTmp = 1; // entspr. 1cm
+// with paper take a borden
+nTmp = 1; //cm
// Abfragen, ob fuer Raender 0 gesetzt ist:
if ( bScreen || aRightMarginEdit.GetValue() == 0 )
@@ -1410,7 +1410,7 @@ int SvxPageDescPage::DeactivatePage( SfxItemSet* _pSet )
sal_uInt16 nPos = aPaperSizeBox.GetSelectEntryPos();
Paper ePaper = (Paper)(sal_uLong)aPaperSizeBox.GetEntryData( nPos );
-if ( ePaper != PAPER_SCREEN && IsMarginOutOfRange() )
+if ( (ePaper != PAPER_SCREEN_4_3 || ePaper != PAPER_SCREEN_16_9) && IsMarginOutOfRange() )
{
if ( QueryBox( this, WB_YES_NO | WB_DEF_NO, aPrintRangeQueryText ).Execute() == RET_NO )
{
diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index bc7ad78..87858fe 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -54,7 +54,7 @@
#define PAPERSIZE_C65 16
#define PAPERSIZE_DL17
#define PAPERSIZE_DIA 18
-#define PAPERSIZE_SCREEN19
+#define PAPERSIZE_SCREEN_4_319
#define PAPERSIZE_C 20
#define PAPERSIZE_D 21
#define PAPERSIZE_E 22
@@ -74,6 +74,7 @@
#define PAPERSIZE_B6_JIS36
#define PAPERSIZE_POSTCARD_JP 46
#define PAPERSIZE_A656
+#define PAPERSIZE_SCREEN_16_9 78
#endif
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index 91873c7..2137ff2 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -452,7 +452,8 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
< "C5 Envelope" ; PAPERSIZE_C5 ; > ;
< "C4 Envelope" ; PAPERSIZE_C4 ; > ;
< "Dia Slide" ; PAPERSIZE_DIA ; > ;
-< "Screen" ; PAPERSIZE_SCREEN ; > ;
+< "Screen 4:3" ; PAPERSIZE_SCREEN_4_3 ; > ;
+< "Screen 16:9" ; PAPERSIZE_SCREEN_16_9 ; > ;
< "Japanese Postcard" ; PAPERSIZE_POSTCARD_JP; > ;
};
};
diff --git a/i18nutil/inc/i18nutil/paper.hxx b/i18nutil/inc/i18nutil/paper.hxx
index d5be9ec..5c08661 100644
--- a/i18nutil/inc/i18nutil/paper.hxx
+++ b/i18nutil/inc/i18nutil/paper.hxx
@@ -58,7 +58,7 @@ enum Paper
PAPER_ENV_C65,
PAPER_ENV_DL,
PAPER_SLIDE_DIA,
-PAPER_SCREEN,
+PAPER_SCREEN_4_3,
PAPER_C,
PAPER_D,
PAPER_E,
@@ -116,7 +116,8 @@ enum Paper
PAPER_ARCHB,
PAPER_ARCHC,
PAPER_ARCHD,
-PAPER_ARCHE
+PAPER_ARCHE,
+PAPER_SCREEN_16_9
};
// defined for 'equal size' test with the implementation array
diff --git a/i18nutil/source/utility/paper.cxx b/i18nutil/source/utility/paper.cxx
index 63b5cff..a79089d 100644
--- a/i18nutil/source/utility/paper.cxx
+++ b/i18nutil/source/utility/paper.cxx
@@ -93,7 +93,7 @@ static PageDesc aDinTab[] =
{ MM2MM100( 114 ), MM2MM100( 229 ),"EnvC65", NULL },
{ MM2MM100( 110 ), MM2MM100( 220 ),"EnvDL", "DL" },
{ MM2MM100( 180),MM2M
Re: [patch] [fdo#42986] Presentations in Wide-screen
Hi,
There was an error in page.cxx. I fixed that now.
Thanks to Rodolfo for seeing it.
--
Greetings,
Rob Snelders
On 14-04-12 21:26, Rob Snelders wrote:
Hi,
Here is a corrected patch, without tab's in it.
--
Greetings,
Rob Snelders
On 14-04-12 18:58, Rob Snelders wrote:
Hi,
Patches for bug fdo#42986
--
Greetings,
Rob Snelders
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From eaf512ac6d636f13b2574edeef118cd816f5d5da Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sat, 14 Apr 2012 21:21:25 +0200
Subject: [PATCH] fdo#42986 Add Presentationsize 16:9 Widescreen
---
cui/source/tabpages/page.cxx | 10 +-
cui/source/tabpages/page.h|3 ++-
cui/source/tabpages/page.src |3 ++-
i18nutil/inc/i18nutil/paper.hxx |5 +++--
i18nutil/source/utility/paper.cxx |6 --
sd/inc/sdenumdef.hxx |2 +-
sd/source/core/drawdoc2.cxx |2 +-
sd/source/ui/app/sdmod1.cxx | 10 ++
sd/source/ui/dlg/dlgass.cxx |6 ++
sd/source/ui/dlg/dlgass.src | 10 ++
sd/source/ui/inc/dlgass.hrc |1 +
vcl/source/gdi/print.cxx |2 +-
12 files changed, 46 insertions(+), 14 deletions(-)
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index a0b5cc8..13e32e3 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -995,13 +995,13 @@ IMPL_LINK( SvxPageDescPage, PaperSizeSelect_Impl, ListBox *, pBox )
if ( eMode == SVX_PAGE_MODE_PRESENTATION )
{
-// Draw: bei Papierformat soll der Rand 1cm betragen
+// Draw: With on screen no border
long nTmp = 0;
-sal_Bool bScreen = ( PAPER_SCREEN == ePaper );
+sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )|| ( PAPER_SCREEN_16_9 == ePaper));
if ( !bScreen )
-// bei Bildschirm keinen Rand
-nTmp = 1; // entspr. 1cm
+// with paper take a borden
+nTmp = 1; //cm
// Abfragen, ob fuer Raender 0 gesetzt ist:
if ( bScreen || aRightMarginEdit.GetValue() == 0 )
@@ -1410,7 +1410,7 @@ int SvxPageDescPage::DeactivatePage( SfxItemSet* _pSet )
sal_uInt16 nPos = aPaperSizeBox.GetSelectEntryPos();
Paper ePaper = (Paper)(sal_uLong)aPaperSizeBox.GetEntryData( nPos );
-if ( ePaper != PAPER_SCREEN && IsMarginOutOfRange() )
+if ( ePaper != PAPER_SCREEN_4_3 && ePaper != PAPER_SCREEN_16_9 && IsMarginOutOfRange() )
{
if ( QueryBox( this, WB_YES_NO | WB_DEF_NO, aPrintRangeQueryText ).Execute() == RET_NO )
{
diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index bc7ad78..87858fe 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -54,7 +54,7 @@
#define PAPERSIZE_C65 16
#define PAPERSIZE_DL17
#define PAPERSIZE_DIA 18
-#define PAPERSIZE_SCREEN19
+#define PAPERSIZE_SCREEN_4_319
#define PAPERSIZE_C 20
#define PAPERSIZE_D 21
#define PAPERSIZE_E 22
@@ -74,6 +74,7 @@
#define PAPERSIZE_B6_JIS36
#define PAPERSIZE_POSTCARD_JP 46
#define PAPERSIZE_A656
+#define PAPERSIZE_SCREEN_16_9 78
#endif
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index 91873c7..2137ff2 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -452,7 +452,8 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
< "C5 Envelope" ; PAPERSIZE_C5 ; > ;
< "C4 Envelope" ; PAPERSIZE_C4 ; > ;
< "Dia Slide" ; PAPERSIZE_DIA ; > ;
-< "Screen" ; PAPERSIZE_SCREEN ; > ;
+< "Screen 4:3" ; PAPERSIZE_SCREEN_4_3 ; > ;
+< "Screen 16:9" ; PAPERSIZE_SCREEN_16_9 ; > ;
< "Japanese Postcard" ; PAPERSIZE_POSTCARD_JP; > ;
};
};
diff --git a/i18nutil/inc/i18nutil/paper.hxx b/i18nutil/inc/i18nutil/paper.hxx
index d5be9ec..5c08661 100644
--- a/i18nutil/inc/i18nutil/paper.hxx
+++ b/i18nutil/inc/i18nutil/paper.hxx
@@ -58,7 +58,7 @@ enum Paper
PAPER_ENV_C65,
PAPER_ENV_DL,
PAPER_SLIDE_DIA,
-PAPER_SCREEN,
+PAPER_SCREEN_4_3,
PAPER_C,
PAPER_D,
PAPER_E,
@@ -116,7 +116,8 @@ enum Paper
PAPER_ARCHB,
PAPER_ARCHC,
PAPER_ARCHD,
-PAPER_ARCHE
+PAPER_ARCHE,
+PAPER_SCREEN_16_9
};
// defined for 'equal size' test with the implementation array
diff --git a/i18nutil/source/utility/paper.cxx b/i18nutil/source/utility/paper.c
Make clean for bugassistent
Hi All, I want to improve the bug-assistent. I have created a simple patch that allows you to do a make clean in the bug-directory of the website. -- Greetings, Rob Snelders >From a6ac8a6702bb78b20fec34f5a87d0ecd70161918 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Sun, 15 Apr 2012 00:50:15 +0200 Subject: [PATCH] added make clean to the bugassistent --- bug/Makefile |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/bug/Makefile b/bug/Makefile index 56665d7..bd846fc 100644 --- a/bug/Makefile +++ b/bug/Makefile @@ -33,3 +33,6 @@ compose: check: perl sanity.pl TEST + +clean: + rm -f BugReport_Details.xhtml component_comments.xhtml subcomponents.xhtml components.xhtml query.xhtml versions.xhtml bug/bug.html -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Update Bugassistant
Hi All, Sometimes the text that the bug is submitted displays below on the page. This will make sure it is always displayed above in the page. This patch is for the website-repository. -- Greetings, Rob Snelders >From 1ed0decf1f03c819aef18ff7f6412248d9c25392 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Sun, 15 Apr 2012 13:24:16 +0200 Subject: [PATCH] Display submitted-text always where it is visible --- bug/bug.xhtml | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/bug/bug.xhtml b/bug/bug.xhtml index 0e9c073..c0f017b 100644 --- a/bug/bug.xhtml +++ b/bug/bug.xhtml @@ -92,10 +92,14 @@ - + + +The bug report has been successfully submitted. +You can edit it or add attachments using the corresponding bugzilla page. + + - Please login using your bugzilla account. @@ -209,11 +213,6 @@ Platform (if different from the browser): - -The bug report has been successfully submitted. -You can edit it or add attachments using the corresponding bugzilla page. - - -- 1.7.5.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] [fdo#40778] Remove dictionary choice when adding new entry to the spellchecker
Miklos Vajna schreef op 17.04.2012 12:19: On Sat, Apr 14, 2012 at 02:02:05PM +0200, Rob Snelders wrote: Ah yes.. sorry about that.. Hi Rob, Thanks for this! Pushed now. Two suggestions, though: - Please use git config user.email to set something better than "ertai@idefix.(none)" :) I fixed that already. But that was after sending this patch. - The same problem is there when you right-click on the underlined problematic word - did you check if it would be easy to avoid the submenu there when there is only one dictionary? That would make the UI more consistent. I'll look into it later this week. Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] Update Bugassistant
Hi Thorsten, How/When will this be on the website? -- Greetings, Rob Snelders Op di 17 apr 2012 09:38:01 CEST, Thorsten Behrens schreef: Rob Snelders wrote: Sometimes the text that the bug is submitted displays below on the page. This will make sure it is always displayed above in the page. This patch is for the website-repository. Thanks Rob, pushed. -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [patch] [fdo#42986] Presentations in Wide-screen
Hi Ivan,
I have tested with removing the PAPER_SCREEN*.
It seems to work. The size indeed dissapears where the page-size of the
printer is mentioned.
I only saw that the handout-page is empty on the screen. It seems to
print however. Also without the patch applied it doesn't work here. But
my build is more then a week old so It could be fixed. It seems to be a
different error however.
--
Greetings,
Rob Snelders
Op 16-04-12 20:26, Ivan Timofeev schreef:
Hi Rob,
thanks a lot, great work! :)
Just one detail: if you add smth to 'static const int PaperIndex'
(print.cxx), I suppose you also have to add it to RID_STR_PAPERNAMES
(print.src):
OSL_ENSURE( sal_uInt32(SAL_N_ELEMENTS(PaperIndex)) ==
aPaperStrings.Count(), "localized paper name count wrong" );
But hmmm... Where we will see the effect?
$ git grep GetPaperName
editeng/source/items/paperinf.cxx:return String(
Printer::GetPaperName( ePaper ) );
[some garbage...]
vcl/source/gdi/print.cxx:return (ePaper != PAPER_USER ||
i_bPaperUser ) ? GetPaperName( ePaper ) : rtl::OUString();
vcl/source/window/printdlg.cxx: aPrt->GetPaperName( false ),
The first occurrence in editeng is a mysterious wrapper, used in
Writer (Insert -> Envelope... -> Format). The last occurrence is the
print dialog code, we see a paper name in parentheses above the print
preview.
I wonder why the 'Screen' entry is there. Is it a standardized page
format name? ( *whisper* yeah, I'd like to remove it... :)
Regards,
Ivan
>From 331414fbc0dd08bfd07177fc8ad005e0131be83d Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 18 Apr 2012 23:30:26 +0200
Subject: [PATCH] fdo#42986 Add Presentationsize 16:9 Widescreen
---
cui/source/tabpages/page.cxx | 10 +-
cui/source/tabpages/page.h|3 ++-
cui/source/tabpages/page.src |3 ++-
i18nutil/inc/i18nutil/paper.hxx |5 +++--
i18nutil/source/utility/paper.cxx |6 --
sd/inc/sdenumdef.hxx |2 +-
sd/source/core/drawdoc2.cxx |2 +-
sd/source/ui/app/sdmod1.cxx | 10 ++
sd/source/ui/dlg/dlgass.cxx |6 ++
sd/source/ui/dlg/dlgass.src | 10 ++
sd/source/ui/inc/dlgass.hrc |1 +
vcl/source/gdi/print.cxx |2 +-
vcl/source/src/print.src |1 -
13 files changed, 46 insertions(+), 15 deletions(-)
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index a0b5cc8..1ef696e 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -995,13 +995,13 @@ IMPL_LINK( SvxPageDescPage, PaperSizeSelect_Impl, ListBox *, pBox )
if ( eMode == SVX_PAGE_MODE_PRESENTATION )
{
-// Draw: bei Papierformat soll der Rand 1cm betragen
+// Draw: With on screen no border
long nTmp = 0;
-sal_Bool bScreen = ( PAPER_SCREEN == ePaper );
+sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )|| ( PAPER_SCREEN_16_9 == ePaper));
if ( !bScreen )
-// bei Bildschirm keinen Rand
-nTmp = 1; // entspr. 1cm
+// with paper take a borden
+nTmp = 1; //cm
// Abfragen, ob fuer Raender 0 gesetzt ist:
if ( bScreen || aRightMarginEdit.GetValue() == 0 )
@@ -1410,7 +1410,7 @@ int SvxPageDescPage::DeactivatePage( SfxItemSet* _pSet )
sal_uInt16 nPos = aPaperSizeBox.GetSelectEntryPos();
Paper ePaper = (Paper)(sal_uLong)aPaperSizeBox.GetEntryData( nPos );
-if ( ePaper != PAPER_SCREEN && IsMarginOutOfRange() )
+if ( ePaper != PAPER_SCREEN_4_3 && ePaper != PAPER_SCREEN_16_9 && IsMarginOutOfRange() )
{
if ( QueryBox( this, WB_YES_NO | WB_DEF_NO, aPrintRangeQueryText ).Execute() == RET_NO )
{
diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index bc7ad78..87858fe 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -54,7 +54,7 @@
#define PAPERSIZE_C65 16
#define PAPERSIZE_DL17
#define PAPERSIZE_DIA 18
-#define PAPERSIZE_SCREEN19
+#define PAPERSIZE_SCREEN_4_319
#define PAPERSIZE_C 20
#define PAPERSIZE_D 21
#define PAPERSIZE_E 22
@@ -74,6 +74,7 @@
#define PAPERSIZE_B6_JIS36
#define PAPERSIZE_POSTCARD_JP 46
#define PAPERSIZE_A656
+#define PAPERSIZE_SCREEN_16_9 78
#endif
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index 91873c7..2137ff2 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -452,7 +452,8 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
< "C5 Envelope" ; PAPERSIZE_C5 ; > ;
< "C4 Envelope" ; PAPERSIZE_C4 ; > ;
< "Dia Slide" ; PAPERSIZE_DIA ; > ;
-< "Screen" ; PAPERSIZE_SCREEN ; >
[PATCH] fdo#40778 - Remove dictionary choice when adding new entry to the spellchecker
Hi All,
Here 2 patches related to bug 40778.
Patch 1 removes the submenu of adding new words to the dictionary when
there is only 1 dictionary in the spellcheck-popupmenu in writer.
Patch 2 does the same for the popupmenu in the other programs.
--
Greetings,
Rob Snelders
>From e8389662048074533b30e4db52129121a1cf3f86 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 17 May 2012 16:50:34 +0200
Subject: [PATCH] fd0#40778 - Remove dictionary choice when adding new entry
Change-Id: Ieaaf2466474463d19f91c74ea7f164962ba19936
---
sw/source/ui/inc/olmenu.hxx |1 +
sw/source/ui/lingu/olmenu.cxx | 21 ++---
sw/source/ui/lingu/olmenu.hrc |1 +
sw/source/ui/lingu/olmenu.src |6 ++
4 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/sw/source/ui/inc/olmenu.hxx b/sw/source/ui/inc/olmenu.hxx
index d0d45b7..3da80f3 100644
--- a/sw/source/ui/inc/olmenu.hxx
+++ b/sw/source/ui/inc/olmenu.hxx
@@ -62,6 +62,7 @@ class SwSpellPopup : public PopupMenu
std::map< sal_Int16, ::rtl::OUString > aLangTable_Paragraph;
//std::map< sal_Int16, ::rtl::OUString > aLangTable_Document;
+String aDicNameSingle;
boolbGrammarResults;// show grammar results? Or show spellcheck results?
Image aInfo16;
diff --git a/sw/source/ui/lingu/olmenu.cxx b/sw/source/ui/lingu/olmenu.cxx
index 6abb921..1d53314 100644
--- a/sw/source/ui/lingu/olmenu.cxx
+++ b/sw/source/ui/lingu/olmenu.cxx
@@ -460,8 +460,8 @@ SwSpellPopup::SwSpellPopup(
pMenu = GetPopupMenu(MN_ADD_TO_DIC);
pMenu->SetMenuFlags(MENU_FLAG_NOAUTOMNEMONICS); //! necessary to retrieve the correct dictionary name in 'Execute' below
-bEnable = sal_False;// enable MN_ADD_TO_DIC?
uno::Reference< linguistic2::XDictionaryList >xDicList( SvxGetDictionaryList() );
+sal_uInt16 nItemId = MN_DICTIONARIES_START;
if (xDicList.is())
{
// add the default positive dictionary to dic-list (if not already done).
@@ -475,7 +475,6 @@ SwSpellPopup::SwSpellPopup(
const uno::Reference< linguistic2::XDictionary > *pDic = aDics.getConstArray();
sal_uInt16 nDicCount = static_cast< sal_uInt16 >(aDics.getLength());
-sal_uInt16 nItemId = MN_DICTIONARIES_START;
for( sal_uInt16 i = 0; i < nDicCount; i++ )
{
uno::Reference< linguistic2::XDictionary > xDicTmp( pDic[i], uno::UNO_QUERY );
@@ -492,7 +491,7 @@ SwSpellPopup::SwSpellPopup(
// the extra 1 is because of the (possible) external
// linguistic entry above
pMenu->InsertItem( nItemId, xDicTmp->getName() );
-bEnable = sal_True;
+aDicNameSingle = xDicTmp->getName();
uno::Reference< lang::XServiceInfo > xSvcInfo( xDicTmp, uno::UNO_QUERY );
if (xSvcInfo.is())
@@ -510,7 +509,8 @@ SwSpellPopup::SwSpellPopup(
}
}
}
-EnableItem( MN_ADD_TO_DIC, bEnable );
+EnableItem( MN_ADD_TO_DIC, ((nItemId - MN_DICTIONARIES_START) > 1)?sal_True:sal_False );
+EnableItem( MN_ADD_TO_DIC_SINGLE, ((nItemId - MN_DICTIONARIES_START) == 1)?sal_True:sal_False );
//ADD NEW LANGUAGE MENU ITEM
///
@@ -656,6 +656,7 @@ aInfo16( SW_RES(IMG_INFO_16) )
EnableItem( MN_IGNORE_WORD, false );
EnableItem( MN_ADD_TO_DIC, false );
+EnableItem( MN_ADD_TO_DIC_SINGLE, false );
//ADD NEW LANGUAGE MENU ITEM
///
@@ -807,12 +808,18 @@ void SwSpellPopup::Execute( sal_uInt16 nId )
linguistic::AddEntryToDic( xDictionary,
xSpellAlt->getWord(), sal_False, aEmptyStr, LANGUAGE_NONE );
}
-else if (MN_DICTIONARIES_START <= nId && nId <= MN_DICTIONARIES_END)
+else if ((MN_DICTIONARIES_START <= nId && nId <= MN_DICTIONARIES_END) || nId == MN_ADD_TO_DIC_SINGLE)
{
OUString aWord( xSpellAlt->getWord() );
+String aDicName;
-PopupMenu *pMenu = GetPopupMenu(MN_ADD_TO_DIC);
-String aDicName ( pMenu->GetItemText(nId) );
+if (MN_DICTIONARIES_START <= nId && nId <= MN_DICTIONARIES_END)
+{
+PopupMenu *pMenu = GetPopupMenu(MN_ADD_TO_DIC);
+aDicName = pMenu->GetItemText(nId);
+}
+else
+aDicName = aDicNameSingle;
uno::Reference< linguistic2::XDictionary > xDic;
uno::Reference< linguistic2::XDictionaryList > xDicList( SvxGetDictionaryList() );
diff --git a/sw/source/ui/lingu/olmenu.hrc b/sw/source/ui/lingu/olmenu.hrc
index 1d65bbf..73fbac0 100644
--- a/sw/source/ui/lingu/olmenu.hrc
+++ b/sw/source/ui/lingu/olmenu.hrc
@@ -54,6 +54,7 @@
#de
[PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi All, This patch makes the SlideSorter-toolbar in Impress and Draw remember if it was visible or not for each view. When this patch is accepted then I'll create a similar patch for the ToolPanel-toolbar. -- Greetings, Rob Snelders >From d0152a068a92019131032a03bf39f00fb2fc7bf5 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Thu, 24 May 2012 21:59:57 +0200 Subject: [PATCH] fdo#35973 [EasyHack] Remember the state of the sidebar pane in Impress --- .../drawing/framework/XConfigurationController.idl |6 + .../data/org/openoffice/Office/Impress.xcu | 22 + .../schema/org/openoffice/Office/Impress.xcs | 44 ++- .../configuration/ConfigurationController.cxx | 10 +- sd/source/ui/framework/module/ResourceManager.cxx | 24 +- sd/source/ui/framework/module/ResourceManager.hxx |3 + .../ui/framework/module/SlideSorterModule.cxx | 31 +- .../ui/framework/module/SlideSorterModule.hxx |2 +- .../ui/inc/framework/ConfigurationController.hxx |3 + svtools/Library_svt.mk |1 + svtools/Package_inc.mk |1 + svtools/inc/svtools/slidesorterbaropt.hxx | 134 + svtools/source/config/slidesorterbaropt.cxx| 580 13 files changed, 846 insertions(+), 15 deletions(-) create mode 100644 svtools/inc/svtools/slidesorterbaropt.hxx create mode 100644 svtools/source/config/slidesorterbaropt.cxx diff --git a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl index 4c0fd46..1e7cdb2 100644 --- a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl +++ b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl @@ -154,6 +154,12 @@ interface XConfigurationController interface XConfigurationControllerBroadcaster; interface XResourceFactoryManager; +/** Check if the ConfigurationController is disposing +@return +When the ConfigurationController is disposing then true else false +*/ +boolean IsDisposing (); + /** Request the activation of a resource. The request is processed asynchronously. Notifications about configuration changes are sent after this call returns. diff --git a/officecfg/registry/data/org/openoffice/Office/Impress.xcu b/officecfg/registry/data/org/openoffice/Office/Impress.xcu index 6101cef..f894ccb 100644 --- a/officecfg/registry/data/org/openoffice/Office/Impress.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Impress.xcu @@ -28,6 +28,28 @@ http://openoffice.org/2004/installation"; xmlns:oor="http://openoffice.org/2001/registry"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + + + + true + + + true + + + true + + + false + + + false + + + true + + + diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs index 094cee5..8350429 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs @@ -1402,11 +1402,53 @@ - + Values related to the slide sorter. Slide Sorter Options + + +Options that control the visibility of the slide sorter. +Slide Sorter Visibility + + + + Visibility of the Slide Sorter in the Impress view. + Slide Sorter Visibility ImpressView + + + + + Visibility of the Slide Sorter in the Outline view. + Slide Sorter Visibility OutlineView + + + + + Visibility of the Slide Sorter in the Notes view. + Slide Sorter Visibility NotesView + + + + + Visibility of the Slide Sorter in the HandOut view. + Slide Sorter Visibility HandOutView + + + + + Visibility of the Slide Sorter in the SlideSorter view. + Slide Sorter Visibility SlideSorterView + + + + + Visibility of the Slide Sorter in the Draw view. + Slide Sorter Visibility DrawView + + + Values for tuning the preview cache of the slide sorter. diff --git a/sd/source/ui/framework/configuration/ConfigurationController.cxx b/sd/source/ui/framework/configuration/Configurati
Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi Tor, I have updated the license/header, I forgot to change them when I copied them from the miscopt-class. Also removed some comments with especially the art, seems usefull to me. -- Greetings, Rob Snelders Op 25-05-12 12:39, Tor Lillqvist schreef: It will take a while for me to digest and approve the patch (others are welcome to do it quicker, of course), but just a few stylistic questions at a start: - You use the old Oracle LGPL-only header in a couple of new files the patch introduces. Is this because the files in question are largely based on existing files thatuse that license/header, or just an oversight? Somebody, correct me if I am wrong, but I think new code should be MPL licensed, and use the must shorter TEMPLATE.SOURCECODE.HEADER. (Patches to existing code should be MPL/LGPL dual licensed.) - Is it really a convention to use those @ATTENTION thingies? I see only a handful of those elsewhere in the codebase. - Do we really want to introduce new instances of ASCII graphics like /*-//** ? (My own opinion is that at some point we should do a really heavy-handed automatic cleanup up the codebase and remove all silly ASCII graphics delimiters around comment blocks, separating functions etc.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice >From 261c9db301640a79a620b3ee64a9d8b3f432c4bc Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Fri, 25 May 2012 17:31:11 +0200 Subject: [PATCH] fd0#35973 - [EasyHack] Remember the state of the sidebar pane in Impress Change-Id: Ie287bc1c545bd8986ee3509181c878bdcd0d1942 --- .../drawing/framework/XConfigurationController.idl |6 + .../data/org/openoffice/Office/Impress.xcu | 22 + .../schema/org/openoffice/Office/Impress.xcs | 44 ++- .../configuration/ConfigurationController.cxx | 10 +- sd/source/ui/framework/module/ResourceManager.cxx | 24 +- sd/source/ui/framework/module/ResourceManager.hxx |3 + .../ui/framework/module/SlideSorterModule.cxx | 31 +- .../ui/framework/module/SlideSorterModule.hxx |2 +- .../ui/inc/framework/ConfigurationController.hxx |3 + svtools/Library_svt.mk |1 + svtools/Package_inc.mk |1 + svtools/inc/svtools/slidesorterbaropt.hxx | 83 svtools/source/config/slidesorterbaropt.cxx| 496 13 files changed, 711 insertions(+), 15 deletions(-) create mode 100644 svtools/inc/svtools/slidesorterbaropt.hxx create mode 100644 svtools/source/config/slidesorterbaropt.cxx diff --git a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl index 4c0fd46..1e7cdb2 100644 --- a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl +++ b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl @@ -154,6 +154,12 @@ interface XConfigurationController interface XConfigurationControllerBroadcaster; interface XResourceFactoryManager; +/** Check if the ConfigurationController is disposing +@return +When the ConfigurationController is disposing then true else false +*/ +boolean IsDisposing (); + /** Request the activation of a resource. The request is processed asynchronously. Notifications about configuration changes are sent after this call returns. diff --git a/officecfg/registry/data/org/openoffice/Office/Impress.xcu b/officecfg/registry/data/org/openoffice/Office/Impress.xcu index 6101cef..ff44549 100644 --- a/officecfg/registry/data/org/openoffice/Office/Impress.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Impress.xcu @@ -28,6 +28,28 @@ http://openoffice.org/2004/installation"; xmlns:oor="http://openoffice.org/2001/registry"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + + + + true + + + true + + + true + + + false + + + false + + + true + + + diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs index 094cee5..cb8c31a 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs @@ -1402,11 +1402,53 @@ - + Values related to the slide sorter. Slide Sorter Options + + +Options that c
fdo#45830 - Language/User Interface: current choice indicated as default
Hi All, I saw this bug and I found where the change needs to be for this bug. The problem is that the default-value for the "locale setting" is in the list the current setting, not the locale of the system. But can I solve this or should this be asked to the usability-mailinglist? And what is the emailaddress of that mailinglist? -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#45830 - Language/User Interface: current choice indicated as default
Hi,
I have created a patch that corrects the name of the default locale to
the system default. When you selected the option then it would use the
default locale but the name wasn't the default locale but the currently
selected locale. So now the name corresponds with the option.
The Default Currency isn't updated correctly, but that will need to be
looked at what the behavior should be, because I can see multiple ways
it could be working.
--
Greetings,
Rob Snelders
Op 26-05-12 17:37, Rob Snelders schreef:
Hi All,
I saw this bug and I found where the change needs to be for this bug.
The problem is that the default-value for the "locale setting" is in
the list the current setting, not the locale of the system. But can I
solve this or should this be asked to the usability-mailinglist? And
what is the emailaddress of that mailinglist?
--
Greetings,
Rob Snelders
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 37264bfc4a7cd8d87a4664913fc703c4be0caf31 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sun, 27 May 2012 12:05:56 +0200
Subject: [PATCH] fdo#45830 - Indicated Default Locale setting now correct
Change-Id: I73904225b2ea1c5b78453caafe382860fb9a3a0f
---
i18npool/source/isolang/mslangid.cxx |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/i18npool/source/isolang/mslangid.cxx b/i18npool/source/isolang/mslangid.cxx
index 3cd877e..8fe16c0 100644
--- a/i18npool/source/isolang/mslangid.cxx
+++ b/i18npool/source/isolang/mslangid.cxx
@@ -94,10 +94,7 @@ LanguageType MsLangId::getRealLanguage( LanguageType nLang )
switch (simplifySystemLanguages( nLang))
{
case LANGUAGE_SYSTEM :
-if (nConfiguredSystemLanguage == LANGUAGE_SYSTEM)
-nLang = getSystemLanguage();
-else
-nLang = nConfiguredSystemLanguage;
+nLang = getSystemLanguage();
break;
case LANGUAGE_NONE :
if (nConfiguredSystemUILanguage == LANGUAGE_SYSTEM)
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#47896 - Too many languages in Format/Language
Hi, This page removes the languages that are not installed from the language-lists in de fonts-dialog. It will always display the selected language in the languages-tab of the options-dialog. -- Greetings, Rob Snelders >From 420583a965d02bfec595088cab81e8c6d585ca71 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Sun, 27 May 2012 15:51:33 +0200 Subject: [PATCH] fd0#47896 - Too many languages in Format/Language Change-Id: I67a21d4b16c27dd68a2a87a6bcbac438da617f47 --- cui/source/tabpages/chardlg.cxx |7 --- svx/inc/svx/langbox.hxx | 37 +++-- svx/source/dialog/langbox.cxx | 26 -- 3 files changed, 47 insertions(+), 23 deletions(-) diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index c127824..48a8548 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -400,9 +400,9 @@ SvxCharNamePage::SvxCharNamePage( Window* pParent, const SfxItemSet& rInSet ) : FreeResource(); -m_pWestFontLanguageLB->SetLanguageList( LANG_LIST_WESTERN, sal_True, sal_False, sal_True ); -m_pEastFontLanguageLB->SetLanguageList( LANG_LIST_CJK, sal_True, sal_False, sal_True ); -m_pCTLFontLanguageLB->SetLanguageList( LANG_LIST_CTL, sal_True, sal_False, sal_True ); +m_pWestFontLanguageLB->SetLanguageList( LANG_LIST_SPELL_USED_WESTERN, sal_True, sal_False, sal_True ); +m_pEastFontLanguageLB->SetLanguageList( LANG_LIST_SPELL_USED_CJK, sal_True, sal_False, sal_True ); +m_pCTLFontLanguageLB->SetLanguageList( LANG_LIST_SPELL_USED_CTL, sal_True, sal_False, sal_True ); Initialize(); } @@ -907,6 +907,7 @@ void SvxCharNamePage::Reset_Impl( const SfxItemSet& rSet, LanguageGroup eLangGrp const SvxLanguageItem& rItem = (SvxLanguageItem&)rSet.Get( nWhich ); LanguageType eLangType = (LanguageType)rItem.GetValue(); DBG_ASSERT( eLangType != LANGUAGE_SYSTEM, "LANGUAGE_SYSTEM not allowed" ); +pLangBox->InsertLanguageIfNotFound( eLangType ); if ( eLangType != LANGUAGE_DONTKNOW ) pLangBox->SelectLanguage( eLangType ); break; diff --git a/svx/inc/svx/langbox.hxx b/svx/inc/svx/langbox.hxx index 7baf253..7ee0f34 100644 --- a/svx/inc/svx/langbox.hxx +++ b/svx/inc/svx/langbox.hxx @@ -38,24 +38,24 @@ class SvtLanguageTable; -#define LANG_LIST_EMPTY 0x -#define LANG_LIST_ALL 0x0001 -#define LANG_LIST_WESTERN 0x0002 -#define LANG_LIST_CTL 0x0004 -#define LANG_LIST_CJK 0x0008 -#define LANG_LIST_FBD_CHARS 0x0010 -#define LANG_LIST_SPELL_AVAIL 0x0020 -#define LANG_LIST_HYPH_AVAIL0x0040 -#define LANG_LIST_THES_AVAIL0x0080 -#define LANG_LIST_ONLY_KNOWN0x0100 // list only locales provided by I18N -#define LANG_LIST_SPELL_USED0x0200 -#define LANG_LIST_HYPH_USED 0x0400 -#define LANG_LIST_THES_USED 0x0800 -#define LANG_LIST_ALSO_PRIMARY_ONLY 0x1000 // Do not exclude primary-only -// languages that do not form a -// locale, such as Arabic as -// opposed to Arabic-Egypt. - +#define LANG_LIST_EMPTY 0x +#define LANG_LIST_ALL0x0001 +#define LANG_LIST_WESTERN0x0002 +#define LANG_LIST_CTL0x0004 +#define LANG_LIST_CJK0x0008 +#define LANG_LIST_FBD_CHARS 0x0010 +#define LANG_LIST_SPELL_AVAIL0x0020 +#define LANG_LIST_HYPH_AVAIL 0x0040 +#define LANG_LIST_THES_AVAIL 0x0080 +#define LANG_LIST_ONLY_KNOWN 0x0100 // list only locales provided by I18N +#define LANG_LIST_SPELL_USED 0x0200 +#define LANG_LIST_HYPH_USED 0x0400 +#define LANG_LIST_THES_USED 0x0800 +#define LANG_LIST_ALSO_PRIMARY_ONLY 0x1000 // Do not exclude primary-only languages that do not form a + // locale, such as Arabic as opposed to Arabic-Egypt. +#define LANG_LIST_SPELL_USED_WESTERN 0x2000 +#define LANG_LIST_SPELL_USED_CTL 0x4000 +#define LANG_LIST_SPELL_USED_CJK 0x8000 // load language strings from resource SVX_DLLPUBLIC StringGetDicInfoStr( const String& rName, const sal_uInt16 nLang, sal_Bool bNeg ); @@ -87,6 +87,7 @@ public: sal_Bool bHasLangNone, sal_Bool bLangNoneIsLangAll = sal_False, sal_Bool bCheckSpellAvail = sal_False ); +sal_uInt16 InsertLanguageIfNotFound( const LanguageType eLangType, sal_uInt16 nPos = LISTBOX_APPEND ); sal_uInt16 InsertLanguage( const LanguageType eLangType, sal_uInt16 nPos = LISTBOX_APPEND ); sal_uInt16 InsertDefaultLanguage( sal_Int16 nType, sal_uInt16 nPos = LISTBOX
Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi Tor, Op 28-05-12 13:23, Tor Lillqvist schreef: I am sorry but I still have some critique of the patch... Please don't take this too harshly. it's ok. Is this use of "IsDisposing" state variable really necessary? Or is that band-aid protection against some bug (mismanagement of dynamically allocated objects) elsewhere? I created it because otherwise it would save the visibility-states several times. Also because for each view the bar is set to invisible before disposing I added a boolean if it is already saved. The use of the GetPropertyNames() static method seems a bit overly complicated and duplicate to me; Is it really necessary to have this method *and* local variables here and there initialised by calling it? Could this be done in some simpler way? Can't this table just be a static variable in the source file? The SvtSlideSorterBarOptions::m_nRefCount thing seems a bit odd. The use of the "reference count" term is misleading, it doesn't correspond to what is normally thought of as reference counting, does it? (And if it does, then we already have some mechanisms in LO to build reference countig upon, no need to write your own.) Is it really necessary to "hide" simple boolean fields behind public setters and getters? Couldn't the fields just be made public instead? The comments "We implement these class with a refcount mechanism! Every instance of this class increase it at create and decrease it at delete time - but all instances use the same data container! He is implemented as a static member ..." , "We use these class as internal member to support small memory requirements. You can create the container if it is neccessary. The class which use these mechanism is faster and smaller then a complete implementation!" and "impl. data container as dynamic pointer for smaller memory requirements!" make me suspect you attempt some questionable micro-optimisation. I.e. make the code a lot more complex for dubious gain in speed and size. The use of naming like _impl suffix easily misleads the code reader into thinking that it is the common Pimpl idiom that is used, while in fact it is something else, a dynamically allocated block of static variables? Or am I missing something? Anyway, what is the real gain here? Does other similar code in LO use similar constructs? I copied this code from miscopts-class. I didn't change the workings as much. I'll see what can be changed. The rest is just style issues, if you can improve that too, that would be great. The capitalization of the description texts added to officecfg/registry/schema/org/openoffice/Office/Impress.xcs is a bit odd. Is the user and translators supposed to understand the difference betwee "Slide Sorter" with a space and "SlideSorter" without space? I'll change it to SlideSorter-toolbar if (SvtSlideSorterBarOptions().GetVisibleImpressView()==sal_True) should surely be written as if (SvtSlideSorterBarOptions().GetVisibleImpressView()) , etc ok. The style of Doxygen (?) comments added is inconsistent; does /*@short really work, when elsewhere you seem to use /** @short etc? Sometimes you put the terminating */ right after the last word, sometimes on a line by itself. I removed all ascii-art as you asked earlier. I didn't know Doxygen. Why lots of spaces in front of semicolons in some places, to align semicolons, but not consistently, and that is not something LO code does elsewhere, is it? I'll remove that OUString has a constructor that takes a string literal, doesn't it, no need to use the RTL_CONSTASCII_USTRINGPARAM stuff I think. In newly written code we shouldn't use sal_Bool and sal_Int32 unless necessary; just bool and int is fine. ok It is not clear who "we" and "you" in comments refer to. "we" = the class in which the comment is located, "you" = code of subclasses? i think so. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Re: fdo#45830 - Language/User Interface: current choice indicated as default
Hi,
I have resend this patch, as the earlier email didn't have [PATCH] in
the subject.
--
Greetings,
Rob Snelders
Op 27-05-12 12:34, Rob Snelders schreef:
Hi,
I have created a patch that corrects the name of the default locale to
the system default. When you selected the option then it would use the
default locale but the name wasn't the default locale but the
currently selected locale. So now the name corresponds with the option.
The Default Currency isn't updated correctly, but that will need to be
looked at what the behavior should be, because I can see multiple ways
it could be working.
--
Greetings,
Rob Snelders
Op 26-05-12 17:37, Rob Snelders schreef:
Hi All,
I saw this bug and I found where the change needs to be for this bug.
The problem is that the default-value for the "locale setting" is in
the list the current setting, not the locale of the system. But can I
solve this or should this be asked to the usability-mailinglist? And
what is the emailaddress of that mailinglist?
--
Greetings,
Rob Snelders
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 37264bfc4a7cd8d87a4664913fc703c4be0caf31 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Sun, 27 May 2012 12:05:56 +0200
Subject: [PATCH] fdo#45830 - Indicated Default Locale setting now correct
Change-Id: I73904225b2ea1c5b78453caafe382860fb9a3a0f
---
i18npool/source/isolang/mslangid.cxx |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/i18npool/source/isolang/mslangid.cxx b/i18npool/source/isolang/mslangid.cxx
index 3cd877e..8fe16c0 100644
--- a/i18npool/source/isolang/mslangid.cxx
+++ b/i18npool/source/isolang/mslangid.cxx
@@ -94,10 +94,7 @@ LanguageType MsLangId::getRealLanguage( LanguageType nLang )
switch (simplifySystemLanguages( nLang))
{
case LANGUAGE_SYSTEM :
-if (nConfiguredSystemLanguage == LANGUAGE_SYSTEM)
-nLang = getSystemLanguage();
-else
-nLang = nConfiguredSystemLanguage;
+nLang = getSystemLanguage();
break;
case LANGUAGE_NONE :
if (nConfiguredSystemUILanguage == LANGUAGE_SYSTEM)
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi, I have changed a lot of the things Tor wrote about in the earlier email. Except the issue below and the issue about IsDisposing. I also saw another little bug in the patch and solved that. -- Greetings, Rob Snelders Op 28-05-12 16:55, Tor Lillqvist schreef: Rob pointed out to me that much of his additions is in fact based on existing code, svtools/inc/svtools/miscopt.hxx etc. Which uses a similar oddly phrased comments, weird _Impl class with "reference counting" that is not a Pimpl, and other potential signs of micro-optimization for dubious gain. So is it OK then, and I am just being too sensitive? Since when am I a C++ expert anyway? Or should we ask him to try to simplify both the existing code and his own? --tml >From 27e88c17ba3450d2b2d9ba47b1c49b7ece1c3f57 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Mon, 28 May 2012 16:54:34 +0200 Subject: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar Change-Id: I61a3bc81ebd267c39718ae16dc99c80cd862ca9e --- .../drawing/framework/XConfigurationController.idl |6 + .../data/org/openoffice/Office/Impress.xcu | 22 + .../schema/org/openoffice/Office/Impress.xcs | 48 ++ .../configuration/ConfigurationController.cxx | 10 +- sd/source/ui/framework/module/ResourceManager.cxx | 24 +- sd/source/ui/framework/module/ResourceManager.hxx |3 + .../ui/framework/module/SlideSorterModule.cxx | 31 +- .../ui/framework/module/SlideSorterModule.hxx |2 +- .../ui/inc/framework/ConfigurationController.hxx |3 + svtools/Library_svt.mk |1 + svtools/Package_inc.mk |1 + svtools/inc/svtools/slidesorterbaropt.hxx | 89 svtools/source/config/slidesorterbaropt.cxx| 501 13 files changed, 727 insertions(+), 14 deletions(-) create mode 100644 svtools/inc/svtools/slidesorterbaropt.hxx create mode 100644 svtools/source/config/slidesorterbaropt.cxx diff --git a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl index 4c0fd46..1e7cdb2 100644 --- a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl +++ b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl @@ -154,6 +154,12 @@ interface XConfigurationController interface XConfigurationControllerBroadcaster; interface XResourceFactoryManager; +/** Check if the ConfigurationController is disposing +@return +When the ConfigurationController is disposing then true else false +*/ +boolean IsDisposing (); + /** Request the activation of a resource. The request is processed asynchronously. Notifications about configuration changes are sent after this call returns. diff --git a/officecfg/registry/data/org/openoffice/Office/Impress.xcu b/officecfg/registry/data/org/openoffice/Office/Impress.xcu index 6101cef..ff44549 100644 --- a/officecfg/registry/data/org/openoffice/Office/Impress.xcu +++ b/officecfg/registry/data/org/openoffice/Office/Impress.xcu @@ -28,6 +28,28 @@ http://openoffice.org/2004/installation"; xmlns:oor="http://openoffice.org/2001/registry"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + + + + true + + + true + + + true + + + false + + + false + + + true + + + diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs index 094cee5..907b874 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs @@ -1402,6 +1402,54 @@ + + + Values related to the SlideSorter-toolbar. + SlideSorter-toolbar Options + + + +Options that control the visibility of the SlideSorter-toolbar. +SlideSorter-toolbar Visibility + + + + Visibility of the SlideSorter-toolbar in the Impress view. + SlideSorter-toolbar Visibility ImpressView + + + + + Visibility of the SlideSorter-toolbar in the Outline view. + SlideSorter-toolbar Visibility OutlineView + + + + + Visibility of the SlideSorter-toolbar in the Notes view. + SlideSorter-toolbar Visibility NotesView + + + + + Visibility of the SlideSorter-toolbar in the HandOut view. +
[PATCH] Re: [PATCH] [PUSHED] Re: fdo#45830 - Language/User Interface: current choice indicated as default
Hi,
The patch was reverted because it gave errors. I have changed the patch.
Can anybody look if it is ok now?
I changed the patch so that it is solved in
SvxLanguageBox::ImplInsertLanguage. The only function that calls it with
the LANGUAGE_SYSTEM-option is the optgdlg (OptionsDialog->Language). Is
it correct this way or is a new function needed as not to disturb the
current function?
--
Greetings,
Rob Snelders
Op 28-05-12 16:59, Tor Lillqvist schreef:
Thanks, pushed.
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
>From 67fd871f3549b977406da10a2062f6b229cbd519 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Tue, 29 May 2012 23:25:10 +0200
Subject: [PATCH] fdo#45830: Indicate correct default locale setting
Change-Id: Iac77758e4cdd48629ae276566bec2d7a4b873e38
---
svx/source/dialog/langbox.cxx |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/svx/source/dialog/langbox.cxx b/svx/source/dialog/langbox.cxx
index 0ec2329..a2ec7fd 100644
--- a/svx/source/dialog/langbox.cxx
+++ b/svx/source/dialog/langbox.cxx
@@ -349,7 +349,10 @@ sal_uInt16 SvxLanguageBox::ImplInsertLanguage( const LanguageType nLangType, sal
LanguageType nRealLang = nLang;
if (nRealLang == LANGUAGE_SYSTEM)
{
-nRealLang = MsLangId::resolveSystemLanguageByScriptType(nRealLang, nType);
+if (nType == ::com::sun::star::i18n::ScriptType::WEAK)
+nRealLang = MsLangId::getSystemLanguage();
+else
+nRealLang = MsLangId::resolveSystemLanguageByScriptType(nRealLang, nType);
aStrEntry.AppendAscii(" - ");
aStrEntry.Append(m_pLangTable->GetString( nRealLang ));
}
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Dialog "About LibreOffice" contents
or search for a string on the about dialog in opengrok.libreoffice.org. That will probably lead you to the src-file corresponding with the cxx-file you want. (that's the way I look for code-files I need). -- Greetings, Rob Snelders Op 04-06-12 18:22, Noel Grandin schreef: "git grep" is your friend. On 2012-06-04 18:13, Yoandy Pérez Villazón wrote: Hi, can someone tell me where in the code is the contents of the dialog (About LibreOffice)? Thank you all, 10mo. ANIVERSARIO DE LA CREACION DE LA UNIVERSIDAD DE LAS CIENCIAS INFORMATICAS... CONECTADOS AL FUTURO, CONECTADOS A LA REVOLUCION http://www.uci.cu http://www.facebook.com/universidad.uci http://www.flickr.com/photos/universidad_uci ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 1.6Gb of workdir/.../Dep - thoughts ...
Hi All, I want to add that the buildspeed and disksize does matter. Not everybody who wants to help can afford the newest machines. -- Greetings, Rob Snelders Op 04-06-12 19:53, Michael Meeks schreef: Hi Bjoern, On Mon, 2012-06-04 at 17:19 +0200, Bjoern Michaelsen wrote: But concat-deps is _after_ the creation dep files of the objects (which will then still be huge). Sigh; true - it'll mostly speedup build time then; then again we could filter them during / after generation I suppose. - a significant part of .d content is the depend-on-nothing deps created by -MP , if those would be merged into one dedicated .d file that'd save a lot of space as well; not sure if this is easily doable though Arent we doing that already when merging the .d files for one library? Right; that is done already as we merge to a library. Note however, that every bit of added complexity to the build system will bite you back one day. Currently the Deps are ~10% of the working directory -- even if you reduce them by 90%(*) Why do you think that Deps are 10% of the working directory ? $ du -m workdir/unxlngi6.pro | tail -n 1 2906unxlngi6.pro $ du -m workdir/unxlngi6.pro/Dep | tail -n 1 1546unxlngi6.pro/Dep For me that reads> 50% of the size. So right now, I consider the topic premature optimization until proven otherwise. Is my workdir abnormally different to yours ? it's normal to have> 1.5Gb of 'stuff' in there I think - at least someone I sanity checked with saw that too - IMHO it's too big. ATB, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#39641 - Clean up document type association on Linux
HI All, I wanted to look at this bug. But I wondered if the printeradmin still is in the code and still works. Can anybody tell me the status of the printer-admin-tool? -- Greetings, Rob Snelders -- -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Build Error
Hi All, When i tried a build with debugging then I ran into the error as is in the file build-error. The attached patch solved the error. -- Greetings, Rob Snelders [ build CUT ] i18npool_test_breakiterator [ build CUT ] i18npool_test_characterclassification [ build CUT ] o3tl_tests [ build CUT ] sax_cppunit [ build CUT ] sot_test_sot [ build CUT ] svl_lngmisc [ build CUT ] tools_test [ build LNK ] Library/libvcllo.so [ build MOD ] connectivity [ build MOD ] lingucomponent [ build JAR ] OOoRunnerLight [ build JAR ] commonwizards [ build MOD ] xmloff [ build CHK ] basebmp [ build CHK ] basegfx [ build CHK ] binaryurp [ build CHK ] i18npool [ build CHK ] o3tl [ build CHK ] sax [ build CHK ] sot [ build CHK ] svl [ build CHK ] tools [ build CXX ] dbaccess/source/core/api/BookmarkSet.cxx [ build CXX ] dbaccess/source/core/api/CacheSet.cxx /home/projecten/libo_20120610/workdir/unxlngx6/CxxObject/vcl/generic/glyphs/gcach_layout.o: In function `IcuFontFromServerFont::getFontTable(unsigned int) const': /home/projecten/libo_20120610/vcl/generic/glyphs/gcach_layout.cxx:237: undefined reference to `ServerFont::GetFontFileName() const' collect2: ld gaf exit-status 1 terug make[2]: *** [/home/projecten/libo_20120610/workdir/unxlngx6/LinkTarget/Library/libvcllo.so] Fout 1 make[2]: *** Wachten op onvoltooide taken... --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 512 occurred while making /home/projecten/libo_20120610/tail_build/prj it seems that the error is inside 'tail_build', please re-run build inside this module to isolate the error and/or test your fix: build_error.log should contain the captured output of the failed module(s) --- To rebuild a specific module: make tail_build.clean # not recommended, this will re-build almost everything make tail_build when the problem is isolated and fixed, re-run 'make' make[1]: *** [build-packimages] Fout 1 make[1]: Map '/home/projecten/libo_20120610' wordt verlaten make: *** [dev-install] Fout 2 >From 23e04f1d5c6cf642a2abf41fbe13d107004a9a76 Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Mon, 11 Jun 2012 08:19:37 +0200 Subject: [PATCH] fix build error Change-Id: Ie43fb139af5cfd3a4386fb21ad71d1adeb85bd82 --- vcl/generic/glyphs/gcach_layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcl/generic/glyphs/gcach_layout.cxx b/vcl/generic/glyphs/gcach_layout.cxx index 40c7a33..5326299 100644 --- a/vcl/generic/glyphs/gcach_layout.cxx +++ b/vcl/generic/glyphs/gcach_layout.cxx @@ -234,7 +234,7 @@ const void* IcuFontFromServerFont::getFontTable( LETag nICUTableTag ) const #if OSL_DEBUG_LEVEL > 1 fprintf(stderr,"IcuGetTable(\"%s\") => %p\n", pTagName, pBuffer); int mnHeight = mrServerFont.GetFontSelData().mnHeight; -const char* pName = mrServerFont.GetFontFileName()->getStr(); +const char* pName = mrServerFont.GetFontFileName().getStr(); fprintf(stderr,"font( h=%d, \"%s\" )\n", mnHeight, pName ); #endif return (const void*)pBuffer; -- 1.7.9.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress
Hi Tor, I looked at the miscopt.*xx. When searching for other alike classes I did find several, for example: - /core/unotools/source/config/misccfg.cxx - /core/unotools/source/config/printwarningoptions.cxx - /core/svtools/source/config/optionsdrawinglayer.cxx - /core/svtools/source/config/menuoptions.cxx So this isn't a single occurance of this complexity. What does needs to be changed in the slidesorterbaropt.*xx? I'm not sure what you want. A lot of complexity can be removed. Is the mutexguard still needed? I think so but I don't know the reasons to cut it in 2 classes. Isn't it simpler to always save the preferences when the class is destroyed? Then a simple boolean-variable is enough to save in the impl-class. The need to create a different class for these values is that you need to set the ROOTNODE for the configItem-class Please help me in how to proceed with this patch. I'm not sure what to do next. -- Greetings, Rob Snelders Op ma 28 mei 2012 18:49:01 CEST, Tor Lillqvist schreef: A hard one; I'd not hold a volunteer's feature up for a cleanup, but clearly having the code made beautiful is in the end a good goal OTOH - this is some UNO using code so - our ability to make it succinct and sweet is somewhat constrained anyway - cf. the property verbosity. Sure, but we shouldn't encourage copy-pasting code either? Is it certain that the new options introduced here can't be handled in miscopt.hxx/cxx? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#38731 - Papiamentu not avaliable as language
Hi, I have looked at this bug. The problem consists of 2 parts: - The language-name is updated. Because the country Dutch Antilles is gone and the country has split into Curacao and a part has become the Netherlands. The language Papiamentu has now pap_cw and pap_bq. Of both I can't find the locale IDs Windows uses to define them. Where should I find them (I used the links on http://erack.de/bookmarks/D.html#GIL_MS) or as what do I need to define them? - The current papiamentu languages can be found in the character-dialog when you set a language there. But they can't be found in the options-dialog at the language selecter. Can I add them there or isn't that allowed? -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#50871 BUGZILLAASSISTANT: Help Linguistic & PDF Export not available
Hi, I also created a patch for when the component is renamed. -- Greetings, Rob Snelders Op 22-06-12 18:54, Rainer Bielefeld schreef: Caolán McNamara schrieb: Use localization, globalization, etc., throughout regardless of US/UK English IMO. Hi, I think so, too, and will modify that for next new LibO release we get, so that no extra Assistant update will be required. <https://wiki.documentfoundation.org/BugReport_Details#Localisation> http://en.wikipedia.org/wiki/Eats,_Shoots_%26_Leaves :-) :-) Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice From bfe6e1e5a92b8adddb0eaf307ae700baea4c5f3f Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Thu, 21 Jun 2012 21:27:57 +0200 Subject: [PATCH] Localisation changed to Localization --- bug/bug.xhtml |2 +- bug/sanity-query.xhtml |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bug/bug.xhtml b/bug/bug.xhtml index fed2e2d..ca70672 100644 --- a/bug/bug.xhtml +++ b/bug/bug.xhtml @@ -124,7 +124,7 @@ - + &component_comments; diff --git a/bug/sanity-query.xhtml b/bug/sanity-query.xhtml index 5342d2d..6ab3dfa 100644 --- a/bug/sanity-query.xhtml +++ b/bug/sanity-query.xhtml @@ -1,4 +1,4 @@ -cpts[0] = ['BASIC', 'BugAssistant', 'Chart', 'contrib', 'Database', 'Documentation', 'Drawing', 'Extensions', 'Formula editor', 'Installation', 'Libreoffice', 'Linguistic', 'Localisation', 'Printing and PDF export', 'Presentation', 'Spreadsheet', 'UI', 'Writer', 'WWW' ]; +cpts[0] = ['BASIC', 'BugAssistant', 'Chart', 'contrib', 'Database', 'Documentation', 'Drawing', 'Extensions', 'Formula editor', 'Installation', 'Libreoffice', 'Linguistic', 'Localization', 'Printing and PDF export', 'Presentation', 'Spreadsheet', 'UI', 'Writer', 'WWW' ]; LibreOffice -- 1.7.9.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#50871 BUGZILLAASSISTANT: Help Linguistic & PDF Export not available
Hi, I have checked it and it should work. So I see no problem that this patch is pushed. -- Greetings, Rob Snelders Op wo 27 jun 2012 20:00:49 CEST, Rainer Bielefeld schreef: Petr Mladek schrieb: I am still confused. I am talking about Rob's 0001-Localisation-changed-to-Localization.patch. I guess that we want to rename the component but I am not sure about the push timing. Do you need to do some changes in bugzilla first? Hi Petr, no need to be confused. All fixes can (and should) be pushed immediately when review has showed that the patch is sane. The push is without any influence to the Assistant until the update of the Assistant due to <https://wiki.documentfoundation.org/Bug_Submission_Assistant#Installation_and_maintenance> will have been done. I consider that these updates only can be done when Bugzilla, Wiki and may be patches all are prepared. Currently these Updates generally are done By Thorsten Behrens (I did not understand the SSH proceeding), and I initiate the the update only So please push Rob's latest patch. Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#41601 - BUGZILLAASSISTANT: Mouseover SUBMIT button does not change mouse pointer view
Hi All,
Here the patch that solves this bug. The SUBMIT-button now has the
pointer again.
--
Greetings,
Rob Snelders
>From 9f014d4a35ccf973b3c1a05732caae56f870175b Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 27 Jun 2012 23:29:01 +0200
Subject: [PATCH] fdo#41601 - BUGZILLAASSISTANT: Mouseover SUBMIT button does
not change mouse pointer view
---
bug/bug/bug.css |4
1 file changed, 4 deletions(-)
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 34e4377..6fde858 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -430,11 +430,7 @@ body {
color: #fff;
text-align: center;
line-height: 49px;
-}
-
-.state_submit div:hover.go {
cursor: pointer;
-background: url('images/submit-hover.png') no-repeat;
}
/* related bugs */
--
1.7.9.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] updates for the bugzilla-assistant
Hi All,
Here 3 small patches for the bugzilla assistant.
- The first fixes the problem that some debug-options (set with the
skin-variable) didn't give the correct screen
- The second removes trailing white-spaces
- The thirth solves a bug when the bugzilla can't be reached. It gives
an error now, while it used to give java-script errors.
--
Greetings,
Rob Snelders
>From 2e922d4f9f81fe129ee2d613295c3184ca4058e3 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 5 Jul 2012 21:04:54 +0200
Subject: [PATCH] Select the first options in the select-boxes so the
skin-options always work.
---
bug/bug/skin.js |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bug/bug/skin.js b/bug/bug/skin.js
index 1399fac..7858f67 100644
--- a/bug/bug/skin.js
+++ b/bug/bug/skin.js
@@ -26,18 +26,18 @@
}
function subcomponent() {
component();
- $('.state_component .choice:nth(3)').click();
+ $('.state_component .choice:nth(0)').click();
}
function version() {
subcomponent();
$.bug.ajax = function(settings) {
return $.Deferred().resolve('NUM,DESC\n100,"BUG 1"\n200,"BUG 2"\n');
};
- $('.state_subcomponent .active_subcomponent .choice:nth(2)').click();
+ $('.state_subcomponent .active_subcomponent .choice:nth(0)').click();
}
function description() {
version();
- $('.state_version .choice:nth(2)').click();
+ $('.state_version .choice:nth(0)').click();
$('.state_description .short').val('12');
}
function submit() {
--
1.7.9.5
>From 52c3e6d644b08e669edd7fb8873c09ccc1a7de62 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Thu, 5 Jul 2012 22:19:47 +0200
Subject: [PATCH] Remove trailing whitespaces
---
bug/bug.xhtml |4 ++--
bug/bug/bug.css |2 +-
bug/bug/bug.js| 14 +++---
bug/bug/qunit.css | 10 +-
bug/bug/select.js |2 +-
bug/bug/test.html |2 +-
bug/bug/test.js |2 +-
bug/subcomponents.xsl |2 +-
8 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index 254731a..d43008b 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -92,12 +92,12 @@
-
+
The bug report has been successfully submitted.
You can edit it or add attachments using the corresponding bugzilla page.
-
+
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index 6fde858..a932f2a 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -15,7 +15,7 @@
along with this program. If not, see .
*/
/* javascript and old browsers fallback */
-.javascript, .unsupported, .compatibility .version {
+.javascript, .unsupported, .compatibility .version {
display: none;
}
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index d670092..9b7f906 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -53,7 +53,7 @@
$.bug.error_set(error[1]);
throw error;
} else {
-var success = data.match(success_regexp);
+var success = data.match(success_regexp);
if(success !== null) {
return success[1];
} else {
@@ -114,23 +114,23 @@
element.show();
$('.select', element).select();
$('.select .choice, img', element).hover(function() {
-var component = $(this).attr('data');
+var component = $(this).attr('data');
$('.comment', element).hide();
$('.comment.' + component, element).show();
});
$('.select .choice', element).click(function() {
$(this).mouseenter();
-var component = $(this).attr('data');
+var component = $(this).attr('data');
$('img', element).removeClass('selected');
$('img[data="' + component + '"]').addClass('selected');
$.bug.state_subcomponent();
});
$('img', element).click(function() {
-var component = $(this).attr('data');
+var component = $(this).attr('data');
$(".select .choice[data='" + component + "']", element).click();
});
$('.components_icons').mouseleave(function() {
-$('img.selected', element).mouseenter();
Re: [PUSHED] updates for the bugzilla-assistant
Op ma 09 jul 2012 21:13:21 CEST, Thorsten Behrens schreef: Rob Snelders wrote: Here 3 small patches for the bugzilla assistant. Thanks a lot, pushed & set live on the website. I tried the bugzilla-assistant and it doesn't work for me. It can't find the jquery.js, bug.js and skin.js. Can you look if they are there? Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[HELP] fdo#47707 PRINTING: Printing windows wrong color indication
Hi,
I have searched for the problem of fdo#47707. And I think I found it,
but I have some questions.
I have attached a diff. When I know I have the correct solution I'll
submit it to gerrit.
docshel4.cxx -> getPrinter-function: I don't know why this exists. It is
called when you insert a picture in impress. I don't know if ever
another drawmode is used then the default drawmode in that function. But
I think the change will also need to happen there, although I'm not sure.
The Black&White-option would be useful in my opinion when it prints
pictures but no the background. But I can't turn on the one without the
other (both are set with the DRAWMODE_WHITEBITMAP-define). So I think
then all pictures should be turned off otherwise it hardly is different
from grayscale.
--
Greetings,
Rob Snelders
diff --git a/sd/source/ui/docshell/docshel4.cxx b/sd/source/ui/docshell/docshel4.cxx
index 5b0d4c5..033a66f 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -129,9 +129,9 @@ SfxPrinter* DrawDocShell::GetPrinter(sal_Bool bCreate)
sal_uLong nMode = DRAWMODE_DEFAULT;
if( nQuality == 1 )
-nMode = DRAWMODE_GRAYLINE | DRAWMODE_GRAYFILL | DRAWMODE_BLACKTEXT | DRAWMODE_GRAYBITMAP | DRAWMODE_GRAYGRADIENT;
+nMode = DRAWMODE_GRAYLINE | DRAWMODE_GRAYFILL | DRAWMODE_GRAYTEXT | DRAWMODE_GRAYBITMAP | DRAWMODE_GRAYGRADIENT;
else if( nQuality == 2 )
-nMode = DRAWMODE_BLACKLINE | DRAWMODE_BLACKTEXT | DRAWMODE_WHITEFILL | DRAWMODE_GRAYBITMAP | DRAWMODE_WHITEGRADIENT;
+nMode = DRAWMODE_BLACKLINE | DRAWMODE_WHITEFILL | DRAWMODE_BLACKTEXT | DRAWMODE_WHITEBITMAP | DRAWMODE_WHITEGRADIENT;
mpPrinter->SetDrawMode( nMode );
diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx
index 794e4ab..6fcb1c3 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -1506,13 +1506,13 @@ private:
{
case 1:
aInfo.mnDrawMode = DRAWMODE_GRAYLINE | DRAWMODE_GRAYFILL
-| DRAWMODE_BLACKTEXT | DRAWMODE_GRAYBITMAP
+| DRAWMODE_GRAYTEXT | DRAWMODE_GRAYBITMAP
| DRAWMODE_GRAYGRADIENT;
break;
case 2:
-aInfo.mnDrawMode = DRAWMODE_BLACKLINE | DRAWMODE_BLACKTEXT
-| DRAWMODE_WHITEFILL | DRAWMODE_GRAYBITMAP
+aInfo.mnDrawMode = DRAWMODE_BLACKLINE | DRAWMODE_WHITEFILL
+| DRAWMODE_BLACKTEXT | DRAWMODE_WHITEBITMAP
| DRAWMODE_WHITEGRADIENT;
break;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Bugzilla-assistant
Hi Petr, The Localization should be changed to Localisation. It is for the testing if typo's are found by the sanity-checker. I have already updated the wiki-page accordingly so it doesn't show the components anymore that don't have a capital. -- Greetings, Rob Snelders Op 03-08-12 18:17, Petr Mladek schreef: Hi Rob, I am very sorry that we all missed the patches for too long time. We were busy with 3.6.0 release. It is bad excuse but... Please, see also one question bellow. Thorsten, could you please pull and restart the stuff on the server? Rob Snelders píše v Po 16. 07. 2012 v 23:09 +0200: Hi All, I have created 3 patches for the Bugzilla-assistant: They looked good => pushed, see: http://cgit.freedesktop.org/libreoffice/website/commit/?id=bd005b18110d9eef71eb21fbe9366f331c130e4f http://cgit.freedesktop.org/libreoffice/website/commit/?id=6e1517a3d8f0fec890874379108d61a8b0f4d39b http://cgit.freedesktop.org/libreoffice/website/commit/?id=a146af203f5f88a9bb5250f13a476e48e1f405ca I am only a bit curious about the second one. It renames 'Localization' back to 'Localisation'. Is it by purpose? Finally, I slightly improved the indentation, see http://cgit.freedesktop.org/libreoffice/website/commit/?id=1e91864a92f986c253d8513d5f1d84676d55e063 You know, it was hard to understand the changes in the long lines. I hope that it is fine for you ;-) Thanks a lot for nice contribution. I will do my best to push your patches faster next time. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Bugzilla-assistant
Hi Petr, I just build it again and the makeup of the page is wrong now. The problem is with the patch you made. I don't know why but when I revert the patch then it is shown correctly again. I think that's a bug with html or firefox (the browser I use). The problem is that the box with the extra info is below the components with the patch and next to the components without. Can you revert the patch you made? -- Greetings, Rob Snelders Op 03-08-12 18:17, Petr Mladek schreef: Hi Rob, I am very sorry that we all missed the patches for too long time. We were busy with 3.6.0 release. It is bad excuse but... Please, see also one question bellow. Thorsten, could you please pull and restart the stuff on the server? Rob Snelders píše v Po 16. 07. 2012 v 23:09 +0200: Hi All, I have created 3 patches for the Bugzilla-assistant: They looked good => pushed, see: http://cgit.freedesktop.org/libreoffice/website/commit/?id=bd005b18110d9eef71eb21fbe9366f331c130e4f http://cgit.freedesktop.org/libreoffice/website/commit/?id=6e1517a3d8f0fec890874379108d61a8b0f4d39b http://cgit.freedesktop.org/libreoffice/website/commit/?id=a146af203f5f88a9bb5250f13a476e48e1f405ca I am only a bit curious about the second one. It renames 'Localization' back to 'Localisation'. Is it by purpose? Finally, I slightly improved the indentation, see http://cgit.freedesktop.org/libreoffice/website/commit/?id=1e91864a92f986c253d8513d5f1d84676d55e063 You know, it was hard to understand the changes in the long lines. I hope that it is fine for you ;-) Thanks a lot for nice contribution. I will do my best to push your patches faster next time. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] code cleanup
Hi All, I have cleaned this up after an email from Tor (see attachment) explaining what needs to be done to clean it up. When something needs to be different then please let me know, as there are more a-like classes and I want to clean those up the same way, but I want to verify if this is ok before I change those. -- Greetings, Rob Op 04-08-12 20:48, Gerrit schreef: >From Rob Snelders : Rob Snelders has uploaded a new change for review. Change subject: code cleanup .. code cleanup Change-Id: Ib154cd53253e4d802d13a024a20f6c34d499e672 --- M svtools/inc/svtools/slidesorterbaropt.hxx M svtools/source/config/slidesorterbaropt.cxx 2 files changed, 132 insertions(+), 160 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/368/1 -- To view, visit https://gerrit.libreoffice.org/368 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib154cd53253e4d802d13a024a20f6c34d499e672 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice I am sorry but I still have some critique of the patch... Please don't take this too harshly. Is this use of "IsDisposing" state variable really necessary? Or is that band-aid protection against some bug (mismanagement of dynamically allocated objects) elsewhere? The use of the GetPropertyNames() static method seems a bit overly complicated and duplicate to me; Is it really necessary to have this method *and* local variables here and there initialised by calling it? Could this be done in some simpler way? Can't this table just be a static variable in the source file? The SvtSlideSorterBarOptions::m_nRefCount thing seems a bit odd. The use of the "reference count" term is misleading, it doesn't correspond to what is normally thought of as reference counting, does it? (And if it does, then we already have some mechanisms in LO to build reference countig upon, no need to write your own.) Is it really necessary to "hide" simple boolean fields behind public setters and getters? Couldn't the fields just be made public instead? The comments "We implement these class with a refcount mechanism! Every instance of this class increase it at create and decrease it at delete time - but all instances use the same data container! He is implemented as a static member ..." , "We use these class as internal member to support small memory requirements. You can create the container if it is neccessary. The class which use these mechanism is faster and smaller then a complete implementation!" and "impl. data container as dynamic pointer for smaller memory requirements!" make me suspect you attempt some questionable micro-optimisation. I.e. make the code a lot more complex for dubious gain in speed and size. The use of naming like _impl suffix easily misleads the code reader into thinking that it is the common Pimpl idiom that is used, while in fact it is something else, a dynamically allocated block of static variables? Or am I missing something? Anyway, what is the real gain here? Does other similar code in LO use similar constructs? The rest is just style issues, if you can improve that too, that would be great. The capitalization of the description texts added to officecfg/registry/schema/org/openoffice/Office/Impress.xcs is a bit odd. Is the user and translators supposed to understand the difference betwee "Slide Sorter" with a space and "SlideSorter" without space? if (SvtSlideSorterBarOptions().GetVisibleImpressView()==sal_True) should surely be written as if (SvtSlideSorterBarOptions().GetVisibleImpressView()) , etc The style of Doxygen (?) comments added is inconsistent; does /*@short really work, when elsewhere you seem to use /** @short etc? Sometimes you put the terminating */ right after the last word, sometimes on a line by itself. Why lots of spaces in front of semicolons in some places, to align semicolons, but not consistently, and that is not something LO code does elsewhere, is it? OUString has a constructor that takes a string literal, doesn't it, no need to use the RTL_CONSTASCII_USTRINGPARAM stuff I think. In newly written code we shouldn't use sal_Bool and sal_Int32 unless necessary; just bool and int is fine. It is not clear who "we" and "you" in comments refer to. "we" = the class in which the comment is located, "you" = code of subclasses? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#53084 - BUGZILLAASSISTANT: focus on page bottom instead on Bugzilla link after Bus Submission
Hi,
The attached patch fixes bug fdo#53084. This is a patch for the
libreoffice-website-repository.
--
Greetings,
Rob Snelders
>From 4383c528d1e8882cf68b0df4b0c0d564e5f5aea4 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 15 Aug 2012 21:07:48 +0200
Subject: [PATCH] fdo#53084 - BUGZILLAASSISTANT: focus on page bottom instead
on Bugzilla link after Bus Submission
---
bug/bug/bug.js |1 +
1 file changed, 1 insertion(+)
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 9947ff2..8e7cc0a 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -266,6 +266,7 @@
var bug = $('.state_submit .bug').text();
$('.bug', element).attr('href', $.bug.url + '/show_bug.cgi?id=' + bug);
element.show();
+window.scrollTo(0,0);
},
// if this string is found in the page returned when
--
1.7.9.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Bugzilla-assistant updates
Hi,
These 2 patches fix 2 bugs of the bugzilla-assistant:
- *Bug 53082* <https://bugs.freedesktop.org/show_bug.cgi?id=53082>
-BUGZILLAASSISTANT: Improve exception handling for unavailable Bugzilla
- *Bug 50851* <https://bugs.freedesktop.org/show_bug.cgi?id=50851>
-BUGZILLAASSISTANT: Error message should be in focus
Please add them to the repository (with the 1 I send earlier today) and
update the BSA.
>From b027776d5a886e0c6a6209085ad2e3113f9a830e Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 15 Aug 2012 22:08:00 +0200
Subject: [PATCH] fdo#50851 - BUGZILLAASSISTANT: Error message should be in
focus
---
bug/bug/bug.js |1 +
1 file changed, 1 insertion(+)
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 8e7cc0a..fdd14ec 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -42,6 +42,7 @@
message += 'statusText = ' + error.statusText + ' ';
}
$.bug.error_set(message);
+window.scrollTo(0,0);
throw error;
});
},
--
1.7.9.5
>From 8bf699575bbb4c8231ec757a5a19550e97efb147 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Wed, 15 Aug 2012 22:30:39 +0200
Subject: [PATCH] fdo#53082 - BUGZILLAASSISTANT: Improve exception handling
for unavailable Bugzilla
---
bug/bug/bug.js | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index fdd14ec..0565d84 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -32,15 +32,25 @@
} else {
message = url + '(' + $.param(args) + ') XHR error. ';
}
-if('status' in error) {
-message += 'status = ' + error.status + ' ';
-}
-if('responseText' in error) {
-message += 'responseText = ' + error.responseText + ' ';
-}
-if('statusText' in error) {
-message += 'statusText = ' + error.statusText + ' ';
-}
+
+ if (url == "/enter_bug.cgi" && 'status' in error && (error.status == 404 || error.status == 0)) {
+ message = "It seems there is a problem to connect with Bugzilla. Please try again later.";
+ }
+ else
+ {
+if('status' in error) {
+ if(error.status == 404 || error.status == 0) {
+ message += "Cannot find the URL specified.\n\n";
+ }
+message += 'status = ' + error.status + ' ';
+}
+if('responseText' in error) {
+message += 'responseText = ' + error.responseText + ' ';
+}
+if('statusText' in error) {
+message += 'statusText = ' + error.statusText + ' ';
+}
+ }
$.bug.error_set(message);
window.scrollTo(0,0);
throw error;
--
1.7.9.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
BugzillaAssistant
Hi All,
Here are 2 small patches for the bugzilla-assistant.
--
Greetings,
Rob Snelders
>From 70a0477efcaf401642db916cb76acccb00bb6246 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Fri, 17 Aug 2012 00:03:50 +0200
Subject: [PATCH] Hides the username that is printed for testing
---
bug/bug/bug.css |4
1 file changed, 4 insertions(+)
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index a932f2a..f81aa9b 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -610,3 +610,7 @@ body {
background: url('images/select-right.png') repeat-y top right;
padding-right: 12px;
}
+
+.username {
+display: hidden;
+}
--
1.7.9.5
>From 1c1aa6cff807d54b1ea42997ac74428289334503 Mon Sep 17 00:00:00 2001
From: Rob Snelders
Date: Fri, 17 Aug 2012 00:07:06 +0200
Subject: [PATCH] Reset the error-message when submitting the bug
---
bug/bug/bug.js |1 +
1 file changed, 1 insertion(+)
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 0565d84..a0be19d 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -235,6 +235,7 @@
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
var form = $('.submission_form form');
+$.bug.error_clear();
form.attr('action', $.bug.url + '/post_bug.cgi');
form.submit(function() {
if($(element).hasClass('inprogress')) {
--
1.7.9.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: BSA + New Wiki = No Good
Hi All, I did say that yesterday on the IRC. Since a little while I have been working a bit on the BSA. I seems that with the change of the wiki that the HTML-output of the BugReport_Details has been changed. After the conference I want to look at it. I can run a diff on the old and the new output and see what has changed. For now the BSA on the website still works. But we can't update it at the moment so It will have to be fixed but it can be done a little later. -- Greetings, Rob Snelders Op 19-10-12 07:48, Joel Madero schreef: On 10/18/2012 10:27 PM, Joel Madero wrote: Hi All, Someone else (can't remember who) talked to me earlier in IRC and told me that they had permissions to update BSA site but that make was failing and spitting out errors about the new wiki. I haven't confirmed this as I don't want to break anything but, can someone else with permissions see if they can reproduce? Including Florian on this one since he's in charge of the wiki update. Regards, Joel Now it's confirmed, here is the error: Current branch master is up to date. mkdir -p build curl --silent http://wiki.documentfoundation.org/BugReport_Details | tidy --numeric-entities yes -asxhtml 2>/dev/null | perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||' > build/BugReport_Details.xhtml xsltproc --encoding UTF-8 --novalid component_comments.xsl build/BugReport_Details.xhtml > build/component_comments.xhtml xsltproc --encoding UTF-8 --novalid subcomponents.xsl build/BugReport_Details.xhtml > build/subcomponents.xhtml xsltproc --encoding UTF-8 --novalid components.xsl build/BugReport_Details.xhtml > build/components.xhtml curl --silent 'https://bugs.freedesktop.org/query.cgi?product=LibreOffice&query_format=advanced' > build/query.xhtml perl query.pl < build/query.xhtml > build/versions.xhtml perl sanity.pl build/query.xhtml build/components.xhtml component Writer found in bugzilla but not in the wiki component Drawing found in bugzilla but not in the wiki component UI found in bugzilla but not in the wiki component Printing and PDF export found in bugzilla but not in the wiki component Installation found in bugzilla but not in the wiki component Formula Editor found in bugzilla but not in the wiki component Extensions found in bugzilla but not in the wiki component Database found in bugzilla but not in the wiki component Linguistic found in bugzilla but not in the wiki component Chart found in bugzilla but not in the wiki component Localization found in bugzilla but not in the wiki component Documentation found in bugzilla but not in the wiki component Presentation found in bugzilla but not in the wiki component WWW found in bugzilla but not in the wiki component BASIC found in bugzilla but not in the wiki component Spreadsheet found in bugzilla but not in the wiki component Libreoffice found in bugzilla but not in the wiki wiki URL http://wiki.documentfoundation.org/BugReport_Details components extracted with components.xsl from the wiki are in build/components.xhtml bugzilla URL https://bugassistant.libreoffice.org/enter_bug.cgi?product=LibreOffice bugzilla information retrieved from build/query.xhtml make: *** [extract] Error 17 Regards, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: BSA + New Wiki = No Good
Hi All, I resend this message so Florian will also receive it. I did say that yesterday on the IRC. Since a little while I have been working a bit on the BSA. I seems that with the change of the wiki that the HTML-output of the BugReport_Details has been changed. After the conference I want to look at it. I can run a diff on the old and the new output and see what has changed. For now the BSA on the website still works. But we can't update it at the moment so It will have to be fixed but it can be done a little later. -- Greetings, Rob Snelders Op 19-10-12 11:24, Florian Effenberger schreef: Hi, I am not subscribed to the FDO list, so please keep me in Cc for your replies. Joel Madero wrote on 2012-10-19 07:48: Now it's confirmed, here is the error: I have no idea what the script does, so I probably cannot be of too much help here. :( I guess it's a parsing error. All previously installed extensions should be available again, but the page template changed a bit. Maybe that causes the error and the parser needs some adjustments? Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: bug/Makefile bug/stripnamespace.xsl
bug/Makefile |5 +++-- bug/stripnamespace.xsl | 13 + 2 files changed, 16 insertions(+), 2 deletions(-) New commits: commit 696a3bc25fb4cd69fc59923f022ba4f2d0117217 Author: Christian Lohmaier Date: Tue Oct 23 23:41:52 2012 +0200 Fixing the BSA with the new wiki diff --git a/bug/Makefile b/bug/Makefile index 0cc49a7..358d33c 100644 --- a/bug/Makefile +++ b/bug/Makefile @@ -18,7 +18,8 @@ all: extract compose extract: mkdir -p build - curl --silent http://wiki.documentfoundation.org/BugReport_Details | tidy --numeric-entities yes -asxhtml 2>/dev/null | perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||' > build/BugReport_Details.xhtml + curl --silent http://wiki.documentfoundation.org/BugReport_Details | tidy --numeric-entities yes -asxhtml 2>/dev/null > build/tidyout.xhtml || echo "ignoring tidy error" + xsltproc --encoding UTF-8 --novalid stripnamespace.xsl build/tidyout.xhtml > build/BugReport_Details.xhtml xsltproc --encoding UTF-8 --novalid component_comments.xsl build/BugReport_Details.xhtml > build/component_comments.xhtml xsltproc --encoding UTF-8 --novalid subcomponents.xsl build/BugReport_Details.xhtml > build/subcomponents.xhtml xsltproc --encoding UTF-8 --novalid components.xsl build/BugReport_Details.xhtml > build/components.xhtml @@ -33,5 +34,5 @@ check: perl sanity.pl TEST clean: - rm -f build/BugReport_Details.xhtml build/component_comments.xhtml build/subcomponents.xhtml build/components.xhtml build/query.xhtml build/versions.xhtml bug/bug.html + rm -f build/BugReport_Details.xhtml build/tidyout.xhtml build/component_comments.xhtml build/subcomponents.xhtml build/components.xhtml build/query.xhtml build/versions.xhtml bug/bug.html rmdir build diff --git a/bug/stripnamespace.xsl b/bug/stripnamespace.xsl new file mode 100644 index 000..73ee6fc --- /dev/null +++ b/bug/stripnamespace.xsl @@ -0,0 +1,13 @@ +http://www.w3.org/1999/XSL/Transform";> + + + + + + + + + + + + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: BSA + New Wiki = No Good
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Many thanks to Christian. I pushed his patch. I have also updated the BSA on the website. - -- Greetings, Rob Snelders Op 19-10-12 15:22, Christian Lohmaier schreef: > Hi *, > > On Fri, Oct 19, 2012 at 12:25 PM, Christian Lohmaier > wrote: >> [...] The additional html tags in the wiki-output on the >> tag makes the removal of the xmlns tag that is added by tidy >> fail. >> >> i.e. perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||' does >> nothing, since it is not > xmlns="http://www.w3.org/1999/xhtml"; ..> but >> >> "http://www.w3.org/1999/xhtml";> >> >> so remove the xmlns declaration and just run the xslt commands >> manually or fix the regular expression or something like that. > > Or better - instead of trying to search and replace, also use xslt > to process the xml: > > stripnamespace.xsl: > > xmlns:xsl="http://www.w3.org/1999/XSL/Transform";> indent="yes" encoding="UTF-8" method="xml" > omit-xml-declaration="yes"/> > > > > > > > > > > --- a/bug/Makefile +++ b/bug/Makefile @@ -18,7 +18,8 @@ all: > extract compose > > extract: mkdir -p build - curl --silent > http://wiki.documentfoundation.org/BugReport_Details | tidy > --numeric-entities yes -asxhtml 2>/dev/null | perl -pe > 's|xmlns="http://www.w3.org/1999/xhtml";||' > > build/BugReport_Details.xhtml + curl --silent > http://wiki.documentfoundation.org/BugReport_Details | tidy > --numeric-entities yes -asxhtml 2>/dev/null > build/tidyout.xhtml > || echo "ignoring tidy error" + xsltproc --encoding UTF-8 > --novalid stripnamespace.xsl build/tidyout.xhtml > > build/BugReport_Details.xhtml xsltproc --encoding UTF-8 --novalid > component_comments.xsl build/BugReport_Details.xhtml > > build/component_comments.xhtml xsltproc --encoding UTF-8 --novalid > subcomponents.xsl build/BugReport_Details.xhtml > > build/subcomponents.xhtml xsltproc --encoding UTF-8 --novalid > components.xsl build/BugReport_Details.xhtml > > build/components.xhtml > > > ciao Christian ___ > LibreOffice mailing list LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQhxCrAAoJEGs78UIq7mKyMzYH/A7bML7aLdBVpD+aAaqD2+oS KqfVcIYOGGoi/aonurGjmaHLi7kLmqiMCvY4DwvQR5psJ++xHokA5VfD7KZpQmGr QPDpAquOSkVUFpnBGuJaNhPFjMMKKO6i8UT0smsPkadYDKGmZNtUrSYLO1J9fFqK tvarh6SUzzBxEKnpT7QeSy8kQLudW8Bk2+hrIkT2/ecR9M0SplzI5FPFtFTdblVg OKw+88TfrNhaFGeClZDRjEW6lgD1ujK2CN3pem/plXHz8yDMf7vlqIAzlFuV6m4h fdlNEg2KSefU32q++f4CVol4JqwRLAw3whbFYzOjCCADfOBmvaFRcBzFZdIFTYw= =6net -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
export HTML
Hi all, The export-option in the options-dialog -> Load/Save -> HTML-compatibility states that you can save for LibreOffice Writer, Internet Explorer and Netscape Navigator. Looking at the code that states Netscape 4-compatibility. But has this still any value? As the browsers are for basic HTML compatible for some years. I think that the Netscape output also works in Internet Explorer. If it still has value then the name netscape navigator should change as less and less people know what Netscape is. This bug triggerd the question: https://bugs.freedesktop.org/show_bug.cgi?id=56726 -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[fdo#40325] PRINTING: order of page not respected with Handout
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi All, This bug describes that the printing of handouts doesn't respect the "order of page"-option. It seems some parts of the working of this already functions but the default-option still is weird. It defaults to 6 slides and doesn't respect the "order of page"-option it always prints vertically first. I think it would be better to remove te default-option for the slides and default to 6 slides with the "left to right then down" selected for "order of page". Anybody any thoughts on that? - -- Greetings, Rob Snelders -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQmpqAAAoJEGs78UIq7mKy/1oIAKe52qhtRa9VBKvB+UZcIbyk rRT8uRhCqUvH8rdHw17hGl91a5jPVS1G6sIDSsiP0Ptiv0wOeye7SG+tXLsSKeK+ 4jwapIuYxefiItmicX+b8dxF89bWyTzGXNnYzILDhxskODq8i/jZ5p4sqZnxTJXB y2WVvm0OXifWJNiFcOP0L8saZ6zW7/fI/fvbDmGMNkGhu8gSOXCdPWPanP9qd6zz 2OoITSxwGJOIPNdeoKNLvEoAZ43UwtWp7fti3+rnVeFPTMIo0p1TbSSz/MDPsp3C rveYsh1JUPmi7bRxjBP75gz3di6zqvpB7QYs5UTuzLFbpH04BbrtColPPlYNbaM= =BKNx -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [fdo#40325] PRINTING: order of page not respected with Handout
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi All, I forgot to tell that I was not subscribed to the design-list, so I reply on this mail after read the replies online. I think this default-option is very confusing. It seems to me really a bug that in this option doesn't respect the order I set. But this brings only a old discussion back. I want to propose a small change that should make it more clear. Can we disable the "order of page"-option when default is selected? Another option to add is to set the correct "order of page" that the default-option is following in that disabled state. - -- Greetings, Rob Snelders Op 07-11-12 18:29, Rob Snelders schreef: > Hi All, > > This bug describes that the printing of handouts doesn't respect > the "order of page"-option. > > It seems some parts of the working of this already functions but > the default-option still is weird. It defaults to 6 slides and > doesn't respect the "order of page"-option it always prints > vertically first. > > I think it would be better to remove te default-option for the > slides and default to 6 slides with the "left to right then down" > selected for "order of page". > > Anybody any thoughts on that? > > -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQnWJzAAoJEGs78UIq7mKyM0QH/R7G0AuCR62pHCO2yAJelYu3 aCVt/q3xGs7iLq7TQo0ybBaR6AjAdn0JwJXy4lbCZdvasXQh1nef5IDrKd2f1RHQ ypZq2NwpZCxhLGCut/s6X6xxZ1wf2yn931y/KLVS/fkyqSEfvClZcuXXEp61vdKz 8G7+41bid/b22mioCITetULUiqii0Cx4GE1mzK03lxO7b5Y3LFqKkYEUzidKoZB+ UjNb67Of6tNBPR4TIoc3RmkBfkddCJD324iDfzhawkmMg/VFfybktLNcKjB3dqgx M1R0qmpJUFQ37w9EE3qWDOvkJdzx0kBOkANKlxYpTDMBjWEMtsPwoVid6d6YVhk= =GR+5 -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 7 commits - bug/bug bug/bug.xhtml
bug/bug.xhtml |1 +
bug/bug/bug.js | 17 +
bug/bug/test.js |7 +++
3 files changed, 25 insertions(+)
New commits:
commit abaa1d52d080490ec04e881c1d3636ac2fa440f8
Author: Rob Snelders
Date: Mon Oct 1 23:02:08 2012 +0200
new bugzilla demands a token. That works now.
diff --git a/bug/bug.xhtml b/bug/bug.xhtml
index f4c4e05..fe365be 100644
--- a/bug/bug.xhtml
+++ b/bug/bug.xhtml
@@ -181,6 +181,7 @@ Platform (if different from the browser):
+
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index a0be19d..9a1ab1e 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -94,6 +94,7 @@
},
url: '',
+ token: '',
state_signin_error_regexps: [/CLASS="THROW_ERROR">([^<]*)/i],
state_signin_success_regexp: /LOG&NBSP;OUT<\/A>([^<]*)/i,
@@ -232,8 +233,23 @@
state_submit_element: 'html',
state_submit: function() {
+ $.bug.logged_in().done(function(status) {
+if(status) {
+$.bug.submit_bug();
+} else {
+ $.bug.error_set("You're not logged in. Please login first");
+$.bug.state_signin();
+}
+ });
+ },
+
+ submit_bug: function() {
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
+ $.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
+ $.bug.token = data.match(//)[1];
+});
+
var form = $('.submission_form form');
$.bug.error_clear();
form.attr('action', $.bug.url + '/post_bug.cgi');
@@ -248,6 +264,7 @@
var short_desc = $('.state_subcomponent
.active_subcomponent .chosen').attr('data') + ': ' + $('.state_description
.short').val();
var comment = $('.state_description .long').val();
$("body").css("cursor", "progress");
+$('input[name="token"]', form).val($.bug.token);
$('input[name="component"]', form).val(component);
$('input[name="version"]', form).val(version);
$('input[name="short_desc"]', form).val(short_desc);
diff --git a/bug/bug/test.js b/bug/bug/test.js
index defb842..1a36df2 100644
--- a/bug/bug/test.js
+++ b/bug/bug/test.js
@@ -241,6 +241,12 @@ test("state_submit", function() {
equal(element.css('display'), 'none');
ok(!element.hasClass('initialized'), 'is not initialized');
$.bug.state_submit();
+
+/*$.bug.ajax = function(type, url) {
+return $.Deferred().resolve('logged in ok');
+};
+
+$.bug.state_submit();
equal(element.css('display'), 'block');
ok(element.hasClass('initialized'), 'is initialized');
$.bug.state_component();
@@ -302,6 +308,7 @@ test("state_submit", function() {
equal($('.error').text(), error, 'error is set');
$.bug.state_success = state_success;
+$.bug.ajax = $.ajax;*/
});
test("state_success", function() {
commit 633869eb45ed46a1b67c1b559499b55ac1b64d53
Merge: 1c1aa6c... 213529e...
Author: Rob Snelders
Date: Fri Aug 17 17:29:56 2012 +0200
Merge branch 'master' of git://anongit.freedesktop.org/libreoffice/website
commit 1c1aa6cff807d54b1ea42997ac74428289334503
Author: Rob Snelders
Date: Fri Aug 17 00:07:06 2012 +0200
Reset the error-message when submitting the bug
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 0565d84..a0be19d 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -235,6 +235,7 @@
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
var form = $('.submission_form form');
+$.bug.error_clear();
form.attr('action', $.bug.url + '/post_bug.cgi');
form.submit(function() {
if($(element).hasClass('inprogress')) {
commit 70a0477efcaf401642db916cb76acccb00bb6246
Author: Rob Snelders
Date: Fri Aug 17 00:03:50 2012 +0200
Hides the username that is printed for testing
diff --git a/bug/bug/bug.css b/bug/bug/bug.css
index a932f2a..f81aa9b 100644
--- a/bug/bug/bug.css
+++ b/bug/bug/bug.css
@@ -610,3 +610,7 @@ body {
background: url('images/select-r
[Libreoffice-commits] .: bug/bug
bug/bug/bug.js | 15 ++-
bug/bug/test.js |8 +---
2 files changed, 3 insertions(+), 20 deletions(-)
New commits:
commit c247d268474d62fdbab76cb671203c4385d9a5ea
Author: Rob Snelders
Date: Wed Oct 3 23:58:22 2012 +0200
- Revert wrong changes of last commit
- correct indenting
diff --git a/bug/bug/bug.js b/bug/bug/bug.js
index 9a1ab1e..c6f5966 100644
--- a/bug/bug/bug.js
+++ b/bug/bug/bug.js
@@ -233,21 +233,10 @@
state_submit_element: 'html',
state_submit: function() {
- $.bug.logged_in().done(function(status) {
-if(status) {
-$.bug.submit_bug();
-} else {
- $.bug.error_set("You're not logged in. Please login first");
-$.bug.state_signin();
-}
- });
- },
-
- submit_bug: function() {
var element = $('.state_submit');
if(!element.hasClass('initialized')) {
- $.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
- $.bug.token = data.match(//)[1];
+$.bug.ajax('GET', $.bug.url +
'/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED').pipe(function(data){
+$.bug.token = data.match(//)[1];
});
var form = $('.submission_form form');
diff --git a/bug/bug/test.js b/bug/bug/test.js
index 1a36df2..f6a3e24 100644
--- a/bug/bug/test.js
+++ b/bug/bug/test.js
@@ -241,12 +241,6 @@ test("state_submit", function() {
equal(element.css('display'), 'none');
ok(!element.hasClass('initialized'), 'is not initialized');
$.bug.state_submit();
-
-/*$.bug.ajax = function(type, url) {
-return $.Deferred().resolve('logged in ok');
-};
-
-$.bug.state_submit();
equal(element.css('display'), 'block');
ok(element.hasClass('initialized'), 'is initialized');
$.bug.state_component();
@@ -308,7 +302,7 @@ test("state_submit", function() {
equal($('.error').text(), error, 'error is set');
$.bug.state_success = state_success;
-$.bug.ajax = $.ajax;*/
+$.bug.ajax = $.ajax;
});
test("state_success", function() {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sd/source sd/uiconfig
sd/source/ui/view/drvwshrg.cxx |1 +
sd/uiconfig/simpress/menubar/menubar.xml |1 +
2 files changed, 2 insertions(+)
New commits:
commit cb4225144f1fff44f9bb972fe06f51524da11b8b
Author: Rob Snelders
Date: Thu Dec 5 23:56:52 2013 +0100
Partly revert "Resolves: #ii122335# Disabling the old task pane"
This partly reverts commit 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872.
SideBar is experimental, Impress still needs the TaskPane slot, otherwise
once
disabled / clicked away the user won't get the TaskPane back.
Change-Id: I65b9e4a52ef2f3f1e7240fc01b828d2ff5d1589c
Reviewed-on: https://gerrit.libreoffice.org/6943
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sd/source/ui/view/drvwshrg.cxx b/sd/source/ui/view/drvwshrg.cxx
index bb20370..c71959c 100644
--- a/sd/source/ui/view/drvwshrg.cxx
+++ b/sd/source/ui/view/drvwshrg.cxx
@@ -94,6 +94,7 @@ SFX_IMPL_INTERFACE(GraphicViewShell, SfxShell,
SdResId(STR_DRAWVIEWSHELL)) //SOH
{
SFX_POPUPMENU_REGISTRATION( SdResId(RID_DRAW_TEXTOBJ_INSIDE_POPUP) );
SFX_CHILDWINDOW_CONTEXT_REGISTRATION( SID_NAVIGATOR );
+SFX_CHILDWINDOW_REGISTRATION( SID_TASKPANE );
SFX_CHILDWINDOW_REGISTRATION( SfxTemplateDialogWrapper::GetChildWindowId()
);
SFX_CHILDWINDOW_REGISTRATION( SvxFontWorkChildWindow::GetChildWindowId() );
SFX_CHILDWINDOW_REGISTRATION( SvxColorChildWindow::GetChildWindowId() );
diff --git a/sd/uiconfig/simpress/menubar/menubar.xml
b/sd/uiconfig/simpress/menubar/menubar.xml
index 9ad2019..9a5b874 100644
--- a/sd/uiconfig/simpress/menubar/menubar.xml
+++ b/sd/uiconfig/simpress/menubar/menubar.xml
@@ -113,6 +113,7 @@
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1-4' - sd/source sd/uiconfig
sd/source/ui/view/drvwshrg.cxx |1 +
sd/uiconfig/simpress/menubar/menubar.xml |1 +
2 files changed, 2 insertions(+)
New commits:
commit 7a92317c40a5aa5dcd78bc52d8c426b446626b0b
Author: Rob Snelders
Date: Thu Dec 5 23:56:52 2013 +0100
Partly revert "Resolves: #ii122335# Disabling the old task pane"
This partly reverts commit 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872.
SideBar is experimental, Impress still needs the TaskPane slot, otherwise
once
disabled / clicked away the user won't get the TaskPane back.
Change-Id: I65b9e4a52ef2f3f1e7240fc01b828d2ff5d1589c
Reviewed-on: https://gerrit.libreoffice.org/6943
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
(cherry picked from commit cb4225144f1fff44f9bb972fe06f51524da11b8b)
Reviewed-on: https://gerrit.libreoffice.org/6952
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/ui/view/drvwshrg.cxx b/sd/source/ui/view/drvwshrg.cxx
index bb20370..c71959c 100644
--- a/sd/source/ui/view/drvwshrg.cxx
+++ b/sd/source/ui/view/drvwshrg.cxx
@@ -94,6 +94,7 @@ SFX_IMPL_INTERFACE(GraphicViewShell, SfxShell,
SdResId(STR_DRAWVIEWSHELL)) //SOH
{
SFX_POPUPMENU_REGISTRATION( SdResId(RID_DRAW_TEXTOBJ_INSIDE_POPUP) );
SFX_CHILDWINDOW_CONTEXT_REGISTRATION( SID_NAVIGATOR );
+SFX_CHILDWINDOW_REGISTRATION( SID_TASKPANE );
SFX_CHILDWINDOW_REGISTRATION( SfxTemplateDialogWrapper::GetChildWindowId()
);
SFX_CHILDWINDOW_REGISTRATION( SvxFontWorkChildWindow::GetChildWindowId() );
SFX_CHILDWINDOW_REGISTRATION( SvxColorChildWindow::GetChildWindowId() );
diff --git a/sd/uiconfig/simpress/menubar/menubar.xml
b/sd/uiconfig/simpress/menubar/menubar.xml
index 9ad2019..9a5b874 100644
--- a/sd/uiconfig/simpress/menubar/menubar.xml
+++ b/sd/uiconfig/simpress/menubar/menubar.xml
@@ -113,6 +113,7 @@
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Help
Hi Markus, We have spoken about exporting the help-system from the help-wiki. We will need a html/javascript framework for that. I don't think a basic framework will need more time then a month or 2 for me. But I think we will also need to look at how we export the pages from the wiki because how the pages are exported is important. Can you tell me what plugin for mediawiki you had in mind to do the export? Is there a test-wiki to try it on to see what it does, maybe we'll need to change the plugin to fit our needs. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: officecfg/README
officecfg/README |2 ++ 1 file changed, 2 insertions(+) New commits: commit fcd3d85ea4bf0d82190551df3d5c88d5230b4567 Author: Rob Snelders Date: Mon Feb 3 12:34:03 2014 +0100 Add a line what you need to build to see your changes in officecfg Change-Id: I38f961e153246b29d0959d0b4491b9f7eecbaf8f Reviewed-on: https://gerrit.libreoffice.org/7803 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/officecfg/README b/officecfg/README index 3a39d28..add1276 100644 --- a/officecfg/README +++ b/officecfg/README @@ -1,4 +1,6 @@ The schema and default settings for the OpenOffice.org configuration database. +If you change change a file in this module, then a make postprocess is needed after make officecfg. + See also: [[configmgr]] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
