Re: LibreOffice: blanket license statement ...
Hi Michael, All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license Robert DARGAUD (Bob) -- Sorry, I'm not very active on the lists for several months. Good idea Michael for sending me the email;-) Best regards Le 10/05/12 13:14, Michael Meeks a écrit : Hi Robert, Missing you :-) On Tue, 2011-06-14 at 23:48 +0200, Robert Dargaud wrote: The last patch I've submitted is this one : see message below (Mon, 11 Apr 2011 01:09:00 +0200) ... This version is functional and this patch is under LGPLv3+/MPL dual license I'm just working through the MPL/LGPLv3+ re-licensing audit at the moment (so we can include code from Apache OpenOffice :-) What would really help reduce the work would be if we could have a blanket statement from you for all past/future contributions we can link into: http://wiki.documentfoundation.org/Development/Developers Something like: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license sent to the libreoffice@lists.freedesktop.org would be wonderful (no subscription required). Your great feature work in calc, and elsewhere is still much appreciated. Thanks ! Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Status of unlimited conditional formatting
Hi Christoph and All, After you've suggested to me this new idea. Last month I've started to work on a new version with new dialog based on CustomProperties classes and it seems a good base to create a generic control for this sort of UI list. Work is in progress ... But the patch I've submitted on Mon, 11 Apr 2011 01:09:00 +0200 based on standard dialog box is fully operational and can be a first step with not a lot of change for the user. Regards Bob Le 14/06/11 19:41, Christoph Noack a écrit : Hi Kohei, sorry, I don't know the current status - the last mail I'm aware about is dated 20.04.2011 01:18:33 ... Rob mentioned that - concerning the new stuff - he can't work on it these days but I will try to propose something in the begining of may. Agree, would be cool if there is a chance to continue this great work! Cheers, Christoph Am Montag, den 13.06.2011, 19:03 -0400 schrieb Kohei Yoshida: Hi there, I'm just checking to see if there is any activities on Robert's nice unlimited conditional formatting rework. I had thought that this already went into master, but then I just checked realized that the dialog looks the same as before (i.e. only supports up to 3 conditions). Has this been stalled, or did this go in but somehow accidentally got reverted, or ... ? I'd love to get this piece included I'd hate to see this work go unhandled. Thanks, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] 3.4RC1 Calc datapilot : crash with refresh and filter
Hi, This short message to give a file with datapilot who crash LibO 3.4RC1. ooo.bobiciel.com/tests_documents/testLibO_34rc1_proto_time_line_pour_defauts.ods On the second sheet : Clic on A2 == crash Or right clic on A2 / refresh == crash Same bug on WinXP SP3 and MacOX 10.6 No problem with OOo 3.4RC and NeoO If necessary, I'll create the issue later this week end Best regards Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix fdo#36399 - ScrollBar display bug on dialog boxes
After a long reflection, I confirm that this gigantesque contribution is under LGPLv3+/MPL Bob Le 20/04/11 16:20, Michael Meeks a écrit : On Wed, 2011-04-20 at 00:44 +0200, Robert Dargaud wrote: And I've found a missing returnVal = sal_True; in salnativewidgets-gtk.cxx Nice work - even though it's restoring code - it'd be great if you could confirm that your contribution(s) are under LGPLv3+/MPL :-) Thanks again, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields
Hi All, In cursor.cxx I found 2 lines accidentally deleted by this patch it seems : vcl119: #i80730# fix cursor paint behavior and timer I've tried to find an explication of this deleted ligne, but without Timer.Stop() I don't understand how it can work correctly. I'm not sure of that. It's preferable than an expert have a look to my patch before pushed it. Best regard Bob From 2150718d3a241e81b00478dec84122d773f0211b Mon Sep 17 00:00:00 2001 From: Robert Dargaud l...@bobiciel.com Date: Wed, 20 Apr 2011 23:15:16 +0200 Subject: [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields --- vcl/source/window/cursor.cxx |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx index f3c75dd..9aaccff 100644 --- a/vcl/source/window/cursor.cxx +++ b/vcl/source/window/cursor.cxx @@ -225,6 +225,7 @@ bool Cursor::ImplHide() bWasCurVisible = mpData-mbCurVisible; if ( mpData-mbCurVisible ) ImplRestore(); +mpData-maTimer.Stop(); } return bWasCurVisible; } -- 1.7.1 From f6753885e887afdd9e219b5a1fc63d079164ce01 Mon Sep 17 00:00:00 2001 From: Robert Dargaud l...@bobiciel.com Date: Wed, 20 Apr 2011 23:32:00 +0200 Subject: [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields --- vcl/source/window/cursor.cxx |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx index 9aaccff..7e485ba 100644 --- a/vcl/source/window/cursor.cxx +++ b/vcl/source/window/cursor.cxx @@ -226,6 +226,7 @@ bool Cursor::ImplHide() if ( mpData-mbCurVisible ) ImplRestore(); mpData-maTimer.Stop(); +mpData-mpWindow = NULL; } return bWasCurVisible; } -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes
Hi Michael, Le 20/04/11 15:44, Michael Meeks a écrit : [...] It's very strange than this line was deleted ! I try to find the origine of this delete with qgit and gitk. But I can't find it ! It seems you found it, and it was an error; nice work. Yes, I found the patch, but not the origin of deletion of this line in the history ! What tool can be used to find easily history for each line ? I've pushed the patch to master, and will merge it to libreoffice-3-4 - what's next ? :-) This one ;-) https://bugs.freedesktop.org/show_bug.cgi?id=36404 Best regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] fix fdo#36399 - ScrollBar display bug on dialog boxes
Hi Michael All,
Le 11/04/11 11:41, Michael Meeks a écrit :
[...]
on 3.4 build, I've a strange display bug on dialog boxes ScrollBar.
But finding bugs is good - particularly if we have patches to discuss -
do you think you could dig into these ?
Last week, my answer was no. But this evening, after many printf, it's
yes
I've a patch who fixe this bug ;-)
My printf() traces in scrbar.cxx, show me that
getNativeControlRegion return sal_false for CTRL_SCROLLBAR
And I've found a missing returnVal = sal_True; in
salnativewidgets-gtk.cxx
It's very strange than this line was deleted ! I try to find the origine
of this delete with qgit and gitk. But I can't find it !
Best regard
Bob
From 4ca312d7c13a6f3f57ab2229201cad56b4c2d3f4 Mon Sep 17 00:00:00 2001
From: Robert Dargaud l...@bobiciel.com
Date: Wed, 20 Apr 2011 00:14:25 +0200
Subject: [PATCH] fix fdo#36399 - ScrollBar display bug on dialog boxes
---
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index e1d12ce..e073794 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -987,7 +987,7 @@ sal_Bool GtkSalGraphics::getNativeControlRegion(
ControlType nType,
rNativeContentRegion.Right() = rNativeContentRegion.Left() + 1;
if (!rNativeContentRegion.GetHeight())
rNativeContentRegion.Bottom() = rNativeContentRegion.Top() + 1;
-
+returnVal = sal_True;
}
if( (nType == CTRL_MENUBAR) (nPart == PART_ENTIRE_CONTROL) )
{
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules
Hi Christoph, Le 15/04/11 21:59, Christoph Noack a écrit : Hi Bob, [...] [...] I'm currently thinking about whether something like the Custom Document Properties [1] might be a next step - the UI design pattern might fit here as well. Mmh ... Oh ! Yes !!! It seem perfectly adapted, I have a look to code and start to hack tomorow Amazing! Just tell if you have any questions related to the UI behavior or user's needs ... I think (but I'm not a developer) that the main issue will be to build a table with entries similar to the current ones (having several controls stacked in a container that represents a list item). A simple table like the one for the custom document properties might not work ... to many information / controls. Or at least I don't know if there is a solution that will work well nevertheless. Last week I have a look to CustomProperties classes and it seems a good base to create a generic control for this sort of UI list. I can't work on it these days but I will try to propose something in the begining of may. At least, we may get rid of the Checkbox, and place the New Style ... below the table (because it is a rather generic control). If we add an Apply button, the checkbox will be usable to momentaly desactivate a rule. And (dreaming) one day, we'll be able to provide something like LivePreview (or Apply behavior) for such dialogs :-) Yes, but LivePreview should be implemented for all dialogues who change formats and styles. I think it will be a big work. In first time, I've added a preview for each style used by rules. It's allready a progress ;-) And I will debug refresh ... who is not really perfect ! like you can see on screen shot below. http://archives.bobiciel.com/libo/custom_properties/custom_document_properties_LibO_ubuntu.jpg http://archives.bobiciel.com/libo/custom_properties/custom_document_properties_OOo_Mac.jpg Ouch! Doesn't look that nice ... that's true. It's fixed : https://bugs.freedesktop.org/show_bug.cgi?id=36069 Best regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Libo 3.4 - writer insert fields other : 2 bugs
Hi Kendy, Le 14/04/11 07:30, Jan Holesovsky a écrit : Hi Robert, On 2011-04-11 at 01:49 +0200, Robert Dargaud wrote: 3.4 on Ubuntu 10.4 Win7 Writer insert fieds other first bug : Condition = sat_True instead of True Monday, I've started to have a look on this bug. The result of my investigation seems show that this user interface problem appears not only in this dialog box but also in svl module. I base this constat on this search result : http://opengrok.libreoffice.org/search?q=RTL_CONSTASCII_STRINGPARAM%5C%28%5C+%5C%22sal_True%5C%22%5C+%5C%29+OR+RTL_CONSTASCII_STRINGPARAM%5C%28%5C+%5C%22sal_False%5C%22%5C+%5C%29project=artworkproject=baseproject=bootstrapproject=calcproject=componentsproject=extensionsproject=extrasproject=filtersproject=impressproject=libs-cor eproject=libs-externproject=libs-extern-sysproject=libs-guiproject=postprocessproject=sdkproject=ureproject=writerdefs=refs=path=hist= sw and svl are impacted by this problem. I've not investigate more. Maybe that my research is incomplete ... Oh, thanks for noticing! I think http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4id=6ccd6981635845e9fd9ba2aef2a3ce3e46171f9b Should fix that :-) I am just about to check for more of these. Yes, I think also that your patch fix this bug. But, I've notice that 'TRUE' 'FALSE' are not in tune with help document. In help, TRUE and FALSE are localized : (see below an extract of french help screen) La méthode la plus simple pour définir une condition consiste à saisir l'expression logique directement dans une zone *Condition* à l'aide des valeurs suivantes : VRAI La condition est toujours remplie. Il est également possible d'entrer une valeur quelconque différente de zéro comme texte conditionnel. FAUX La condition n'est pas remplie. À la place, vous pouvez aussi spécifier la valeur 0. I dont know if it is easy to use localized constant strings to display 'VRAI' 'FAUX' (for ex in french) in user interface. second bug : 1) Clic on Condition 2) Clic on Record number result : 2 text cursors in the same time ! (see picture below) I did not look at this one. You mean that you have not see this problem ? It's strange. On my computer I've this bug on all dialog boxes having more than one text field. The same bug on 2 plateforms : - my buid from master (Ubuntu 10.10) - nightly builds http://dev-builds.libreoffice.org/daily/Windows_Relese_Configuration/libreoffice-3-4/current/libreoffice-3-4~20110413_LibO_3.4.0beta1_Win_x86_install_multi.exe on the same computer (core i5) I can't try on Mac because 3.4 installation fail I wait somebody confirm before register this bug on bugs.freedesktop.org Regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Nightly Build on Mac from 20110414 - application launch failure and crash rep
Hi Alex All, I've the same problem with 2 times with different nightly builds (last report in attachment) Regard Bob Le 14/04/11 09:54, Alexander Thurgood a écrit : Hi all, For those who may be interested, I am enclosing an Apple crash rep of the attempted launch of the nightly Mac build from master dated 20110414. Alex __ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Process: soffice [2381] Path:/Applications/LibreOffice.app/Contents/MacOS/soffice Identifier: org.libreoffice.script Version: 3.4.0 (???) Code Type: X86 (Native) Parent Process: launchd [255] Date/Time: 2011-04-14 09:42:06.145 +0200 OS Version: Mac OS X 10.6.6 (10J567) Report Version: 6 Interval Since Last Report: 115918 sec Crashes Since Last Report: 5 Per-App Interval Since Last Report: 38 sec Per-App Crashes Since Last Report: 3 Anonymous UUID: 962B3BFC-A0D2-4DAA-9196-E0B4A636E7E7 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0005 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libvclmxi.dylib 0x017d6606 ImplFontCharMap::DeReference() const + 54 1 libvclmxi.dylib 0x017d6b44 FontCharMap::~FontCharMap() + 20 2 libvclmxi.dylib 0x017f58de OutputDevice::HasGlyphs(Font const, String const, unsigned short, unsigned short) const + 190 3 libvclmxi.dylib 0x01987f89 Window::IsMouseCaptured() const + 729 4 libvclmxi.dylib 0x01999317 Window::doLazyDelete() + 4023 5 libvclmxi.dylib 0x01766de7 Application::MergeSystemSettings(AllSettings) + 71 6 libsvtmxi.dylib 0x00a564ac SvtTabAppearanceCfg::SetApplicationDefaults(Application*) + 412 7 libsofficeapp.dylib 0x0006aff6 0x59000 + 73718 8 libvclmxi.dylib 0x0176eb08 DeInitVCL() + 3624 9 libvclmxi.dylib 0x01a7225b component_getFactory + 209515 10 libvclmxi.dylib 0x01a7768b SalGetDesktopEnvironment() + 20891 11 com.apple.AppKit0x9702d2a7 -[NSApplication run] + 917 12 com.apple.AppKit0x970252d9 NSApplicationMain + 574 13 libvclmxi.dylib 0x01a72fe7 SalGetDesktopEnvironment() + 2807 14 libvclmxi.dylib 0x0176ebb1 SVMain() + 17 15 libsofficeapp.dylib 0x00097d65 soffice_main + 245 16 org.libreoffice.script 0x1ebe main + 30 17 org.libreoffice.script 0x1822 start + 258 18 org.libreoffice.script 0x1749 start + 41 Thread 1: 0 libSystem.B.dylib 0x9000415a semaphore_timedwait_signal_trap + 10 1 libSystem.B.dylib 0x90031ce5 _pthread_cond_wait + 1066 2 libSystem.B.dylib 0x9007a67c pthread_cond_timedwait + 47 3 libuno_sal.dylib.3 0x000367c8 rtl_cache_create + 696 4 libSystem.B.dylib 0x9003185d _pthread_start + 345 5 libSystem.B.dylib 0x900316e2 thread_start + 34 Thread 2: Dispatch queue: com.apple.libdispatch-manager 0 libSystem.B.dylib 0x9002a982 kevent + 10 1 libSystem.B.dylib 0x9002b09c _dispatch_mgr_invoke + 215 2 libSystem.B.dylib 0x9002a559 _dispatch_queue_invoke + 163 3 libSystem.B.dylib 0x9002a2fe _dispatch_worker_thread2 + 240 4 libSystem.B.dylib 0x90029d81 _pthread_wqthread + 390 5 libSystem.B.dylib 0x90029bc6 start_wqthread + 30 Thread 3: 0 libSystem.B.dylib 0x90029a12 __workq_kernreturn + 10 1 libSystem.B.dylib 0x90029fa8 _pthread_wqthread + 941 2 libSystem.B.dylib 0x90029bc6 start_wqthread + 30 Thread 4: 0 libSystem.B.dylib 0x900cb422 accept$NOCANCEL$UNIX2003 + 10 1 libSystem.B.dylib 0x900ca28a accept + 32 2 libuno_sal.dylib.3 0x0001275a osl_acceptPipe + 58 3 libsofficeapp.dylib 0x00093afe 0x59000 + 240382 4 libsofficeapp.dylib 0x00096a72 0x59000 + 252530 5 libuno_sal.dylib.3 0xcbb9 osl_setThreadName + 569 6 libSystem.B.dylib 0x9003185d _pthread_start + 345 7 libSystem.B.dylib 0x900316e2 thread_start + 34 Thread 0 crashed with X86 Thread State (32-bit): eax: 0x0001 ebx: 0x01987e30 ecx: 0x0070 edx: 0x16c90f70 edi: 0x0033 esi: 0xb2f8 ebp: 0xb288 esp: 0xb288 ss: 0x001f efl: 0x00010202 eip: 0x017d6606 cs: 0x0017 ds: 0x001f es: 0x001f fs: 0x gs:
[Libreoffice] [PATCH] fix bug #36069 - Date properties in 'Custom Properties' do not scroll in UI
From 2de03b6a40f6bfe9413a30914fbc26a01afc0969 Mon Sep 17 00:00:00 2001
From: Robert Dargaud l...@bobiciel.com
Date: Tue, 12 Apr 2011 18:09:28 +0200
Subject: [PATCH] fix bug #36069 - Date properties in 'Custom Properties' do not
scroll in UI
---
sfx2/source/dialog/dinfdlg.cxx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index b0e1cab..7770ded 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -2230,8 +2230,8 @@ void CustomPropertiesWindow::DoScroll( sal_Int32 nNewPos )
if ( pLine-m_bIsRemoved )
continue;
-Window* pWindows[] = { pLine-m_aNameBox, pLine-m_aTypeBox,
pLine-m_aValueEdit, pLine-m_aDurationField,
-pLine-m_aYesNoButton,
pLine-m_aRemoveButton, NULL };
+Window* pWindows[] = { pLine-m_aNameBox, pLine-m_aTypeBox,
pLine-m_aValueEdit, pLine-m_aDateField, pLine-m_aTimeField,
+pLine-m_aDurationField,
pLine-m_aEditButton, pLine-m_aYesNoButton, pLine-m_aRemoveButton, NULL };
Window** pCurrent = pWindows;
while ( *pCurrent )
{
--
1.7.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules
I confirm : this patch is under LGPLv3+/MPL dual license Bob Le 11/04/11 10:57, Katarina Machalkova a écrit : On Monday, April 11, 2011 01:09:00 Robert Dargaud wrote: Hi Katarina Christoph ( All), I have improved code like you suggest. Lovely :) Before I push the improved code to git repo, can you please confirm that you're submitting this patch under LGPLv3+/MPL dual license? Thanks B. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules
Hello Christoph, Le 11/04/11 23:42, Christoph Noack a écrit : [...] Hehe ... then we should talk. To be honest, please tell me if you want to give this another try - or if you want to have a look at another topic as well. Yes, I want continue on this subject because it seems to me that it's a good way to learn LibO code. [...] I'm currently thinking about whether something like the Custom Document Properties [1] might be a next step - the UI design pattern might fit here as well. Mmh ... Oh ! Yes !!! It seem perfectly adapted, I have a look to code and start to hack tomorow And I will debug refresh ... who is not really perfect ! like you can see on screen shot below. http://archives.bobiciel.com/libo/custom_properties/custom_document_properties_LibO_ubuntu.jpg http://archives.bobiciel.com/libo/custom_properties/custom_document_properties_OOo_Mac.jpg Good exercise for me ;-) Thank Best regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Libo 3.4 SrollBar bug on dialog boxes
Hi, I don't know if it's the good list for this : on 3.4 build, I've a strange display bug on dialog boxes ScrollBar. Data Form Data Filter Standard filter Lag between fix and mobile box ! See picture below : Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Libo 3.4 - writer insert fields other : 2 bugs
Hi, 3.4 on Ubuntu 10.4 Win7 Writer insert fieds other first bug : Condition = "sat_True" instead of "True" second bug : 1) Clic on "Condition" 2) Clic on "Record number" result : 2 text cursors in the same time ! (see picture below) Regard Bob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] conditional formatting with an unlimited number of rules
Hi Katarina, Thank for your evaluation work and your detailed feedback. I insert my answers in your text. Le 06/04/11 17:56, Katarina Machalkova a écrit : Hey Bob ( all) ... Wow, I'm impressed by how good job you did, esp. considering the fact that this is your first submission :) I've applied the patch and tested it and (save some small issues), it works reasonably well. Thanks so much for that. I've not invent anything, it's just the result of code analyse and reorganize it. (many cut paste). Since this is quite a big feature patch, you're gonna receive rather long feedback from me, please don't be put off by that: 1) svx part of the patch is mostly OK ... except for the long list of new #includes. As the (French) comment says, not all of them are needed Oups ! I create a patch with translations of French comments ;-) More seriously : I have let things like that because I project to add other preview fonctionalities (rotate, borders, ...) and I don't know exactly which header-files are necessary. I will work to clean it. Is there a tool to make warning for useless hxx ? Now for sc/calc part: 2) I find Insert button (newly added to the dialog) a bit redundant. All it does is that it appends an empty condition rule at the end of the list (position N+1) -- the same thing can be achieved by enabling/selecting checkbox by Nth rule in the list -- the scrollbar then moves, so the users see they can add more rules. Additionally, its function is a bit buggy -- it tends to check some boxes that weren't previously checked and populates the affected entries with some default values (zeroes etc.) Therefore I'd suggest to remove it (+ related code as well) ... but we can discuss this further, it's a matter of taste. The insert fonctionality make _realy an insert_ ! But the visual result is not really evident for user ... A new entry is inserted on the first position in the dialog box (It's not correctly visible because I've directly selected aCbxCond1). I think then insert an unchecked entry, will better see new entry. What do you think about that ? (I hope my googled-english is readable ;-) 3) In ScConditionalFormatDlg::InsertEntry and ScConditionalFormatDlg::AddEntry -- instead of handling/copying array of pointers to conditional format entries in this way, it'd be cleaner to work with some C++ container holding the pointers to entries -- std::vector or boost::ptr_vector Ok, I'm going to buy a new C++ book, because I don't find std::vector references in my old one ! (Borland C++ dating the past siecle, with the price in francs ;-) I think I can work on this in a next time. 4) In ::Refresh and ::UpdateValueList (as well as ::CondNChecked) methods really, really lot of code is duplicated/copypasted around. That's on one hand consistent with the rest of the code in this class (yeah, unfortunately), but on the other hand not very nice. Ok, I can improve this. 5) Found a small buglet while testing (easy to fix) -- for newly appended condition entries, pre-selected style should be Default. With your patch, it is the one that comes first in alphabetically sorted list (e.g. if I create a custom style named Blue, it'll come before Default and all the newly created rules will have Blue style as default) Thank, I've stupidly not tested with other style names than Default and undefined# Sooo, what I'm gonna do now is that after fixing some very obvious quirks (reduce the list of includes in svx, fix some typos -- CondNChecked instead of CondNCheked, and three-liner fix for issue 5) I'll push the patch as it is, so that LibO users can use the feature already and give it a good deal of testing. Whaou ! super :-) I will send a new patch tomorrow As for the code cleanup -- this is mostly about issues 3 4 -- we can do it together later. Or, if you feel like it, you can try to improve the code yourself and send a patch to LibO list for review Yes, I try to improve the code and send a next patch. Again, thanks a lot for the patch and keep up good work. Should you have any questions, please don't hesitate to poke any of Calc hackers (me, kohei, muthusuba etc.) on IRC Ok, thank you. In first times, I will send questions on this dev list because I'm not regular IRC user. Best regard Bob B. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
