Licensing

2012-05-10 Thread Roland Baudin 

Hi,

all of my past & future contributions to LibreOffice may be 
licensed under the MPL/LGPLv3+ dual license.


Best regards,
Roland Baudin

--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Licensing

2012-05-10 Thread Roland Baudin 

Hi,

all of my past & future contributions to LibreOffice may be 
licensed under the MPL/LGPLv3+ dual license.


Best regards,
Roland Baudin

--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Additional fix for bug fdo#33781

2011-06-23 Thread Roland Baudin 

Le 21/06/2011 21:10, Petr Mladek a écrit :

Roland Baudin píše v Út 21. 06. 2011 v 09:26 +0200:

Hi Petr,

I've tested your patch with my test docs and for me it's OK.
I've just noticed a small issue when inserting a chart in Calc : when
switching out from edit mode, the top line of the graphic becomes blurred.
I attach a test file, so you can judge the issue.


I see this even without your patch, so it is most likely another issue.
Or do you see it different?

If it is not a regression caused by your or mine change, I am happy to
cherry-pick your fix with mine additions to the libreoffice-3-4 branch.

Best Regards,
Petr




I tested with and without the patch and the issue with the top line of 
the chart is there. So I can confirm this issue is not introduced by our 
patch.

Have a nice day,
RB


--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Additional fix for bug fdo#33781

2011-06-21 Thread Roland Baudin 

Hi Petr,

I've tested your patch with my test docs and for me it's OK.
I've just noticed a small issue when inserting a chart in Calc : when 
switching out from edit mode, the top line of the graphic becomes blurred.

I attach a test file, so you can judge the issue.
Have a nice day,
RB




Le 20/06/2011 17:35, Petr Mladek a écrit :

Hi Ronald,

Roland Baudin píše v Pá 17. 06. 2011 v 23:23 +0200:

Hi,

here is a small patch for sw that fixes another issue related to bug
33781 that I already fixed last month.

The problem is that a graphic object of type "Draw 8" is not
anti-aliased when anchored as char (see test file for example).

IMHO, this patch is safe and acts exactly the same as the previous fix
for bug 33781.


It works nice.

Well, just after your new lines there is another hack with aliasing for
http://openoffice.org/bugzilla/show_bug.cgi?id=99665 . It solves the
problem where the aliasing caused problems =>  we should be more careful
with setting aliasing to ANTIALIASING_ENABLE_B2DDRAW globally.

I prefer the more conservative approach from i#99665. It modifies the
current aliasing using "byte or" (operator |) and restores the original
aliasing at the end of the "if" block.

I see that the aliasing value is always modified by byte operators '&',
'|'. Try to search for ANTIALIASING_ENABLE_B2DDRAW at
http://opengrok.libreoffice.org/


So, what do you think about the attached patch?

It uses the conservative approach from i#99665 also for your two
changes. Also it combines your fix with the fix for i#99665 to avoid two
nFormerAntialiasingAtOutput variables.

I would prefer to sort this out before we cherry-pick it to
libreoffice-3-4 branch.


Best Regards,
Petr



--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc


ex.ods
Description: application/vnd.oasis.opendocument.spreadsheet
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Additional fix for bug fdo#33781

2011-06-17 Thread Roland Baudin 

Hi,

here is a small patch for sw that fixes another issue related to bug 
33781 that I already fixed last month.


The problem is that a graphic object of type "Draw 8" is not 
anti-aliased when anchored as char (see test file for example).


IMHO, this patch is safe and acts exactly the same as the previous fix 
for bug 33781.


Should be nice if it could be commited to the 3-4 branch and / or 3-4-1 
branch.


Have a nice day,
RB



--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
>From 978bebea673217065e157b94368a9c70097843ee Mon Sep 17 00:00:00 2001
From: Roland Baudin 
Date: Fri, 17 Jun 2011 19:39:55 +
Subject: [PATCH] Additional fix for bug fdo#33781

---
 sw/source/core/doc/notxtfrm.cxx |6 ++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/sw/source/core/doc/notxtfrm.cxx b/sw/source/core/doc/notxtfrm.cxx
index 520de0c..41023eb 100644
--- a/sw/source/core/doc/notxtfrm.cxx
+++ b/sw/source/core/doc/notxtfrm.cxx
@@ -947,6 +947,12 @@ void SwNoTxtFrm::PaintPicture( OutputDevice* pOut, const SwRect &rGrfArea ) cons
 }
 else if( pOLENd )
 {
+// Fix for bug fdo#33781
+if (pShell->Imp()->GetDrawView()->IsAntiAliasing())
+{
+pOut->SetAntialiasing( ANTIALIASING_ENABLE_B2DDRAW );
+}
+
 // #i99665#
 // Adjust AntiAliasing mode at output device for chart OLE
 const sal_uInt16 nFormerAntialiasingAtOutput( pOut->GetAntialiasing() );
-- 
1.7.5.4



test.odt
Description: application/vnd.oasis.opendocument.text
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PLEASE REVIEW] Fix for bug 33781 => No anti-aliasing in metafiles when anchor is "as char"

2011-05-15 Thread Roland Baudin 

OK, nice to see someone has answered!
The purpose of the patch is simply to check if antialiasing is enabled 
(in Libreoffice options) and then, when drawing the metafile, the object 
is antialiased. This was forgotten when the object is abchored as char.

RB


Le 15/05/2011 22:40, Jean-Baptiste Faure a écrit :

Le 14/05/2011 10:39, Roland Baudin a écrit :

Here is a *very small and easy patch* (three lines) that fixes a nasty
bug in writer : metafile drawings are not antialiased when anchored as
char. This is a great problem when dealing with Latex equations in text
(see attached file).

The patch has only three lines and is *inoffensive*!
Please review!!!
RB




Great ! I tried your patch on LibreOffice 3.4 beta-5 and it works well.
That said I am not able to check if it is safe. :-)

Best regards
JBF




--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PLEASE REVIEW] Fix for bug 33781 => No anti-aliasing in metafiles when anchor is "as char"

2011-05-14 Thread Roland Baudin 
Here is a *very small and easy patch* (three lines) that fixes a nasty 
bug in writer : metafile drawings are not antialiased when anchored as 
char. This is a great problem when dealing with Latex equations in text 
(see attached file).


The patch has only three lines and is *inoffensive*!
Please review!!!
RB


--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc

--- ./git.orig/libo/clone/writer/sw/source/core/doc/notxtfrm.cxx	2011-05-08 12:20:26.0 +0200
+++ ./git/libo/clone/writer/sw/source/core/doc/notxtfrm.cxx	2011-05-09 10:48:43.020482547 +0200
@@ -816,6 +816,13 @@
 
 if( pGrfNd )
 {
+		// Fix for bug #33781
+		if (pShell->Imp()->GetDrawView()->IsAntiAliasing())
+		{
+			pOut->SetAntialiasing( ANTIALIASING_ENABLE_B2DDRAW );
+		}
+		// End of fix
+		
 sal_Bool bForceSwap = sal_False, bContinue = sal_True;
 GraphicObject& rGrfObj = pGrfNd->GetGrfObj();
 



antialiasing-metafile-test.odt
Description: application/vnd.oasis.opendocument.text
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix for bug 33781 => No anti-aliasing in metafiles when anchor is "as char"

2011-05-10 Thread Roland Baudin 
Oh, sorry! There was a problem with my webmail and the files were not 
delivered.


Here is the small patch (only three lines to add in a file) and the test 
file.


Do you think the patch will be included for the 3.4.0 release?
Best regards,
RB



Le 09/05/2011 11:27, rolan...@free.fr a écrit :

Hi there,

here is a patch of the writer module that fixes bug 33781 (No anti-aliasing in metafiles 
when anchor is "as char").
The patch is against LibreOffice 3.4.0 DEV300m103 (Build:1), as it is said in 
the About dialog.

Since I'm not familiar with git, I provide the patch as a simple diff file. I 
hope it's not a problem for you.

I also attach a test file : just right click on the displayed equation and select 
"Anchor / As character" to check that the metafile is correctly antialiased now.

Hope this helps,
RB

(See attached file: fix-antialiasing-problem-with-metafiles.patch.gz) (See 
attached file: antialiasing-metafile-test.odt)


Roland Baudin
Ingénieur de Recherche / Research Engineer
Tel : +33 5 34 35 55 16
Fax : +33 5 34 35 51 52
roland.bau...@thalesaleniaspace.com
RT/TB/N








___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



--
X File Explorer http://roland65.free.fr/xfe
Toutes Choses http://roland65.free.fr/ttc
--- ./git.orig/libo/clone/writer/sw/source/core/doc/notxtfrm.cxx	2011-05-08 12:20:26.0 +0200
+++ ./git/libo/clone/writer/sw/source/core/doc/notxtfrm.cxx	2011-05-09 10:48:43.020482547 +0200
@@ -816,6 +816,13 @@
 
 if( pGrfNd )
 {
+		// Fix for bug #33781
+		if (pShell->Imp()->GetDrawView()->IsAntiAliasing())
+		{
+			pOut->SetAntialiasing( ANTIALIASING_ENABLE_B2DDRAW );
+		}
+		// End of fix
+		
 sal_Bool bForceSwap = sal_False, bContinue = sal_True;
 GraphicObject& rGrfObj = pGrfNd->GetGrfObj();
 


antialiasing-metafile-test.odt
Description: application/vnd.oasis.opendocument.text
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice