Combobox rebuild error
Hello I am trying to make code changes to the file core/vcl/source/control/combobox.cxx but I have the following errors : core/vcl/source/control/combobox.cxx: In member function ‘virtual void ComboBox::Resize()’: core/vcl/source/control/combobox.cxx:601:9: error: ‘ComboBoxBounds’ was not declared in this scope core/vcl/source/control/combobox.cxx:601:24: error: expected ‘;’ before ‘aBounds’ core/vcl/source/control/combobox.cxx:603:36: error: ‘aBounds’ was not declared in this scope core/vcl/source/control/combobox.cxx: In member function ‘virtual Size ComboBox::CalcMinimumSize() const’: core/vcl/source/control/combobox.cxx:1072:9: error: ‘ComboBoxBounds’ was not declared in this scope core/vcl/source/control/combobox.cxx:1072:24: error: expected ‘;’ before ‘aBounds’ core/vcl/source/control/combobox.cxx:1073:24: error: ‘aBounds’ was not declared in this scope core/vcl/source/control/combobox.cxx: At global scope: core/vcl/source/control/combobox.cxx:1498:1: error: ‘ComboBoxBounds’ in ‘class ComboBox’ does not name a type None of my code changes is shown in the errors list and maybe I think the commit here produces some changes which might be the cause of the errors : http://cgit.freedesktop.org/libreoffice/core/commit/?id=d19eab221f168aed12249ffc8a36a9f1aca5a94e Need help on this . Any sort of assistance is appreciated . Regards , Rushi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Help required
Hello , I am trying to solve the bug : https://bugs.freedesktop.org/show_bug.cgi?id=55846 and I have already gone through the files : http://opengrok.libreoffice.org/search?q=&project=core&defs=FontSizeBox , http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbunocontroller.cxx and other files related to the toolbox as well : http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox.cxx , http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox2.cxx . I am adopting the following approach : 1) If the toolbar is docked vertically , i.e. if(!bHorz) or the values are such : meAlign = WINDOWALIGN_LEFT || meAlign = WINDOWALIGN_RIGHT , then the FontSizeBox's representation as a MetricBox is converted to an image , can you please tell me how do I get the ItemId of the image . 2) After getting the ItemId of the image in the vertical Toolbar , I want to attach a handler to the image which creates a drop-down box as it does for the FontSizeBox : http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbunocontroller.cxx . I would like to ask about how and where do I attach the drop-down handler to the fontsizebox image in the vertical toolbar ? Any sort of help is appreciated :-) Regards , Rushi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Resolves fdo#46718 : UI: Delete multiple styles at once
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1730
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/1730/1
Resolves fdo#46718 : UI: Delete multiple styles at once
Allows the user to delete multiple styles at once.
Previously you need to select one style at a time and confirm its deletion. The
patch enables the user to select multiple styles at once and delete them in one
step. This is particularly useful when the user has numerous styles which are
not not used regualarly or shall not be used in the future .
Author : Rushi Shukla (rushbo...@gmail.com)
Change-Id: I88d0113d4d311f98de8e20a5f8c8ebc0e2025b6f
---
M sfx2/source/dialog/templdlg.cxx
M sfx2/source/inc/templdgi.hxx
2 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index b315453..d707ea4 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -1991,7 +1991,12 @@
if ( pTreeBox )
{
-pTreeBox->RemoveParentKeepChildren(
pTreeBox->FirstSelected() );
+while(pTreeBox->FirstSelected)
+{
+SvTreeListEntry* temp = pTreeBox->NextSelected();
+pTreeBox->RemoveParentKeepChildren(
pTreeBox->FirstSelected() );
+pTreeBox->FirstSelected() = temp ;
+}
bDontUpdate = sal_False;
}
}
@@ -2038,6 +2043,7 @@
const SfxStyleFamilyItem *pItem = GetFamilyItem_Impl();
const SfxStyleFamily eFam = pItem->GetFamily();
sal_uInt16 nFilter = 0;
+sal_bool DelFlag = sal_false;
if(pItem->GetFilterList().size() > nActFilter)
nFilter = pItem->GetFilterList()[ nActFilter ]->nFlags;
if(!nFilter)// automatic
@@ -2045,14 +2051,29 @@
const SfxStyleSheetBase *pStyle =
pStyleSheetPool->Find(aTemplName,eFam, pTreeBox? SFXSTYLEBIT_ALL :
nFilter);
-OSL_ENSURE(pStyle, "Style ot found");
-if(pStyle && pStyle->IsUserDefined())
+OSL_ENSURE(pStyle, "Style not found");
+if(pStyle)
{
-EnableDel(sal_True);
-}
-else
-{
-EnableDel(sal_False);
+ while(pTreeBox->FirstSelected)
+ {
+SfxStyleSheetBase *pcheck = GetSelectedStyle();
+if(!(pcheck->UserDefined()))
+{
+sal_bool=false;
+break;
+}
+SvTreeListEntry* temp = pTreeBox->NextSelected();
+if(pTreeBox->FirstSelected)
+pTreeBox->FirstSelected() = temp ;
+}
+if(DelFlag)
+{
+EnableDel(sal_True);
+}
+else
+{
+EnableDel(sal_False);
+}
}
}
else
diff --git a/sfx2/source/inc/templdgi.hxx b/sfx2/source/inc/templdgi.hxx
index b5fdbd9..1bd6fe3 100644
--- a/sfx2/source/inc/templdgi.hxx
+++ b/sfx2/source/inc/templdgi.hxx
@@ -136,6 +136,7 @@
SfxTemplateItem*pFamilyState[MAX_FAMILIES];
SfxStyleSheetBasePool* pStyleSheetPool;
SvTreeListBox* pTreeBox;
+pTreeBox.SetSelectionMode(MULTIPLE_SELECTION);
SfxObjectShell* pCurObjShell;
::com::sun::star::uno::Reference< ::com::sun::star::frame::XModuleManager2
>
xModuleManager;
--
To view, visit https://gerrit.libreoffice.org/1730
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88d0113d4d311f98de8e20a5f8c8ebc0e2025b6f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rushi Shukla
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Resolves fdo#55846 - Font Size list does not display with ve...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1717
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1717/1
Resolves fdo#55846 - Font Size list does not display with vertical Formatting
toolbar
When the Formatting toolbar is positioned/docked horizontally, the Font Size
drop-down list expands correctly. When docked vertically, the Font Size
drop-down list does not expand at all.
The Font Size drop-down list should now expand whether the Formatting toolbar
is vertically or horizontally positioned/docked.
Author : Rushi Shukla (rushbo...@gmail.com)
Change-Id: I62f5d49b3c1d1e37dc74cdf8c18bde51cede4cf4
---
M svtools/source/control/ctrlbox.cxx
1 file changed, 7 insertions(+), 0 deletions(-)
diff --git a/svtools/source/control/ctrlbox.cxx
b/svtools/source/control/ctrlbox.cxx
index 09cf09f..c66f85e 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -28,6 +28,9 @@
#include
#include
#include
+#include
+#include
+#include
#include
#include
@@ -38,6 +41,8 @@
#include
#include
+#include
+#include
#include
#include
@@ -1670,6 +1675,8 @@
extern "C" SAL_DLLPUBLIC_EXPORT Window* SAL_CALL makeFontSizeBox(Window
*pParent, VclBuilder::stringmap &rMap)
{
bool bDropdown = extractDropdown(rMap);
+if(pParent->IsPined() && !(pParent->IsHorizontal()))
+bDropdown = true;
WinBits nWinBits = WB_LEFT|WB_VCENTER|WB_3DLOOK|WB_TABSTOP;
if (bDropdown)
nWinBits |= WB_DROPDOWN;
--
To view, visit https://gerrit.libreoffice.org/1717
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62f5d49b3c1d1e37dc74cdf8c18bde51cede4cf4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rushi Shukla
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Enables-fontsize-in-vertical-formatting-toolbar Change-Id: I...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1711
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1711/1
Enables-fontsize-in-vertical-formatting-toolbar
Change-Id: I8a376e657b99e7daa51272f5153d7cbc5bcafe9b
---
M svtools/inc/svtools/ctrlbox.hxx
M svtools/source/control/ctrlbox.cxx
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/svtools/inc/svtools/ctrlbox.hxx b/svtools/inc/svtools/ctrlbox.hxx
index 2d6e6a2..5cc1c1c 100644
--- a/svtools/inc/svtools/ctrlbox.hxx
+++ b/svtools/inc/svtools/ctrlbox.hxx
@@ -21,6 +21,9 @@
#define _CTRLBOX_HXX
#include "svtools/svtdllapi.h"
+#include
+#include
+#include
#include
#include
@@ -29,6 +32,9 @@
#include
#include
#include
+#include
+#include
+
class FontList;
class ImplColorListData;
diff --git a/svtools/source/control/ctrlbox.cxx
b/svtools/source/control/ctrlbox.cxx
index 09cf09f..5da4448 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -38,6 +38,7 @@
#include
#include
+#include
#include
#include
@@ -1670,6 +1671,9 @@
extern "C" SAL_DLLPUBLIC_EXPORT Window* SAL_CALL makeFontSizeBox(Window
*pParent, VclBuilder::stringmap &rMap)
{
bool bDropdown = extractDropdown(rMap);
+if(pParent->IsPined() && !(pParent->IsHorizontal()))
+bDropdown = true;
+
WinBits nWinBits = WB_LEFT|WB_VCENTER|WB_3DLOOK|WB_TABSTOP;
if (bDropdown)
nWinBits |= WB_DROPDOWN;
--
To view, visit https://gerrit.libreoffice.org/1711
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a376e657b99e7daa51272f5153d7cbc5bcafe9b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rushi Shukla
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
License Statement
I hereby declare that: All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Regards, Rushi Shukla ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice build error
Hello I am trying to build my own LibreOffice . The ./autogen.sh worked fine but after issuing the make command an error showed up which said fatal : index file smaller than expected So to solve this , I issued mv .git/index .git/index/backup git add . but after this I get an error saying : make -r -f /home/rushi/Documents/Gitty/libo/Makefile.top all make[1]: Entering directory `/home/rushi/Documents/Gitty/libo' cd /home/rushi/Documents/Gitty/libo && ./g -f clone error: pathspec 'dictionaries' did not match any file(s) known to git. Did you forget to 'git add'? make[1]: *** [get-submodules] Error 1 make[1]: Leaving directory `/home/rushi/Documents/Gitty/libo' make: *** [all] Error 2 How do I get rid of this ? Any kind of help is appreciated :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re:
Hello The platform is Linux Ubuntu 11.10 , Git version is : git version 1.7.12.4 and for cloning the libreoffice repos i used : git clone git:// anongit.freedesktop.org/libreoffice/core libo . Sorry I'm not clear about how to find the checkout of the libreoffice version I am trying to build . Regards, Rushi On Fri, Dec 14, 2012 at 3:37 PM, Michael Meeks wrote: > Hi there, > > On Fri, 2012-12-14 at 04:45 +0530, Rushi Shukla wrote: > > I was trying to build LibreOffice but when i issue the './autogen.sh' > > comand the error i get is : > > Please always CC the development list. > > > BEGIN failed--compilation aborted at -e line 1. > > configure: error: Failed to find some modules > > Error running configure at ./autogen.sh line 201. > > What platform are you using ? what version of git ? what checkout > of > LibreOffice ? > > > Please help me get rid of this problem . Thanks in advance . > > More details are helpful :-) > > Thanks for getting involved ! > > ATB, > > Michael. > > -- > michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Documentation required
Hello If available may I please get a documentation of some .cxx and .hxx files listed in the mail ? I am going through a lot of such files and am still having trouble to understand as to how a particular function works and what is the purpose of it . If you would be so kind as to reply to this mail with a documentation of files listed here : 1) http://opengrok.libreoffice.org/xref/core/sw/inc/docstyle.hxx 2) http://opengrok.libreoffice.org/xref/core/sw/source/ui/app/docstyle.cxx 3) http://opengrok.libreoffice.org/xref/core/rsc/inc/rsc/rscsfx.hxx Regards, -Rushi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Custom Styles in Writer
Hello This might be a no-brainer but can you please tell me exactly which list or arrray stores the Custom Styles made by the user under the 'Styles and Formatting' section of Writer ? .hxx and .cxx files I am studying right now (if this helps in any way) 1) http://opengrok.libreoffice.org/xref/core/sw/inc/docstyle.hxx 2) http://opengrok.libreoffice.org/xref/core/sw/source/ui/app/docstyle.cxx Hope to get this query solved as soon as possible Regards, Rushi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Guidance needed
Hello I am a student of Dhirubhai Ambani Institute of Information and Communication Technology (DAIICT) , Gandhinagr , India.I am really interested in going for GSOC 2013 . I would like to undertake one of libreoffice's projects as my project for GSOC 2013. I am highly dedicated towards programming and research . Can anyone please guide me as to how do i contact a mentor and ask him/her to provide me documentation on any projects that libreoffice is offering .Also do I need to submit some bug-solving code in github . How do I get in touch with a mentor ? Any sort of help is highly appreciated . Awaiting your reply soon . -Rushi Shukla ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
