[Libreoffice-commits] core.git: Changes to 'refs/changes/66/266/2'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/66/266/1'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/66/266/3'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/98/298/1'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/68/268/1'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/65/265/3'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/65/265/1'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/changes/65/265/2'

[Ruslan Kabatsayev]

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: On the use of C++ exception handling

[Ruslan Kabatsayev]

Hello,

I've tried filling the survey forms, and on "Use of exception handling
in C++" page the numbers are reset to 1-2-3-4-5 regardless of what I
choose. Thus it's impossible to correctly answer the questions.
I'm using Chromium Version 34.0.1847.116 Ubuntu 12.04 (260972).

Regards,
Ruslan

On Wed, Aug 13, 2014 at 9:50 PM, Rodrigo B Almeida
 wrote:
> Dear all, I've been investigating the use of C++ exception handling
> constructs in open-source C++ projects (including LibreOffice). Currently, I
> am conducting a survey on this subject and I would really appreciate if you
> could contribute to this research by answering a few questions.
>
> The survey is available on-line:
>
> https://pt.surveymonkey.com/s/exceptionHandling
>
> All the best,
>
> Rodrigo.
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to build an old version of LibO

[Ruslan Kabatsayev]

On Thu, May 1, 2014 at 7:23 PM, Laurent BP  wrote:
> Thanks Ruslan for your answer.
>
> Ruslan Kabatsayev wrote
>> So you want to reset your local branch to libreoffice-4-2, right? I
>> think what you need is switching to your local branch and doing
>>
>> git reset --hard origin/libreoffice-4-2
>
> OK. It works. Now after make distclean and autogen and make
> I've got a 4.2 version up to date: Version: 4.2.5.0.0+
> Build ID: d1d25c8cbc2962ce2501b4ed6034d2e4e4ccba9a
>
> And now, how can I revert to dace560b350346b9f9a102ee602bb129a008bcfe?

If you reset to this commit, you'll appear somewhere in the master
branch. Are you sure this is what you want? This would then explain
why your version after build was 4.3. It seems you've picked the wrong
sha1 of the commit.
Also, note that when a commit is pushed to several branches, each its
instance will have its own unique hash. Thus, you should check, which
of all these sha1 sums you really want to switch to. (Although this
one doesn't have copies of its commit message as I've searched.)

>
> Regards,
>
> Laurent BP
>
>
>
>
> -
> LibreOffice 4.2.4.1
> --
> View this message in context: 
> http://nabble.documentfoundation.org/How-to-build-an-old-version-of-LibO-tp4106986p4107154.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to build an old version of LibO

[Ruslan Kabatsayev]

Hi,

So you want to reset your local branch to libreoffice-4-2, right? I
think what you need is switching to your local branch and doing

git reset --hard origin/libreoffice-4-2

This should ensure that you reset to the "real" libreoffice-4-2 branch
from remote, not to anything you might have messed up in your local
libreoffice-4-2 branch.

Regards,
Ruslan

On Thu, May 1, 2014 at 12:11 PM, Laurent BP  wrote:
> Hello,
>
> Thanks for your comments. However I did not yet succeed.
>
>
> Christian Lohmaier-3 wrote
>> Hmm. I wouldn't do that (as I don't know what that would do), instead I'd
>> do a
>>
>> git checkout -b myoldlibreofficebranch whatevergitcommityoupicked
>>
>> That should do the trick.
>
> I tried the following commands:
>> git checkout -b myoldlibreofficebranch
>> dace560b350346b9f9a102ee602bb129a008bcfe
>> make distclean
>> ./autogen.sh && make
>> ./instdir/program/soffice
> But About box says: Version: 4.3.0.0.alpha1+
> Build ID: c6c286f14468d341f5fd88edc39a37175a1b6caa
>
> However, "git log -1" returns
> ==
> commit dace560b350346b9f9a102ee602bb129a008bcfe
> Author: Caolán McNamara 
> Date:   Fri Oct 11 20:45:22 2013 +0100
>
> CID#736194 out of bounds
>
> Change-Id: I236c2f51716bfebd0c132bbaed50c1f1ec811ffa
> ==
>
> "git branch" returns
> ==
>   UITrendLineNbPoints
>   commandNameEnterGroup
>   importDrawAOO4
>   libreoffice-4-2
>   master
> * myoldlibreofficebranch
> ==
>
> and "git status" returns (my own translation)
> # On branch myoldlibreofficebranch
> # Files not followed:
> #   (use "git add ..." to include in what will be validated)
> #
> #   external/tarballs/
> #   ios/lo.xcconfig
>
> I do not understand what is happening :(
> "git" seems to be OK but "make" seems to build another branch (actually my
> branch "master")
>
>
> Christian Lohmaier-3 wrote
>> btw: 4.1.1.2 in your signature: Really using that version? If so: why? :-)
>
> No, I did not update my signature for a long time.
>
> Many thanks in advance for your help.
>
> Laurent BP
>
>
>
> -
> LibreOffice 4.2.4.1
> --
> View this message in context: 
> http://nabble.documentfoundation.org/How-to-build-an-old-version-of-LibO-tp4106986p4107083.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: OpenGL on Linux

[Ruslan Kabatsayev]

On Mon, Feb 10, 2014 at 3:11 AM, Markus Mohrhard
 wrote:
> Hey Philipp,
>
>
> On Sat, Feb 8, 2014 at 8:09 PM, Philipp Weissenbacher
>  wrote:
>>
>> Bit late to the party, but here you go:
>> http://pastie.org/8712627
>>
>> System: openSUSE 13.1
>> Hardware: Dell Latitude D830 with a "Mobile GM965/GL960 Integrated
>> Graphics Controller"
>>
>
> Do you by chance run it in Vmware? You are only the third one reporting a
> 2.1 OpenGL version. Ignoring the base line we are at just yours and
> Krunoslav Šebetic's. Actually these two are also the ones that don't support
> anti-aliasing which even if we manage to support these old versions results
> in ugly output.

I'd like to note that there're still lots of video cards which are not
even 2.0 capable - e.g. intel video in my EEE PC 1015PN only supports
OpenGL 1.4 with ARB assembly shaders. Another example would be
(although quite old, but still working and actively supported by intel
in Mesa) i915G chipset, which has similar characteristics.
Also, if you try using Mesa 9.1+ with these, you'll get (exactly, not
higher than) OpenGL 2.1 advertised, but really giving you software
fallbacks every now and then.
So, I'd not like to have an office suite require OpenGL higher than
1.4 (it may use higher versions if they are available, but still not
require).
As to antialiasing, it seems Mesa doesn't support useful antialiasing
_at_all_ (not even in swrast). I.e. it has exactly one sample in
GL_ARB_multisample, it doesn't have antialiased lines - only "manual"
supersampling/jittered frame accumulation/jittered frame blending.

>
> Regards,
> Markus
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: OpenGL on Linux

[Ruslan Kabatsayev]

Hi Markus,

Here's glxinfo output on my nVidia Geforce GTX 460 with binary drivers:

http://pastebin.com/raw.php?i=Uh2rYufS

Regards,
Ruslan

On Sat, Jan 11, 2014 at 9:54 PM, Markus Mohrhard
 wrote:
> Hey,
>
> I'm currently working on integrating the chart-opengl2 branch into master
> and would like to make it available on linux soon after that. Currently the
> feature is developed on Windows and produces runtime problems.
>
> Sadly Mesa is quite far behind the OpenGL specification (Mesa 10 just
> supports 3.3 and our RHEL 5 baseline is still in OpenGL 1.x)
>
> Could some of you please send me the output of glxinfo to provide a picture
> which OpenGL versions are available and more importantly which OpenGL
> extensions are supported?
>
> This helps me to determine which OpenGL features I can use and have an
> approximation how many systems are not supported in the chart-opengl2
> branch. I'm both interested in output from systems with the opensource
> drivers but even more in systems using the official drivers from
> Intel/Nvidia/AMD.
>
> Thanks a lot for your help,
> Markus
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Visual formula editor

[Ruslan Kabatsayev]

Hi,

On Fri, May 17, 2013 at 10:37 PM, Tomaž Vajngerl  wrote:
> Hi,
>
> With formula editor you mean LO Math? I am working on a new "elements"
> docking window as better alternative to the current one. All elements are
> rendered so I can put in any equation that I want - see attached image. I
> hope I will be able to deliver something in LO 4.1
By _visual_ formula editor I mean the experimental feature where one
can enter formulas directly in formula viewing frame, not having to
write LO Math code itself.
So, my question is rather for specially this feature, not the whole math.
>
> Generally everything is in starmath folder in LO. Most interesting are
> starmath/source/visitors.cxx / stamath/inc/visitors.hxx which contain
> visitors which perform various tasks on a parsed equation tree like drawing
> the equation. With a custom visitor you could for implement solving or
> exporting.
Thanks, I'll have a look in that dir.
>
> Regards, Tomaž
>
>
> On Fri, May 17, 2013 at 7:47 PM, Ruslan Kabatsayev 
> wrote:
>>
>> Hi all,
>>
>> Is visual formula editor still being worked on?
>> I'd like to make some changes on its interface, namely shortcuts to
>> insert some elements like fractions, roots etc., making all this feel
>> more like Wolfram Mathematica's formula editor (which is _quite_
>> powerful and logically consistent). Ideally, this would have the power
>> of Mathematica's formula editor, residing in a FOSS suite.
>> Has there in fact been any discussion on how these things should feel
>> like? Or is there any documentation about this?
>> Also, could someone give some pointers on where all this stuff is
>> located in the code?
>>
>> Regards,
>> Ruslan
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Visual formula editor

[Ruslan Kabatsayev]

Hi all,

Is visual formula editor still being worked on?
I'd like to make some changes on its interface, namely shortcuts to
insert some elements like fractions, roots etc., making all this feel
more like Wolfram Mathematica's formula editor (which is _quite_
powerful and logically consistent). Ideally, this would have the power
of Mathematica's formula editor, residing in a FOSS suite.
Has there in fact been any discussion on how these things should feel
like? Or is there any documentation about this?
Also, could someone give some pointers on where all this stuff is
located in the code?

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: master build failure

[Ruslan Kabatsayev]

Well, I always do a 'git clean -xdf' before pulling LibO stuff, so I
guess this should be enough, no?

On Fri, May 3, 2013 at 11:34 AM, Noel Grandin  wrote:
>
> That looks like it has to do with the splitting out of some ODF stuff.
> You might need to do a "make clean"
>
>
> On 2013-05-02 21:02, Ruslan Kabatsayev wrote:
>>
>> Hi all,
>>
>> I'm facing a build failure with current master, here's the error output:
>>
>> [build CUT] sal_rtl_cipher
>> [build CUT] sal_rtl_crc32
>> [build CUT] sal_rtl_doublelock
>> [build CUT] sal_rtl_locale
>> [build CUT] sal_rtl_ostringbuffer
>> [build CUT] sal_rtl_oustringbuffer
>> [build CUT] sal_rtl_textenc
>> [build CUT] sal_rtl_strings
>> [build CUT] sal_rtl_uri
>> [build CUT] sal_rtl_uuid
>> [build CUT] sal_tcwf
>> [build CUT] sal_types
>> [build CUT] sal_osl_mutex
>> [build CUT] sal_osl_profile
>> [build CUT] sal_osl_setthreadname
>> [build CUT] sal_rtl_math
>> [build LNK] Library/libreg.so
>> [build PKG] harfbuzz
>> [build EPK] harfbuzz
>> [build PRJ] libcdr
>> [build PKG] langtag_data
>> [build PKG] liblangtag_data
>>
>> /fastdocs/programmer/libreoffice/libo/libodfgen/ExternalPackage_libodfgen.mk:24:
>> *** file
>> /fastdocs/programmer/libreoffice/libo/workdir/unxlngi6.pro/UnpackedTarball/odfgen/src/lib/.libs/libodfgen-0.0.a
>> does not exist in the tarball.  Stop.
>> make[1]: *** Waiting for unfinished jobs
>> make: *** [build] Error 2
>>
>> Any ideas?
>>
>> Thanks,
>> Ruslan
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>
> Disclaimer: http://www.peralex.com/disclaimer.html
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

master build failure

[Ruslan Kabatsayev]

Hi all,

I'm facing a build failure with current master, here's the error output:

[build CUT] sal_rtl_cipher
[build CUT] sal_rtl_crc32
[build CUT] sal_rtl_doublelock
[build CUT] sal_rtl_locale
[build CUT] sal_rtl_ostringbuffer
[build CUT] sal_rtl_oustringbuffer
[build CUT] sal_rtl_textenc
[build CUT] sal_rtl_strings
[build CUT] sal_rtl_uri
[build CUT] sal_rtl_uuid
[build CUT] sal_tcwf
[build CUT] sal_types
[build CUT] sal_osl_mutex
[build CUT] sal_osl_profile
[build CUT] sal_osl_setthreadname
[build CUT] sal_rtl_math
[build LNK] Library/libreg.so
[build PKG] harfbuzz
[build EPK] harfbuzz
[build PRJ] libcdr
[build PKG] langtag_data
[build PKG] liblangtag_data
/fastdocs/programmer/libreoffice/libo/libodfgen/ExternalPackage_libodfgen.mk:24:
*** file 
/fastdocs/programmer/libreoffice/libo/workdir/unxlngi6.pro/UnpackedTarball/odfgen/src/lib/.libs/libodfgen-0.0.a
does not exist in the tarball.  Stop.
make[1]: *** Waiting for unfinished jobs
make: *** [build] Error 2

Any ideas?

Thanks,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Problems amending commit

[Ruslan Kabatsayev]

Hi,

On Tue, Mar 5, 2013 at 2:28 AM, Philipp Weissenbacher
 wrote:
> Hi all,
>
> I have problems incorporating the changes suggested by Thomas Arnhold in
> Change-Id: I98c1ffcb.
>
> I tried the following (following the wiki and Winfried's question regarding
> this
> http://nabble.documentfoundation.org/how-to-submit-a-patch-set-2-or-greater-to-gerrit-td4027094.html):
>
> philipp@styx libo$ ./logerrit cherry-pick I98c1ffcb4
> From ssh://logerrit/core
>  * branchrefs/changes/39/2539/2 -> FETCH_HEAD
> # On branch master
> # Your branch is ahead of 'origin/master' by 4 commits.
> #   (use "git push" to publish your local commits)
> #
> # You are currently cherry-picking.
> #   (all conflicts fixed: run "git commit")
> #
> # Changes not staged for commit:
> #   (use "git add ..." to update what will be committed)
> #   (use "git checkout -- ..." to discard changes in working
> directory)
> #
> # modified:   sc/source/core/data/dociter.cxx
> #
> no changes added to commit (use "git add" and/or "git commit -a")
> The previous cherry-pick is now empty, possibly due to conflict resolution.
> If you wish to commit it anyway, use:
>
> git commit --allow-empty
>
> Otherwise, please use 'git reset'
> philipp@styx libo$ git commit -a --amend && ./logerrit submit
> fatal: You are in the middle of a cherry-pick -- cannot amend.
>
> I tried to git reset --hard and do the cherry-pick + editing + git commit
> --amend again, but to no avail. I always end up with "fatal: You are in the
> middle of a cherry-pick -- cannot amend."

You can reset to remote state via "git reset --hard origin/HEAD" or
"git reset --hard origin/BranchName". Or, just as easy, look some
recent commit in your tree and reset ot it via "git reset --hard
$COMMIT_ID". This will take you out of being in the middle of the
cherry-pick.

>
> Any help much appreciated.
>
> I really should've used branches like in the wiki. :-/
>
> Regards,
> Philipp
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: I know I shouldn't but I'll do it anyway....

[Ruslan Kabatsayev]

Hi,

On Fri, Feb 15, 2013 at 10:14 PM, Noel Grandin  wrote:
>
>
>
> On Fri, Feb 15, 2013 at 7:57 PM, Olivier Hallot
>  wrote:
>>
>>
>> suggest to replace the start center with a grid of recent files
>> thumbnails...
>>
>> Whoever opened an Office 2013 application with no document loaded knows
>> what I am talking about. And we can do better.
>>
>
> Good idea.
>
> I don't see why we can't have both links to the applications and a set of
> recent files.
>
> I have no idea why start screens always use so little of the available
> display.

I hope by available display you mean window size, not screen
resolution?.. Of course, I'd be quite annoyed if I can't make the app
window smaller than my screen is. Also, take such machines as netbooks
into account. They can have as small as 1024x600 screens. Will this
still work on them?

>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Ruslan Kabatsayev]

 sw/source/ui/inc/view.hxx|2 ++
 sw/source/ui/uiview/view.cxx |1 +
 sw/source/ui/uiview/viewport.cxx |   11 ++-
 3 files changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 8880c773e779710dc0a08760e92afd709a73ca31
Author: Ruslan Kabatsayev 
Date:   Thu Feb 7 21:09:59 2013 +0400

Resolves: fdo#43650 Disable tooltip when scrolling writer docs via mouse 
wheel

Change-Id: I8e0d27b26afef08cc6ef963a2baadcddc78f6b27

diff --git a/sw/source/ui/inc/view.hxx b/sw/source/ui/inc/view.hxx
index 573e4d7..68383d4 100644
--- a/sw/source/ui/inc/view.hxx
+++ b/sw/source/ui/inc/view.hxx
@@ -243,6 +243,8 @@ class SW_DLLPUBLIC SwView: public SfxViewShell
 sal_uInt16  nLeftBorderDistance;
 sal_uInt16  nRightBorderDistance;
 
+bool mbWheelScrollInProgress;
+
 sal_BoolbCenterCrsr : 1,
 bTopCrsr : 1,
 bAllwaysShowSel : 1,
diff --git a/sw/source/ui/uiview/view.cxx b/sw/source/ui/uiview/view.cxx
index 1d27f8d..1ad946c 100644
--- a/sw/source/ui/uiview/view.cxx
+++ b/sw/source/ui/uiview/view.cxx
@@ -744,6 +744,7 @@ SwView::SwView( SfxViewFrame *_pFrame, SfxViewShell* pOldSh 
)
 nLastPasteDestination( 0x ),
 nLeftBorderDistance( 0 ),
 nRightBorderDistance( 0 ),
+mbWheelScrollInProgress(false),
 bInMailMerge(sal_False),
 bInDtor(sal_False),
 bOldShellWasPagePreView(sal_False),
diff --git a/sw/source/ui/uiview/viewport.cxx b/sw/source/ui/uiview/viewport.cxx
index 150ba01f..729a42b 100644
--- a/sw/source/ui/uiview/viewport.cxx
+++ b/sw/source/ui/uiview/viewport.cxx
@@ -692,7 +692,7 @@ IMPL_LINK( SwView, ScrollHdl, SwScrollbar *, pScrollbar )
 {
 
 //QuickHelp:
-if( pWrtShell->GetPageCnt() > 1 && Help::IsQuickHelpEnabled() )
+if( !mbWheelScrollInProgress && pWrtShell->GetPageCnt() > 1 && 
Help::IsQuickHelpEnabled() )
 {
 if( !nPgNum || nPgNum != nPhNum )
 {
@@ -1290,6 +1290,12 @@ sal_Bool SwView::HandleWheelCommands( const 
CommandEvent& rCEvt )
 }
 else
 {
+if(pWData->GetMode()==COMMAND_WHEEL_SCROLL)
+{
+// This influences whether quick help is shown
+mbWheelScrollInProgress=true;
+}
+
 if (pWData && (COMMAND_WHEEL_SCROLL==pWData->GetMode()) && 
(((sal_uLong)0x) == pWData->GetScrollLines()))
 {
 if (pWData->GetDelta()<0)
@@ -1301,6 +1307,9 @@ sal_Bool SwView::HandleWheelCommands( const CommandEvent& 
rCEvt )
 else
 bOk = pEditWin->HandleScrollCommand( rCEvt,
 pHScrollbar, pVScrollbar);
+
+// Restore default state for case when scroll command comes from 
dragging scrollbar handle
+mbWheelScrollInProgress=false;
 }
 return bOk;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Disable useless flickering tooltip when scrolling Writer document via mouse wheel

[Ruslan Kabatsayev]

Hi all,

This patch disables annoying useless flickering tooltip appearing when
Writer document is being scrolled by mouse wheel.
It doesn't touch the tooltip when scrolling is done via scrollbar
handle because this one _is_ useful.
See fdo#43650 for rationale.

Regards,
Ruslan


0001-Disable-tooltip-when-scrolling-Writer-document-via-m.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Combobox rebuild error

[Ruslan Kabatsayev]

Hi,

On Fri, Jan 25, 2013 at 11:05 PM, Rushi Shukla  wrote:
> Hello
>
> I am trying to make code changes to the file
> core/vcl/source/control/combobox.cxx but I have the following errors :
>
>
> core/vcl/source/control/combobox.cxx: In member function ‘virtual void
> ComboBox::Resize()’:
> core/vcl/source/control/combobox.cxx:601:9: error: ‘ComboBoxBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx:601:24: error: expected ‘;’ before
> ‘aBounds’
> core/vcl/source/control/combobox.cxx:603:36: error: ‘aBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx: In member function ‘virtual Size
> ComboBox::CalcMinimumSize() const’:
> core/vcl/source/control/combobox.cxx:1072:9: error: ‘ComboBoxBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx:1072:24: error: expected ‘;’ before
> ‘aBounds’
> core/vcl/source/control/combobox.cxx:1073:24: error: ‘aBounds’ was not
> declared in this scope
> core/vcl/source/control/combobox.cxx: At global scope:
> core/vcl/source/control/combobox.cxx:1498:1: error: ‘ComboBoxBounds’ in
> ‘class ComboBox’ does not name a type
>
> None of my code changes is shown in the errors list and maybe I think the
> commit here produces some changes which might be the cause of the errors :
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=d19eab221f168aed12249ffc8a36a9f1aca5a94e
>

What do your changes look like? You might have added a new data member
before struct ComboBoxBounds declaration, but missing a semicolon,
which would make the struct appear undeclared.
This could in fact be anything. If this code does compile when
unchanged (and it does for me), then we can't tell anything without
seeing your changes.

> Need help on this . Any sort of assistance is appreciated .
>
> Regards ,
> Rushi
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW-4-0] oxygen-gtk support version ...

[Ruslan Kabatsayev]

Hi,

On Fri, Jan 11, 2013 at 10:45 PM, Noel Power  wrote:
> On 10/01/13 17:41, Michael Meeks wrote:
>>
>> Hi there,
>>
>>
>> I cleaned up the version bits (as well as I could in a
>> back-portable
>> way for 4.0 - really we should drive this all from one setting in
>> configure.in IMHO).
>>
>> I'd like to get the result into -4-0 if someone could review/ pick
>> these two:
>>
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=364cce0a511d3e7a3bbc51e09895999fbdf0dbe1
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=0260f0b256c3675bb6d836c0a2babb7626577b7a
>>
>> And hopefully it'd be possible (any chance you could do that Tor?)
>> to
>> file an easy-hack to kill remaining code-based 'SUPD' uses to use
>> LIBO_VERSION_ bits
>>
>
> ok, these didn't cherry-pick cleanly, I manaully changed the "add
> LIBO_VERSION_* macros and a config header for them to live in."
> patch. After that it didn't build so I added "add config path for commit
> bf85d5eb33ff33c9ff94336de9d9f67825296c10"
>
> I don't feel confident pushing this on a friday afternoon, if anyone else
> wants to test and try ( say on windows ) then that might be an
> idea :-) note: builds for me ok on linux. If not I will push on Monday

Tested on Linux, builds OK and works OK with oxygen-gtk2 master.

>
> Noel

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About idlc/source/idlccompile.cxx

[Ruslan Kabatsayev]

Hi,

On Sun, Jan 13, 2013 at 9:01 PM, julien2412  wrote:
> Hello,
>
> Taking a look at this cppcheck report:
> dlc/source/idlccompile.cxx
> 198 nullPointer error   Possible null pointer dereference: source - 
> otherwise
> it is redundant to check it against null.

Looks like a false-positive of cppcheck. source is checked against
null to determine whether to take stdin or source file as data source,
then at lines 198 & 207 pSource file handle is closed only if it had
been opened (which is done only for source==0). I don't see any way
there could be a null pointer dereference.
>
> I don't understand the function "sal_Bool copyFile(const OString* source,
> const OString& target)", above all this part:
> 192 while ( !feof(pSource) )
> 193 {
> 194 if ( (readSize = fread(pBuffer, 1, totalSize, pSource)) > 0
> && !ferror(pSource) )
> 195 {
> 196 if ( (fwrite(pBuffer, 1, readSize, pTarget)) != readSize
> || ferror(pTarget) )
> 197 {
> 198 if (source != 0) {
> 199 fclose(pSource);
> 200 }
> 201 fclose(pTarget);
> 202 return sal_False;
> 203 }
> 204 }
> 205 }
> see
> http://opengrok.libreoffice.org/xref/core/idlc/source/idlccompile.cxx#173
> Isn't it overcomplicated? Why reading a file 1 per 1 byte for example?

It's not reading 1 byte at a time. It's reading totalSize bytes at a
time, getting readSize with 1 byte granularity.

>
> Julien
>
>
>
> --
> View this message in context: 
> http://nabble.documentfoundation.org/About-idlc-source-idlccompile-cxx-tp4028889.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fdo#40465 fix to maintain focus whilst zooming

[Ruslan Kabatsayev]

Hi,

Your change, though looks good in principle, appears to lead to some
usability problems: suppose while reading a document you've placed
cursor somewhere (or even didn't move it), then you scroll several
pages up/down from that place, and now need to see current page in
more detail. You Zoom it and... the view jumps to cursor position.
This is clearly not what you've expected; moreover, if you didn't know
page number you were on, you'll now have to search that place to
continue reading.

Could this behavior be changed so that not cursor governs current
focus, but the place which the user has last scrolled to?
Should I make a bug report for this?

Regards,
Ruslan

On Fri, Jan 4, 2013 at 7:00 PM, Winfried Donkers (via Code Review)
 wrote:
> Winfried Donkers has abandoned this change.
>
> Change subject: fdo#40465 fix to maintain focus whilst zooming
> ..
>
>
> Patch Set 1: Abandoned
>
> I finally managed to upload a Patch Set 2 to gerrit 1278, so this one (1533) 
> can be closed.
>
> --
> To view, visit https://gerrit.libreoffice.org/1533
> To unsubscribe, visit https://gerrit.libreoffice.org/settings
>
> Gerrit-MessageType: abandon
> Gerrit-Change-Id: I3fab5d62d8f479a5efe242693d2fbe33375206f8
> Gerrit-PatchSet: 1
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Owner: Winfried Donkers 
> Gerrit-Reviewer: Winfried Donkers 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hi,

On Wed, Jan 9, 2013 at 4:51 PM, Michael Meeks  wrote:
> Hi Ruslan,
>
> On Sat, 2013-01-05 at 22:59 +0300, Ruslan Kabatsayev wrote:
>> What about such a simple change, which will let us set LibO version
>> once and for all GTK theme calls:
>
> I guess we could do; we'd want to produce a real version string for a
> patch though :-)
>
> The reason why I put it on the top-level windows was so that it can be
> avoided for native widgets (eg. the gtk+ file selector) - but if that's
> not an issue then fine :-)
>
>>  // init gtk/gdk
>>  gtk_init_check( &nParams, &pCmdLineAry );
>> +g_setenv("LibreOffice_Version","4.0.0.0",true);
>>  gdk_error_trap_push();
>>  aOrigXIOErrorHandler = XSetIOErrorHandler(XIOErrorHdl);
>>
>> 
>> Of course, "4.0.0.0" should be replaced by some variable, name of
>> which I currently don't know. But how do you like this idea? It seems
>> the easiest and most efficient compared to any g_object_set_data()
>> way.
>
> The g_object_set_data stuff is already in:
>
> +static char pVersion[16] = "";
> +if( pVersion[0] == '\0' )
> +g_sprintf( pVersion, "%d", SUPD );
> +g_object_set_data( G_OBJECT( m_pWindow ), "libo-version", pVersion );
> +
>
> should be in 4.0 and master.

I've checked this and it appears to work *sometimes* (i.e. for some
widgets). Also, it doesn't look too clean to me to make per-widget
changes only to make theme detect LibO version once (and possibly at
the earliest stage). I'd rather just put this to environment variable
and didn't mess with all these parenting problems.
So, if you don't mind putting version to env var, I'll submit a patch
which will remove the above half-working g_object-based code and add
g_setenv() call.
What env var name should be used, if this matters? Is "LibreOffice_Version" OK?

>
> I wonder if we get problems from the (un-parented) fake widgets that
> are used in the salnativewidgets-gtk pile [ could that be why it doesn't
> work for you ? ].
>
> If that's the issue (and most likely it is) - then we'd want to add a
> similar chunk of version code to the above to:
>
> static void NWAddWidgetToCacheWindow( GtkWidget* widget, SalX11Screen nScreen 
> )
>
> Where we construct and realize the cache window (I guess).
>
> Using SUPD is reasonably easy - it is a 4.0.0 -> 400 thing: not
> terribly robust over big versions, but easy enough to parse I guess.
>
> If you propose a patch, we can get it into 4.0.1rc2 !
>
> Thanks :-)
>
> Michael.
>
> --
> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hi Michael,

What about such a simple change, which will let us set LibO version
once and for all GTK theme calls:
---
diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 14a1949..ec11a8f 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -667,6 +667,7 @@ void GtkData::Init()

 // init gtk/gdk
 gtk_init_check( &nParams, &pCmdLineAry );
+g_setenv("LibreOffice_Version","4.0.0.0",true);
 gdk_error_trap_push();
 aOrigXIOErrorHandler = XSetIOErrorHandler(XIOErrorHdl);


Of course, "4.0.0.0" should be replaced by some variable, name of
which I currently don't know. But how do you like this idea? It seems
the easiest and most efficient compared to any g_object_set_data()
way.

Regards,
Ruslan

On Thu, Nov 22, 2012 at 4:19 PM, Michael Meeks  wrote:
>
> On Wed, 2012-11-21 at 19:46 +0400, Ruslan Kabatsayev wrote:
>> This doesn't seem to be a very easy thing. Oxygen-gtk gets application
>> name via g_get_prgname() and also from PID reading /proc/$PID/cmdline.
>> Not very extensible for versions.
>
> Right :-)
>
>> Yeah, g_object_set_data with LibO version on widget passed to theme
>> would be just fine.
>
> Drat - I added it to each gtk top-level; but now I recall that the
> widgets prolly behave somewhat oddly wrt. their parenting.
>
>> Something like this:
>> g_object_set_data(G_OBJECT(widget),"LibreOfficeVersion",(gpointer)0xMAJVMINV).
>> At least this will work for gtk2, not for gtk3 since no widgets are
>> passed there. Though I don't think we really want to explicitely
>> support LibO in oxygen-gtk3.
>
> I have:
>
> m_pWindow = gtk_widget_new( GTK_TYPE_WINDOW, "type", eWinType,
> "visible", FALSE, NULL );
> g_object_set_data( G_OBJECT( m_pWindow ), "SalFrame", this );
>
> static char pVersion[16] = "";
> if( pVersion[0] == '\0' )
> g_sprintf( pVersion, "%d", SUPD );
> g_object_set_data( G_OBJECT( m_pWindow ), "libo-version", pVersion );
>
> If that helps; if not - a patch to
> vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx would be appreciated :-) [ I
> guess adding a helper and calling it in all those NWFooBaaEnsure methods
> would do it - they look like they could use some re-factoring love
> anyway ].
>
> Thanks !
>
> Michael.
>
> --
> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Junk *.tmp files in /tmp after compilation

[Ruslan Kabatsayev]

Hi,

On Thu, Jan 3, 2013 at 3:35 PM, Michael Meeks  wrote:
> Hi Ruslan,
>
> On Thu, 2013-01-03 at 01:31 +0300, Ruslan Kabatsayev wrote:
>> Each time after LibO compilation (doing it from scratch, i.e. having
>> "git pull&&git clean -xdf" done before if that matters) I discover
>> about 400 files with names like "luxy1e20.tmp" in my /tmp.
>> Shouldn't these temp files have been removed automatically?
>
> In a word - yes :-) I suspect these are gnumake related files; what 
> are
> the contents of them ? we should find which rule is not cleaning up
> nicely and bin them.

Here's contents of one of files:
http://pastebin.com/raw.php?i=5SqkVSGS . Many of the files are empty,
some of non-empty ones are RTFs as the one I've shown, some others are
ZIP (ODS in fact, it seems). My guess is they are left from tests
because they look like test files.
There're also several empty directories left after build.
Interestingly, most files have 0600 permissions, and dirs are 0700.

>
> Also - did your compile complete successfully ?

Yes, build runs to "Multiprocessing build is finished" message.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: How to set the temp directory when building LibreOffice ?

[Ruslan Kabatsayev]

Hi,

I've just sent a message on similar topic :)

On Thu, Jan 3, 2013 at 1:11 AM, Jean-Baptiste Faure
 wrote:
> Hi all,
>
> When building LibreOffice, a lot of files are created in the standard
> temp directory (/tmp for me under Ubuntu). Many of these files are not
> removed when the build has been completed with success.
>
> I think it would be cleaner if these temporary files was created in a
> subdirectory of /tmp. Is there an option to set the temp directory ? I
> did not find such an option in the options list of autogen.sh.

If anything, you can always use standard TMPDIR environment variable.


Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Junk *.tmp files in /tmp after compilation

[Ruslan Kabatsayev]

Hi all,

Each time after LibO compilation (doing it from scratch, i.e. having
"git pull&&git clean -xdf" done before if that matters) I discover
about 400 files with names like "luxy1e20.tmp" in my /tmp.
Shouldn't these temp files have been removed automatically?

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hi,

On Wed, Nov 21, 2012 at 6:36 PM, Ivan Timofeev  wrote:
> Hi,
>
> So, background gradients are fixed now with
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0a5eed63b871e2febb36e27e9dea4b7e57f681b

Thanks, I confirm that it's fixed.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hi Michael,

On Wed, Nov 21, 2012 at 7:09 PM, Michael Meeks  wrote:
>
>> To get this all work more or less as expected (i.e. to fix oxygen-gtk
>> at correct time), I'd need to know, which LibO releases will contain
>> these commits. Any pointers to this?
>
> Is it an easy thing to check from a gtk theme ?

This doesn't seem to be a very easy thing. Oxygen-gtk gets application
name via g_get_prgname() and also from PID reading /proc/$PID/cmdline.
Not very extensible for versions.

> It'd be reasonably easy to set some g_object_data on our top-level
> windows or somesuch - if that helps you ? I guess we have no
> GApplication usage as of now (in case that helps).

Yeah, g_object_set_data with LibO version on widget passed to theme
would be just fine.
Something like this:
g_object_set_data(G_OBJECT(widget),"LibreOfficeVersion",(gpointer)0xMAJVMINV).
At least this will work for gtk2, not for gtk3 since no widgets are
passed there. Though I don't think we really want to explicitely
support LibO in oxygen-gtk3.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

On Tue, Nov 20, 2012 at 2:45 AM, Enrico Weigelt  wrote:
>
> IIRC, this provides KDE look+feel using Gtk, right ?
> That, IMHO, could count as argument for dropping Qt/KDE vcl.
> (see my other postings about vcl's/widget toolkits)

Not quite KDE look&feel in general, rather only Oxygen widget style
(not any other Qt style like Plastique). But still, KDE is indeed
mostly used with oxygen, so I do agree with you about dropping Qt/KDE
support in VCL (especially since it's much poorer than gtk support).
One thing which might be not so good here is KDE file open, file save,
print etc. dialogs. They appear much more usable than GTK ones, so
this is what I'd like to have left in (maybe even provide them for GTK
users if possible in principle & available at run time).

>
>
> cu
> --
> Mit freundlichen Grüßen / Kind regards
>
> Enrico Weigelt
> VNC - Virtual Network Consult GmbH
> Head Of Development
>
> Pariser Platz 4a, D-10117 Berlin
> Tel.: +49 (30) 3464615-20
> Fax: +49 (30) 3464615-59
>
> enrico.weig...@vnc.biz; www.vnc.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hi Ivan,

OK, it appears that these commits have made LibO work more correctly
in GTK handling, and now oxygen-gtk's old hacks to work around
previous LibO incorrectness overcompensate the margins and need to be
removed.
To get this all work more or less as expected (i.e. to fix oxygen-gtk
at correct time), I'd need to know, which LibO releases will contain
these commits. Any pointers to this?

Thanks,
Ruslan

On Fri, Nov 2, 2012 at 1:26 PM, Ivan Timofeev  wrote:
> Hi Ruslan,
>
> On 01.11.2012 23:48, Ruslan Kabatsayev wrote:
>> Some time after my commits, which enabled almost fully correct
>> oxygen-gtk support (latest commit was on Jul 8 2012), this support was
>> broken. See screenshots at [1], [2], [3] and [4] for details.
>
> The problem at [1] is due to the following commits
>
>   https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=50a20f94
>   https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=681e894b
>
> which take logic from _gtk_entry_get_borders
>
>   http://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-2-24#n2874
>
> I have no idea of what is wrong with those commits.
>
> Regards,
> Ivan
>
>> [1] Edit field and combo button sizes mismatch: http://i.imgur.com/lnvfS.png
>> [2] Background gradient not rendered: http://i.imgur.com/lRPLY.png
>> [3] Text line entry clips text to the left too much 
>> http://i.imgur.com/sV10D.png
>> [4] Menu expansion arrows are clipped at top: http://i.imgur.com/Gn67Z.png
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

GTK theming: oxygen-gtk support broken

[Ruslan Kabatsayev]

Hello,

Some time after my commits, which enabled almost fully correct
oxygen-gtk support (latest commit was on Jul 8 2012), this support was
broken. See screenshots at [1], [2], [3] and [4] for details.
Those who hacked on GTK theming support since Jul 8 2012, please have
a look at this. If you think it's oxygen-gtk which should be fixed,
not libreoffice, please report the particular problems to
https://bugs.kde.org (product=Oxygen, component=gtk2-engine). I'll be
happy to improve things on oxygen-gtk side.

Thanks,
Ruslan

[1] Edit field and combo button sizes mismatch: http://i.imgur.com/lnvfS.png
[2] Background gradient not rendered: http://i.imgur.com/lRPLY.png
[3] Text line entry clips text to the left too much http://i.imgur.com/sV10D.png
[4] Menu expansion arrows are clipped at top: http://i.imgur.com/Gn67Z.png
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Ruslan Kabatsayev]

Dirty workaround would be to make a wrapper around ld, which would
filter the command line and call real ld.

On Wed, Oct 31, 2012 at 1:03 AM, Kohei Yoshida  wrote:
> On 10/30/2012 04:07 PM, Kohei Yoshida wrote:
>>
>> On 10/30/2012 03:42 PM, Lubos Lunak wrote:
>>>
>>> On Tuesday 30 of October 2012, Kohei Yoshida wrote:

 Hi there,

 Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't
 seem to turn on symbols.

 Does this ring a bell to anyone?
>>>
>>>
>>>
>>>
>>> http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html
>>>
>>
>> Thanks.  Obviously I missed that that change would eliminate
>> ENABLE_SYMBOLS option altogether.
>>
>> Anyway, sounds like not many people use this option, and I happened to
>> be one of the few that use it (?)  So, I wrote a wrapper to make to
>> revive this use case.
>
>
> ...
>
>
>> inside a module should just enable debug symbols, and nothing but symbols.
>
>
> So, this script can add -g to the CXXFLAGS, but unfortunately the symbols
> get stripped during linking because of -Wl,-S option passed to the linker.
>
> To work around this, I need to find a way to not add this -S option to the
> linker flag in my wrapper script, but so far I'm a bit lost.  It's easier to
> add an additional flag but is very hard to remove flag manually.
>
> Any clever ideas?
>
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: RuntimeException while building

[Ruslan Kabatsayev]

On Fri, Oct 19, 2012 at 6:26 PM, Stephan Bergmann  wrote:
> On 10/19/2012 04:13 PM, Ruslan Kabatsayev wrote:
>>
>> I'm trying to build current libo master, and build fails with this
>> log: http://pastebin.com/d191HeiH
>> Here's the backtrace: http://pastebin.com/6T7CCAZL .
>>
>> LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID:
>> ecf56e)".
>
>
> This *might* have to do with somewhat recent commit
> dccddcc20b0b873ca182983506d97b500edfe4f1 "make gcc-uno bridge work with both
> gcc-4.7 and clang."  Can you try with that two-line patch reverted?  Also,
> what version of GCC do you use?

With this patch reverted it builds OK. I'm using gcc 4.5.1.

>
> Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RuntimeException while building

[Ruslan Kabatsayev]

Hello,

I'm trying to build current libo master, and build fails with this
log: http://pastebin.com/d191HeiH
Here's the backtrace: http://pastebin.com/6T7CCAZL .

LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID: ecf56e)".

Any ideas how to solve this?

Thanks,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

[Ruslan Kabatsayev]

On Wed, Oct 10, 2012 at 12:41 AM, ChrSchultz  wrote:
> I created a symbolic link from the system libstdc++.so.6 to the
> /opt/libreoffice3.6/ure/lib/libstdc++.so.6 and the are no  warnings more ...
Just remove /opt/libreoffice3.6/ure/lib/libstdc++.so.6 or better yet
don't install stdlib part of libreoffice distribution.

>
> Many greatings
> Christoph
>
>
>
> --
> View this message in context: 
> http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstdc-so-6-version-GLIBCXX-3-4-11-not-found-re-tp3995424p4012391.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: autogen.sh error on no warnings

[Ruslan Kabatsayev]

Well, in fact, testing for presence of warn in a way I suggested won't
work, so either ||true should be used, or exit 0 at the end

On Fri, Aug 24, 2012 at 6:02 PM, Ruslan Kabatsayev
 wrote:
> Hi Norbert,
>
> Your fix is not solving all the problem: now autogen fails without
> indication why. See the message:
>
>>If you want to run the smoketest, issue:
>>make check
>>
>>Error running configure at ./autogen.sh line 187.
> This is because you redirect error to /dev/null, but don't prevent cat
> error status. So this is better to be fixed either by first checking
> presence of warn ("[ -e warn ] && cat warn"), or adding "|| true" to
> "cat warn 2>/dev/null"
>
> Regards,
> Ruslan
>
>
> On Fri, Aug 24, 2012 at 5:46 PM, Norbert Thiebaud  wrote:
>> On Fri, Aug 24, 2012 at 7:34 AM, Ruslan Kabatsayev
>>  wrote:
>>> Hello,
>>>
>>> When I have no warnings from configure script, I get an error from
>>> "cat warn" line saying "No such file or directory". I guess "cat warn"
>>> should be changed to something like "[ -e warn ] && cat warn", or warn
>>> should be created at the beginning of configure.
>>> CCing Norbert Thiebaud as git-blame says the corresponding line in
>>> configure.in was last added in commit
>>> 65335b13da74f4f350ba52493b0919a62d1a5bca.
>>>
>>
>> Thanks for the cc:, fixed.
>>
>> Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: autogen.sh error on no warnings

[Ruslan Kabatsayev]

Hi Norbert,

Your fix is not solving all the problem: now autogen fails without
indication why. See the message:

>If you want to run the smoketest, issue:
>make check
>
>Error running configure at ./autogen.sh line 187.
This is because you redirect error to /dev/null, but don't prevent cat
error status. So this is better to be fixed either by first checking
presence of warn ("[ -e warn ] && cat warn"), or adding "|| true" to
"cat warn 2>/dev/null"

Regards,
Ruslan


On Fri, Aug 24, 2012 at 5:46 PM, Norbert Thiebaud  wrote:
> On Fri, Aug 24, 2012 at 7:34 AM, Ruslan Kabatsayev
>  wrote:
>> Hello,
>>
>> When I have no warnings from configure script, I get an error from
>> "cat warn" line saying "No such file or directory". I guess "cat warn"
>> should be changed to something like "[ -e warn ] && cat warn", or warn
>> should be created at the beginning of configure.
>> CCing Norbert Thiebaud as git-blame says the corresponding line in
>> configure.in was last added in commit
>> 65335b13da74f4f350ba52493b0919a62d1a5bca.
>>
>
> Thanks for the cc:, fixed.
>
> Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

autogen.sh error on no warnings

[Ruslan Kabatsayev]

Hello,

When I have no warnings from configure script, I get an error from
"cat warn" line saying "No such file or directory". I guess "cat warn"
should be changed to something like "[ -e warn ] && cat warn", or warn
should be created at the beginning of configure.
CCing Norbert Thiebaud as git-blame says the corresponding line in
configure.in was last added in commit
65335b13da74f4f350ba52493b0919a62d1a5bca.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: [PATCH] translated German comments in starmath

[Ruslan Kabatsayev]

Hi,

Sorry, this was first sent to the wrong address:
-- Forwarded message --
From: Ruslan Kabatsayev 
Date: Sat, Aug 4, 2012 at 12:56 AM
Subject: Re: [PATCH] translated German comments in starmath
To: Philipp Riemer 


Hi,

 2012/8/3 Alexander Wilms :
> When I want to continue working, is 'git reset --hard origin/master'
> all I need to do?
This doesn't fetch new remote changes, so you should do "git pull"
afterwards. Even better, instead of resetting and pulling, you can do
"git fetch && git rebase origin" so that if you have some local
commits which haven't been pushed, they'll get applied on top of
updated origin.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] gtk: listbox border was not rendered

[Ruslan Kabatsayev]

Hi,

After some checks I've come to the conclusion that your patch does it
as it should, and the breakage should be fixed in oxygen-gtk. The only
problem remains is when this fix should be done (i.e. there'll be some
time until your patch gets into a released version of LibO, and until
then we should use current oxygen-gtk code). Any pointers on when your
change may be released once pushed?

Regards,
Ruslan

On Sat, Jul 28, 2012 at 4:51 PM, Ivan Timofeev  wrote:
> Hi Ruslan,
>
>
> On 28.07.2012 15:08, Ruslan Kabatsayev wrote:
>>
>> This mostly looks good, but breaks a bit border for oxygen-gtk
>
>
> I have just installed it, yeah - it is broken... :(
>
>
>> (which somehow has worked before the patch, unlike other themes).
>
>
> Strange.
>
>
>> I'd suggest using getFrameWidth() to adjust the shadow rect.
>
>
> AFAICS vcl makes listbox a child of borderwindow, which receives the border
> sizes via DecorationView::DrawFrame:
> http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1212
> (for oxygen-gtk it is 2 for each border);
>
> shrinks the listbox size by that border in Resize():
> http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#2066
>
> draws CTRL_LISTBOX PART_WINDOW (i.e. calls gtk_paint_shadow with
> "scrolled_window") with its size (i.e. client+borders):
> http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1362
>
> Try to build with my patch and the attached diff applied, IMHO LibO will do
> things right. But probably I missed something (as usual :).
>
>
>> OTOH, we've done quite some customizations in oxygen-gtk before to
>> make it look better with LibO, so maybe this is what should be changed
>> on oxygen-gtk side.
>
>
> It would be great if you could check it. :)
>
> Regards,
> Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Revert toolbox bg rendering as it creates hard to fix regression

[Ruslan Kabatsayev]

Hello,

This patch reverts my earlier patch which tried to render native
background on ToolBox. It appears that this breaks some themes, and
there's no easy fix for this (at least not simple enough to be worth
the trouble).

Regards,
Ruslan


0001-Revert-Enable-native-background-rendering-for-ToolBo.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibO master fails to build after pull

[Ruslan Kabatsayev]

Thank you, now it builds ok.
BTW, your commit message says about gcc 3.x while it should say 4.x.
Though, seems it's too late to fix the message :)

On Mon, Jul 30, 2012 at 11:48 PM, Kohei Yoshida  wrote:
> On Mon, Jul 30, 2012 at 2:29 PM, Kohei Yoshida  
> wrote:
>
>> I'll see if I can patch the internal mdds meantime.
>
> K.  Just pushed a workaround patch to master.  Please pull and try again.
>
> Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibO master fails to build after pull

[Ruslan Kabatsayev]

Hi Kohei,

On Mon, Jul 30, 2012 at 5:59 PM, Kohei Yoshida  wrote:
>As a test, when you clone the upstream master branch of mdds from
>
>http://code.google.com/p/multidimalgorithm/source/checkout
>
> run autogen.sh and make check (or simply make test.mtv), do you get
> the same build error?
Yes, the same ambiguous overload error. Also, I get this error not
only with my gcc 4.5.1 on the machine where LibO build fails, but this
test fails in the same way on Ubuntu 10.04 LTS with gcc 4.4.3. So,
this seems either bug in big enough range of gcc versions, or real
problem in the code.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibO master fails to build after pull

[Ruslan Kabatsayev]

Hi,

I do have this patch pulled (at least git-show does show it), I also
have tried "git reset --hard origin/HEAD" to make sure I'm on latest
commit, but still I have this error. And I rebuild it from clean tree
using "git clean -xdf", so shouldn't need make clean.

Regards,
Ruslan

On Sun, Jul 29, 2012 at 9:06 AM, Daniel Bankston
 wrote:
> On 07/28/2012 03:11 PM, Ruslan Kabatsayev wrote:
>
> Hello,
>
> After pulling master updating from tree dated by ~July 18, LibO no
> longer builds for me. Here's what I get: http://pastebin.com/YiXhAvM4
> I don't quite understand what's wrong here and how to fix this. Any ideas?
>
> (CC'ing Kohei since he's the only one who has committed to
> scmatrix.cxx since then)
>
> Thanks,
> Ruslan
>
> Hi, Ruslan,
>
> Last week when my build was failing at scmatrix, David Tardon's commit fixed
> it for me (Markus Mohrhard pointed it out to me):
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=42c58d9ce4f33b047feb1e94e60f165360d96209
>
> You may have pulled before David pushed it.
>
> If I remember correctly, after getting that commit, you'll need to make
> clean and make within sc.  Then you can try top level make again.
>
> --Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibO master fails to build after pull

[Ruslan Kabatsayev]

Hello,

After pulling master updating from tree dated by ~July 18, LibO no
longer builds for me. Here's what I get: http://pastebin.com/YiXhAvM4
I don't quite understand what's wrong here and how to fix this. Any ideas?

(CC'ing Kohei since he's the only one who has committed to
scmatrix.cxx since then)

Thanks,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] gtk: listbox border was not rendered

[Ruslan Kabatsayev]

Hello,

This mostly looks good, but breaks a bit border for oxygen-gtk (which
somehow has worked before the patch, unlike other themes). Namely, the
border now appears to be 1px while it should be 2px. I'd suggest using
getFrameWidth() to adjust the shadow rect.
OTOH, we've done quite some customizations in oxygen-gtk before to
make it look better with LibO, so maybe this is what should be changed
on oxygen-gtk side.

Regards,
Ruslan

On Fri, Jul 27, 2012 at 9:39 PM, Ivan Timofeev  wrote:
> Hi!
>
> there was a discussion about ugly listboxes in gtk theming, and we
> decided to draw a border:
>
> http://nabble.documentfoundation.org/PATCH-Revert-Set-the-listbox-height-to-an-integer-multiple-of-the-listbox-entry-height-tp3969374p3980299.html
>
> and after a more than 2 month *cough* I have figured out what is wrong.
> The problem is in gtk plugin which does some weird things when drawing
> a listbox (see the description in the patch).
> I have no idea why it does that, git blame shows that it is from the
> initial import. It would be great if someone review the patch, I am
> absolutely not sure.
>
> The famous before.png and after.png are attached.
>
> Thanks!
>
> Ivan
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Native background for some more widgets

[Ruslan Kabatsayev]

On Wed, Jul 25, 2012 at 10:56 PM, Ivan Timofeev  wrote:
> this patch a bit breaks a toolbar look to me. (on Linux, the default
> Ubuntu's Ambiance theme, have not tried on windows, where it is now
> completely broken I guess).

Yes, I can reproduce this. I'll try to fix it asap (so that toolbar bg
is rendered, not window), and if I fail, we'll have to revert this
patch.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH][PUSHED] Native background for some more widgets

[Ruslan Kabatsayev]

On Wed, Jul 25, 2012 at 3:59 PM, Caolán McNamara  wrote:
> Or is there side-effects
> like the calc bottom tabbar stuff that means I shouldn't have pushed
> it :-)

No, these are just background, doesn't change anything for tabs
themselves, so should be safe.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Make default dark shadow non-black

[Ruslan Kabatsayev]

Oops, sorry. Here it is.

On Tue, Jul 17, 2012 at 7:52 PM, Caolán McNamara  wrote:
> On Tue, 2012-07-17 at 18:23 +0400, Ruslan Kabatsayev wrote:
>> Hello,
>>
>> This patch makes some plugins like gtk and kde4 have non-black dark
>> shadow. Black (strict #00) resulted from lack of initialization
>> both in StyleSettings and the plugins themselves. The patch makes dark
>> shadow initialize in StyleSettings so that the plugins can have a
>> reasonable default.
>
> Sounds reasonable, but there was no patch attached ?
>
> C.
>


0004-Make-default-dark-shadow-non-black.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Make default dark shadow non-black

[Ruslan Kabatsayev]

Hello,

This patch makes some plugins like gtk and kde4 have non-black dark
shadow. Black (strict #00) resulted from lack of initialization
both in StyleSettings and the plugins themselves. The patch makes dark
shadow initialize in StyleSettings so that the plugins can have a
reasonable default.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

[Ruslan Kabatsayev]

There is a segfault in the trace. Try running soffice.bin in gdb and
getting a backtrace after crash.

On Tue, Jul 17, 2012 at 12:23 AM, gericom  wrote:

> sorry, here is the one without stdlib
>
> On Mon, Jul 16, 2012 at 6:02 PM, Stephan Bergmann-2 [via Document
> Foundation Mail Archive] <[hidden 
> email]
> > wrote:
>
>> On 07/16/2012 04:55 PM, gericom wrote:
>> > Here is the outpus of strace, sorry didn't thought about it.
>>
>> ...but that's with /opt/libreoffice3.6/ure-link/lib/libstdc++.so.6 still
>> there (so outputting the "version `GLIBCXX_3.4.11' not found" failure).
>>
>> Stephan
>> ___
>> LibreOffice mailing list
>> [hidden email] 
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>>
>> --
>>  If you reply to this email, your message will be added to the
>> discussion below:
>>
>> http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstdc-so-6-version-GLIBCXX-3-4-11-not-found-re-tp3995424p3995858.html
>>  To unsubscribe from Gtk-WARNING **:
>> /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version
>> `GLIBCXX_3.4.11' not found (required by
>> /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so), click
>> here.
>> NAML
>>
>
>
>
> --
> 
>
> Nikola Yanev
> http://www.gericom.free.bg
> http://www.gericom.wordpress.com
> Linux, Mac OS X & Windows installing
> Open Source Software support and translations
> Part of Debian/Ubuntu Bulgarian Translators Team
> PC/Laptops cleaning, PC Hardware/Software reparation/renovation,
> Trainings, Graphical adds., Amateur Photography.
> Mobile:+359885321589
> EUROPE
> Bulgaria
> 8001 Burgas
> 57 "Macedonia" str. 1st floor, 2nd apartment
> ---This mail was sent from Debian KDE by KMail---
> http://userbase.kde.org/KMail
>
> *lo-no-stdc* (2M) Download 
> Attachment
>
> --
> View this message in context: Re: Gtk-WARNING **:
> /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version
> `GLIBCXX_3.4.11' not found (required by
> /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)
> Sent from the Dev mailing list 
> archiveat Nabble.com.
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: A solution to calculation of odd roots of negative numbers with Calc

[Ruslan Kabatsayev]

On Mon, Jul 16, 2012 at 11:13 PM, Albert Thuswaldner
 wrote:
> Sorry, It was a long time since I went to the university, but I if I'm
> correct you want to calculate:
> (-27)^(1/3) (note it is the same as 3x(-1)^(1/3) which to my mind
> results in an complex number (not -3) thus the #VALUE!.
>
> just to double check:
> http://www.wolframalpha.com/input/?i=%28-27%29^%281%2F3%29&lk=4

Well, in fact, there're 3 roots, one of which is -3:
http://www.wolframalpha.com/input/?i=-27%3D%3Da^3


> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Undo Calc TabBar items native rendering

[Ruslan Kabatsayev]

Hello,

As my commit 17ea32a1a36d81a0a12df12adbe15e8eaf1c7c62 breaks tab
coloring functionality, and there's no good enough way to fix it, plus
it is likely to break Windows tabbar items look, this patch reverts
that commit.

Regards,
Ruslan


0004-Revert-Make-bottom-tabbar-items-follow-native-theme.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

[Ruslan Kabatsayev]

What if you set SAL_USE_VCLPLUGIN=gen before starting soffice? What if
you remove oxygen-gtk having stdlibs installed?

On Sat, Jul 14, 2012 at 4:46 PM, Nikola Yanev  wrote:
> I have already tried that,but then it just won't start. No error is thrown
> in the terminal.
>
> On Jul 14, 2012 3:41 PM, "Ruslan Kabatsayev"  wrote:
>>
>> Then just don't install *stdlibs* package from the package set you've
>> downloaded.
>>
>> On Sat, Jul 14, 2012 at 4:39 PM, Nikola Yanev 
>> wrote:
>> > I am talking about the one downloaded from the doc.foundation preleases.
>> >
>> > On Jul 14, 2012 12:47 PM, "Ruslan Kabatsayev" 
>> > wrote:
>> >>
>> >> Hi,
>> >>
>> >> You should compile LO with --with-system-stdlibs to make plugins
>> >> (oxygen-gtk theme) not conflict with custom stdc++.
>> >>
>> >> Regards,
>> >> Ruslan
>> >>
>> >> On Sat, Jul 14, 2012 at 12:37 PM, gericom 
>> >> wrote:
>> >> > Gtk-WARNING **:
>> >> > /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6:
>> >> > version `GLIBCXX_3.4.11' not found (required by
>> >> > /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)
>> >> >
>> >> > If i am using the local version of libstdc++.so.6 LO doesn't want
>> >> > even
>> >> > to
>> >> > start, but with the lo preinstalled libstdc++ it's just giving me
>> >> > that
>> >> > error
>> >> > and crashing.
>> >> >
>> >> > LibreOffice 3.6.0-RC1 on Debian unstable
>> >> >
>> >> > Also tried with new profiles and so on...
>> >> >
>> >> > Thanx,
>> >> > Nikola Yanev
>> >> >
>> >> > --
>> >> > View this message in context:
>> >> >
>> >> > http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstdc-so-6-version-GLIBCXX-3-4-11-not-found-re-tp3995424.html
>> >> > Sent from the Dev mailing list archive at Nabble.com.
>> >> > ___
>> >> > LibreOffice mailing list
>> >> > LibreOffice@lists.freedesktop.org
>> >> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

[Ruslan Kabatsayev]

Then just don't install *stdlibs* package from the package set you've
downloaded.

On Sat, Jul 14, 2012 at 4:39 PM, Nikola Yanev  wrote:
> I am talking about the one downloaded from the doc.foundation preleases.
>
> On Jul 14, 2012 12:47 PM, "Ruslan Kabatsayev"  wrote:
>>
>> Hi,
>>
>> You should compile LO with --with-system-stdlibs to make plugins
>> (oxygen-gtk theme) not conflict with custom stdc++.
>>
>> Regards,
>> Ruslan
>>
>> On Sat, Jul 14, 2012 at 12:37 PM, gericom 
>> wrote:
>> > Gtk-WARNING **:
>> > /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6:
>> > version `GLIBCXX_3.4.11' not found (required by
>> > /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)
>> >
>> > If i am using the local version of libstdc++.so.6 LO doesn't want even
>> > to
>> > start, but with the lo preinstalled libstdc++ it's just giving me that
>> > error
>> > and crashing.
>> >
>> > LibreOffice 3.6.0-RC1 on Debian unstable
>> >
>> > Also tried with new profiles and so on...
>> >
>> > Thanx,
>> > Nikola Yanev
>> >
>> > --
>> > View this message in context:
>> > http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstdc-so-6-version-GLIBCXX-3-4-11-not-found-re-tp3995424.html
>> > Sent from the Dev mailing list archive at Nabble.com.
>> > ___
>> > LibreOffice mailing list
>> > LibreOffice@lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

[Ruslan Kabatsayev]

Hi,

You should compile LO with --with-system-stdlibs to make plugins
(oxygen-gtk theme) not conflict with custom stdc++.

Regards,
Ruslan

On Sat, Jul 14, 2012 at 12:37 PM, gericom  wrote:
> Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6:
> version `GLIBCXX_3.4.11' not found (required by
> /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)
>
> If i am using the local version of libstdc++.so.6 LO doesn't want even to
> start, but with the lo preinstalled libstdc++ it's just giving me that error
> and crashing.
>
> LibreOffice 3.6.0-RC1 on Debian unstable
>
> Also tried with new profiles and so on...
>
> Thanx,
> Nikola Yanev
>
> --
> View this message in context: 
> http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstdc-so-6-version-GLIBCXX-3-4-11-not-found-re-tp3995424.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Calc's tab colors and GTK tabs

[Ruslan Kabatsayev]

Hi,

It seems there's no easy way for this. Some themes, e.g. QtCurve and
oxygen-gtk, don't have special color inside tabs (like Clearlooks or
Glossy have), and all we can do with them is rendering the colored
background and then the tabs, so we'll get ugly squares under tabs
(and I'm not sure if QtCurve has similar "translucent" tabs with
respect to background as oxygen-gtk).

One way around this might be to render translucent rounded rectangle
fading to its borders under the text, but I guess this would look ugly
for most themes.

So, maybe it was a bad idea to render tabs in native way at all. Maybe
we should just try to develop a generic tab look, which wouldn't look
as prehistoric as old ones did, and not follow native style (native
styles already don't have trapezoid shaped tabs)?

> Do you think this regression would be something you could take care of, 
> should someone else tackle this?
I think I'll take care of it as soon as I have some ideas on how to do
this best. I'd like to hear from someone else what they think.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ONGERRIT] Better center status bar items between separators

[Ruslan Kabatsayev]

Hi Bjoern,

It seems you haven't pushed this patch to review, your link says about
another patch.

Thanks,
Ruslan


On Mon, Jul 9, 2012 at 12:23 PM, Bjoern Michaelsen
 wrote:
> On Sun, Jul 08, 2012 at 09:34:18PM +0400, Ruslan Kabatsayev wrote:
>> This patch fixes status bar separators position so that status bar
>> items appears better centered between them.
>> As a side effect, it also gives more space for rendering separators
>> for themes which have thicker separators than 2px.
>
> Pushed to gerrit for review at:
>
> https://gerrit.libreoffice.org/268
>
> Best,
>
> Bjoern
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Native background for some more widgets

[Ruslan Kabatsayev]

Hello,

These patches make TabBar and ToolBox have correct native background
(needed for bg gradients and other non-flat-colored backgrounds).

Regards,
Ruslan


0002-Use-native-theme-to-draw-TabBar-background.patch
Description: Binary data


0003-Enable-native-background-rendering-for-ToolBox.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Implement support for treeview headers native rendering, add GTK implementation

[Ruslan Kabatsayev]

Hello again,

I'm sorry, but the second patch was broken, here's fixed version.
Please update the version in gerrit (I haven't yet figured out how to
do this myself).

Thanks,
Ruslan

On Sun, Jul 8, 2012 at 8:55 PM, Bjoern Michaelsen
 wrote:
> Hi Ruslan,
>
> On Sat, Jul 07, 2012 at 10:06:37PM +0400, Ruslan Kabatsayev wrote:
>> These two patches implement support for listview headers (aka
>> HeaderBar) native rendering.
>> First one makes the "buttons" look natively, and second one makes
>> arrow showing sort order also look native.
>> Aside from adding support for this, these patches also add GTK
>> implementation of this.
>
> Pushed as dependant patches:
>
> https://gerrit.libreoffice.org/#/c/265/
> https://gerrit.libreoffice.org/#/c/266/
>
> for review on gerrit.
>
> @Caolan: I would love to have you as a reviewer on this Gtk stuff. Could you
> finally get yourself an account on gerrit(*)?
>
> Best,
>
> Bjoern
>
> (*) https://wiki.documentfoundation.org/Development/gerrit/setup
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


0002-Implement-support-for-HeaderBar-arrow-native-renderi.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Make bottom tabbar items follow native theme

[Ruslan Kabatsayev]

Hello,

This patch makes bottom tabbar items (e.g. the ones switching sheets
in Calc or similar items in Draw) follow native theme (currently seems
only implemented for GTK, but should also be tested with Win32 - most
likely there'll need something to change).

Screenshots for comparison:
before: http://i.imgur.com/OH3lX.png
after: http://i.imgur.com/dMY6t.png

Regards,
Ruslan


0005-Make-bottom-tabbar-items-follow-native-theme.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Better center status bar items between separators

[Ruslan Kabatsayev]

Hello,

This patch fixes status bar separators position so that status bar
items appears better centered between them.
As a side effect, it also gives more space for rendering separators
for themes which have thicker separators than 2px.

Regards,
Ruslan


0003-Better-center-status-bar-items-between-separators.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Implement support for treeview headers native rendering, add GTK implementation

[Ruslan Kabatsayev]

Hello,

These two patches implement support for listview headers (aka
HeaderBar) native rendering.
First one makes the "buttons" look natively, and second one makes
arrow showing sort order also look native.
Aside from adding support for this, these patches also add GTK
implementation of this.

Regards,
Ruslan


0001-Implement-support-for-listview-headers-native-render.patch
Description: Binary data


0002-Implement-support-for-HeaderBar-arrow-native-renderi.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix check for FRAME_DRAW_NWF and regression in CTRL_FRAME support

[Ruslan Kabatsayev]

Hello,

Commit 504e41016004fb2edebdb29a85d69084b1d6 breaks almost all the
support for CTRL_FRAME because of incorrect check for FRAME_DRAW_NWF.
It checks for it as if this were a single bit flag, but its value is
0x7, so it should be compared against its value after bitwise AND.

I'm attaching a patch which fixes this regression.

Regards,
Ruslan


0001-Fix-check-for-FRAME_DRAW_NWF-and-thus-reenable-CTRL_.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] GTK: don't crash on X errors

[Ruslan Kabatsayev]

Thanks for pushing. Would be good if this patch got into 3.5.5 and 3.6 as well.

On Mon, Jun 18, 2012 at 6:37 PM, Fridrich Strba
 wrote:
> On 18/06/12 15:27, Ruslan Kabatsayev wrote:
>> Hello,
>>
>> This patch disables GDK's default behaviour of abort() on X errors
>> such as BadAtom etc.. It'll just ignore such errors.
>> Rationale:
>> 1. KDE4 and GEN plugins ignore the X erorrs
>> 2. X errors may be unavoidable in some cases, like when wrong Atom is
>> returned in XConvertSelection/SelectionNotify
>>
>> This will fix fdo#50920 and invalidate my message
>> http://lists.freedesktop.org/archives/libreoffice/2012-June/033550.html
>> .
>>
>> Regards,
>> Ruslan
>>
>>
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK: don't crash on X errors

[Ruslan Kabatsayev]

Hello,

This patch disables GDK's default behaviour of abort() on X errors
such as BadAtom etc.. It'll just ignore such errors.
Rationale:
1. KDE4 and GEN plugins ignore the X erorrs
2. X errors may be unavoidable in some cases, like when wrong Atom is
returned in XConvertSelection/SelectionNotify

This will fix fdo#50920 and invalidate my message
http://lists.freedesktop.org/archives/libreoffice/2012-June/033550.html
.

Regards,
Ruslan


0002-GTK-don-t-crash-on-X-errors.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Need help with fdo#50920

[Ruslan Kabatsayev]

Hello,

As I've found with fdo#50920, if I've understood
XConvertSelection/SelectionNotify mechanism correctly, it's selection
owner (Mathematica in this case) who converts the selection to our
target type, and it appears that last (15th) atom is always corrupt
with Mathematica. Qt and GEN plugins don't have these crashes because
they don't abort() on X errors. So, it seems we should just use
gdk_error_trap_push() to prevent crashes with GTK plugin.
So, below is a trivial patch which solves two cases of crashes with
Mathematica. But I now have a question: should we maybe just call
gdk_error_trap_push() on GTK initialization and just ignore any X
errors in any context, or should we limit at what the patch does?

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 4d58110..86d3f56 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -839,8 +839,10 @@ extern "C" {
 sal_gtk_timeout_defer( pTSource );

 ImplSVData* pSVData = ImplGetSVData();
+gdk_error_trap_push();
 if( pSVData->mpSalTimer )
 pSVData->mpSalTimer->CallCallback();
+gdk_error_trap_pop();

 return TRUE;
 }
@@ -941,7 +943,9 @@ gboolean GtkData::userEventFn( gpointer data )

 pThis->GetGtkDisplay()->EventGuardRelease();

+gdk_error_trap_push();
 pThis->GetGtkDisplay()->DispatchInternalEvent();
+gdk_error_trap_pop();
 }

 return bContinue;


Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix arguments to Rectangle constructor in GtkSalSystem::GetDisplayScreenPosSizePixel()

[Ruslan Kabatsayev]

Hello,

This patch fixes at least fdo#46469, and maybe also (looking like
duplicates) fdo#48168 and fdo#48321.
The bug was because width & height were passed instead of right &
bottom arguments. (The bug affects 3.5.x and current master).

Regards,
Ruslan


0001-Fix-arguments-of-Rectangle-constructor.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6] Re: Some GTK theming related commits and 3.6 release

[Ruslan Kabatsayev]

Thank you

On Fri, Jun 15, 2012 at 5:24 PM, Fridrich Strba
 wrote:
> I did take care of them
>
> Cheers
>
> F.
>
> On 15/06/12 13:47, Ruslan Kabatsayev wrote:
>> Hello,
>>
>> I've added some summary of GTK theming changes to the wiki here
>> http://wiki.documentfoundation.org/ReleaseNotes/3.6#GUI, but it seems
>> commits 7d0d52fb758249a7d6b8fc5e36c0e77354e5f5c3 and
>> 866599ab5ce091de56094d4d458e010ba56d22d0 haven't been added
>> (cherry-picked/merged or whatever) to libreoffice-3-6 branch, while
>> they were supposed to appear in 3.6. Is it OK? Could someone take care
>> of them?
>>
>> Regards,
>> Ruslan
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Some GTK theming related commits and 3.6 release

[Ruslan Kabatsayev]

Hello,

I've added some summary of GTK theming changes to the wiki here
http://wiki.documentfoundation.org/ReleaseNotes/3.6#GUI, but it seems
commits 7d0d52fb758249a7d6b8fc5e36c0e77354e5f5c3 and
866599ab5ce091de56094d4d458e010ba56d22d0 haven't been added
(cherry-picked/merged or whatever) to libreoffice-3-6 branch, while
they were supposed to appear in 3.6. Is it OK? Could someone take care
of them?

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: help with git commit

[Ruslan Kabatsayev]

Hi,

Trailing whitespace isn't the same as empty line. Most likely some of
you lines end with a space. This could be like "some text   " instead
of "some text", or line which looks like empty, but isn't: "   "
instead of "".

Regards,
Ruslan

On Sun, Jun 10, 2012 at 9:41 PM, Olivier Hallot
 wrote:
> Hi
>
> I am trying to commit a xml file with blank lines iserted for readbility.
>
> When I issue the git commit, it complains empty lines are a no-no.
>
> Is there a way to override this feature?
>
>
> tdf@olivier-Vostro-3500:~/git/core/dictionaries/pt_BR$ git commit
> --author="Raimundo Moura " description.xml
> dictionaries.xcu hyph_pt_BR.dic manifest.xml pt_BR.aff pt_BR.dic
> README_en.txt README_hyph_pt_BR.txt README_pt_BR.txt
> *
> * You have some suspicious patch lines:
> *
> * In dictionaries/pt_BR/description.xml
> * trailing whitespace (line 12)
> dictionaries/pt_BR/description.xml:12:
> * trailing whitespace (line 17)
> dictionaries/pt_BR/description.xml:17:
> * trailing whitespace (line 28)
> dictionaries/pt_BR/description.xml:28:
> * trailing whitespace (line 39)
> dictionaries/pt_BR/description.xml:39:
> * trailing whitespace (line 42)
> dictionaries/pt_BR/description.xml:42:
> * trailing whitespace (line 48)
> dictionaries/pt_BR/description.xml:48:
> * trailing whitespace (line 49)
> dictionaries/pt_BR/description.xml:49:
> * trailing whitespace (line 51)
> dictionaries/pt_BR/description.xml:51:
> * trailing whitespace (line 52)
> dictionaries/pt_BR/description.xml:52:     Olivier Hallot
> Founder and Steering Commitee Member
> The Document Foundation
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: implement FixedLine rendering

[Ruslan Kabatsayev]

Hello,

This patch implements support for native rendering of FixedLine, and
makes use of it in GTK theming plugin.
This makes vertical and horizontal lines look native in e.g. grouping
widgets (like Tools->Options->User data->Address) and statusbar
separators.

Change might be not as visible with usual themes like Clearlooks or
Glossy, but is greately changed with oxygen-gtk and QtCurve.

Regards,
Ruslan


0002-Implement-native-FixedLine-render-add-GTK-support-fo.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: render background correctly for widgets without GTK parent

[Ruslan Kabatsayev]

Hello,

This patch allows the GTK theme to render background pattern correctly
for LO widgets which pass GdkPixmap instead of true GdkWindow for
rendering.
Without this patch these widgets have no theme-visible position on the
window, thus making the theme unable to properly render their
background.

Regards,
Ruslan


0001-Render-bg-correctly-for-widgets-without-theme-visibl.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] GTK theming: implement frame rendering

[Ruslan Kabatsayev]

Hi,

Yes, I'll do, but first I need to logically finalize my series of
patches, namely enable correct bg rendering for several widgets, for
which the theme can't compute their position relative to the window
(which is crucial for bg gradient).
I hope to do this before the release.

Regards,
Ruslan

On Wed, Jun 6, 2012 at 1:53 PM, Michael Meeks  wrote:
> Hi Ruslan,
>
> On Sat, 2012-06-02 at 16:12 +0400, Ruslan Kabatsayev wrote:
>> This patch implements frame rendering via GTK theme.
>> This way we get rid of those ugly square black/gray frames we had all
>> over the place and replace them with native frames.
>
>        Any chance you can put a nice summary of what you've worked on here:
>
>        http://wiki.documentfoundation.org/ReleaseNotes/3.6
>
>        Thanks ! :-)
>
>                Micahel.
>
> --
> michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: implement frame rendering

[Ruslan Kabatsayev]

Hello,

This patch implements frame rendering via GTK theme.
This way we get rid of those ugly square black/gray frames we had all
over the place and replace them with native frames.

Regards,
Ruslan


0001-GTK-theming-implement-frame-rendering.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix operator precedence error

[Ruslan Kabatsayev]

Hello,

This patch fixes an operator precedence error which leads to
ImplDrawFrame() in decoview.cxx always pass 0x40 instead of correct
nStyle.
The effect of the bug is visible in e.g. lack of combobox dropdown
list frames and very thin optionmenu buttons in kde4 integration.

Regards,
Ruslan


0001-Fix-operator-precedence-error.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] GTK theming plugin: a little cleanup

[Ruslan Kabatsayev]

On Fri, Jun 1, 2012 at 3:36 PM, Michael Meeks  wrote:
>        And it's pure re-factor ? [ I hope so ].
Yes, just refactor.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming plugin: a little cleanup

[Ruslan Kabatsayev]

Hello,

This patch converts that awful if statement with lots of nested
parentheses to switch structure.
I think everyone will agree that this improves readability and
decreases chances of making mistake while editing it.

Regards,
Ruslan


0002-GTK-theming-plugin-convert-big-if-statement-to-switc.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: tab prelight, not breaking unaware themes

[Ruslan Kabatsayev]

Hello,

Here's a new variant of tab prelight implementation, which now doesn't
break themes which are unaware of it.

Regards,
Ruslan


0001-Gtk-theming-pass-tab-prelight-state-to-theme.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEWED] GTK theming: tab prelight

[Ruslan Kabatsayev]

Hello,

On Thu, May 31, 2012 at 3:08 PM, Michael Meeks  wrote:
>
>        Yep - so; I'm rather less sure about this patch. If I run gedit, I get
> no pre-lighting behaviour for tabs, and while I can see the attraction
> of a prelight, it makes rather a startling and (IMHO) unpleasant effect
> at least with my default theme - since the tab is rendered as if it is
> in the foreground behind the others, there is a rectangular cut-off
> there that looks a tad unpleasant, cf. the attached.

OK, I was expecting that some themes might appear to look bad.
I have another way of implementing prelight, namely, pass a GObject
data indicating that the tab should be prelit.
This would look like this
"g_object_set_data(G_OBJECT(gdkDrawable),"LibreOffice tab is
prelit",TRUE);", then after calling style paint method, do
g_obect_steal_data() with this key.
This way, the themes which are unaware of this data, won't render any
tab prelight, while those which are, will draw it nicely.

>
>        Is there a better way to achieve the same end ? :-) (and/or any nice
> pictures of your preferred theme)

Here's the screenshot of how this looks with oxygen-gtk (git branch
"libreoffice"):
http://simplest-image-hosting.net/png-0-screenshot-05282012-03-pm
Toolbars tab is prelit.

(Bg gradient is drawn thanks to another patch, and yet some patches
are waiting to be sent)

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] GTK theme toolbar button rendering

[Ruslan Kabatsayev]

Hi,

On Mon, May 28, 2012 at 11:08 AM, David Tardon  wrote:
> On Sat, May 26, 2012 at 09:40:49PM +0400, Ruslan Kabatsayev wrote:
>> Hello,
>>
>> Current GTK theming plugin renders toolbar buttons as non-flat
>> unconditionally. But some themes, e.g. oxygen-gtk expect toolbuttons
>> to be flat, and the desktop integration fails.
>> I'm attaching a patch to fix this. The patch has been tested with
>> oxygen-gtk(current master), QtCurve-GTK, Glossy and Simple themes.
>
> Hi,
>

>> +    if(GTK_IS_TOGGLE_BUTTON(button))
>> +    {
>> +       if(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(button)))
>
> This is equivalent to "if(nState & CTRL_STATE_PRESSED)", is it not?

It's not equivalent since this code checks if the button is
toggled-down (like e.g. Align Left button in Formatting toolbar).
CTRL_STATE_PRESSED, OTOH, means that the button is being pressed by
the mouse, and doesn't take toggled state into account.
This state of toggle button is set in NWPaintGTKToolbar() on
aValue.getTristateVal()==BUTTONVALUE_ON to make rendering correct.
Togglebuttons in toolbars have a bit more states, e.g. toggled and
prelit, toggled and not prelit, pressed, etc., so they should be
handled differently from usual press buttons.

>> +           shadowType=GTK_SHADOW_IN;
>> +       else
>> +           shadowType=GTK_SHADOW_OUT;
>> +
>> +       if(nState & CTRL_STATE_ROLLOVER)
>> +           stateType=GTK_STATE_PRELIGHT;
>> +       else
>> +           stateType=GTK_STATE_NORMAL;
>> +
>> +       if(nState & CTRL_STATE_PRESSED)
>> +       {
>> +           stateType=GTK_STATE_ACTIVE;
>> +           shadowType=GTK_SHADOW_IN;
>> +       }
>> +    }
>
> It seems to me that this code could be used in
> NWConvertVCLStateToGTKState (with the above modification), so there
> would be no need for toggle button-specific code branch. Or am I missing
> something?

If this is moved to NWConvertVCLStateToGTKState, a new argument (set
default to 0 for other callers) would be needed for this function,
namely, GtkWidget* button. Or, if we don't want to rely on toggle
button state, we'll have to pass ImplControlValue& aValue and do this
check there.
Not sure if this is really better... Do you think this still should be done?

>
> D.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] GTK theming: implement window background rendering

[Ruslan Kabatsayev]

Forgot the patch itself

On Mon, May 28, 2012 at 2:31 AM, Ruslan Kabatsayev
 wrote:
> Hello,
>
> This patch implements window background rendering for GTK integration.
> It makes it possible for themes to render custom window background,
> e.g. with gradient or bg image.
>
> Regards,
> Ruslan


0003-GTK-theming-implement-rendering-window-background.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: implement window background rendering

[Ruslan Kabatsayev]

Hello,

This patch implements window background rendering for GTK integration.
It makes it possible for themes to render custom window background,
e.g. with gradient or bg image.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theming: tab prelight

[Ruslan Kabatsayev]

Hello,

It seems it won't hurt if GTK themes could do some way of prelighting
of inactive tabs on mouse hover. Although GTK doesn't support tab
prelighting, we may be able to pass GTK_STATE_PRELIGHT instead of
usual GTK_STATE_ACTIVE for inactive tabs.
This has a side effect though: some themes which don't support
GTK_STATE_PRELIGHT, render the tabs as active, but smaller in size.
Though it isn't quite correct from POV of those themes, it still gives
the user feedback that the tab is "alive" and clickable. Other themes,
which will be aware of this behavior, will render nice prelit tabs (I
plan to implement this in oxygen-gtk).
So, I'm attaching a patch which will do what's described above.

Another approach would be setting GObject data which would tell the
theme that tab is prelit. In this case no theme will render inactive
tabs as active, but prelight will only work with those themes which
are aware of this GObject data.

Regards,
Ruslan


0002-GTK-theming-pass-tab-prelight-state-to-theme-on-CTRL.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] GTK theme toolbar button rendering

[Ruslan Kabatsayev]

Hello,

Current GTK theming plugin renders toolbar buttons as non-flat
unconditionally. But some themes, e.g. oxygen-gtk expect toolbuttons
to be flat, and the desktop integration fails.
I'm attaching a patch to fix this. The patch has been tested with
oxygen-gtk(current master), QtCurve-GTK, Glossy and Simple themes.

Regards,
Ruslan


0001-GTK-theming-fix-rendering-of-toolbuttons.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

License statement

[Ruslan Kabatsayev]

Hello,

All of my past & future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.

Regards,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix autogen.sh configuration when ACLOCAL_FLAGS are non-empty

[Ruslan Kabatsayev]

Hello all.

Current autogen.sh only sets "-I ./m4" when ACLOCAL_FLAGS are empty,
leading to problems with expansion of libo_MINGW_CHECK_DLL macro.
As people on IRC have said, it should append this option to existing
flags. So, I'm attaching a patch which fixes this.

Regards,
Ruslan


0001-autogen.sh-append-aclocal-arguments-to-ACLOCAL_FLAGS.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice