New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1603563: Error handling issues (CHECKED_RETURN)
/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx: 688 in
ScAccessibleSpreadsheet::Notify(SfxBroadcaster &, const SfxHint &)()
*** CID 1603563: Error handling issues (CHECKED_RETURN)
/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx: 688 in
ScAccessibleSpreadsheet::Notify(SfxBroadcaster &, const SfxHint &)()
682 {
683 OUString
valStr(pScDoc->GetString(aNewCell.Col(),aNewCell.Row(),aNewCell.Tab()));
684 if(m_strCurCellValue != valStr)
685 {
686 uno::Any aOldValue;
687 uno::Any aNewValue;
>>> CID 1603563: Error handling issues (CHECKED_RETURN)
>>> Calling "implInitTextChangedEvent" without checking return value (as is
>>> done elsewhere 7 out of 8 times).
688
comphelper::OCommonAccessibleText::implInitTextChangedEvent(m_strCurCellValue,
valStr, aOldValue, aNewValue);
689 AccessibleEventObject aTextChangedEvent;
690 aTextChangedEvent.EventId =
AccessibleEventId::TEXT_CHANGED;
691 aTextChangedEvent.OldValue = aOldValue;
692 aTextChangedEvent.NewValue = aNewValue;
693 mpAccCell->CommitChange(aTextChangedEvent);
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D2yhF_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtmVoA1ZVpVtHQewmxaxpP10IOsJWFFHZ1AWjnb-2BNn4Dm5uyy5rIiKxQhMDSKKdArZJmQsaQdkJf7dCm-2BsgvDhmKs6cjEsTI1PB833ifS08gUSajunuSq7tgJZ0ZJKQwCpl2ukeBgr4z38hc7rWcKXJH5wyNr4mWuBBccK7hBRXvY-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1603200: Uninitialized variables (UNINIT)
*** CID 1603200: Uninitialized variables (UNINIT)
/sc/source/filter/excel/xelink.cxx: 2022 in
::XclExpSupbookBuffer::InsertDde(const rtl::OUString &, const
rtl::OUString &, const rtl::OUString &)()
2016 xSupbook = new XclExpSupbook( GetRoot(), rApplic, rTopic );
2017 nSupbook = Append(xSupbook);
2018 }
2019 auto nExtName = xSupbook->InsertDde( rItem );
2020 if (nExtName > 0)
2021 {
>>> CID 1603200: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nSupbook" when calling "make_pair".
2022 return std::make_pair(nSupbook, nExtName);
2023 }
2024 return {};
2025 }
2026
2027 std::optional>
XclExpSupbookBuffer::InsertExtName( const OUString& rUrl,
** CID 1603199: Uninitialized variables (UNINIT)
*** CID 1603199: Uninitialized variables (UNINIT)
/sc/source/filter/excel/xelink.cxx: 2041 in
::XclExpSupbookBuffer::InsertExtName(const rtl::OUString &, const
rtl::OUString &, const std::shared_ptr &)()
2035 nSupbook = Append(xSupbook);
2036 }
2037
2038 auto nExtName = xSupbook->InsertExtName(rName, rArray);
2039 if (nExtName > 0)
2040 {
>>> CID 1603199: Uninitialized variables (UNINIT)
>>> Using uninitialized value "nSupbook" when calling "make_pair".
2041 return std::make_pair(nSupbook, nExtName);
2042 }
2043 return {};
2044 }
2045
2046 XclExpXti XclExpSupbookBuffer::GetXti( sal_uInt16 nFileId, const
OUString& rTabName, sal_uInt16 nXclTabSpan,
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DWDrN_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtS6TN8LX7QGFG9uikw6XI2zN6rAMQYUUfPYNRE04m2gT7LFO3nhJadEx-2BHqJuW4uZbbcOK6zeVIY4kkYzITeyFlubFnkVSvt4Po-2Brl121K2zZLBYbThYE4q0hsKXqbcwnv-2FeYx2fSQ-2BYc7GiOjnUH6htvBxT6CAQ66SqWGsdX9-2FU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
9 new defect(s) introduced to LibreOffice found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)
** CID 1602450: Null pointer dereferences (FORWARD_NULL)
*** CID 1602450: Null pointer dereferences (FORWARD_NULL)
/sw/source/filter/ww8/wrtww8gr.cxx: 149 in WW8Export::TestOleNeedsGraphic(const
SwAttrSet &, const rtl::Reference &, const
rtl::Reference &, const rtl::OUString &, SwOLENode *)()
143 0,
144 nAspect,
145 m_pWriter->GetBaseURL());
146
147 if (pRet)
148 {
>>> CID 1602450: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pOLENd->GetOLEObj()" to "GetOleRef", which
>>> dereferences it.
149 uno::Reference< embed::XEmbeddedObject > xObj =
pOLENd->GetOLEObj().GetOleRef();
150 if ( xObj.is() )
151 {
152 std::unique_ptr pGraphicStream;
153 comphelper::EmbeddedObjectContainer aCnt(
m_rDoc.GetDocStorage() );
154 try
** CID 1602449: Resource leaks (RESOURCE_LEAK)
/sw/source/core/doc/docsort.cxx: 457 in SwDoc::SortText(const SwPaM &, const
SwSortOptions &)()
*** CID 1602449: Resource leaks (RESOURCE_LEAK)
/sw/source/core/doc/docsort.cxx: 457 in SwDoc::SortText(const SwPaM &, const
SwSortOptions &)()
451 GetIDocumentUndoRedo().DoUndo( bUndo );
452 if( bUndo )
453 {
454 GetIDocumentUndoRedo().EndUndo( SwUndoId::END, nullptr );
455 }
456
>>> CID 1602449: Resource leaks (RESOURCE_LEAK)
>>> Variable "pRedlUndo" going out of scope leaks the storage it points to.
457 return true;
458 }
459
460 /// Sort Table in the Document
461 bool SwDoc::SortTable(const SwSelBoxes& rBoxes, const SwSortOptions&
rOpt)
462 {
** CID 1602448: Error handling issues (CHECKED_RETURN)
/sw/source/filter/html/htmlplug.cxx: 837 in SwHTMLParser::NewObject()()
*** CID 1602448: Error handling issues (CHECKED_RETURN)
/sw/source/filter/html/htmlplug.cxx: 837 in SwHTMLParser::NewObject()()
831
832 m_pAppletImpl->SetAltText( aStandBy );
833
834 SfxItemSet aItemSet( m_xDoc->GetAttrPool(),
m_pCSS1Parser->GetWhichMap() );
835 SvxCSS1PropertyInfo aPropInfo;
836 if( HasStyleOptions( aStyle, aId, aClass ) )
>>> CID 1602448: Error handling issues (CHECKED_RETURN)
>>> Calling "ParseStyleOptions" without checking return value (as is done
>>> elsewhere 18 out of 22 times).
837 ParseStyleOptions( aStyle, aId, aClass, aItemSet, aPropInfo );
838
839 SfxItemSet& rFrameSet = m_pAppletImpl->GetItemSet();
840 if( !IsNewDoc() )
841 Reader::ResetFrameFormatAttrs( rFrameSet );
842
** CID 1602447: Error handling issues (CHECKED_RETURN)
/sw/source/filter/html/htmlgrin.cxx: 566 in SwHTMLParser::InsertImage()()
*** CID 1602447: Error handling issues (CHECKED_RETURN)
/sw/source/filter/html/htmlgrin.cxx: 566 in SwHTMLParser::InsertImage()()
560 }
561 }
562
563 SfxItemSet aItemSet( m_xDoc->GetAttrPool(),
m_pCSS1Parser->GetWhichMap() );
564 SvxCSS1PropertyInfo aPropInfo;
565 if( HasStyleOptions( aStyle, aId, aClass ) )
>>> CID 1602447: Error handling issues (CHECKED_RETURN)
>>> Calling "ParseStyleOptions" without checking return value (as is done
>>> elsewhere 18 out of 22 times).
566 ParseStyleOptions( aStyle, aId, aClass, aItemSet, aPropInfo );
567
568 SfxItemSetFixed aFrameSet(
m_xDoc->GetAttrPool() );
569 if( !IsNewDoc() )
570 Reader::ResetFrameFormatAttrs( aFrameSet );
571
** CID 1602446: Error handling issues (CHECKED_RETURN)
/sc/source/core/tool/dbdata.cxx: 1601 in ScDBCollection::CopyToTable(short,
short)()
*** CID 1602446: Error handling issues (CHECKED_RETURN)
/sc/source/core/tool/dbdata.cxx: 1601 in ScDBCollection::CopyToTable(short,
short)()
1595 for (const auto& rxNamedDB : aTemp)
1596 {
1597 const OUString newName( lcl_IncrementNumberInNamedRange(
maNamedDBs, rxNamedDB->GetName()));
1598 std::unique_ptr
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1598442:(NULL_RETURNS)
*** CID 1598442:(NULL_RETURNS)
/sc/source/ui/undo/undotab.cxx: 478 in ScUndoDeleteTab::Redo()()
472 pViewShell->SetTabNo( lcl_GetVisibleTabBefore( rDoc, theTabs[0]
), true );
473 }
474
475 void ScUndoDeleteTab::Redo()
476 {
477 ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
>>> CID 1598442:(NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pViewShell" when
>>> calling "SetTabNo".
478 pViewShell->SetTabNo( lcl_GetVisibleTabBefore(
pDocShell->GetDocument(), theTabs.front() ) );
479
480 RedoSdrUndoAction( pDrawUndo.get() ); // Draw Redo first
481
482 pDocShell->SetInUndo( true ); //! BeginRedo
483 bDrawIsInUndo = true;
/sc/source/ui/undo/undotab.cxx: 494 in ScUndoDeleteTab::Redo()()
488 SetChangeTrack();
489
490 if (comphelper::LibreOfficeKit::isActive() && !theTabs.empty())
491 {
492 ScDocument& rDoc = pDocShell->GetDocument();
493 lcl_OnTabsChanged(pViewShell, rDoc, theTabs[0]);
>>> CID 1598442:(NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pViewShell" when
>>> calling "lcl_UndoCommandResult".
494 lcl_UndoCommandResult(pViewShell, ".uno:Redo",
"ScUndoDeleteTab", );
495 }
496
497 // SetTabNo(...,sal_True) for all views to sync with drawing layer
pages
498 pDocShell->Broadcast( SfxHint( SfxHintId::ScForceSetTab ) );
499 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D8GvR_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtRs21SpJYxmEuHcCNhcR6c2tEPVHJ65guYKM4Ndwr1MNRYtDZQIeZ4FHqrwgR8A6a-2FMtHkLxB9P7Tg9BlmL8Gb9lHdjjuhjwxanr82a-2BkpDGYn65fZ6MLs77Qcl3YijxYNKlME2ihprY0BQiI4eijTqQqpdrlmTegCjwXIpHHorM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1598293: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unotbl.cxx: 2716 in
SwXTextTable::getPropertyValue(const rtl::OUString &)()
*** CID 1598293: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unotbl.cxx: 2716 in
SwXTextTable::getPropertyValue(const rtl::OUString &)()
2710 }
2711 break;
2712
2713 case FN_UNO_ANCHOR_TYPES:
2714 case FN_UNO_TEXT_WRAP:
2715 case FN_UNO_ANCHOR_TYPE:
>>> CID 1598293: Error handling issues (CHECKED_RETURN)
>>> Calling "GetDefaultTextContentValue" without checking return value (as
>>> is done elsewhere 8 out of 10 times).
2716 ::sw::GetDefaultTextContentValue(
2717 aRet, u"", pEntry->nWID);
2718 break;
2719
2720 case FN_UNO_RANGE_ROW_LABEL:
2721 {
** CID 1598292: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unosect.cxx: 1610 in
SwXTextSection::getPropertyDefault(const rtl::OUString &)()
*** CID 1598292: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unosect.cxx: 1610 in
SwXTextSection::getPropertyDefault(const rtl::OUString &)()
1604 case WID_SECT_EDIT_IN_READONLY:
1605 aRet <<= false;
1606 break;
1607 case FN_UNO_ANCHOR_TYPES:
1608 case FN_UNO_TEXT_WRAP:
1609 case FN_UNO_ANCHOR_TYPE:
>>> CID 1598292: Error handling issues (CHECKED_RETURN)
>>> Calling "GetDefaultTextContentValue" without checking return value (as
>>> is done elsewhere 8 out of 10 times).
1610 ::sw::GetDefaultTextContentValue(aRet, u"", pEntry->nWID);
1611 break;
1612 default:
1613 if(pFormat && SfxItemPool::IsWhich(pEntry->nWID))
1614 {
1615 SwDoc *const pDoc = pFormat->GetDoc();
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D5zYB_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtKmWXHLXD2K1QR2E0we2gMn5wcMxInQlUK6dDYna68JKILfgHJ5fmdUrDHNAjyeGutssgC6UiOf3tTplNaaWmgR4ovfqIIraxT06EMYD0X41RbLLR5QRgxgg7vjSA-2F1Ed1jqyi5AINm1rErKe3iTaVZYIE5torCQxPe-2BzmomAgj4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 608 in ::DemoApp::Main()()
*** CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 608 in ::DemoApp::Main()()
602 void Init() override;
603 void DeInit() override;
604 };
605
606 }
607
>>> CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "::DemoApp::Main()" an exception of type
>>> "com::sun::star::uno::DeploymentException" is thrown and never caught.
608 int DemoApp::Main()
609 {
610 bool bHelp = false;
611
612 for( unsigned int i = 0; i < GetCommandLineParamCount(); i++ )
613 {
** CID 1598236: Error handling issues (CHECKED_RETURN)
/sw/source/uibase/app/apphdl.cxx: 417 in
::SwMailMergeWizardExecutor::ExecuteMailMergeWizard(const SfxItemSet
*)()
*** CID 1598236: Error handling issues (CHECKED_RETURN)
/sw/source/uibase/app/apphdl.cxx: 417 in
::SwMailMergeWizardExecutor::ExecuteMailMergeWizard(const SfxItemSet
*)()
411 using namespace org::freedesktop::PackageKit;
412 using namespace svtools;
413 css::uno::Reference< XSyncDbusSessionHelper >
xSyncDbusSessionHelper(SyncDbusSessionHelper::create(comphelper::getProcessComponentContext()));
414 const css::uno::Sequence< OUString > vPackages{
"libreoffice-base" };
415 xSyncDbusSessionHelper->InstallPackageNames(vPackages,
OUString());
416 SolarMutexGuard aGuard;
>>> CID 1598236: Error handling issues (CHECKED_RETURN)
>>> Calling "executeRestartDialog" without checking return value (as is
>>> done elsewhere 6 out of 7 times).
417
executeRestartDialog(comphelper::getProcessComponentContext(), nullptr,
RESTART_REASON_MAILMERGE_INSTALL);
418 }
419 catch (const css::uno::Exception &)
420 {
421 TOOLS_INFO_EXCEPTION(
422 "sw.core",
** CID 1598235: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/framework/module/NotesPaneModule.cxx: 45 in
sd::framework::NotesPaneModule::NotesPaneModule(const
rtl::Reference &)()
*** CID 1598235: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/framework/module/NotesPaneModule.cxx: 45 in
sd::framework::NotesPaneModule::NotesPaneModule(const
rtl::Reference &)()
39 NotesPaneModule::NotesPaneModule(const
rtl::Reference<::sd::DrawController>& rxController)
40 : mxBottomImpressPaneId(FrameworkHelper::CreateResourceId(
41 FrameworkHelper::msNotesPanelViewURL,
FrameworkHelper::msBottomImpressPaneURL))
42 ,
mxMainViewAnchorId(FrameworkHelper::CreateResourceId(FrameworkHelper::msCenterPaneURL))
43 {
44 if (!rxController.is())
>>> CID 1598235: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpViewShellBase" is not initialized in this
>>> constructor nor in any functions that it calls.
45 return;
46
47 mpViewShellBase = rxController->GetViewShellBase();
48
49 mxConfigurationController =
rxController->getConfigurationController();
50 if (!mxConfigurationController.is())
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DUNj__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt2K6Hw1GZzA8I67sWF7NG-2BWh2ziA0r8iMXl5wP1qzlfk0Dfqxvgy-2FkqoVaqRqr41NGqxPEjODcl0dG35QNb05uV-2Bnp1CQtO-2B-2BhlHqfXVc8i6Kdeb6DZDPH7nawi1mFkZK9c4xfec5YCSIaJZlPEKtGzv-2BF3fRk2xfl6wFahW9qXc-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1597307: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/misc/asyncmodaldialog.cxx: 68 in
dbauiDialogExecutor_Impl::onExecute(void *)()
*** CID 1597307: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/misc/asyncmodaldialog.cxx: 68 in
dbauiDialogExecutor_Impl::onExecute(void *)()
62 }
63
64 IMPL_LINK_NOARG( DialogExecutor_Impl, onExecute, void*, void )
65 {
66 try
67 {
>>> CID 1597307: Error handling issues (CHECKED_RETURN)
>>> Calling "execute" without checking return value (as is done elsewhere
>>> 32 out of 39 times).
68 m_xDialog->execute();
69 }
70 catch( const Exception& )
71 {
72 DBG_UNHANDLED_EXCEPTION("dbaccess");
73 }
** CID 1597306: Error handling issues (CHECKED_RETURN)
/svx/source/form/fmshimp.cxx: 1394 in
FmXFormShell::ExecuteTabOrderDialog_Lock(const
com::sun::star::uno::Reference &)()
*** CID 1597306: Error handling issues (CHECKED_RETURN)
/svx/source/form/fmshimp.cxx: 1394 in
FmXFormShell::ExecuteTabOrderDialog_Lock(const
com::sun::star::uno::Reference &)()
1388
1389 Reference< dialogs::XExecutableDialog > xDialog =
form::TabOrderDialog::createWithModel(
1390 comphelper::getProcessComponentContext(),
1391 _rxForForm, getControlContainerForView_Lock(),
xParentWindow
1392 );
1393
>>> CID 1597306: Error handling issues (CHECKED_RETURN)
>>> Calling "execute" without checking return value (as is done elsewhere
>>> 32 out of 39 times).
1394 xDialog->execute();
1395 }
1396 catch( const Exception& )
1397 {
1398 TOOLS_WARN_EXCEPTION( "svx",
"FmXFormShell::ExecuteTabOrderDialog" );
1399 }
** CID 1597305: Error handling issues (CHECKED_RETURN)
/sc/source/ui/app/scmod.cxx: 535 in ScModule::Execute(SfxRequest &)()
*** CID 1597305: Error handling issues (CHECKED_RETURN)
/sc/source/ui/app/scmod.cxx: 535 in ScModule::Execute(SfxRequest &)()
529
530 case SID_OPEN_XML_FILTERSETTINGS:
531 {
532 try
533 {
534 css::uno::Reference <
css::ui::dialogs::XExecutableDialog > xDialog =
css::ui::dialogs::XSLTFilterDialog::create(
::comphelper::getProcessComponentContext());
>>> CID 1597305: Error handling issues (CHECKED_RETURN)
>>> Calling "execute" without checking return value (as is done elsewhere
>>> 32 out of 39 times).
535 xDialog->execute();
536 }
537 catch( css::uno::RuntimeException& )
538 {
539 DBG_UNHANDLED_EXCEPTION("sc.ui");
540 }
** CID 1597304: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/misc/TableCopyHelper.cxx: 110 in
dbaui::OTableCopyHelper::insertTable(std::basic_string_view>, const
com::sun::star::uno::Reference &, const
rtl::OUString &, int, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Sequence &, bool,
std::basic_string_view>, const
com::sun::star::uno::Reference &)()
*** CID 1597304: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/misc/TableCopyHelper.cxx: 110 in
dbaui::OTableCopyHelper::insertTable(std::basic_string_view>, const
com::sun::star::uno::Reference &, const
rtl::OUString &, int, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Sequence &, bool,
std::basic_string_view>, const
com::sun::star::uno::Reference &)()
104 OUString sTableNameForAppend( GetTableNameForAppend() );
105 xWizard->setDestinationTableName( GetTableNameForAppend() );
106
107 bool bAppendToExisting = !sTableNameForAppend.isEmpty();
108 xWizard->setOperation( bAppendToExisting ?
CopyTableOperation::AppendData : CopyTableOperation::CopyDefinitionAndData );
109
>>> CID 1597304: Error handling issues (CHECKED_RETURN)
>>> Calling "execute" without checking return value (as is done elsewhere
>>> 32 out of 39 times).
110 xWizard->execute();
111
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1597280: Null pointer dereferences (NULL_RETURNS)
*** CID 1597280: Null pointer dereferences (NULL_RETURNS)
/lotuswordpro/source/filter/lwptablelayout.cxx: 935 in
LwpTableLayout::SplitRowToCells(XFTable *, const rtl::Reference &,
unsigned char, const unsigned char *)()
929 if (pTempRowStyle)
930 *xRowStyle = *pTempRowStyle;
931
932 for (i=1;i<=nRowNum;i++)
933 {
934 styleName = pTmpTable->GetRow(i)->GetStyleName();
>>> CID 1597280: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "static_cast>> *>(pXFStyleManager->FindStyle(styleName.operator std::u16string_view()))"
>>> when calling "GetRowHeight".
935
fHeight+=static_cast(pXFStyleManager->FindStyle(styleName))->GetRowHeight();
936 }
937 if (m_nDirection & 0x0030)
938 {
939 xRowStyle->SetMinRowHeight(static_cast(fHeight));
940 }
** CID 1597279: Error handling issues (CHECKED_RETURN)
/oox/source/ole/olehelper.cxx: 529 in
oox::ole::MSConvertOCXControls::WriteOCXExcelKludgeStream(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, const
com::sun::star::awt::Size &, rtl::OUString &)()
*** CID 1597279: Error handling issues (CHECKED_RETURN)
/oox/source/ole/olehelper.cxx: 529 in
oox::ole::MSConvertOCXControls::WriteOCXExcelKludgeStream(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, const
com::sun::star::awt::Size &, rtl::OUString &)()
523 {
524 OleFormCtrlExportHelper exportHelper(
comphelper::getProcessComponentContext(), rxModel, rxControlModel );
525 if ( !exportHelper.isValid() )
526 return false;
527 rName = exportHelper.getTypeName();
528 SvGlobalName aName;
>>> CID 1597279: Error handling issues (CHECKED_RETURN)
>>> Calling "MakeId" without checking return value (as is done elsewhere 6
>>> out of 7 times).
529 aName.MakeId(exportHelper.getGUID());
530 BinaryXOutputStream aOut( xOutStrm, false );
531 OleHelper::exportGuid( aOut, aName );
532 exportHelper.exportControl( xOutStrm, rSize );
533 return true;
534 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D3CZ__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtuF1AFWGXklFo3pPNXqNmp2eiKqr53jjPXurINB4FVmRqE7kg1sWEWW2USGT1a7TXqrldQe606OwlNpWkz7LdKZVGkF06e7LQ5W5uRVnX-2F-2FAIaJwL8gO9vSq5WxXwbKtfdLYXH009YA7HorjX4ZyjRNKpoh8JStSS5fchWWqYdjo-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
14 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1597274: Incorrect expression (IDENTICAL_BRANCHES)
/sd/source/ui/app/sdmod2.cxx: 735 in SdModule::ApplyItemSet(unsigned short,
const SfxItemSet &)()
*** CID 1597274: Incorrect expression (IDENTICAL_BRANCHES)
/sd/source/ui/app/sdmod2.cxx: 735 in SdModule::ApplyItemSet(unsigned short,
const SfxItemSet &)()
729
730 // Only if also the document type matches...
731 if( pDocSh && pDoc && eDocType == pDoc->GetDocumentType() )
732 {
733 FieldUnit eUIUnit;
734 SvtSysLocale aSysLocale;
>>> CID 1597274: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed regardless of whether "eDocType ==
>>> DocumentType::Impress" is true, because the 'then' and 'else' branches are
>>> identical. Should one of the branches be modified, or the entire 'if'
>>> statement replaced?
735 if (eDocType == DocumentType::Impress)
736 if (aSysLocale.GetLocaleData().getMeasurementSystemEnum()
== MeasurementSystem::Metric)
737 eUIUnit =
static_cast(officecfg::Office::Impress::Layout::Other::MeasureUnit::Metric::get());
738 else
739 eUIUnit =
static_cast(officecfg::Office::Impress::Layout::Other::MeasureUnit::NonMetric::get());
740 else
** CID 1597273: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/browser/unodatbr.cxx: 2162 in
dbaui::SbaTableQueryBrowser::OnExpandEntry(const weld::TreeIter &)()
*** CID 1597273: Error handling issues (CHECKED_RETURN)
/dbaccess/source/ui/browser/unodatbr.cxx: 2162 in
dbaui::SbaTableQueryBrowser::OnExpandEntry(const weld::TreeIter &)()
2156 if (etTableContainer == pData->eType)
2157 {
2158 weld::WaitObject aWaitCursor(getFrameWeld());
2159
2160 // it could be that we already have a connection
2161 SharedConnection xConnection;
>>> CID 1597273: Error handling issues (CHECKED_RETURN)
>>> Calling "ensureConnection" without checking return value (as is done
>>> elsewhere 4 out of 5 times).
2162 ensureConnection(xFirstParent.get(), xConnection);
2163
2164 if ( xConnection.is() )
2165 {
2166 SQLExceptionInfo aInfo;
2167 try
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DyvG3_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtKcSBmBEvTNeRuiIvP564cBNHH-2BnkseL5EtBP-2BeZzQbE1g97Np-2BpvZKquT0r5hu-2FR0xG2hOM4vNeYySn05u6OrlYAsxbmWDQfrI7UK8gKm0ghYRf9KG90CCzmk2fLGZk-2FmvpozqJ-2FWmGrXV21IxRBwyOAk2EDdxDyVQ1S9tg8wTY-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1596888: Null pointer dereferences (FORWARD_NULL) *** CID 1596888: Null pointer dereferences (FORWARD_NULL) /sc/source/ui/app/scmod.cxx: 233 in ScModule::ConfigurationChanged(utl::ConfigurationBroadcaster *, ConfigurationHints)() 227 const bool bUnchanged(aViewRenderingOptions == pViewShell->GetViewRenderingData()); 228 if (!bUnchanged) 229 pViewShell->SetViewRenderingData(aViewRenderingOptions); 230 ScModelObj* pScModelObj = nullptr; 231 if (SfxObjectShell* pCurrentSh = SfxObjectShell::Current()) 232 pScModelObj = comphelper::getFromUnoTunnel(pCurrentSh->GetModel()); >>> CID 1596888: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pScModelObj" to "notifyViewRenderState", which >>> dereferences it. 233 SfxLokHelper::notifyViewRenderState(pViewShell, pScModelObj); 234 // In Online, the document color is the one used for the background, contrary to 235 // Writer and Draw that use the application background color. 236 pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR, 237 aFillColor.AsRGBHexString().toUtf8()); 238 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D4S96_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtmY-2BVlqDvJQT99MURjAhHNhswJEGZtztX6sqICD-2BLQZMg4pY9-2BKEDc1hvT6plFRP6OmCd37paMxRoWtAmbgM4rcUBwDRhheUmjeXHzJuQfIbO0csvdoYhIbf5w3zrhUQxwEeWCwCdfvqcch3DEB35g6MopW8lNSgMkEAZRKWqU9w-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1596834: Incorrect expression (IDENTICAL_BRANCHES)
/sw/source/core/bastyp/calc.cxx: 127 in OperatorCompare(const void *, const
void *)()
*** CID 1596834: Incorrect expression (IDENTICAL_BRANCHES)
/sw/source/core/bastyp/calc.cxx: 127 in OperatorCompare(const void *, const
void *)()
121 extern "C" {
122 static int OperatorCompare( const void *pFirst, const void *pSecond)
123 {
124 int nRet = 0;
125 if( CALC_NAME == static_cast(pFirst)->eOp )
126 {
>>> CID 1596834: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed regardless of whether "CALC_NAME ==
>>> static_cast(pSecond)->eOp" is true, because the 'then' and
>>> 'else' branches are identical. Should one of the branches be modified, or
>>> the entire 'if' statement replaced?
127 if( CALC_NAME == static_cast(pSecond)->eOp )
128 nRet = static_cast(pFirst)->aName.compareTo(
129 static_cast(pSecond)->aName );
130 else
131 nRet = static_cast(pFirst)->aName.compareTo(
132 static_cast(pSecond)->aName );
** CID 1596833: Uninitialized members (UNINIT_CTOR)
/svgio/source/svgreader/svgstyleattributes.cxx: 1299 in
svgio::svgreader::SvgStyleAttributes::SvgStyleAttributes(svgio::svgreader::SvgNode
&)()
*** CID 1596833: Uninitialized members (UNINIT_CTOR)
/svgio/source/svgreader/svgstyleattributes.cxx: 1299 in
svgio::svgreader::SvgStyleAttributes::SvgStyleAttributes(svgio::svgreader::SvgNode
&)()
1293 maBaselineShiftNumber(0),
1294 maDominantBaseline(DominantBaseline::Auto),
1295 maResolvingParent(33, 0),
1296 mbStrokeDasharraySet(false),
1297 mbContextStroke(false)
1298 {
>>> CID 1596833: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "maContextStroke" is not initialized in this
>>> constructor nor in any functions that it calls.
1299 }
1300
1301 SvgStyleAttributes::~SvgStyleAttributes()
1302 {
1303 }
1304
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DlzJ__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtOnfJZXHZ0I-2BqvltHif1tKV6yUEK1nhCUEgrcGEHrlPYeDXLVLxGWnFQ4LOE4envtKartEpNvFsISrxil-2FMFDR5UkOz-2F2yuhJwW5QIoF7buabPX8X61cIlC6IfrAucuT4myWy7ENT7GeX7IaV6w5R4Pc-2F0sINIUWmfjVGhSgs6K0-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1585038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 2943 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::priv_insert_forward_range_expand_forward,
boost::container::new_allocator, void>,
boost::container::vec_iterator
*, (bool)1>, std::shared_ptr
*>>(std::shared_ptr *,
unsigned long, T1, boost::move_detail::integral_constant)()
*** CID 1585038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 2943 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::priv_insert_forward_range_expand_forward,
boost::container::new_allocator, void>,
boost::container::vec_iterator
*, (bool)1>, std::shared_ptr
*>>(std::shared_ptr *,
unsigned long, T1, boost::move_detail::integral_constant)()
2937
2938template
2939BOOST_CONTAINER_FORCEINLINE void
priv_insert_forward_range_expand_forward(T* const raw_pos, const size_type n,
InsertionProxy insert_range_proxy, dtl::false_type)
2940{
2941 //There is enough memory
2942 boost::container::expand_forward_and_insert_alloc
>>> CID 1585038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "insert_range_proxy" is passed-by-value as parameter to
>>> "expand_forward_and_insert_alloc" when it could be moved instead.
2943 ( this->m_holder.alloc(), raw_pos, this->priv_raw_end(), n,
insert_range_proxy);
2944 this->m_holder.inc_stored_size(n);
2945}
2946
2947template
2948void priv_insert_forward_range_new_allocation
** CID 1584285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 2957 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::priv_insert_forward_range_new_allocation,
boost::container::new_allocator, void>,
boost::container::vec_iterator
*, (bool)1>, std::shared_ptr
*>>(std::shared_ptr *,
unsigned long,
std::shared_ptr *, unsigned
long, T1)()
*** CID 1584285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 2957 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::priv_insert_forward_range_new_allocation,
boost::container::new_allocator, void>,
boost::container::vec_iterator
*, (bool)1>, std::shared_ptr
*>>(std::shared_ptr *,
unsigned long,
std::shared_ptr *, unsigned
long, T1)()
2951 //n can be zero, if we want to reallocate!
2952 allocator_type = this->m_holder.alloc();
2953 T * const raw_old_buffer = this->priv_raw_begin();
2954
2955 typename value_traits::ArrayDeallocator
new_buffer_deallocator(new_start, a, new_cap);
2956 boost::container::uninitialized_move_and_insert_alloc
>>> CID 1584285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "insert_range_proxy" is passed-by-value as parameter to
>>> "uninitialized_move_and_insert_alloc" when it could be moved instead.
2957 (a, raw_old_buffer, pos, this->priv_raw_end(), new_start, n,
insert_range_proxy);
2958 new_buffer_deallocator.release();
2959
2960 //Destroy and deallocate old elements
2961 if(raw_old_buffer){
2962
BOOST_IF_CONSTEXPR(!has_trivial_destructor_after_move::value)
** CID 1583837: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 1985 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::insert
*,
(bool)1>>(boost::container::vec_iterator
*, (bool)1>, T1, T1, boost::move_detail::disable_if_or,
boost::container::dtl::is_input_iterator::value)>,
boost::move_detail::bool_<(bool)0>, boost::move_detail::bool_<(bool)0>>::type
*)()
*** CID 1583837: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/usr/include/boost/container/vector.hpp: 1985 in
boost::container::vector,
boost::container::small_vector_allocator,
boost::container::new_allocator, void>,
void>::insert
*,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1596707: Null pointer dereferences (FORWARD_NULL)
*** CID 1596707: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/view/frmview.cxx: 286 in sd::FrameView::Update(const SdOptions
*)()
280 {
281 if (!pOptions)
282 return;
283
284 SdDrawDocument* pDrawDocument =
dynamic_cast(());
285
>>> CID 1596707: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pDrawDocument" to "GetDocumentType", which
>>> dereferences it.
286 if (pDrawDocument->GetDocumentType() == DocumentType::Impress)
287 {
288 mbRuler =
officecfg::Office::Impress::Layout::Display::Ruler::get();
289 SetDragStripes(
officecfg::Office::Impress::Layout::Display::Guide::get() );
290 SetNoDragXorPolys (
!officecfg::Office::Impress::Layout::Display::Contour::get() );
291 }
** CID 1596706: Null pointer dereferences (FORWARD_NULL)
/tools/source/fsys/urlobj.cxx: 2285 in INetURLObject::getPrefix(const char16_t
*&, const char16_t *)()
*** CID 1596706: Null pointer dereferences (FORWARD_NULL)
/tools/source/fsys/urlobj.cxx: 2285 in INetURLObject::getPrefix(const char16_t
*&, const char16_t *)()
2279 pMatch = pFirst++;
2280 pMatched = p;
2281 }
2282 if (p >= pEnd)
2283 break;
2284 sal_uInt32 nChar = rtl::toAsciiLowerCase(*p++);
>>> CID 1596706: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "pFirst->m_pPrefix".
2285 while (pFirst <= pLast && static_cast(pFirst->m_pPrefix[i]) < nChar)
2286 ++pFirst;
2287 while (pFirst <= pLast && static_cast(pLast->m_pPrefix[i]) > nChar)
2288 --pLast;
2289 }
2290 if (pFirst == pLast)
** CID 1596705: Code maintainability issues (UNUSED_VALUE)
/basegfx/source/polygon/b2dpolygontools.cxx: 3371 in
basegfx::utils::UnoPolygonBezierCoordsToB2DPolygon(const
com::sun::star::uno::Sequence &, const
com::sun::star::uno::Sequence &)()
*** CID 1596705: Code maintainability issues (UNUSED_VALUE)
/basegfx/source/polygon/b2dpolygontools.cxx: 3371 in
basegfx::utils::UnoPolygonBezierCoordsToB2DPolygon(const
com::sun::star::uno::Sequence &, const
com::sun::star::uno::Sequence &)()
3365 {
3366 aControlB = aNewCoordinatePair;
3367 bControlB = true;
3368
3369 // get next point and flag
3370 aNewCoordinatePair =
B2DPoint(rPointSequenceSource[b].X, rPointSequenceSource[b].Y);
>>> CID 1596705: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value from "rFlagSequenceSource[b]" to "ePolygonFlag" here,
>>> but that stored value is overwritten before it can be used.
3371 ePolygonFlag = rFlagSequenceSource[b];
3372 b++;
3373 }
3374
3375 // two or no control points are consumed, another
one would be an error.
3376 // It's also an error if only one control point
was read
** CID 1596704: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/xmlsecurity/source/gpg/CertificateImpl.cxx: 226 in
CertificateImpl::setCertificate(std::shared_ptr, const
GpgME::Key &)()
*** CID 1596704: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/xmlsecurity/source/gpg/CertificateImpl.cxx: 226 in
CertificateImpl::setCertificate(std::shared_ptr, const
GpgME::Key &)()
220 return KeyUsage::DIGITAL_SIGNATURE | KeyUsage::NON_REPUDIATION |
KeyUsage::KEY_ENCIPHERMENT | KeyUsage::DATA_ENCIPHERMENT;
221 }
222
223 void CertificateImpl::setCertificate(std::shared_ptr
ctx, const GpgME::Key& key)
224 {
225 m_pKey = key;
>>> CID 1596704: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "ctx" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
226 m_pContext = ctx;
227 }
228
229 const GpgME::Key* CertificateImpl::getCertificate() const
230 {
231 return
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1596697:(FORWARD_NULL)
*** CID 1596697:(FORWARD_NULL)
/sc/source/ui/miscdlgs/inscldlg.cxx: 99 in
ScInsertCellDlg::ScInsertCellDlg(weld::Window *, bool)()
93 break;
94 }
95 }
96
97 // if some cells are selected, then disable the SpinButtons
98 m_xNumberOfCols->set_sensitive(bColCount &&
!pViewData->GetMarkData().IsMarked());
>>> CID 1596697:(FORWARD_NULL)
>>> Passing null pointer "pViewData->GetMarkData()" to "IsMarked", which
>>> dereferences it.
99 m_xNumberOfRows->set_sensitive(bRowsCount &&
!pViewData->GetMarkData().IsMarked());
100 }
101
102 ScInsertCellDlg::~ScInsertCellDlg() {}
103
104 InsCellCmd ScInsertCellDlg::GetInsCellCmd() const
/sc/source/ui/miscdlgs/inscldlg.cxx: 98 in
ScInsertCellDlg::ScInsertCellDlg(weld::Window *, bool)()
92 bColCount = true;
93 break;
94 }
95 }
96
97 // if some cells are selected, then disable the SpinButtons
>>> CID 1596697:(FORWARD_NULL)
>>> Passing null pointer "pViewData->GetMarkData()" to "IsMarked", which
>>> dereferences it.
98 m_xNumberOfCols->set_sensitive(bColCount &&
!pViewData->GetMarkData().IsMarked());
99 m_xNumberOfRows->set_sensitive(bRowsCount &&
!pViewData->GetMarkData().IsMarked());
100 }
101
102 ScInsertCellDlg::~ScInsertCellDlg() {}
103
** CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 1282 in
slideshow::internal::DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr)()
*** CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 1282 in
slideshow::internal::DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr)()
1276 {
1277 mpGraphicLoader.reset();
1278 }
1279 }
1280
1281
DelayedGraphicLoader::DelayedGraphicLoader(std::shared_ptr pGraphic)
>>> CID 1596696: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pGraphic" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
1282 : mpGraphic(pGraphic)
1283 , mpVDevMask(DeviceFormat::WITHOUT_ALPHA)
1284 {
1285 }
1286 }
1287
** CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 575 in
slideshow::internal::DrawShape::create(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, double,
std::shared_ptr, const slideshow::internal::SlideShowContext &)()
*** CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/drawshape.cxx: 575 in
slideshow::internal::DrawShape::create(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &, double,
std::shared_ptr, const slideshow::internal::SlideShowContext &)()
569 std::shared_ptrpGraphic,
570 const SlideShowContext& rContext )
571 {
572 DrawShapeSharedPtr pShape( new DrawShape(xShape,
573 xContainingPage,
574 nPrio,
>>> CID 1596695: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pGraphic" is passed-by-value as parameter to
>>> "slideshow::internal::DrawShape::DrawShape(com::sun::star::uno::Reference
>>> const &,
>>> com::sun::star::uno::Reference, double,
>>> std::shared_ptr, slideshow::internal::SlideShowContext const &)"
>>> when it could be moved instead.
575 pGraphic,
576 rContext) );
577
578 if( pShape->hasIntrinsicAnimation() )
579 {
580 OSL_ASSERT( !pShape->maAnimationFrames.empty() );
** CID 1596694: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/shapeimporter.cxx: 323 in
slideshow::internal::ShapeImporter::createShape(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &,
std::basic_string_view>) const()
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1596522: Incorrect expression (BAD_COMPARE)
/sc/source/core/data/patattr.cxx: 277 in
CellAttributeHelper::RegisteredAttrSetLess::operator ()(const ScPatternAttr *,
const rtl::OUString *) const()
*** CID 1596522: Incorrect expression (BAD_COMPARE)
/sc/source/core/data/patattr.cxx: 277 in
CellAttributeHelper::RegisteredAttrSetLess::operator ()(const ScPatternAttr *,
const rtl::OUString *) const()
271 {
272 int cmp = CompareStringPtr(lhs->GetStyleName(), rhs);
273 if (cmp < 0)
274 return true;
275 if (cmp > 0)
276 return false;
>>> CID 1596522: Incorrect expression (BAD_COMPARE)
>>> Comparing pointer "lhs" against "nullptr" using anything besides "=="
>>> or "!=" is likely to be incorrect.
277 return lhs < static_cast(nullptr);
278 }
279 bool CellAttributeHelper::RegisteredAttrSetLess::operator()(const
OUString* lhs, const ScPatternAttr* rhs) const
280 {
281 int cmp = CompareStringPtr(lhs, rhs->GetStyleName());
282 if (cmp < 0)
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DeGZ__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGttWS9tzE37PgPm14eQfk0pIjwfvRDg36IZCRx64cuEDsMuGufFgqOb51JTYSfID2AwF4afWdfOnsTqD1Cn9HVR-2F5wuroye1vsAXxP3gUJncwnI2UR3msknLR-2B3-2FXAamwpcDulJwbR-2BRFuFc8gwzpNH1C3fVJFU9J9XjTpIQE9YYo-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1596521: Resource leaks (RESOURCE_LEAK)
/svgio/source/svgreader/svgfecompositenode.cxx: 248 in
svgio::svgreader::SvgFeCompositeNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&, const svgio::svgreader::SvgFilterNode *) const()
*** CID 1596521: Resource leaks (RESOURCE_LEAK)
/svgio/source/svgreader/svgfecompositenode.cxx: 248 in
svgio::svgreader::SvgFeCompositeNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&, const svgio::svgreader::SvgFilterNode *) const()
242
243 const drawinglayer::primitive2d::Primitive2DReference xRef(
244 new drawinglayer::primitive2d::BitmapPrimitive2D(
245 aResBmpEx,
basegfx::utils::createScaleTranslateB2DHomMatrix(
246aBaseRect.getRange(),
aBaseRect.getMinimum(;
247 rTarget = drawinglayer::primitive2d::Primitive2DContainer{ xRef
};
>>> CID 1596521: Resource leaks (RESOURCE_LEAK)
>>> Variable "pArithmeticFilter" going out of scope leaks the storage it
>>> points to.
248 }
249 }
250
251 } // end of namespace svgio::svgreader
252
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3Db3rj_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtnt62i6mFx1se7aN-2BqGSee1UnrR0hvz9xPkxZd86Rb5n1nZARgWme1ZB-2FD-2BLkK20PAHKxImk0ePnFitb15CErVfr-2Fp3c-2Bg1woU-2BQYdfp7xEixyBO-2Bw2mpV00XxohO0C8wyezsEYztlOFGNhW8uqzpHspCMYmltb87zXj26IQI81Y-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1596323: Null pointer dereferences (NULL_RETURNS)
*** CID 1596323: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/text/widorp.cxx: 482 in
WidowsAndOrphans::FindWidows(SwTextFrame *, SwTextMargin &)()
476 if( bKeep && pFrame->IsInSct() && (
477 rAttr.GetKeepType() ==
css::text::ParagraphHyphenationKeepType::SPREAD ||
478 rAttr.GetKeepType() ==
css::text::ParagraphHyphenationKeepType::PAGE ) )
479 {
480 const SwSectionFrame* const pSct = pFrame->FindSctFrame();
481 // multi-column section
>>> CID 1596323: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr"
>>> "pFrame->FindColFrame()" when calling "GetNext".
482 if ( pSct->Lower()->IsColumnFrame() &&
pSct->Lower()->GetNext()
483 // and not in the last column
484 && !pFrame->FindColFrame()->GetNext() )
485 {
486 bKeep = false;
487 }
** CID 1596322: Resource leaks (RESOURCE_LEAK)
/svgio/source/svgreader/svgfeblendnode.cxx: 158 in
svgio::svgreader::SvgFeBlendNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&, const svgio::svgreader::SvgFilterNode *) const()
*** CID 1596322: Resource leaks (RESOURCE_LEAK)
/svgio/source/svgreader/svgfeblendnode.cxx: 158 in
svgio::svgreader::SvgFeBlendNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&, const svgio::svgreader::SvgFilterNode *) const()
152
153 const drawinglayer::primitive2d::Primitive2DReference xRef(
154 new drawinglayer::primitive2d::BitmapPrimitive2D(
155 aResBmpEx,
basegfx::utils::createScaleTranslateB2DHomMatrix(
156aBaseRect.getRange(),
aBaseRect.getMinimum(;
157 rTarget = drawinglayer::primitive2d::Primitive2DContainer{ xRef
};
>>> CID 1596322: Resource leaks (RESOURCE_LEAK)
>>> Variable "pScreenBlendFilter" going out of scope leaks the storage it
>>> points to.
158 }
159
160 pParent->addGraphicSourceToMapper(maResult, rTarget);
161 }
162
163 } // end of namespace svgio::svgreader
164
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3Dsnv6_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtuw314jrPBVWaQyrmAPGzU9vOtqtRrAdjw-2B4Z3l-2FSG3YnSY-2FhLDqo1J6WFHB9nVcdNzKwHNFSf-2BmzFHCVwLOh9kkBXRnPUFoHB7odZCx4jG9nXO-2B1xDw5jLnfdhNJ-2BKC8ZYR1i8jWUXdSOWyfzNnvptzS5PX-2BItrQHYQ1TtuSOAk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
15 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1596278: Null pointer dereferences (FORWARD_NULL)
*** CID 1596278: Null pointer dereferences (FORWARD_NULL)
/sw/source/core/text/frmform.cxx: 1205 in
SwTextFrame::FormatAdjust(SwTextFormatter &, WidowsAndOrphans &,
o3tl::strong_int, bool)()
1199 nNew = 0;
1200 }
1201 else if (!bEmptyWithSplitFly)
1202 {
1203 // Do not split immediately in the beginning of page
(unless there is an at-para or
1204 // at-char or at-page fly, which pushes the rest down)
>>> CID 1596278: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pBodyFrame" to "hasAtPageFly", which dereferences
>>> it.
1205 if (isFirstVisibleFrameInBody(this) && !hasFly(this) &&
!hasAtPageFly(pBodyFrame))
1206 nNew = 0;
1207 }
1208 }
1209
1210 if ( nNew )
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DOVq3_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtlPTtwlLm0LVNz3b0CKB7cFDFIk0k2thRDBo3nZcFupaXqV493hgw-2Fl3onk-2FssT3N05Vk0hTGK1WN0aWq7a0zbfChKTMPg-2F20R8sbH8UhQ2yNsd-2BisYfJG4M66fXujPTZET58sbQSW5rWAtEOA-2FghnAs5P-2FQWwJSwNw9iubDqwmk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
17 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 17 of 17 defect(s)
** CID 1596254: Null pointer dereferences (FORWARD_NULL)
/sw/source/uibase/dochdl/swdtflvr.cxx: 2815 in SwTransferable::PasteGrf(const
TransferableDataHelper &, SwWrtShell &, SotClipboardFormatId, SwPasteSdr, const
Point *, SotExchangeActionFlags, signed char, bool, RndStdIds)()
*** CID 1596254: Null pointer dereferences (FORWARD_NULL)
/sw/source/uibase/dochdl/swdtflvr.cxx: 2815 in SwTransferable::PasteGrf(const
TransferableDataHelper &, SwWrtShell &, SotClipboardFormatId, SwPasteSdr, const
Point *, SotExchangeActionFlags, signed char, bool, RndStdIds)()
2809 case SotClipboardFormatId::SVXB:
2810 {
2811 std::unique_ptr xStm;
2812
2813 if(rData.GetSotStorageStream(SotClipboardFormatId::SVXB, xStm))
2814 {
>>> CID 1596254: Null pointer dereferences (FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "xStm".
2815 TypeSerializer aSerializer(*xStm);
2816 aSerializer.readGraphic(aGraphic);
2817 bRet = (GraphicType::NONE != aGraphic.GetType() &&
GraphicType::Default != aGraphic.GetType());
2818 }
2819
2820 break;
** CID 1596253: Null pointer dereferences (FORWARD_NULL)
/sc/source/ui/view/viewfun3.cxx: 785 in
ScViewFunc::PasteOnDrawObjectLinked(const
com::sun::star::uno::Reference &,
SdrObject &)()
*** CID 1596253: Null pointer dereferences (FORWARD_NULL)
/sc/source/ui/view/viewfun3.cxx: 785 in
ScViewFunc::PasteOnDrawObjectLinked(const
com::sun::star::uno::Reference &,
SdrObject &)()
779 std::unique_ptr xStm;
780 ScDrawView* pScDrawView = GetScDrawView();
781
782 if( pScDrawView && aDataHelper.GetSotStorageStream(
SotClipboardFormatId::SVXB, xStm ) )
783 {
784 Graphic aGraphic;
>>> CID 1596253: Null pointer dereferences (FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "xStm".
785 TypeSerializer aSerializer(*xStm);
786 aSerializer.readGraphic(aGraphic);
787
788 const OUString aBeginUndo(ScResId(STR_UNDO_DRAGDROP));
789
790 if(pScDrawView->ApplyGraphicToObject( rHitObj, aGraphic,
aBeginUndo, "" ))
** CID 1596252:(FORWARD_NULL)
/sc/source/ui/view/viewfun5.cxx: 256 in
ScViewFunc::PasteDataFormat(SotClipboardFormatId, const
com::sun::star::uno::Reference &,
short, int, const Point *, bool, bool)()
/sc/source/ui/view/viewfun5.cxx: 238 in
ScViewFunc::PasteDataFormat(SotClipboardFormatId, const
com::sun::star::uno::Reference &,
short, int, const Point *, bool, bool)()
*** CID 1596252:(FORWARD_NULL)
/sc/source/ui/view/viewfun5.cxx: 256 in
ScViewFunc::PasteDataFormat(SotClipboardFormatId, const
com::sun::star::uno::Reference &,
short, int, const Point *, bool, bool)()
250 ScDocShellRef aDragShellRef( new ScDocShell );
251 aDragShellRef->MakeDrawLayer();
252 aDragShellRef->DoInitNew();
253
254 ScDrawLayer* pModel =
aDragShellRef->GetDocument().GetDrawLayer();
255
>>> CID 1596252:(FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "xStm".
256 xStm->Seek(0);
257
258 css::uno::Reference< css::io::XInputStream > xInputStream(
new utl::OInputStreamWrapper( *xStm ) );
259 SvxDrawingLayerImport( pModel, xInputStream );
260
261 // set everything to right layer:
/sc/source/ui/view/viewfun5.cxx: 238 in
ScViewFunc::PasteDataFormat(SotClipboardFormatId, const
com::sun::star::uno::Reference &,
short, int, const Point *, bool, bool)()
232 else if (nFormatId == SotClipboardFormatId::SVXB)
233 {
234 std::unique_ptr xStm;
235 if( aDataHelper.GetSotStorageStream(
SotClipboardFormatId::SVXB, xStm ) )
236 {
237 Graphic aGraphic;
>>> CID 1596252:(FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "xStm".
238 TypeSerializer aSerializer(*xStm);
239 aSerializer.readGraphic(aGraphic);
240 bRet = PasteGraphic(
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
17 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 17 of 17 defect(s)
** CID 1596132: API usage errors (LOCK)
*** CID 1596132: API usage errors (LOCK)
/scripting/source/vbaevents/eventhelper.cxx: 529 in
::EventListener::~EventListener()()
523
524 #define EVENTLSTNR_PROPERTY_ID_MODEL 1
525 constexpr OUStringLiteral EVENTLSTNR_PROPERTY_MODEL = u"Model";
526
527 namespace {
528
>>> CID 1596132: API usage errors (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
529 class EventListener : public EventListener_BASE
530 ,public ::comphelper::OPropertyContainer2
531 ,public ::comphelper::OPropertyArrayUsageHelper< EventListener >
532 {
533
534 public:
** CID 1596131: API usage errors (LOCK)
*** CID 1596131: API usage errors (LOCK)
/sc/source/ui/unoobj/celllistsource.cxx: 74 in
calc::OCellListSource::~OCellListSource()()
68 {
69 if ( !m_bDisposed )
70 {
71 acquire(); // prevent duplicate dtor
72 dispose();
73 }
>>> CID 1596131: API usage errors (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
74 }
75
76 IMPLEMENT_FORWARD_XINTERFACE2( OCellListSource,
OCellListSource_Base, OCellListSource_PBase )
77
78 IMPLEMENT_FORWARD_XTYPEPROVIDER2( OCellListSource,
OCellListSource_Base, OCellListSource_PBase )
79
** CID 1596130: API usage errors (LOCK)
*** CID 1596130: API usage errors (LOCK)
/chart2/source/tools/CachedDataSequence.cxx: 98 in
chart::CachedDataSequence::~CachedDataSequence()()
92 }
93
94 registerProperties();
95 }
96
97 CachedDataSequence::~CachedDataSequence()
>>> CID 1596130: API usage errors (LOCK)
>>> "~WeakComponentImplHelper" uses "this->m_aMutex" in an uninitialized
>>> state.
98 {}
99
100 void CachedDataSequence::registerProperties()
101 {
102 registerProperty( "NumberFormatKey",
103 PROP_NUMBERFORMAT_KEY,
** CID 1596129: API usage errors (LOCK)
*** CID 1596129: API usage errors (LOCK)
/scripting/source/basprov/basmethnode.cxx: 99 in
basprov::BasicMethodNodeImpl::~BasicMethodNodeImpl()()
93 registerProperty( BASPROV_PROPERTY_EDITABLE,
BASPROV_PROPERTY_ID_EDITABLE, BASPROV_DEFAULT_ATTRIBS(), _bEditable,
cppu::UnoType::get() );
94 }
95
96
97 BasicMethodNodeImpl::~BasicMethodNodeImpl()
98 {
>>> CID 1596129: API usage errors (LOCK)
>>> "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
99 }
100
101
102 // XInterface
103
104
** CID 1596128: API usage errors (LOCK)
*** CID 1596128: API usage errors (LOCK)
/sc/source/ui/unoobj/pageuno.cxx: 28 in ScPageObj::ScPageObj(SdrPage *)()
22 #include
23 #include
24
25 using namespace ::com::sun::star;
26
27 ScPageObj::ScPageObj( SdrPage* pPage ) :
>>> CID 1596128: API usage errors (LOCK)
>>> "SvxDrawPage" initializes "this->m_aMutex" while it is already
>>> initialized.
28 SvxDrawPage( pPage )
29 {
30 }
31
32 ScPageObj::~ScPageObj() noexcept
33 {
** CID 1596127: API usage errors (LOCK)
*** CID 1596127: API usage errors (LOCK)
/sccomp/source/solver/SolverComponent.cxx: 111 in
SolverComponent::~SolverComponent()()
105 registerProperty( STR_EPSILONLEVEL, PROP_EPSILONLEVEL, 0,
, cppu::UnoType::get() );
106 registerProperty( STR_LIMITBBDEPTH, PROP_LIMITBBDEPTH, 0,
, cppu::UnoType::get() );
107 }
108
109 SolverComponent::~SolverComponent()
110 {
>>> CID 1596127: API usage errors (LOCK)
>>> "~WeakImplHelper" uses "this->m_aMutex" in an uninitialized state.
111 }
112
113 IMPLEMENT_FORWARD_XINTERFACE2( SolverComponent, SolverComponent_Base,
comphelper::OPropertyContainer2 )
114 IMPLEMENT_FORWARD_XTYPEPROVIDER2( SolverComponent,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1594675:(DEADCODE)
/sc/source/ui/view/tabview.cxx: 1160 in ScTabView::ScrollHdl(ScrollAdaptor *)()
/sc/source/ui/view/tabview.cxx: 1158 in ScTabView::ScrollHdl(ScrollAdaptor *)()
*** CID 1594675:(DEADCODE)
/sc/source/ui/view/tabview.cxx: 1160 in ScTabView::ScrollHdl(ScrollAdaptor *)()
1154 aHelpStr = ScResId(STR_ROW) +
1155" " + OUString::number(nScrollPos + 1);
1156
1157 // show quicktext always inside sheet area
1158 aRect.SetLeft( bLayoutRTL ? (aPos.X() + aSize.Width()
+ 8) : (aPos.X() - 8) );
1159 aRect.SetTop( aMousePos.Y() );
>>> CID 1594675:(DEADCODE)
>>> Execution cannot reach the expression "QuickHelpFlags::Left" inside
>>> this statement: " = (bLayoutRTL ?...".
1160 nAlign = (bLayoutRTL ? QuickHelpFlags::Left :
QuickHelpFlags::Right) | QuickHelpFlags::VCenter;
1161 }
1162 aRect.SetRight( aRect.Left() );
1163 aRect.SetBottom( aRect.Top() );
1164
1165 Help::ShowQuickHelp(pScroll->GetParent(), aRect, aHelpStr,
nAlign);
/sc/source/ui/view/tabview.cxx: 1158 in ScTabView::ScrollHdl(ScrollAdaptor *)()
1152 else
1153 {
1154 aHelpStr = ScResId(STR_ROW) +
1155" " + OUString::number(nScrollPos + 1);
1156
1157 // show quicktext always inside sheet area
>>> CID 1594675:(DEADCODE)
>>> Execution cannot reach the expression "aPos.X() + aSize.Width() + 8L"
>>> inside this statement: "aRect.SetLeft((bLayoutRTL ?...".
1158 aRect.SetLeft( bLayoutRTL ? (aPos.X() + aSize.Width()
+ 8) : (aPos.X() - 8) );
1159 aRect.SetTop( aMousePos.Y() );
1160 nAlign = (bLayoutRTL ? QuickHelpFlags::Left :
QuickHelpFlags::Right) | QuickHelpFlags::VCenter;
1161 }
1162 aRect.SetRight( aRect.Left() );
1163 aRect.SetBottom( aRect.Top() );
** CID 1594674: API usage errors (INVALIDATE_ITERATOR)
/sc/source/core/data/SolverSettings.cxx: 789 in
sc::SolverSettings::TabHasSolverModel()()
*** CID 1594674: API usage errors (INVALIDATE_ITERATOR)
/sc/source/core/data/SolverSettings.cxx: 789 in
sc::SolverSettings::TabHasSolverModel()()
783so before it is called, no solver-related named ranges exist.
784 */
785 bool SolverSettings::TabHasSolverModel()
786 {
787 // Check if the named range for the objective value exists in the
sheet
788 const auto iter = m_mNamedRanges.find(SP_OBJ_CELL);
>>> CID 1594674: API usage errors (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "iter" though it is already past the end of its
>>> container.
789 OUString sRange = iter->second;
790 ScRangeData* pRangeData
791 =
m_pRangeName->findByUpperName(ScGlobal::getCharClass().uppercase(sRange));
792 if (pRangeData)
793 return true;
794 return false;
795 }
796
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DBAIx_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtERQty1Y5JpkDXubi7MsokQaRv4jsHtrS-2BixY5vNs-2FGbRZsRBY0-2Ba4Ds142E1HxrBQy3-2FfJLFeOubpB02YnnKddIcygoNaLijEdfdc1WG4Y32XWZ2k46a8UyxKtYrRJWZowog86JcdLAHzoDzhbfpYGyqwawJaDre8AYwyGfd4rM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1594402: Null pointer dereferences (FORWARD_NULL)
*** CID 1594402: Null pointer dereferences (FORWARD_NULL)
/sc/source/ui/unoobj/docuno.cxx: 2372 in lcl_SetMediaScreen(const
com::sun::star::uno::Reference &, const
OutputDevice *, tools::Rectangle &, int)()
2366: OUString::Concat(sTitle) +
OUString::Concat("\n")
2367 +
OUString::Concat(sDescription));
2368
2369 OUString const
mimeType(xPropSet->getPropertyValue("MediaMimeType").get());
2370 SdrObject*
pSdrObj(SdrObject::getSdrObjectFromXShape(xMediaShape));
2371 vcl::PDFExtOutDevData* pPDF =
dynamic_cast(pDev->GetExtOutDevData());
>>> CID 1594402: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pPDF" to "CreateScreen", which dereferences it.
2372 sal_Int32 nScreenId = pPDF->CreateScreen(aRect, altText,
mimeType, nPageNumb, pSdrObj);
2373 if (sMediaURL.startsWith("vnd.sun.star.Package:"))
2374 {
2375 // Embedded media
2376 OUString aTempFileURL;
2377 xPropSet->getPropertyValue("PrivateTempFileURL") >>=
aTempFileURL;
** CID 1594401: Null pointer dereferences (FORWARD_NULL)
*** CID 1594401: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/sidebar/ControllerItem.cxx: 72 in
sfx2::sidebar::ControllerItem::RequestUpdate()()
66 const SfxItemState eState (GetBindings().QueryState(GetId(),
pState));
67 if (GetId() == SID_ATTR_METRIC &&
comphelper::LibreOfficeKit::isActive())
68 {
69 MeasurementSystem eSystem
70 =
LocaleDataWrapper(comphelper::LibreOfficeKit::getLocale()).getMeasurementSystemEnum();
71 FieldUnit eUnit = MeasurementSystem::Metric == eSystem ?
FieldUnit::CM : FieldUnit::INCH;
>>> CID 1594401: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pState.get()" to "SetValue", which dereferences
>>> it.
72
static_cast(pState.get())->SetValue(static_cast(eUnit));
73 }
74 mrItemUpdateReceiver.NotifyItemUpdate(GetId(), eState, pState.get());
75 }
76
77
ControllerItem::ItemUpdateReceiverInterface::~ItemUpdateReceiverInterface()
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DQmg-_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtuM6dpEYHAKPAFOJnFFVTAqyXcfeEbV-2BOW4lbsmS1OR0nkjjh7njRe7s5QFDFx7brLxb5QyVkD5FJ6Cbd7-2Bgo8L3HkTQubHucgEUCgCYMVFNZbqXF2c2vU7innBMhSfrv9VCmBEXIFp5fBqc-2B4Gq1xnoJqgsa0QHSbGHvJGqgj30NSky9ULHy9BfyemEoKG3F
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1592991: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Properties.cxx: 796 in
chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr,
const rtl::OUString &, bool)()
*** CID 1592991: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Properties.cxx: 796 in
chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr,
const rtl::OUString &, bool)()
790 {
791 aDlgPtr->SetAxisMinorStepWidthForErrorBarDecimals(
792
InsertErrorBarsDialog::getAxisMinorStepWidthForErrorBarDecimals( xChartDoc,
m_xChartView, rObjectCID ) );
793 }
794
795 //open the dialog
>>> CID 1592991: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aUndoGuard" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
796 SfxTabDialogController::runAsync(aDlgPtr, [aDlgPtr, xChartDoc,
pItemConverter, bSuccessOnUnchanged, aUndoGuard] (int nResult)
797 {
798 if (nResult == RET_OK || (bSuccessOnUnchanged &&
aDlgPtr->DialogWasClosedWithOK())) {
799 const SfxItemSet* pOutItemSet =
aDlgPtr->GetOutputItemSet();
800 if(pOutItemSet) {
801 ControllerLockGuardUNO aCLGuard(xChartDoc);
** CID 1592990: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Properties.cxx: 712 in
chart::ChartController::executeDlg_ObjectProperties(const rtl::OUString &)()
*** CID 1592990: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Properties.cxx: 712 in
chart::ChartController::executeDlg_ObjectProperties(const rtl::OUString &)()
706 auto aUndoGuard = std::make_shared(
707 ActionDescriptionProvider::createDescription(
708 ActionDescriptionProvider::ActionType::Format,
709 ObjectNameProvider::getName(
ObjectIdentifier::getObjectType( aObjectCID ))),
710 m_xUndoManager );
711
>>> CID 1592990: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aUndoGuard" is passed-by-value as parameter to
>>> "executeDlg_ObjectProperties_withUndoGuard" when it could be moved instead.
712 ChartController::executeDlg_ObjectProperties_withUndoGuard(
aUndoGuard, aObjectCID, false );
713 }
714
715 void ChartController::executeDlg_ObjectProperties_withUndoGuard(
716 std::shared_ptr aUndoGuard,const OUString& rObjectCID,
bool bSuccessOnUnchanged )
717 {
** CID 1592989: Null pointer dereferences (FORWARD_NULL)
/vcl/source/window/brdwin.cxx: 2014 in ImplBorderWindow::FlashWindow() const()
*** CID 1592989: Null pointer dereferences (FORWARD_NULL)
/vcl/source/window/brdwin.cxx: 2014 in ImplBorderWindow::FlashWindow() const()
2008 vcl::Window* pMyParent = mpWindowImpl->mpParent;
2009 while (pMyParent && pMyParent->mpWindowImpl &&
pMyParent->mpWindowImpl->mpParent)
2010 {
2011 pMyParent = pMyParent->mpWindowImpl->mpParent;
2012 }
2013 if (pMyParent) {
>>> CID 1592989: Null pointer dereferences (FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "pMyParent->mpWindowImpl".
2014 pMyParent->mpWindowImpl->mpFrame->FlashWindow();
2015 }
2016 }
2017
** CID 1592988: Uninitialized members (UNINIT_CTOR)
/sw/source/core/text/porlay.cxx: 852 in SwLineLayout::SwLineLayout()()
*** CID 1592988: Uninitialized members (UNINIT_CTOR)
/sw/source/core/text/porlay.cxx: 852 in SwLineLayout::SwLineLayout()()
846 m_nRealHeight( 0 ),
847 m_nTextHeight( 0 ),
848 m_bUnderscore( false )
849 {
850 ResetFlags();
851 SetWhichPor( PortionType::Lay );
>>> CID 1592988: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_bLastHyph" is not initialized in this
>>> constructor nor in any functions that it calls.
852 }
853
854 SwLinePortion
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1592910: Null pointer dereferences (NULL_RETURNS)
*** CID 1592910: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/edit/edsect.cxx: 349 in lcl_SpecialInsertNode(const SwPosition
*)()
343 // only protection outside needs to be checked
344 if( pSection &&
345 (SectionType::ToxHeader == pSection->GetType() ||
346 SectionType::ToxContent == pSection->GetType()))
347 {
348 if (SectionType::ToxHeader == pSection->GetType())
>>> CID 1592910: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pSection->GetParent()"
>>> when calling "GetFormat".
349 pInnermostNode =
pSection->GetParent()->GetFormat()->GetSectionNode();
350 bIsProtected = static_cast(pInnermostNode)->IsInProtectSect();
351 }
352
353 // The previous version had a check to skip empty read-only
sections. Those
354 // shouldn't occur, so we only need to check whether our
pInnermostNode is
** CID 1592909: Null pointer dereferences (REVERSE_INULL)
/sw/source/core/edit/edsect.cxx: 337 in lcl_SpecialInsertNode(const SwPosition
*)()
*** CID 1592909: Null pointer dereferences (REVERSE_INULL)
/sw/source/core/edit/edsect.cxx: 337 in lcl_SpecialInsertNode(const SwPosition
*)()
331 }
332 else
333 pInnermostNode = pTableNode;
334 }
335 }
336 bool bIsProtected = pInnermostNode->IsProtect();
>>> CID 1592909: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pInnermostNode" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
337 if(pInnermostNode != nullptr)
338 {
339 //special case - ToxSection
340 // - in this case the inner section could be tox header
341 // section but the new node should be before the content
section
342 // protection of the tox should not prevent the insertion
** CID 1592908: Null pointer dereferences (NULL_RETURNS)
*** CID 1592908: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/edit/edsect.cxx: 336 in lcl_SpecialInsertNode(const SwPosition
*)()
330 pSection = _cast(pSectionNode)->GetSection();
331 }
332 else
333 pInnermostNode = pTableNode;
334 }
335 }
>>> CID 1592908: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pInnermostNode" when
>>> calling "IsProtect".
336 bool bIsProtected = pInnermostNode->IsProtect();
337 if(pInnermostNode != nullptr)
338 {
339 //special case - ToxSection
340 // - in this case the inner section could be tox header
341 // section but the new node should be before the content
section
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DoByu_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtQnnP2Sl-2BcQ8L7jLCiUvR0e20beDprWglfuXB9hxvFXmlxGvnqQ6tKW7XlK3i8VGudPmeOrrs0Wv9ppjT9Kvmk0vnqDB7iIZaTN8mBl-2BIFQpqyiv4ZzeA3By8mGuMOg99GWdNOmQeHQ3EaGZtYA33KPc43G0l-2Beciq31oEU-2BnMJk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1592640: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/slideshow/slideshowimpl.cxx: 1130 in
sd::SlideshowImpl::startShow(const sd::PresentationSettingsEx *)()
*** CID 1592640: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/slideshow/slideshowimpl.cxx: 1130 in
sd::SlideshowImpl::startShow(const sd::PresentationSettingsEx *)()
1124 mpViewShell->GetViewShellBase().ShowUIControls (false);
1125 // Hide the side panes for in-place presentations.
1126 if ( ! maPresSettings.mbFullScreen)
1127 mpPaneHider.reset(new PaneHider(*mpViewShell,this));
1128
1129 // these Slots are forbidden in other views for this
document
>>> CID 1592640: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "pPresSettings".
1130 if( mpDocSh && !pPresSettings->mbInteractive) // IASS
1131 {
1132 mpDocSh->SetSlotFilter( true, pAllowed );
1133 mpDocSh->ApplySlotFilter();
1134 }
1135
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DnEde_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt1tr1i9DQoO7ElOGukyr4SHjOVDWMXgVx3dXiRAReu0G9KraVCIeQhsM5zgCnrFYy0Wr-2FLkgjbxGfTbsLjC3oXwYUNsxmwGHNMquG1C6mBOHOn3YbKHUkDtmsq7OWI00mIxMmshRz231IywiZJZ-2Fm1CMA5c-2BL-2Fyn7X1diIY2DxbI-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
7 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)
** CID 1592381:(OVERRUN)
/oox/source/drawingml/scene3dhelper.cxx: 248 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
/oox/source/drawingml/scene3dhelper.cxx: 250 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
/oox/source/drawingml/scene3dhelper.cxx: 249 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
*** CID 1592381:(OVERRUN)
/oox/source/drawingml/scene3dhelper.cxx: 248 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
242 // OOXML markup are given, they overwrite the values from the
preset camera type. Otherwise the
243 // values from the preset camera are used. OOXML requires that all
three attributes must exist at
244 // the same time. Thus it is enough to test one of them.
245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value())
246 {
247 // The angles are given in 1/6 deg in
aPrstCameraValuesArray.
>>> CID 1592381:(OVERRUN)
>>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements
>>> at element index 62 (byte offset 6551) using index
>>> "this->mnPrstCameraIndex" (which evaluates to 62).
248 nLatitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX;
249 nLongitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY;
250 nRevolution =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ;
251 }
252
253 // MS Office applies the shape rotation after the rotations from
camera in case of non-legacy
/oox/source/drawingml/scene3dhelper.cxx: 250 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
244 // the same time. Thus it is enough to test one of them.
245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value())
246 {
247 // The angles are given in 1/6 deg in
aPrstCameraValuesArray.
248 nLatitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX;
249 nLongitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY;
>>> CID 1592381:(OVERRUN)
>>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements
>>> at element index 62 (byte offset 6551) using index
>>> "this->mnPrstCameraIndex" (which evaluates to 62).
250 nRevolution =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ;
251 }
252
253 // MS Office applies the shape rotation after the rotations from
camera in case of non-legacy
254 // cameras, and before for legacy cameras. ODF specifies to first
rotate the shape. Thus we need
255 // to add shape rotation to nRevolution in case of non-legacy
cameras. The shape rotation has
/oox/source/drawingml/scene3dhelper.cxx: 249 in
oox::Scene3DHelper::getAPIAnglesFrom3DProperties(std::shared_ptr,
const int &, double &, double &, double &)()
243 // values from the preset camera are used. OOXML requires that all
three attributes must exist at
244 // the same time. Thus it is enough to test one of them.
245 if (!(*p3DProperties).maCameraRotation.mnRevolution.has_value())
246 {
247 // The angles are given in 1/6 deg in
aPrstCameraValuesArray.
248 nLatitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleX;
>>> CID 1592381:(OVERRUN)
>>> Overrunning array "oox::aPrstCameraValuesArray" of 62 104-byte elements
>>> at element index 62 (byte offset 6551) using index
>>> "this->mnPrstCameraIndex" (which evaluates to 62).
249 nLongitude =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleY;
250 nRevolution =
aPrstCameraValuesArray[mnPrstCameraIndex].mfRotateAngleZ;
251 }
252
253 // MS Office applies the shape rotation after the rotations from
camera in case of non-legacy
254 // cameras, and before for legacy cameras. ODF specifies to first
rotate the shape. Thus we need
** CID 1592380: Incorrect expression (COPY_PASTE_ERROR)
/sd/source/ui/slideshow/slideshowimpl.cxx: 3439 in
sd::SlideshowImpl::Notify(SfxBroadcaster &, const SfxHint &)()
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1592140: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx: 237 in
drawinglayer::primitive2d::PatternFillPrimitive2D::create2DDecomposition(const
drawinglayer::geometry::ViewInformation2D &) const()
*** CID 1592140: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx: 237 in
drawinglayer::primitive2d::PatternFillPrimitive2D::create2DDecomposition(const
drawinglayer::geometry::ViewInformation2D &) const()
231
232 // create one primitive for each matrix
233 for(size_t a(0); a < aMatrices.size(); a++)
234 {
235 aRetval[a] = new TransformPrimitive2D(
236 aMatrices[a],
>>> CID 1592140: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aContent" is passed-by-value as parameter to
>>> "drawinglayer::primitive2d::TransformPrimitive2D::TransformPrimitive2D(basegfx::B2DHomMatrix,
>>> drawinglayer::primitive2d::Primitive2DContainer &&)" when it could be
>>> moved instead.
237 Primitive2DContainer(aContent));
238 }
239
240 // transform result which is in unit coordinates to mask's
object coordinates
241 {
242 const basegfx::B2DHomMatrix aMaskTransform(
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3Dtz1R_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiZjg2Q2TJLdTnF-2B9XFDtNnn7ZwF3iYbeyhd4IuSBeG6GhFOROVKZeGU-2Bn2kqQJh9KOx-2Bg78lyJNUvgB8bzjaslJyPbolkCmGdsj6dNoJ92d2GYkFpA54lTi-2BlWlAhXyTPlLgSn12O-2FJyo5xLYnr2AgL-2FvdcOcJ90t21PpSHx9VYg-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1591787: API usage errors (SWAPPED_ARGUMENTS)
*** CID 1591787: API usage errors (SWAPPED_ARGUMENTS)
/vcl/source/window/printdlg.cxx: 1036 in vcl::PrintDialog::updatePageSize(int)()
1030
1031 if (nOrientation != ORIENTATION_AUTOMATIC)
1032 {
1033 if ((nOrientation == ORIENTATION_PORTRAIT && aSize.Width() >
aSize.Height())
1034 || (nOrientation == ORIENTATION_LANDSCAPE && aSize.Width()
< aSize.Height()))
1035 {
>>> CID 1591787: API usage errors (SWAPPED_ARGUMENTS)
>>> The positions of arguments in the constructor for "Size" do not match
>>> the ordering of the parameters:
* "aSize.Height()" is passed to "nWidth".
* "aSize.Width()" is passed to "nHeight".
1036 aSize = Size(aSize.Height(), aSize.Width());
1037 }
1038 }
1039
1040 aPrt->SetPrintPageSize(aSize);
1041 aPrt->SetUsePrintDialogSetting(true);
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DDZ5s_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2FMQNah90sVdv0ufhkoWtzO2yEdxi5dY8o2vQQcoB2hSoFdNaLwNmMm2gNCNERoDYMS8RgLOYE-2BbbR5orvWVPZD-2BuXBdfvqECndMhQI28ykYcGID5mITnTdGzTD6Riqj0OEId5AFt9Df0-2BKx251CiECdMrJhLCwyirGDqU81cM1A-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
10 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1591769:(COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Insert.cxx: 611 in
chart::ChartController::executeDispatch_InsertErrorBars(bool)()
/chart2/source/controller/main/ChartController_Insert.cxx: 572 in
chart::ChartController::executeDispatch_InsertErrorBars(bool)()
*** CID 1591769:(COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Insert.cxx: 611 in
chart::ChartController::executeDispatch_InsertErrorBars(bool)()
605 getChartModel(),
606 bYError ? ErrorBarResources::ERROR_BAR_Y :
ErrorBarResources::ERROR_BAR_X);
607
608 aDlg->SetAxisMinorStepWidthForErrorBarDecimals(
609
InsertErrorBarsDialog::getAxisMinorStepWidthForErrorBarDecimals(
getChartModel(), m_xChartView, u"" ) );
610
>>> CID 1591769:(COPY_INSTEAD_OF_MOVE)
>>> "aUndoGuard" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
611 weld::DialogController::runAsync(aDlg, [this, aDlg,
aItemConverter, aUndoGuard](int nResult) {
612 if ( nResult == RET_OK )
613 {
614 SfxItemSet aOutItemSet =
aItemConverter->CreateEmptyItemSet();
615 aDlg->FillItemSet( aOutItemSet );
616
/chart2/source/controller/main/ChartController_Insert.cxx: 572 in
chart::ChartController::executeDispatch_InsertErrorBars(bool)()
566 aDlg->SetAxisMinorStepWidthForErrorBarDecimals(
567
InsertErrorBarsDialog::getAxisMinorStepWidthForErrorBarDecimals(
getChartModel(),
568
m_xChartView, m_aSelection.getSelectedCID()));
569
570 // note: when a user pressed "OK" but didn't change any
settings in the
571 // dialog, the SfxTabDialog returns "Cancel"
>>> CID 1591769:(COPY_INSTEAD_OF_MOVE)
>>> "aUndoGuard" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved
>>> instead.
572 SfxTabDialogController::runAsync(aDlg, [this, aDlg,
aItemConverter, aUndoGuard](int nResult) {
573 if ( nResult == RET_OK || aDlg->DialogWasClosedWithOK() )
574 {
575 const SfxItemSet* pOutItemSet =
aDlg->GetOutputItemSet();
576 if( pOutItemSet )
577 {
** CID 1591768: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Insert.cxx: 291 in
chart::ChartController::executeDispatch_InsertTitles()()
*** CID 1591768: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/main/ChartController_Insert.cxx: 291 in
chart::ChartController::executeDispatch_InsertTitles()()
285 {
286 auto aDialogInput = std::make_shared();
287 aDialogInput->readFromModel( getChartModel() );
288
289 SolarMutexGuard aGuard;
290 auto aDlg = std::make_shared(GetChartFrame(),
*aDialogInput);
>>> CID 1591768: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aUndoGuard" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
291 weld::DialogController::runAsync(aDlg, [this, aDlg,
aDialogInput, aUndoGuard](int nResult){
292 if ( nResult == RET_OK )
293 {
294 // lock controllers till end of block
295 ControllerLockGuardUNO aCLGuard( getChartModel() );
296 TitleDialogData aDialogOutput(
impl_createReferenceSizeProvider() );
** CID 1591767:(UNINIT_CTOR)
/sc/source/core/data/queryiter.cxx: 79 in
ScQueryCellIteratorBase<(ScQueryCellIteratorAccess)1,
(ScQueryCellIteratorType)0>::ScQueryCellIteratorBase(ScDocument &,
ScInterpreterContext &, short, const ScQueryParam &, bool, bool)()
/sc/source/core/data/queryiter.cxx: 79 in
ScQueryCellIteratorBase<(ScQueryCellIteratorAccess)0,
(ScQueryCellIteratorType)1>::ScQueryCellIteratorBase(ScDocument &,
ScInterpreterContext &, short, const ScQueryParam &, bool, bool)()
/sc/source/core/data/queryiter.cxx: 79 in
ScQueryCellIteratorBase<(ScQueryCellIteratorAccess)0,
(ScQueryCellIteratorType)0>::ScQueryCellIteratorBase(ScDocument &,
ScInterpreterContext &, short, const
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
17 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1591747: Control flow issues (NO_EFFECT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode
&)()
*** CID 1591747: Control flow issues (NO_EFFECT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode
&)()
456 mrStream.ReadUInt16(nUnit);
457 readPoint(aOrigin);
458 readFraction(aScaleX);
459 readFraction(aScaleY);
460 mrStream.ReadCharAsBool(bSimple);
461
>>> CID 1591747: Control flow issues (NO_EFFECT)
>>> This less-than-zero comparison of an unsigned value is never true.
>>> "nUnit < 0".
462 if (nUnit < sal_Int16(MapUnit::Map100thMM) || nUnit >
sal_Int16(MapUnit::LAST))
463 {
464 SAL_WARN("vcl.gdi", "Parsing error: invalid mapmode");
465 return false;
466 }
467 MapUnit eUnit = static_cast(nUnit);
** CID 1591746: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode
&)()
*** CID 1591746: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/vcl/source/gdi/TypeSerializer.cxx: 462 in TypeSerializer::readMapMode(MapMode
&)()
456 mrStream.ReadUInt16(nUnit);
457 readPoint(aOrigin);
458 readFraction(aScaleX);
459 readFraction(aScaleY);
460 mrStream.ReadCharAsBool(bSimple);
461
>>> CID 1591746: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "nUnit < 0 /* (sal_Int16)MapUnit::Map100thMM */" is always false
>>> regardless of the values of its operands. This occurs as the logical first
>>> operand of "||".
462 if (nUnit < sal_Int16(MapUnit::Map100thMM) || nUnit >
sal_Int16(MapUnit::LAST))
463 {
464 SAL_WARN("vcl.gdi", "Parsing error: invalid mapmode");
465 return false;
466 }
467 MapUnit eUnit = static_cast(nUnit);
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3Doo0P_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiKCkzfyxoeQcM5wzPHNpnNYhnHmuGI4YO-2F0xdfF3oWcgfgZvFMXwuWwfCIx8UMZO-2FdAC6eMLXLjm7BlypTHmZBivbagamiEGfFLi6PCP7GFfa5WThz1S5xy4ZmSGUU-2BjF-2FbaluI7tI-2BGbfL14bTYl2rqqtG4SlApvqwwD2UjYE2Y-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
16 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 16 of 16 defect(s)
** CID 1591496: Null pointer dereferences (NULL_RETURNS)
*** CID 1591496: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/layout/atrfrm.cxx: 2637 in SwFrameFormat::SetFormatName(const
rtl::OUString &, bool)()
2631 if (!aHint.m_sOld.isEmpty() && aHint.m_sOld != aHint.m_sNew)
2632 {
2633 if (SwFlyFrame* pSFly = SwIterator(*this).First())
2634 {
2635 if (pSFly->Lower() && !pSFly->Lower()->IsNoTextFrame())
2636 {
>>> CID 1591496: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr"
>>> "static_cast(pSFly->ContainsContent())" when calling
>>> "GetTextNodeFirst".
2637 if (SwTextNode* pSwTxtNode =
static_cast(pSFly->ContainsContent())->GetTextNodeFirst())
2638
pSwTxtNode->resetAndQueueAccessibilityCheck(true);
2639 }
2640 else
2641 {
2642 if (SwNode* pSwNode =
static_cast(pSFly->Lower())->GetNode())
** CID 1591495: Resource leaks (RESOURCE_LEAK)
/test/source/xmltesttools.cxx: 306 in XmlTestTools::assertXPathNodeName(const
std::unique_ptr<_xmlDoc, xmlDocDeleter> &, const rtl::OString &, const
rtl::OString &)()
*** CID 1591495: Resource leaks (RESOURCE_LEAK)
/test/source/xmltesttools.cxx: 306 in XmlTestTools::assertXPathNodeName(const
std::unique_ptr<_xmlDoc, xmlDocDeleter> &, const rtl::OString &, const
rtl::OString &)()
300 CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In <") +
pXmlDoc->name + ">, XPath '" + rXPath + "' number of nodes is
incorrect").getStr(),
301 1,
302 xmlXPathNodeSetGetLength(pXmlNodes));
303 xmlNodePtr pXmlNode = pXmlNodes->nodeTab[0];
304 CPPUNIT_ASSERT_EQUAL_MESSAGE(OString(OString::Concat("In XPath '" +
rXPath + "' name of node is incorrect")).getStr(),
305 rExpectedName,
oconvert(pXmlNode->name));
>>> CID 1591495: Resource leaks (RESOURCE_LEAK)
>>> Variable "pXmlObj" going out of scope leaks the storage it points to.
306 }
307
308 void XmlTestTools::registerODFNamespaces(xmlXPathContextPtr&
pXmlXpathCtx)
309 {
310 xmlXPathRegisterNs(pXmlXpathCtx, BAD_CAST("manifest"),
311
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:manifest:1.0"));
** CID 1591494: Null pointer dereferences (NULL_RETURNS)
*** CID 1591494: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/layout/trvlfrm.cxx: 1533 in
SwRootFrame::GetNextPrevContentPos(const Point &, bool) const()
1527 while ( !pCnt )
1528 {
1529 pPage = static_cast(pPage->GetPrev());
1530 if ( pPage )
1531 pCnt = pPage->ContainsContent();
1532 else
>>> CID 1591494: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr"
>>> "this->ContainsContent()" when calling "UnionFrame".
1533 return ContainsContent()->UnionFrame().Pos();
1534 }
1535 pCnt->Calc(pRenderContext);
1536 }
1537 }
1538
** CID 1591493: Error handling issues (CHECKED_RETURN)
/comphelper/source/xml/xmltools.cxx: 79 in comphelper::xml::makeXMLChaff()()
*** CID 1591493: Error handling issues (CHECKED_RETURN)
/comphelper/source/xml/xmltools.cxx: 79 in comphelper::xml::makeXMLChaff()()
73 {
74 OString makeXMLChaff()
75 {
76 rtlRandomPool pool = rtl_random_createPool();
77
78 sal_Int8 n;
>>> CID 1591493: Error handling issues (CHECKED_RETURN)
>>> Calling "rtl_random_getBytes" without checking return value (as is done
>>> elsewhere 13 out of 16 times).
79 rtl_random_getBytes(pool, , 1);
80
81 sal_Int32 nLength = 1024+n;
82 // coverity[tainted_data] - 1024 deliberate random minus max
-127/plus max 128
83
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
16 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1591435: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 271 in handleGraphicFilterDialog(const
VclPtr &, const Graphic &, const
std::function &)::[lambda(int) (instance
1)]::operator ()(int) const()
*** CID 1591435: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 271 in handleGraphicFilterDialog(const
VclPtr &, const Graphic &, const
std::function &)::[lambda(int) (instance
1)]::operator ()(int) const()
265 pDlg->StartExecuteAsync(
266 [pDlg, aInputGraphic, f] (sal_Int32 nResult)->void
267 {
268 if (nResult == RET_OK)
269 {
270 Graphic aOutputGraphic = pDlg->GetFilteredGraphic(
aInputGraphic, 1.0, 1.0 );
>>> CID 1591435: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aOutputGraphic" is passed-by-value as parameter to
>>> "GraphicObject::GraphicObject(Graphic)" when it could be moved instead.
271 f(aOutputGraphic);
272 }
273 pDlg->disposeOnce();
274 }
275 );
276 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DI_zk_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJihCoBL4HhM-2FUQzSEmVtE14r0kO217z4CU3ew2QzXzxbjrbykpkJBjHh6Oi87IaDXcXR-2BZoBogqGageZ7DQmlYSwofF3aUJ0lYcYiyT2YGPMBgynh7IEpZd87K9I2KnwdbRS0-2FUyocVmZ9x0Li6CEHrLsCNkJ-2B8FtoxGzMZNJf-2Fv0-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
16 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 16 of 16 defect(s)
** CID 1588088: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/drawfunc/drawsh.cxx: 565 in
ScDrawShell::ExecuteTextAttrDlg(SfxRequest &)()
*** CID 1588088: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/drawfunc/drawsh.cxx: 565 in
ScDrawShell::ExecuteTextAttrDlg(SfxRequest &)()
559 weld::Window* pWin = rViewData.GetDialogParent();
560 VclPtr pDlg(pFact->CreateTextTabDialog(pWin,
, pView));
561
562 auto xRequest = std::make_shared(rReq);
563 rReq.Ignore(); // the 'old' request is not relevant any more
564 pDlg->StartExecuteAsync(
>>> CID 1588088: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xRequest" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
565 [pDlg, xRequest, bHasMarked, pView] (sal_Int32 nResult)->void
566 {
567 if ( RET_OK == nResult )
568 {
569 if ( bHasMarked )
570 pView->SetAttributes( *pDlg->GetOutputItemSet() );
** CID 1588087: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/view/tabvwshf.cxx: 695 in
ScTabViewShell::ExecuteMoveTable(SfxRequest &)()
*** CID 1588087: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/view/tabvwshf.cxx: 695 in
ScTabViewShell::ExecuteMoveTable(SfxRequest &)()
689
690 // We support direct renaming of sheet only when one sheet
691 // is selected.
692 pDlg->EnableRenameTable(nTabSelCount == 1);
693
694 std::shared_ptr pReq =
std::make_shared(rReq);
>>> CID 1588087: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pReq" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
695 pDlg->StartExecuteAsync([this, pDlg, pReq,
696 nContextMenuTab](sal_Int32
nResult) {
697
698 OUString aTableName;
699 sal_uInt16 nDocument = 0;
700 SCTAB nTargetIndex = -1;
** CID 1588086: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 266 in handleGraphicFilterDialog(const
VclPtr &, const Graphic &, std::function)()
*** CID 1588086: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/dialog/grfflt.cxx: 266 in handleGraphicFilterDialog(const
VclPtr &, const Graphic &, std::function)()
260
261 static void handleGraphicFilterDialog(const
VclPtr& pDlg,
262 const Graphic& aInputGraphic,
263 std::function f)
264 {
265 pDlg->StartExecuteAsync(
>>> CID 1588086: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "f" is copied in call to copy constructor "std::function>> (GraphicObject)>", when it could be moved instead.
266 [pDlg, aInputGraphic, f] (sal_Int32 nResult)->void
267 {
268 if (nResult == RET_OK)
269 {
270 Graphic aOutputGraphic = pDlg->GetFilteredGraphic(
aInputGraphic, 1.0, 1.0 );
271 f(aOutputGraphic);
** CID 1588085: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/view/tabvwshf.cxx: 818 in
ScTabViewShell::ExecuteMoveTable(SfxRequest &)()
*** CID 1588085: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/view/tabvwshf.cxx: 818 in
ScTabViewShell::ExecuteMoveTable(SfxRequest &)()
812 // is selected.
813 pDlg->EnableRenameTable(nTabSelCount == 1);
814
815 auto xRequest = std::make_shared(rReq);
816 rReq.Ignore(); // the 'old' request is not relevant any more
817 pDlg->StartExecuteAsync(
>>> CID 1588085: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xRequest" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
818 [this, pDlg, xRequest] (sal_Int32 nResult)->void
819 {
820 if (nResult == RET_OK)
821 {
822 DoMoveTableFromDialog(*xRequest, pDlg);
823 }
** CID 1588084:(COPY_INSTEAD_OF_MOVE)
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
29 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1586677: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/string.hxx: 191 in ()
*** CID 1586677: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/string.hxx: 191 in ()
185
186 The design of this class is similar to the string classes in Java
187 and so more people should have fewer understanding problems when they
188 use this class.
189 */
190
>>> CID 1586677: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "rtl::OString" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalues, where a move assignment may be faster.
191 class SAL_WARN_UNUSED SAL_DLLPUBLIC_RTTI OString
192 {
193 public:
194 /// @cond INTERNAL
195 rtl_String * pData;
196 /// @endcond
** CID 1586676: Performance inefficiencies (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/unordered_set.h: 77 in
frozen::unordered_set>, (unsigned long)14,
frozen::elsa>>,
std::equal_to>>>::unordered_set(frozen::bits::carray>, (unsigned long)14>, const
frozen::elsa>> &,
const std::equal_to>> &)()
*** CID 1586676: Performance inefficiencies (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/unordered_set.h: 77 in
frozen::unordered_set>, (unsigned long)14,
frozen::elsa>>,
std::equal_to>>>::unordered_set(frozen::bits::carray>, (unsigned long)14>, const
frozen::elsa>> &,
const std::equal_to>> &)()
71 using const_iterator = const_pointer;
72 using iterator = const_iterator;
73
74 public:
75 /* constructors */
76 unordered_set(unordered_set const &) = default;
>>> CID 1586676: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter keys of type
>>> "frozen::unordered_set>> std::char_traits >, 14ul,
>>> frozen::elsa >
>>> >, std::equal_to>> std::char_traits > > >::container_type" (size 224 bytes) by
>>> value, which exceeds the low threshold of 128 bytes.
77 constexpr unordered_set(container_type keys, Hash const ,
78 KeyEqual const )
79 : equal_{equal}
80 , keys_{keys}
81 , tables_{bits::make_pmh_tables(
82 keys_, hash, bits::Get{}, default_prg_t{})} {}
** CID 1586675: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustring.hxx: 170 in ()
*** CID 1586675: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustring.hxx: 170 in ()
164 functionalities and avoids too much memory allocation.
165
166 The design of this class is similar to the string classes in Java so
167 less people should have understanding problems when they use this
class.
168 */
169
>>> CID 1586675: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "rtl::OUString" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalues, where a move assignment may be faster.
170 class SAL_WARN_UNUSED SAL_DLLPUBLIC_RTTI OUString
171 {
172 public:
173 /// @cond INTERNAL
174 rtl_uString * pData;
175 /// @endcond
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DokP__OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiBq57mMQEVtuAdBaxLBfjo7rODALKx71sJkVhbvUlxq4S6r-2FAmZlhPS82Bppp4qpJL9O0ChWUUgXWYB4Lb1kJ1ifrfM3OGXwMA7i-2F9VJvjS9kJWy9ijbuFuv7twJwDIXg138-2B9DE6bWTiiqFgRmr4WdKR8lQ2k5uWlWjIkL3LChQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1586650: Error handling issues (CHECKED_RETURN)
/sc/source/ui/unoobj/docuno.cxx: 905 in
ScModelObj::hyperlinkInfoAtPosition(int, int)()
*** CID 1586650: Error handling issues (CHECKED_RETURN)
/sc/source/ui/unoobj/docuno.cxx: 905 in
ScModelObj::hyperlinkInfoAtPosition(int, int)()
899 ScGridWindow* pGridWindow = pViewData->GetActiveWin();
900 if (pGridWindow)
901 {
902 const Point point(x * pViewData->GetPPTX(), y *
pViewData->GetPPTY());
903 OUString name;
904 OUString url;
>>> CID 1586650: Error handling issues (CHECKED_RETURN)
>>> Calling "GetEditUrl" without checking return value (as is done
>>> elsewhere 5 out of 6 times).
905 pGridWindow->GetEditUrl(point, , );
906 return url;
907 }
908 }
909
910 return OUString();
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DnUrI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJigMIYWjJCK1vu-2FWSOCMbK49YKbIqBEICRToIbplFHxQONVGv4DOSTa-2FoZ2DBRXPdZ0zXtrsONRIuiyepXm7RmkqwiK7AjbSL5SR1fqIeH4evOJrTe5Ak6kwfS3ndnldfPYcGUtMRr78jPA88Ag9nMYQjdk0G3YlK8ZeLc9FSBzAo-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1586339: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/inc/fstalgorithm.hxx: 67 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator,
mdds::flat_segment_tree::const_iterator)()
*** CID 1586339: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/inc/fstalgorithm.hxx: 67 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator,
mdds::flat_segment_tree::const_iterator)()
61 Key nIndex1 = nLastPos;
62 Key nIndex2 = nThisPos-1;
63 rSpans.push_back(Span(nIndex1, nIndex2, nLastVal));
64 }
65
66 nLastPos = nThisPos;
>>> CID 1586339: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "nThisVal" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
67 nLastVal = nThisVal;
68 }
69 }
70
71 /**
72 * Convert a flat_segment_tree structure whose value type is boolean,
into
** CID 1586338:(UNINIT)
*** CID 1586338:(UNINIT)
/sw/source/core/unocore/unodraw.cxx: 1333 in SwXShape::setPropertyValue(const
rtl::OUString &, const com::sun::star::uno::Any &)()
1327 }
1328 //anchor position has to be inserted after the
text attribute has been inserted
1329 aNewAnchor.SetAnchor( aPam.GetPoint() );
1330 aSet.Put( aNewAnchor );
1331 pFormat->SetFormatAttr(aSet);
1332 bSetAttr = false;
>>> CID 1586338:(UNINIT)
>>> Using uninitialized value
>>> "aNewAnchor.m_oContentAnchor._M_payload._M_payload" when calling
>>> "~SwFormatAnchor".
1333 }
1334 if( text::TextContentAnchorType_AS_CHARACTER ==
eNewAnchor &&
1335 (RndStdIds::FLY_AS_CHAR != eOldAnchorId))
1336 {
1337 SwPaM aPam(pDoc->GetNodes().GetEndOfContent());
1338 if(
pDoc->getIDocumentLayoutAccess().GetCurrentLayout() )
/sw/source/core/unocore/unodraw.cxx: 1360 in SwXShape::setPropertyValue(const
rtl::OUString &, const com::sun::star::uno::Any &)()
1354 aPam.GetPoint()->GetContentIndex(), 0 );
1355 aPam.GetPoint()->AdjustContent(-1); //
InsertItem moved it
1356 SwFormatAnchor aNewAnchor(
1357 aSet.Get(RES_ANCHOR));
1358 aNewAnchor.SetAnchor( aPam.GetPoint() );
1359 aSet.Put( aNewAnchor );
>>> CID 1586338:(UNINIT)
>>> Using uninitialized value
>>> "aNewAnchor.m_oContentAnchor._M_payload._M_payload" when calling
>>> "~SwFormatAnchor".
1360 }
1361 if( bSetAttr )
1362 pFormat->SetFormatAttr(aSet);
1363
1364 // If this property is an anchor change, and there
is a group shape with textboxes
1365 // do anchor sync in time unless the anchor sync
in the porfly will cause crash during
** CID 1586337: Uninitialized variables (UNINIT)
*** CID 1586337: Uninitialized variables (UNINIT)
/sw/source/core/doc/docdraw.cxx: 291 in SwDoc::GroupSelection(SdrView &)()
285
286 if( pUndo )
287 {
288 pUndo->SetGroupFormat( pFormat );
289 GetIDocumentUndoRedo().AppendUndo( std::move(pUndo) );
290 }
>>> CID 1586337: Uninitialized variables (UNINIT)
>>> Using uninitialized value
>>> "aAnch.m_oContentAnchor._M_payload._M_payload" when calling
>>> "~SwFormatAnchor".
291 }
292 else
293 {
294 if (GetIDocumentUndoRedo().DoesUndo())
295 {
296 GetIDocumentUndoRedo().ClearRedo();
To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 28 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1585558: Uninitialized variables (USE_AFTER_MOVE) /chart2/source/model/main/ChartModel.cxx: 181 in chart::ChartModel::ChartModel(const chart::ChartModel&)() *** CID 1585558: Uninitialized variables (USE_AFTER_MOVE) /chart2/source/model/main/ChartModel.cxx: 181 in chart::ChartModel::ChartModel(const chart::ChartModel&)() 175 } 176 } 177 178 ModifyListenerHelper::addListener( xNewTitle, xListener ); 179 if( xNewDiagram && xListener) 180 xNewDiagram->addModifyListener( xListener ); >>> CID 1585558: Uninitialized variables (USE_AFTER_MOVE) >>> "xNewPageBackground" is used after it has been already moved. 181 if( xNewPageBackground && xListener) 182 xNewPageBackground->addModifyListener( xListener ); 183 xListener.clear(); 184 } 185 osl_atomic_decrement(_refCount); 186 } To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DVt8V_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi0T52ytdbCmibfcUwJt5Y8LmM1MMgE-2FoFZM0VJ-2BMINHo0lN7m69t7-2BhAGgRb3TpF-2F31TqerErn4dvsM3By8iV1G9AsheOWzibLqAo8903MikkuO4bg2RezIEFMNvTGzaoJhyrXi3zxGa7MQJtipfrMwJN6gsKFJg-2FCis6Fwlq8fg-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
40 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1585309: Null pointer dereferences (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const
SfxPoolItem *, unsigned short, bool)()
*** CID 1585309: Null pointer dereferences (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const
SfxPoolItem *, unsigned short, bool)()
333 pTargetPool = pTargetPool->GetSecondaryPool();
334
335 // if this goes wrong, an Item with invalid ID for this pool is
336 // processed. This is not allowed (and should not happen, e.g.
337 // ItemSets already have WhichRanges that are checked against
338 // their Pool)
>>> CID 1585309: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pTargetPool" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
339 if (nullptr == pTargetPool)
340 {
341 assert(false);
342 return pSource;
343 }
344
** CID 1585308: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in
SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *,
SvxRulerSupportFlags, SfxBindings &, long)()
*** CID 1585308: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in
SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *,
SvxRulerSupportFlags, SfxBindings &, long)()
95 maFadeTimer.SetInvokeHandler(LINK(this, SwCommentRuler,
FadeHandler));
96
97 // we have a little bit more space, as we don't draw ruler ticks
98 vcl::Font aFont(maVirDev->GetFont());
99 aFont.SetFontHeight(aFont.GetFontHeight() + 1);
100 maVirDev->SetFont(aFont);
>>> CID 1585308: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mbIsDrag" is not initialized in this
>>> constructor nor in any functions that it calls.
101 }
102
103 SwCommentRuler::~SwCommentRuler() { disposeOnce(); }
104
105 void SwCommentRuler::dispose()
106 {
** CID 1585307:(OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in
chart::VSeriesPlotter::getRenderOrder() const()
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in
chart::VSeriesPlotter::getRenderOrder() const()
*** CID 1585307:(OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in
chart::VSeriesPlotter::getRenderOrder() const()
2338 } // unnamed
2339
2340 sal_Int32 VSeriesPlotter::getRenderOrder() const
2341 {
2342 OUString aChartType = m_xChartTypeModel->getChartType();
2343 for (size_t n = 0; n < sizeof(pairList); ++n) {
>>> CID 1585307:(OVERRUN)
>>> Overrunning array "chartpairList" of 10 16-byte elements
>>> at element index 159 (byte offset 2559) using index "n" (which evaluates to
>>> 159).
2344 if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
2345 return pairList[n].renderOrder;
2346 }
2347 }
2348 SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349 return 0;
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in
chart::VSeriesPlotter::getRenderOrder() const()
2339
2340 sal_Int32 VSeriesPlotter::getRenderOrder() const
2341 {
2342 OUString aChartType = m_xChartTypeModel->getChartType();
2343 for (size_t n = 0; n < sizeof(pairList); ++n) {
2344 if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
>>> CID 1585307:(OVERRUN)
>>> Overrunning array "chartpairList" of 10 16-byte elements
>>> at element index 159 (byte offset 2559) using index "n" (which evaluates to
>>> 159).
2345 return pairList[n].renderOrder;
2346 }
2347 }
2348 SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349 return 0;
2350 }
** CID 1585306: Uninitialized members (UNINIT_CTOR)
/sc/source/ui/cctrl/tbzoomsliderctrl.cxx: 228 in
ScZoomSlider::ScZoomSlider(com::sun::star::uno::Reference,
unsigned short)()
*** CID 1585306: Uninitialized members (UNINIT_CTOR)
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
19 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1583765: Memory - corruptions (BAD_FREE)
*** CID 1583765: Memory - corruptions (BAD_FREE)
/sw/source/core/txtnode/thints.cxx: 1183 in MakeTextAttr(SwDoc &, const
SfxItemSet &, int, int)()
1177 sal_Int32 nStt, sal_Int32 nEnd )
1178 {
1179 IStyleAccess& rStyleAccess = rDoc.GetIStyleAccess();
1180 const std::shared_ptr pAutoStyle =
rStyleAccess.getAutomaticStyle( rSet, IStyleAccess::AUTO_STYLE_CHAR );
1181 SwFormatAutoFormat aNewAutoFormat;
1182 aNewAutoFormat.SetStyleHandle( pAutoStyle );
>>> CID 1583765: Memory - corruptions (BAD_FREE)
>>> "MakeTextAttr" frees address of "aNewAutoFormat".
1183 SwTextAttr* pNew = MakeTextAttr( rDoc, aNewAutoFormat, nStt, nEnd
);
1184 return pNew;
1185 }
1186
1187 // delete the text attribute and unregister its item at the pool
1188 void SwTextNode::DestroyAttr( SwTextAttr* pAttr )
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D442V_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiQVe0uTPxDqiopw-2Bjnu9uM-2FuJPMryRdazLTC4bjKBq-2FvkkxrvmRJgNdX5HLVSNJONrKqpO26p6SYuP9eq5Q0iByER-2B3OlKOOMGaSzx9LSGPKPjM4Z8hAjs10HNSwvgE3ZxNmSwEGBD4JkKadw3N5hBTUdhmk8xfXAU6gOPAWgS-2BI-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
147 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1583748:(FORWARD_NULL)
*** CID 1583748:(FORWARD_NULL)
/sc/source/ui/app/inputhdl.cxx: 3864 in ScInputHandler::KeyInput(const KeyEvent
&, bool)()
3858
3859 if (pActiveViewSh)
3860 pActiveViewSh->MoveCursorEnter( bShift &&
!bControl );
3861
3862 ScModule* pScMod = SC_MOD();
3863 const ScInputOptions& rOpt = pScMod->GetInputOptions();
>>> CID 1583748:(FORWARD_NULL)
>>> Passing null pointer "this->pActiveViewSh" to "GetMoveKeepEdit", which
>>> dereferences it.
3864 if ( (rOpt.GetMoveKeepEdit() &&
!comphelper::LibreOfficeKit::isActive())
3865 || (pActiveViewSh->GetMoveKeepEdit() &&
comphelper::LibreOfficeKit::isActive()) )
3866 pScMod->SetInputMode( SC_INPUT_TABLE );
3867
3868 bUsed = true;
3869 }
/sc/source/ui/app/inputhdl.cxx: 3818 in ScInputHandler::KeyInput(const KeyEvent
&, bool)()
3812 if (pActiveViewSh)
3813 pActiveViewSh->FindNextUnprot( bShift, true );
3814
3815 ScModule* pScMod = SC_MOD();
3816 const ScInputOptions& rOpt = pScMod->GetInputOptions();
3817
>>> CID 1583748:(FORWARD_NULL)
>>> Passing null pointer "this->pActiveViewSh" to "GetMoveKeepEdit", which
>>> dereferences it.
3818 if ( (rOpt.GetMoveKeepEdit() &&
!comphelper::LibreOfficeKit::isActive())
3819 || (pActiveViewSh->GetMoveKeepEdit() &&
comphelper::LibreOfficeKit::isActive()) )
3820 pScMod->SetInputMode( SC_INPUT_TABLE );
3821
3822 return true;
3823 }
** CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.cxx: 1559 in
basctl::ModulWindowLayout::ApplyColorSchemeToCurrentWindow(rtl::OUString)()
*** CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.cxx: 1559 in
basctl::ModulWindowLayout::ApplyColorSchemeToCurrentWindow(rtl::OUString)()
1553
1554 // Applies the color scheme to the current window and updates color
definitions;
1555 // note that other ModulWindow instances are not affected by calling
this method
1556 void ModulWindowLayout::ApplyColorSchemeToCurrentWindow(OUString
aSchemeId)
1557 {
1558 // Apply new color scheme to the UI
>>> CID 1583747: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aSchemeId" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
1559 m_sColorSchemeId = aSchemeId;
1560 aSyntaxColors.ApplyColorScheme(m_sColorSchemeId, false);
1561 }
1562
1563 ModulWindowLayout::SyntaxColors::SyntaxColors ()
1564 : pEditor(nullptr)
** CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/ColorSchemeDialog.cxx: 37 in
basctl::ColorSchemeDialog::ColorSchemeDialog(weld::Window *,
VclPtr)()
*** CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/ColorSchemeDialog.cxx: 37 in
basctl::ColorSchemeDialog::ColorSchemeDialog(weld::Window *,
VclPtr)()
31
32 namespace basctl
33 {
34 ColorSchemeDialog::ColorSchemeDialog(weld::Window* pParent,
35 VclPtr
pModulWinLayout)
36 : GenericDialogController(pParent,
"modules/BasicIDE/ui/colorscheme.ui", "ColorSchemeDialog")
>>> CID 1583746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pModulWinLayout" is copied in call to copy constructor
>>> "VclPtr", when it could be moved instead.
37 , m_pModulWinLayout(pModulWinLayout)
38 , m_xSchemeList(m_xBuilder->weld_tree_view("schemelist"))
39 , m_xUseAppCollors(m_xBuilder->weld_radio_button("opt_appcolors"))
40 , m_xUseScheme(m_xBuilder->weld_radio_button("opt_usescheme"))
41 , m_xOk(m_xBuilder->weld_button("btn_ok"))
42 {
** CID 1583745: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/basctl/source/basicide/baside2.hxx: 451 in
basctl::ModulWindowLayout::SyntaxColors::SetActiveColorSchemeId(rtl::OUString)()
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
11 new defect(s) introduced to LibreOffice found with Coverity Scan.
46 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 11 of 11 defect(s)
** CID 1583700: Uninitialized variables (UNINIT)
/sc/source/core/tool/token.cxx: 3357 in
ScTokenArray::AdjustReferenceOnShift(const sc::RefUpdateContext &, const
ScAddress &)()
*** CID 1583700: Uninitialized variables (UNINIT)
/sc/source/core/tool/token.cxx: 3357 in
ScTokenArray::AdjustReferenceOnShift(const sc::RefUpdateContext &, const
ScAddress &)()
3351 ; // nothing
3352 }
3353 }
3354 }
3355 }
3356
>>> CID 1583700: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aRes". Field "aRes.nTab" is uninitialized.
3357 return aRes;
3358 }
3359
3360 sc::RefUpdateResult ScTokenArray::AdjustReferenceOnMove(
3361 const sc::RefUpdateContext& rCxt, const ScAddress& rOldPos, const
ScAddress& rNewPos )
3362 {
** CID 1583699: Uninitialized variables (UNINIT)
/sc/source/core/tool/token.cxx: 4395 in
ScTokenArray::AdjustReferenceOnInsertedTab(const sc::RefUpdateInsertTabContext
&, const ScAddress &)()
*** CID 1583699: Uninitialized variables (UNINIT)
/sc/source/core/tool/token.cxx: 4395 in
ScTokenArray::AdjustReferenceOnInsertedTab(const sc::RefUpdateInsertTabContext
&, const ScAddress &)()
4389 default:
4390 ; // nothing
4391 }
4392 }
4393 }
4394 }
>>> CID 1583699: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aRes". Field "aRes.nTab" is uninitialized.
4395 return aRes;
4396 }
4397
4398 namespace {
4399
4400 bool adjustTabOnMove( ScAddress& rPos, const
sc::RefUpdateMoveTabContext& rCxt )
** CID 1583698:(MISSING_MOVE_ASSIGNMENT)
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
/include/rtl/ref.hxx: 45 in ()
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 300 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1560054:(MISSING_MOVE_ASSIGNMENT) /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in () /include/com/sun/star/uno/Reference.h: 183 in ()
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
32 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1559993:(DIVIDE_BY_ZERO)
/sw/source/ui/dialog/wordcountdialog.cxx: 73 in
SwWordCountFloatDlg::SetValues(const SwDocStat &, const SwDocStat &)()
/sw/source/ui/dialog/wordcountdialog.cxx: 75 in
SwWordCountFloatDlg::SetValues(const SwDocStat &, const SwDocStat &)()
*** CID 1559993:(DIVIDE_BY_ZERO)
/sw/source/ui/dialog/wordcountdialog.cxx: 73 in
SwWordCountFloatDlg::SetValues(const SwDocStat &, const SwDocStat &)()
67 setValue(*m_xDocCjkcharsFT, rDoc.nAsianWord, rLocaleData);
68 setValue(*m_xDocComments, rCurrent.nComments, rLocaleData);
69
70 if (m_xStandardizedPagesLabelFT->get_visible())
71 {
72 sal_Int64 nCharsPerStandardizedPage =
officecfg::Office::Writer::WordCount::StandardizedPageSize::get();
>>> CID 1559993:(DIVIDE_BY_ZERO)
>>> In expression "static_cast(rCurrent.nChar) /
>>> nCharsPerStandardizedPage", division by expression
>>> "nCharsPerStandardizedPage" which may be zero has undefined behavior.
73 setDoubleValue(*m_xCurrentStandardizedPagesFT,
74 static_cast(rCurrent.nChar) /
nCharsPerStandardizedPage);
75 setDoubleValue(*m_xDocStandardizedPagesFT,
76 static_cast(rDoc.nChar) / nCharsPerStandardizedPage);
77 }
78
/sw/source/ui/dialog/wordcountdialog.cxx: 75 in
SwWordCountFloatDlg::SetValues(const SwDocStat &, const SwDocStat &)()
69
70 if (m_xStandardizedPagesLabelFT->get_visible())
71 {
72 sal_Int64 nCharsPerStandardizedPage =
officecfg::Office::Writer::WordCount::StandardizedPageSize::get();
73 setDoubleValue(*m_xCurrentStandardizedPagesFT,
74 static_cast(rCurrent.nChar) /
nCharsPerStandardizedPage);
>>> CID 1559993:(DIVIDE_BY_ZERO)
>>> In expression "static_cast(rDoc.nChar) /
>>> nCharsPerStandardizedPage", division by expression
>>> "nCharsPerStandardizedPage" which may be zero has undefined behavior.
75 setDoubleValue(*m_xDocStandardizedPagesFT,
76 static_cast(rDoc.nChar) / nCharsPerStandardizedPage);
77 }
78
79 bool bShowCJK = (SvtCJKOptions::IsAnyEnabled() || rDoc.nAsianWord);
80 bool bToggleCJK = m_xCurrentCjkcharsFT->get_visible() != bShowCJK;
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DO6zB_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJigysQen5OMfnry610iZ10vzbkx1obUyWBwekGKbjMuStv74Cl-2B6kiQvtj68-2F6eJKhc1RzQ2b47pSEKGRPx3z-2Fn5Opuu3pN5YFr5FgMl2tpxx5YjNYIm1I0IBPPViZyKyI-2FXdttgv19DYUIS8VhklVNYB30oc1qKEDoO1lafgp5xU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
25 new defect(s) introduced to LibreOffice found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 25 defect(s)
** CID 1559969: Uninitialized variables (UNINIT)
*** CID 1559969: Uninitialized variables (UNINIT)
/sc/source/core/data/poolcach.cxx: 74 in ScItemPoolCache::ApplyTo(const
CellAttributeHolder &)()
68 }
69 else
70 {
71 pNewItem->GetItemSet().Put(*pSetToPut);
72 }
73
>>> CID 1559969: Uninitialized variables (UNINIT)
>>> Using uninitialized value "pNewItem->pName._M_payload._M_payload" when
>>> calling "CellAttributeHolder".
74 m_aCache.emplace_back(rOrigItem, CellAttributeHolder(pNewItem,
true));
75 return m_aCache.back().aModified;
76 }
77
78
** CID 1559968: Uninitialized variables (UNINIT)
*** CID 1559968: Uninitialized variables (UNINIT)
/sc/source/ui/undo/undocell.cxx: 252 in ScUndoEnterData::Undo()()
246 rDoc.ApplyAttr(maPos.Col(), maPos.Row(), rVal.mnTab,
247 SfxUInt32Item(ATTR_VALUE_FORMAT,
rVal.mnFormat));
248 else
249 {
250 ScPatternAttr* pPattern(new
ScPatternAttr(*rDoc.GetPattern(maPos.Col(), maPos.Row(), rVal.mnTab)));
251 pPattern->GetItemSet().ClearItem( ATTR_VALUE_FORMAT );
>>> CID 1559968: Uninitialized variables (UNINIT)
>>> Using uninitialized value "pPattern->pName._M_payload._M_payload" when
>>> calling "CellAttributeHolder".
252 rDoc.SetPattern(maPos.Col(), maPos.Row(), rVal.mnTab,
CellAttributeHolder(pPattern, true));
253 }
254 pDocShell->PostPaintCell(maPos.Col(), maPos.Row(), rVal.mnTab);
255 }
256
257 ScChangeTrack* pChangeTrack = rDoc.GetChangeTrack();
** CID 1559967: Uninitialized variables (UNINIT)
*** CID 1559967: Uninitialized variables (UNINIT)
/sc/source/core/data/attarray.cxx: 1624 in ScAttrArray::ApplyFlags(int, int,
ScMF)()
1618 if ( (nOldValue | nFlags) != nOldValue )
1619 {
1620 nRow = mvData[nIndex].nEndRow;
1621 SCROW nAttrRow = std::min( nRow, nEndRow );
1622 ScPatternAttr* pNewPattern(new
ScPatternAttr(*pOldPattern));
1623 pNewPattern->GetItemSet().Put( ScMergeFlagAttr( nOldValue
| nFlags ) );
>>> CID 1559967: Uninitialized variables (UNINIT)
>>> Using uninitialized value "pNewPattern->pName._M_payload._M_payload"
>>> when calling "CellAttributeHolder".
1624 SetPatternArea( nThisRow, nAttrRow,
CellAttributeHolder(pNewPattern, true) );
1625 Search( nThisRow, nIndex ); // data changed
1626 bChanged = true;
1627 }
1628
1629 ++nIndex;
** CID 1559966: Uninitialized variables (UNINIT)
*** CID 1559966: Uninitialized variables (UNINIT)
/sc/source/core/data/attarray.cxx: 2439 in ScAttrArray::CopyArea(int, int,
long, ScAttrArray&, ScMF) const()
2433
2434 if (bSameCellAttributeHelper)
2435 aNewPattern.setScPatternAttr(pTmpPattern, true);
2436 else
2437 {
2438 aNewPattern = pTmpPattern->MigrateToDocument(
, );
>>> CID 1559966: Uninitialized variables (UNINIT)
>>> Using uninitialized value "pTmpPattern->pName._M_payload._M_payload"
>>> when calling "~ScPatternAttr".
2439 delete pTmpPattern;
2440 }
2441 }
2442 else
2443 {
2444 if (bSameCellAttributeHelper)
** CID 1559965: Memory - corruptions (USE_AFTER_FREE)
/sc/inc/fstalgorithm.hxx: 69 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator,
mdds::flat_segment_tree::const_iterator)()
*** CID 1559965: Memory - corruptions (USE_AFTER_FREE)
/sc/inc/fstalgorithm.hxx: 69 in sc::buildSpanWithValue::PatternSpan>(std::vector> &, mdds::flat_segment_tree::const_iterator,
mdds::flat_segment_tree::const_iterator)()
63 rSpans.push_back(Span(nIndex1, nIndex2, nLastVal));
64 }
65
66
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
74 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1559939: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/tbxctrls/PaletteManager.cxx: 409 in
PaletteManager::PopupColorPicker(weld::Window *, const rtl::OUString &, const
Color &)()
*** CID 1559939: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/tbxctrls/PaletteManager.cxx: 409 in
PaletteManager::PopupColorPicker(weld::Window *, const rtl::OUString &, const
Color &)()
403 // The calling object goes away during aColorDlg.Execute(), so we
must copy this
404 OUString aCommandCopy = aCommand;
405 m_pColorDlg = std::make_unique();
406 m_pColorDlg->SetColor(rInitialColor);
407 m_pColorDlg->SetMode(svtools::ColorPickerMode::Modify);
408 std::shared_ptr xSelf(shared_from_this());
>>> CID 1559939: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xSelf" is copied in call to copy constructor
>>> "std::shared_ptr", when it could be moved instead.
409 m_pColorDlg->ExecuteAsync(pParent, [xSelf, aCommandCopy] (sal_Int32
nResult) {
410 if (nResult == RET_OK)
411 {
412 Color aLastColor = xSelf->m_pColorDlg->GetColor();
413 OUString sColorName = "#" +
aLastColor.AsRGBHexString().toAsciiUpperCase();
414 NamedColor aNamedColor(aLastColor, sColorName);
** CID 1559938: Null pointer dereferences (NULL_RETURNS)
*** CID 1559938: Null pointer dereferences (NULL_RETURNS)
/sd/source/ui/dlg/LayerTabBar.cxx: 182 in
sd::LayerTabBar::BringLayerObjectsToAttention(unsigned short)()
176 SdrLayerAdmin& rLayerAdmin =
pDrViewSh->GetDoc()->GetLayerAdmin();
177 SdrObjListIter aIter(pDrViewSh->GetActualPage(),
SdrIterMode::DeepWithGroups);
178 while (aIter.IsMore())
179 {
180 SdrObject* pObj = aIter.Next();
181 assert(pObj != nullptr);
>>> CID 1559938: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr"
>>> "rLayerAdmin->GetLayerPerID(pObj->GetLayer())->GetName()" when calling
>>> "operator ==".
182 if (pObj && (aLayerName ==
rLayerAdmin.GetLayerPerID(pObj->GetLayer())->GetName()))
183 {
184 ::tools::Rectangle aRect(pObj->GetLogicRect());
185 if (!aRect.IsEmpty())
186 aRanges.emplace_back(aRect.Left(), aRect.Top(),
aRect.Right(), aRect.Bottom());
187 // skip over objects in groups
** CID 1559937: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/cui/source/dialogs/colorpicker.cxx: 1349 in
cuiColorPicker::startExecuteModal(const
com::sun::star::uno::Reference
&)()
*** CID 1559937: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/cui/source/dialogs/colorpicker.cxx: 1349 in
cuiColorPicker::startExecuteModal(const
com::sun::star::uno::Reference
&)()
1343 }
1344
1345 void SAL_CALL ColorPicker::startExecuteModal( const
css::uno::Reference< css::ui::dialogs::XDialogClosedListener >& xListener )
1346 {
1347 std::shared_ptr xDlg =
std::make_shared(Application::GetFrameWeld(mxParent),
mnColor, mnMode);
1348 rtl::Reference xThis(this);
>>> CID 1559937: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xThis" is copied in call to copy constructor
>>> "rtl::Reference::ColorPicker>", when it could be moved
>>> instead.
1349 weld::DialogController::runAsync(xDlg, [xThis, xDlg, xListener]
(sal_Int32 nResult) {
1350 if (nResult)
1351 xThis->mnColor = xDlg->GetColor();
1352
1353 sal_Int16 nRet = static_cast(nResult);
1354 css::ui::dialogs::DialogClosedEvent aEvent( *xThis, nRet );
To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
19 new defect(s) introduced to LibreOffice found with Coverity Scan.
23 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 19 of 19 defect(s)
** CID 1559884: Uninitialized variables (UNINIT)
*** CID 1559884: Uninitialized variables (UNINIT)
/sw/source/uibase/sidebar/PageSizeControl.cxx: 124 in
sw::sidebar::PageSizeControl::PageSizeControl(PageSizePopup *, weld::Widget *)()
118 bool bLandscape = false;
119 const SvxSizeItem* pSize(nullptr);
120 if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
121 {
122 SfxPoolItemHolder aResult;
123
pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE, aResult );
>>> CID 1559884: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aResult.m_bDeleted" when calling "getItem".
124 bLandscape = static_cast(aResult.getItem())->IsLandscape();
125
pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_SIZE,
aResult);
126 pSize = static_cast(aResult.getItem());
127 }
128
129 const LocaleDataWrapper& localeDataWrapper =
Application::GetSettings().GetLocaleDataWrapper();
** CID 1559883: Uninitialized variables (UNINIT)
*** CID 1559883: Uninitialized variables (UNINIT)
/sw/source/uibase/sidebar/PageColumnControl.cxx: 44 in
sw::sidebar::PageColumnControl::PageColumnControl(PageColumnPopup *,
weld::Widget *)()
38 {
39 bool bLandscape = false;
40 if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
41 {
42 SfxPoolItemHolder aResult;
43
pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE, aResult);
>>> CID 1559883: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aResult.m_bDeleted" when calling "getItem".
44 const SvxPageItem* pPageItem(static_cast(aResult.getItem()));
45 bLandscape = pPageItem->IsLandscape();
46 }
47
48 if ( bLandscape )
49 {
** CID 1559882: Uninitialized members (UNINIT_CTOR)
/svl/source/items/itemset.cxx: 103 in
SfxPoolItemHolder::SfxPoolItemHolder(const SfxPoolItemHolder&)()
*** CID 1559882: Uninitialized members (UNINIT_CTOR)
/svl/source/items/itemset.cxx: 103 in
SfxPoolItemHolder::SfxPoolItemHolder(const SfxPoolItemHolder&)()
97 assert(!rHolder.isDeleted() && "Destructed instance used (!)");
98 nAllocatedSfxPoolItemHolderCount++;
99 nUsedSfxPoolItemHolderCount++;
100 #endif
101 if (nullptr != m_pItem)
102 m_pItem = implCreateItemEntry(*m_pPool, m_pItem,
m_pItem->Which(), false);
>>> CID 1559882: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_bDeleted" is not initialized in this
>>> constructor nor in any functions that it calls.
103 }
104
105 SfxPoolItemHolder::~SfxPoolItemHolder()
106 {
107 #ifdef DBG_UTIL
108 assert(!isDeleted() && "Destructed instance used (!)");
** CID 1559881: Uninitialized variables (UNINIT)
*** CID 1559881: Uninitialized variables (UNINIT)
/sw/source/uibase/sidebar/PageSizeControl.cxx: 202 in
sw::sidebar::PageSizeControl::ExecuteSizeChange(Paper)()
196 SfxViewFrame* pViewFrm = SfxViewFrame::Current();
197 if (!pViewFrm)
198 return;
199
200 SfxPoolItemHolder aResult;
201 pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE,
aResult);
>>> CID 1559881: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aResult.m_bDeleted" when calling "getItem".
202 const SvxPageItem* pItem(static_cast(aResult.getItem()));
203 bLandscape = pItem->IsLandscape();
204
205 SvxSizeItem aPageSizeItem(SID_ATTR_PAGE_SIZE);
206 Size aPageSize = SvxPaperInfo::GetPaperSize( ePaper, eUnit );
207 if ( bLandscape )
** CID 1559880: Uninitialized variables (UNINIT)
*** CID 1559880: Uninitialized variables (UNINIT)
/sd/source/ui/unoidl/unomodel.cxx: 2472 in
SdXImpressDocument::isMasterViewMode()()
2466 return false;
2467
2468 if (pViewSh->GetDispatcher())
2469 {
2470
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
49 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1559857: Memory - corruptions (OVERRUN)
/sd/source/filter/eppt/pptx-epptbase.cxx: 434 in PPTWriterBase::GetLayout(int)()
*** CID 1559857: Memory - corruptions (OVERRUN)
/sd/source/filter/eppt/pptx-epptbase.cxx: 434 in PPTWriterBase::GetLayout(int)()
428 return pPHLayout[ GetLayoutOffsetFixed( rXPropSet ) ];
429 }
430
431 PHLayout const & PPTWriterBase::GetLayout( sal_Int32 nOffset )
432 {
433 if( nOffset >= 0 && nOffset < EPP_LAYOUT_SIZE )
>>> CID 1559857: Memory - corruptions (OVERRUN)
>>> "pPHLayout[nOffset]" evaluates to an address that is at byte offset 700
>>> of an array of 500 bytes.
434 return pPHLayout[ nOffset ];
435
436 SAL_INFO("sd.eppt", "asked " << nOffset << " for layout outside of
0, " << EPP_LAYOUT_SIZE << " array scope");
437
438 return pPHLayout[ 0 ];
439 }
** CID 1559856: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/view/viewfrm.cxx: 2551 in
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool)()
*** CID 1559856: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/view/viewfrm.cxx: 2551 in
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool)()
2545 SfxObjectFactory& rDocFact = GetObjectShell()->GetFactory();
2546 const SfxInterfaceId nViewId = ( bIsIndex || !nViewIdOrNo ) ?
rDocFact.GetViewFactory( nViewIdOrNo ).GetOrdinal() :
SfxInterfaceId(nViewIdOrNo);
2547
2548 // save the view data of the old view, so it can be restored
later on (when needed)
2549 SaveCurrentViewData_Impl( nViewId );
2550
>>> CID 1559856: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pOldSh" to "SetDying", which dereferences it.
>>> (The dereference happens because this is a virtual function call.)
2551 pOldSh->SetDying();
2552
2553 // create and load new ViewShell
2554 SfxViewShell* pNewSh = LoadViewIntoFrame_Impl(
2555 *GetObjectShell(),
2556 GetFrame().GetFrameInterface(),
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D7U63_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi3kiqkTfWIAMClNn6pAvWk2hXxzsNdrgaYZbALoaTa1-2Biq7JePOTZbSgFFo-2F6j9-2FucNjekMO5b5PWZ9K50-2FFfifv6XhUPZlKcRNzCkwaDmGyQWDIAgoVC5fsVmt9-2FGJ8vnJ2LKLsnwjMhNfARuosk-2B1V7dFJMI9S9nD1Ia-2F7gEEI-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
50 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1559313: Null pointer dereferences (NULL_RETURNS)
*** CID 1559313: Null pointer dereferences (NULL_RETURNS)
/sc/source/ui/view/output.cxx: 2604 in ScOutputData::AddPDFNotes()()
2598
2599 // Note title is the cell address (as on
printed note pages)
2600 ScAddress aAddress( nMergeX, nMergeY, nTab );
2601 aNote.Title =
aAddress.Format(ScRefFlags::VALID, mpDoc, mpDoc->GetAddressConvention());
2602
2603 // Content has to be a simple string without
line breaks
>>> CID 1559313: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pNote" when calling
>>> "GetText".
2604 OUString aContent = pNote->GetText();
2605 aNote.Contents = aContent.replaceAll("\n", "
");
2606
2607 pPDFData->CreateNote( aNoteRect, aNote );
2608 }
2609 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DIL98_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi2wJbLo4SieEDO47Z86J2qHiYTc68ToGCAScYAxXsrQ6h-2Brwf6c60AtoSxv7dg3zNC3VNrGJrHkEi8HaVXIezgLnlbCqRg2htZZjGIPBKjLfR-2BoQwU5PvaUsGTj8rusn-2FAP7YVtiQp25eZ1yWzNHYG2JPfFbU6D0VEQKdEUo6uu4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
46 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1559193: Memory - illegal accesses (UNINIT)
/include/tools/globname.hxx: 33 in operator <=>(const SvGUID &, const SvGUID
&)()
*** CID 1559193: Memory - illegal accesses (UNINIT)
/include/tools/globname.hxx: 33 in operator <=>(const SvGUID &, const SvGUID
&)()
27 struct SAL_WARN_UNUSED SvGUID
28 {
29 sal_uInt32 Data1;
30 sal_uInt16 Data2;
31 sal_uInt16 Data3;
32 sal_uInt8 Data4[8];
>>> CID 1559193: Memory - illegal accesses (UNINIT)
>>> Using uninitialized value "".
33 friend constexpr auto operator<=>(const SvGUID&, const SvGUID&) =
default;
34 friend constexpr bool operator==(const SvGUID&, const SvGUID&) =
default;
35 };
36
37 class SvStream;
38
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DDQst_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiiRBXFEWdzZPNhFi3L0knIctzjmuZ2HDuSCyiB3WHpShTTsHFUrXSdYfTvciNo-2BTRMUmxKPUYv-2Fz2fXveSdEexaJc5z402TUJiXdua7bxOwWmsZChwmzYP8eLC9-2FKVxKZVsO2dT2mHlkOGobl-2FHEJwMQu-2FcXXrTY66IphEXTVGoc-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
70 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1559173: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/eventmultiplexer.cxx: 1299 in
slideshow::internal::EventMultiplexer::toNormalPoint(const
com::sun::star::uno::Reference &, const
basegfx::B2DPoint &)()
*** CID 1559173: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/eventmultiplexer.cxx: 1299 in
slideshow::internal::EventMultiplexer::toNormalPoint(const
com::sun::star::uno::Reference &, const
basegfx::B2DPoint &)()
1293 }
1294
1295 basegfx::B2DPoint EventMultiplexer::toNormalPoint(const
uno::Reference& xInterface,
1296 const
basegfx::B2DPoint& pnt)
1297 {
1298 uno::Reference xView(xInterface,
uno::UNO_QUERY_THROW);
>>> CID 1559173: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xView" is passed-by-value as parameter to "toNormalPoint" when it
>>> could be moved instead.
1299 return mpImpl->toNormalPoint(xView, pnt);
1300 }
1301
1302 } // namespace presentation
1303
** CID 1559172: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/eventmultiplexer.cxx: 1292 in
slideshow::internal::EventMultiplexer::toMatrixPoint(const
com::sun::star::uno::Reference &, const
basegfx::B2DPoint &)()
*** CID 1559172: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/eventmultiplexer.cxx: 1292 in
slideshow::internal::EventMultiplexer::toMatrixPoint(const
com::sun::star::uno::Reference &, const
basegfx::B2DPoint &)()
1286 }
1287
1288 basegfx::B2DPoint EventMultiplexer::toMatrixPoint(const
uno::Reference& xInterface,
1289 const
basegfx::B2DPoint& pnt)
1290 {
1291 uno::Reference xView(xInterface,
uno::UNO_QUERY_THROW);
>>> CID 1559172: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xView" is passed-by-value as parameter to "toMatrixPoint" when it
>>> could be moved instead.
1292 return mpImpl->toMatrixPoint(xView, pnt);
1293 }
1294
1295 basegfx::B2DPoint EventMultiplexer::toNormalPoint(const
uno::Reference& xInterface,
1296 const
basegfx::B2DPoint& pnt)
1297 {
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D9QKo_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJioULrH9AQU2iCiNG402wJeZZcQh1N7xjme43VLYkYPWXasLJzIuYufBdIJVb-2Br1DcvDzgIbfrmRrzkL5s1pfgjXoa-2BUctKvPYa6B-2BpspGJyid-2Fs-2F7Mw3m-2FgJcKFnQCE5JXW-2BPV6b1OT-2BUF9xMepMzUeD-2Bx4kAgQmAJ0dOK7Z54m4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
45 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1558833: Uninitialized members (UNINIT_CTOR)
/configmgr/source/localizedvaluenode.cxx: 38 in
configmgr::LocalizedValueNode::LocalizedValueNode(int)()
*** CID 1558833: Uninitialized members (UNINIT_CTOR)
/configmgr/source/localizedvaluenode.cxx: 38 in
configmgr::LocalizedValueNode::LocalizedValueNode(int)()
32 LocalizedValueNode::LocalizedValueNode(int layer, css::uno::Any value):
33 Node(layer), value_(std::move(value)), modified_(false)
34 {}
35
36 LocalizedValueNode::LocalizedValueNode(int layer):
37 Node(layer)
>>> CID 1558833: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "modified_" is not initialized in this
>>> constructor nor in any functions that it calls.
38 {}
39
40 rtl::Reference< Node > LocalizedValueNode::clone(bool) const {
41 return new LocalizedValueNode(*this);
42 }
43
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DbAXC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJizsXYzB20AENTXYWij-2BRRRCQjMemO5KotBmb4V5RRrDTmu2L5En5vuufaVR0Wg9iDCrF3787eEbn9V2-2FdV0pTgqYNI5sWl30h248tLN66sJ6d2DiFSoNZ2j0Sm5Vh6G6kGzESDqJwt6JOFMIQVnA7rFO-2FaYVAWsXaVx0uXxndzqs-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
37 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1558798:(CHECKED_RETURN)
/vcl/source/outdev/font.cxx: 1031 in OutputDevice::ForceFallbackFont(const
vcl::Font &)()
/vcl/source/outdev/font.cxx: 1027 in OutputDevice::ForceFallbackFont(const
vcl::Font &)()
*** CID 1558798:(CHECKED_RETURN)
/vcl/source/outdev/font.cxx: 1031 in OutputDevice::ForceFallbackFont(const
vcl::Font &)()
1025 vcl::Font aOldFont = GetFont();
1026 SetFont(rFallbackFont);
1027 InitFont();
1028
1029 mpForcedFallbackInstance = mpFontInstance;
1030 SetFont(aOldFont);
>>> CID 1558798:(CHECKED_RETURN)
>>> Calling "InitFont" without checking return value (as is done elsewhere
>>> 11 out of 13 times).
1031 InitFont();
1032
1033 if (mpForcedFallbackInstance)
1034 return true;
1035
1036 return false;
/vcl/source/outdev/font.cxx: 1027 in OutputDevice::ForceFallbackFont(const
vcl::Font &)()
1021 }
1022
1023 bool OutputDevice::ForceFallbackFont(vcl::Font const& rFallbackFont)
1024 {
1025 vcl::Font aOldFont = GetFont();
1026 SetFont(rFallbackFont);
>>> CID 1558798:(CHECKED_RETURN)
>>> Calling "InitFont" without checking return value (as is done elsewhere
>>> 11 out of 13 times).
1027 InitFont();
1028
1029 mpForcedFallbackInstance = mpFontInstance;
1030 SetFont(aOldFont);
1031 InitFont();
1032
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D7a2y_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJimbt-2BNOGakoBgdcaDjKDqx-2B2x5N0kjR5ngWSo5c3f3-2BBLo6ifIEAXvnlQ7W5RUKqO-2BB-2FF6yOqZKhB33P88budkjh10ksHdrKV-2F7bMYoNWKBxSMj9smEk0F4JNiUuXn3a8EATfbr6vMCPf95NbIGDyucec8RvMGh-2FKh8NJFzNcnJU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
49 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1558795: Null pointer dereferences (FORWARD_NULL)
/svx/source/svdraw/svdoedge.cxx: 1515 in SdrEdgeObj::ImpCalcEdgeTrack(const
Point &, long, const tools::Rectangle &, const tools::Rectangle &, const Point
&, long, const tools::Rectangle &, const tools::Rectangle &, unsigned long *,
SdrEdgeInfoRec *) const()
*** CID 1558795: Null pointer dereferences (FORWARD_NULL)
/svx/source/svdraw/svdoedge.cxx: 1515 in SdrEdgeObj::ImpCalcEdgeTrack(const
Point &, long, const tools::Rectangle &, const tools::Rectangle &, const Point
&, long, const tools::Rectangle &, const tools::Rectangle &, unsigned long *,
SdrEdgeInfoRec *) const()
1509 }
1510 }
1511 // make the connector a bezier curve, if appropriate
1512 if (eKind != SdrEdgeKind::Bezier || nPointCount <= 2)
1513 return aXP1;
1514
>>> CID 1558795: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "pInfo".
1515 if (pInfo->m_bUseOOXMLCurve) // Routing method OOXML
1516 {
1517 // The additional points needed are located on the segments of
the path of the
1518 // corresponding bentConnector as calculated above.
1519 auto SegmentPoint = [](const sal_uInt16& nEnd, const
double& fFactor) {
1520 return Point(
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DPLQ2_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiEJPLiT23hy3EjHjIq7B9VOM2ANPhev2kaF6dBmkQf2Rwu7UXoc6klD761S-2BJnFRxCX5aKoHLytF-2F9rD2197sWC54GcLg1P3WbmUJUoznRsBPgOESh7562tf0FT83bUQeCHqdoTnTISJvYIVLxHVJB86uxLAfLppvO4ykJ9r4Ofw-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
423 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 423 defect(s)
** CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/pdfwriter_impl.cxx: 10686 in
vcl::PDFWriterImpl::addRoleMap(rtl::OString, vcl::PDFWriter::StructElement)()
*** CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/pdfwriter_impl.cxx: 10686 in
vcl::PDFWriterImpl::addRoleMap(rtl::OString, vcl::PDFWriter::StructElement)()
10680 void PDFWriterImpl::addRoleMap(OString aAlias,
PDFWriter::StructElement eType)
10681 {
10682 OString aTag = getStructureTag(eType);
10683 // For PDF/UA it's not allowed to map an alias with the same name.
10684 // Not aware of a reason for doing it in any case, so just don't
do it.
10685 if (aAlias != aTag)
>>> CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aTag" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
10686 m_aRoleMap[aAlias] = aTag;
10687 }
10688
10689 void PDFWriterImpl::beginStructureElementMCSeq()
10690 {
10691 assert(m_nCurrentStructElement == 0 ||
m_aStructure[m_nCurrentStructElement].m_oType);
** CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svl/source/items/custritm.cxx: 59 in CntUnencodedStringItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
*** CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svl/source/items/custritm.cxx: 59 in CntUnencodedStringItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
53 bool CntUnencodedStringItem::PutValue(const css::uno::Any& rVal,
54 sal_uInt8)
55 {
56 OUString aTheValue;
57 if (rVal >>= aTheValue)
58 {
>>> CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aTheValue" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
59 m_aValue = aTheValue;
60 return true;
61 }
62 OSL_FAIL("CntUnencodedStringItem::PutValue(): Wrong type");
63 return false;
64 }
** CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/connectivity/source/drivers/jdbc/ResultSet.cxx: 119 in
connectivity::java_sql_ResultSet::queryInterface(const
com::sun::star::uno::Type &)()
*** CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/connectivity/source/drivers/jdbc/ResultSet.cxx: 119 in
connectivity::java_sql_ResultSet::queryInterface(const
com::sun::star::uno::Type &)()
113 SDBThreadAttach::releaseRef();
114 }
115
116 css::uno::Any SAL_CALL java_sql_ResultSet::queryInterface( const
css::uno::Type & rType )
117 {
118 css::uno::Any aRet = OPropertySetHelper::queryInterface(rType);
>>> CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aRet" is copied in call to copy constructor
>>> "com::sun::star::uno::Any", when it could be moved instead.
119 return aRet.hasValue() ? aRet :
java_sql_ResultSet_BASE::queryInterface(rType);
120 }
121
122 css::uno::Sequence< css::uno::Type > SAL_CALL
java_sql_ResultSet::getTypes( )
123 {
124 ::cppu::OTypeCollection aTypes(
cppu::UnoType::get(),
** CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svl/itemset.hxx: 45 in ()
*** CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svl/itemset.hxx: 45 in ()
39 #endif
40
41 // ItemSet/ItemPool helpers
42 SfxPoolItem const* implCreateItemEntry(SfxItemPool& rPool, SfxPoolItem
const* pSource, sal_uInt16 nWhich, bool bPassingOwnership);
43 void implCleanupItemEntry(SfxItemPool& rPool, SfxPoolItem const*
pSource);
44
>>> CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "SfxPoolItemHolder" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalues, where a move assignment may be faster.
45 class SAL_WARN_UNUSED SVL_DLLPUBLIC SfxPoolItemHolder
46 {
47 SfxItemPool*m_pPool;
48 const SfxPoolItem* m_pItem;
49
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1550112: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/config/viewopt.cxx: 353 in SwViewOption::SwViewOption(const
SwViewOption&)()
*** CID 1550112: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/config/viewopt.cxx: 353 in SwViewOption::SwViewOption(const
SwViewOption&)()
347 m_bTest5 = rVOpt.m_bTest5;
348 m_bTest6 = rVOpt.m_bTest6;
349 m_bTest7 = rVOpt.m_bTest7;
350 m_bTest8 = rVOpt.m_bTest8;
351 m_bTest10 = rVOpt.m_bTest10;
352 #endif
>>> CID 1550112: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_nIdxEntryLvl" is not initialized in this
>>> constructor nor in any functions that it calls.
353 }
354
355 SwViewOption& SwViewOption::operator=( const SwViewOption )
356 {
357 // #114856# Form view
358 m_sThemeName = rVOpt.m_sThemeName;
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D31GD_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiCdwzNjCBJX-2BQDWM84U6psusb8SF6tI1hapm8erTH4tWc-2BnZtyIE9SH-2BN2nFA79ngDsvJ47b5SPuQjCmlBLaex2fDMjYDfY4h8HL5y8IUGh4ZD2Azse7GNbLu3bY-2Bkthyh2rvGmLIq9dSmR571xqZQ2gpqb9-2BIQWP7mwNq2H36pM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1550047: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/app/optsitem.cxx: 430 in SdOptionsMisc::SdOptionsMisc(bool,
bool)()
*** CID 1550047: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/app/optsitem.cxx: 430 in SdOptionsMisc::SdOptionsMisc(bool,
bool)()
424 // The default for 6.1-and-above documents is to use
printer-independent
425 // formatting.
426 mnPrinterIndependentLayout (1),
427 mnDragThresholdPixels(6)
428 {
429 EnableModify( true );
>>> CID 1550047: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "bPresenterScreenFullScreen" is not initialized
>>> in this constructor nor in any functions that it calls.
430 }
431
432 bool SdOptionsMisc::operator==( const SdOptionsMisc& rOpt ) const
433 {
434 return( IsStartWithTemplate() == rOpt.IsStartWithTemplate() &&
435 IsMarkedHitMovesAlways() == rOpt.IsMarkedHitMovesAlways() &&
** CID 1550046: Memory - corruptions (BAD_FREE)
*** CID 1550046: Memory - corruptions (BAD_FREE)
/sw/source/filter/writer/writer.cxx: 342 in
Writer::PutNumFormatFontsInAttrPool()()
336 if( *pFont == *pDefFont )
337 continue;
338 }
339 else if( *pFont == *pDefFont )
340 bCheck = true;
341
>>> CID 1550046: Memory - corruptions (BAD_FREE)
>>> "AddFontItem" frees address of "SvxFontItem(pFont->GetFamilyType(),
>>> rtl::OUString(pFont->GetFamilyName()),
>>> rtl::OUString(pFont->GetStyleName()), pFont->GetPitch(),
>>> pFont->GetCharSet(), 7)".
342 AddFontItem( rPool, SvxFontItem(
pFont->GetFamilyType(),
343 pFont->GetFamilyName(),
pFont->GetStyleName(),
344 pFont->GetPitch(), pFont->GetCharSet(),
RES_CHRATR_FONT ));
345 }
346 }
347 }
** CID 1550045: Memory - corruptions (BAD_FREE)
*** CID 1550045: Memory - corruptions (BAD_FREE)
/sw/source/filter/writer/writer.cxx: 388 in Writer::AddFontItem(SfxItemPool &,
const SvxFontItem &)()
382 pItem = ( aFont );
383 }
384 else
385 pItem = ( rFont );
386
387 if( 1 < pItem->GetRefCount() )
>>> CID 1550045: Memory - corruptions (BAD_FREE)
>>> "DirectRemoveItemFromPool" frees incorrect pointer "pItem".
388 rPool.DirectRemoveItemFromPool( *pItem );
389 else
390 {
391 m_pImpl->aFontRemoveLst.push_back( pItem );
392 }
393 }
** CID 1550044: Memory - illegal accesses (RETURN_LOCAL)
/svx/source/dialog/framelinkarray.cxx: 358 in
svx::frame::ArrayImpl::ArrayImpl(int, int)()
*** CID 1550044: Memory - illegal accesses (RETURN_LOCAL)
/svx/source/dialog/framelinkarray.cxx: 358 in
svx::frame::ArrayImpl::ArrayImpl(int, int)()
352 mbXCoordsDirty( false ),
353 mbYCoordsDirty( false ),
354 mbMayHaveCellRotation( false )
355 {
356 const Cell* pDefaultCell = >DirectPutItemInPool(Cell());
357 // default-construct all vectors
>>> CID 1550044: Memory - illegal accesses (RETURN_LOCAL)
>>> Using "pDefaultCell", which points to an out-of-scope temporary
>>> variable of type "svx::frameCell".
358 maCells.resize( mnWidth * mnHeight, pDefaultCell );
359 maWidths.resize( mnWidth, 0 );
360 maHeights.resize( mnHeight, 0 );
361 maXCoords.resize( mnWidth + 1, 0 );
362 maYCoords.resize( mnHeight + 1, 0 );
363 }
** CID 1550043: Memory - illegal accesses (RETURN_LOCAL)
/sw/source/filter/writer/writer.cxx: 387 in Writer::AddFontItem(SfxItemPool &,
const SvxFontItem &)()
*** CID 1550043: Memory - illegal accesses (RETURN_LOCAL)
/sw/source/filter/writer/writer.cxx: 387 in Writer::AddFontItem(SfxItemPool &,
const SvxFontItem &)()
381 aFont.SetWhich( RES_CHRATR_FONT );
382 pItem = ( aFont );
383 }
384 else
385
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1548365: Control flow issues (DEADCODE)
/emfio/source/reader/wmfreader.cxx: 1734 in
emfio::WmfReader::GetPlaceableBound(tools::Rectangle &, SvStream *)()
*** CID 1548365: Control flow issues (DEADCODE)
/emfio/source/reader/wmfreader.cxx: 1734 in
emfio::WmfReader::GetPlaceableBound(tools::Rectangle &, SvStream *)()
1728 {
1729 break;
1730 }
1731
1732 switch( nFunction )
1733 {
>>> CID 1548365: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "case ::W_META_EOF:".
1734 case W_META_EOF:
1735 {
1736 return;
1737 }
1738
1739 case W_META_SETWINDOWORG:
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DAnJ6_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiKGkF6HBw-2FpBOebamfVB-2FC-2FYWEsF-2Bt54fTgKMdEOunqpco7zCbOsMIwmIosn-2FvPdc7k8Js77uLMhzVL1CoyRA5kAPVVRymXtt-2FaIY4DkrjTOeRPcnovTzsN-2Fn6wHm8-2F5zV-2BmqAFkWVKHDzSfdcUIqgvaGssRkj0M-2FEm6WKlwAEuM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1548028: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/sidebar/LayoutMenu.cxx: 534 in sd::sidebar::LayoutMenu::Fill()()
*** CID 1548028: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/sidebar/LayoutMenu.cxx: 534 in sd::sidebar::LayoutMenu::Fill()()
528 pInfo = standard;
529 }
530
531 Clear();
532 for (size_t i = 0; i < pInfo.size(); i++)
533 {
>>> CID 1548028: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "pInfo[i]".
534 if ((WritingMode_TB_RL != pInfo[i].meWritingMode) || bVertical)
535 {
536 Image aImg(OUString::Concat("private:graphicrepository/") +
pInfo[i].msBmpResId);
537
538 if (bRightToLeft && (WritingMode_TB_RL !=
pInfo[i].meWritingMode))
539 { // FIXME: avoid interpolating RTL layouts.
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D_ciS_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiSHhe9Wg-2FPnsc7UhTzovCpfyVTuEnUpg25la-2Bm-2F4-2B9DrIs-2FJPt-2FC3Ee8HW4Im7iDDW9EgozI-2BdJbG6eN-2FFL421Gikc-2BxPdL77TBu6VCN7GYFdXnEoldYiphhV-2BhPY0TExJxSeDLpFD3UpFp7gi2zy6Vo4RqO2cRmSAFIMiu-2FsPOg-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1547215: Parse warnings (PARSE_ERROR)
/usr/include/c++/12/bits/stl_pair.h: 278 in ()
*** CID 1547215: Parse warnings (PARSE_ERROR)
/usr/include/c++/12/bits/stl_pair.h: 278 in ()
272 : first(__x), second(__y)
273 { }
274
275 /// Constructor accepting two values of arbitrary types
276 template
277 requires (_S_constructible<_U1, _U2>())
>>> CID 1547215: Parse warnings (PARSE_ERROR)
>>> template constraint not satisfied
278 constexpr explicit(!_S_convertible<_U1, _U2>())
279 pair(_U1&& __x, _U2&& __y)
280 noexcept(_S_nothrow_constructible<_U1, _U2>())
281 : first(std::forward<_U1>(__x)), second(std::forward<_U2>(__y))
282 { }
283
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DqnjQ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiwFnsfJj-2FHuShNrfSBb0tnrOit2lhy7BGVokoMZtqEAdEUUNyvd8VKIN1MWVmGb5tDsnzK1dLBQDoJ6siWL5QMKX1J1ieqgivWWl2fIg6ZswKkOI-2BeTWuTLkkdwNDm-2FflOPpm8gwlZq8EcAMZ-2BBHR8WVguBYxwtd-2BAGutUhj2M5Q-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1547102: Uninitialized members (UNINIT_CTOR)
/editeng/source/accessibility/AccessibleStaticTextBase.cxx: 185 in
accessibility::AccessibleStaticTextBase_Impl::AccessibleStaticTextBase_Impl()()
*** CID 1547102: Uninitialized members (UNINIT_CTOR)
/editeng/source/accessibility/AccessibleStaticTextBase.cxx: 185 in
accessibility::AccessibleStaticTextBase_Impl::AccessibleStaticTextBase_Impl()()
179 AccessibleStaticTextBase_Impl::AccessibleStaticTextBase_Impl() :
180 mxTextParagraph( new AccessibleEditableTextPara(nullptr) )
181 {
182
183 // TODO: this is still somewhat of a hack, all the more since
184 // now the maTextParagraph has an empty parent reference set
>>> CID 1547102: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpThis" is not initialized in this constructor
>>> nor in any functions that it calls.
185 }
186
187 void AccessibleStaticTextBase_Impl::SetEditSource( std::unique_ptr<
SvxEditSource > && pEditSource )
188 {
189
190 maEditSource.SetEditSource( std::move(pEditSource) );
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DDTPf_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJivEByo8HRdx3MAnZB6PPji3NAy3w5WG89orNHicr9lrmbtnShChkGi1PUnfg3A03O58M7XJDHgxPvLsGiAV2qBwwRdy7op9e5OPLAVTFKKXVrsusE-2FGUi7Dv-2F0-2BqbFzmu1DjZGRtwsr964nB0krf5KkdxCdAi-2FYVW0eHy4A6pIHk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1547086: Control flow issues (DEADCODE)
/svx/source/form/fmundo.cxx: 326 in FmXUndoEnvironment::Notify(SfxBroadcaster
&, const SfxHint &)()
*** CID 1547086: Control flow issues (DEADCODE)
/svx/source/form/fmundo.cxx: 326 in FmXUndoEnvironment::Notify(SfxBroadcaster
&, const SfxHint &)()
320 break;
321 default: break;
322 }
323 }
324 else if (rHint.GetId() == SfxHintId::ThisIsAnSfxEventHint)
325 {
>>> CID 1547086: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "switch (static_cast(rHint).GetEventId())
327 {
328 case SfxEventHintId::CreateDoc:
329 case SfxEventHintId::OpenDoc:
330 ModeChanged();
331 break;
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DFJqn_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi6683qbSYhY5UBDD4eu64QOTLnEPAUXodBdXiBzlOfOpTx3ZOkJan5Bsf9ZsqIGUszTDDr-2FYyjb8nFcDDjLX7qQ0zQ7N9H-2BWaqlhPwKmhbEc1HmpQYvH-2FKwOoOTh9JRN7LsPIHpGdeJRsnH25hbkiMWUjZmgO4Zh7i5eHmXxbInM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1547076: Uninitialized members (UNINIT_CTOR)
/include/comphelper/errcode.hxx: 184 in ErrCodeMsg::ErrCodeMsg()()
*** CID 1547076: Uninitialized members (UNINIT_CTOR)
/include/comphelper/errcode.hxx: 184 in ErrCodeMsg::ErrCodeMsg()()
178 /** Wrap up an ErrCode and an explanation and the source location where
the error was created,
179 helps with debugging when finding the source of a problem.
180 */
181 class SAL_WARN_UNUSED ErrCodeMsg
182 {
183 public:
>>> CID 1547076: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mnDialogMask" is not initialized in this
>>> constructor nor in any functions that it calls.
184 ErrCodeMsg() : mnCode(0) {}
185 #ifdef LIBO_ERRMSG_USE_SOURCE_LOCATION
186 ErrCodeMsg(ErrCode code, const OUString& arg,
std::experimental::source_location loc =
std::experimental::source_location::current())
187 : mnCode(code), maArg1(arg), mnDialogMask(DialogMask::NONE),
moLoc(loc) {}
188 ErrCodeMsg(ErrCode code, const OUString& arg1, const OUString&
arg2, std::experimental::source_location loc =
std::experimental::source_location::current())
189 : mnCode(code), maArg1(arg1), maArg2(arg2),
mnDialogMask(DialogMask::NONE), moLoc(loc) {}
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dbyz0_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiAThq93V3DdanW3Zjvbp7SNjrJlHKyK-2BrYAPmLKgA3Rrmgs8LcOxNKmCpKBjVxAboKknTzl3n-2BU7xjhM6W-2BTR-2BufwymB4BncRN5CRPqRg1r-2BPU0SeCwM9Z1AahvJd9CenpdXTkrR5BP6Y8fABE150vwsNtKxbgB-2F22NugLxC75iI-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1547033:(FORWARD_NULL)
*** CID 1547033:(FORWARD_NULL)
/filter/source/pdf/impdialog.cxx: 942 in
ImpPDFTabGeneralPage::TogglePDFVersionOrUniversalAccessibilityHandle(weld::Toggleable
&)()
936
937 // set the security page status (and its controls as well)
938 ImpPDFTabSecurityPage* pSecPage = mpParent ?
mpParent->getSecurityPage() : nullptr;
939 if (pSecPage)
940 pSecPage->ImplPDFASecurityControl(!bIsPDFA);
941
>>> CID 1547033:(FORWARD_NULL)
>>> Passing null pointer "this->mpParent->maConfigItem" to "IsReadOnly",
>>> which dereferences it.
942 mxCbTaggedPDF->set_sensitive(
943 !bIsPDFA && !bIsPDFUA &&
!mpParent->maConfigItem.IsReadOnly("UseTaggedPDF"));
944 mxRbPDFAVersion->set_sensitive(
945 bIsPDFA &&
!mpParent->maConfigItem.IsReadOnly("SelectPdfVersion"));
946
947 if (bIsPDFA || bIsPDFUA)
/filter/source/pdf/impdialog.cxx: 944 in
ImpPDFTabGeneralPage::TogglePDFVersionOrUniversalAccessibilityHandle(weld::Toggleable
&)()
938 ImpPDFTabSecurityPage* pSecPage = mpParent ?
mpParent->getSecurityPage() : nullptr;
939 if (pSecPage)
940 pSecPage->ImplPDFASecurityControl(!bIsPDFA);
941
942 mxCbTaggedPDF->set_sensitive(
943 !bIsPDFA && !bIsPDFUA &&
!mpParent->maConfigItem.IsReadOnly("UseTaggedPDF"));
>>> CID 1547033:(FORWARD_NULL)
>>> Passing null pointer "this->mpParent->maConfigItem" to "IsReadOnly",
>>> which dereferences it.
944 mxRbPDFAVersion->set_sensitive(
945 bIsPDFA &&
!mpParent->maConfigItem.IsReadOnly("SelectPdfVersion"));
946
947 if (bIsPDFA || bIsPDFUA)
948 {
949 // store the users selection of subordinate controls and set
required PDF/A values
/filter/source/pdf/impdialog.cxx: 993 in
ImpPDFTabGeneralPage::TogglePDFVersionOrUniversalAccessibilityHandle(weld::Toggleable
&)()
987 }
988 else if (mpParent)
989 {
990
mxCbExportBookmarks->set_active(mpParent->mbExportBookmarksUserSelection);
991
mxCbUseReferenceXObject->set_active(mpParent->mbUseReferenceXObjectUserSelection);
992 }
>>> CID 1547033:(FORWARD_NULL)
>>> Passing null pointer "this->mpParent->maConfigItem" to "IsReadOnly",
>>> which dereferences it.
993 mxCbExportBookmarks->set_sensitive(
994 !bIsPDFUA &&
!mpParent->maConfigItem.IsReadOnly("ExportBookmarks"));
995 mxCbUseReferenceXObject->set_sensitive(!bIsPDFUA);
996
997 ImpPDFTabOpnFtrPage *const pOpenPage(mpParent ?
mpParent->getOpenPage() : nullptr);
998 if (pOpenPage)
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DoQbI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiJYghQPBp2QpoePK0lIKEfF9lRNOVIs9XkB-2FVguAgcsgc2K0MOORfF0ji4YfBwPiUyGlVuyJAkN0qCXhLgGjRH1Xzn-2FIeZII-2Bs1rPq2k6fTr4CuvnVvZgZLaRGHh-2FFkgQ3eXB3OojPT4c1-2BOt-2FHt358YyVx5HHTQg1HYoPijVIto-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1546839: Control flow issues (DEADCODE) /sw/source/core/attr/swatrset.cxx: 325 in SwAttrSet::Intersect_BC(const SfxItemSet &, SwAttrSet*, SwAttrSet*)() *** CID 1546839: Control flow issues (DEADCODE) /sw/source/core/attr/swatrset.cxx: 325 in SwAttrSet::Intersect_BC(const SfxItemSet &, SwAttrSet*, SwAttrSet*)() 319 m_pNewSet = pNew; 320 m_pOldSet = pOld; 321 setCallback(m_aCallbackHolder); 322 SfxItemSet::Intersect( rSet ); 323 clearCallback(); 324 m_pOldSet = m_pNewSet = nullptr; >>> CID 1546839: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "0" inside this statement: >>> "return pNew ? pNew->Count()...". 325 return pNew ? pNew->Count() : ( pOld ? pOld->Count() : 0 ); 326 } 327 328 /** special treatment for some attributes 329 330 Set the Modify pointer (old pDefinedIn) for the following attributes: To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DSeD1_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi0ajyWbuTOgdNTUHp45uBVmkRlo9Z-2FSOZfC2LbI5gXYAl3Xpy5oEWnt98Zamr4SZMHxLD4Po1qSkE9P7AHy3PBIJqBBsfZ4TckT-2FbfssbGIU1LmRfCVyAJLmgk7qjQ9pVXFC37R4EbRRNMDr3kaAMTtZ1xqm5ySJcAossY1lkwXs-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
8 new defect(s) introduced to LibreOffice found with Coverity Scan.
1436 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)
** CID 1546834: Error handling issues (CHECKED_RETURN)
/pyuno/source/module/pyuno_runtime.cxx: 244 in pyuno::readLoggingConfig(int *,
_IO_FILE **)()
*** CID 1546834: Error handling issues (CHECKED_RETURN)
/pyuno/source/module/pyuno_runtime.cxx: 244 in pyuno::readLoggingConfig(int *,
_IO_FILE **)()
238 else if ( str == "stderr" )
239 *ppFile = stderr;
240 else
241 {
242 oslProcessInfo data;
243 data.Size = sizeof( data );
>>> CID 1546834: Error handling issues (CHECKED_RETURN)
>>> Calling "osl_getProcessInfo" without checking return value (as is done
>>> elsewhere 6 out of 7 times).
244 osl_getProcessInfo(
245 nullptr , osl_Process_IDENTIFIER , );
246 osl_getSystemPathFromFileURL( str.pData, );
247 OString o = OUStringToOString( str, osl_getThreadTextEncoding()
);
248 o += ".";
249 o += OString::number( data.Ident );
** CID 1546833: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unoframe.cxx: 2997 in SwXFrame::attachToRange(const
com::sun::star::uno::Reference &, const SwPaM
*)()
*** CID 1546833: Error handling issues (CHECKED_RETURN)
/sw/source/core/unocore/unoframe.cxx: 2997 in SwXFrame::attachToRange(const
com::sun::star::uno::Reference &, const SwPaM
*)()
2991 if(!bSizeFound)
2992 {
2993 //TODO/LATER: how do I transport it to the OLENode?
2994 sal_Int64 nAspect = m_nDrawAspect;
2995
2996 // TODO/LEAN: VisualArea still needs running state
>>> CID 1546833: Error handling issues (CHECKED_RETURN)
>>> Calling "TryRunningState" without checking return value (as is done
>>> elsewhere 33 out of 39 times).
2997 svt::EmbeddedObjectRef::TryRunningState( xIPObj );
2998
2999 // set parent to get correct VisArea(in case of
object needing parent printer)
3000 uno::Reference < container::XChild > xChild(
xIPObj, uno::UNO_QUERY );
3001 if ( xChild.is() )
3002 xChild->setParent(
pDoc->GetDocShell()->GetModel() );
** CID 1546832: Sigma (SIGMA.weak_hash_core_java)
/workdir/UnpackedTarball/java_websocket/src/main/java/org/java_websocket/drafts/Draft_6455.java:
837 in
org.java_websocket.drafts.Draft_6455::generateFinalKey(org.java_websocket.drafts.Draft_6455,
String)()
*** CID 1546832: Sigma (SIGMA.weak_hash_core_java)
/workdir/UnpackedTarball/java_websocket/src/main/java/org/java_websocket/drafts/Draft_6455.java:
837 in
org.java_websocket.drafts.Draft_6455::generateFinalKey(org.java_websocket.drafts.Draft_6455,
String)()
831*/
832 private String generateFinalKey(String in) {
833 String seckey = in.trim();
834 String acc = seckey + "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
835 MessageDigest sh1;
836 try {
>>> CID 1546832: Sigma (SIGMA.weak_hash_core_java)
>>> This application uses a weak algorithm to create a `MessageDigest`,
>>> which may lead to collision attacks.
837 sh1 = MessageDigest.getInstance("SHA1");
838 } catch (NoSuchAlgorithmException e) {
839 throw new IllegalStateException(e);
840 }
841 return Base64.encodeBytes(sh1.digest(acc.getBytes()));
842 }
** CID 1546831: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/view/lokcharthelper.cxx: 178 in LokChartHelper::HitAny(const Point
&, bool)()
*** CID 1546831: Null pointer dereferences (FORWARD_NULL)
/sfx2/source/view/lokcharthelper.cxx: 178 in LokChartHelper::HitAny(const Point
&, bool)()
172 {
173 SfxViewShell* pCurView = SfxViewShell::Current();
174 int nPartForCurView = pCurView ? pCurView->getPart() : -1;
175 SfxViewShell* pViewShell = SfxViewShell::GetFirst();
176 while (pViewShell)
177 {
>>> CID 1546831: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pCurView" to "GetDocId", which dereferences it.
>>> (The dereference happens because this is a virtual
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
492 new defect(s) introduced to LibreOffice found with Coverity Scan.
12 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 492 defect(s)
** CID 1546235: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uielement/toolbarsmenucontroller.cxx: 629 in
framework::ToolbarsMenuController::itemSelected(const
com::sun::star::awt::MenuEvent &)()
*** CID 1546235: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uielement/toolbarsmenucontroller.cxx: 629 in
framework::ToolbarsMenuController::itemSelected(const
com::sun::star::awt::MenuEvent &)()
623 Reference< XDispatch > xDispatch =
xDispatchProvider->queryDispatch(
624 aTargetURL,
OUString(), 0 );
625
626 ExecuteInfo* pExecuteInfo = new ExecuteInfo;
627 pExecuteInfo->xDispatch = xDispatch;
628 pExecuteInfo->aTargetURL= aTargetURL;
>>> CID 1546235: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aArgs" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
629 pExecuteInfo->aArgs = aArgs;
630 Application::PostUserEvent( LINK(nullptr,
ToolbarsMenuController, ExecuteHdl_Impl), pExecuteInfo );
631 }
632 }
633 else
634 {
** CID 1546234: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/core/unocore/unostyle.cxx: 4855 in
SwXTextCellStyle::getPropertySetInfo()()
*** CID 1546234: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/core/unocore/unostyle.cxx: 4855 in
SwXTextCellStyle::getPropertySetInfo()()
4849 }
4850
4851 //XPropertySet
4852 css::uno::Reference SAL_CALL
SwXTextCellStyle::getPropertySetInfo()
4853 {
4854 static uno::Reference
xRef(aSwMapProvider.GetPropertySet(PROPERTY_MAP_CELL_STYLE)->getPropertySetInfo());
>>> CID 1546234: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xRef" is copied in call to copy constructor
>>> "com::sun::star::uno::Reference",
>>> when it could be moved instead.
4855 return xRef;
4856 }
4857
4858 void SAL_CALL SwXTextCellStyle::setPropertyValue(const OUString&
rPropertyName, const css::uno::Any& aValue)
4859 {
4860 SolarMutexGuard aGuard;
** CID 1546233: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uielement/toolbarmanager.cxx: 1116 in
framework::ToolBarManager::CreateControllers()()
*** CID 1546233: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uielement/toolbarmanager.cxx: 1116 in
framework::ToolBarManager::CreateControllers()()
1110 m_pToolBar,
aCommandURL,
1112 nId,
1113 nWidth,
1114 aControlType
).get(), UNO_QUERY );
1115
>>> CID 1546233: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xStatusListener" is copied in a call to copy assignment "operator =",
>>> when it could be moved instead.
1116 xController = xStatusListener;
1117 }
1118 else
1119 {
1120 if ( m_pToolBar )
1121 xController.set( new GenericToolbarController(
m_xContext, m_xFrame, m_pToolBar, nId, aCommandURL ));
** CID 1546232: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/sidebar/ChartTypePanel.cxx: 271 in
chart::sidebar::ChartTypePanel::doUpdateModel(rtl::Reference)()
*** CID 1546232: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/chart2/source/controller/sidebar/ChartTypePanel.cxx: 271 in
chart::sidebar::ChartTypePanel::doUpdateModel(rtl::Reference)()
265 {
266 if (mbModelValid)
267 {
268 m_xChartModel->removeModifyListener(mxListener);
269 }
270
>>> CID 1546232: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xModel" is copied in a call to copy assignment "operator =", when it
>>> could be
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1542448: Null pointer dereferences (REVERSE_INULL)
/cui/source/options/treeopt.cxx: 841 in
OfaTreeOptionsDialog::selectFirstEntry()()
*** CID 1542448: Null pointer dereferences (REVERSE_INULL)
/cui/source/options/treeopt.cxx: 841 in
OfaTreeOptionsDialog::selectFirstEntry()()
835 {
836 xEntry = xTreeLB->make_iterator();
837 if (!xTreeLB->get_iter_first(*xEntry) ||
!xTreeLB->iter_next(*xEntry))
838 xEntry.reset();
839 }
840
>>> CID 1542448: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "xEntry" suggests that it may be null, but it has already
>>> been dereferenced on all paths leading to the check.
841 if (!xEntry)
842 return;
843
844 std::unique_ptr
xParent(xTreeLB->make_iterator(xEntry.get()));
845 xTreeLB->iter_parent(*xParent);
846 xTreeLB->expand_row(*xParent);
** CID 1542447: Null pointer dereferences (FORWARD_NULL)
*** CID 1542447: Null pointer dereferences (FORWARD_NULL)
/sc/source/ui/theme/ThemeColorChanger.cxx: 220 in
scchangeSheets(ScDocShell &, ScTabViewShell *, ScDrawLayer *,
const std::shared_ptr &)()
214 pView = pViewShell->GetScDrawView();
215
216 SdrPage* pPage =
pModel->GetPage(static_cast(nTab));
217 SdrObjListIter aIter(pPage, SdrIterMode::DeepNoGroups);
218 for (SdrObject* pObject = aIter.Next(); pObject; pObject =
aIter.Next())
219 {
>>> CID 1542447: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pView" to "updateSdrObject", which dereferences
>>> it.
220 svx::theme::updateSdrObject(*pColorSet, pObject, pView,
rDocShell.GetUndoManager());
221 }
222
223 std::unique_ptr pUndo = pModel->GetCalcUndo();
224
225 if (pUndo)
** CID 1542446: Uninitialized variables (UNINIT)
*** CID 1542446: Uninitialized variables (UNINIT)
/sc/source/ui/theme/ThemeColorChanger.cxx: 206 in
scchangeSheets(ScDocShell &, ScTabViewShell *, ScDrawLayer *,
const std::shared_ptr &)()
200 ScEditDataArray* pDataArray = pUndo->GetDataArray();
201
202 rDocument.ApplySelectionPattern(aNewPattern, aMark,
pDataArray);
203
204
rDocShell.GetUndoManager()->AddUndoAction(std::move(pUndo));
205 }
>>> CID 1542446: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aNewPattern.pName._M_payload._M_payload"
>>> when calling "~ScPatternAttr".
206 }
207 }
208
209 // Change all SdrObjects
210 {
211 pModel->BeginCalcUndo(true);
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DacUJ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiRlmMPRrg5ltzIRs9dFvttPn1qIlOHBgq3lwvmLvdMiakh1ZnzQwId1VcG2xuTBe1m3U6ViOGvz-2Ff-2BuZsVy83vqDBd5iLHYuKvm9dGZpQyBu1pUcrwxU9IFTjxANiZBsUfY-2FpEhwqQ0LeTlgwyxzqlmJE5B1ql-2FdGV-2FpJFKGnzlI-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in
writerperfect::WPXSvInputStream::seek(long)()
*** CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in
writerperfect::WPXSvInputStream::seek(long)()
450 int WPXSvInputStream::seek(tools::Long offset)
451 {
452 if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
453 return -1;
454
455 const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>> CID 1541186: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "tmpPosition > 9223372036854775807L" is always false regardless of the
>>> values of its operands. This occurs as the logical second operand of "||".
456 if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
457 return -1;
458
459 try
460 {
461 mxSeekable->seek(offset);
** CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in
writerperfect::WPXSvInputStream::tellImpl()()
*** CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in
writerperfect::WPXSvInputStream::tellImpl()()
438 {
439 if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
440 return -1;
441 else
442 {
443 const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>> CID 1541185: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "tmpPosition > 9223372036854775807L" is always false regardless of the
>>> values of its operands. This occurs as the logical second operand of "||".
444 if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
445 return -1;
446 return static_cast(tmpPosition);
447 }
448 }
449
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D1gxC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiXV5MJlq0SQHeh3zIHStjN-2BM9Vbq8-2BCQyJ5qJeZmkQEdJ-2Fd2zGqzmFnHDxcKeLI7gZzhLCheJe6UfAzovCx-2BlO7zf4lGZmZ49MIjLZXoEbg3PoDbLKORPqe3kDofnlraSqqd3IKby1EbJzpwAr3qX0RcBSW20CtadQzHn0Oiv6EY-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1541152: Control flow issues (DEADCODE)
/sw/source/core/layout/paintfrm.cxx: 2899 in
::SwTabFramePainter::InsertFollowTopBorder(const SwFrame &, const
SvxBoxItem &, bool, long, long, long, bool)()
*** CID 1541152: Control flow issues (DEADCODE)
/sw/source/core/layout/paintfrm.cxx: 2899 in
::SwTabFramePainter::InsertFollowTopBorder(const SwFrame &, const
SvxBoxItem &, bool, long, long, long, bool)()
2893 }
2894
2895 // This is then a first row in a follow table, without repeated
headlines.
2896 auto pLastRow = dynamic_cast(mrTabFrame.GetLastLower());
2897 if (!pLastRow && pLastRow == pThisRow)
2898 {
>>> CID 1541152: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
2899 return;
2900 }
2901
2902 const SwFrame* pLastCell = pLastRow->GetLower();
2903 for (int i = 0; i < nCol; ++i)
2904 {
** CID 1541151: Null pointer dereferences (FORWARD_NULL)
*** CID 1541151: Null pointer dereferences (FORWARD_NULL)
/sw/source/core/layout/paintfrm.cxx: 2902 in
::SwTabFramePainter::InsertFollowTopBorder(const SwFrame &, const
SvxBoxItem &, bool, long, long, long, bool)()
2896 auto pLastRow = dynamic_cast(mrTabFrame.GetLastLower());
2897 if (!pLastRow && pLastRow == pThisRow)
2898 {
2899 return;
2900 }
2901
>>> CID 1541151: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pLastRow" to "GetLower", which dereferences it.
2902 const SwFrame* pLastCell = pLastRow->GetLower();
2903 for (int i = 0; i < nCol; ++i)
2904 {
2905 if (!pLastCell)
2906 {
2907 break;
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DwgLn_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiEY3BFVrLuW9iFjIZnXOsrXpSI528ZMHgx0KQIjS7mrlzhOPGVcvdGZWsIn3gYRsmP4IYBljOpsMbZxEVcU-2B0FvVBuWnQZZsYtleb6gNt28BFRjO08vzARDtIxBYDx2Iw8uYzy75AZQNB5Kii-2FcvzP6rnJDXN9E7dYsmjdLefzoM-3D
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1539919: Null pointer dereferences (FORWARD_NULL) *** CID 1539919: Null pointer dereferences (FORWARD_NULL) /slideshow/source/engine/slideshowimpl.cxx: 1546 in ::SlideShowImpl::registerUserPaintPolygons(const com::sun::star::uno::Reference &)() 1540 //Add the shape to the slide 1541 Shapes->add(rPolyShape); 1542 //Construct a sequence of points sequence 1543 const drawing::PointSequenceSequence aRetval 1544 = lcl_createPointSequenceSequenceFromB2DPolygon(aDrawingPoints); 1545 //Fill the properties >>> CID 1539919: Null pointer dereferences (FORWARD_NULL) >>> Passing "cppcanvas::PolyPolygonSharedPtr(pFirstPolyPoly)" to >>> "lcl_setPropertiesToShape", which dereferences null >>> "cppcanvas::PolyPolygonSharedPtr(pFirstPolyPoly)". 1546 lcl_setPropertiesToShape(aRetval, pFirstPolyPoly, rPolyShape); 1547 // make polygons special 1548 xLayerManager->attachShapeToLayer(rPolyShape, xDrawnInSlideshow); 1549 // Start next pen drawing object 1550 aDrawingPoints.clear(); 1551 aDrawingPoints.append(aPoly); To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dsofg_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiMZV5w-2BadXib3ZOTUZxa7Me6ECr3qkd1vXasZok1ijlouz-2FV1CX3Kg6d0SjeHp3Jr-2BhXkKQ072eHwaLmCtdhVt8NiFA-2BOxZWSHXRQ-2B-2FjXpD3vZHN-2FMIzBFlAuY7AMq21kyZH8WYiKCx5jaW0lsFqKksNNwjhJ0JqmVZl0d3CegIuUgtK2oohWpbcNBDNpWd0c
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1539913: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/animate/Animation.hxx: 33 in ()
*** CID 1539913: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/animate/Animation.hxx: 33 in ()
27
28 #define ANIMATION_TIMEOUT_ON_CLICK 2147483647L
29
30 class AnimationRenderer;
31 struct AnimationData;
32
>>> CID 1539913: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "Animation" may benefit from adding a move assignment operator.
>>> See other events which show the copy assignment operator being applied to
>>> rvalues, where a move assignment may be faster.
33 class VCL_DLLPUBLIC Animation
34 {
35 public:
36 Animation();
37 Animation(const Animation& rAnimation);
38 ~Animation();
** CID 1539912: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/task.hxx: 42 in ()
*** CID 1539912: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/task.hxx: 42 in ()
36 DEFAULT_IDLE, ///< Default idle priority
37 LOWEST ///< Low, very idle cleanup tasks
38 };
39
40 #define PRIO_COUNT (static_cast(TaskPriority::LOWEST) + 1)
41
>>> CID 1539912: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "Task" may benefit from adding a move assignment operator. See
>>> other events which show the copy assignment operator being applied to
>>> rvalues, where a move assignment may be faster.
42 class VCL_DLLPUBLIC Task
43 {
44 friend class Scheduler;
45 friend struct ImplSchedulerData;
46
47 ImplSchedulerData *mpSchedulerData; ///< Pointer to the element in
scheduler list
** CID 1539911: Performance inefficiencies (PASS_BY_VALUE)
/sw/source/uibase/shells/txtnum.cxx: 203 in
SwTextShell::ExecEnterNum(SfxRequest &)::[lambda(int) (instance 1)]::operator
()(int) const()
*** CID 1539911: Performance inefficiencies (PASS_BY_VALUE)
/sw/source/uibase/shells/txtnum.cxx: 203 in
SwTextShell::ExecEnterNum(SfxRequest &)::[lambda(int) (instance 1)]::operator
()(int) const()
197 if ( pPageItem )
198 pDlg->SetCurPageId( pPageItem->GetValue() );
199
200 auto pRequest = std::make_shared(rReq);
201 rReq.Ignore(); // the 'old' request is not relevant any more
202
>>> CID 1539911: Performance inefficiencies (PASS_BY_VALUE)
>>> Capturing variable "aSet" of type "SfxItemSetFixed<(unsigned
>>> short)10414, (unsigned short)10414, (unsigned short)10855, (unsigned
>>> short)10859>" (size 144 bytes) by value, which exceeds the low threshold of
>>> 128 bytes.
203 pDlg->StartExecuteAsync([aSet, pDlg,
pNumRuleAtCurrentSelection, pRequest, this](sal_Int32 nResult){
204 if (RET_OK == nResult)
205 {
206 const SvxNumBulletItem* pBulletItem =
pDlg->GetOutputItemSet()->GetItemIfSet(SID_ATTR_NUMBERING_RULE, false);
207 if (pBulletItem)
208 {
** CID 1539910: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/timer.hxx: 26 in ()
*** CID 1539910: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/vcl/timer.hxx: 26 in ()
20 #ifndef INCLUDED_VCL_TIMER_HXX
21 #define INCLUDED_VCL_TIMER_HXX
22
23 #include
24 #include
25
>>> CID 1539910: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "Timer" may benefit from adding a move assignment operator. See
>>> other events which show the copy assignment operator being applied to
>>> rvalues, where a move assignment may be faster.
26 class VCL_DLLPUBLIC Timer : public Task
27 {
28 Link maInvokeHandler; ///< Callback Link
29 sal_uInt64 mnTimeout;
30 const bool mbAuto;
31
To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1539807: Uninitialized members (UNINIT_CTOR)
/svgio/source/svgreader/svgcharacternode.cxx: 83 in
svgio::svgreader::SvgCharacterNode::SvgCharacterNode(svgio::svgreader::SvgDocument
&, svgio::svgreader::SvgNode *, rtl::OUString)()
*** CID 1539807: Uninitialized members (UNINIT_CTOR)
/svgio/source/svgreader/svgcharacternode.cxx: 83 in
svgio::svgreader::SvgCharacterNode::SvgCharacterNode(svgio::svgreader::SvgDocument
&, svgio::svgreader::SvgNode *, rtl::OUString)()
77 SvgDocument& rDocument,
78 SvgNode* pParent,
79 OUString aText)
80 : SvgNode(SVGToken::Character, rDocument, pParent),
81 maText(std::move(aText))
82 {
>>> CID 1539807: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpTextParent" is not initialized in this
>>> constructor nor in any functions that it calls.
83 }
84
85 SvgCharacterNode::~SvgCharacterNode()
86 {
87 }
88
** CID 1539806: Null pointer dereferences (FORWARD_NULL)
*** CID 1539806: Null pointer dereferences (FORWARD_NULL)
/sc/source/ui/undo/undoblk.cxx: 1155 in ScUndoPaste::DoChange(bool)()
1149
1150 pDocShell->PostDataChanged();
1151 if (pViewShell)
1152 pViewShell->CellContentChanged();
1153
1154 if (bColsAffected || bRowsAffected)
>>> CID 1539806: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pViewShell" to
>>> "notifyAllViewsSheetGeomInvalidation", which dereferences it.
1155 ScTabViewShell::notifyAllViewsSheetGeomInvalidation(
1156 pViewShell,
1157 bColsAffected, bRowsAffected,
1158 true /* bSizes*/, true /* bHidden */, true /* bFiltered */,
1159 true /* bGroups */, aDrawRanges[0].aStart.Tab());
1160 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DHfVY_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiLDLGUIpEQkM88gBNH9yTVUiq-2FYuw67tQbk-2FTvx5sCdR9clnYJTdhPS5ZSQlXObvoAo9Vj1FgT-2BtNJmoJ09swDrQsdDohorv021mRS-2F-2Bigw5PKVgb5xHewe9IghkI76rTusw5MDqLqDCq4bJk2BDpKYHxGl-2B2ulzndROsqSYn-2FGs-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1539504: Integer handling issues (DIVIDE_BY_ZERO)
/reportdesign/source/ui/report/DesignView.cxx: 253 in
rptui::ODesignView::resizeDocumentView(tools::Rectangle &)()
*** CID 1539504: Integer handling issues (DIVIDE_BY_ZERO)
/reportdesign/source/ui/report/DesignView.cxx: 253 in
rptui::ODesignView::resizeDocumentView(tools::Rectangle &)()
247 {
248 aTaskPanePos.setX( aPlaygroundSize.Width() -
nMinWidth );
249 }
250 nSplitPos = aTaskPanePos.X() - nSplitterWidth;
251 getController().setSplitPos(nSplitPos);
252
>>> CID 1539504: Integer handling issues (DIVIDE_BY_ZERO)
>>> In expression "(aPlaygroundSize.Width() - aTaskPanePos.X()) * 100L /
>>> aPlaygroundSize.Width()", division by expression "aPlaygroundSize.Width()"
>>> which may be zero has undefined behavior.
253 const tools::Long nTaskPaneSize =
static_cast((aPlaygroundSize.Width() -
aTaskPanePos.X())*100/aPlaygroundSize.Width());
254 if ( m_aSplitWin->GetItemSize( TASKPANE_ID ) !=
nTaskPaneSize )
255 {
256 m_aSplitWin->SetItemSize( REPORT_ID, 99 -
nTaskPaneSize );
257 m_aSplitWin->SetItemSize( TASKPANE_ID,
nTaskPaneSize );
258 }
** CID 1539503: Null pointer dereferences (FORWARD_NULL)
/sw/source/core/unocore/unotext.cxx: 497 in
SwXText::insertControlCharacter(const
com::sun::star::uno::Reference &, short,
unsigned char)()
*** CID 1539503: Null pointer dereferences (FORWARD_NULL)
/sw/source/core/unocore/unotext.cxx: 497 in
SwXText::insertControlCharacter(const
com::sun::star::uno::Reference &, short,
unsigned char)()
491 if (pRange)
492 {
493 pRange->SetPositions(aCursor);
494 }
495 else
496 {
>>> CID 1539503: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pCursor" to "GetPaM", which dereferences it. (The
>>> dereference happens because this is a virtual function call.)
497 SwPaM *const pUnoCursor = pCursor->GetPaM();
498 *pUnoCursor->GetPoint() = *aCursor.GetPoint();
499 if (aCursor.HasMark())
500 {
501 pUnoCursor->SetMark();
502 *pUnoCursor->GetMark() = *aCursor.GetMark();
** CID 1539502: Null pointer dereferences (REVERSE_INULL)
/sw/source/filter/html/wrthtml.cxx: 546 in SwHTMLWriter::WriteStream()()
*** CID 1539502: Null pointer dereferences (REVERSE_INULL)
/sw/source/filter/html/wrthtml.cxx: 546 in SwHTMLWriter::WriteStream()()
540 // create table of the floating frames, but only when the whole
541 // document is saved
542 m_aHTMLPosFlyFrames.clear();
543 CollectFlyFrames();
544 m_nLastParaToken = HtmlTokenId::NONE;
545
>>> CID 1539502: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "this->m_pCurrentPam" suggests that it may be null, but
>>> it has already been dereferenced on all paths leading to the check.
546 if (mbReqIF && !m_bWriteAll && m_pCurrentPam
547 && *m_pCurrentPam->GetPoint() == *m_pCurrentPam->GetMark()
548 && m_pCurrentPam->GetPoint()->GetNode().IsOLENode() &&
m_aHTMLPosFlyFrames.size() == 1)
549 {
550 // A single OLE object selection must be output: do it directly
(without replacement)
551 OutHTML_FrameFormatOLENodeGrf(*this,
m_aHTMLPosFlyFrames[0]->GetFormat(), true, false);
** CID 1539501: Null pointer dereferences (FORWARD_NULL)
*** CID 1539501: Null pointer dereferences (FORWARD_NULL)
/sd/source/ui/unoidl/unomodel.cxx: 2337 in
SdXImpressDocument::getViewRenderState(SfxViewShell *)()
2331 OStringBuffer aState;
2332 DrawViewShell* pView = nullptr;
2333
2334 if (pViewShell)
2335 {
2336 ViewShellBase* pShellBase =
dynamic_cast(pViewShell);
>>> CID 1539501: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pShellBase" to "GetMainViewShell", which
>>> dereferences it.
2337 pView =
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
/accessibility/source/extended/accessibletablistboxtable.cxx: 328 in
accessibility::AccessibleTabListBoxTable::getSelectedAccessibleChild(long)()
*** CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
/accessibility/source/extended/accessibletablistboxtable.cxx: 328 in
accessibility::AccessibleTabListBoxTable::getSelectedAccessibleChild(long)()
322
323 sal_Int32 nRows = implGetSelRowCount();
324 if ( nRows == 0 )
325 throw IndexOutOfBoundsException();
326
327 const sal_Int32 nColCount = implGetColumnCount();
>>> CID 1539071: Integer handling issues (DIVIDE_BY_ZERO)
>>> In expression "nSelectedChildIndex / nColCount", division by expression
>>> "nColCount" which may be zero has undefined behavior.
328 const sal_Int32 nRow = implGetSelRow(nSelectedChildIndex /
nColCount);
329 const sal_Int32 nColumn = nSelectedChildIndex % nColCount;
330 return getAccessibleCellAt( nRow, nColumn );
331 }
332
333 void SAL_CALL AccessibleTabListBoxTable::deselectAccessibleChild(
sal_Int64 nSelectedChildIndex )
** CID 1539070: Null pointer dereferences (REVERSE_INULL)
/sd/source/ui/func/futext.cxx: 725 in sd::FuText::MouseButtonUp(const
MouseEvent &)()
*** CID 1539070: Null pointer dereferences (REVERSE_INULL)
/sd/source/ui/func/futext.cxx: 725 in sd::FuText::MouseButtonUp(const
MouseEvent &)()
719 }
720
721 ForcePointer();
722 mpWindow->ReleaseMouse();
723 sal_uInt16 nDrgLog1 = sal_uInt16 (
mpWindow->PixelToLogic(Size(mpView->GetDragThresholdPixels(),0)).Width() );
724
>>> CID 1539070: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "this->mpView" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
725 if ( mpView && !mpView->AreObjectsMarked() &&
726 std::abs(aMDPos.X() - aPnt.X()) < nDrgLog1 &&
727 std::abs(aMDPos.Y() - aPnt.Y()) < nDrgLog1 &&
728 !rMEvt.IsShift() && !rMEvt.IsMod2() )
729 {
730 SdrPageView* pPV2 = mpView->GetSdrPageView();
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DmZOW_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJizAj7K4U7LzoHJpnORrww8GbnFbzCRczyOubZ3ivnZuxJoEh8jLeAyHSSX7-2FzL2YgzK-2FC5SE-2FcHMcgtucfLH8dF2GvzvGEcFPnle3I-2FlMrflZ7bB6rXCS798C2HzDXonQaMD-2F5Z56xbUYVGAjGGiJpfZIow8lM4QcZvz7kfUQYL4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1538889: Memory - illegal accesses (RETURN_LOCAL)
*** CID 1538889: Memory - illegal accesses (RETURN_LOCAL)
/sw/source/core/docnode/ndtbl.cxx: 1923 in SwDoc::DelTable(SwTableNode *)()
1917
1918 void SwDoc::DelTable(SwTableNode *const pTableNd)
1919 {
1920 {
1921 // tdf#156267 remove DdeBookmarks before deleting nodes
1922 SwDataChanged aTmp(SwPaM(*pTableNd,
*pTableNd->EndOfSectionNode()));
>>> CID 1538889: Memory - illegal accesses (RETURN_LOCAL)
>>> In "aTmp.~SwDataChanged()", using "aTmp.m_pPam", which points to an
>>> out-of-scope temporary variable of type "SwPaM".
1923 }
1924
1925 bool bNewTextNd = false;
1926 // Is it alone in a FlyFrame?
1927 SwNodeIndex aIdx( *pTableNd, -1 );
1928 const SwStartNode* pSttNd = aIdx.GetNode().GetStartNode();
** CID 153: Integer handling issues (NEGATIVE_RETURNS)
*** CID 153: Integer handling issues (NEGATIVE_RETURNS)
/filter/source/pdf/pdfexport.cxx: 1268 in
PDFExport::ImplWriteWatermark(vcl::PDFWriter &, const Size &)()
1262 pDev->Pop();
1263
1264 rWriter.Push();
1265 // tdf#152235 tag around the reference to the XObject on the page
1266 sal_Int32 const id = rWriter.EnsureStructureElement();
1267 rWriter.InitStructureElement(id, vcl::PDFWriter::NonStructElement,
::std::u16string_view());
>>> CID 153: Integer handling issues (NEGATIVE_RETURNS)
>>> "id" is passed to a parameter that cannot be negative.
1268 rWriter.BeginStructureElement(id);
1269 rWriter.SetStructureAttribute(vcl::PDFWriter::Type,
vcl::PDFWriter::Pagination);
1270 rWriter.SetStructureAttribute(vcl::PDFWriter::Subtype,
vcl::PDFWriter::Watermark);
1271 // HACK: this should produce *nothing* itself but is necessary to
output
1272 // the Artifact tag here, not inside the XObject
1273 rWriter.DrawPolyLine({});
** CID 1538887: Integer handling issues (NEGATIVE_RETURNS)
*** CID 1538887: Integer handling issues (NEGATIVE_RETURNS)
/filter/source/pdf/pdfexport.cxx: 1366 in
PDFExport::ImplWriteTiledWatermark(vcl::PDFWriter &, const Size &)()
1360 pDev->Pop();
1361
1362 rWriter.Push();
1363 // tdf#152235 tag around the reference to the XObject on the page
1364 sal_Int32 const id = rWriter.EnsureStructureElement();
1365 rWriter.InitStructureElement(id, vcl::PDFWriter::NonStructElement,
::std::u16string_view());
>>> CID 1538887: Integer handling issues (NEGATIVE_RETURNS)
>>> "id" is passed to a parameter that cannot be negative.
1366 rWriter.BeginStructureElement(id);
1367 rWriter.SetStructureAttribute(vcl::PDFWriter::Type,
vcl::PDFWriter::Pagination);
1368 rWriter.SetStructureAttribute(vcl::PDFWriter::Subtype,
vcl::PDFWriter::Watermark);
1369 // HACK: this should produce *nothing* itself but is necessary to
output
1370 // the Artifact tag here, not inside the XObject
1371 rWriter.DrawPolyLine({});
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DTGxv_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiwmckhO2Qmj9WZkDG4FMeFYT121Ib676N8AVSloXHZJ4N4LTRwW6S0aFKxfhPXauD0Bl2rEwnaoRVudYzgBV2gEo-2FEktt51Pmy4-2FaSNSO1w9-2B7qzuZoOzF4hP6h-2FHxj2u2Hge3vFoRcVbiI3s3Nga8XUaSOZw2HSGRqZ2P0v4xZ4-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
10 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1538313: Null pointer dereferences (NULL_RETURNS)
*** CID 1538313: Null pointer dereferences (NULL_RETURNS)
/sc/source/core/data/documen3.cxx: 725 in
ScDocument::SetCalcNotification(short)()
719 return false;
720 }
721
722 void ScDocument::SetCalcNotification( SCTAB nTab )
723 {
724 // set only if not set before
>>> CID 1538313: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pTable" when calling
>>> "GetCalcNotification".
725 if (ScTable* pTable = FetchTable(nTab) ;
!pTable->GetCalcNotification())
726 pTable->SetCalcNotification(true);
727 }
728
729 void ScDocument::ResetCalcNotifications()
730 {
** CID 1538312: Null pointer dereferences (NULL_RETURNS)
*** CID 1538312: Null pointer dereferences (NULL_RETURNS)
/sc/source/core/data/documen3.cxx: 472 in ScDocument::GetScenarioData(short,
rtl::OUString &, Color &, ScScenarioFlags &) const()
466 return true;
467 }
468
469 void ScDocument::GetScenarioData( SCTAB nTab, OUString& rComment,
470 Color& rColor, ScScenarioFlags&
rFlags ) const
471 {
>>> CID 1538312: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pTable" when calling
>>> "IsScenario".
472 if (const ScTable* pTable = FetchTable(nTab); pTable->IsScenario())
473 {
474 pTable->GetScenarioComment( rComment );
475 rColor = pTable->GetScenarioColor();
476 rFlags = pTable->GetScenarioFlags();
477 }
** CID 1538311: Null pointer dereferences (NULL_RETURNS)
*** CID 1538311: Null pointer dereferences (NULL_RETURNS)
/sc/source/core/data/documen3.cxx: 441 in ScDocument::SetScenarioData(short,
const rtl::OUString &, const Color &, ScScenarioFlags)()
435 return pTable && pTable->IsScenario();
436 }
437
438 void ScDocument::SetScenarioData( SCTAB nTab, const OUString& rComment,
439 const Color& rColor,
ScScenarioFlags nFlags )
440 {
>>> CID 1538311: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pTable" when calling
>>> "IsScenario".
441 if (ScTable* pTable = FetchTable(nTab); pTable->IsScenario())
442 {
443 pTable->SetScenarioComment( rComment );
444 pTable->SetScenarioColor( rColor );
445 pTable->SetScenarioFlags( nFlags );
446 }
** CID 1538310: Incorrect expression (USELESS_CALL)
*** CID 1538310: Incorrect expression (USELESS_CALL)
/sc/source/core/data/documen3.cxx: 664 in ScDocument::GetSheetEvents(short)
const()
658 return *mxFormulaParserPool;
659 }
660
661 const ScSheetEvents* ScDocument::GetSheetEvents( SCTAB nTab ) const
662 {
663 if (const ScTable* pTable = FetchTable(nTab))
>>> CID 1538310: Incorrect expression (USELESS_CALL)
>>> Calling "pTable->GetSheetEvents()" is only useful for its return value,
>>> which is ignored.
664 pTable->GetSheetEvents();
665 return nullptr;
666 }
667
668 void ScDocument::SetSheetEvents( SCTAB nTab,
std::unique_ptr pNew )
669 {
** CID 1538309:(PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/map.h: 97 in
frozen::map>::map(frozen::bits::carray, (unsigned long)38>, const
std::less &)()
/workdir/UnpackedTarball/frozen/include/frozen/map.h: 97 in
frozen::map>::map(frozen::bits::carray, (unsigned long)23>, const
std::less &)()
/workdir/UnpackedTarball/frozen/include/frozen/map.h: 97 in frozen::map>::map(frozen::bits::carray, (unsigned
long)20>, const std::less &)()
/workdir/UnpackedTarball/frozen/include/frozen/map.h: 97 in
frozen::map>::map(frozen::bits::carray, (unsigned long)40>, const
std::less &)()
*** CID 1538309:(PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/map.h: 97 in
frozen::map>::map(frozen::bits::carray, (unsigned long)38>, const
std::less
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1537992:(DEADCODE)
/tools/source/misc/json_writer.cxx: 150 in tools::writeEscapedSequence(unsigned
int, char *&)()
/tools/source/misc/json_writer.cxx: 152 in tools::writeEscapedSequence(unsigned
int, char *&)()
/tools/source/misc/json_writer.cxx: 153 in tools::writeEscapedSequence(unsigned
int, char *&)()
/tools/source/misc/json_writer.cxx: 151 in tools::writeEscapedSequence(unsigned
int, char *&)()
/tools/source/misc/json_writer.cxx: 149 in tools::writeEscapedSequence(unsigned
int, char *&)()
*** CID 1537992:(DEADCODE)
/tools/source/misc/json_writer.cxx: 150 in tools::writeEscapedSequence(unsigned
int, char *&)()
144 return true;
145 }
146
147 switch (ch)
148 {
149 case '\b':
>>> CID 1537992:(DEADCODE)
>>> Execution cannot reach this statement: "case 9U:".
150 case '\t':
151 case '\n':
152 case '\f':
153 case '\r':
154 case '"':
155 case '/':
/tools/source/misc/json_writer.cxx: 152 in tools::writeEscapedSequence(unsigned
int, char *&)()
146
147 switch (ch)
148 {
149 case '\b':
150 case '\t':
151 case '\n':
>>> CID 1537992:(DEADCODE)
>>> Execution cannot reach this statement: "case 12U:".
152 case '\f':
153 case '\r':
154 case '"':
155 case '/':
156 case '\\':
157 *pos++ = '\\';
/tools/source/misc/json_writer.cxx: 153 in tools::writeEscapedSequence(unsigned
int, char *&)()
147 switch (ch)
148 {
149 case '\b':
150 case '\t':
151 case '\n':
152 case '\f':
>>> CID 1537992:(DEADCODE)
>>> Execution cannot reach this statement: "case 13U:".
153 case '\r':
154 case '"':
155 case '/':
156 case '\\':
157 *pos++ = '\\';
158 *pos++ = getEscapementChar(ch);
/tools/source/misc/json_writer.cxx: 151 in tools::writeEscapedSequence(unsigned
int, char *&)()
145 }
146
147 switch (ch)
148 {
149 case '\b':
150 case '\t':
>>> CID 1537992:(DEADCODE)
>>> Execution cannot reach this statement: "case 10U:".
151 case '\n':
152 case '\f':
153 case '\r':
154 case '"':
155 case '/':
156 case '\\':
/tools/source/misc/json_writer.cxx: 149 in tools::writeEscapedSequence(unsigned
int, char *&)()
143 pos += written;
144 return true;
145 }
146
147 switch (ch)
148 {
>>> CID 1537992:(DEADCODE)
>>> Execution cannot reach this statement: "case 8U:".
149 case '\b':
150 case '\t':
151 case '\n':
152 case '\f':
153 case '\r':
154 case '"':
** CID 1537991: Error handling issues (CHECKED_RETURN)
/cppuhelper/source/paths.cxx: 41 in ::get_this_libpath()::[lambda()
(instance 1)]::operator ()() const()
*** CID 1537991: Error handling issues (CHECKED_RETURN)
/cppuhelper/source/paths.cxx: 41 in ::get_this_libpath()::[lambda()
(instance 1)]::operator ()() const()
35 namespace {
36
37 #if !(defined ANDROID || defined EMSCRIPTEN)
38 OUString get_this_libpath() {
39 static OUString s_uri = []() {
40 OUString uri;
>>> CID 1537991: Error handling issues (CHECKED_RETURN)
>>> Calling "getUrlFromAddress" without checking return value (as is done
>>> elsewhere 4 out of 5 times).
41
osl::Module::getUrlFromAddress(reinterpret_cast(get_this_libpath),
uri);
42 sal_Int32 i = uri.lastIndexOf('/');
43 if (i == -1)
44 {
45 throw css::uno::DeploymentException("URI " + uri + " is
expected to contain a slash");
46 }
To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
123 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1533667: Uninitialized variables (UNINIT)
/libreofficekit/qa/tilebench/tilebench.cxx: 139 in dumpTile(const char *, int,
int, int, const unsigned char *, int, int, int)()
*** CID 1533667: Uninitialized variables (UNINIT)
/libreofficekit/qa/tilebench/tilebench.cxx: 139 in dumpTile(const char *, int,
int, int, const unsigned char *, int, int, int)()
133 buf[1] = (*(pixel + 1) * 255 + alpha / 2) /
alpha;
134 buf[2] = (*(pixel + 0) * 255 + alpha / 2) /
alpha;
135 break;
136 }
137 }
138
>>> CID 1533667: Uninitialized variables (UNINIT)
>>> Using uninitialized element of array "buf" when calling "write".
139 ofs.write(buf, 3);
140 if (dumpText)
141 {
142 int lowResI = (pixel[0] + pixel[1] + pixel[2])/(3*16);
143 fprintf(stderr,"%1x", lowResI);
144 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DroAo_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiuE7cWEprdc6UO-2FaGuA9EG5P8hhtgm9OAY32iD-2BeLXRxsXrhPeymWUQ6-2FXoRBVwh1ZmCmkyM9X19uDEGjBpZeI2sCuPSQApgShZIQKDXTz4z39AnE6rcVHjDxSxxOMV5sTB14dr3xRBJqI48uC2dHQ5MnipBXccO-2FOYWxAX03erY-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
123 new defect(s) introduced to LibreOffice found with Coverity Scan.
565 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 123 defect(s)
** CID 1533655: Security best practices violations (DC.WEAK_CRYPTO)
/tools/Replay.hpp: 214 in StressSocketHandler::StressSocketHandler(SocketPoll
&, std::shared_ptr, const std::__cxx11::basic_string, std::allocator> &, const
std::__cxx11::basic_string, std::allocator>
&, int)()
*** CID 1533655: Security best practices violations (DC.WEAK_CRYPTO)
/tools/Replay.hpp: 214 in StressSocketHandler::StressSocketHandler(SocketPoll
&, std::shared_ptr, const std::__cxx11::basic_string, std::allocator> &, const
std::__cxx11::basic_string, std::allocator>
&, int)()
208 {
209 static std::atomic number;
210 _logPre = "[" + std::to_string(++number) + "] ";
211 std::cerr << "Attempt connect to " << uri << " for trace " <<
_trace << "\n";
212 getNextRecord();
213 _start = std::chrono::steady_clock::now() +
std::chrono::milliseconds(delayMs);
>>> CID 1533655: Security best practices violations (DC.WEAK_CRYPTO)
>>> "rand" should not be used for security-related applications, because
>>> linear congruential algorithms are too easy to break.
214 _nextPing = _start +
std::chrono::milliseconds((long)(std::rand() * 1000.0) / RAND_MAX);
215 _lastTile = _start;
216 }
217
218 void gotPing(WSOpCode /* code */, int pingTimeUs) override
219 {
** CID 1533654: API usage errors (INVALIDATE_ITERATOR)
/test/WopiTestServer.hpp: 519 in WopiTestServer::assertTargetTest(const
Poco::URI &)()
*** CID 1533654: API usage errors (INVALIDATE_ITERATOR)
/test/WopiTestServer.hpp: 519 in WopiTestServer::assertTargetTest(const
Poco::URI &)()
513 const auto testnameIt = std::find_if(params.begin(),
params.end(),
514 [](const
std::pair& pair)
515 { return pair.first ==
"testname"; });
516
517 LOK_ASSERT_MESSAGE_SILENT("Request belongs to an unknown test",
testnameIt != params.end());
518
>>> CID 1533654: API usage errors (INVALIDATE_ITERATOR)
>>> Dereferencing iterator "testnameIt" though it is already past the end
>>> of its container.
519 const std::string target =
StringVector::tokenize(testnameIt->second, '/')[0];
520 LOK_ASSERT_EQUAL_MESSAGE("Request belongs to a different test",
getTestname(), target);
521 }
522
523 /// Here we act as a WOPI server, so that we have a server that
responds to
524 /// the wopi requests without additional expensive setup.
** CID 1533653: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/wsd/DocumentBroker.cpp: 3944 in RenderSearchResultBroker::handleInput(const
std::shared_ptr &)()
*** CID 1533653: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/wsd/DocumentBroker.cpp: 3944 in RenderSearchResultBroker::handleInput(const
std::shared_ptr &)()
3938 _aResposeData.resize(messageData.size() -
commandStringVector.size());
3939 std::copy(messageData.begin() +
commandStringVector.size(), messageData.end(), _aResposeData.begin());
3940
3941 std::string aDataString(_aResposeData.data(),
_aResposeData.size());
3942 // really not ideal that the response works only with
std::string
3943 http::Response httpResponse(http::StatusCode::OK);
>>> CID 1533653: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aDataString" is passed-by-value as parameter to "setBody" when it
>>> could be moved instead.
3944 httpResponse.setBody(aDataString, "image/png");
3945 httpResponse.set("Connection", "close");
3946 _socket->sendAndShutdown(httpResponse);
3947
3948 removeSession(_clientSession);
3949 stop("Finished RenderSearchResult handler.");
** CID 1533652: Performance inefficiencies (PASS_BY_VALUE)
/wsd/Storage.hpp: 440 in StorageBase::sanitizeUri(Poco::URI)()
*** CID 1533652: Performance inefficiencies (PASS_BY_VALUE)
/wsd/Storage.hpp: 440 in StorageBase::sanitizeUri(Poco::URI)()
434
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
37 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 37 defect(s)
** CID 1532480: Uninitialized variables (UNINIT)
*** CID 1532480: Uninitialized variables (UNINIT)
/oox/source/ppt/pptshape.cxx: 458 in
oox::ppt::PPTShape::addShape(oox::core::XmlFilterBase &, const
oox::ppt::SlidePersist &, const oox::drawingml::Theme *, const
com::sun::star::uno::Reference &,
basegfx::B2DHomMatrix &, std::map, std::less,
std::allocator>>> *)()
452 if (meShapeLocation == Slide && mpPlaceholder &&
getTextBody() && getTextBody()->isEmpty())
453 {
454 Reference < XText > xText(mxShape, UNO_QUERY);
455 if (xText.is())
456 {
457 TextCharacterProperties aCharStyleProperties;
>>> CID 1532480: Uninitialized variables (UNINIT)
>>> Using uninitialized value
>>> "aCharStyleProperties.maUnderlineColor.meThemeColorType" when calling
>>> "ApplyStyleEmpty".
458 getTextBody()->ApplyStyleEmpty(rFilterBase, xText,
aCharStyleProperties, mpMasterTextListStyle);
459 }
460 }
461 if (pShapeMap)
462 {
463 // bnc#705982 - if optional model id reference is
** CID 1532479: Memory - corruptions (MISMATCHED_ITERATOR)
/cui/source/tabpages/tptrans.cxx: 373 in SvxTransparenceTabPage::Reset(const
SfxItemSet *)()
*** CID 1532479: Memory - corruptions (MISMATCHED_ITERATOR)
/cui/source/tabpages/tptrans.cxx: 373 in SvxTransparenceTabPage::Reset(const
SfxItemSet *)()
367
m_xMtrTrgrStartValue->set_value(static_cast(((static_cast(aStart.GetRed())
+ 1) * 100) / 255), FieldUnit::PERCENT);
368
m_xMtrTrgrEndValue->set_value(static_cast(((static_cast(aEnd.GetRed())
+ 1) * 100) / 255), FieldUnit::PERCENT);
369
370 // MCGR: preserve ColorStops if given
371 // tdf#155901 We need offset of first and last stop, so include
them.
372 if (rGradient.GetColorStops().size() >= 2)
>>> CID 1532479: Memory - corruptions (MISMATCHED_ITERATOR)
>>> Using iterator "rGradient->GetColorStops()->end()" from
>>> "rGradient->GetColorStops()" with "".
373 maColorStops =
basegfx::BColorStops(rGradient.GetColorStops().begin(),
rGradient.GetColorStops().end());
374 else
375 maColorStops.clear();
376
377 // linear transparence
378 sal_uInt16 nTransp = pLinearItem->GetValue();
** CID 1532478:(CHECKED_RETURN)
/svgio/source/svgreader/svgfecolormatrixnode.cxx: 99 in
svgio::svgreader::SvgFeColorMatrixNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&) const()
/svgio/source/svgreader/svgfecolormatrixnode.cxx: 88 in
svgio::svgreader::SvgFeColorMatrixNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&) const()
*** CID 1532478:(CHECKED_RETURN)
/svgio/source/svgreader/svgfecolormatrixnode.cxx: 99 in
svgio::svgreader::SvgFeColorMatrixNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&) const()
93
std::make_shared(aNum.getNumber(;
94 rTarget = drawinglayer::primitive2d::Primitive2DContainer{ xRef
};
95 }
96 else if (maType == ColorType::HueRotate)
97 {
98 SvgNumber aNum(0.0);
>>> CID 1532478:(CHECKED_RETURN)
>>> Calling "readSingleNumber" without checking return value (as is done
>>> elsewhere 65 out of 67 times).
99 readSingleNumber(maValuesContent, aNum);
100 const drawinglayer::primitive2d::Primitive2DReference xRef(
101 new drawinglayer::primitive2d::ModifiedColorPrimitive2D(
102 std::move(rTarget),
std::make_shared(
103
basegfx::deg2rad(aNum.getNumber();
104 rTarget = drawinglayer::primitive2d::Primitive2DContainer{ xRef
};
/svgio/source/svgreader/svgfecolormatrixnode.cxx: 88 in
svgio::svgreader::SvgFeColorMatrixNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&) const()
82
std::make_shared()));
83 rTarget = drawinglayer::primitive2d::Primitive2DContainer{ xRef
};
84 }
85 else if (maType == ColorType::Saturate)
86 {
87 SvgNumber aNum(1.0);
>>> CID 1532478:(CHECKED_RETURN)
>>> Calling
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1532384: Memory - illegal accesses (OVERRUN)
/sc/source/filter/oox/condformatbuffer.cxx: 268 in
oox::xlsimportOOXColor(const oox::AttributeList &, const
oox::xls::ThemeBuffer &, const oox::GraphicHelper &)()
*** CID 1532384: Memory - illegal accesses (OVERRUN)
/sc/source/filter/oox/condformatbuffer.cxx: 268 in
oox::xlsimportOOXColor(const oox::AttributeList &, const
oox::xls::ThemeBuffer &, const oox::GraphicHelper &)()
262 nColor = rThemeBuffer.getColorByIndex( nThemeIndex );
263 }
264 else if (rAttribs.hasAttribute(XML_indexed))
265 {
266 sal_uInt32 nIndexed = rAttribs.getUnsigned(XML_indexed, 0);
267 if (nIndexed < sizeof(IndexedColors))
>>> CID 1532384: Memory - illegal accesses (OVERRUN)
>>> Overrunning array "oox::xls::IndexedColors" of 66 4-byte elements at
>>> element index 263 (byte offset 1055) using index "nIndexed" (which
>>> evaluates to 263).
268 nColor = IndexedColors[nIndexed];
269 }
270
271 ::Color aColor;
272 double nTint = rAttribs.getDouble(XML_tint, 0.0);
273 if (nTint != 0.0)
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D4i9j_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiCse12Q9RqDBKvTdXFqnSYqIPnp-2FfdbD1Ifp-2FuOwwQ8Qo2bM9oOSeI7wqogUQk6-2BOjb6gfCJL05OKBjXPrkXPHEq5NSv3wLCTAo1Ro3V4ldE4H3qDVn2ndNLSUG1yfrHun5MGgR6RlUyBgsQtvliWqfAVSm-2BVgIq69E6PnbrBmLE-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
4 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1532379: Insecure data handling (TAINTED_SCALAR)
/vcl/source/filter/svm/SvmReader.cxx: 1347 in
SvmReader::FloatTransparentHandler(ImplMetaReadData *)()
*** CID 1532379: Insecure data handling (TAINTED_SCALAR)
/vcl/source/filter/svm/SvmReader.cxx: 1347 in
SvmReader::FloatTransparentHandler(ImplMetaReadData *)()
1341 {
1342 basegfx::BColorStops aColorStops;
1343 sal_uInt16 nTmp;
1344 double fOff, fR, fG, fB;
1345 mrStream.ReadUInt16(nTmp);
1346
>>> CID 1532379: Insecure data handling (TAINTED_SCALAR)
>>> Using tainted variable "nTmp" as a loop boundary.
1347 for (sal_uInt16 a(0); a < nTmp; a++)
1348 {
1349 mrStream.ReadDouble(fOff);
1350 mrStream.ReadDouble(fR);
1351 mrStream.ReadDouble(fG);
1352 mrStream.ReadDouble(fB);
** CID 1532378: Insecure data handling (TAINTED_SCALAR)
/filter/source/svg/svgwriter.cxx: 3400 in
SVGActionWriter::ImplWriteActions(const GDIMetaFile &, unsigned int, const
rtl::OUString &, const
com::sun::star::uno::Reference *, const
GDIMetaFile *)()
*** CID 1532378: Insecure data handling (TAINTED_SCALAR)
/filter/source/svg/svgwriter.cxx: 3400 in
SVGActionWriter::ImplWriteActions(const GDIMetaFile &, unsigned int, const
rtl::OUString &, const
com::sun::star::uno::Reference *, const
GDIMetaFile *)()
3394 SvMemoryStream aMemStm(const_cast(pA->GetData()), pA->GetDataSize(), StreamMode::READ);
3395 VersionCompatRead aCompat(aMemStm);
3396 sal_uInt16 nTmp;
3397 double fOff, fR, fG, fB;
3398 aMemStm.ReadUInt16( nTmp );
3399
>>> CID 1532378: Insecure data handling (TAINTED_SCALAR)
>>> Using tainted variable "nTmp" as a loop boundary.
3400 for (sal_uInt16 a(0); a < nTmp; a++)
3401 {
3402 aMemStm.ReadDouble(fOff);
3403 aMemStm.ReadDouble(fR);
3404 aMemStm.ReadDouble(fG);
3405 aMemStm.ReadDouble(fB);
** CID 1532377: Null pointer dereferences (REVERSE_INULL)
/oox/source/export/drawingml.cxx: 778 in
oox::drawingml::DrawingML::WriteGradientFill(const basegfx::BGradient *, int,
const basegfx::BGradient *, double)()
*** CID 1532377: Null pointer dereferences (REVERSE_INULL)
/oox/source/export/drawingml.cxx: 778 in
oox::drawingml::DrawingML::WriteGradientFill(const basegfx::BGradient *, int,
const basegfx::BGradient *, double)()
772
773 // synchronize ColorStops and AlphaStops as preparation to export
774 // so also gradients 'coupled' indirectly using the
'FillTransparenceGradient'
775 // method (at import time) will be exported again
776 basegfx::utils::synchronizeColorStops(aColorStops, aAlphaStops,
aSingleColor, aSingleAlpha);
777
>>> CID 1532377: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pGradient" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
778 if (aColorStops.size() != aAlphaStops.size() || nullptr ==
pGradient)
779 {
780 // this is an error - synchronizeColorStops above *has* to
create that
781 // state, see description there (!)
782 // also an error - see comment in header - is to give neither
pColorGradient
783 // nor pTransparenceGradient
** CID 1532376: Performance inefficiencies (PASS_BY_VALUE)
/svx/source/table/tablecontroller.cxx: 966 in
sdr::table::SvxTableController::onFormatTable(const SfxRequest &)::[lambda(int)
(instance 1)]::operator ()(int) const()
*** CID 1532376: Performance inefficiencies (PASS_BY_VALUE)
/svx/source/table/tablecontroller.cxx: 966 in
sdr::table::SvxTableController::onFormatTable(const SfxRequest &)::[lambda(int)
(instance 1)]::operator ()(int) const()
960 VclPtr xDlg(
pFact->CreateSvxFormatCellsDialog(
961 rReq.GetFrameWeld(),
962
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
6 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1532370: Uninitialized variables (UNINIT)
*** CID 1532370: Uninitialized variables (UNINIT)
/svx/source/theme/ThemeColorPaletteManager.cxx: 127 in
svx::ThemeColorPaletteManager::generate()()
121 {
122 aColorName = aColorNames[nColor];
123 }
124 rEffect.maColorName = aColorName;
125 }
126 }
>>> CID 1532370: Uninitialized variables (UNINIT)
>>> Using uninitialized value
>>> "aThemePaletteCollection.maColors._M_elems[0].meThemeColorType" when
>>> calling "ThemePaletteCollection".
127 return aThemePaletteCollection;
128 }
129
130 OString ThemeColorPaletteManager::generateJSON()
131 {
132 svx::ThemePaletteCollection aThemePaletteCollection = generate();
** CID 1532369: Null pointer dereferences (FORWARD_NULL)
/sc/source/filter/oox/commentsbuffer.cxx: 170 in
oox::xls::Comment::finalizeImport()()
*** CID 1532369: Null pointer dereferences (FORWARD_NULL)
/sc/source/filter/oox/commentsbuffer.cxx: 170 in
oox::xls::Comment::finalizeImport()()
164 SdrCaptionObj* pCaption = pPostIt->GetOrCreateCaption(
maModel.maRange.aStart );
165
166 rtl::Reference< SvxShapeText > xAnnoShape(
dynamic_cast(pCaption->getUnoShape().get() ) ); // SvxShapeText
167 // setting a property triggers expensive process, so set them
all at once
168
169 // Add shape formatting properties (autoFill, colHidden and
rowHidden are dropped)
>>> CID 1532369: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "xAnnoShape.get()" to "setPropertyValues", which
>>> dereferences it. (The dereference happens because this is a virtual
>>> function call.)
170 static_cast(xAnnoShape.get())->setPropertyValues(
171 Sequence { "TextFitToSize", "MoveProtect",
"TextHorizontalAdjust", "TextVerticalAdjust" },
172 Sequence { Any(maModel.mbAutoScale),
Any(maModel.mbLocked),
173 Any(lcl_ToHorizAlign( maModel.mnTHA )),
Any(lcl_ToVertAlign( maModel.mnTVA )) });
174 if( maModel.maAnchor.Width > 0 && maModel.maAnchor.Height > 0 )
175 {
** CID 1532368: Null pointer dereferences (FORWARD_NULL)
*** CID 1532368: Null pointer dereferences (FORWARD_NULL)
/svgio/source/svgreader/svgfilternode.cxx: 49 in
svgio::svgreader::SvgFilterNode::apply(drawinglayer::primitive2d::Primitive2DContainer
&) const()
43 {
44 SvgNode* pCandidate = rChildren[a].get();
45 if (pCandidate->getType() == SVGToken::FeGaussianBlur)
46 {
47 const SvgFeGaussianBlurNode* pFeGaussianBlurNode
48 = dynamic_cast(pCandidate);
>>> CID 1532368: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pFeGaussianBlurNode" to "apply", which
>>> dereferences it.
49 pFeGaussianBlurNode->apply(rTarget);
50 }
51 else if (pCandidate->getType() == SVGToken::FeColorMatrix)
52 {
53 const SvgFeColorMatrixNode* pFeColorMatrixNode
54 = dynamic_cast(pCandidate);
** CID 1532367:(UNUSED_VALUE)
/sw/source/uibase/misc/redlndlg.cxx: 887 in
SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
/sw/source/uibase/misc/redlndlg.cxx: 892 in
SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
*** CID 1532367:(UNUSED_VALUE)
/sw/source/uibase/misc/redlndlg.cxx: 887 in
SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long)()
881 }
882 }
883 else
884 {
885 // redline is not in a tracked table change
886 bChange = bRowChange = false;
>>> CID 1532367:(UNUSED_VALUE)
>>> Assigning value "2147483647UL" to "nPrevRowChange" here, but that
>>> stored value is overwritten before it can be used.
887 nPrevRowChange = SwRedlineTable::npos;
888 }
889 }
890 else
891 // redline is not in a tracked table change
892
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1531780: Null pointer dereferences (NULL_RETURNS) /sc/source/filter/oox/autofilterbuffer.cxx: 444 in oox::xls::ColorFilter::finalizeImport()() *** CID 1531780: Null pointer dereferences (NULL_RETURNS) /sc/source/filter/oox/autofilterbuffer.cxx: 444 in oox::xls::ColorFilter::finalizeImport()() 438 if (!pStyleSheet) 439 return aSettings; 440 441 const SfxItemSet& rItemSet = pStyleSheet->GetItemSet(); 442 // Color (whether text or background color) is always stored in ATTR_BACKGROUND 443 const SvxBrushItem* pItem = rItemSet.GetItem(ATTR_BACKGROUND); >>> CID 1531780: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pItem->GetFiltColor()", which is known to be "nullptr". 444 ::Color aColor = pItem->GetFiltColor(); 445 util::Color nColor(aColor); 446 aSettings.appendField(true, nColor, mbIsBackgroundColor); 447 return aSettings; 448 } 449 To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DjTil_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiGs-2F8cYct9ORVxABPoYjGwgQrEUP2P7kVdPgjBGSOTLZBueMpZNtNlbLS9ouJlaUdKJDeD1krKFQ8UR14BKlWIk7pw4-2Bk30ZkYzM68p311XC2us2rvnPDaxsyG5MVSxaTIfUsF21YVftRrIkALP9KBe1-2BD5-2FlbB5cva6Y-2BS9CiNQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1530396: Error handling issues (UNCAUGHT_EXCEPT)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 99 in
sw::sidebar::A11yCheckIssuesPanel::~A11yCheckIssuesPanel()()
*** CID 1530396: Error handling issues (UNCAUGHT_EXCEPT)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 99 in
sw::sidebar::A11yCheckIssuesPanel::~A11yCheckIssuesPanel()()
93
94 mpDoc = pDocSh->GetDoc();
95
96 populateIssues();
97 }
98
>>> CID 1530396: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown
>>> but the exception specification "noexcept" doesn't allow it to be thrown.
>>> This will result in a call to terminate().
99 A11yCheckIssuesPanel::~A11yCheckIssuesPanel()
100 {
101 // Restore state when this panel is no longer used
102 if (!mbAutomaticCheckEnabled)
103 {
104 std::shared_ptr batch(
** CID 1530395: Uninitialized variables (UNINIT)
*** CID 1530395: Uninitialized variables (UNINIT)
/sw/source/core/inc/viewimp.hxx: 155 in SwViewShellImp::TakePaintRegion()()
149 void SetFirstVisPageInvalid() { m_bFirstPageInvalid = true; }
150
151 const SwPageFrame* GetLastVisPage(const OutputDevice*
pRenderContext) const;
152
153 bool AddPaintRect( const SwRect );
154 bool HasPaintRegion() { return m_oPaintRegion.has_value(); }
>>> CID 1530395: Uninitialized variables (UNINIT)
>>> Using uninitialized value "ret". Field "ret._M_payload._M_payload" is
>>> uninitialized when calling "optional".
155 std::optional TakePaintRegion() { auto ret =
std::move(m_oPaintRegion); m_oPaintRegion.reset(); return ret; }
156 const std::optional& GetPaintRegion() { return
m_oPaintRegion; }
157 void DeletePaintRegion() { m_oPaintRegion.reset(); }
158
159 void AddPendingLOKInvalidation( const SwRect& rRect );
160 std::vector TakePendingLOKInvalidations();
** CID 1530394: Error handling issues (UNCAUGHT_EXCEPT)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 99 in
sw::sidebar::A11yCheckIssuesPanel::~A11yCheckIssuesPanel()()
*** CID 1530394: Error handling issues (UNCAUGHT_EXCEPT)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 99 in
sw::sidebar::A11yCheckIssuesPanel::~A11yCheckIssuesPanel()()
93
94 mpDoc = pDocSh->GetDoc();
95
96 populateIssues();
97 }
98
>>> CID 1530394: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::DeploymentException" is
>>> thrown but the exception specification "noexcept" doesn't allow it to be
>>> thrown. This will result in a call to terminate().
99 A11yCheckIssuesPanel::~A11yCheckIssuesPanel()
100 {
101 // Restore state when this panel is no longer used
102 if (!mbAutomaticCheckEnabled)
103 {
104 std::shared_ptr batch(
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DqgEt_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiBbdBMvNJPZ8HwxJ-2BksCTAZm6I0aJzCUwhRGQD8y3KuZW6k7Fjt-2FwJKpv8HfK4mhLuLywpWw0i1uiGIxle4Lo7AOyAGoXfBRnaZzmMzl-2FPo0DiZ-2BAyY0Ly-2B-2F8sZe-2B6YjX30M0NZSaAml-2FNvM1wQOl-2FUCE8N6sBn-2FDpStzFL8-2FVyU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1530050: Uninitialized variables (UNINIT)
*** CID 1530050: Uninitialized variables (UNINIT)
/sw/source/core/txtnode/atrflyin.cxx: 238 in SwTextFlyCnt::SetAnchor(const
SwTextNode *)()
232 pTextBox->UnlockModify();
233 }
234 else
235 {
236 pTextBox->MakeFrames();
237 }
>>> CID 1530050: Uninitialized variables (UNINIT)
>>> Using uninitialized value
>>> "aTextBoxAnchor.m_oContentAnchor._M_payload._M_payload" when calling
>>> "~SwFormatAnchor".
238 }
239 }
240
241 // The node may have several SwTextFrames - for every SwTextFrame a
242 // SwFlyInContentFrame is created.
243 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dct5n_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiMXP4lKxbz-2BHcneFpUFS6Ai93TfTbMIJE6D8JcVgPnuEokNKEXjCP7cDgAktBjqPbphpqxQ6pVDnnTv7m-2F3iqNyR1bM24jlcfIjYmmJKQwo9kXyXtOl0yKGMF6PD-2F2g-2FRaFbK4pVPrKF2GVt3pd9EutgZMa6vGVpMu-2FcLlDSpTiU-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1530046:(FORWARD_NULL)
/sd/source/ui/view/drviewsk.cxx: 33 in
sd::DrawViewShell::ConfigurationChanged(utl::ConfigurationBroadcaster *,
ConfigurationHints)()
/sd/source/ui/view/drviewsk.cxx: 33 in
sd::DrawViewShell::ConfigurationChanged(utl::ConfigurationBroadcaster *,
ConfigurationHints)()
*** CID 1530046:(FORWARD_NULL)
/sd/source/ui/view/drviewsk.cxx: 33 in
sd::DrawViewShell::ConfigurationChanged(utl::ConfigurationBroadcaster *,
ConfigurationHints)()
27 if (comphelper::LibreOfficeKit::isActive() && pCurrentShell)
28 {
29 DrawViewShell* pCurrentDrawShell = nullptr;
30 ViewShellBase* pShellBase =
dynamic_cast(pCurrentShell);
31 if(pShellBase)
32 pCurrentDrawShell =
dynamic_cast(pShellBase->GetMainViewShell().get());
>>> CID 1530046:(FORWARD_NULL)
>>> Dereferencing null pointer "pCurrentDrawShell".
33 pCurrentDrawShell->maViewOptions.mnDocBackgroundColor =
pColorConfig->GetColorValue(svtools::DOCCOLOR).nColor;
34 pCurrentDrawShell->maViewOptions.msColorSchemeName =
pColorConfig->GetCurrentSchemeName();
35 SdXImpressDocument* pDoc =
comphelper::getFromUnoTunnel(pCurrentShell->GetCurrentDocument());
36 SfxLokHelper::notifyViewRenderState(pCurrentShell, pDoc);
37 Color
aFillColor(pColorConfig->GetColorValue(svtools::APPBACKGROUND).nColor);
38
SfxViewShell::Current()->libreOfficeKitViewCallback(LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR,
/sd/source/ui/view/drviewsk.cxx: 33 in
sd::DrawViewShell::ConfigurationChanged(utl::ConfigurationBroadcaster *,
ConfigurationHints)()
27 if (comphelper::LibreOfficeKit::isActive() && pCurrentShell)
28 {
29 DrawViewShell* pCurrentDrawShell = nullptr;
30 ViewShellBase* pShellBase =
dynamic_cast(pCurrentShell);
31 if(pShellBase)
32 pCurrentDrawShell =
dynamic_cast(pShellBase->GetMainViewShell().get());
>>> CID 1530046:(FORWARD_NULL)
>>> Dereferencing null pointer "pCurrentDrawShell".
33 pCurrentDrawShell->maViewOptions.mnDocBackgroundColor =
pColorConfig->GetColorValue(svtools::DOCCOLOR).nColor;
34 pCurrentDrawShell->maViewOptions.msColorSchemeName =
pColorConfig->GetCurrentSchemeName();
35 SdXImpressDocument* pDoc =
comphelper::getFromUnoTunnel(pCurrentShell->GetCurrentDocument());
36 SfxLokHelper::notifyViewRenderState(pCurrentShell, pDoc);
37 Color
aFillColor(pColorConfig->GetColorValue(svtools::APPBACKGROUND).nColor);
38
SfxViewShell::Current()->libreOfficeKitViewCallback(LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR,
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DTJn7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJibMfcE8MdZHdSbs2fCzUeNvC3oVy5sW8Jn7snXg7mGF1zP3dV3ai1a8diwmenO-2Bdu6zAINQA5Cp73ORG8pwLkkoCwL5wUERTMDDnbkSwiuzmftgLGDpgGwk7zdp6Zzg1ZE3Mxe-2BV4IBitSoFM-2F0njJWY5pL-2BJqiQ2jhior-2B-2Bw3mk-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1529968: Null pointer dereferences (NULL_RETURNS)
*** CID 1529968: Null pointer dereferences (NULL_RETURNS)
/sc/source/core/data/column3.cxx: 2579 in
::FilterEntriesHandler::processCell(const ScColumn &, int,
ScRefCellValue &)()
2573 sal_uLong nFormat =
mrColumn.GetNumberFormat(mrColumn.GetDoc().GetNonThreadedContext(), nRow);
2574 OUString aStr = ScCellFormat::GetInputString(rCell, nFormat,
*pFormatter, mrColumn.GetDoc(), mbFiltering);
2575
2576 // Colors
2577 ScAddress aPos(rColumn.GetCol(), nRow, rColumn.GetTab());
2578 ScTable* pTable =
rColumn.GetDoc().FetchTable(rColumn.GetTab());
>>> CID 1529968: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pTable" when calling
>>> "GetCellTextColor".
2579 mrFilterEntries.addTextColor(pTable->GetCellTextColor(aPos));
2580
mrFilterEntries.addBackgroundColor(pTable->GetCellBackgroundColor(aPos));
2581
2582 if (rCell.hasString())
2583 {
2584 mrFilterEntries.push_back(ScTypedStrData(std::move(aStr),
0.0, 0.0, ScTypedStrData::Standard, false, mbFilteredRow));
** CID 1529967: Uninitialized variables (UNINIT)
*** CID 1529967: Uninitialized variables (UNINIT)
/sc/source/core/data/sortparam.cxx: 74 in ScSortParam::Clear()()
68
69 aKeyState.bDoSort = false;
70 aKeyState.nField = 0;
71 aKeyState.bAscending = true;
72
73 // Initialize to default size
>>> CID 1529967: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aKeyState". Field "aKeyState.aColorSortMode"
>>> is uninitialized when calling "assign".
74 maKeyState.assign( DEFSORT, aKeyState );
75 }
76
77 ScSortParam& ScSortParam::operator=( const ScSortParam& r )
78 {
79 nCol1 = r.nCol1;
** CID 1529966:(RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in
BitmapMosaicFilter::execute(const BitmapEx &) const()
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in
BitmapMosaicFilter::execute(const BitmapEx &) const()
*** CID 1529966:(RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in
BitmapMosaicFilter::execute(const BitmapEx &) const()
172 aBitmap = *pNewBmp;
173
174 aBitmap.SetPrefMapMode(aMap);
175 aBitmap.SetPrefSize(aPrefSize);
176 }
177 }
>>> CID 1529966:(RESOURCE_LEAK)
>>> Variable "pWriteAcc" going out of scope leaks the storage it points to.
178 }
179
180 if (bRet)
181 return BitmapEx(aBitmap);
182
183 return BitmapEx();
184 }
185
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in
BitmapMosaicFilter::execute(const BitmapEx &) const()
172 aBitmap = *pNewBmp;
173
174 aBitmap.SetPrefMapMode(aMap);
175 aBitmap.SetPrefSize(aPrefSize);
176 }
177 }
>>> CID 1529966:(RESOURCE_LEAK)
>>> Variable "pWriteAcc" going out of scope leaks the storage it points to.
178 }
179
180 if (bRet)
181 return BitmapEx(aBitmap);
182
183 return BitmapEx();
184 }
185
** CID 1529965:(UNINIT)
/sc/source/core/data/sortparam.cxx: 199 in ScSortParam::ScSortParam(const
ScSubTotalParam &, const ScSortParam&)()
/sc/source/core/data/sortparam.cxx: 181 in ScSortParam::ScSortParam(const
ScSubTotalParam &, const ScSortParam&)()
*** CID 1529965:(UNINIT)
/sc/source/core/data/sortparam.cxx: 199 in ScSortParam::ScSortParam(const
ScSubTotalParam &, const ScSortParam&)()
193 if (!bDouble) // do not enter a field twice
194 {
195 ScSortKeyState key;
196 key.bDoSort = true;
197 key.nField = nThisField;
198 key.bAscending = rOld.maKeyState[i].bAscending;
>>> CID 1529965:(UNINIT)
>>> Using uninitialized value "key". Field "key.aColorSortMode" is
>>> uninitialized when calling "push_back". [Note: The source code
>>> implementation of the function has been overridden by a builtin model.]
199
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1529287: Null pointer dereferences (FORWARD_NULL)
*** CID 1529287: Null pointer dereferences (FORWARD_NULL)
/vcl/source/filter/graphicfilter.cxx: 917 in
GraphicFilter::ImportUnloadedGraphic(SvStream &, unsigned long, const Size *)()
911 if( nStatus == ERRCODE_NONE )
912 {
913 bool bAnimated = false;
914 Size aLogicSize;
915 if (eLinkType == GfxLinkType::NativeGif)
916 {
>>> CID 1529287: Null pointer dereferences (FORWARD_NULL)
>>> "getAsStream" dereferences null "aGraphicContent.mpImpl".
917 std::shared_ptr pMemoryStream =
aGraphicContent.getAsStream();
918 bAnimated = IsGIFAnimated(*pMemoryStream, aLogicSize);
919 if (!pSizeHint && aLogicSize.getWidth() &&
aLogicSize.getHeight())
920 {
921 pSizeHint =
922 }
** CID 1529286: Null pointer dereferences (FORWARD_NULL)
/sw/source/ui/index/swuiidxmrk.cxx: 1700 in
::SwCreateAuthEntryDlg_Impl::SwCreateAuthEntryDlg_Impl(weld::Window *,
const rtl::OUString *, SwWrtShell &, bool, bool)()
*** CID 1529286: Null pointer dereferences (FORWARD_NULL)
/sw/source/ui/index/swuiidxmrk.cxx: 1700 in
::SwCreateAuthEntryDlg_Impl::SwCreateAuthEntryDlg_Impl(weld::Window *,
const rtl::OUString *, SwWrtShell &, bool, bool)()
1694 m_pBoxes[nIndex] = m_aBuilders.back()->weld_box("vbox");
1695 m_pEdits[nIndex] = m_aBuilders.back()->weld_entry("entry");
1696
1697 if (AUTH_FIELD_TARGET_URL == aCurInfo.nToxField)
1698 {
1699 m_xTargetURLField = m_pEdits[nIndex].get();
>>> CID 1529286: Null pointer dereferences (FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "this->m_xTargetTypeListBox".
1700 m_xTargetURLField->set_sensitive(
1701 m_xTargetTypeListBox->get_active() ==
SwAuthorityField::TargetType::UseTargetURL);
1702 }
1703
1704 if (bLeft)
1705 m_aOrigContainers.back()->move(m_pBoxes[nIndex].get(),
m_xLeft.get());
** CID 1529285: Uninitialized members (UNINIT_CTOR)
/sw/source/ui/index/swuiidxmrk.cxx: 1776 in
::SwCreateAuthEntryDlg_Impl::SwCreateAuthEntryDlg_Impl(weld::Window *,
const rtl::OUString *, SwWrtShell &, bool, bool)()
*** CID 1529285: Uninitialized members (UNINIT_CTOR)
/sw/source/ui/index/swuiidxmrk.cxx: 1776 in
::SwCreateAuthEntryDlg_Impl::SwCreateAuthEntryDlg_Impl(weld::Window *,
const rtl::OUString *, SwWrtShell &, bool, bool)()
1770 else
1771 ++nRightRow;
1772 bLeft = !bLeft;
1773 }
1774 assert(m_xTypeListBox && "this will exist after the loop");
1775 EnableHdl(*m_xTypeListBox);
>>> CID 1529285: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_xTargetURLField" is not initialized in this
>>> constructor nor in any functions that it calls.
1776 }
1777
1778 OUString SwCreateAuthEntryDlg_Impl::GetEntryText(ToxAuthorityField
eField) const
1779 {
1780 if( AUTH_FIELD_AUTHORITY_TYPE == eField )
1781 {
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DoL2R_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiRTJJu1ykOYVqWd4H4tAh3cSLJQGI7hs74givHHGVjiWFhgwZvHJ9cLU-2BD9P1tL3VqKEDN-2FEdRDxERiKua4zyebr-2BfBmw6AG4Oa4aSfMPd3Tavy-2FQG9W95cAeQKSKjXOWP7iwydq5jwRXH-2BJk6IRu4rZDfNLI1cnWdxbzqyEytok-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
7 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)
** CID 1524751: Null pointer dereferences (FORWARD_NULL)
/vcl/source/graphic/BinaryDataContainer.cxx: 57 in
::ReferencedMemoryStream::ReferencedMemoryStream(const
std::shared_ptr>> &)()
*** CID 1524751: Null pointer dereferences (FORWARD_NULL)
/vcl/source/graphic/BinaryDataContainer.cxx: 57 in
::ReferencedMemoryStream::ReferencedMemoryStream(const
std::shared_ptr>> &)()
51 class ReferencedMemoryStream : public SvMemoryStream
52 {
53 std::shared_ptr> mpData;
54
55 public:
56 ReferencedMemoryStream(const
std::shared_ptr>& rData)
>>> CID 1524751: Null pointer dereferences (FORWARD_NULL)
>>> Attempting to access the managed object of an empty smart pointer
>>> "rData".
57 : SvMemoryStream(rData ? rData->data() : nullptr, rData->size(),
StreamMode::READ)
58 , mpData(rData)
59 {
60 }
61 };
62 }
** CID 1524750: Null pointer dereferences (NULL_RETURNS)
*** CID 1524750: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/access/AccessibilityIssue.cxx: 111 in
sw::AccessibilityIssue::quickFixIssue() const()
105 OUString aDesc = SwResId(STR_ENTER_ALT);
106 SvxNameDialog aNameDialog(m_pParent, "", aDesc);
107 if (aNameDialog.run() == RET_OK)
108 {
109 SwFlyFrameFormat* pFlyFormat
110 =
const_cast(m_pDoc->FindFlyByName(m_sObjectID));
>>> CID 1524750: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pFlyFormat" when
>>> calling "SetFlyFrameTitle".
111 m_pDoc->SetFlyFrameTitle(*pFlyFormat,
aNameDialog.GetName());
112 }
113 }
114 break;
115 default:
116 break;
** CID 1524749:(STRING_OVERFLOW)
/hwpfilter/source/hwpeq.cxx: 715 in eq2ltxconv(rtl::OString &,
std::basic_istream>*, const char *)()
/hwpfilter/source/hwpeq.cxx: 712 in eq2ltxconv(rtl::OString &,
std::basic_istream>*, const char *)()
*** CID 1524749:(STRING_OVERFLOW)
/hwpfilter/source/hwpeq.cxx: 715 in eq2ltxconv(rtl::OString &,
std::basic_istream>*, const char *)()
709 const hwpeq *eq = nullptr;
710 if( (eq = lookup_eqn(key)) != nullptr ) {
711 if( eq->latex )
712 strcpy(key, eq->latex);
713 else {
714 key[0] = '\\';
>>> CID 1524749:(STRING_OVERFLOW)
>>> You might overrun the 256-character fixed-size string "key + 1" by
>>> copying "eq->key" without checking the length.
715 strcpy(key + 1, eq->key);
716 }
717 if( (eq->flag & EQ_CASE)
718 && rtl::isAsciiUpperCase(static_cast(token[0])) )
719 key[1] = sal::static_int_cast(
720 rtl::toAsciiUpperCase(static_cast(key[1])));
/hwpfilter/source/hwpeq.cxx: 712 in eq2ltxconv(rtl::OString &,
std::basic_istream>*, const char *)()
706 if( sentinel && (result == 1) && strchr(sentinel, token[0]) )
707 break;
708 make_keyword(key, token);
709 const hwpeq *eq = nullptr;
710 if( (eq = lookup_eqn(key)) != nullptr ) {
711 if( eq->latex )
>>> CID 1524749:(STRING_OVERFLOW)
>>> You might overrun the 256-character fixed-size string "key" by copying
>>> "eq->latex" without checking the length.
712 strcpy(key, eq->latex);
713 else {
714 key[0] = '\\';
715 strcpy(key + 1, eq->key);
716 }
717 if( (eq->flag & EQ_CASE)
** CID 1524748: Uninitialized members (UNINIT_CTOR)
/sfx2/source/accessibility/AccessibilityIssue.cxx: 18 in
sfx::AccessibilityIssue::AccessibilityIssue(sfx::AccessibilityIssueID)()
*** CID 1524748: Uninitialized members (UNINIT_CTOR)
/sfx2/source/accessibility/AccessibilityIssue.cxx: 18 in
sfx::AccessibilityIssue::AccessibilityIssue(sfx::AccessibilityIssueID)()
12
13 namespace sfx
14 {
15 AccessibilityIssue::AccessibilityIssue(AccessibilityIssueID eIssueID)
16 : m_eIssueID(eIssueID)
17 {
>>> CID 1524748: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524699: Uninitialized variables (UNINIT)
/vcl/unx/generic/gdi/cairotextrender.cxx: 214 in makeCacheId(const
GenericSalLayout &)()
*** CID 1524699: Uninitialized variables (UNINIT)
/vcl/unx/generic/gdi/cairotextrender.cxx: 214 in makeCacheId(const
GenericSalLayout &)()
208 FT_Face aFace = rFont.GetFtFace();
209 CairoFontsCache::CacheId aId;
210 aId.maFace = aFace;
211 aId.mpOptions = rFont.GetFontOptions();
212 aId.mbEmbolden = rInstance.NeedsArtificialBold();
213
>>> CID 1524699: Uninitialized variables (UNINIT)
>>> Using uninitialized value "aId". Field "aId.mbVerticalMetrics" is
>>> uninitialized.
214 return aId;
215 }
216
217 void CairoTextRender::DrawTextLayout(const GenericSalLayout& rLayout,
const SalGraphics& rGraphics)
218 {
219 const LogicalFontInstance& rInstance = rLayout.GetFont();
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Du1Hy_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJikD5l4lGuyVajiDdFNs477-2FnR1-2FFgbD8F2FhcWZBhtxOs5VSI1MwuzKCoSBRK6AQAPlCAjOzciVCNgOb2rWl-2FkNThVhM7yR0TZLTRfH9IPD47VNnyooHW4GlDBhbnf6UUtDwEJ-2BdrnGKRNcvE-2FSssUNNbTt63B-2FaSq-2BseLK3drUA-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1524677:(FORWARD_NULL)
*** CID 1524677:(FORWARD_NULL)
/oox/source/drawingml/fillproperties.cxx: 773 in
oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap
&, const oox::GraphicHelper &, int, Color, const com::sun::star::awt::Size &,
short, bool, bool, bool) const()
767 nBorder = aPrev->first - aNext->first;
768 aGradientStops.erase(aNext);
769 aWidestSegmentStart = aGradientStops.begin();
770 bSwap = true;
771 nShapeRotation = 180*6 - nShapeRotation;
772 }
>>> CID 1524677:(FORWARD_NULL)
>>> Passing null pointer "aWidestSegmentStart->second" to "getColor", which
>>> dereferences it.
773 else if( !bSymmetric &&
774 aGradientStops.size() >= 4 &&
775 aWidestSegmentStart->second.getColor(
rGraphicHelper, nPhClr ) ==
std::next(aWidestSegmentStart)->second.getColor(rGraphicHelper, nPhClr) &&
776
aWidestSegmentStart->second.getTransparency() ==
std::next(aWidestSegmentStart)->second.getTransparency() &&
777 ( aWidestSegmentStart ==
aGradientStops.begin() ||
778std::next(aWidestSegmentStart) ==
std::prev(aGradientStops.end(
/oox/source/drawingml/fillproperties.cxx: 832 in
oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap
&, const oox::GraphicHelper &, int, Color, const com::sun::star::awt::Size &,
short, bool, bool, bool) const()
826
827 // Try to grow the widest segment backwards: if a
previous segment has the same
828 // color, just different transparency, include it.
829 while (aWidestSegmentStart !=
aGradientStops.begin())
830 {
831 auto it = std::prev(aWidestSegmentStart);
>>> CID 1524677:(FORWARD_NULL)
>>> Passing null pointer "aWidestSegmentStart->second" to "getColor", which
>>> dereferences it.
832 if (it->second.getColor(rGraphicHelper, nPhClr)
833 !=
aWidestSegmentStart->second.getColor(rGraphicHelper, nPhClr))
834 {
835 break;
836 }
837
** CID 1524676: Null pointer dereferences (FORWARD_NULL)
*** CID 1524676: Null pointer dereferences (FORWARD_NULL)
/oox/source/drawingml/fillproperties.cxx: 572 in
oox::drawingml::FillProperties::pushToPropMap(oox::drawingml::ShapePropertyMap
&, const oox::GraphicHelper &, int, Color, const com::sun::star::awt::Size &,
short, bool, bool, bool) const()
566 const sal_Int32 nDmlAngle = nShadeAngle +
nShapeRotation;
567 // convert DrawingML angle (in 1/6 degrees) to
API angle (in 1/10 degrees)
568 aGradient.Angle = static_cast< sal_Int16 >( (8100 -
(nDmlAngle / (PER_DEGREE / 10))) % 3600 );
569 }
570
571 // set ColorStops using UNO API
>>> CID 1524676: Null pointer dereferences (FORWARD_NULL)
>>> Passing "aGradient.ColorStops" to
>>> "fillColorStopSequenceFromColorStops", which dereferences null
>>> "aGradient.ColorStops._pSequence".
572
basegfx::utils::fillColorStopSequenceFromColorStops(aGradient.ColorStops,
aColorStops);
573
574 // push gradient or named gradient to property map
575 if (rPropMap.setProperty(ShapeProperty::FillGradient,
aGradient))
576 {
577 eFillStyle = FillStyle_GRADIENT;
To view the defects in Coverity Scan visit,
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1524675: Uninitialized variables (UNINIT)
*** CID 1524675: Uninitialized variables (UNINIT)
/sw/source/core/txtnode/atrflyin.cxx: 243 in SwTextFlyCnt::SetAnchor(const
SwTextNode *)()
237 }
238 }
239 }
240
241 // The node may have several SwTextFrames - for every SwTextFrame a
242 // SwFlyInContentFrame is created.
>>> CID 1524675: Uninitialized variables (UNINIT)
>>> Using uninitialized value
>>> "aAnchor.m_oContentAnchor._M_payload._M_payload" when calling
>>> "~SwFormatAnchor".
243 }
244
245
246 /** GetFlyFrame_() is called during text formatting by SwTextFormatter
247 * and searches for the SwFlyFrame for the dummy char of the current
248 * SwTextFrame. If none is found, a new SwFlyInContentFrame is
created.
** CID 1524674: Uninitialized members (UNINIT_CTOR)
/sw/source/core/undo/unattr.cxx: 130 in
SwUndoFormatAttr::SwUndoFormatAttr(SfxItemSet &&, SwFormat &, bool)()
*** CID 1524674: Uninitialized members (UNINIT_CTOR)
/sw/source/core/undo/unattr.cxx: 130 in
SwUndoFormatAttr::SwUndoFormatAttr(SfxItemSet &&, SwFormat &, bool)()
124 , m_nFormatWhich( rChgFormat.Which() )
125 , m_bSaveDrawPt( bSaveDrawPt )
126 {
127 assert(m_sFormatName.getLength());
128
129 Init( rChgFormat );
>>> CID 1524674: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_nAnchorContentOffset" is not initialized in
>>> this constructor nor in any functions that it calls.
130 }
131
132 SwUndoFormatAttr::SwUndoFormatAttr( const SfxPoolItem& rItem, SwFormat&
rChgFormat,
133 bool bSaveDrawPt )
134 : SwUndo( SwUndoId::INSFMTATTR, rChgFormat.GetDoc() )
135 , m_sFormatName(rChgFormat.GetName())
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DQhxG_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiuUmb5lT84-2BniENgUd0kqypD2lntKPnjCm9CaW2qAnWY-2FcIWn5uKzAUjEma7sDUW0XlGUG0kfVIW-2FdfP4wAjwlzDNDi3ugJMWNq7r5a6cgjF0GgXKe6-2FwA5M-2B16xHe-2BciidyZGvH7qTN-2BPBFlzFfv9Vdj-2Fv-2B9wHD0jko-2BI0CApTQ-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524623: Null pointer dereferences (FORWARD_NULL)
*** CID 1524623: Null pointer dereferences (FORWARD_NULL)
/sc/source/core/data/drwlayer.cxx: 1939 in
ScDrawLayer::CopyFromClip(ScDrawLayer*, short, const tools::Rectangle &, const
ScAddress &, const tools::Rectangle &)()
1933 if (bObjectInArea && (pOldObject->GetLayer() !=
SC_LAYER_INTERN)
1934 && !IsNoteCaption(pOldObject))
1935 {
1936 // Copy style sheet
1937 auto pStyleSheet = pOldObject->GetStyleSheet();
1938 if (pStyleSheet && !bSameDoc)
>>> CID 1524623: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pClipDoc" to "GetStyleSheetPool", which
>>> dereferences it.
1939
pDoc->GetStyleSheetPool()->CopyStyleFrom(pClipDoc->GetStyleSheetPool(),
1940 pStyleSheet->GetName(), pStyleSheet->GetFamily(),
true);
1941
1942 // Clone to target SdrModel
1943 rtl::Reference
pNewObject(pOldObject->CloneSdrObject(*this));
1944
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DfDi0_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiL9Vj-2BAun7alxecPVYX7QH7Z800rjQglVelCn0CFInNPaxR4DmXOuF5Ny-2BpmFqn72WgubEJ0vveoMOLPuq7AmQma658V8lrEYAEP50u0GreOsFY1GSSTROuGY6-2FKAabCrXS3luXKt3EbqTj2yv3-2FDg1KQ-2F-2FyNskObwiq03mnefW6nVNZ0TcSv9cvDoRTbqiit
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524600: Control flow issues (DEADCODE)
/svx/source/svdraw/svdotext.cxx: 1300 in SdrTextObj::ImpAutoFitText(SdrOutliner
&, const Size &, bool) const()
*** CID 1524600: Control flow issues (DEADCODE)
/svx/source/svdraw/svdotext.cxx: 1300 in SdrTextObj::ImpAutoFitText(SdrOutliner
&, const Size &, bool) const()
1294 {
1295 if (aCurrTextSize.Width() != 0)
1296 {
1297 fFactor =
double(rTextSize.Width())/aCurrTextSize.Width();
1298 }
1299 }
>>> CID 1524600: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "if (aCurrTextSize.Height() ...".
1300 else if (aCurrTextSize.Height() != 0)
1301 {
1302 fFactor =
double(rTextSize.Height())/aCurrTextSize.Height();
1303 }
1304 // fFactor scales in both x and y directions
1305 // - this is fine for bulleted words
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DK7Rc_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJipRyHzEdEGaUDJhPMr0veJiM2w6mRszBwpHkD-2BHX0ipzg01hO3LRaqwHZZqu1stAX8EKd6jp1bQKcMzZ5BSxq1EhAWcUHaHAGCdcwDCBiDt9jUpyba9hm9RmK4m2AGo31KNn0am6vm8y-2BMo-2FX77bE-2F7-2FELJH3lY56z6LX1AblLx8-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524497: Uninitialized members (UNINIT_CTOR)
/sw/source/ui/misc/titlepage.cxx: 164 in
SwTitlePageDlg::SwTitlePageDlg(weld::Window *)()
*** CID 1524497: Uninitialized members (UNINIT_CTOR)
/sw/source/ui/misc/titlepage.cxx: 164 in
SwTitlePageDlg::SwTitlePageDlg(weld::Window *)()
158 ,
m_xPagePropertiesLB(m_xBuilder->weld_combo_box("LB_PAGE_PROPERTIES"))
159 , m_xPagePropertiesPB(m_xBuilder->weld_button("PB_PAGE_PROPERTIES"))
160 , m_xOkPB(m_xBuilder->weld_button("ok"))
161 {
162 SwView* pView = GetActiveView();
163 if (!pView)
>>> CID 1524497: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpNormalDesc" is not initialized in this
>>> constructor nor in any functions that it calls.
164 return;
165 SwWrtShell& rWrtShell = pView->GetWrtShell();
166
167 m_xOkPB->connect_clicked(LINK(this, SwTitlePageDlg, OKHdl));
168 m_xRestartNumberingCB->connect_toggled(LINK(this, SwTitlePageDlg,
RestartNumberingHdl));
169 m_xSetPageNumberCB->connect_toggled(LINK(this, SwTitlePageDlg,
SetPageNumberHdl));
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DWiA7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi1msGdBrWmpxmLAmSYRznQb8P-2BK-2FLAPuNo49mvBjF0tnlKiRcPSPBh9uJshR3sYiz8daoEpDQXSJ8pggngGlliE-2FvnEFJtTnC-2FZ1BI3JflBH5Znp8pdLLCCzh7WIGP6sL3RrpGa-2F5jlRAecuV-2BesUvtyRTPu-2BsEzTawVswBXOzv0-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524496: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 66 in
sw::sidebar::A11yCheckIssuesPanel::A11yCheckIssuesPanel(weld::Widget *,
SfxBindings *)()
*** CID 1524496: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx: 66 in
sw::sidebar::A11yCheckIssuesPanel::A11yCheckIssuesPanel(weld::Widget *,
SfxBindings *)()
60 ,
m_xScrolledWindow(m_xBuilder->weld_scrolled_window("scrolledwindow"))
61 , maA11yCheckController(FN_STAT_ACCESSIBILITY_CHECK, *pBindings,
*this)
62 , mnIssueCount(0)
63 {
64 SwDocShell* pDocSh =
dynamic_cast(SfxObjectShell::Current());
65 if (!pDocSh)
>>> CID 1524496: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpDoc" is not initialized in this constructor
>>> nor in any functions that it calls.
66 return;
67
68 mpDoc = pDocSh->GetDoc();
69
70 populateIssues();
71 }
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DKj7-_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJix6wNBaQC04BEBaqzZbTxTC-2BaBSYAWF5w8C6tsbojXvlwTkep6KCZsaoqAKTwr1w79roKG8GIRxbbdBtAGiSzhQpHOvkcn-2BISPi8Ci-2F0oKF-2BUTmpTZIwoQtGa-2FLEMT6kVh2PfPl7Eau96joUTjwX3SVgwi-2Fj6W1z-2F9-2BcHTOuKxO0-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1524485: Possible Control flow issues (DEADCODE)
/cui/source/options/optgdlg.cxx: 822 in OfaViewTabPage::FillItemSet(SfxItemSet
*)()
*** CID 1524485: Possible Control flow issues (DEADCODE)
/cui/source/options/optgdlg.cxx: 822 in OfaViewTabPage::FillItemSet(SfxItemSet
*)()
816 {
817 // Set changed settings to the application instance
818 AllSettings aAllSettings = Application::GetSettings();
819
820 if (bMenuOptModified)
821 {
>>> CID 1524485: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "aStyleSettings.StyleSetting...".
822 StyleSettings aStyleSettings =
aAllSettings.GetStyleSettings();
823 aAllSettings.SetStyleSettings(aStyleSettings);
824 }
825
826 if (bDarkModeOptModified)
827
MiscSettings::SetDarkMode(m_xAppearanceStyleLB->get_active());
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D5lSA_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiUeV3QvrQo6pySkdYmtB7NUEF-2B-2BA97xV2WJY-2BOemzjwF23xpUfvUcGsTEZ1Koe2jzWEegw10mX-2BeqbZWRr5odOldELgOcxig5seIbReEKsWXcsGsUCK2A3w9WDBeSjzWvZbc2oA6zVfyxUPtGx0F0zJUuTcbyzBY95rZZGghASBY-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1523442: Performance inefficiencies (AUTO_CAUSES_COPY)
/sc/source/core/data/column2.cxx: 811 in
ScColumn::GetOptimalColWidth(OutputDevice *, double, double, const Fraction &,
const Fraction &, bool, unsigned short, const ScMarkData *, const
ScColWidthParam *) const()
*** CID 1523442: Performance inefficiencies (AUTO_CAUSES_COPY)
/sc/source/core/data/column2.cxx: 811 in
ScColumn::GetOptimalColWidth(OutputDevice *, double, double, const Fraction &,
const Fraction &, bool, unsigned short, const ScMarkData *, const
ScColWidthParam *) const()
805 ScNeededSizeOptions aOptions;
806 aOptions.bFormula = bFormula;
807 const ScPatternAttr* pOldPattern = nullptr;
808
809 // Go though all non-empty cells within selection.
810 sc::CellStoreType::const_iterator itPos = maCells.begin();
>>> CID 1523442: Performance inefficiencies (AUTO_CAUSES_COPY)
>>> Using the "auto" keyword without an "&" causes the copy of an object of
>>> type RowSpan.
811 for (auto [ nRow, nRow2 ] : aMarkedSpans)
812 {
813 while (nRow <= nRow2)
814 {
815 size_t nOffset;
816 std::tie(itPos, nOffset) = maCells.position(itPos,
nRow);
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DQiwy_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi51pbRrRc3x-2FLJH8fIfHu0ckOTSOgpxE7HT3UAM8CkEl1IDgA3hpdXlzgAz-2Bn3hMk1cRp-2BR4rCDs-2BAaB9OwmGiuJ41l9uMol2gkdJaL-2BIJ7dXP-2B8o9k-2BsCH-2FOwgZhXeoUOl3N-2F85PZRjmqD3N7XoueorkngdXSsbMpqcp7oET4so-3D
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1523394: Null pointer dereferences (FORWARD_NULL)
/sw/source/ui/chrdlg/drpcps.cxx: 245 in SwDropCapsPict::UpdatePaintSettings()()
*** CID 1523394: Null pointer dereferences (FORWARD_NULL)
/sw/source/ui/chrdlg/drpcps.cxx: 245 in SwDropCapsPict::UpdatePaintSettings()()
239 maCTLFont.SetFontSize(Size(0, mnTextH));
240
241 aFont.SetTransparent(true);
242 maCJKFont.SetTransparent(true);
243 maCTLFont.SetTransparent(true);
244
>>> CID 1523394: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "this->mpPage".
245 const Color& rFontColor =
mpPage->m_rSh.GetViewOptions()->GetFontColor();
246
247 aFont.SetColor( rFontColor );
248 maCJKFont.SetColor( rFontColor );
249 maCTLFont.SetColor( rFontColor );
250
** CID 1523393: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/config/viewopt.cxx: 70 in SwViewColors::SwViewColors()()
*** CID 1523393: Uninitialized members (UNINIT_CTOR)
/sw/source/uibase/config/viewopt.cxx: 70 in SwViewColors::SwViewColors()()
64 m_aFieldShadingsColor(COL_LIGHTGRAY),
65 m_aSectionBoundColor(COL_LIGHTGRAY),
66 m_aPageBreakColor(COL_BLUE),
67 m_aScriptIndicatorColor(COL_GREEN),
68 m_aShadowColor(COL_GRAY),
69 m_aHeaderFooterMarkColor(COL_BLUE)
>>> CID 1523393: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_nAppearanceFlags" is not initialized in this
>>> constructor nor in any functions that it calls.
70 {}
71
72 SwViewColors::SwViewColors(const svtools::ColorConfig& rConfig)
73 {
74 m_aDocColor = rConfig.GetColorValue(svtools::DOCCOLOR).nColor;
75
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dsy_e_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiw3yHJo-2F5EeZNYD4sldobq9W37Cgu9PNFUn8gxH9XjjkttF4F3UCY-2B8DG67yROJ5Yy7AgF7EgYbHCscpxU-2F38AfwiURYzGV7wf1h7JtMCTNvIKbro4QoEUpEsyf6HhRZPJ-2BuGolVPTxlhQRepKCy1ZrRnYktoQW2M6w9a7X1Uncg-3D
