core.git: cui/uiconfig
cui/uiconfig/ui/numberingoptionspage.ui |1 + 1 file changed, 1 insertion(+) New commits: commit d52d82140e14d75487243c8d57dbb88e6a968c59 Author: Caolán McNamara AuthorDate: Mon Jun 10 12:40:35 2024 +0100 Commit: Caolán McNamara CommitDate: Mon Jun 10 15:18:38 2024 +0200 fix GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel' Change-Id: I29024237cc2d92d16433cf432f87e2b42107a487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168630 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/numberingoptionspage.ui b/cui/uiconfig/ui/numberingoptionspage.ui index e9d57e62e0e0..5e6a112fa484 100644 --- a/cui/uiconfig/ui/numberingoptionspage.ui +++ b/cui/uiconfig/ui/numberingoptionspage.ui @@ -359,6 +359,7 @@ False 0 True +
core.git: sw/qa
sw/qa/extras/layout/data/crashHyphen.fodt | 31 ++ sw/qa/extras/layout/layout3.cxx |6 + 2 files changed, 37 insertions(+) New commits: commit aa6993e35c38c8be81da326ef41afc980ccc3ef3 Author: Caolán McNamara AuthorDate: Mon Jun 10 08:55:10 2024 +0100 Commit: Caolán McNamara CommitDate: Mon Jun 10 15:04:33 2024 +0200 add test for hyphenation related crash of: commit f050103c3324d878b310f37429ea3580a8230905 Date: Fri Jun 7 20:14:15 2024 +0100 stale hyphenation data after skipping blanks Change-Id: I9743d67b49db054968e9f13c5fc6a13136953733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168606 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/qa/extras/layout/data/crashHyphen.fodt b/sw/qa/extras/layout/data/crashHyphen.fodt new file mode 100644 index ..6cdd2ccc45e6 --- /dev/null +++ b/sw/qa/extras/layout/data/crashHyphen.fodt @@ -0,0 +1,31 @@ + + +http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text"> + + + true + + + + + + + + + + + + + + + + + + + + + + He heard quiet steps behind; + + + diff --git a/sw/qa/extras/layout/layout3.cxx b/sw/qa/extras/layout/layout3.cxx index af480f970164..ab4bb1d52829 100644 --- a/sw/qa/extras/layout/layout3.cxx +++ b/sw/qa/extras/layout/layout3.cxx @@ -2843,6 +2843,12 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf161368) assertXPath(pExportDump, "//page[1]/body/txt[3]/SwParaPortion/SwLineLayout"_ostr, 1); } +CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, TestCrashHyphenation) +{ +//just care it doesn't crash/assert +createSwDoc("crashHyphen.fodt"); +} + } // end of anonymous namespace CPPUNIT_PLUGIN_IMPLEMENT();
[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry
https://bugs.documentfoundation.org/show_bug.cgi?id=157064 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1252 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry
https://bugs.documentfoundation.org/show_bug.cgi?id=157064 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1252 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7064 CC||vsfo...@libreoffice.org --- Comment #5 from V Stuart Foote --- (In reply to Heiko Tietze from comment #4) > Can we make this request a duplicate of bug 157064 Yes please. And rather than one off handling of a few styles as here, we need ability to style against CSL; and even better integration of CSL capable reference managers as extension (e.g. Zotero or Mendeley). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7064 CC||vsfo...@libreoffice.org --- Comment #5 from V Stuart Foote --- (In reply to Heiko Tietze from comment #4) > Can we make this request a duplicate of bug 157064 Yes please. And rather than one off handling of a few styles as here, we need ability to style against CSL; and even better integration of CSL capable reference managers as extension (e.g. Zotero or Mendeley). -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 152706] TRANSLATION: "Requested clipboard format is not available" error message when using DeepL translation feature
https://bugs.documentfoundation.org/show_bug.cgi?id=152706 --- Comment #26 from TANAKA Hidemune --- Created attachment 194627 --> https://bugs.documentfoundation.org/attachment.cgi?id=194627=edit I also reproduced it on Linux. I also reproduced it on Linux. Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 24; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Ubuntu package version: 4:24.2.3-0ubuntu0.24.04.2 Calc: threaded $ java -version openjdk version "1.8.0_412" OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1~24.04.2-b08) OpenJDK 64-Bit Server VM (build 25.412-b08, mixed mode) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=161441 --- Comment #11 from Telesto --- Created attachment 194626 --> https://bugs.documentfoundation.org/attachment.cgi?id=194626=edit Screencast (In reply to Regina Henschel from comment #10) > If I understand Telesto correct, then he copies a shape that has no text, > inserts it and wants to add text. And only then he detects that the shape is > not suitable. He wants to notice it earlier. This is indeed the one part of my experience The other half is about seeing horizontal oriented rectangle shape, but having 90° rotation; it for me counter intuitive. And doesn't make any sense until you add text. Even if you add text, you ask yourself, what's wrong here... why is the text placed top/down.. There is no UI feedback An a drawing easily becomes chaos: And if you have 10 rectangles at various degrees: 270 degrees some at 180 degree some at 0 degree some at 90 degree but only shown horizontal or vertical... what is going on? And you want rotate a few of those.. the rotation itself becomes a challenge and distracts from what you're actually are drawing Turn the shape upside down by 270° degree rotation is odd. A shape with 180° being upside down feels natural. If i asked you to draw a rectangle with a 270° rotation without further information.. what of a result would I get? Vertical or horizontal oriented shape? Or reply: I can't because lack of baseline rotation. You don't think of a shape with a 270° rotation to be upside down containing vertical text --- The whole rotation angle stuff would be less noticeable WYSIWYG with a rotation handle on the shape/ image itself, instead of fiddling with dialog control. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152706] TRANSLATION: "Requested clipboard format is not available" error message when using DeepL translation feature
https://bugs.documentfoundation.org/show_bug.cgi?id=152706 --- Comment #25 from Shinji Enoki --- There was a question about this on Japanese ASK, and it seems to be reproducible on Windows. https://ask.libreoffice.org/t/deepl/106649 It doesn't reproduce in my environment: Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded This issue may only occur on Windows -- You are receiving this mail because: You are the assignee for the bug.
core.git: android/source
android/source/res/values-iw/strings.xml | 118 ++- android/source/res/values-ja/strings.xml |3 2 files changed, 120 insertions(+), 1 deletion(-) New commits: commit 29525b020c3599e2786e04fec1aef0094a36874d Author: Weblate AuthorDate: Sun Jun 9 10:36:50 2024 +0200 Commit: Michael Weghorn CommitDate: Mon Jun 10 14:00:45 2024 +0200 android-viewer translated using Weblate Japanese currently translated at 82.7% (96 of 116 strings) Change-Id: I823d969cd027cbdd3778c5ca6887722831d01fbf android-viewer translated using Weblate Hebrew currently translated at 99.1% (115 of 116 strings) Change-Id: I610c1282074f709b2b08baf6303cd70e2eef19c1 Co-authored-by: Taichi Haradaguchi <20001...@ymail.ne.jp> Co-authored-by: Weblate Co-authored-by: Yaron Shahrabani Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168567 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/android/source/res/values-iw/strings.xml b/android/source/res/values-iw/strings.xml index a6b3daec9354..f5abd82b13bd 100644 --- a/android/source/res/values-iw/strings.xml +++ b/android/source/res/values-iw/strings.xml @@ -1,2 +1,118 @@ - \ No newline at end of file + +רמז: לחיצה כפולה על כותרת עליונה מגדירה רוחב/גובה מיטביים. +אישור +לא לדחוס +לדחוס את התמונה? +הסתרה +הצגה +שגיאה +מציג LibreOffice +הגדרות מציג LibreOffice +גרסה: %1$sbrמזהה הרכבה: a href=https://hub.libreoffice.org/git-core/%2$s%2$s/a; +מציג LibreOffice הוא מציג מסמכים שמבוסס על LibreOffice. +https://he.libreoffice.org +המהדורה הזאת סופקה על ידי $VENDOR. +הקובץ הזה הוא לקריאה בלבד. +הצגת הרישיון +הצגת ההצהרה +מדיניות פרטיות +יצירת קובץ חדש +מסמך טקסט חדש +מצגת חדשה +גיליון נתונים חדש +ציור חדש +ללא שם +בחירת קובץ לפתיחה +איתור הבא +איתור הקודם +סמל_קובץ +קבצים אחרונים +כל הקבצים +כללי +מצב ניסיוני +הפעלת מצב העריכה הניסיוני. על אחריותך בלבד. +מצב פיתוח +הפעלת מצב פיתוח בו ניתן לשלוח פקודות UNO מתוך היישומון. על אחריותך בלבד. +על אודות +חלקים +הגדרות +הצגת מקלדת +שמירה +שמירה בשם… +הפעלת עיצוב +חיפוש +שליחת פקודת UNO +השמירה הושלמה +המסמך נשמר… +שמירת המסמך נכשלה. +סיסמה +הסגה +ביצוע מחדש +לשמור את המסמך טרם הסגירה? +שמירה +ביטול +לא +מצגת שקופיות +הוספת שקופית +חזרה +הוספה +מחיקה +אורך מיטבי +כיוון אורך +כיוון גובה +כיוון רוחב +גובה מיטבי +רוחב מיטבי +אישור +הוספת גיליון עבודה +אישור +ביטול +נא למלא סיסמה +צילום תמונה +בחירת תמונה +בחירת צילום +לא נמצא מצלמה +הגודל הקטן ביותר +גודל בינוני +האיכות המיטבית +העתקה +הדבקה +גזירה +חזרה +הטקסט הועתק ללוח הגזירים +הוספת טבלה +בחירת אפשרויות הוספה: +בחירת אפשרויות מחיקה: +שינוי שם לגיליון העבודה +מחיקת גיליון עבודה +מחיקת שקופית +השם שסופק כבר תפוס. +שם החלק השתנה. +החלק נמחק. +פקודת UNO +סוג +ערך +ביטול +פקודת UBO נוכחית +ייצוא ה־PDF הושלם +לא ניתן לייצא ל־pdf +לא ניתן לשמור קובץ +נא למלא שם לחלק +BMP ריק! +עמוד +גיליון +שקופית +חלק +צבע הדגשה +צבע כתב +שינוי שם לשקופית +אוטומטי +ערך הורה +ייצוא ל־PDF +הדפסה +תו +פסקה +הוספה +סגנון + \ No newline at end of file diff --git a/android/source/res/values-ja/strings.xml b/android/source/res/values-ja/strings.xml index a10aeeed35ee..344a8367dd50 100644 --- a/android/source/res/values-ja/strings.xml +++ b/android/source/res/values-ja/strings.xml @@ -93,4 +93,7 @@ 長さの調整 最小サイズ 写真を撮る +普通サイズ +圧縮しない +写真を圧縮しますか? \ No newline at end of file
[Bug 121436] CALC editing: Shifting Cells when inserting a cut column breaks formulas after the cut column
https://bugs.documentfoundation.org/show_bug.cgi?id=121436 --- Comment #12 from Shinji Enoki --- Reproduced in Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded The case discussed in Japanese ASK used absolute references, so the situation may be a little different, but there were problems even with absolute references. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161492] New: Vertical Tab dialogs--Options column in Area section is not wide enough in paragraph style dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=161492 Bug ID: 161492 Summary: Vertical Tab dialogs--Options column in Area section is not wide enough in paragraph style dialog Product: LibreOffice Version: 24.8.0.0 alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 194625 --> https://bugs.documentfoundation.org/attachment.cgi?id=194625=edit Screenshot comparing vertical and horizontal layout The dialog is still too small. Especially: The 'Options' layout column in the Area section is so small: labels are cut and drop-down arrow in the field overlay the text in the field. The attachment compares horizontal and vertical dialog for 'Gradient' and 'Image'. The 'Options' layout column is nearly half of the width in vertical dialog than in horizontal dialog. Tested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 3c41e714497fdb13cdcbc4d6ba31887d4aaa4b61 CPU threads: 32; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: basic/qa basic/source
basic/qa/basic_coverage/test_tdf160321_gosub_goto.bas | 43 + basic/qa/vba_tests/gosub_goto.vb | 44 ++ basic/source/runtime/runtime.cxx | 15 +++--- 3 files changed, 96 insertions(+), 6 deletions(-) New commits: commit 84e8758d429d5cfaa049cd0bfa437f539029 Author: Andreas Heinisch AuthorDate: Wed Apr 10 21:40:47 2024 +0200 Commit: Andreas Heinisch CommitDate: Mon Jun 10 13:52:00 2024 +0200 tdf#160321 - Don't execute jump statement if the expression is out of range Don't execute On expression GoSub Statement; On expression GoTo Statement if the expression lies out of range. Change-Id: I5c1de25918b5e812d7ec82034f8d56351374d56a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165960 Reviewed-by: Andreas Heinisch Tested-by: Jenkins diff --git a/basic/qa/basic_coverage/test_tdf160321_gosub_goto.bas b/basic/qa/basic_coverage/test_tdf160321_gosub_goto.bas new file mode 100644 index ..79f886fa179d --- /dev/null +++ b/basic/qa/basic_coverage/test_tdf160321_gosub_goto.bas @@ -0,0 +1,43 @@ +' +' This file is part of the LibreOffice project. +' +' This Source Code Form is subject to the terms of the Mozilla Public +' License, v. 2.0. If a copy of the MPL was not distributed with this +' file, You can obtain one at http://mozilla.org/MPL/2.0/. +' + +Option Explicit + +Function doUnitTest() As String +TestUtil.TestInit +verify_GoSub_GoTo +doUnitTest = TestUtil.GetResult() +End Function + +Sub verify_GoSub_GoTo +On Error GoTo errorHandler + +Dim iVar As Integer + +' tdf#160321 - don't execute the GoSub statement if the expression is 0 +On 0 GoSub Sub1, Sub2 +iVar = iVar + 1 +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") + +' tdf#160321 - check the correct functionality of the GoTo statement +On 1 GoTo Sub1, Sub2 +iVar = iVar + 1 + +Exit Sub +Sub1: +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") +On 2 GoTo Sub1, Sub2 +iVar = iVar + 1 +Exit Sub +Sub2: +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") +Exit Sub +errorHandler: +TestUtil.ReportErrorHandler("verify_GoSub_GoTo", Err, Error$, Erl) +Exit Sub +End Sub diff --git a/basic/qa/vba_tests/gosub_goto.vb b/basic/qa/vba_tests/gosub_goto.vb new file mode 100644 index ..523f15ac94c9 --- /dev/null +++ b/basic/qa/vba_tests/gosub_goto.vb @@ -0,0 +1,44 @@ +' +' This file is part of the LibreOffice project. +' +' This Source Code Form is subject to the terms of the Mozilla Public +' License, v. 2.0. If a copy of the MPL was not distributed with this +' file, You can obtain one at http://mozilla.org/MPL/2.0/. +' + +Option VBASupport 1 +Option Explicit + +Function doUnitTest() As String +TestUtil.TestInit +verify_GoSub_GoTo +doUnitTest = TestUtil.GetResult() +End Function + +Sub verify_GoSub_GoTo +On Error GoTo errorHandler + +Dim iVar As Integer + +' tdf#160321 - don't execute the GoSub statement if the expression is 0 +On 0 GoSub Sub1, Sub2 +iVar = iVar + 1 +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") + +' tdf#160321 - check the correct functionality of the GoTo statement +On 1 GoTo Sub1, Sub2 +iVar = iVar + 1 + +Exit Sub +Sub1: +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") +On 2 GoTo Sub1, Sub2 +iVar = iVar + 1 +Exit Sub +Sub2: +TestUtil.AssertEqual(iVar, 1, "iVar incremented incorrectly") +Exit Sub +errorHandler: +TestUtil.ReportErrorHandler("verify_GoSub_GoTo", Err, Error$, Erl) +Exit Sub +End Sub diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx index e2f82d5ad97d..90b40cb8adc8 100644 --- a/basic/source/runtime/runtime.cxx +++ b/basic/source/runtime/runtime.cxx @@ -3043,13 +3043,16 @@ void SbiRuntime::StepONJUMP( sal_uInt32 nOp1 ) { SbxVariableRef p = PopVar(); sal_Int16 n = p->GetInteger(); -if( nOp1 & 0x8000 ) -{ + +if (nOp1 & 0x8000) nOp1 &= 0x7FFF; -PushGosub( pCode + 5 * nOp1 ); -} -if( n < 1 || o3tl::make_unsigned(n) > nOp1 ) -n = static_cast( nOp1 + 1 ); + +// tdf#160321 - do not execute the jump statement if the expression is out of range +if (n < 1 || o3tl::make_unsigned(n) > nOp1) +n = static_cast(nOp1 + 1); +else if (nOp1 & 0x8000) +PushGosub(pCode + 5 * nOp1); + nOp1 = static_cast(pCode - pImg->GetCode()) + 5 * --n; StepJUMP( nOp1 ); }
[Bug 121436] CALC editing: Shifting Cells when inserting a cut column breaks formulas after the cut column
https://bugs.documentfoundation.org/show_bug.cgi?id=121436 --- Comment #11 from TANAKA Hidemune --- There is no consistency in following absolute references Shifting rows or columns may or may not change the references as expected. For more information, see the Japanese Ask. https://ask.libreoffice.org/t/topic/106010 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - xmloff/source
xmloff/source/core/xmlimp.cxx | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) New commits: commit 10bc0a3619f0e7bba07985069cb99663cc688fb9 Author: Mike Kaganski AuthorDate: Mon Jun 10 11:08:56 2024 +0500 Commit: Xisco Fauli CommitDate: Mon Jun 10 13:42:05 2024 +0200 tdf#161488: allow failed image loading in repair mode Change-Id: I19a68f2f016b5ab95565c7fbcc4c435cf13c6b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168596 Reviewed-by: Mike Kaganski Tested-by: Jenkins (cherry picked from commit bf02c5fa586d2ff7dbfac37d3ea0a07675efc15e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168615 Reviewed-by: Xisco Fauli diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx index 209c141fb0d4..e6b1aa66ee7f 100644 --- a/xmloff/source/core/xmlimp.cxx +++ b/xmloff/source/core/xmlimp.cxx @@ -1306,19 +1306,38 @@ uno::Reference SvXMLImport::loadGraphicByURL(OUString const & { uno::Reference xGraphic; -if (mxGraphicStorageHandler.is()) +try { -if (IsPackageURL(rURL)) +if (mxGraphicStorageHandler.is()) { -xGraphic = mxGraphicStorageHandler->loadGraphic(rURL); +if (IsPackageURL(rURL)) +{ +xGraphic = mxGraphicStorageHandler->loadGraphic(rURL); +} +else +{ +OUString const& rAbsoluteURL = GetAbsoluteReference(rURL); +GraphicExternalLink aExternalLink(rAbsoluteURL); +Graphic aGraphic(aExternalLink); +xGraphic = aGraphic.GetXGraphic(); +} } -else +} +catch (...) +{ +bool bRepairPackage = false; +if (auto const xStorProps{ GetSourceStorage().query() }) { -OUString const & rAbsoluteURL = GetAbsoluteReference(rURL); -GraphicExternalLink aExternalLink(rAbsoluteURL); -Graphic aGraphic(aExternalLink); -xGraphic = aGraphic.GetXGraphic(); +try +{ +xStorProps->getPropertyValue(u"RepairPackage"_ustr) >>= bRepairPackage; +} +catch (uno::Exception&) +{ +} } +if (!bRepairPackage) +throw; } return xGraphic;
[Bug 161491] New: Vertical Tab dialogs--Preview image is cut, problem in RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=161491 Bug ID: 161491 Summary: Vertical Tab dialogs--Preview image is cut, problem in RTL Product: LibreOffice Version: 24.8.0.0 alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 194624 --> https://bugs.documentfoundation.org/attachment.cgi?id=194624=edit Screenshot of Indent in RTL The preview image is cut. That is a problem for RTL writing mode. You do not see the indent before text in the Indent category. Tested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 3c41e714497fdb13cdcbc4d6ba31887d4aaa4b61 CPU threads: 32; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161487] LibreOffice 24.2.4.2 (x86_64) takes over 40 minutes to install on Win11/x64.
https://bugs.documentfoundation.org/show_bug.cgi?id=161487 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Not reproducible with Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded or Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 5a75414d1772d1fd998f405e3b9bd80b1f10c51f CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161490] New: Pages per sheet layout wrong on first activation
https://bugs.documentfoundation.org/show_bug.cgi?id=161490 Bug ID: 161490 Summary: Pages per sheet layout wrong on first activation Product: LibreOffice Version: 24.2.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ewblen@e.email Description: On first opening the print dialog and selecting 2 pages per sheet, the preview shows 2 small portrait pages stacked vertically on a portrait paper. (I didn't try printing this to see if it is a true representation) Closing the dialog and reopening gives the expected result of showing 2 portrait pages next to each other on landscape paper. Another user's report of the problem with screenshots is here https://www.reddit.com/r/libreoffice/comments/1akxtna/problem_with_print_multiple_pages_in_242/ Steps to Reproduce: 1. Open print dialog 2. Select Pages per sheet: 2 Actual Results: the preview shows 2 small portrait pages stacked vertically on a portrait paper. Expected Results: preview shows 2 portrait pages next to each other on landscape paper. Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 6; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: en-NZ (en_NZ.UTF-8); UI: en-US Debian package version: 4:24.2.3-1~bpo12+1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 123070] EDITING: Moving fields in Query designer GUI isn't shown with an arrow any more
https://bugs.documentfoundation.org/show_bug.cgi?id=123070 --- Comment #12 from Alex James --- To move a field in Query Designer, simply click and drag the field to the desired position. This helps organize your query for better readability and efficiency. Other than that If you're looking for an amazing game character outfit Saga Anderson Alan Wake 2 FBI Jacket. Check out! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161351] vertical tab dialogs--List styles examples are not readable
https://bugs.documentfoundation.org/show_bug.cgi?id=161351 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Samuel Mehrbrodt (allotropia) --- Confirmed, problem still exists. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 --- Comment #6 from Mike Kaganski --- (In reply to Daniele Mte90 Scasciafratte from comment #5) We do *not* show a crash! We just show the point, at which the error of conversion appeared. And at that point, there was no information about the command line. > Doesn't seems very difficult We welcome anyone. Please read https://www.libreoffice.org/community/developers/, join #libreoffice-dev, and we will be glad to mentor you and provide with code pointers. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 --- Comment #5 from Daniele Mte90 Scasciafratte --- I understand but instead to show a crash, is helpful to show like "the parameter you provided is not supported" as there is a crash it is possible to detect and show a basic error and maybe a link to the documentation. Doesn't seems very difficult, and I understand that require a contributor but it would improve as looking online I wasn't able to find how to use the CLI on libreoffice for converting files that weren't the odt/odp/ods etc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148510] UI: Move table & expand handles are too close together (so get mixed up in use)
https://bugs.documentfoundation.org/show_bug.cgi?id=148510 László Németh changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7833 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 László Németh changed: What|Removed |Added Depends on||157833 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157833 [Bug 157833] Unable to resize columns and rows of a table inside of a frame using the cursor -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 László Németh changed: What|Removed |Added Depends on||157833 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157833 [Bug 157833] Unable to resize columns and rows of a table inside of a frame using the cursor -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 --- Comment #4 from Mike Kaganski --- (In reply to Daniele Mte90 Scasciafratte from comment #3) Before lately, we didn't provide additional information. In those versions, the error would simply be "Error: Please verify input parameters...". Well, adding more information, that would help if needed, makes users unhappy. It would be ideal to tell you specifically "you provided a wrong name", but I know how it's implemented, so I can tell you only "don't hold your breath" ;) - I would guess, that it would take no less than ten years, to find someone who is interested to untangle the whole complexity to deliver the information from layer to layer. The technical info was a simple-to-implement thing to help in cases where it is needed; and in general, no convenience output really substituted reading the documentation. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 --- Comment #3 from Daniele Mte90 Scasciafratte --- I see, but the CLI version shouldn't add this kind of information? Because showing the cpp files usually is a crash as behaviour. The command is the same I am using for odt files like: soffice --headless --convert-to htm:HTML --outdir . libri.odt And works with no issue instead the CSV file crashes. I think that the CLI should give some hints about what I did wrong instead of an error like this that is not helpful. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=161441 --- Comment #10 from Regina Henschel --- (In reply to Heiko Tietze from comment #9) > (In reply to Regina Henschel from comment #8) > > The difference becomes visible when you add text to the shape. > And with text you see what's going on. Why add some indicator, and in what > situation? If I understand Telesto correct, then he copies a shape that has no text, inserts it and wants to add text. And only then he detects that the shape is not suitable. He wants to notice it earlier. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #2 from Mike Kaganski --- This is not a bug. The command line that you used has this: --convert-to htm:HTML Where that ":HTML" was taken from? In any case, not from the documentation [1], which tells, that the argument to --convert-to has, after the output file extension, an optional comma and OutputFilterName. Further, that --convert-to entry has a link to the list of document filters [2], where there is no entries named simply "HTML" in the "API Name (OutputFilterName / InputFilterName)" column. In the "Filters for CALC" section (applicable because CSV are opened in Calc), there is a "HTML (StarCalc)" filter, which would allow e.g. this command line: soffice --headless --convert-to "htm:HTML (StarCalc)" --outdir . LibriNuovi.csv But in fact, even that is unnecessary, because that is the default filter handling htm extension, so this would be the easier working command: soffice --headless --convert-to htm --outdir . LibriNuovi.csv [1] https://help.libreoffice.org/latest/en-US/text/shared/guide/start_parameters.html?DbPAR=SHARED [2] https://help.libreoffice.org/latest/en-US/text/shared/guide/convertfilters.html?=SHARED -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/app/apphdl.cxx|8 sw/source/uibase/app/applab.cxx|4 sw/source/uibase/app/docsh.cxx |6 sw/source/uibase/app/docsh2.cxx| 34 +- sw/source/uibase/app/docshini.cxx |2 sw/source/uibase/app/docst.cxx | 34 +- sw/source/uibase/app/swdll.cxx |6 sw/source/uibase/app/swmodul1.cxx |4 sw/source/uibase/app/swmodule.cxx |4 sw/source/uibase/config/StoredChapterNumbering.cxx | 10 sw/source/uibase/config/barcfg.cxx |2 sw/source/uibase/config/caption.cxx|4 sw/source/uibase/config/dbconfig.cxx | 14 sw/source/uibase/config/fontcfg.cxx| 62 +-- sw/source/uibase/config/modcfg.cxx | 268 - sw/source/uibase/config/prtopt.cxx |2 sw/source/uibase/config/usrpref.cxx| 12 sw/source/uibase/config/viewopt.cxx|8 sw/source/uibase/dbui/dbmgr.cxx| 80 ++--- sw/source/uibase/dbui/dbui.cxx | 26 - sw/source/uibase/dbui/mailmergehelper.cxx |4 sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx | 20 - sw/source/uibase/dbui/mmconfigitem.cxx | 104 +++--- sw/source/uibase/dialog/watermarkdialog.cxx| 22 - sw/source/uibase/dochdl/gloshdl.cxx|2 sw/source/uibase/dochdl/swdtflvr.cxx | 18 - sw/source/uibase/docvw/AnnotationMenuButton.cxx| 36 +- sw/source/uibase/docvw/AnnotationWin.cxx | 10 sw/source/uibase/docvw/AnnotationWin2.cxx | 24 - sw/source/uibase/docvw/HeaderFooterWin.cxx | 16 - sw/source/uibase/docvw/OutlineContentVisibilityWin.cxx |7 sw/source/uibase/docvw/PageBreakWin.cxx| 10 sw/source/uibase/docvw/UnfloatTableButton.cxx |8 sw/source/uibase/docvw/contentcontrolaliasbutton.cxx |7 sw/source/uibase/docvw/edtwin.cxx |4 sw/source/uibase/docvw/edtwin2.cxx |4 sw/source/uibase/docvw/romenu.cxx |2 sw/source/uibase/docvw/srcedtw.cxx |2 sw/source/uibase/envelp/envimg.cxx |2 sw/source/uibase/envelp/labelcfg.cxx |8 sw/source/uibase/envelp/labimg.cxx |2 sw/source/uibase/envelp/syncbtn.cxx|4 sw/source/uibase/fldui/xfldui.cxx |2 sw/source/uibase/globdoc/globdoc.cxx |2 sw/source/uibase/inc/inputwin.hxx |8 sw/source/uibase/lingu/olmenu.cxx | 66 ++-- sw/source/uibase/misc/glosdoc.cxx |4 sw/source/uibase/misc/redlndlg.cxx | 16 - sw/source/uibase/ribbar/inputwin.cxx |4 sw/source/uibase/ribbar/workctrl.cxx | 28 - sw/source/uibase/table/chartins.cxx|6 sw/source/uibase/table/tablemgr.cxx|8 sw/source/uibase/uitest/uiobject.cxx | 70 ++-- sw/source/uibase/web/wdocsh.cxx|2 sw/source/uibase/web/wformsh.cxx |2 sw/source/uibase/web/wfrmsh.cxx|2 sw/source/uibase/web/wgrfsh.cxx|4 sw/source/uibase/web/wlistsh.cxx |2 sw/source/uibase/web/wolesh.cxx|4 sw/source/uibase/web/wtabsh.cxx|4 sw/source/uibase/web/wtextsh.cxx |2 sw/source/uibase/wrtsh/select.cxx |8 sw/source/uibase/wrtsh/wrtsh1.cxx | 24 - sw/source/uibase/wrtsh/wrtsh2.cxx | 92 ++--- sw/source/uibase/wrtsh/wrtsh3.cxx |8 65 files changed, 638 insertions(+), 636 deletions(-) New commits: commit 18ef391582e1f8db5838dfc1aaff36f78ce51447 Author: Noel Grandin AuthorDate: Mon Jun 10 10:36:45 2024 +0200 Commit: Noel Grandin CommitDate: Mon Jun 10 12:15:17 2024 +0200 loplugin:ostr in sw/../uibase Change-Id: I4f4284b55d481caa006743688e6d83cc3c713b5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168601 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx index 28c766b3d3b1..9e5ada1b0101 100644 --- a/sw/source/uibase/app/apphdl.cxx +++ b/sw/source/uibase/app/apphdl.cxx @@ -309,7 +309,7 @@ SwView* lcl_LoadDoc(SwView* pView, const OUString& rURL) if(!rURL.isEmpty()) {
[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=161441 --- Comment #9 from Heiko Tietze --- (In reply to Regina Henschel from comment #8) > The difference becomes visible when you add text to the shape. And with text you see what's going on. Why add some indicator, and in what situation? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143231] Spellcheck: "correct all" replaces only current occurrence (MacOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=143231 --- Comment #7 from birnb...@posteo.de --- Sorry, I cannot confirm. "Lorem Lorem Lorem" --(correct all)--> "Loren Loren Loren" (correct) "Lorem Lorem ipsum [50 words more] Lorem" --(correct all)--> "Loren Loren ipsum [50 words] Lorem" (partially correct) It seems like the "replace all" function starts off well and stops eventually. I checked this with LO 7.5.7.1. To be sure I upgraded to Version: 7.6.7.2 (AARCH64) / LibreOffice Community Build ID: dd47e4b30cb7dab30588d6c79c651f218165e3c5 CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Metal; VCL: osx Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded with the same result -- You are receiving this mail because: You are the assignee for the bug.
core.git: linguistic/source
linguistic/source/lngprophelp.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit d25de4a04671c2f380fc86a58259b073c49dfe19 Author: Caolán McNamara AuthorDate: Mon Jun 10 08:52:29 2024 +0100 Commit: Caolán McNamara CommitDate: Mon Jun 10 12:04:17 2024 +0200 silence unknown property 'HyphNoLastWord'... etc warnings warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphNoLastWord' warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeepType' warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeep' Change-Id: I4f99961e17bd4e0f90925b8530e25729d964d42e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168600 Reviewed-by: Caolán McNamara Tested-by: Jenkins diff --git a/linguistic/source/lngprophelp.cxx b/linguistic/source/lngprophelp.cxx index e3d09665625e..ce479ee851d8 100644 --- a/linguistic/source/lngprophelp.cxx +++ b/linguistic/source/lngprophelp.cxx @@ -632,6 +632,13 @@ void PropertyHelper_Hyphen::SetTmpPropVals( const PropertyValues ) pnResVal = else if ( rVal.Name == UPN_HYPH_NO_CAPS ) pbResVal = +else if (rVal.Name == UPN_HYPH_NO_LAST_WORD || + rVal.Name == UPN_HYPH_KEEP || + rVal.Name == UPN_HYPH_KEEP_TYPE) +{ +// skip these known ones without warnings +continue; +} SAL_WARN_IF( !(pnResVal || pbResVal), "linguistic", "unknown property '" << rVal.Name << "'");
[Bug 161480] Animated gif renders with green artifacts with Skia/Raster & Metal
https://bugs.documentfoundation.org/show_bug.cgi?id=161480 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression OS|macOS (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=161441 --- Comment #8 from Regina Henschel --- Created attachment 194623 --> https://bugs.documentfoundation.org/attachment.cgi?id=194623=edit Text in shape on optical 5x2 rectangle The difference becomes visible when you add text to the shape. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 --- Comment #1 from Daniele Mte90 Scasciafratte --- Created attachment 194622 --> https://bugs.documentfoundation.org/attachment.cgi?id=194622=edit the file generating the crash -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161489] New: CSV convert to HTML from cli crash
https://bugs.documentfoundation.org/show_bug.cgi?id=161489 Bug ID: 161489 Summary: CSV convert to HTML from cli crash Product: LibreOffice Version: 24.2.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mte90...@gmail.com Description: So I have a CSV with cells separated by a double semi-colon and if I try to convert it as HTML I get this: soffice --headless --convert-to htm:HTML --outdir . LibriNuovi.csv This is the output: convert /path/LibriNuovi.csv as a Calc document -> /path/LibriNuovi.htm using filter : HTML Error: Please verify input parameters... (SfxBaseModel::impl_store failed: 0xc10(Error Area:Io Class:Write Code:16) at ./sfx2/source/doc/sfxbasemodel.cxx:3274 at ./sfx2/source/doc/sfxbasemodel.cxx:1822) My guess is that as LibreOffice requires on opening a CSV some filter on how to load the file it is expecting the same in this way and somehow crashes. In this case there should be a output informing that or some documentation (that I wasn't able to find). Steps to Reproduce: 1. Try with the attached file and the same command Actual Results: That output Expected Results: The html file generated Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: it-IT (it_IT.UTF-8); UI: it-IT Debian package version: 4:24.2.4-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155692] Resizing RTL table cells is almost impossible (very tricky)
https://bugs.documentfoundation.org/show_bug.cgi?id=155692 László Németh changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | CC||nem...@numbertext.org Status|NEEDINFO|ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157833] Unable to resize columns and rows of a table inside of a frame using the cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=157833 László Németh changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'private/quwex/notespane-search' - sd/source
sd/source/ui/view/Outliner.cxx | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) New commits: commit 196fab317381872a80879420c0a2b8fbcb08af39 Author: Sarper Akdemir AuthorDate: Mon Jun 10 10:40:27 2024 +0200 Commit: Sarper Akdemir CommitDate: Mon Jun 10 10:46:23 2024 +0200 Fix crash on search initated from notes pane on the OutlineView Change-Id: I128f5398a9abec57168d72a711fadab2584c4a94 diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx index 727cef1a7f9f..f43570bb9a68 100644 --- a/sd/source/ui/view/Outliner.cxx +++ b/sd/source/ui/view/Outliner.cxx @@ -999,14 +999,17 @@ void SdOutliner::DetectChange() pFakeShell = pViewShellManager->GetOverridingMainShell(); auto bViewChanged = false; -if( !pFakeShell && pDrawViewShell ) -bViewChanged = (aPosition.meEditMode != pDrawViewShell->GetEditMode() || aPosition.mePageKind != pDrawViewShell->GetPageKind()); -else if (pFakeShell) -{ -auto pPage = pFakeShell->getCurrentPage(); -auto ePageKind = pPage ? pPage->GetPageKind() : PageKind::Standard; -auto eEditMode = EditMode::Page; -bViewChanged = (aPosition.meEditMode != eEditMode || aPosition.mePageKind != ePageKind); +if( pDrawViewShell ) +{ +if( !pFakeShell ) +bViewChanged = (aPosition.meEditMode != pDrawViewShell->GetEditMode() || aPosition.mePageKind != pDrawViewShell->GetPageKind()); +else +{ +auto pPage = pFakeShell->getCurrentPage(); +auto ePageKind = pPage ? pPage->GetPageKind() : PageKind::Standard; +auto eEditMode = EditMode::Page; +bViewChanged = (aPosition.meEditMode != eEditMode || aPosition.mePageKind != ePageKind); +} } // Detect whether the view has been switched from the outside.
core.git: Branch 'feature/cib_contract49c' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c405694fce4c54ada5292f11286e99a8172d7e27 Author: Samuel Mehrbrodt AuthorDate: Mon Jun 10 10:41:09 2024 +0200 Commit: Gerrit Code Review CommitDate: Mon Jun 10 10:41:09 2024 +0200 Update git submodules * Update translations from branch 'feature/cib_contract49c' to 221d20eaf354f82b10065e8d9fc3b365182412c1 - Add translation for "Change bullet" btn Change-Id: Ib9c661f092449b1dfad0674dd765da6387ffe766 diff --git a/translations b/translations index 90e048d8ffa2..221d20eaf354 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 90e048d8ffa2e03a35e0a8f9f3c53bb293ea0942 +Subproject commit 221d20eaf354f82b10065e8d9fc3b365182412c1
translations.git: Branch 'feature/cib_contract49c' - source/de
source/de/cui/messages.po |6 ++ 1 file changed, 6 insertions(+) New commits: commit 221d20eaf354f82b10065e8d9fc3b365182412c1 Author: Samuel Mehrbrodt AuthorDate: Mon Jun 10 10:39:46 2024 +0200 Commit: Samuel Mehrbrodt CommitDate: Mon Jun 10 10:40:55 2024 +0200 Add translation for "Change bullet" btn Change-Id: Ib9c661f092449b1dfad0674dd765da6387ffe766 diff --git a/source/de/cui/messages.po b/source/de/cui/messages.po index bc0fc0f5b1c..62cb35a3173 100644 --- a/source/de/cui/messages.po +++ b/source/de/cui/messages.po @@ -18488,6 +18488,12 @@ msgctxt "pickbulletpage|extended_tip|valueset" msgid "Click the bullet style that you want to use." msgstr "Klicken Sie auf den gewünschten Aufzählungsstil." +#. WfEwh +#: cui/uiconfig/ui/pickbulletpage.ui:52 +msgctxt "pickbulletpage|changeBulletBtn" +msgid "Change Bullet" +msgstr "Aufzählungszeichen wechseln" + #. K4D8E #: cui/uiconfig/ui/pickbulletpage.ui:50 msgctxt "pickbulletpage|label25"
core.git: sw/qa
sw/qa/extras/accessibility/accessible_relation_set.cxx |5 sw/qa/extras/accessibility/basics.cxx | 27 sw/qa/extras/accessibility/dialogs.cxx | 20 sw/qa/extras/docbookexport/docbookexport.cxx |4 sw/qa/extras/fodfexport/fodfexport.cxx |9 sw/qa/extras/globalfilter/globalfilter.cxx | 448 ++--- sw/qa/extras/htmlexport/htmlexport.cxx | 606 +++ sw/qa/extras/htmlexport/xhtmlexport.cxx| 18 sw/qa/extras/htmlimport/htmlimport.cxx | 158 - sw/qa/extras/indexing/IndexingExportTest.cxx | 242 +- sw/qa/extras/indexing/SearchResultLocatorTest.cxx |2 sw/qa/extras/layout/layout.cxx | 1462 - sw/qa/extras/layout/layout2.cxx| 629 +++ sw/qa/extras/layout/layout3.cxx| 354 ++-- sw/qa/extras/mailmerge/mailmerge.cxx | 78 sw/qa/extras/mailmerge/mailmerge2.cxx | 72 sw/qa/extras/odfexport/odfexport.cxx | 1458 sw/qa/extras/odfexport/odfexport2.cxx | 720 sw/qa/extras/odfimport/odfimport.cxx | 494 ++--- sw/qa/extras/ooxmlexport/ooxml_ThemeExport.cxx | 24 sw/qa/extras/ooxmlexport/ooxmlencryption.cxx | 10 sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 422 ++-- sw/qa/extras/ooxmlexport/ooxmlexport10.cxx | 248 +- sw/qa/extras/ooxmlexport/ooxmlexport11.cxx | 340 +-- sw/qa/extras/ooxmlexport/ooxmlexport12.cxx | 1174 ++--- sw/qa/extras/ooxmlexport/ooxmlexport13.cxx | 652 +++ sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 614 +++ sw/qa/extras/ooxmlexport/ooxmlexport15.cxx | 502 ++--- sw/qa/extras/ooxmlexport/ooxmlexport16.cxx | 342 +-- sw/qa/extras/ooxmlexport/ooxmlexport17.cxx | 454 ++--- sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 390 ++-- sw/qa/extras/ooxmlexport/ooxmlexport19.cxx | 376 ++-- sw/qa/extras/ooxmlexport/ooxmlexport2.cxx | 446 ++--- sw/qa/extras/ooxmlexport/ooxmlexport20.cxx | 452 ++--- sw/qa/extras/ooxmlexport/ooxmlexport21.cxx | 383 ++-- sw/qa/extras/ooxmlexport/ooxmlexport3.cxx | 528 +++--- sw/qa/extras/ooxmlexport/ooxmlexport4.cxx | 394 ++-- sw/qa/extras/ooxmlexport/ooxmlexport5.cxx | 296 +-- sw/qa/extras/ooxmlexport/ooxmlexport6.cxx | 368 ++-- sw/qa/extras/ooxmlexport/ooxmlexport7.cxx | 410 ++-- sw/qa/extras/ooxmlexport/ooxmlexport8.cxx | 324 +-- sw/qa/extras/ooxmlexport/ooxmlexport9.cxx | 706 sw/qa/extras/ooxmlexport/ooxmlexport_template.cxx | 13 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx | 358 ++-- sw/qa/extras/ooxmlexport/ooxmllinks.cxx| 46 sw/qa/extras/ooxmlexport/ooxmlw14export.cxx| 624 +++ sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 688 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx | 301 +-- sw/qa/extras/pdf/HybridPdfTest.cxx |8 sw/qa/extras/rtfexport/rtfexport.cxx | 326 +-- sw/qa/extras/rtfexport/rtfexport2.cxx | 261 +-- sw/qa/extras/rtfexport/rtfexport3.cxx | 284 +-- sw/qa/extras/rtfexport/rtfexport4.cxx | 415 ++-- sw/qa/extras/rtfexport/rtfexport5.cxx | 335 ++- sw/qa/extras/rtfexport/rtfexport6.cxx | 265 +-- sw/qa/extras/rtfexport/rtfexport8.cxx |6 sw/qa/extras/rtfimport/rtfimport.cxx | 920 +- sw/qa/extras/tiledrendering/tiledrendering.cxx | 376 ++-- sw/qa/extras/tiledrendering2/tiledrendering2.cxx |6 sw/qa/extras/txtencexport/txtencexport.cxx |6 sw/qa/extras/txtexport/txtexport.cxx | 10 sw/qa/extras/txtimport/txtimport.cxx | 16 sw/qa/extras/uiwriter/uiwriter.cxx | 444 ++--- sw/qa/extras/uiwriter/uiwriter2.cxx| 1109 ++-- sw/qa/extras/uiwriter/uiwriter3.cxx| 776 - sw/qa/extras/uiwriter/uiwriter4.cxx| 525 +++--- sw/qa/extras/uiwriter/uiwriter5.cxx| 1094 ++-- sw/qa/extras/uiwriter/uiwriter6.cxx| 523 +++--- sw/qa/extras/uiwriter/uiwriter7.cxx| 540 +++--- sw/qa/extras/uiwriter/uiwriter8.cxx| 998 +-- sw/qa/extras/uiwriter/uiwriter9.cxx| 102 - sw/qa/extras/unowriter/unowriter.cxx | 351 ++-- sw/qa/extras/ww8export/ww8export.cxx | 458 ++---
core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Math.xcs |6 ++ 1 file changed, 6 insertions(+) New commits: commit 71e905b62b02f28e6eca728f763a845509bf5a1a Author: Julien Nabet AuthorDate: Sat Jun 8 11:18:37 2024 +0200 Commit: Julien Nabet CommitDate: Mon Jun 10 09:56:25 2024 +0200 Related tdf#134193: declare right-to-left in Math.xcs Change-Id: I4341f8dd84a17b4f8dd9da2e4f031ed38590d881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168568 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/officecfg/registry/schema/org/openoffice/Office/Math.xcs b/officecfg/registry/schema/org/openoffice/Office/Math.xcs index 7c052633bad0..026f33b5e983 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Math.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Math.xcs @@ -390,6 +390,12 @@ false + + + Enables right-to-left layout. + +false + Specifies the default layout for symbols from the 'Greek' symbol set.
core.git: include/svx svx/source
include/svx/svdograf.hxx | 14 ++--- svx/source/svdraw/svdograf.cxx | 104 - 2 files changed, 59 insertions(+), 59 deletions(-) New commits: commit fd7418c1f75e855a19078c6288a024b1b465f614 Author: Miklos Vajna AuthorDate: Mon Jun 10 08:41:56 2024 +0200 Commit: Miklos Vajna CommitDate: Mon Jun 10 09:54:14 2024 +0200 svx: prefix members of SdrGrafObj See tdf#94879 for motivation. Change-Id: Icc587c31582fb5fdfbdfe375005b96ea219bf4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168597 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx index ec2c94ab3f45..88296f4a2629 100644 --- a/include/svx/svdograf.hxx +++ b/include/svx/svdograf.hxx @@ -79,14 +79,14 @@ private: SAL_DLLPRIVATE virtual std::unique_ptr CreateObjectSpecificProperties() override; SAL_DLLPRIVATE void ImpSetAttrToGrafInfo(); // Copy values from the pool -GraphicAttr aGrafInfo; +GraphicAttr m_aGrafInfo; -OUString aFileName; // If it's a Link, the filename can be found in here -OUString aFilterName; +OUString m_aFileName; // If it's a Link, the filename can be found in here +OUString m_aFilterName; std::unique_ptr mpGraphicObject; // In order to speed up output of bitmaps, especially rotated ones std::unique_ptr mpReplacementGraphicObject; -SdrGraphicLink* pGraphicLink; // And here a pointer for linked graphics -bool bMirrored:1; // True: the graphic is horizontal, which means it's mirrored along the y-axis +SdrGraphicLink* m_pGraphicLink; // And here a pointer for linked graphics +bool m_bMirrored:1; // True: the graphic is horizontal, which means it's mirrored along the y-axis // Flag for allowing text animation. Default is true. bool mbGrafAnimationAllowed:1; @@ -157,7 +157,7 @@ public: voidReleaseGraphicLink(); bool IsLinkedGraphic() const; -const OUString& GetFileName() const { return aFileName;} +const OUString& GetFileName() const { return m_aFileName;} voidStartAnimation(); @@ -192,7 +192,7 @@ public: SAL_DLLPRIVATE virtual voidNotify( SfxBroadcaster& rBC, const SfxHint& rHint ) override; -bool IsMirrored() const { return bMirrored;} +bool IsMirrored() const { return m_bMirrored;} SAL_DLLPRIVATE void SetMirrored( bool _bMirrored ); virtual bool shouldKeepAspectRatio() const override { return true; } diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx index 1e09eccab766..a0c97cc3dde9 100644 --- a/svx/source/svdraw/svdograf.cxx +++ b/svx/source/svdraw/svdograf.cxx @@ -86,7 +86,7 @@ SdrGraphicLink::SdrGraphicLink(SdrGrafObj& rObj) if( pLinkManager && rValue.hasValue() ) { -sfx2::LinkManager::GetDisplayNames( this, nullptr, , nullptr, ); +sfx2::LinkManager::GetDisplayNames( this, nullptr, _aFileName, nullptr, _aFilterName ); Graphic aGraphic; if (pLinkManager->GetGraphicFromAny(rMimeType, rValue, aGraphic, nullptr)) @@ -106,7 +106,7 @@ void SdrGraphicLink::Closed() { // close connection; set pLink of the object to NULL, as link instance is just about getting destructed. rGrafObj.ForceSwapIn(); -rGrafObj.pGraphicLink=nullptr; +rGrafObj.m_pGraphicLink=nullptr; rGrafObj.ReleaseGraphicLink(); SvBaseLink::Closed(); } @@ -181,8 +181,8 @@ void SdrGrafObj::onGraphicChanged() SdrGrafObj::SdrGrafObj(SdrModel& rSdrModel) : SdrRectObj(rSdrModel) ,mpGraphicObject(new GraphicObject) -,pGraphicLink(nullptr) -,bMirrored(false) +,m_pGraphicLink(nullptr) +,m_bMirrored(false) ,mbIsSignatureLine(false) ,mbIsSignatureLineShowSignDate(true) ,mbIsSignatureLineCanAddComment(false) @@ -205,7 +205,7 @@ SdrGrafObj::SdrGrafObj(SdrModel& rSdrModel) SdrGrafObj::SdrGrafObj(SdrModel& rSdrModel, SdrGrafObj const & rSource) : SdrRectObj(rSdrModel, rSource) ,mpGraphicObject(new GraphicObject) -,pGraphicLink(nullptr) +,m_pGraphicLink(nullptr) { onGraphicChanged(); @@ -220,8 +220,8 @@ SdrGrafObj::SdrGrafObj(SdrModel& rSdrModel, SdrGrafObj const & rSource) // #i25616# mbSupportTextIndentingOnLineWidthChange = false; -aFileName = rSource.aFileName; -bMirrored = rSource.bMirrored; +m_aFileName = rSource.m_aFileName; +m_bMirrored = rSource.m_bMirrored; mbIsSignatureLine = rSource.mbIsSignatureLine; maSignatureLineId = rSource.maSignatureLineId; @@ -250,7 +250,7 @@ SdrGrafObj::SdrGrafObj(SdrModel& rSdrModel, SdrGrafObj const & rSource) if( rSource.IsLinkedGraphic() ) { -SetGraphicLink( aFileName ); +SetGraphicLink( m_aFileName ); } ImpSetAttrToGrafInfo(); @@ -262,8 +262,8 @@ SdrGrafObj::SdrGrafObj( const tools::Rectangle& rRect) : SdrRectObj(rSdrModel, rRect)
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | Status|NEEDINFO|NEW --- Comment #19 from Heiko Tietze --- UX input is clear: add an option for the default date/time appearance with entries mm-dd- hh:mm, -mm-dd hh:mm, dd.mm. hh/mm, etc. defaulting to what the locale defines. I suggest to put all these tweaking options in an expander so it wont be too frightening for basic users. Up to QA whether this is part of bug 46448 - Allow custom locale settings... or a separate issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | Status|NEEDINFO|NEW --- Comment #19 from Heiko Tietze --- UX input is clear: add an option for the default date/time appearance with entries mm-dd- hh:mm, -mm-dd hh:mm, dd.mm. hh/mm, etc. defaulting to what the locale defines. I suggest to put all these tweaking options in an expander so it wont be too frightening for basic users. Up to QA whether this is part of bug 46448 - Allow custom locale settings... or a separate issue. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=161441 --- Comment #7 from Heiko Tietze --- (In reply to Telesto from comment #6) > What exactly do you perceive as artificial use case? The rectangle has axial symmetry. Whether you create a rectangle with 1x5cm or 5x1cm + 90°- both look the same and I see no use case to make the difference more clear. Did you ever run into any trouble or are there any questions on ask.libreoffice, for example. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - desktop/source
desktop/source/lib/init.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit db27cd2246cfc54abd94885ce5edbdca69688af0 Author: Andras Timar AuthorDate: Fri Jun 7 10:56:45 2024 +0200 Commit: Miklos Vajna CommitDate: Mon Jun 10 09:36:35 2024 +0200 LOK: do not use deprecated .uno:BackColor Change-Id: Ieb780d278cd45bf82a2b4acee0abd17af2dc71eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168519 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index af14bae07df1..eae08a12889e 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -3719,7 +3719,6 @@ static void doc_iniUnoCommands () u".uno:AlignLeft"_ustr, u".uno:AlignHorizontalCenter"_ustr, u".uno:AlignRight"_ustr, -u".uno:BackColor"_ustr, u".uno:BackgroundColor"_ustr, u".uno:TableCellBackgroundColor"_ustr, u".uno:Bold"_ustr,
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 --- Comment #18 from Mike Kaganski --- (In reply to Heiko Tietze from comment #17) If the idea is to add this bug as another duplicate of bug 46448: please don't. Please read comment 9, and comment 16. Together, they show that this one can be implemented independently (or easier), and would satisfy a large chunk of users on its own; so closing this as "we need to fix a larger and harder issue, which will fix this, too" would miss this opportunity completely. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 --- Comment #18 from Mike Kaganski --- (In reply to Heiko Tietze from comment #17) If the idea is to add this bug as another duplicate of bug 46448: please don't. Please read comment 9, and comment 16. Together, they show that this one can be implemented independently (or easier), and would satisfy a large chunk of users on its own; so closing this as "we need to fix a larger and harder issue, which will fix this, too" would miss this opportunity completely. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161454] LET function, round-trip issue with ms sample for the function.
https://bugs.documentfoundation.org/show_bug.cgi?id=161454 --- Comment #3 from Balázs Varga (allotropia) --- Created attachment 194621 --> https://bugs.documentfoundation.org/attachment.cgi?id=194621=edit LET with array function Export -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161454] LET function, round-trip issue with ms sample for the function.
https://bugs.documentfoundation.org/show_bug.cgi?id=161454 Balázs Varga (allotropia) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Balázs Varga (allotropia) --- > https://git.libreoffice.org/core/commit/ > 5a75414d1772d1fd998f405e3b9bd80b1f10c51f So this patch only related to this issue: "Also, there is a different result involving blank cell in source data." The other one "Creating the sample in Excel (xlsx), it opens as array in Calc, but saving and opening again in Excel, doesn't work." unfortunatelly, I have no idea atm, checked the xml files and everything looked fine around the let function. Also in case of other inside array function in the LET function it is worked fine in MSO after LO export. Atteched an example document. But I saw some suspecios line in the workbook.xml which were missed from the exported file but not from the original file. May be related to this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 --- Comment #17 from Heiko Tietze --- Then I suggest to add this request too. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.
https://bugs.documentfoundation.org/show_bug.cgi?id=161377 --- Comment #17 from Heiko Tietze --- Then I suggest to add this request too. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 101258] [META] Bibliography bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101258 Heiko Tietze changed: What|Removed |Added Depends on||161252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161252 [Bug 161252] bibliography shows either number or short title in the entry not both -- You are receiving this mail because: You are the assignee for the bug.
[Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122497 Heiko Tietze changed: What|Removed |Added Depends on|161252 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161252 [Bug 161252] bibliography shows either number or short title in the entry not both -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 Heiko Tietze changed: What|Removed |Added Blocks|122497 |101258 --- Comment #4 from Heiko Tietze --- Can we make this request a duplicate of bug 157064 or some other from META bug 101258? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101258 [Bug 101258] [META] Bibliography bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=122497 [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 Heiko Tietze changed: What|Removed |Added Blocks|122497 |101258 --- Comment #4 from Heiko Tietze --- Can we make this request a duplicate of bug 157064 or some other from META bug 101258? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101258 [Bug 101258] [META] Bibliography bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=122497 [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
core.git: xmloff/source
xmloff/source/core/xmlimp.cxx | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) New commits: commit bf02c5fa586d2ff7dbfac37d3ea0a07675efc15e Author: Mike Kaganski AuthorDate: Mon Jun 10 11:08:56 2024 +0500 Commit: Mike Kaganski CommitDate: Mon Jun 10 09:16:49 2024 +0200 tdf#161488: allow failed image loading in repair mode Change-Id: I19a68f2f016b5ab95565c7fbcc4c435cf13c6b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168596 Reviewed-by: Mike Kaganski Tested-by: Jenkins diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx index b39775f0699d..016ca91dc014 100644 --- a/xmloff/source/core/xmlimp.cxx +++ b/xmloff/source/core/xmlimp.cxx @@ -1303,19 +1303,38 @@ uno::Reference SvXMLImport::loadGraphicByURL(OUString const & { uno::Reference xGraphic; -if (mxGraphicStorageHandler.is()) +try { -if (IsPackageURL(rURL)) +if (mxGraphicStorageHandler.is()) { -xGraphic = mxGraphicStorageHandler->loadGraphic(rURL); +if (IsPackageURL(rURL)) +{ +xGraphic = mxGraphicStorageHandler->loadGraphic(rURL); +} +else +{ +OUString const& rAbsoluteURL = GetAbsoluteReference(rURL); +GraphicExternalLink aExternalLink(rAbsoluteURL); +Graphic aGraphic(aExternalLink); +xGraphic = aGraphic.GetXGraphic(); +} } -else +} +catch (...) +{ +bool bRepairPackage = false; +if (auto const xStorProps{ GetSourceStorage().query() }) { -OUString const & rAbsoluteURL = GetAbsoluteReference(rURL); -GraphicExternalLink aExternalLink(rAbsoluteURL); -Graphic aGraphic(aExternalLink); -xGraphic = aGraphic.GetXGraphic(); +try +{ +xStorProps->getPropertyValue(u"RepairPackage"_ustr) >>= bRepairPackage; +} +catch (uno::Exception&) +{ +} } +if (!bRepairPackage) +throw; } return xGraphic;
[Bug 161486] LibreOffice Base keeps crashing on Debian Testing.
https://bugs.documentfoundation.org/show_bug.cgi?id=161486 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Julien Nabet --- It should be fixed from 24.2.4 Meanwhile, you can use this workaround: in a term/console, type: export SAL_USE_VCLPLUGIN=gen;soffice --base it will prevent from using gtk rendering. *** This bug has been marked as a duplicate of bug 161073 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160541] Quickfind sidebar: present results with some indication of location in document
https://bugs.documentfoundation.org/show_bug.cgi?id=160541 --- Comment #5 from Heiko Tietze --- Not a good solution. I'd prefer a horizontal ruler with a small label of the page number. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151050] [META] GTK4-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=151050 Bug 151050 depends on bug 161467, which changed state. Bug 161467 Summary: Assertion in Impress when trying to insert a table (gtk4 only) https://bugs.documentfoundation.org/show_bug.cgi?id=161467 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160541] Quickfind sidebar: present results with some indication of location in document
https://bugs.documentfoundation.org/show_bug.cgi?id=160541 --- Comment #4 from Jim Raykowski --- Maybe a simple tooltip that shows the page number of the find entry is enough? https://gerrit.libreoffice.org/c/core/+/168599/1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160538] Quickfind sidebar: ordering of results, Text in fields and frames comes first
https://bugs.documentfoundation.org/show_bug.cgi?id=160538 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/sidebar/QuickFindPanel.cxx | 208 ++-- 1 file changed, 136 insertions(+), 72 deletions(-) New commits: commit 99ed68ac1fbaf883ddc730936299bba95d9e1d6f Author: Jim Raykowski AuthorDate: Fri Jun 7 18:00:35 2024 -0800 Commit: Jim Raykowski CommitDate: Mon Jun 10 09:04:19 2024 +0200 tdf#160538 Quickfind sidebar list finds in frames and footnotes and endnotes in the order of occurance in the document Change-Id: Ifd91065ed416495084ba7f396f740daef5233c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168566 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Jim Raykowski diff --git a/sw/source/uibase/sidebar/QuickFindPanel.cxx b/sw/source/uibase/sidebar/QuickFindPanel.cxx index 176ae3ad2eab..cffca4511ef2 100644 --- a/sw/source/uibase/sidebar/QuickFindPanel.cxx +++ b/sw/source/uibase/sidebar/QuickFindPanel.cxx @@ -14,19 +14,36 @@ #include #include #include -#include #include #include -#include #include #include #include -#include -using namespace css; -using namespace std; +#include +#include const int MinimumPanelWidth = 250; +namespace +{ +void getAnchorPos(SwPosition& rPos) +{ +// get the top most anchor position of the position +if (SwFrameFormat* pFlyFormat = rPos.GetNode().GetFlyFormat()) +{ +SwNode* pAnchorNode; +SwFrameFormat* pTmp = pFlyFormat; +while (pTmp && (pAnchorNode = pTmp->GetAnchor().GetAnchorNode()) + && (pTmp = pAnchorNode->GetFlyFormat())) +{ +pFlyFormat = pTmp; +} +if (const SwPosition* pPos = pFlyFormat->GetAnchor().GetContentAnchor()) +rPos = *pPos; +} +} +} + namespace sw::sidebar { std::unique_ptr QuickFindPanel::Create(weld::Widget* pParent) @@ -149,85 +166,132 @@ void QuickFindPanel::FillSearchFindsList() comphelper::dispatchCommand(u".uno:ExecuteSearch"_ustr, aPropertyValues); -if (m_pWrtShell->HasMark()) +if (!m_pWrtShell->HasMark()) +return; + +for (SwPaM& rPaM : m_pWrtShell->GetCursor()->GetRingContainer()) { -for (SwPaM& rPaM : m_pWrtShell->GetCursor()->GetRingContainer()) -{ -SwPosition* pMarkPosition = rPaM.GetMark(); -const SwContentIndex aContentIndex = pMarkPosition->nContent; -const SwContentNode* pContentNode = aContentIndex.GetContentNode(); -const SwTextNode* pTextNode = pContentNode->GetTextNode(); -const OUString& sNodeText = pTextNode->GetText(); -auto nMarkIndex = rPaM.GetMark()->nContent.GetIndex(); -auto nPointIndex = rPaM.GetPoint()->nContent.GetIndex(); - -// determine the text node text subview start index for the list entry text -auto nStartIndex = nMarkIndex - 50; -if (nStartIndex < 0) -{ -nStartIndex = 0; -} -else +SwPosition* pMarkPosition = rPaM.GetMark(); +SwPosition* pPointPosition = rPaM.GetPoint(); +std::unique_ptr xPaM(std::make_unique(*pMarkPosition, *pPointPosition)); +m_vPaMs.push_back(std::move(xPaM)); +} + +// tdf#160538 sort finds in frames and footnotes in the order they occur in the document +const SwNodeOffset nEndOfInsertsIndex = m_pWrtShell->GetNodes().GetEndOfInserts().GetIndex(); +const SwNodeOffset nEndOfExtrasIndex = m_pWrtShell->GetNodes().GetEndOfExtras().GetIndex(); +std::stable_sort( +m_vPaMs.begin(), m_vPaMs.end(), +[, , this](const std::unique_ptr& a, +const std::unique_ptr& b) { +SwPosition aPos(*a->Start()); +SwPosition bPos(*b->Start()); +// use page number for footnotes and endnotes +if (aPos.GetNodeIndex() >= nEndOfInsertsIndex +&& bPos.GetNodeIndex() < nEndOfInsertsIndex) +return b->GetPageNum() >= a->GetPageNum(); +// use anchor position for finds that are located in flys +if (nEndOfExtrasIndex >= aPos.GetNodeIndex()) +getAnchorPos(aPos); +if (nEndOfExtrasIndex >= bPos.GetNodeIndex()) +getAnchorPos(bPos); +if (aPos == bPos) { -// tdf#160539 format search finds results also to word boundaries -sal_Unicode ch; -do +// probably in same or nested fly frame +// sort using layout position +SwRect aCharRect, bCharRect; +if (SwContentFrame* pFrame = a->GetMarkContentNode()->GetTextNode()->getLayoutFrame( +m_pWrtShell->GetLayout())) { -ch = sNodeText[nStartIndex]; -} while (++nStartIndex < nMarkIndex && ch != ' ' && ch != ' '); -if (nStartIndex < nMarkIndex) +
core.git: Branch 'distro/collabora/co-24.04' - include/svx sd/inc sd/source svx/source
include/svx/annotation/Annotation.hxx | 56 sd/inc/Annotation.hxx | 26 --- sd/source/core/annotations/Annotation.cxx | 172 ++--- sd/source/ui/annotations/annotationmanager.cxx | 21 +-- sd/source/ui/unoidl/unomodel.cxx |2 svx/source/annotation/Annotation.cxx | 130 ++ 6 files changed, 217 insertions(+), 190 deletions(-) New commits: commit ec5c4b572b1744a50c7dc94aeb472174c736069a Author: Tomaž Vajngerl AuthorDate: Thu Apr 18 22:41:04 2024 +0900 Commit: Miklos Vajna CommitDate: Mon Jun 10 09:02:47 2024 +0200 annot: move UndoAnnotation and deps. to svx, adapt svx Annotation This moves UndoAnnotation and dependent classes to svx, refactor the code to in sdr::annotaion::Annotation so annotations in sd module still work as they have before. Change-Id: I3769069a636c30c55bc1fcf2406d990f1b44baa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166493 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl (cherry picked from commit d126f57fd4bbba7ac0e4218ed30524cb9bbb5859) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168527 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/include/svx/annotation/Annotation.hxx b/include/svx/annotation/Annotation.hxx index 13881a58d070..566dd6ef52f4 100644 --- a/include/svx/annotation/Annotation.hxx +++ b/include/svx/annotation/Annotation.hxx @@ -14,10 +14,40 @@ #include #include +#include #include +class SdrUndoAction; +class SfxViewShell; + namespace sdr::annotation { +class Annotation; + +enum class CommentNotificationType +{ +Add, +Modify, +Remove +}; + +SVXCORE_DLLPUBLIC void LOKCommentNotify(CommentNotificationType nType, +const SfxViewShell* pViewShell, Annotation& rAnnotation); +SVXCORE_DLLPUBLIC void LOKCommentNotifyAll(CommentNotificationType nType, Annotation& rAnnotation); + +struct SVXCORE_DLLPUBLIC AnnotationData +{ +css::geometry::RealPoint2D m_Position; +css::geometry::RealSize2D m_Size; +OUString m_Author; +OUString m_Initials; +css::util::DateTime m_DateTime; +OUString m_Text; + +void get(Annotation& rAnnotation); +void set(Annotation& rAnnotation); +}; + class SVXCORE_DLLPUBLIC Annotation { private: @@ -33,8 +63,11 @@ protected: OUString m_Author; OUString m_Initials; css::util::DateTime m_DateTime; + bool m_bIsFreeText = false; +std::unique_ptr createUndoAnnotation(); + public: Annotation(SdrPage* pPage) : mpSdrPage(pPage) @@ -42,12 +75,35 @@ public: { } +css::geometry::RealPoint2D GetPosition() const { return m_Position; } +void SetPosition(const css::geometry::RealPoint2D& rValue) { m_Position = rValue; } + +css::geometry::RealSize2D GetSize() const { return m_Size; } +void SetSize(const css::geometry::RealSize2D& rValue) { m_Size = rValue; } + +OUString GetAuthor() const { return m_Author; } +void SetAuthor(const OUString& rValue) { m_Author = rValue; } + +OUString GetInitials() const { return m_Initials; } +void SetInitials(const OUString& rValue) { m_Initials = rValue; } + +css::util::DateTime GetDateTime() const { return m_DateTime; } +void SetDateTime(const css::util::DateTime& rValue) { m_DateTime = rValue; } + +virtual OUString GetText() = 0; +virtual void SetText(OUString const& rText) = 0; + SdrModel* GetModel() { return mpSdrPage != nullptr ? >getSdrModelFromSdrPage() : nullptr; } +SdrPage const* getPage() const { return mpSdrPage; } sal_uInt32 GetId() const { return m_nId; } + +void setIsFreeText(bool value) { m_bIsFreeText = value; } + +bool isFreeText() const { return m_bIsFreeText; } }; //typedef std::vector> AnnotationVector; diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx index 9bdbc31033f1..7d63cd54bea9 100644 --- a/sd/inc/Annotation.hxx +++ b/sd/inc/Annotation.hxx @@ -38,34 +38,19 @@ class SdrUndoAction; -namespace com::sun::star::office { -class XAnnotation; -} +namespace com::sun::star::office { class XAnnotation; } namespace com::sun::star::uno { template class Reference; } class SfxViewShell; -namespace sd { - -enum class CommentNotificationType { Add, Modify, Remove }; +namespace sd +{ void createAnnotation( rtl::Reference< Annotation >& xAnnotation, SdPage* pPage ); std::unique_ptr CreateUndoInsertOrRemoveAnnotation( const css::uno::Reference< css::office::XAnnotation >& xAnnotation, bool bInsert ); -void CreateChangeUndo(const css::uno::Reference< css::office::XAnnotation >& xAnnotation); - -sal_uInt32 getAnnotationId(const css::uno::Reference & xAnnotation); - -const SdPage* getAnnotationPage(const css::uno::Reference& xAnnotation); - -void LOKCommentNotify(CommentNotificationType nType, const SfxViewShell*
core.git: Branch 'distro/collabora/co-24.04' - include/svx sd/inc sd/source svx/Library_svxcore.mk svx/source
include/svx/annotation/Annotation.hxx | 57 ++ sd/inc/Annotation.hxx | 18 ++--- sd/source/core/annotations/Annotation.cxx | 10 + svx/Library_svxcore.mk|1 svx/source/annotation/Annotation.cxx | 18 + 5 files changed, 83 insertions(+), 21 deletions(-) New commits: commit 83b6adcd0daf935dcf9d52b4d1b791e79e274dcf Author: Tomaž Vajngerl AuthorDate: Thu Apr 18 14:54:52 2024 +0900 Commit: Miklos Vajna CommitDate: Mon Jun 10 08:51:58 2024 +0200 annot: added Annotation impl. to svx, moved some thing from sd This is an attempt to move the sd::Annotation to the common code in the svx module. This will need to be done in multiple steps so the first one is to introduce sdr::annotation::Annotation class in svx module, which is derived by sd::Annotation. Non-problematic functionality and members are also moved to the svx Annotation. Change-Id: Id20466b3780514ab63a9df8923b879098870ebb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit a938ed2be520426ce7949c4fd30a6e7e31d7c279) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168419 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/include/svx/annotation/Annotation.hxx b/include/svx/annotation/Annotation.hxx new file mode 100644 index ..13881a58d070 --- /dev/null +++ b/include/svx/annotation/Annotation.hxx @@ -0,0 +1,57 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#pragma once + +#include +#include +#include + +#include +#include + +namespace sdr::annotation +{ +class SVXCORE_DLLPUBLIC Annotation +{ +private: +static sal_uInt32 m_nLastId; +static sal_uInt32 nextID() { return m_nLastId++; } + +protected: +SdrPage* mpSdrPage; +sal_uInt32 m_nId; + +css::geometry::RealPoint2D m_Position; +css::geometry::RealSize2D m_Size; +OUString m_Author; +OUString m_Initials; +css::util::DateTime m_DateTime; +bool m_bIsFreeText = false; + +public: +Annotation(SdrPage* pPage) +: mpSdrPage(pPage) +, m_nId(nextID()) +{ +} + +SdrModel* GetModel() +{ +return mpSdrPage != nullptr ? >getSdrModelFromSdrPage() : nullptr; +} + +sal_uInt32 GetId() const { return m_nId; } +}; + +//typedef std::vector> AnnotationVector; + +} // namespace sdr::annotation + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx index c09f67703289..9bdbc31033f1 100644 --- a/sd/inc/Annotation.hxx +++ b/sd/inc/Annotation.hxx @@ -27,6 +27,7 @@ #include #include #include +#include #include "sdpage.hxx" #include "textapi.hxx" @@ -74,19 +75,16 @@ struct SD_DLLPUBLIC CustomAnnotationMarker }; class SD_DLLPUBLIC Annotation final : private ::cppu::BaseMutex, - public ::cppu::WeakComponentImplHelper, - public ::cppu::PropertySetMixin +public sdr::annotation::Annotation, +public ::cppu::WeakComponentImplHelper, +public ::cppu::PropertySetMixin { public: explicit Annotation( const css::uno::Reference& context, SdPage* pPage ); Annotation(const Annotation&) = delete; Annotation& operator=(const Annotation&) = delete; -static sal_uInt32 m_nLastId; - SdPage* GetPage() const { return mpPage; } -SdrModel* GetModel() { return (mpPage != nullptr) ? >getSdrModelFromSdrPage() : nullptr; } -sal_uInt32 GetId() const { return m_nId; } // XInterface: virtual css::uno::Any SAL_CALL queryInterface(css::uno::Type const & type) override; @@ -146,17 +144,9 @@ private: // disposed, do it here. virtual void SAL_CALL disposing() override; -sal_uInt32 m_nId; SdPage* mpPage; -css::geometry::RealPoint2D m_Position; -css::geometry::RealSize2D m_Size; -OUString m_Author; -OUString m_Initials; -css::util::DateTime m_DateTime; rtl::Reference m_TextRange; - std::unique_ptr m_pCustomAnnotationMarker; -bool m_bIsFreeText; }; } diff --git a/sd/source/core/annotations/Annotation.cxx b/sd/source/core/annotations/Annotation.cxx index 9faee9d7b701..a75669694f3b 100644 --- a/sd/source/core/annotations/Annotation.cxx +++ b/sd/source/core/annotations/Annotation.cxx @@ -115,15 +115,11 @@ void createAnnotation(rtl::Reference& xAnnotation, SdPage* pPage ) pPage->addAnnotation(xAnnotation, -1); } -sal_uInt32 Annotation::m_nLastId = 1; - Annotation::Annotation(const
[Bug 161363] Backward compatibility issue in Impress: not visible texts (white texts) and formatting issues
https://bugs.documentfoundation.org/show_bug.cgi?id=161363 Heiko Tietze changed: What|Removed |Added Severity|critical|normal --- Comment #10 from Heiko Tietze --- Lowering the importance, at least, as it affects one document only. Nothing to fix without clear STR. Back to QA... ;-) (Ultimately the modification of automatic dark/light calculation is working well and makes a lot of sense. There might be corner cases where some processing is not done properly.) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 84194] Other: Double clicking embedded PDF in Writer opens file in Writer, not in OS' PDF reader
https://bugs.documentfoundation.org/show_bug.cgi?id=84194 --- Comment #10 from JamesLowe --- https://git.libreoffice.org/core/+/7aaa9ef2e5edaf468f116449776433e98fb1a2f3%5E%21 https://geometrydash-meltdown.com Good workaround for me. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160538] Quickfind sidebar: ordering of results, Text in fields and frames comes first
https://bugs.documentfoundation.org/show_bug.cgi?id=160538 --- Comment #5 from Heiko Tietze --- Much better. The content of an anchored object comes first, which makes the search jumpy at this point. But it's reasonable and I wouldn't put too much effort in this. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - sc/source
sc/source/ui/view/gridwin.cxx | 55 ++ 1 file changed, 29 insertions(+), 26 deletions(-) New commits: commit 65fa3d18ce28c609ead1ac81c93d0fbb38ce9658 Author: Caolán McNamara AuthorDate: Fri Jun 7 12:11:22 2024 +0100 Commit: Miklos Vajna CommitDate: Mon Jun 10 08:10:04 2024 +0200 prep AutoFill menu in kit mode only Change-Id: Id533d78e1433b616ce661e855dad0d571d24cf8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168533 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index b5cd268e4cc4..85816c5636b9 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -2369,32 +2369,35 @@ void ScGridWindow::MouseButtonUp( const MouseEvent& rMEvt ) { mrViewData.GetDispatcher().Execute( FID_FILL_AUTO, SfxCallMode::SLOT | SfxCallMode::RECORD ); -// prepare AutoFill menu items for "Copy Cells" and "Fill Series" -ScTabViewShell* pViewShell = mrViewData.GetViewShell(); -boost::property_tree::ptree aMenu; -boost::property_tree::ptree aItemTree; - -aItemTree.put("text", "~Copy Cells"); -aItemTree.put("type", "command"); -aItemTree.put("command", ".uno:AutoFill?Copy:bool=true"); -aItemTree.put("enabled", "true"); -aMenu.push_back(std::make_pair("", aItemTree)); - -aItemTree.put("text", "~Fill Series"); -aItemTree.put("type", "command"); -aItemTree.put("command", ".uno:AutoFill?Copy:bool=false"); -aItemTree.put("enabled", "true"); -aMenu.push_back(std::make_pair("", aItemTree)); -aItemTree.clear(); - -boost::property_tree::ptree aRoot; -aRoot.add_child("menu", aMenu); - -std::stringstream aStream; -boost::property_tree::write_json(aStream, aRoot, true); - -pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CONTEXT_MENU, - OString(aStream.str())); +if (comphelper::LibreOfficeKit::isActive()) +{ +// prepare AutoFill menu items for "Copy Cells" and "Fill Series" +ScTabViewShell* pViewShell = mrViewData.GetViewShell(); +boost::property_tree::ptree aMenu; +boost::property_tree::ptree aItemTree; + +aItemTree.put("text", "~Copy Cells"); +aItemTree.put("type", "command"); +aItemTree.put("command", ".uno:AutoFill?Copy:bool=true"); +aItemTree.put("enabled", "true"); +aMenu.push_back(std::make_pair("", aItemTree)); + +aItemTree.put("text", "~Fill Series"); +aItemTree.put("type", "command"); +aItemTree.put("command", ".uno:AutoFill?Copy:bool=false"); +aItemTree.put("enabled", "true"); +aMenu.push_back(std::make_pair("", aItemTree)); +aItemTree.clear(); + +boost::property_tree::ptree aRoot; +aRoot.add_child("menu", aMenu); + +std::stringstream aStream; +boost::property_tree::write_json(aStream, aRoot, true); + + pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CONTEXT_MENU, + OString(aStream.str())); +} } } else if (mrViewData.GetFillMode() == ScFillMode::MATRIX)
[Bug 161488] Approving loading of a specific broken ODG package still fails
https://bugs.documentfoundation.org/show_bug.cgi?id=161488 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/168596 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161488] New: Approving loading of a specific broken ODG package still fails
https://bugs.documentfoundation.org/show_bug.cgi?id=161488 Bug ID: 161488 Summary: Approving loading of a specific broken ODG package still fails Product: LibreOffice Version: unspecified Hardware: All URL: https://ask.libreoffice.org/t/corrupted-file-cant-open -it/106693 OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Created attachment 194619 --> https://bugs.documentfoundation.org/attachment.cgi?id=194619=edit A broken document from Ask The attachment is a bugdoc from https://ask.libreoffice.org/t/corrupted-file-cant-open-it/106693. It has a problem in the ZIP headers, making three images broken. Loading it gives an expected warning: The file 'M_F_Gervais English and Scottish Monarchs.odg' is corrupt and therefore cannot be opened. LibreOffice can try to repair the file. The corruption could be the result of document manipulation or of structural document damage due to data transmission. We recommend that you do not trust the content of the repaired document. Execution of macros is disabled for this document. Should LibreOffice attempt to repair the file? Answering "Yes" tries to reload, but ends up with Read Error. Format error discovered in the file in sub-document content.xml at position 2,1605412(row,col). It should open the file properly after repairment confirmation (in a repair mode, with some images missing). It was possible in AOO and in LO prior to commit ebf767eeb2a169ba533e1b2ffccf16f41d95df35. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113108] [META] Dialog UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113108 Bug 113108 depends on bug 99528, which changed state. Bug 99528 Summary: Better handling for multiline tabs https://bugs.documentfoundation.org/show_bug.cgi?id=99528 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149496] Drag content within formula bar doesn't do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=149496 Aron Budea changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Aron Budea --- This particular case is fine in 24.8.0.0.alpha1+ (f6ea343e6fb2dc3539823dee60c9c6f96fc16275) / Ubuntu. However, these slightly modified steps still don't work properly, and they haven't worked even before the regression (eg. in 6.4 latest): - Open the attached spreadsheet, - Expand formula bar using the triangle button, - Click into the cell that has several lines of text, select a piece of it, and drag it someplace else within the formula bar, - Press Ctrl+Z. => Undo happens in the formula bar, but not within the cell. Pressing Enter finalizes the change without the undo part. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149495] [META] Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Bug 149495 depends on bug 149496, which changed state. Bug 149496 Summary: Drag content within formula bar doesn't do anything https://bugs.documentfoundation.org/show_bug.cgi?id=149496 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 149496, which changed state. Bug 149496 Summary: Drag content within formula bar doesn't do anything https://bugs.documentfoundation.org/show_bug.cgi?id=149496 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
core.git: cui/qa sw/uiconfig vcl/source
cui/qa/uitest/dialogs/shortcuts.py| 31 +++--- sw/uiconfig/swriter/ui/templatedialog2.ui |1 vcl/source/control/imivctl1.cxx |2 + 3 files changed, 15 insertions(+), 19 deletions(-) New commits: commit 30380c2f9888685ddceaafc9fb3a637e7167a3ac Author: Samuel Mehrbrodt AuthorDate: Thu Apr 25 15:10:49 2024 +0200 Commit: Samuel Mehrbrodt CommitDate: Mon Jun 10 07:13:22 2024 +0200 tdf#99528 Use vertical tabs in para dialog Change-Id: I7ec61c07f75e9a8aa124ac5b3d67c90077cca033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166625 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/cui/qa/uitest/dialogs/shortcuts.py b/cui/qa/uitest/dialogs/shortcuts.py index ac8a0a791496..947d94b910d7 100644 --- a/cui/qa/uitest/dialogs/shortcuts.py +++ b/cui/qa/uitest/dialogs/shortcuts.py @@ -13,25 +13,18 @@ from uitest.uihelper.common import get_state_as_dict class Test(UITestCase): def test_tab_navigation(self): -with self.ui_test.create_doc_in_start_center("writer"): -xWriterDoc = self.xUITest.getTopFocusWindow() - -with self.ui_test.execute_dialog_through_command(".uno:EditStyle") as xDialog: - -xTabs = xDialog.getChild("tabcontrol") -select_pos(xTabs, "0") - -for i in range(16): -self.assertEqual(get_state_as_dict(xTabs)["CurrPagePos"], str(i)) - -xTabs.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+PAGEDOWN"})) - -self.assertEqual(get_state_as_dict(xTabs)["CurrPagePos"], "0") - -for i in reversed(range(16)): -xTabs.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+PAGEUP"})) - -self.assertEqual(get_state_as_dict(xTabs)["CurrPagePos"], str(i)) +with self.ui_test.create_doc_in_start_center("writer"),\ +self.ui_test.execute_dialog_through_command(".uno:EditStyle") as xDialog: +xTabs = xDialog.getChild("tabcontrol") +select_pos(xTabs, "0") + +for i in range(16): +self.assertEqual(get_state_as_dict(xTabs)["CurrPagePos"], str(i)) +xTabs.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+PAGEDOWN"})) + +for i in reversed(range(16)): +self.assertEqual(get_state_as_dict(xTabs)["CurrPagePos"], str(i)) +xTabs.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+PAGEUP"})) diff --git a/sw/uiconfig/swriter/ui/templatedialog2.ui b/sw/uiconfig/swriter/ui/templatedialog2.ui index 97fde7653f39..ae467d56a486 100644 --- a/sw/uiconfig/swriter/ui/templatedialog2.ui +++ b/sw/uiconfig/swriter/ui/templatedialog2.ui @@ -122,6 +122,7 @@ True True True +left True True diff --git a/vcl/source/control/imivctl1.cxx b/vcl/source/control/imivctl1.cxx index dca91c7d4163..a52a8634ff4b 100644 --- a/vcl/source/control/imivctl1.cxx +++ b/vcl/source/control/imivctl1.cxx @@ -220,6 +220,8 @@ void SvxIconChoiceCtrl_Impl::RemoveEntry(size_t nPos) { pImpCursor->Clear(); maEntries.erase(maEntries.begin() + nPos); +// Recalculate list positions +nFlags &= ~IconChoiceFlags::EntryListPosValid; RecalcAllBoundingRectsSmart(); }
[Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 BogdanB changed: What|Removed |Added Depends on||159940 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159940 [Bug 159940] Searching for toolbars in "Tools > Customize" lead to results lacking name -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159940] Searching for toolbars in "Tools > Customize" lead to results lacking name
https://bugs.documentfoundation.org/show_bug.cgi?id=159940 BogdanB changed: What|Removed |Added Blocks||103238 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103238 [Bug 103238] [META] Customize dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160738] search and replace widget reset the current selection only option after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=160738 BogdanB changed: What|Removed |Added Blocks||102847 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 BogdanB changed: What|Removed |Added Depends on||160738 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160738 [Bug 160738] search and replace widget reset the current selection only option after saving -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 BogdanB changed: What|Removed |Added Depends on||161481 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161481 [Bug 161481] Date field not found when using search tool. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161481] Date field not found when using search tool.
https://bugs.documentfoundation.org/show_bug.cgi?id=161481 BogdanB changed: What|Removed |Added Blocks||102847 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152760] Insert - Text from File ... in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152760 --- Comment #5 from BogdanB --- I meet those warning before, doesn't seem connected special with this, but anyway, I get them: warn:legacy.tools:36488:36488:sfx2/source/control/bindings.cxx:1770: No cache for OfficeDispatch! warn:sfx.dialog:36488:36488:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for WordPerfect warn:sfx.dialog:36488:36488:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for writerweb8_writer_template warn:sfx.dialog:36488:36488:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for writerglobal8 Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152757] Insert - OLE Object - OLE Object... in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152757 --- Comment #5 from BogdanB --- warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family graphic with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family presentation with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family graphic with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family presentation with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family graphic with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:xmloff:35824:35824:xmloff/source/style/impastpl.cxx:362: Adding duplicate family presentation with mismatching mapper ! P25SvXMLExportPropertyMapper 28XMLShapeExportPropertyMapper warn:legacy.tools:35824:35824:sfx2/source/control/bindings.cxx:1770: No cache for OfficeDispatch! warn:legacy.tools:35824:35824:sfx2/source/control/bindings.cxx:1770: No cache for OfficeDispatch! Retested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152730] Trying to open a file from StartCenter gets some warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152730 --- Comment #5 from BogdanB --- warn:sfx.dialog:35484:35484:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for WordPerfect warn:sfx.dialog:35484:35484:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for writerweb8_writer_template warn:sfx.dialog:35484:35484:sfx2/source/dialog/filtergrouping.cxx:357: already have an element for writerglobal8 warn:vcl.gtk:35484:35484:vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:948: no parent widget set Retested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152820] Tools - Redact in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152820 --- Comment #5 from BogdanB --- warn:unotools.misc:35071:35071:unotools/source/misc/mediadescriptor.cxx:372: url: 'private:factory/sdraw' com.sun.star.ucb.ContentCreationException message: "No Content Provider available for URL: private:factory/sdraw at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/ucbhelper/source/client/content.cxx:208" eError: (com.sun.star.ucb.ContentCreationError) NO_CONTENT_PROVIDER warn:legacy.tools:35071:35071:sfx2/source/control/bindings.cxx:1770: No cache for OfficeDispatch! warn:legacy.tools:35071:35071:sfx2/source/control/bindings.cxx:1770: No cache for OfficeDispatch! warn:sd:35071:35071:sd/source/core/drawdoc2.cxx:255: Page object must not be a handout. warn:drawinglayer.emf:35071:35071:drawinglayer/source/tools/emfphelperdata.cxx:1810: EMF+TODO SetPixelOffsetMode warn:drawinglayer.emf:35071:35071:drawinglayer/source/tools/emfphelperdata.cxx:1797: EMF+TODO SetAntiAliasMode warn:drawinglayer.emf:35071:35071:drawinglayer/source/tools/emfphelperdata.cxx:1804: EMF+TODO InterpolationMode Retested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152764] Insert - Fontwork in a new document: warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152764 --- Comment #5 from BogdanB --- warn:legacy.osl:34893:34893:sfx2/source/doc/sfxbasemodel.cxx:3044: SfxBaseModel::IsInitialized: this should have been caught earlier! warn:xmloff.core:34893:34893:xmloff/source/core/xmlimp.cxx:946: DBG_UNHANDLED_EXCEPTION in setTargetDocument exception: com.sun.star.lang.NotInitializedException message: "at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/sfx2/source/doc/sfxbasemodel.cxx:3056" context: SvxUnoDrawingModel Retested with Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152816] Form - Label in a new document: warning in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152816 --- Comment #5 from BogdanB --- Retested warn:svx:34707:34707:svx/source/form/fmcontrollayout.cxx:192: DBG_UNHANDLED_EXCEPTION in lcl_initializeControlFont exception: com.sun.star.uno.RuntimeException message: "invalid attempt to assign an empty interface of type com.sun.star.style.XStyleFamiliesSupplier! at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/include/com/sun/star/uno/Reference.hxx:105" warn:svx:34707:34707:svx/source/form/formcontrolfactory.cxx:162: DBG_UNHANDLED_EXCEPTION in lcl_getUniqueLabel_nothrow exception: com.sun.star.uno.RuntimeException message: "unsatisfied query for interface of type com.sun.star.container.XIndexAccess! at /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/include/com/sun/star/uno/Reference.hxx:85" Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 152731] Opening Impress produces warnings in console with debug LO: unsatisfied query for interface of type com.sun.star.lang.XUnoTunnel
https://bugs.documentfoundation.org/show_bug.cgi?id=152731 BogdanB changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #5 from BogdanB --- NO warning in Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 6d39b1a6068bbbd5ca4947f668f989dbfb73342d CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 140879] [META] Console noise
https://bugs.documentfoundation.org/show_bug.cgi?id=140879 Bug 140879 depends on bug 152731, which changed state. Bug 152731 Summary: Opening Impress produces warnings in console with debug LO: unsatisfied query for interface of type com.sun.star.lang.XUnoTunnel https://bugs.documentfoundation.org/show_bug.cgi?id=152731 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161487] New: LibreOffice 24.2.4.2 (x86_64) takes over 40 minutes to install on Win11/x64.
https://bugs.documentfoundation.org/show_bug.cgi?id=161487 Bug ID: 161487 Summary: LibreOffice 24.2.4.2 (x86_64) takes over 40 minutes to install on Win11/x64. Product: LibreOffice Version: 24.2.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: akapu...@yahoo.co.uk Description: LibreOffice 24.2.4.2 (x86_64) takes over 40 minutes to install on Win11/x64. Steps to Reproduce: 1. Try to install LibreOffice 24.2.4.2 (x86_64) on Win11/x64. 2. Sit back and fume for over 40 minutes after answering all installation questions. 3. Feel screwed up and file a LibreOffice bug report. Actual Results: After >40 minutes the blasted think installs and seems to work. Expected Results: On Linux installation took less than 3 minutes. Debian 12.5 x64. I expect Win11 installation times to be similar. Reproducible: Always User Profile Reset: No Additional Info: Nothing that can be written down politely in a public bug board. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161252] bibliography shows either number or short title in the entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161281] Tiny floating Navigator when it is first opened (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=161281 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161242] FILEOPEN DOC Direct formatting is lost on paragraph before table
https://bugs.documentfoundation.org/show_bug.cgi?id=161242 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161274] Moving paragraphs breaks text and marks undesired changes
https://bugs.documentfoundation.org/show_bug.cgi?id=161274 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161233] FILEOPEN DOCX Through wrapped image looks cropped
https://bugs.documentfoundation.org/show_bug.cgi?id=161233 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.