New submitted patch

[Mariam Fahmy]

Hi,
I have submitted my second patch on Gerrit,
Here it is: https://gerrit.libreoffice.org/c/core/+/104461
It is about using " #pragma once" instead of guards, I am asking for
reviewers to check what I have made.
Thanks in advance.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Conflict with submitted change

[Kaganski Mike]

Hi,

On 02.02.2019 9:48, Aditya Sahu wrote:
> Hi,
> I submitted a change ( Change-Id: 
> I440c637dd2a566f820a6e8fac826f35cabb9c05f ) but after doing that, I 
> found out that it is having conflict with some other change ( Change-Id: 
> I937ed12f2a96943664087ddcdd035f1347e84a57 ).
> What should be my move here?

As discussed on IRC, that was a misunderstanding: gerrit shown "Conflict 
with:" information about a change modifying the same file (in a 
different place: [1], [2]). The changes don't actually conflict.

[1] 
https://gerrit.libreoffice.org/#/c/67102/2/svtools/source/dialogs/PlaceEditDialog.cxx
[2] 
https://gerrit.libreoffice.org/#/c/66055/11/svtools/source/dialogs/PlaceEditDialog.cxx

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Conflict with submitted change

[Aditya Sahu]

Hi,
I submitted a change ( Change-Id: I440c637dd2a566f820a6e8fac826f35cabb9c05f
) but after doing that, I found out that it is having conflict with some
other change ( Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 ).
What should be my move here?
--
Best Regards,
Aditya Sahu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Submitted patch builds "Aborted by user anonymous"

[Muhammet Kara]

Hi Brian,

You can trigger a new build by rebasing your change, by using the button 
("Rebase") on gerrit.


Best,
Muhammet

On 09/27/2018 06:28 PM, Brian Fraser wrote:

Hello,

I submitted a patch to gerrit a week ago which shows the MacOS and 
Linux (clang) builds as "Aborted by user anonymous":

https://gerrit.libreoffice.org/#/c/60707/

How can I trigger a restart of the build so that the patch can be code 
reviewed?


Thank you,
Brian.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Submitted patch builds "Aborted by user anonymous"

[Brian Fraser]

Hello,

I submitted a patch to gerrit a week ago which shows the MacOS and Linux
(clang) builds as "Aborted by user anonymous":
https://gerrit.libreoffice.org/#/c/60707/

How can I trigger a restart of the build so that the patch can be code
reviewed?

Thank you,
Brian.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 64037] gerrit "patch submitted" mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64037

Dennis Roczek  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||dennisroc...@gmail.com
 Resolution|--- |MOVED

--- Comment #5 from Dennis Roczek  ---
ticket moved to redmine, see https://redmine.documentfoundation.org/issues/1549

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Submitted patch for SwHTMLParser::AppendTextNode

[Matteo Casalin]

Hi everybody,
in SwHTMLParser::AppendTextNode I noticed some code that claimed to 
repair an improper handling of script-dependent hints, but was suspiciously 
mixing end positions of plain, CTL and CJK attributes. I submitted a patch:

https://gerrit.libreoffice.org/16169

that restores (in a more verbose and explicit way) the original behaviour. It 
was verified by Jenkins but I have no clue on how to test it. I would 
appreciate if somebody with a deeper knoweledge of that code could have a look 
at it and provide some feedback.

Thanks in advance and kind regards
Matteo
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64037

--- Comment #4 from Joel Madero jmadero@gmail.com ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

   Test to see if the bug is still present on a currently supported version of
LibreOffice (4.4.2 or later)
   https://www.libreoffice.org/download/

   If the bug is present, please leave a comment that includes the version of
LibreOffice and your operating system, and any changes you see in the bug
behavior

 If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a short comment that includes your version of
LibreOffice and Operating System

Please DO NOT

   Update the version field
   Reply via email (please reply directly on the bug tracker)
   Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so: 1. Download and install oldest version of LibreOffice
(usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug 3. Leave a comment with your results. 4a. If the bug was
present with 3.3 - set version to inherited from OOo; 4b. If the bug was not
present in 3.3 - add regression to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2015-05-02

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

redline eating up table cell divider when exported to .doc - tentative fix submitted to gerrit

[Justin Luth]

I have submitted a fix (https://gerrit.libreoffice.org/#/c/15340/) that
requires someone knowledgeable with redline and .doc exporting to review.

The marker used in Word to identify table cell division was being
included in the track-changes deletion from the following cell if
the deletion was the first node in the cell.  This would cause the
two table cells to merge into one when changes were accepted by
Word.  (Problem not seen in LibreOffice itself, only in Word.)

I don't understand this code - I just figured out something that fixed
my problem and tried to make it as targeted as possible. I'm not really
sure of the implications - it just didn't seem to do anything bad to my
sample document The biggest problem is that this is called at the
end of EVERY cell, regardless of whether it is touching a redline. I
couldn't figure out how to recognize when that occurs. So the
possibility of introducing a regression is fairly high...  Several
testcases are attached to the bug report.  It is super easy to reproduce
the problem.  Simply open the testcase in LibreOffice and save.  Then in
MSWord, accept all of the tracked changes.

Thanks,
Justin


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64037

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||qu...@runcibility.com
 Ever confirmed|0   |1

--- Comment #1 from Qubit qu...@runcibility.com ---
(In reply to comment #0)
 The I have submitted a patch automatic mail from gerrit currently contains:
 
 
  To pull it, you can do:
 
 git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3615/1
 
 
 Please make that:
 
 
  To pull it, you can do:
 
 git pull git://gerrit.libreoffice.org/core refs/changes/15/3615/1
 
 
 So that this command-line works anywhere, anytime, not only when one has
 properly setup ssh authentication to gerrit on the currently used machine.
 (My personal case is that I usually have not introduced my crypto smartcard
 for authentication.)

Lionel - Is this still a problem? I find a few gerrit emails from last
September that mention an ssh:// url, but perhaps the problem has been fixed
between then and now?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64037

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Qubit qu...@runcibility.com ---
Let's do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64037

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Lionel Elie Mamane lio...@mamane.lu ---
(In reply to comment #1)

 Lionel - Is this still a problem?

Yes, it is.

 I find a few gerrit emails from last
 September (...) perhaps the problem has been fixed
 between then and now?

No, it has not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64037] New: gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64037

  Priority: medium
Bug ID: 64037
CC: bjoern.michael...@canonical.com, d.ostrov...@gmx.de,
nthieb...@gmail.com, r.ein...@documentfoundation.org,
webs...@global.libreoffice.org
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: gerrit patch submitted mail: please quote pull
command-line with anonymous git URL
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: lio...@mamane.lu
  Hardware: Other
Status: UNCONFIRMED
   Version: 3.5.7.2 release
 Component: WWW
   Product: LibreOffice

The I have submitted a patch automatic mail from gerrit currently contains:


 To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3615/1


Please make that:


 To pull it, you can do:

git pull git://gerrit.libreoffice.org/core refs/changes/15/3615/1


So that this command-line works anywhere, anytime, not only when one has
properly setup ssh authentication to gerrit on the currently used machine. (My
personal case is that I usually have not introduced my crypto smartcard for
authentication.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64037

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

Version|3.5.7.2 release |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Michael Stahl]

On 08/03/13 09:55, Markus Mohrhard wrote:
 On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote:

 The import for files written by gnumeric should map the values to the
 corresponding ODF values and during export we only want to export them
 as ODF and never into the gnumeric namespace. This also means to

 OK. I thought that it would be nice for somebody that wrote the file with
 Gnumeric not to silently convert it to something that might not be read back
 the same in Gnumeric. That's why I added all these GNM_* values. But I can
 understand your POV.

the problem is that an attribute can have only one value, and it's far
better in the long run to write the value that is in a current ODF draft
than the value that will only be understood by Gnumeric.

 remove all the references to the GNM_* values in the other source
 files. For that to correctly work we need to register the gnumeric
 namespace and map the elements in the chart namespace and the elements
 in the gnumeric namesapce to the same UNO attributes.

 Could you explain this a bit more. Are we talking about the XML namespace or
 the C++ namespace ? I see some references in the code related to Gnumeric
 and a link with orcus.
 
 We are talking about XML namespaces. The gnumeric elements with gnm
 prefix are in an gnumeric namespace. The other links you see to
 gnumeric code is in calc and orcus for the gnumeric import which is
 only a proof of concept right now.

you have fallen into the same trap as i have 2 weeks ago: the gnm:
prefix is part of the value, not any attribute or element name, and thus
no namespace needs to be declared to support it.

 into the gnumeric namespace. Additionally we need to take care of the
 ODF version during export and make sure we only export it into ODF1.2
 extended. I think Thorsten was fine with exporting the elements into
 the chart namespace but only for ODF 1.2 extended.

 First a general question. I found the option for selecting the ODF type. But
 how does that work when somebody requires, e.g., strict ODF1.2 or lower
 compliance. Is there a warning given when the file is written ? Do we hide
 the option for stepped lines then ?
 
 We warn the user that choosing anything except ODF 1.2 extended may
 loose data but we don't hide anything in the UI. We just drop the
 elements during export.

in the latter Sun days there were plans to query the ODF version from
the configuration in the UI and only allow inserting those content
elements that are supported by the selected ODF version.  i can't
remember if anything was ever implemented for that, but in general it
would be a good idea.  (except it would not be worth the effort for 1.1
because there is just too much missing there; it was only intended for
post-ODF 1.2 features).

 Secondly, can you point to an example where the above is done ? Then I can
 implement something similar.
 
 Sadly this one is a bit tricky. Normally the magic happens in how we
 specify the attribute values in the map but for this one I need to
 explore it a bit more.

some maps have an additional element to store the required version which
is then checked on export but apparently this one does not (yet).

for example there is a MAP_ENTRY_ODF_EXT macro in that
PropertyMap.hxx... oh actually that applies to entire attributes while
here we want to only handle certain values of the attribute differently...

i guess it needs some special handling then, there is some flag
MID_FLAG_SPECIAL_ITEM_EXPORT which causes a call to the
handleSpecialItem() method, which can then mangle the attribute in
arbitrary ways, so you can use it to generate appropriate fall-back
values for older ODF versions.

also, your changes to xmloff/source/transform/StyleOASISTContext.cxx
seem a bit pointless to me: source/transform is for the OpenOffice.org
XML format, which is a predecessor of ODF and a legacy format and
usually does not get new features added :)  well i guess nobody will
complain about some different values there.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Markus Mohrhard]

Hey Eric,


 On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote:

 First we need to move the new values in CurveStyle.idl to the end and

 remove all the GNM_* values. Moving the values to the end ensures that

 the old values stay unchanged which causes as little trouble for

 extension developers using the API as possible.



 OK. I wasn't aware that the last value there was not a sentinel but needed
 to remain the same.

It is always better to leave existing values to make it easier for
potential external users of the API.


 The import for files written by gnumeric should map the values to the

 corresponding ODF values and during export we only want to export them

 as ODF and never into the gnumeric namespace. This also means to



 OK. I thought that it would be nice for somebody that wrote the file with
 Gnumeric not to silently convert it to something that might not be read back
 the same in Gnumeric. That's why I added all these GNM_* values. But I can
 understand your POV.



 remove all the references to the GNM_* values in the other source

 files. For that to correctly work we need to register the gnumeric

 namespace and map the elements in the chart namespace and the elements

 in the gnumeric namesapce to the same UNO attributes.



 Could you explain this a bit more. Are we talking about the XML namespace or
 the C++ namespace ? I see some references in the code related to Gnumeric
 and a link with orcus.

We are talking about XML namespaces. The gnumeric elements with gnm
prefix are in an gnumeric namespace. The other links you see to
gnumeric code is in calc and orcus for the gnumeric import which is
only a proof of concept right now.

So the right way is to register the namespace. An exmaple for such a
change is 
(http://cgit.freedesktop.org/libreoffice/core/commit/?id=f18a242966d3fd25ec0832c09ce7164bdae7ba2d
) where I added a namespace for calc ODF1.2 extended elements. You
need to do something similar for gnumeric with the
http://www.gnumeric.org/odf-extension/1.0 URL. It makes sense to use
GNM or something like that as namespace alias in our code as this is
more or less the official gnumeric namespace prefix.


 into the gnumeric namespace. Additionally we need to take care of the

 ODF version during export and make sure we only export it into ODF1.2

 extended. I think Thorsten was fine with exporting the elements into

 the chart namespace but only for ODF 1.2 extended.



 First a general question. I found the option for selecting the ODF type. But
 how does that work when somebody requires, e.g., strict ODF1.2 or lower
 compliance. Is there a warning given when the file is written ? Do we hide
 the option for stepped lines then ?

We warn the user that choosing anything except ODF 1.2 extended may
loose data but we don't hide anything in the UI. We just drop the
elements during export.


 Secondly, can you point to an example where the above is done ? Then I can
 implement something similar.

Sadly this one is a bit tricky. Normally the magic happens in how we
specify the attribute values in the map but for this one I need to
explore it a bit more.

 Additionally it would be nice if you would provide at least one of

 your test documents from gnumeric and one of your test documents for

 normal ODF as MPL/LGPL licensed test documents that we can add to our

 test file repository. If you are interested it would also be nice if

 you could add a test case for it to our new chart2 import test at

 chart2/qa/extras/chart2import.cxx.



 There is a Gnumeric file attached to the bugzilla. I hereby place it under
 MPL/LGPL. Once I'm further, I will also add a similar file created fully in
 LO.

Thanks I'll add it to the test file repository at
http://cgit.freedesktop.org/libreoffice/contrib/test-files/



 I'll have a look at the test cases and what is done there.

Basically what we do there is just import a document and check through
the UNO API that the feature we are interested in is correctly
imported. So in your case it just means that we need to have a test
document with all the stepped line featiures that you want to test.
The easiest way is to have just one chart per sheet and then use the
existing code to get the chart and the data series and just test for
your property. However if you have problems with it I can add the
test.




 For the UI part of the task it

 might make sense to first convert the relevant dialog to the new UI

 format and then add the new elements into it.



 As indicated in the UI ML, I will use a seperate dialog. As for getting up
 to speed with Glade, I was thinking about converting the existing dialog for
 the spline option first. Then, I know better how to create a new one.

Great. Thanks.



 But first I'll amend the existing patch with the code changes you requested
 above. Once those are accepted I'll tackle the UI.


Regards,
Markus
___
LibreOffice mailing list

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Eric Seynaeve]

Hello Markus,

thanks for your review. 

On Wednesday 06 March 2013 17:00:56 Markus Mohrhard wrote:
 First we need to move the new values in CurveStyle.idl to the end and
 remove all the GNM_* values. Moving the values to the end ensures that
 the old values stay unchanged which causes as little trouble for
 extension developers using the API as possible.

OK. I wasn't aware that the last value there was not a sentinel but needed to 
remain the same.
 
 The import for files written by gnumeric should map the values to the
 corresponding ODF values and during export we only want to export them
 as ODF and never into the gnumeric namespace. This also means to

OK. I thought that it would be nice for somebody that wrote the file with 
Gnumeric not to silently convert it to something that might not be read back 
the same in Gnumeric. That's why I added all these GNM_* values. But I can 
understand your POV.

 remove all the references to the GNM_* values in the other source
 files. For that to correctly work we need to register the gnumeric
 namespace and map the elements in the chart namespace and the elements
 in the gnumeric namesapce to the same UNO attributes.

Could you explain this a bit more. Are we talking about the XML namespace or 
the C++ namespace ? I see some references in the code related to Gnumeric and 
a link with orcus.

 into the gnumeric namespace. Additionally we need to take care of the
 ODF version during export and make sure we only export it into ODF1.2
 extended. I think Thorsten was fine with exporting the elements into
 the chart namespace but only for ODF 1.2 extended.

First a general question. I found the option for selecting the ODF type. But 
how does that work when somebody requires, e.g., strict ODF1.2 or lower 
compliance. Is there a warning given when the file is written ? Do we hide the 
option for stepped lines then ?

Secondly, can you point to an example where the above is done ? Then I can 
implement something similar.
 
 Additionally it would be nice if you would provide at least one of
 your test documents from gnumeric and one of your test documents for
 normal ODF as MPL/LGPL licensed test documents that we can add to our
 test file repository. If you are interested it would also be nice if
 you could add a test case for it to our new chart2 import test at
 chart2/qa/extras/chart2import.cxx.

There is a Gnumeric file attached to the bugzilla. I hereby place it under 
MPL/LGPL. Once I'm further, I will also add a similar file created fully in 
LO.

I'll have a look at the test cases and what is done there.

 Thanks a lot for your great work. It is highly appreciated and feel
 free to ask for any help you need. 

:-)

 For the UI part of the task it
 might make sense to first convert the relevant dialog to the new UI
 format and then add the new elements into it.

As indicated in the UI ML, I will use a seperate dialog. As for getting up to 
speed with Glade, I was thinking about converting the existing dialog for the 
spline option first. Then, I know better how to create a new one.

But first I'll amend the existing patch with the code changes you requested 
above. Once those are accepted I'll tackle the UI.

 Regards,
 Markus

Thanks,

Eric___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Markus Mohrhard]

Hey Eric,



 I have added my first real code for submission to LO :-) It's in gerrit:
 https://gerrit.libreoffice.org/2476.

 I'm going to review it in the next days.


so here is the inital review for your change. Your patch looks already
quite good but there are some small changes necessary before we can
merge it.

First we need to move the new values in CurveStyle.idl to the end and
remove all the GNM_* values. Moving the values to the end ensures that
the old values stay unchanged which causes as little trouble for
extension developers using the API as possible.

The import for files written by gnumeric should map the values to the
corresponding ODF values and during export we only want to export them
as ODF and never into the gnumeric namespace. This also means to
remove all the references to the GNM_* values in the other source
files. For that to correctly work we need to register the gnumeric
namespace and map the elements in the chart namespace and the elements
in the gnumeric namesapce to the same UNO attributes.
Your current export code is producing invalid xml files because you
were exporting the gnumeric values without registering the namespace.
However this problem should be gone once we no longer export elements
into the gnumeric namespace. Additionally we need to take care of the
ODF version during export and make sure we only export it into ODF1.2
extended. I think Thorsten was fine with exporting the elements into
the chart namespace but only for ODF 1.2 extended.

The code in AreaChart.cxx looks mostly good and I will have a final
look at it when all the other problems are fixed.

Additionally it would be nice if you would provide at least one of
your test documents from gnumeric and one of your test documents for
normal ODF as MPL/LGPL licensed test documents that we can add to our
test file repository. If you are interested it would also be nice if
you could add a test case for it to our new chart2 import test at
chart2/qa/extras/chart2import.cxx.

Please let me know if I should help you with any of the above tasks. I
can take care of them if neccesary.

Thanks a lot for your great work. It is highly appreciated and feel
free to ask for any help you need. For the UI part of the task it
might make sense to first convert the relevant dialog to the new UI
format and then add the new elements into it.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Markus Mohrhard]

  Anyway, I will now create a mock for the UI and discuss this on the UI

  list. Once this is done, what would be the best way to add the new UI

  functionality ? A friendly push in the right direction would save me
  quite

  some time ;-)



 You should design the dialogs nowadays with Glade. We are switching

 from our old dialog descriptions to new glade xml files. Caolan wrote

 a nice wiki page about widgetllayout

 (https://wiki.documentfoundation.org/Development/WidgetLayout). While

 it focuses mostly on transfering old dialogs to the new format it

 should give you a basic idea how to create a new one. If you need one

 of the custom widgets that we have somewhere in the code or other

 customization of an existing widget we can help you implement that.



 I'm with you on new Dialogs. I could convert the existing dialog
 (ChartTypeDialog?) to glade, but it seems a bit ambitious at the moment for
 my knowledge in LO. Maybe later after getting more experience with simpler
 dialogs. I saw Caolan's talk on FOSDEM and it seemed not too difficult for
 the simpler dialogs.


Well i think it belongs maybe in the Smooth lines dialog with a new
title for the dialog which seems reasonable easy to convert. I think
Caolan's tutorial will give you all the information you need for it.
If you sill have questions about it you can just ask and we will help
you with the task. An inital step would be to design the dialog in
glade and send it to the ML. Caolan or I can take care of the source
code part if necessary.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Eric Seynaeve]

Hello Markus,

  I also want to add some debug code in what I have done, mainly to print a
  warning if new curve types are fed to LO. What's the best way to do that ?
  From
  https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Contro
  lling_Debug_Code I would think to add the code in #ifdef SAL_LOG_WARN or
  use the SAL_WARN macro.
 
 You should use SAL_WARN and SAL_INFO for these tasks. Additionally we
 are using more and more assert if we really want an abort for a
 special condition. THere is also SAL_WARN_IF and SAL_INFO_IF for
 conditional debug statements.

Thanks for the pointers. Looks like SAL_WARN_IF is what I want. I have amended 
the patch with this already.

  Anyway, I will now create a mock for the UI and discuss this on the UI
  list. Once this is done, what would be the best way to add the new UI
  functionality ? A friendly push in the right direction would save me quite
  some time ;-)
 
 You should design the dialogs nowadays with Glade. We are switching
 from our old dialog descriptions to new glade xml files. Caolan wrote
 a nice wiki page about widgetllayout
 (https://wiki.documentfoundation.org/Development/WidgetLayout). While
 it focuses mostly on transfering old dialogs to the new format it
 should give you a basic idea how to create a new one. If you need one
 of the custom widgets that we have somewhere in the code or other
 customization of an existing widget we can help you implement that.

I'm with you on new Dialogs. I could convert the existing dialog 
(ChartTypeDialog?) to glade, but it seems a bit ambitious at the moment for my 
knowledge in LO. Maybe later after getting more experience with simpler 
dialogs. I saw Caolan's talk on FOSDEM and it seemed not too difficult for the 
simpler dialogs.

Eric___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Markus Mohrhard]

Hey Eric,



 I have added my first real code for submission to LO :-) It's in gerrit:
 https://gerrit.libreoffice.org/2476.

I'm going to review it in the next days.

 I looked on the LO website to find some pointers around in the code, but
 didn't really found it. My main helpers were OpenGrok and gdb. Did I miss a
 nice overview of where to find which functionality ?

No. There is no real documentation. As you already discovered xmloff/
contains the ODF import and export code for charts and chart2 the
whole implementation for the chart code. Additionally oox/ contains
the OOXML import and export code for charts.


 Secondly, what would you recommend as a primer on the C++ functionalities
 used in LO code + how they are used ? I didn't do that advanced C++ coding
 before that I know a lot about templates and namespaces.

It very much depends on your knowledge.


 I also want to add some debug code in what I have done, mainly to print a
 warning if new curve types are fed to LO. What's the best way to do that ?
 From
 https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Controlling_Debug_Code
 I would think to add the code in #ifdef SAL_LOG_WARN or use the SAL_WARN
 macro.

You should use SAL_WARN and SAL_INFO for these tasks. Additionally we
are using more and more assert if we really want an abort for a
special condition. THere is also SAL_WARN_IF and SAL_INFO_IF for
conditional debug statements.

 Anyway, I will now create a mock for the UI and discuss this on the UI list.
 Once this is done, what would be the best way to add the new UI
 functionality ? A friendly push in the right direction would save me quite
 some time ;-)

You should design the dialogs nowadays with Glade. We are switching
from our old dialog descriptions to new glade xml files. Caolan wrote
a nice wiki page about widgetllayout
(https://wiki.documentfoundation.org/Development/WidgetLayout). While
it focuses mostly on transfering old dialogs to the new format it
should give you a basic idea how to create a new one. If you need one
of the custom widgets that we have somewhere in the code or other
customization of an existing widget we can help you implement that.

Thanks a lot for your great work on this feature.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

[Eric Seynaeve]

Hello everyone,

I have added my first real code for submission to LO :-) It's in gerrit: 
https://gerrit.libreoffice.org/2476.

It took me a while to find my way around the code and also to get used to the 
new possibilities in C++.

I looked on the LO website to find some pointers around in the code, but 
didn't really found it. My main helpers were OpenGrok and gdb. Did I miss a 
nice overview of where to find which functionality ?

Secondly, what would you recommend as a primer on the C++ functionalities used 
in LO code + how they are used ? I didn't do that advanced C++ coding before 
that I know a lot about templates and namespaces.

I also want to add some debug code in what I have done, mainly to print a 
warning if new curve types are fed to LO. What's the best way to do that ? 
From 
https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Controlling_Debug_Code
 
I would think to add the code in #ifdef SAL_LOG_WARN or use the SAL_WARN 
macro.

Anyway, I will now create a mock for the UI and discuss this on the UI list. 
Once this is done, what would be the best way to add the new UI functionality 
? A friendly push in the right direction would save me quite some time ;-)

Thanks,

Eric___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 59197] New Locale Data for Sidama Language Submitted

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=59197

Eike Rathke er...@redhat.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59197] New: New Locale Data for Sidama Language Submitted

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=59197

  Priority: medium
Bug ID: 59197
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: New Locale Data for Sidama Language Submitted
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: milky...@gmail.com
  Hardware: Other
Status: UNCONFIRMED
   Version: unspecified
 Component: Localization
   Product: LibreOffice

Created attachment 72782
  -- https://bugs.freedesktop.org/attachment.cgi?id=72782action=edit
Locale Data for Sidama Language

As we are working on Sidama Language, I have generated the locale which is
attached here. Please make it part of the build system for us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

RE: how to change submitted (but not pushed) patches in gerrit when necessary?

[Winfried Donkers]

Hi Norbert,

 This is how I do it:
 [...]
 Norbert

Thank you as well, it gives me a nice suggestion to cope with multiple patches 
at the same time being worked on!

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

how to change submitted (but not pushed) patches in gerrit when necessary?

[Winfried Donkers]

Hi all,

I submitted a patch to gerrit with logerrit. The reviewer had some comments 
which need alteration of the patch.
But how to 'resubmit' this changed patch once that is ready?
All I can find on this area is to use git push [...], but I can't/won't push. 
My patches need to be reviewed by sane persons before they are pushed :)



Winfried

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: how to change submitted (but not pushed) patches in gerrit when necessary?

[Christophe JAILLET]

Le 23/11/2012 08:06, Winfried Donkers a écrit :


Hi all,

I submitted a patch to gerrit with logerrit. The reviewer had some 
comments which need alteration of the patch.


But how to 'resubmit' this changed patch once that is ready?

All I can find on this area is to use git push […], but I can't/won't 
push. My patches need to be reviewed by sane persons before they are 
pushed :)


Winfried



See 'Create a patch revision' on 
'http://wiki.documentfoundation.org/Development/gerrit'
Basically, you just have to set the correct Change-ID:..|. and submit it 
again.


Do not forget to enter the same comment to your commit because your 
updated one will overwrite the previous one.


Best regards.
CJ
|||

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: how to change submitted (but not pushed) patches in gerrit when necessary?

[Winfried Donkers]

Hi Christophe,

  But how to 'resubmit' this changed patch once that is ready?
 See 'Create a patch revision' on
 'http://wiki.documentfoundation.org/Development/gerrit'
 Basically, you just have to set the correct Change-ID:..|. and submit it 
 again.
 
 Do not forget to enter the same comment to your commit because your
 updated one will overwrite the previous one.

Thank you very much!

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: how to change submitted (but not pushed) patches in gerrit when necessary?

[Norbert Thiebaud]

On Fri, Nov 23, 2012 at 1:06 AM, Winfried Donkers
w.donk...@dci-electronics.nl wrote:
 Hi all,



 I submitted a patch to gerrit with logerrit. The reviewer had some comments
 which need alteration of the patch.

 But how to 'resubmit' this changed patch once that is ready?

 All I can find on this area is to use git push […], but I can't/won't push.
 My patches need to be reviewed by sane persons before they are pushed :)


This is how I do it:

When I work, I frist create a branch out of a point in master
(preferably a oen that build nicely :-) )
so nwo I'm on branch 'foo' for example.

I code my patch, then I submity it to gerrit via

git push origin foo:refs/for/master

then I checkout out master again... and keep going...


When the review comes and modification to my patch are needed, I
checkout out the branch foo again...
the I make the modifications and 'amend' the commit (which _is_ the
commit I pushed to gerrit)
and then push it again using the same command.

rince and repeat until the patch is ready...

then I let gerrit cherry pick it on top of master.. if ok, then I can
delete the foo branch locally

if the cherry pick failed because of a conflict... I fetch ./g fetch
and then rebase foo : git rebase origin/master (while being on the foo branch)
since the cherry pick from gerrit failed, that rebase should exibit
some conflict, with I resolve using git mergetool

then one can re-push the patch to gerrit, again using the same command
as above.. rince and repeat until the cherry pick from gerrit works

If one has commit right, then the last phase can be dealt by bringing
the patch to master locally and simply pushing to master

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] ==== SUBMITTED ====

[Enrico Weigelt, metux IT service (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1079

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/1079/1

 SUBMITTED 

Change-Id: Ia47e4b1959d9c8fdb8f6b0a82038c7ddee3b938b
---
0 files changed, 0 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1079
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia47e4b1959d9c8fdb8f6b0a82038c7ddee3b938b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Enrico Weigelt, metux IT service metuxitserv...@googlemail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] ==== SUBMITTED ====

[Enrico Weigelt]

 I have submitted a patch for review:
 
 https://gerrit.libreoffice.org/1079
 
 To pull it, you can do:
 
 git pull ssh://gerrit.libreoffice.org:29418/core
 refs/changes/79/1079/1
 
  SUBMITTED 
 
 Change-Id: Ia47e4b1959d9c8fdb8f6b0a82038c7ddee3b938b
 ---
 0 files changed, 0 insertions(+), 0 deletions(-)

sorry, that was an accident ;-o
can I drop it from gerrit somehow ?


cu
-- 
Mit freundlichen Grüßen / Kind regards 

Enrico Weigelt 
VNC - Virtual Network Consult GmbH 
Head Of Development 

Pariser Platz 4a, D-10117 Berlin
Tel.: +49 (30) 3464615-20
Fax: +49 (30) 3464615-59

enrico.weig...@vnc.biz; www.vnc.de 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] ==== SUBMITTED ====

[Eike Rathke]

Hi Enrico,

On Thursday, 2012-11-15 14:08:27 +0100, Enrico Weigelt wrote:

  https://gerrit.libreoffice.org/1079
 
 sorry, that was an accident ;-o
 can I drop it from gerrit somehow ?

Sure, login to gerrit, pick your change and click the Abandon Change
button in the patch set.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack


pgpa8YPE2mRjF.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] ==== SUBMITTED ====

[Norbert Thiebaud]

On Thu, Nov 15, 2012 at 7:08 AM, Enrico Weigelt enrico.weig...@vnc.biz wrote:

 sorry, that was an accident ;-o
 can I drop it from gerrit somehow ?

yes. as the author you can:

go in gerrit, on that patch's page, and click 'Abandon Change'  (next
ot the 'Review' button)

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

==== SUBMITTED ====

[Enrico Weigelt, metux IT service (via Code Review)]

Enrico Weigelt, metux IT service has abandoned this change.

Change subject:   SUBMITTED 
..


Patch Set 1: Abandoned

accidentially pushed a local hacking branch ;-o

--
To view, visit https://gerrit.libreoffice.org/1079
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia47e4b1959d9c8fdb8f6b0a82038c7ddee3b938b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Enrico Weigelt, metux IT service metuxitserv...@googlemail.com
Gerrit-Reviewer: Christian Lohmaier lohmaier+libreoff...@googlemail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice