Re: [ANN] --disable-orcus

2013-09-23 Thread Khaled Hosny
On Thu, Sep 19, 2013 at 11:33:38AM -0400, Kohei Yoshida wrote:
 On Thu, 2013-09-19 at 17:23 +0200, Stephan Bergmann wrote:
 
  But is it intentional that with 
  http://cgit.freedesktop.org/libreoffice/core/commit/?id=02346aa4663055e1adf7c52ede89871a493f4513
   
  Add the configure bits to support --disable-orcus's
  
   AC_MSG_CHECKING([whether to enable orcus])
   if test $_os != Darwin -a $_os != Android -a $_os != iOS -a \( -z 
   $enable_orcus -o $enable_orcus != no \); then
  
  an explicit --enable-orcus on e.g. Mac OS X is now silently ignored 
  completely?
 
 Not intentional.  I just copied whatever the graphite option was doing,
 so it's possible that it's broken on OS X.

Since Graphite is disabled on Mac, this shouldn't be surprising.

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [ANN] --disable-orcus

2013-09-22 Thread Kohei Yoshida
On Thu, 2013-09-19 at 17:23 +0200, Stephan Bergmann wrote:

 But is it intentional that with 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=02346aa4663055e1adf7c52ede89871a493f4513
  
 Add the configure bits to support --disable-orcus's
 
  AC_MSG_CHECKING([whether to enable orcus])
  if test $_os != Darwin -a $_os != Android -a $_os != iOS -a \( -z 
  $enable_orcus -o $enable_orcus != no \); then
 
 an explicit --enable-orcus on e.g. Mac OS X is now silently ignored 
 completely?

Not intentional.  I just copied whatever the graphite option was doing,
so it's possible that it's broken on OS X.

Kohei

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [ANN] --disable-orcus

2013-09-20 Thread Stephan Bergmann

On 09/19/2013 05:23 PM, Stephan Bergmann wrote:

On 09/19/2013 04:42 AM, Kohei Yoshida wrote:

You can now set

--disable-orcus

at configure script to disable building the orcus library.  In case you
have difficulty building liborcus and can't find any solution at all,
you now have a solution.

Orcus is now disabled by default on Cygwin, OS X, and iOS and Android
build.  Those who need functionality provided by orcus can always
re-enable it by setting --enable-orcus to the configure script.


But is it intentional that with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=02346aa4663055e1adf7c52ede89871a493f4513
Add the configure bits to support --disable-orcus's


AC_MSG_CHECKING([whether to enable orcus])
if test $_os != Darwin -a $_os != Android -a $_os != iOS -a \( -z
$enable_orcus -o $enable_orcus != no \); then


an explicit --enable-orcus on e.g. Mac OS X is now silently ignored
completely?


...and sorry for being a pest, but even after 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fed96abcb593925ab4fd39e3938632a54b37ee8b 
No need to by default avoid liborcus for Android, iOS and OS X Windows 
builds will now default to --disable-orcus where in the past they 
included that functionality, so unless our release builders explicitly 
--enable-orcus (and I do not find that in distro-configs/) we will have 
a regression in the TDF Windows LO 4.2 installation sets, right?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [ANN] --disable-orcus

2013-09-20 Thread Kohei Yoshida
Hi Stephan,

On Fri, 2013-09-20 at 09:07 +0200, Stephan Bergmann wrote:

 ...and sorry for being a pest, but even after 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=fed96abcb593925ab4fd39e3938632a54b37ee8b
  
 No need to by default avoid liborcus for Android, iOS and OS X Windows 
 builds will now default to --disable-orcus where in the past they 
 included that functionality, so unless our release builders explicitly 
 --enable-orcus (and I do not find that in distro-configs/) we will have 
 a regression in the TDF Windows LO 4.2 installation sets, right?

That's true.  Well, let's enable it by default on Windows as well.
That's probably for the best.

And we will instruct those who have build issues with orcus, to use
--disable-orcus should that ever happen.

Thanks for pointing that out.

Kohei


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [ANN] --disable-orcus

2013-09-19 Thread Stephan Bergmann

On 09/19/2013 04:42 AM, Kohei Yoshida wrote:

You can now set

--disable-orcus

at configure script to disable building the orcus library.  In case you
have difficulty building liborcus and can't find any solution at all,
you now have a solution.

Orcus is now disabled by default on Cygwin, OS X, and iOS and Android
build.  Those who need functionality provided by orcus can always
re-enable it by setting --enable-orcus to the configure script.


But is it intentional that with 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=02346aa4663055e1adf7c52ede89871a493f4513 
Add the configure bits to support --disable-orcus's



AC_MSG_CHECKING([whether to enable orcus])
if test $_os != Darwin -a $_os != Android -a $_os != iOS -a \( -z $enable_orcus -o 
$enable_orcus != no \); then


an explicit --enable-orcus on e.g. Mac OS X is now silently ignored 
completely?


Stephan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ANN] --disable-orcus

2013-09-18 Thread Kohei Yoshida
You can now set

--disable-orcus

at configure script to disable building the orcus library.  In case you
have difficulty building liborcus and can't find any solution at all,
you now have a solution.

Orcus is now disabled by default on Cygwin, OS X, and iOS and Android
build.  Those who need functionality provided by orcus can always
re-enable it by setting --enable-orcus to the configure script.

Enjoy!

Kohei

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice