[ANN] gerrit maildrop ready for testing
Hi, the gerrit maildrop is ready for early beta testing. To upload a patch to master, attach your git-format-patch patch and send a mail with a subject starting with '[PATCH]' to: ger...@libreoffice.org You patch should then be commited to master for review and you should get a reply about it. If you want to upload a patch for another branch have the word 'branch' followed by the target branch in the subject. Example: [PATCH] heal the world for branch libreoffice-3-6 If you want to cherry-pick a commit (to a release-branch), start the subject with '[CHERRYPICK]' and have to word 'commit' followed by the SHA to pick in the subject: [CHERRYPICK] commit 8ec791316c1d90b25e85c94ad105e9cc62e568e2 for branch libreoffice-3-5 Additional words in the subject line and the body are ignored. Please test vicously with your next patches, so the rough edges can be fixed before we subject this on the general public. The code lives at: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/patchpickup;h=cd5f3f95514fc219e20b5a88e8e0810b7b293034;hb=HEAD patches are most welcome (best via gerrit). Best, Bjoern P.S.: Known issues: - currently only the core repo is a valid target - cherry-pick doesnt rewrite the change-id, thus something reviewed on master cant yet be cherry-pick with this yet ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
Hi Bjoern,
On 10.08.2012 12:55, Bjoern Michaelsen wrote:
the gerrit maildrop is ready for early beta testing.
Great!!
If you want to upload a patch for another branch have the word
'branch' followed by the target branch in the subject. Example:
[PATCH] heal the world for branch libreoffice-3-6
and what will happen if the branch word is inside a commit message?
raise Exception('%s does not look like a legal branch to me.' %
self.branch) ?
Isn't this better:
[PATCH 3-6] heal the world
Best regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
On 10.08.2012 14:13, Ivan Timofeev wrote:
If you want to upload a patch for another branch have the word
'branch' followed by the target branch in the subject. Example:
[PATCH] heal the world for branch libreoffice-3-6
and what will happen if the branch word is inside a commit message?
raise Exception('%s does not look like a legal branch to me.' %
self.branch) ?
Agrh, please ignore this nonsense, I am raving. It will pick the last
occurrence of course.
Sorry,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
On 08/10/2012 10:55 AM, Bjoern Michaelsen wrote: the gerrit maildrop is ready for early beta testing. To upload a patch to master, attach your git-format-patch patch and send a mail with a subject starting with '[PATCH]' to: ...starting with '[PATCH]' but apparently also required to not contain branch XXX -- can't we use an information encoding that is less ambiguous and error prone? Stephan ger...@libreoffice.org You patch should then be commited to master for review and you should get a reply about it. If you want to upload a patch for another branch have the word 'branch' followed by the target branch in the subject. Example: [PATCH] heal the world for branch libreoffice-3-6 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
On Fri, Aug 10, 2012 at 02:13:15PM +0400, Ivan Timofeev wrote:
and what will happen if the branch word is inside a commit message?
raise Exception('%s does not look like a legal branch to me.' %
self.branch) ?
Nothing. The commit message is ignored when deciding where to go with the
commit. ONLY the subject is used for deciding on what to do with the mail.
Otherwise you would indeed have unfortunate restrictions on the commit message.
Best,
Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
On Fri, Aug 10, 2012 at 01:07:13PM +0200, Stephan Bergmann wrote: On 08/10/2012 10:55 AM, Bjoern Michaelsen wrote: the gerrit maildrop is ready for early beta testing. To upload a patch to master, attach your git-format-patch patch and send a mail with a subject starting with '[PATCH]' to: ...starting with '[PATCH]' but apparently also required to not contain branch XXX -- can't we use an information encoding that is less ambiguous and error prone? I dont quit get what you are aiming for. Note that the email subject has little to do with the commit message in your attached git format-patch-generated patch. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
Hi Bjoern, On 10.08.2012 12:55, Bjoern Michaelsen wrote: The code lives at: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/patchpickup;h=cd5f3f95514fc219e20b5a88e8e0810b7b293034;hb=HEAD patches are most welcome (best via gerrit). 24 desturl = 'shh://logerrit/core' shh - ssh, could you correct that yourself please? Thanks, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] gerrit maildrop ready for testing
On Fri, Aug 10, 2012 at 06:56:14PM +0400, Ivan Timofeev wrote: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/patchpickup;h=cd5f3f95514fc219e20b5a88e8e0810b7b293034;hb=HEAD 24 desturl = 'shh://logerrit/core' shh - ssh, could you correct that yourself please? done. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
