[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 Shreyansh changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gandhish...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #13 from Michael Stahl --- Comment on attachment 78635 --> https://bugs.freedesktop.org/attachment.cgi?id=78635 Removes duplicate code from sc/source/ui/view/output2.cxx patch found integrated as ca8b63523885c89c694799622c319260346b00f6 setting "obsolete" flag so it does not show up in bugzilla queries. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 Michael Stahl changed: What|Removed |Added Attachment #78635|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #11 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #12 from Thomas Arnhold --- Those are nearly identical, too: oox/source/export/ColorPropertySet.cxx xmloff/source/chart/ColorPropertySet.cxx oox/source/export/ColorPropertySet.hxx xmloff/source/chart/ColorPropertySet.hxx -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #15 from Peter Senna Tschudin --- Created attachment 100719 --> https://bugs.freedesktop.org/attachment.cgi?id=100719&action=edit Clones found with CCFinderX I found code clones using CCFinderX(https://github.com/petersenna/ccfinderx-core). I was looking for big blocks of code, so I used the options: $ ./ccfx/ccfx d cpp -k- -w f+g+ -b 500 -t 20 -d /var/tmp/libreoffice/core What should I do next? Are you interested in clones that are smaller blocks of code? Are those clones the kind of issue this bug is about? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #16 from Thomas Arnhold --- Peter, this sounds promising. But all files inside workdir/ and instdir/ are just files which are used and generated at compile time. You can omit all of them. The */qa/* dirs could also be omitted, those are testing code, which is generally a kind of copy and paste. The results for sc/source/core/opencl/op_financial.cxx look good. Yeah, maybe you have to search for smaller chunks. Is there any option to output the results as html report, like cppcheck does (sorry, I didn't look into CCFinderX)? If yes, we could easily upload the reports and fill an EasyHack, so new developers can solve those issues. You could fix them, too, if you like :) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #17 from Peter Senna Tschudin --- Created attachment 100734 --> https://bugs.freedesktop.org/attachment.cgi?id=100734&action=edit Code clones found with CCFinderX Code clones found with CCFinderX without compile time additional source code, and without */qa/* directories. This was generated for detecting smaller chunks. The command line: $ ./ccfx/ccfx d cpp -k- -b 250 -t 20 -d /tmp/core/ @thomas-l...@arnhold.org I think it is not difficult to generate html from xml. I'm detecting the clones exactly to find something to fix. Which ones should I start with? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 Thomas Arnhold changed: What|Removed |Added Attachment #100719|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 --- Comment #18 from Thomas Arnhold --- Peter, here are some promising examples: clone ids 8831, 8589 and 8468 look like candidates to split them out inside a helper function. Looks like searching for clones which are inside different files is a good starting point. Here are some examples how to fix copy and paste code: 288f0029c69ab0532165877637a146f774d5e740 and http://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=copypasta -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 Pruthvi changed: What|Removed |Added Status|NEW |NEEDINFO CC||preethamro...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39593] copy/paste code detector / fixing
https://bugs.freedesktop.org/show_bug.cgi?id=39593 bfoman changed: What|Removed |Added Status|NEEDINFO|NEW CC||bfo.bugm...@spamgourmet.com --- Comment #14 from bfoman --- Back to NEW as changing of the status is unclear and I don't see any request in comments for additional information. @gandhish...@gmail.com: you are the current Assignee - are you working on it? If not please reset to default Assignee. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
