[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|high...@gmail.com   |sheikha...@gmail.com

--- Comment #15 from Michael Stahl  ---
looks like Sheikha fixed this one, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

--- Comment #13 from Commit Notification 
 ---
Sheikha AL-Hinai committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eafb1ebf74c3caf8fbecdc6a4fc7037c3c8f4964

tdf#39631: Add optimisation helpers

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

--- Comment #14 from Commit Notification 
 ---
Michael Meeks committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e75406e54c57fc3113d4f1983249eb2aec0a3bcd

tdf#39631 - branch hints: comment, and tweak variously, also use.

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

--- Comment #11 from sheikha  ---

I add SAL_LIKELY, SAL_UNLIKELY ,SAL_HOT, SAL_COLD pair of macro in sal/types.h
,
before that I add 
 _SAL_BOOLEAN_EXPR which is an alternative way  of using __builtin_expect which
is good for implicit conversion to bool, because __builtin_expect 
cause a compilation error it cannot convert  to long int.

see here the patch

http://ci.libreoffice.org/job/lo_gerrit_master/9846/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39631

--- Comment #12 from jan iversen  ---
you point at the ci build job not the patch.

the patch is
https://gerrit.libreoffice.org/#/c/21070

I have added it to my review list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #8 from Stephan Bergmann sberg...@redhat.com ---
(In reply to comment #7)
 I just dug throught he commit log for glib =) I'd be inclined to simply
 re-use G_LIKELY and G_UNLIKELY with a SAL prefix myself.

That _G_BOOLEAN_EXPR trick would work.  An alternative would be to restrict
this to C++ and instead stick an explicit conversion to bool into the
__builtin_expect call.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #9 from Michael Meeks michael.me...@collabora.com ---
As you like; we have less and less C these days I guess, and IIRC we compile it
as C++ (?) =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #6 from Stephan Bergmann sberg...@redhat.com ---
also note that GCC __builtin_expect (with its first parameter being of type
long) is plain, simple, and generally does not work as one would naively hope:

 class C {
 private:
 struct S;
 typedef void (S::* B)();
 public:
 operator B();
 };
 int f(C c) {
 if (c) {
 if (__builtin_expect(c, 1)) {
 return 1;
 } else {
 return 2;
 }
 } else {
 return 3;
 }
 }

will cause a compilation error cannot convert ‘C’ to ‘long int’ for argument
‘1’ to ‘long int __builtin_expect(long int, long int)’

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #7 from Michael Meeks michael.me...@collabora.com ---
I guess it might be worth talking to the glib developers; gmacros.h has a
reasonably workable version - however the _G_BOOLEAN_EXPR stuff is not the
ultimate in beauty =) The implementation in glib is all written by:

Matthias Clasen matthi...@src.gnome.org

I just dug throught he commit log for glib =) I'd be inclined to simply re-use
G_LIKELY and G_UNLIKELY with a SAL prefix myself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

Stephan Bergmann sberg...@redhat.com changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #5 from Stephan Bergmann sberg...@redhat.com ---
(In reply to comment #3)
 That header sal/inc/sal/macros.h these days lives in include/sal/macros.h.
 
 BTW, there never was sal/inc/sal/macros.hxx.  It was always
 sal/inc/sal/macros.h.

...and such platform-dependent SAL_LIKELY functionality would more naturally
fit into sal/types.h than sal/macros.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #3 from Kohei Yoshida libreoff...@kohei.us ---
That header sal/inc/sal/macros.h these days lives in include/sal/macros.h.

BTW, there never was sal/inc/sal/macros.hxx.  It was always
sal/inc/sal/macros.h.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

Michal Strnad high...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |high...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #4 from Michal Strnad high...@gmail.com ---
I am working on this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

--- Comment #3 from Kohei Yoshida libreoff...@kohei.us ---
That header sal/inc/sal/macros.h these days lives in include/sal/macros.h.

BTW, there never was sal/inc/sal/macros.hxx.  It was always
sal/inc/sal/macros.h.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

Michal Strnad high...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |high...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #2 from Björn Michaelsen bjoern.michael...@canonical.com ---
adding LibreOffice developer list as CC to unresolved EasyHacks for better
visibility.

see e.g.
http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for
details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 39631] add optimisation helpers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=39631

Florian Reisinger reisi...@gmail.com changed:

   What|Removed |Added

Summary|[EasyHack] add optimisation |add optimisation helpers
   |helpers |

--- Comment #1 from Florian Reisinger reisi...@gmail.com 2012-05-18 09:06:44 
PDT ---
Deteted Easyhack from summary

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs