[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Kohei Yoshida changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #17 from Kohei Yoshida --- I'll mark this fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug |target:4.4.0 target:4.3.3 |target:4.4.0 target:4.3.3 ||target:4.2.7 --- Comment #16 from Commit Notification --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8cdb25a38530319e0b08d97d2706ff019797fe08&h=libreoffice-4-2 fdo#53920 Switch back tab at RefButton closure time It will be available in LibreOffice 4.2.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug |target:4.4.0|target:4.4.0 target:4.3.3 --- Comment #15 from Commit Notification --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to "libreoffice-4-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=50eac342603ca08d808f53dc9a32bb9d1dfba372&h=libreoffice-4-3 fdo#53920 Switch back tab at RefButton closure time It will be available in LibreOffice 4.3.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Commit Notification changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp SkillDebug |SkillCpp SkillDebug ||target:4.4.0 --- Comment #14 from Commit Notification --- Laurent Balland-Poirier committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=31432c4469e7e0d05516143533d6b5e0b411dda3 fdo#53920 Switch back tab at RefButton closure time The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Laurent BP changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #13 from Laurent BP --- I tried to debug what is happening at closure time after OK click. in sc/source/ui/view/cellsh2.cxx:928 pTabViewShell->SetValidation( aData ); should copy ValidationData to all selected cells. But in sc/source/ui/view/viewfunc.cxx:1092 function ScViewFunc::ApplySelectionPattern( creates aFuncMark with ScMarkData aFuncMark( rViewData.GetMarkData() ); aFuncMark.bMarked should be true but is set to false if visible tab is not where selected cells are (in debugger, forcing it to true avoid the bug). I tried to force to apply tab modification after sc/source/ui/view/cellsh2.cxx#851 pTabViewShell->SetTabNo( nTab ); with pTabViewShell->PaintExtras(); but it has no effect. So I propose to avoid the bug by just switching back tab earlier: at RefButton shrink box closure. In commit 11560, https://gerrit.libreoffice.org/#/c/11660/ I propose to: - switching back tab in ScTPValidationValue::RefInputDonePostHdl - remove unnecessary switch back tab in cellsh2.cxx -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Laurent BP changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #12 from Laurent BP --- Hi, The bug seems to come from the fact that visible tab is not the initial tab. Some easy workarounds: - don't use the picker: - either use a named reference (as mentioned previously) - or type the reference - after using the picker, click on tab where the cells to be validated are - apply twice Data > Validity: second time the dialog is pre-filled, you just need to click on OK It is quite strange because after executing dialog, tab is forced to go back to initial one. See http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh2.cxx#849 849 short nResult = pDlg->Execute(); 850 //When picking Cell Range, other Tab may be switched. Need restore the correct tab 851 pTabViewShell->SetTabNo( nTab ); nTab value is correct. Why it is not enough? What else can be done? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Michael Stahl changed: What|Removed |Added Attachment #66064|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #11 from Joel Madero --- also don't forget that you can jump into the dev IRC channel or email the list to get help :) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #10 from Markus Mohrhard --- (In reply to comment #9) > I would like to attempt this, but I am new to LibreOffice and want to have a > better understanding of the code base before assigning this to myself. Can > anyone offer some pointers on getting started? so most of the calc specific code is inside sc/ sc is split into 3 parts: sc/source/core contain mostly the model sc/source/filter containing mostly the calc specific parts of the filters sc/source/ui containing the ui related code + some other non model parts ScValidationData is the main class for the validation feature. Cell ranges are represented by ScAddress a single cell address ScRange a continuous cell range ScRangeList a list of ScRange ScMarkData also able to contain multi-selection Please ask more detailed question if you need more details. You can use opengrok.libreoffice.org for browsing the Libreoffice source code. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 --- Comment #9 from Doug Naphas --- I would like to attempt this, but I am new to LibreOffice and want to have a better understanding of the code base before assigning this to myself. Can anyone offer some pointers on getting started? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 53920] EDITING: Data Validity Cell Range not being applied to multiple selected cells
https://bugs.freedesktop.org/show_bug.cgi?id=53920 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #8 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
