Re: [Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
HI Read the comments and the code pointers. we have made a wiki to help new developers: https://wiki.documentfoundation.org/Development/GetInvolved Look forward to see your patch. rgds jan i. Sent from my iPad, please excuse any misspellings > On 13 Feb 2016, at 15:39, bugzilla-dae...@bugs.documentfoundation.org wrote: > > Comment # 14 on bug 55410 from Pranav Ganorkar > I want to work on this bugany leads on how to proceed further ? > You are receiving this mail because: > You are on the CC list for the bug. > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 --- Comment #14 from Pranav Ganorkar --- I want to work on this bugany leads on how to proceed further ? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 --- Comment #12 from Stephan Bergmann --- See createInstance in shell/source/backends/desktopbe/desktopbackend.cxx. The code you modified in Default::getPropertyValue would only get used on Linux if your desktop environment did not match one of the more specific overrides of the desktop backend (for GNOME/KDE/KDE4). -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410
--- Comment #11 from Brent Ritzema ---
Okay so I went onto linux to see if my code would even work first.. And I ended
up changing my code to this:
if ( PropertyName == "givenname")
{
return css::uno::makeAny(OUString("brent"));
}
After I deleted the user directory. I then recompiled the shell, officecfg, and
postprocess (last two just to be safe). Then when I ran the program the value
was still not there. Is there any reason that maybe the system got discontinued
somewhere else in the code or am I missing something? Because based off this,
if it is requesting the value and will fill in the space with the value given,
this should work and show this value.
Any more help is appreciated and has been greatly appreciated thus far (Thanks
Caolána and Stephan) :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 --- Comment #10 from Stephan Bergmann --- The desktopbe library is currently only built on Linux, see the start of shell/Module_shell.mk: > $(eval $(call gb_Module_add_targets,shell,\ > $(if $(filter-out MACOSX WNT,$(OS)),Library_desktopbe) \ > Library_localebe \ > )) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410
--- Comment #9 from Brent Ritzema ---
Alright well I made that change to UserProfile.xcu... However it still is not
working. Maybe I am doing something wrong in desktopbackend.cxx? Here is what I
did just as a quick test:
css::uno::Any Default::getPropertyValue(OUString const & PropertyName)
throw (
css::beans::UnknownPropertyException,
css::lang::WrappedTargetException,
css::uno::RuntimeException, std::exception)
{
//Added these next 5 lines
if ( PropertyName == "givenname")
{
css::uno::Any value = "brent";
return css::uno::makeAny(value);
}
if ( PropertyName == "EnableATToolSupport" ||
PropertyName == "ExternalMailer" ||
PropertyName == "SourceViewFontHeight" ||
PropertyName == "SourceViewFontName" ||
PropertyName == "TemplatePathVariable" ||
PropertyName == "WorkPathVariable" ||
PropertyName == "ooInetFTPProxyName" ||
PropertyName == "ooInetFTPProxyPort" ||
PropertyName == "ooInetHTTPProxyName" ||
PropertyName == "ooInetHTTPProxyPort" ||
PropertyName == "ooInetHTTPSProxyName" ||
PropertyName == "ooInetHTTPSProxyPort" ||
PropertyName == "ooInetNoProxy" ||
PropertyName == "ooInetProxyType" ||
PropertyName == "givenname" ||
PropertyName == "sn" )
{
return css::uno::makeAny(css::beans::Optional< css::uno::Any >());
}
throw css::beans::UnknownPropertyException(
PropertyName, static_cast< cppu::OWeakObject * >(this));
}
When I go to the options my name still does not appear (I did delete the user
directory every time).
Any more help is appreciated :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 Stephan Bergmann changed: What|Removed |Added Status|NEEDINFO|NEW CC||sberg...@redhat.com --- Comment #8 from Stephan Bergmann --- (In reply to ritztro from comment #6) > Currently I am trying to set the value manually in desktopbackend.cxx. I am > doing this by returning the value "brent" in the Default::getPropertyValue > function. Since the officecfg/registry/data/org/openoffice/UserProfile.xcu > has this: > >oor:external="com.sun.star.configuration.backend.DesktopBackend givenname"/> > The install:module="unixdesktop" attribute means that this oor:external value will only be used on Unix (Linux), not on Windows. Something like > diff --git a/officecfg/Configuration_officecfg.mk > b/officecfg/Configuration_officecfg.mk > index 7e2af03..b7e8625 100644 > --- a/officecfg/Configuration_officecfg.mk > +++ b/officecfg/Configuration_officecfg.mk > @@ -69,6 +69,7 @@ $(eval $(call > gb_Configuration_add_spool_modules,registry,officecfg/registry/dat > org/openoffice/Setup-reportbuilder.xcu \ > org/openoffice/Setup-start.xcu \ > org/openoffice/UserProfile-unixdesktop.xcu \ > + org/openoffice/UserProfile-unxwnt.xcu \ > org/openoffice/VCL-gconflockdown.xcu \ > org/openoffice/VCL-unixdesktop.xcu \ > org/openoffice/Office/Accelerators-macosx.xcu \ > diff --git a/officecfg/registry/data/org/openoffice/UserProfile.xcu > b/officecfg/registry/data/org/openoffice/UserProfile.xcu > index b41756a..c206366 100644 > --- a/officecfg/registry/data/org/openoffice/UserProfile.xcu > +++ b/officecfg/registry/data/org/openoffice/UserProfile.xcu > @@ -20,7 +20,7 @@ > http://openoffice.org/2001/registry"; > xmlns:install="http://openoffice.org/2004/installation"; > xmlns:xs="http://www.w3.org/2001/XMLSchema"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; oor:name="UserProfile" > oor:package="org.openoffice"> > > > - oor:external="com.sun.star.configuration.backend.DesktopBackend givenname"/> > + oor:external="com.sun.star.configuration.backend.DesktopBackend givenname"/> > > > oor:external="com.sun.star.configuration.backend.DesktopBackend sn"/> > diff --git a/postprocess/CustomTarget_registry.mk > b/postprocess/CustomTarget_registry.mk > index a568832..f10c18b 100644 > --- a/postprocess/CustomTarget_registry.mk > +++ b/postprocess/CustomTarget_registry.mk > @@ -312,6 +312,7 @@ postprocess_FILES_main += \ > $(postprocess_MOD)/org/openoffice/Office/Paths-unixdesktop.xcu \ > $(postprocess_MOD)/org/openoffice/Office/Paths-unxwnt.xcu \ > $(postprocess_MOD)/org/openoffice/UserProfile-unixdesktop.xcu \ > + $(postprocess_MOD)/org/openoffice/UserProfile-unxwnt.xcu \ > $(postprocess_MOD)/org/openoffice/VCL-unixdesktop.xcu > # Inet-unixdesktop.xcu must come after Inet.xcu > # VCL-unixdesktop.xcu must come after VCL.xcu > @@ -322,6 +323,7 @@ postprocess_FILES_main += \ > $(postprocess_MOD)/org/openoffice/Office/Accelerators-unxwnt.xcu \ > $(postprocess_MOD)/org/openoffice/Office/Common-wnt.xcu \ > $(postprocess_MOD)/org/openoffice/Office/Paths-unxwnt.xcu \ > + $(postprocess_MOD)/org/openoffice/UserProfile-unxwnt.xcu \ > $(postprocess_MOD)/org/openoffice/ucb/Configuration-win.xcu > # Inet-wnt.xcu must come after Inet.xcu > postprocess_DRIVERS += ado (and rebuilding at least officecfg and postprocess) should make your changes work. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 --- Comment #7 from Caolán McNamara --- This is probably only called on first-start so rm -rf instdir/user and restart LibreOffice should retrigger "first-start" -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 ritztro changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from ritztro --- I am attempting to add the default entry in on windows, however I am having trouble with this. Main affected file: shell/source/backends/desktopbe/desktopbackend.cxx Currently I am trying to set the value manually in desktopbackend.cxx. I am doing this by returning the value "brent" in the Default::getPropertyValue function. Since the officecfg/registry/data/org/openoffice/UserProfile.xcu has this: I figured that it would call getPropertyValue to get the "givenname" value. Since it would call getPropertyValue, the function should return "brent". This would then automatically fill in the tools->options->user data name value correct? However it does not seem to fill it in. Oh and before I did this I recompiled the shell, officecfg, and postprocess modules (shell contained the backend) so that these changes may take affect. Then I ran LibreOffice. I was wondering if this was because the program no longer checks for default values using the UserProfile.xcu file or if there was another reason. Either way the value is not appearing within the box. Should I try re-making the whole program instead of just the few affected modules? Am I missing something? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.documentfoundation.org/show_bug.cgi?id=55410 --- Comment #5 from Harpreet Bansal --- I think GetUserNameEx should do the trick for windows https://msdn.microsoft.com/en-us/library/ms724435%28VS.85%29.aspx -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.freedesktop.org/show_bug.cgi?id=55410 --- Comment #4 from Tor Lillqvist --- That SHGetUserDisplayName() seems to be undocumented, so we definitely should *not* use that. Which is what Urmas meant, I guess. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.freedesktop.org/show_bug.cgi?id=55410 Qubit changed: What|Removed |Added Whiteboard|EasyHack, |EasyHack DifficultyBeginner |DifficultyBeginner, |SkillCpp |SkillCpp| CC||qu...@runcibility.com --- Comment #3 from Qubit --- Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 55410] on windows automatically fill in the default user's name into tools->options->user data
https://bugs.freedesktop.org/show_bug.cgi?id=55410 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #2 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
