[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7081

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Hardware|Other   |All
 CC||stephane.guillou@libreoffic
   ||e.org
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
Reproduced in libreoffice-4.3.7.1 but it has been fixed since at least
libreoffice-4.4.0.0.beta1.
Tested back then with inserting a page background from the Background gallery,
but can be tested in a recent trunk build with the Bullet gallery.
Files are included in the file's Picture directory instead of being linked.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9a0c97de95688b2f86bbb4dd8c823af5442401c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Couldn't find the fixing commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Hossein  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 Whiteboard|target:4.2.0|target:4.2.0
   |Confirmed:4.2.0.0.beta1:Ubu |Confirmed:4.2.0.0.beta1:Ubu
   |ntu |ntu
   |Confirmed:4.2.0.0.alpha0+:U |Confirmed:4.2.0.0.alpha0+:U
   |nknown  |nknown reviewed:2022

--- Comment #18 from Hossein  ---
(In reply to Regina Henschel from comment #17)
> It is not really solved. Follow up bug report is bug 127322.
> Test it in Writer with a Gallery theme, that has images.
You are right. I am reopening the issue.
For testing, "Gallery" > "Bullets" can be used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Hossein  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

--- Comment #16 from Hossein  ---
Created attachment 181288
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181288=edit
An ODT file with a custom background

I am using LibreOffice 7.3 Writer.

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I no longer see "background" tab when opening "Gallery", which is now available
from the sidebar. The menu option for "Gallery" is currently in:

Insert > Media > Gallery

On the other hand, it is possible to set a custom background using this method:

https://ask.libreoffice.org/t/writer-custom-background-size-image-as-page-background-unwanted-images-are-not-deleted/44138/6

Styles > Default Page Style > (Right click) > Modify > Area > Image

When I save the file as ODT, I see these in styles.xml:

...

...


The jpeg file is stored in the Pictures folder. It means that the files is now
embedded in the document.

Thus, I consider this issue fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7322

--- Comment #17 from Regina Henschel  ---
It is not really solved. Follow up bug report is bug 127322.
Test it in Writer with a Gallery theme, that has images.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

jan iversen  changed:

   What|Removed |Added

 CC|libreoffice@lists.freedeskt |
   |op.org  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

--- Comment #15 from jan iversen  ---
(In reply to Xisco Faulí from comment #14)
> @Jan: it sounds like an easyhack. isn't it?
it sure is, and a good one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp,
   ||topicCleanup
 CC||j...@documentfoundation.org
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #14 from Xisco Faulí  ---
@Jan: it sounds like an easyhack. isn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

--- Comment #15 from jan iversen  ---
(In reply to Xisco Faulí from comment #14)
> @Jan: it sounds like an easyhack. isn't it?
it sure is, and a good one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67274

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp,
   ||topicCleanup
 CC||j...@documentfoundation.org
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #14 from Xisco Faulí  ---
@Jan: it sounds like an easyhack. isn't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   Severity|normal  |enhancement
   Priority|highest |medium
 CC||jmadero@gmail.com
 Blocks|60270   |

--- Comment #13 from Joel Madero jmadero@gmail.com ---
Removing from MAB - this is an enhancement and does not belong on mab list.
Marking as enhancement also. The product works as designed, the request is just
to change the design which by definition is an enhancement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   Severity|normal  |enhancement
   Priority|highest |medium
 CC||jmadero@gmail.com
 Blocks|60270   |

--- Comment #13 from Joel Madero jmadero@gmail.com ---
Removing from MAB - this is an enhancement and does not belong on mab list.
Marking as enhancement also. The product works as designed, the request is just
to change the design which by definition is an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it

--- Comment #12 from tommy27 ba...@quipo.it ---
if issue is still present in 4.2.x current releases please move it to the
mab4.2 list (Bug 65675) since 4.1.x is END OF LIFE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

tommy27 ba...@quipo.it changed:

   What|Removed |Added

 CC||ba...@quipo.it

--- Comment #12 from tommy27 ba...@quipo.it ---
if issue is still present in 4.2.x current releases please move it to the
mab4.2 list (Bug 65675) since 4.1.x is END OF LIFE

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

--- Comment #11 from chtfn stephane.guil...@gmail.com ---
Moving to mab4.1 (Bug 60270) because:
- 4.0 reached EOL (End Of Life)
- bug confirmed in later version

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

chtfn stephane.guil...@gmail.com changed:

   What|Removed |Added

 Blocks|54157   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

chtfn stephane.guil...@gmail.com changed:

   What|Removed |Added

 Blocks||60270

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

--- Comment #11 from chtfn stephane.guil...@gmail.com ---
Moving to mab4.1 (Bug 60270) because:
- 4.0 reached EOL (End Of Life)
- bug confirmed in later version

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

chtfn stephane.guil...@gmail.com changed:

   What|Removed |Added

 Blocks|54157   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

chtfn stephane.guil...@gmail.com changed:

   What|Removed |Added

 Blocks||60270

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

   Priority|medium  |highest

--- Comment #10 from Björn Michaelsen bjoern.michael...@canonical.com ---
(This is an automated message.)

Setting priority to highest as this is a 4.0 MAB. This is part of an effort to
make the importance of MAB reflected in priority too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Björn Michaelsen bjoern.michael...@canonical.com changed:

   What|Removed |Added

   Priority|medium  |highest

--- Comment #10 from Björn Michaelsen bjoern.michael...@canonical.com ---
(This is an automated message.)

Setting priority to highest as this is a 4.0 MAB. This is part of an effort to
make the importance of MAB reflected in priority too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Christian Lohmaier lohma...@gmx.de changed:

   What|Removed |Added

 CC||lohma...@gmx.de

--- Comment #9 from Christian Lohmaier lohma...@gmx.de ---
not a MAB in my opionion.. 
* has always been that way for decades, 
* graphic as page backgrounds are not a very common usecase
* easy workaround/manual fix (Goto Format|Page → Background and uncheck [ ]
Link)

Not saying that this shouldn't be fixed, but that's not so important to have
for 4.2.0 (4.2.x is enough IMHO)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Blocks|65675   |54157

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Christian Lohmaier lohma...@gmx.de changed:

   What|Removed |Added

 CC||lohma...@gmx.de

--- Comment #9 from Christian Lohmaier lohma...@gmx.de ---
not a MAB in my opionion.. 
* has always been that way for decades, 
* graphic as page backgrounds are not a very common usecase
* easy workaround/manual fix (Goto Format|Page → Background and uncheck [ ]
Link)

Not saying that this shouldn't be fixed, but that's not so important to have
for 4.2.0 (4.2.x is enough IMHO)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Michael Meeks michael.me...@collabora.com changed:

   What|Removed |Added

 Blocks|65675   |54157

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Whiteboard|target:4.2.0|target:4.2.0
   ||Confirmed:4.2.0.0.beta1:Ubu
   ||ntu
   ||Confirmed:4.2.0.0.alpha0+:U
   ||nknown
 CC||qu...@runcibility.com

--- Comment #8 from Qubit qu...@runcibility.com ---
CONFIRMED on LO 4.2.0.0.beta1 + Ubuntu 12.04.3

REPRO:
- Open LibreOffice
- Tools - Gallery - Backgrounds
- Right-click on aqua (first background in list) and choose: Insert as
Background - Page
- Right-click on the changed page background and select 'Page'
- Select 'Background' tab
- Under the 'File' section, the 'Link' checkbox is checked, and the filepath
listed below the 'Browse' button is to a file in 'share/gallery' on disk.

EXPECTED:
- The background would be embedded in the file.
- The 'Link' checkbox would be unchecked

Adding repro information to whiteboard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Qubit qu...@runcibility.com changed:

   What|Removed |Added

 Whiteboard|target:4.2.0|target:4.2.0
   ||Confirmed:4.2.0.0.beta1:Ubu
   ||ntu
   ||Confirmed:4.2.0.0.alpha0+:U
   ||nknown
 CC||qu...@runcibility.com

--- Comment #8 from Qubit qu...@runcibility.com ---
CONFIRMED on LO 4.2.0.0.beta1 + Ubuntu 12.04.3

REPRO:
- Open LibreOffice
- Tools - Gallery - Backgrounds
- Right-click on aqua (first background in list) and choose: Insert as
Background - Page
- Right-click on the changed page background and select 'Page'
- Select 'Background' tab
- Under the 'File' section, the 'Link' checkbox is checked, and the filepath
listed below the 'Browse' button is to a file in 'share/gallery' on disk.

EXPECTED:
- The background would be embedded in the file.
- The 'Link' checkbox would be unchecked

Adding repro information to whiteboard

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

--- Comment #7 from Michael Meeks michael.me...@collabora.com ---
No idea but I assume code like this:

706 const Graphic aGrf( pGalleryItem-GetGraphic() );
707 
708 if ( nSelType  nsSelectionType::SEL_GRF )
709 rSh.ReRead( aGrfName, aFltName, aGrf );
710 else
711 rSh.Insert( aGrfName, aFltName, aGrf );

Creates that Graphic - and that (somehow) the GraphicObject that gets created
from that gets tagged as linked somehow - perhaps chasing rSh.Insert() and
re-read to see what parameters they take might be useful (?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

--- Comment #7 from Michael Meeks michael.me...@collabora.com ---
No idea but I assume code like this:

706 const Graphic aGrf( pGalleryItem-GetGraphic() );
707 
708 if ( nSelType  nsSelectionType::SEL_GRF )
709 rSh.ReRead( aGrfName, aFltName, aGrf );
710 else
711 rSh.Insert( aGrfName, aFltName, aGrf );

Creates that Graphic - and that (somehow) the GraphicObject that gets created
from that gets tagged as linked somehow - perhaps chasing rSh.Insert() and
re-read to see what parameters they take might be useful (?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #6 from Samuel M. s.mehrbr...@gmail.com ---
(Adding the Dev list to CC)
I'd need some help with the Fix for this bug. Can someone have a look at
Comment 5 and help me with this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

 CC||libreoffice@lists.freedeskt
   ||op.org

--- Comment #6 from Samuel M. s.mehrbr...@gmail.com ---
(Adding the Dev list to CC)
I'd need some help with the Fix for this bug. Can someone have a look at
Comment 5 and help me with this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Bug 67274 depends on bug 69079, which changed state.

Bug 69079 Summary: Creating a new themes in the gallery the files are always 
created as file new theme.* instead of sdxxx.* - existing files will be 
overwritten and leads to data loss.
https://bugs.freedesktop.org/show_bug.cgi?id=69079

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Caolán McNamara caol...@redhat.com changed:

   What|Removed |Added

 Depends on|65675   |
 Blocks||65675

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

 Depends on||69079

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

   Assignee|s.mehrbr...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org
 Depends on||65675

--- Comment #5 from Samuel M. s.mehrbr...@gmail.com ---
Can someone else please have a look at it?
The Background URL is set here:
http://opengrok.libreoffice.org/xref/core/svx/source/gallery2/galbrws2.cxx#372

Then the Image gets inserted here:
http://opengrok.libreoffice.org/xref/core/sw/source/ui/shells/basesh.cxx#2662

Somewhere in between the SvxBrushItem (the background) is created as a linked
graphic and that must be changed. But I don't know where that happens.

Can someone give a hint or take this over?

I mark this as MAB because it makes Documents depend on hard-coded image paths.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

--- Comment #4 from Samuel M. s.mehrbr...@gmail.com ---
The mentioned commit fixes this problem only partly.
The Problem described in Comment 0 still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |s.mehrbr...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard||target:4.2.0

--- Comment #3 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e3f7d32b80fcb44f20abe634a2035d2c90c9e08

fdo#67274 Always embed images from gallery



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67274] Gallery: Do not link inserted images

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=67274

Samuel M. s.mehrbr...@gmail.com changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
Summary|Gallery: Do not link|Gallery: Do not link
   |inserted backgrounds|inserted images

--- Comment #2 from Samuel M. s.mehrbr...@gmail.com ---
You are right, it should not be possible to link to gallery images. We
discussed this also on the UX-Advise list:
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Remove-outdated-Gallery-images-tp4067129p4067444.html

I changed the title accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs