[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #9 from Jean-Baptiste Faure  ---
(In reply to comment #8)
> Thank you Björn :-)
> 
> Could this patch be backported to 4.1 ? 

Perhaps not so good idea because this would imply to add translatable strings.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #10 from Björn Michaelsen  ---
I vendorpatched that independently on 4.1 for Ubuntu. The PPA versions should
already have this patched and this should also go into the archive with the
next SRU, so TBH I dont want to backport that patch (just to kick out the
vendor patch there).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

David Tardon  changed:

   What|Removed |Added

 CC||dtar...@redhat.com

--- Comment #11 from David Tardon  ---
(In reply to comment #2)
> Created attachment 88144 [details] [review]
> proposed patch
> 
> Here is a patch that updates desktop files.
> Proposed changes are:
> - reactivate StartCenter 

Why? What good does it do to the user, when there are already separate records
for the applications?

> and Math desktop file: NoDisplay keyword set to
> false

This is a regression from bug 41681. IIRC the consensus of most distro
maintainers was not to show it. (And yes, there is no way to please users
anyway. We have got bugs in Fedora asking for both.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
   |SkillScript target:4.2.0|SkillScript target:4.2.0
   ||target:4.3.0

--- Comment #12 from Commit Notification 
 ---
David Tardon committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=12546c8511f0cc8eec0ca7e8cb86ff00dfd429e6

regression since fdo#70553



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #13 from Maxim Monastirsky  ---
(In reply to comment #11)
> (In reply to comment #2)
> > Proposed changes are:
> > - reactivate StartCenter 
> 
> Why? What good does it do to the user, when there are already separate
> records for the applications?
Hi David,

What the point of having a "Start" center if no one will ever see it when he
"starts" the application?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #14 from David Tardon  ---
(In reply to comment #13)
> (In reply to comment #11)
> > (In reply to comment #2)
> > > Proposed changes are:
> > > - reactivate StartCenter 
> > 
> > Why? What good does it do to the user, when there are already separate
> > records for the applications?
> Hi David,
> 
> What the point of having a "Start" center if no one will ever see it when he
> "starts" the application?

I doubt anyone just wants to start the application. One wants to create a
document or presentation or...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #15 from Maxim Monastirsky  ---
(In reply to comment #14)
> I doubt anyone just wants to start the application. One wants to create a
> document or presentation or...
Or to open recently edited document. The new start center allows to do that in
a convenient way, instead of opening the file browser and navigating through
endless folders...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #16 from Jean-Baptiste Faure  ---
(In reply to comment #14)
> [...]
> I doubt anyone just wants to start the application. One wants to create a
> document or presentation or...

So, to be consistent, you should commit a patch to remove the StartCenter,
including for the MS-Windows version. Very strange idea to remove the
visibility of the StartCenter when we create a new one.

If Linux distributions maintainers do not want give the access to the
StartCenter and the Math module, they can do that in their distro build without
deciding for all Linux users.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #17 from David Tardon  ---
(In reply to comment #16)
> (In reply to comment #14)
> > [...]
> > I doubt anyone just wants to start the application. One wants to create a
> > document or presentation or...
> 
> So, to be consistent, you should commit a patch to remove the StartCenter,
> including for the MS-Windows version. Very strange idea to remove the
> visibility of the StartCenter when we create a new one.

To be honest, I do not care much either way. And _if_ this was changed as a
result of a discussion (or a bug) that said: "Hey, we have a shiny new start
center. Let's all the users see it!", I would not say anything. But it was not,
so I see it as a regression.

> 
> If Linux distributions maintainers do not want give the access to the
> StartCenter and the Math module, they can do that in their distro build
> without deciding for all Linux users.

Well, we tend to assume the majority of linux users gets libreoffice through
their distribution. And the last time this come up, more distro maintainers
were for disabling than against it. If that has changed, so be it. We patched
it in Fedora before; we can do it again...

Note that math has been hidden since 3.5 and nobody has protested. Startcenter
was only hidden in 4.1, but I do not remember any bugs related to that
either...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #18 from Samuel M.  ---
Well, I don't think the start center is of great use for Linux users.
For Windows it's ok, you need to put something on their desktop so they can
find the program they installed.
But I doubt there are many Linux users who use the start center. I have it
there since 4.1 but have never opened it.

But I'm not sure what's the reason Math is hidden.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Maxim Monastirsky  changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=70133

--- Comment #19 from Maxim Monastirsky  ---
(In reply to comment #17)
> Startcenter was only hidden in 4.1, but I do not remember any bugs related
> to that either...
There is Bug 70133. Also keep in mind that Debian/Ubuntu patched 4.1 to
re-enable the start center, and that might be the reason we don't have many
reports about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #20 from David Tardon  ---
(In reply to comment #19)
> (In reply to comment #17)
> > Startcenter was only hidden in 4.1, but I do not remember any bugs related
> > to that either...
> There is Bug 70133.

... where the reporter does not say why he needs it, just that it is missing.
Cue http://xkcd.com/1172/ .

> Also keep in mind that Debian/Ubuntu patched 4.1 to
> re-enable the start center, and that might be the reason we don't have many
> reports about it.

But that does not supports the "generic unix" case. Reciprocally, keep in mind
that Fedora has had it disabled for at least 4 releases and we have not had any
bug reports concerning that either.

> Or to open recently edited document. The new start center allows to do
> that in a convenient way, instead of opening the file browser and
> navigating through endless folders...

And only allows to do that one document at a time, because as soon as you have
opened one, the only way to go back to the start center is to close the
document. So the user needs to remember two ways to access recently opened
documents. (Three, actually, because the desktop typically offers one as well.) 

But whatever... I have had enough of this discussion. I will revert my earlier
commit and just handle it in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #21 from Tor Lillqvist  ---
David, don't give up! This is just getting fun.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2014-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #22 from Commit Notification 
 ---
David Tardon committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2b2f2d5194313f6a53d35eee39357dbca5f0bd4

Revert "regression since fdo#70553"



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Björn Michaelsen  changed:

   What|Removed |Added

 OS|All |Linux (All)
 Status|UNCONFIRMED |NEW
 Whiteboard||EasyHack DifficultyBeginner
   ||SkillScript
   Severity|normal  |minor
   Priority|medium  |low
 CC||libreoffice@lists.freedeskt
   ||op.org
   See Also||https://launchpad.net/bugs/
   ||1231799
Version|unspecified |4.1.2.3 release
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #1 from Jean-Baptiste Faure  ---
AFAIK .desktop files are in /core/sysui/desktop/menus/
Not sure if it is enough to modify these files.

Best regards.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jbf.fa...@sud-ouest.org
   |desktop.org |

--- Comment #2 from Jean-Baptiste Faure  ---
Created attachment 88144
  --> https://bugs.freedesktop.org/attachment.cgi?id=88144&action=edit
proposed patch

Here is a patch that updates desktop files.
Proposed changes are:
- reactivate StartCenter and Math desktop file: NoDisplay keyword set to false
- add "New Document" menu for each module in StartCenter desktop file
- make desktop files more standard conforming (hopefully) : 
  a- removed X-Ayatana-Desktop-Shortcuts keyword
  b- %U parameter is useless when creating a new document
  c- use OnlyShowIn keyword instead of TargetEnvironment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #3 from Maxim  ---
@Jean-Baptiste Faure: There is no need to set NoDisplay=false, you just need to
remove this line completely.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #4 from Jean-Baptiste Faure  ---
(In reply to comment #3)
> @Jean-Baptiste Faure: There is no need to set NoDisplay=false, you just need
> to remove this line completely.

I know, the idea was to keep track of the hidden state of the StartCenter and
the Math module in previous version.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #5 from Björn Michaelsen  ---
FWIW, I had a vendor patch for this in on 4.1, but will of course push _your_
changes as soon as I am back home.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Jean-Baptiste Faure  changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=69344

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Björn Michaelsen  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Björn Michaelsen  ---
Pushed, Thanks Jean-Baptiste!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner
   |SkillScript |SkillScript target:4.2.0

--- Comment #7 from Commit Notification 
 ---
Jean-Baptiste Faure committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=78e4c8a925f4735a7e9a4c32a29b19fd2b77670d

fdo#70553: Fix Unity Quicklists



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 70553] Update .desktop files to use freedesktop actions

2013-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70553

--- Comment #8 from Jean-Baptiste Faure  ---
Thank you Björn :-)

Could this patch be backported to 4.1 ? If I am not wrong, before this change
desktop files were identical in 4.1 and the master.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice