[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #1 from Björn Michaelsen --- CCing developer list to Easy Hacks missing this. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #2 from Tor Lillqvist --- Please note that there will be lots of false differences between (flat) ODF exports of even only minimally edited versions of a document, though, thanks to gratuitous randomness in the ODF output. See my recent changes in master that check for the LIBO_ONEWAY_STABLE_ODF_EXPORT environment variable, and in case that is set, do ODF output in a more "stable" manner. Unfortunately, as the "ONEWAY" part of the env var name indicates, this is not intended to be roundtrip-safe, though, so that code path can not be made the default. It would be great if people who actually understand the issues involved would figure out roudtrip-safe ways to solve the problem (that task it likely not an EasyHack) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #3 from Michael Meeks --- Sure - I think the flat-odf idea is prolly not a great one - instead we should just convert to text. Then of course we have a paragraph / line-wrapping problem instead: that small changes perturb that a lot, but ... c'est la vie. I agree that ODF is hardly easy to read on the command-line; but plain-text: more so ;-) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #4 from Tor Lillqvist --- Ah, I didn't read the linked article so I thought you meant flat ODF for storage of docs, but yeah, if just for diffing ,hen plain text obviously is better. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #5 from Deena P.F. --- I'd like to work on this as my first open source contribution. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #6 from Deena P.F. --- There is small problem with the idea, the --convert-to option prints out to stdout a string indicating the file names involved. For example : $ soffice --headless --convert-to txt:Text --outdir /tmp /tmp/filezBIL6j.odt This prints out the following string to stdout : """ convert /tmp/filezBIL6j.odt -> /tmp/filezBIL6j.txt using Text """ If we are to reuse --convert-to code, this string will be present along with the --cat output. Unfortunately, I could not find where this string gets printed in the code using http://opengrok.libreoffice.org/ -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #7 from Maxim Monastirsky --- (In reply to comment #6) > Unfortunately, I could not find where this string gets printed in the code > using http://opengrok.libreoffice.org/ It's here: http://opengrok.libreoffice.org/xref/core/desktop/source/app/dispatchwatcher.cxx#489 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #8 from Michael Meeks --- We could of course add a different option to LibreOffice specific to this functionality (perhaps) eg. a --cat parameter ? that could output the plain text on stdout - and avoid the necessity to manage /tmp files in shell - which is a bit horrible =) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 Deena P.F. changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |deena.fran...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #9 from Deena P.F. --- Added my changes to gerrit for review. https://gerrit.libreoffice.org/#/c/10623/ -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 Commit Notification changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillCpp TopicCleanup |SkillCpp TopicCleanup ||target:4.4.0 --- Comment #10 from Commit Notification --- deenafrancis committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d318e6cf4a183e14a043840b9990958c7527536 fdo#70625 Add --cat parameter to make git diffs pretty The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #11 from Michael Meeks --- Nice patch Deena - thanks for that. A few more things might be a good idea: * perhaps auto-enable --headless on Linux - there are other settings to force windows not to show on Mac etc. I think ;-) * work out what we want for spreadsheets / presentations - export as CSV ? or ... something there would be good I guess. Then I guess we need to persuade someone to knock up some sample git config bits such that we can get nice human readable diffs easily - perhaps dropping that in the wiki ? [ and the 4.4 features wiki page I guess - perhaps the SparkleShare people would appreciate that too ? ]. Anyhow - a really great start; - oh ! and also can you send an E-mail like this: https://wiki.documentfoundation.org/Development/Developers#Developers_and_Contributors_list so we get the auditing right =) Thanks ! -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70625] Add --cat parameter to make git diffs pretty
https://bugs.freedesktop.org/show_bug.cgi?id=70625 --- Comment #12 from Deena P.F. --- Thanks for verifying and accepting the patch. I will work on improving the --cat feature for document formats other than those supported by swriter. (In reply to comment #11) > Nice patch Deena - thanks for that. > > A few more things might be a good idea: > > * perhaps auto-enable --headless on Linux - there are other settings to > force windows not to show on Mac etc. I think ;-) > > * work out what we want for spreadsheets / presentations - export as CSV ? > or ... something there would be good I guess. > > Then I guess we need to persuade someone to knock up some sample git config > bits such that we can get nice human readable diffs easily - perhaps > dropping that in the wiki ? [ and the 4.4 features wiki page I guess - > perhaps the SparkleShare people would appreciate that too ? ]. > > Anyhow - a really great start; - oh ! and also can you send an E-mail like > this: > > https://wiki.documentfoundation.org/Development/ > Developers#Developers_and_Contributors_list > > so we get the auditing right =) > > Thanks ! -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
