[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 jan iversen changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp Whiteboard|easyHack difficultyBeginner | |skillCpp| -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 --- Comment #7 from Kohei Yoshida --- (In reply to jan iversen from comment #6) > Do not trust your memory, trust the version control system :-) Absolutely right. Would you mind looking into that? :-) I might do it later when I find time but I'm a bit short on time at the moment. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 --- Comment #6 from jan iversen --- Do not trust your memory, trust the version control system :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 --- Comment #5 from Kohei Yoshida --- And I swear this UI label used to be "file filters" not "file types" though my memory is a bit hazy. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 --- Comment #4 from Kohei Yoshida --- I'm the original author of the part of the detection code that handles generic text file type. We need to be careful not to confuse format "types" and "filters". A type only refers to a format type such as HTML, plain text etc, and is not tied to a specific application such as Writer or Calc. A filter OTOH is tied to a single application. We have one plain text filter for Writer and one plain text filter for Calc. The one for Writer treats all plain text files equally whereas the one for Calc treats all plain text files equally as CSV, regardless of extension. OTOH, we only have one generic text type that's application agnostic. During detection phase, when a plain text "type" is detected, it does its best to tie that to a specific filter which in turn determines which application the file will be opened. Part of the confusion comes from the fact that we do list all available "filters" as file "types" in the UI, which IMO is not correct. As such, if you specify in the UI the "Text" type which really is a text filter for Writer, the file will be opened in Writer even if you do this from Calc window before what that "Text type" represents is the plain text "filter" for Writer. Perhaps the right solution would be to change the UI label from "file types" to "file filters"? Either way, we do need to make the correct distinction between file types and file filters and do understand the differences between the two before trying to come up with what would be the right solution for this. Just my 2 cents. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 --- Comment #3 from Mike Ruskai --- (In reply to David Tardon from comment #1) > (In reply to Mike Ruskai from comment #0) > > It's a bit of a PITA to open a delimited text file with Calc, as the "Text" > > filter always loads the document in Writer > > That is not true. If the file is opened from an existing Calc window, it > will be opened in Calc too. I take it you're aware by now that this claim is not true. Opening a delimited text file from Calc using the "Text" filter sends the file to Writer. > > and the "Text CSV" filter only > > lists *.csv files. > > That is because this filter is import/export, and 'csv' is the extension for > export. I don't know if there can be more than one. Normal UI design uses a filter with all eligible extensions for opening a file, with a specific extension for saving a file. The latter can either be through separate filters, or a filter with multiple extensions selected via a dropdown on the file dialog. > This filter uses 'Text' type, which is also used by Writer. So the detection > code contains a few simple heuristics that try to guess if the file should > be opened in Writer or Calc. I think a possible course of action is to > define a separate type for it, say 'Delimited Text'. Such a separate filter is what I think makes the most sense. It's really what "Text CSV" already is, save without the file extension limitation. That filter is currently the only way to save a delimited text file of any kind. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 David Tardon changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org Whiteboard||easyHack difficultyBeginner ||skillCpp --- Comment #2 from David Tardon --- What is needed here: Create a new filter type delimited_Text as a copy of filter/source/config/fragments/types/generic_Text.xcu . Change filter/source/config/fragments/filters/Text___txt___csv__StarCalc_.xcu to use it. Modify PlainTextFilterDetect::detect in filter/source/textfilterdetect/filterdetect.cxx to handle delimited_Text in addition to generic_Text and to always set CALC_TEXT_FILTER in that case. Check that various use cases work as expected: e.g., open a .txt/.csv file from an existing Calc/Writer window with specifying a type, then without it, then directly from the Start Center, etc. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 David Tardon changed: What|Removed |Added Component|Calc|filters and storage -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
