Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date
Hi Keith, On Wed, 2011-01-19 at 11:12 +0630, Keith Stribley wrote: > The Graphite font library has recently been rewritten to be much faster. Nice ! :-) > One of the consequences of that is that it also has a new api. I hope to > publish patches for integrating the new graphite2 API into LibO in the > near future. The new api no longer uses STL, so that avoids the > conflicts between STLPort and system STL. Even better; looking forward to seeing that. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date
On ၂၀၁၁ ဇန် ၁၆ တနင်္ဂနွေ နံနက် 02:46, Caolán McNamara wrote: Well, we do occasionally patch those "external" modules, but try to avoid it. The ideal place to send patches to graphite would be to the upstream graphite project and poke them to release a new update at some stage and then just upgrade to the latest graphite. The Graphite font library has recently been rewritten to be much faster. One of the consequences of that is that it also has a new api. I hope to publish patches for integrating the new graphite2 API into LibO in the near future. The new api no longer uses STL, so that avoids the conflicts between STLPort and system STL. Regards, Keith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date
On Sat, Jan 15, 2011 at 08:16:55PM +, Caolán McNamara wrote: > On Sat, 2011-01-15 at 00:43 +0100, Lionel Elie Mamane wrote: > > Hi, > > > > A build with --enable-debug (or is it --enable-dbgutil?) fails in > > graphite... for a problem already corrected in graphite's > > configure.ac, but its "configure" is outdated and thus the problem > > still surfaces. > > Ah, I see. So I've now added a patch into that graphite module to sync > the configure.ac logic into configure. > > > Before I got to the point of trying to disable -Werror (and > > understanding why it was enabled in the first place), I fixed one of > > the warnings. Patch attached, still does not hurt to apply janitorialy > > :) > > Well, we do occasionally patch those "external" modules, but try to > avoid it. The ideal place to send patches to graphite would be to the > upstream graphite project and poke them to release a new update at some > stage and then just upgrade to the latest graphite. BTW, Graphite engine is being re-written into a more stable engine (the current engine is crashy, or so I read), so it might be a good time to consider switching over to the new engine. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date
On Sat, 2011-01-15 at 00:43 +0100, Lionel Elie Mamane wrote: > Hi, > > A build with --enable-debug (or is it --enable-dbgutil?) fails in > graphite... for a problem already corrected in graphite's > configure.ac, but its "configure" is outdated and thus the problem > still surfaces. Ah, I see. So I've now added a patch into that graphite module to sync the configure.ac logic into configure. > Before I got to the point of trying to disable -Werror (and > understanding why it was enabled in the first place), I fixed one of > the warnings. Patch attached, still does not hurt to apply janitorialy > :) Well, we do occasionally patch those "external" modules, but try to avoid it. The ideal place to send patches to graphite would be to the upstream graphite project and poke them to release a new update at some stage and then just upgrade to the latest graphite. We're behind in quite a few modules from the leading edge, we should get up to date in more of them, e.g. hunspell, icu, hyphen, etc. and try and reduce the custom patching. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
