Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
On Mon, Dec 05, 2011 at 06:22:33AM -0800, Pedro wrote: >> There might be more commits in the other repositories in the >> meantime => the question is what time to use. We might end up with >> 5 times in the end, e.g.: >> 41491491-41491527-41491568-41491597-41491613 >> It is quite complex in the end. Also, it would be hard for developers to >> get the corresponding commit from it. > That is why I suggested to established a different "birth" date for > each repository. > If we established a 2 day interval since TDF's birthday, then you would have > 414.91491-412.91491-410.91491-408.91491-406.91491 Not, it is still harder than necessary for devs to find what commit this corresponds to. >> I see the following needs and solutions: >> + easily match about dialog with downloaded tarball >> => we need to use the same string in both >> I would add one more line with a time generated by configure >> to the about dialog. The same time should be used in the >> download tarball name > That would be an easier solution. And human readable. So the time you want to put is essentially a "build started" date, and not even that. If an incremental build was done that did not rerun configure, your date is not updated. We can fix that later point by instead making that date a .PHONY target in make, but it still does not satisfy me. I still prefer my "date of last commit to repo" solution. Yes, we have five dates instead of one, but that is the truth... If someone builds with a recent core, but old binfilters, at least it shows. Essentially, the "last commit" date is a *code* *version* *number*, that is completely independent of when the build was done. *That* is what we want. >> + easily match build with git commit >> => keep the git IDs in about dialog > My suggestion was to replace the git IDs altogether with the age > system. No, the git IDs is the only thing that is easy to use in git. Git IDs have to stay. Add the dates as an *alternative* for human consumption, and as a monotonically increasing version number. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
Hi Petr > Hmm, we check out the five repositories one by one. It might take some > time if you have slower network connection. There might be more commits > in the other repositories in the meantime => the question is what time > to use. We might end up with 5 times in the end, e.g.: > > 41491491-41491527-41491568-41491597-41491613 > > It is quite complex in the end. Also, it would be hard for developers to > get the corresponding commit from it. That is why I suggested to established a different "birth" date for each repository. If we established a 2 day interval since TDF's birthday, then you would have 414.91491-412.91491-410.91491-408.91491-406.91491 Because the part before the point means days, a build from the following day would be (assuming there were changes only to the core) 415.67866-412.91491-410.91491-408.91491-406.91491 I.e. you only need to read the first 3 digits to realize if it's older or newer. Even better: because the fraction part after the point is also time, you know that any value below 0.5 is before noon and any value greater is between noon and midnight. > I see the following needs and solutions: > > > + easily match about dialog with downloaded tarball > > => we need to use the same string in both > > I would add one more line with a time generated by configure > to the about dialog. The same time should be used in the > download tarball name That would be an easier solution. And human readable. > + easily match build with git commit > > => keep the git IDs in about dialog My suggestion was to replace the git IDs altogether with the age system. This solves the potential problem of the truncated 7 digits of the SHA repeating sometime in the future and it is human readable. But this is secondary if the date-time code is added to the about box and to the tarball name (or Windows installer ;) ) > + human readable string for official builds for normal users: > > => I would add one more line, .e.g. 3.5.0-beta1 > it will be used only in the official builds generated from > release tarballs or release tags Couldn't agree more! > > Does it make sense? Yes. I think that covers all problems. Best regards, Pedro -- View this message in context: http://nabble.documentfoundation.org/Naming-builds-Please-tp3556898p3561557.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
Pedro Lino píše v So 03. 12. 2011 v 23:40 +: > Hi Lionel > > > Git commit IDs as identifiers have the huge problem that they are not > > comparable (one cannot say which one is "greater") without referring > > to the repository. How about we also put the *commit* (not author) > > timestamp (in UTC) of the top node (commit), and maybe the branch? > > That would help! > > > Something like: > > > > Build assembled from: > > repo commit date branch > > core: 4f11d0a 2011-11-16 21:57:28 master > > help: adcf6d5 2011-11-05 14:01:21 master > > ... > > > > Or instead of pretty-printing the date, just put it as seconds > > since the epoch: > > > > core: 4f11d0a 1321480648 master > > help: adcf6d5 1320501681 master > > That would solve the problem when looking into the log file but not > when looking at the About box. > > Picking up your (excellent) idea of using the date and converting to a > linear value: if each repository was given a Birth Date and time since > that date converted to a linear value (age), using the Date function > you could get a 10 digit value able to separate builds with one second > time difference. > > E.g. If the Core repository was created at midnight Sept 28th 2010 > (TDF's birthday) or in linear time (times 10 to eliminate the > point) 404490, then the 4f11d0a 2011-11-16 21:57:28 master > > age would be 41491490. This seems like a nice easy number to compare. > In fact a build using code from one second later would be 41491491. Hmm, we check out the five repositories one by one. It might take some time if you have slower network connection. There might be more commits in the other repositories in the meantime => the question is what time to use. We might end up with 5 times in the end, e.g.: 41491491-41491527-41491568-41491597-41491613 It is quite complex in the end. Also, it would be hard for developers to get the corresponding commit from it. I think that we should first define what we expect from the version number. Note that we could mention more lines in the about dialog. They are easy to cut&paste, so they should not cause troubles. I see the following needs and solutions: + easily match about dialog with downloaded tarball => we need to use the same string in both I would add one more line with a time generated by configure to the about dialog. The same time should be used in the download tarball name + easily match build with git commit => keep the git IDs in about dialog + human readable string for official builds for normal users: => I would add one more line, .e.g. 3.5.0-beta1 it will be used only in the official builds generated from release tarballs or release tags Does it make sense? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
> No, my idea was to put the above text in the about box, to replace our > current 4f11d0a-adcf6d5-... string. Oh, I see! But then it would be easier to use the "pretty printing date" instead of having 2 strings to compare for each repository. That would be a nice improvement. What I was proposing was to replace 4f11d0a-adcf6d5-c4bb9bd with 41491490-etc-etc which is a simple numeric value that will continually grow because it is an age... One year from now you would be using build 79831260-etc-etc and you wouldn't have to look twice to know that this build was much newer than 41491490-etc-etc Even better, use the string as the actual number of days which is even easier to visually compare: 414.91490-etc-etc now, 798.31260-etc-etc in a year, 44534.31260-etc-etc ten years from today at the exact same second It's easy to visualize and to explain to anyone the logic. Kind regards, Pedro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
On Sat, Dec 03, 2011 at 11:40:01PM +, Pedro Lino wrote: >> Git commit IDs as identifiers have the huge problem that they are not >> comparable (one cannot say which one is "greater") without referring >> to the repository. How about we also put the *commit* (not author) >> timestamp (in UTC) of the top node (commit), and maybe the branch? >> Something like: >> Build assembled from: >> repo commit date branch >> core: 4f11d0a 2011-11-16 21:57:28 master >> help: adcf6d5 2011-11-05 14:01:21 master >> ... >> Or instead of pretty-printing the date, just put it as seconds >> since the epoch: >> core: 4f11d0a 1321480648 master >> help: adcf6d5 1320501681 master > That would solve the problem when looking into the log file but not > when looking at the About box. No, my idea was to put the above text in the about box, to replace our current 4f11d0a-adcf6d5-... string. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
Hi Lionel > Git commit IDs as identifiers have the huge problem that they are not > comparable (one cannot say which one is "greater") without referring > to the repository. How about we also put the *commit* (not author) > timestamp (in UTC) of the top node (commit), and maybe the branch? That would help! > Something like: > > Build assembled from: > repo commit date branch > core: 4f11d0a 2011-11-16 21:57:28 master > help: adcf6d5 2011-11-05 14:01:21 master > ... > > Or instead of pretty-printing the date, just put it as seconds > since the epoch: > > core: 4f11d0a 1321480648 master > help: adcf6d5 1320501681 master That would solve the problem when looking into the log file but not when looking at the About box. Picking up your (excellent) idea of using the date and converting to a linear value: if each repository was given a Birth Date and time since that date converted to a linear value (age), using the Date function you could get a 10 digit value able to separate builds with one second time difference. E.g. If the Core repository was created at midnight Sept 28th 2010 (TDF's birthday) or in linear time (times 10 to eliminate the point) 404490, then the 4f11d0a 2011-11-16 21:57:28 master age would be 41491490. This seems like a nice easy number to compare. In fact a build using code from one second later would be 41491491. All this takes is attributing an arbitrary birth date for each repository and very simple calculations. Please do consider this! Thank you again, Lionel! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
> No need to know. It is just a random (or not so random) sequence of > hex digits. If nothing documents it to have some significance, don't > assume it to have any significance. Thank you for the clarification. It does have some significance. >> Anyway, even if this was a combination of the GIT IDs it would still >> be useless as an identification > > Well, is it claimed anywhere to be useful as an identification? I (wrongly) assumed it was meant for identification. In fact if the same build generates the same sequence then they are synonyms and can be used for some sort of identification (as I just explained in a previous email). I realize from your answer that the code was generated simply to make the folder name unique. But this is irrelevant since the installer folder will no longer be created. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
> I thought Andras was referring to the single 8 letter/number code > added to the Windows install folder name. > Where does that come from? No need to know. It is just a random (or not so random) sequence of hex digits. If nothing documents it to have some significance, don't assume it to have any significance. > Anyway, even if this was a combination of the GIT IDs it would still > be useless as an identification Well, is it claimed anywhere to be useful as an identification? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
Hi Korrawit > That is, if your 4f11d0a is the first group of IDs in About box, it's > the core repository's commit ID. Yes, obviously. Sorry for the confusion. I thought Andras was referring to the single 8 letter/number code added to the Windows install folder name. Where does that come from? Example: Build ID: 4f11d0a-adcf6d5-c4bb9bd Folder name LibO-dev 3.5 (4ec47f5f) Installation Files Anyway, even if this was a combination of the GIT IDs it would still be useless as an identification because different binaries using the same core would have a different code depending on the repositories used, right? Regards, Pedro ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] Naming builds. Please???
Hello Pedro, Andras, * On Sat, Dec 3, 2011 at 20:16, Pedro Lino wrote: > So, 4f11d0a is a global commit ID calculated from the partial 5 git > commit IDs? No, it isn't. It's like what you've explained: > So the About box says a286353-090bcba-3bf3b94 > which I just realized are the 7 first letters of each used repository commit > ID > > tinderbox: git sha1s > core:a28635374613e556a0093c242823ea90a3704f74 > dictionaries:090bcbaa55370d7906b0cab08839fe88f4e80215 > help:3bf3b943ff05fda627498426a23f94cd0e0b7aab That is, if your 4f11d0a is the first group of IDs in About box, it's the core repository's commit ID. Hope this helps. :) Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
