Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote
Hello Lionel, On Sun, Dec 11, 2011 at 14:28, Lionel Elie Mamane lio...@mamane.lu wrote: Well, IMHO the example is correct _with_ quotation marks, else the shell will cut it into several arguments. [cut] On which platform have you encountered the it breaks with quotation marks, but works without quotation marks behaviour you mention? Aha! Now I know why it fails on me. If I run $ ./autogen.sh --with-some-arguments-here it should be _with_ quote. But if I edit autogen.lastrun and just run $ ./autogen.sh without any argument, it will read from autogen.lastrun, and it should be _without_ quote. I'm on cygwin, but I think this applies to other platform as well ... Second patch is just a trivial change: --with-theme is without s. Yes, applied this one. Thanks! Thanks! Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote
On Sun, Dec 11, 2011 at 05:18:36PM +0700, Korrawit Pruegsanusak wrote: On Sun, Dec 11, 2011 at 14:28, Lionel Elie Mamane lio...@mamane.lu wrote: Well, IMHO the example is correct _with_ quotation marks, else the shell will cut it into several arguments. [cut] On which platform have you encountered the it breaks with quotation marks, but works without quotation marks behaviour you mention? If I run $ ./autogen.sh --with-some-arguments-here it should be _with_ quote. But if I edit autogen.lastrun and just run $ ./autogen.sh without any argument, it will read from autogen.lastrun, and it should be _without_ quote. Yes, this smells right, for all platforms. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote
On Sun, Dec 11, 2011 at 11:47:02AM +0700, Korrawit Pruegsanusak wrote: I've attached two cosmetic patches of configure.in. First patch fixes an example in AS_HELP_STRING. The configure options shouldn't be passed with quotation marks, as described in commit message. Well, IMHO the example is correct _with_ quotation marks, else the shell will cut it into several arguments. For example: ./autogen.sh --with-theme=oxygen tango gives: $ ./autogen.sh --with-theme=oxygen tango running ./configure with '--with-theme=oxygen' 'tango' configure: WARNING: you should use --build, --host, --target * * Running LibreOffice build configuration. * checking build system type... Invalid configuration `tango': machine `tango' not recognized configure: error: /bin/bash ./config.sub tango failed Error running configure at ./autogen.sh line 157. On which platform have you encountered the it breaks with quotation marks, but works without quotation marks behaviour you mention? Second patch is just a trivial change: --with-theme is without s. Yes, applied this one. Thanks! -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
