Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
Hi Takeshi, On Fri, 2011-02-11 at 20:31 +0900, KUROSAWA, Takeshi wrote: Currently LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2 for POINTER_HAND. As a result, LibreOffice uses GDK_HAND1 for hyperlinks, while many GTK2 applications use GDK_HAND2. # See attached png images. :-) Since there is not much difference between GDK_HAND1 and GDK_HAND2 and GDK_HAND1 is not commonly used, we should use GDK_HAND2 for both POINTER_REFHAND and POINTER_HAND. It would be interesting to know how POINTER_HAND and POINTER_REFHAND are used around the LibreOffice code ? But anyhow - the patch looks fine for what it is :-) It'd be great to push it, but it'd be nice to know if we really use this distinction meaningfully inside vcl and its dependents anyway ... Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
Hi, On Sat, Feb 12, 2011 at 7:45 PM, Michael Meeks michael.me...@novell.com wrote: Since there is not much difference between GDK_HAND1 and GDK_HAND2 and GDK_HAND1 is not commonly used, we should use GDK_HAND2 for both POINTER_REFHAND and POINTER_HAND. It would be interesting to know how POINTER_HAND and POINTER_REFHAND are used around the LibreOffice code ? I created an wiki page for that (currently POINTER_HAND only). http://wiki.documentfoundation.org/User:Taken/Cursor_Usage I found 7 code paths which uses POINTER_HAND by OpenGrok. In my opinion they are not related to hyperlinks. Additionally some usage could be replaced by other cursors (e.g. panning and editing control point). Anyway more investigations needed. Cheers, -- Kurosawa Takeshi taken@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
On Fri, 2011-02-11 at 20:31 +0900, KUROSAWA, Takeshi wrote: Hi, Here is a patch to make LibeOffice use a more commonly-used mouse cursor in GTK. Currently LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2 for POINTER_HAND. As a result, LibreOffice uses GDK_HAND1 for hyperlinks, while many GTK2 applications use GDK_HAND2. # See attached png images. I wonder why I don't see this behaviour locally. If I type a url in writer or impress and then put my mouse over it I get the same hand as I see in gimp, etc. The only time I see the other hand is if I type anything into draw, whether its a url or not, i.e. I'm in a mode where clicking and moving the mouse moves the textbox under it. Is the previous screenshot from draw ?, and if it is, does clicking spawn off the brower when the cursor is like that ? If you type the url in writer and press ctrl with the mouse over it, do you get the same hand as in gimp ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1
Hi Caolán, On Sat, Feb 12, 2011 at 5:46 AM, Caolán McNamara caol...@redhat.com wrote: I wonder why I don't see this behaviour locally. If I type a url in writer or impress and then put my mouse over it I get the same hand as I see in gimp, etc. Several cursor themes use same cursor for both GDK_HAND1 and GDK_HAND2. In this case there is no difference. But there are some cursor themes which use different cursors (e.g. DMZ (White) ) and provide GDK_HAND2 only (e.g. Arch Cursor Theme (Simple)). DMZ (White) HAND1: http://gitorious.org/opensuse/art/blobs/master/cursors/dmz/pngs/48x48/hand1.png HAND2: http://gitorious.org/opensuse/art/blobs/master/cursors/dmz/pngs/48x48/hand2.png Arch Cursor Theme (Simple) http://gnome-look.org/content/show.php/Arch+Cursor+Theme+%28simple%29?content=135902 Using such themes, you'll see different hands. The only time I see the other hand is if I type anything into draw, whether its a url or not, i.e. I'm in a mode where clicking and moving the mouse moves the textbox under it. Is the previous screenshot from draw ?, and if it is, does clicking spawn off the brower when the cursor is like that ? If you type the url in writer and press ctrl with the mouse over it, do you get the same hand as in gimp ? The previous screenshot is from Impress with DMZ (White) cursor theme. It is happened in Writer with ctrl key pressing and Help Viewer as well. Cheers, -- Takeshi Kurosawa taken@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
