Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar

2011-02-07 Thread Nguyen Vu Hung 
On Wed, Feb 2, 2011 at 12:18 AM, Baptiste Daroussin b...@freebsd.org wrote:
 So, to make things simple, let's force user having GNU tar, not BSD tar.
 Seriously why not supporting bsdtar?
OK,

I think BSD tar is as good as GNU tar :)

Let's close the topic here so that RMS won't jump into LibO cough-cough :)

-- 
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] bsdtar works as fine as gnu tar

2011-02-01 Thread Baptiste Daroussin 
Hi,

On FreeBSD we use bsdtar (libarchive) and from my testings it works
great with libreoffice (no regression compared to gnu tar)

here is an attempt to allow checking for both bsdtar and gnu tar in
configure (against build git repository)

Hope this is ok

regards,
Bapt
diff --git a/configure.in b/configure.in
index d23440c..b427511 100755
--- a/configure.in
+++ b/configure.in
@@ -1334,9 +1334,9 @@ if test -z $BASH; then
 fi
 AC_SUBST(BASH)
 
-AC_MSG_CHECKING([for GNU tar])
+AC_MSG_CHECKING([for GNU or BSD tar])
 for a in $GNUTAR gtar gnutar tar; do
-  $a --version 2 /dev/null | grep GNU  21  /dev/null
+  $a --version 2 /dev/null | egrep GNU|bsdtar  21  /dev/null
   if test $? -eq 0;  then
GNUTAR=$a
break
@@ -1344,7 +1344,7 @@ for a in $GNUTAR gtar gnutar tar; do
 done
 AC_MSG_RESULT($GNUTAR)
 if test -z $GNUTAR; then
-AC_MSG_ERROR([not found. install GNU tar.])
+AC_MSG_ERROR([not found. install GNU or BSD tar.])
 fi
 AC_SUBST(GNUTAR)
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar

2011-02-01 Thread Nguyen Vu Hung 
On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote:
 Hi,

 On FreeBSD we use bsdtar (libarchive) and from my testings it works
 great with libreoffice (no regression compared to gnu tar)

 here is an attempt to allow checking for both bsdtar and gnu tar in
 configure (against build git repository)
A person who tries to compile LibO *is* a programmer++.
So, to make things simple, let's force user having GNU tar, not BSD tar.

GNU tar can be installed on BSD as well as other non-Linux OSes.
I am use we don't want too much checking in configure.in in order to
make LibO support more platforms.

-- 
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar

2011-02-01 Thread Baptiste Daroussin 
2011/2/1 Nguyen Vu Hung vuhung16p...@gmail.com:
 On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote:
 Hi,

 On FreeBSD we use bsdtar (libarchive) and from my testings it works
 great with libreoffice (no regression compared to gnu tar)

 here is an attempt to allow checking for both bsdtar and gnu tar in
 configure (against build git repository)
 A person who tries to compile LibO *is* a programmer++.
 So, to make things simple, let's force user having GNU tar, not BSD tar.

 GNU tar can be installed on BSD as well as other non-Linux OSes.
 I am use we don't want too much checking in configure.in in order to
 make LibO support more platforms.

 --
 Best Regards,
 Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
 vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus


Seriously why not supporting bsdtar? It has a great effort is made to
make it gnu compatible in fact compatible with the largest possible
set of archive formats.
All the testing I have done with bsd tar shows it performs at least as
well as gnu tar.

The patch is minimalistic and works. it is not as if it added 10+
lines of cryptic code.

regards,
Bapt
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar

2011-02-01 Thread Christian Lohmaier 
Hi *,

On Tue, Feb 1, 2011 at 5:48 PM, Nguyen Vu Hung vuhung16p...@gmail.com wrote:
 On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote:

 On FreeBSD we use bsdtar (libarchive) and from my testings it works
 great with libreoffice (no regression compared to gnu tar)

 here is an attempt to allow checking for both bsdtar and gnu tar in
 configure (against build git repository)
 A person who tries to compile LibO *is* a programmer++.
 So, to make things simple, let's force user having GNU tar, not BSD tar.

I completely disagree. Mac doesn't use gnu-tar by default either, and
the code doesn't make use of gnu-specific features.

It is just with the bashisms in preparation scripts - they get added
because people are not aware, not because it is required.

Same for cp command.

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice