Re: [Libreoffice] [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields

2011-04-21 Thread Kohei Yoshida 
On Thu, 2011-04-21 at 00:20 +0200, Robert Dargaud wrote:
> Hi All,
> 
> In cursor.cxx I found 2 lines accidentally deleted by this patch it seems :
> "vcl119: #i80730# fix cursor paint behavior and timer"
> 
> I've tried to find an explication of this deleted ligne, but without 
> Timer.Stop() I don't understand how it can work correctly.
> I'm not sure of that. It's preferable than an expert have a look to my 
> patch before pushed it.

I think we should ping David about your patch.  The bug is currently
assigned to him.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields

2011-04-21 Thread Noel Power 

On 20/04/11 23:20, Robert Dargaud wrote:

Hi All,

In cursor.cxx I found 2 lines accidentally deleted by this patch it 
seems :

"vcl119: #i80730# fix cursor paint behavior and timer"

I've tried to find an explication of this deleted ligne, but without 
Timer.Stop() I don't understand how it can work correctly.
I'm not sure of that. It's preferable than an expert have a look to my 
patch before pushed it.


vcl is a mystery to me but maybe the blurb in 
http://openoffice.org/bugzilla/show_bug.cgi?id=80730 are useful ?


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time in textfields

2011-04-20 Thread Robert Dargaud 

Hi All,

In cursor.cxx I found 2 lines accidentally deleted by this patch it seems :
"vcl119: #i80730# fix cursor paint behavior and timer"

I've tried to find an explication of this deleted ligne, but without 
Timer.Stop() I don't understand how it can work correctly.
I'm not sure of that. It's preferable than an expert have a look to my 
patch before pushed it.


Best regard

Bob

>From 2150718d3a241e81b00478dec84122d773f0211b Mon Sep 17 00:00:00 2001
From: Robert Dargaud 
Date: Wed, 20 Apr 2011 23:15:16 +0200
Subject: [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time 
in textfields

---
 vcl/source/window/cursor.cxx |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx
index f3c75dd..9aaccff 100644
--- a/vcl/source/window/cursor.cxx
+++ b/vcl/source/window/cursor.cxx
@@ -225,6 +225,7 @@ bool Cursor::ImplHide()
 bWasCurVisible = mpData->mbCurVisible;
 if ( mpData->mbCurVisible )
 ImplRestore();
+mpData->maTimer.Stop();
 }
 return bWasCurVisible;
 }
-- 
1.7.1

>From f6753885e887afdd9e219b5a1fc63d079164ce01 Mon Sep 17 00:00:00 2001
From: Robert Dargaud 
Date: Wed, 20 Apr 2011 23:32:00 +0200
Subject: [PATCH] fix fdo#bug 36404 -More than one text cursor at the same time 
in textfields

---
 vcl/source/window/cursor.cxx |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx
index 9aaccff..7e485ba 100644
--- a/vcl/source/window/cursor.cxx
+++ b/vcl/source/window/cursor.cxx
@@ -226,6 +226,7 @@ bool Cursor::ImplHide()
 if ( mpData->mbCurVisible )
 ImplRestore();
 mpData->maTimer.Stop();
+mpData->mpWindow = NULL;
 }
 return bWasCurVisible;
 }
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice