Re: [Libreoffice] [PATCH] new color picker dialog for all applications
Hi Christian, On Thu, 2011-05-05 at 22:18 +0200, Christian Lippka wrote: This is a patch I have hacked on in my spare time. It replaces the old color picker with a new one. See here for a video demo http://youtu.be/rPu6EmIxkIM?hd=1 Waooh, nice work! Many thanks for it. But I think we should integrate it into the current color selection systems. Here are some quick thoughts * in dialogs and toolbars this could be used for an advanced color selection * we shouldn't remove the use of a set of common colors defined in one or several palettes. * That dialog would be even nicer if it remembers the previously picked (10 or so) colors. To see it in the running office you can for example go to menu tools-options-colors and press edit The dialog is implemented as a service so it is usable from extensions. Great this way it can be used from everywhere... Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] new color picker dialog for all applications
Taking mutex on this one. Will integrate to master. F. On Thu, 2011-05-05 at 22:18 +0200, Christian Lippka wrote: This is a patch I have hacked on in my spare time. It replaces the old color picker with a new one. See here for a video demo http://youtu.be/rPu6EmIxkIM?hd=1 To see it in the running office you can for example go to menu tools-options-colors and press edit The dialog is implemented as a service so it is usable from extensions. here is the patch http://dl.dropbox.com/u/10629960/patch.txt The patch is against an OOo DEV300 m102, so there may be conflicts. There is one binary included in the patch, which looks like a git patch can handle. If not, here is the image http://dl.dropbox.com/u/10629960/colorslider.png It should be placed in default_images/res My changes and new code are MPL 1.1 / GPLv3+ / LGPLv3+ licensed. To any reviewers. The code in the new dialog may look a bit complicated at places. There where two difficulties in this feature causing this. First, the rendering of the color field at the left and the color slider on the right where a huge performance problem in my first implementation. So I did some loop unrolling and lookup table stuff to make it usable. Second problem are rounding errors when converting between different color spaces. Therefore the rgb color is saved as doubles and some care has been taken that the conversion is not jittering. I'm hanging around on IRC with nick cl sometimes if there are merge conflicts or build trouble on a different platform then windows. Christian. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] new color picker dialog for all applications
On Thu, 2011-05-05 at 22:18 +0200, Christian Lippka wrote: This is a patch I have hacked on in my spare time. Really pretty :-) It replaces the old color picker with a new one. See here for a video demo I guess it would be wonderful to bring this closer to people editing documents; I've always been frustrated by the lack of flexibility and usability in the Format-Character-Font Effects-Font Color drop-down (and equivalent toolbar / quick pallete). Do you have plans to make these more easily extensible with custom colours ? Then again, perhaps it is a feature that we have a great list of colors in there, that are hard to select and edit ;-) I'm hanging around on IRC with nick cl sometimes if there are merge conflicts or build trouble on a different platform then windows. Fantastic to have you working on this :-) looking forward to whatever is next. Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] new color picker dialog for all applications
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 06/05/2011 10:35, Michael Meeks a écrit : It replaces the old color picker with a new one. See here for a video demo I guess it would be wonderful to bring this closer to people editing documents; I've always been frustrated by the lack of flexibility and usability in the Format-Character-Font Effects-Font Color drop-down (and equivalent toolbar / quick pallete). Great work ! But, don't forget that is more diffcult to retrieve twice the same color with this picker. With the old picker, there are predefined colors and it's easy to retrieve a color already used on the document because predefined colors are limited to ~50 colors. With the new picker, colors are not limited and we should know parameters of the color (RGB...) to retrieve the same color. There will cool to have a table of used colors on the same document to retrieve more easily colors already used on the document when he search a color. Best regards, Quentin THEURET quen...@theuret.net 06 33 23 20 84 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk3DtgsACgkQJiXrGwhvlZ+a5gCfWjerrUnwR/kgZYehD4PvrRs3 F/wAn0yU6m0zErucUHtOxJ1+PDu3KQyC =/q83 -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] new color picker dialog for all applications
Hi Christian, great to have you here! Christian Lippka schrieb: This is a patch I have hacked on in my spare time. It replaces the old color picker with a new one. See here for a video demo http://youtu.be/rPu6EmIxkIM?hd=1 To see it in the running office you can for example go to menu tools-options-colors and press edit So it's only meant as color picker to define a new standard color? This would be a great improvement over the present menu and There are just a few questions open I can't understand from your video: When clicking on the round button at the side of the RGB and HSB values (do you want to add this for CMYK too?) it seems that this keeps the entry constant during selection of any point in the large color field. When you move the focus on the small color bar at the side of the color area the fixed values seem to move. Do you want to add a description to these buttons (or did you already) to explain to the user what happens when he clicks on them? By the way: Did we already implement any bugzilla keyword or wiki page pointing documentation team (including help creators) and UX to areas they should know of? Best regards Bernhard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
