Re: [Libreoffice] [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

[Joachim Trémouroux]

Pierre-André,

Are you sure it is safe to remove the OpenFlagRec() call ?

diff --git a/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
b/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
index b0a286b..e2453f4 100644
--- a/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
+++ b/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
@@ -97,8 +97,6 @@ namespace binfilter {
 /*N*/ {
 /*N*/ OpenRec( SWG_REDLINEDATA_LCL );
 /*N*/
-/*N*/ BYTE cDFlags = OpenFlagRec();
-/*N*/
 /*N*/ BYTE cType;
 /*N*/ UINT16 nStrIdx;
 /*N*/
@@ -106,10 +104,10 @@ namespace binfilter {
 /*N*/  nStrIdx;
 /*N*/ CloseFlagRec();
 /*N*/


Regards,
Joachim.


Le 26 novembre 2010 07:56, Pierre-André Jacquod pjacq...@alumni.ethz.ch a
écrit :

 regards


 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

[Pierre-André Jacquod]

regards

From 84e58630f70dc34f71ee34419d9843980b14b723 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch
Date: Thu, 25 Nov 2010 20:18:10 +0100
Subject: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

shadowing warning and unused parameters
---
 binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx |   11 ---
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx b/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
index b0a286b..e2453f4 100644
--- a/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
+++ b/binfilter/bf_sw/source/core/sw3io/sw_sw3redln.cxx
@@ -97,8 +97,6 @@ namespace binfilter {
 /*N*/ 	{
 /*N*/ 		OpenRec( SWG_REDLINEDATA_LCL );
 /*N*/ 
-/*N*/ 		BYTE cDFlags = OpenFlagRec();
-/*N*/ 
 /*N*/ 		BYTE cType;
 /*N*/ 		UINT16 nStrIdx;
 /*N*/ 
@@ -106,10 +104,10 @@ namespace binfilter {
 /*N*/  nStrIdx;
 /*N*/ 		CloseFlagRec();
 /*N*/ 
-/*N*/ 		UINT32 nDate, nTime;
+/*N*/ 		UINT32 nDate2, nTime2;
 /*N*/ 		String aComment;
-/*N*/ 		*pStrm 	 nDate
-/*N*/  nTime;
+/*N*/ 		*pStrm 	 nDate2
+/*N*/  nTime2;
 /*N*/ 		InString( *pStrm, aComment );
 /*N*/ 
 /*N*/ 		// Das oberste Element des Stack wurde als letztes geschrieben.
@@ -120,7 +118,7 @@ namespace binfilter {
 /*N*/ 			nAuthorIdx = pDoc-GetRedlineAuthor();
 /*N*/ 
 /*N*/ 		pData =	new SwRedlineData( (SwRedlineType)cType, nAuthorIdx,
-/*N*/    DateTime( nDate, nTime ), aComment,
+/*N*/    DateTime( nDate2, nTime2 ), aComment,
 /*N*/    pData );
 /*N*/ 
 /*N*/ 		CloseRec( SWG_REDLINEDATA_LCL );
@@ -128,7 +126,6 @@ namespace binfilter {
 /*N*/ 
 /*N*/ 	// Der PaM ist erstmal egal und wird erst spaeter gesetzt
 /*N*/ 	SwPosition aDummyPos( pDoc-GetNodes().GetEndOfExtras() );
-/*N*/ 	BOOL bVisible = (cFlags  0x10) != 0;
 /*N*/ 	SwRedline *pRedline =
 /*N*/ 		new SwRedline( pData, aDummyPos, (cFlags  0x10) != 0,
 /*N*/ 	   (cFlags  0x20) != 0, (cFlags  0x40) != 0 );
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice