[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/vbahelper
On Sun, 2010-11-21 at 21:35 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/vbahelper Julien. Reviewed the vbahelper patch, looks good. Pushed this, thanks for you efforts. btw, when you're sending these patches, you're including the content of previous patches in there as well, rather than just the extra new bit. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers
On Fri, 2010-11-19 at 22:53 +0100, Julien Nabet wrote: Hello, Here's patch for the last changes to do that I've seen in libs-core/connectivity/drivers -(::rtl::OUString::createFromAscii( i18n(Address Book) )); +(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n(Address Book)) )); Hmm, what's i18n in this context, I can't seem to see a define or function called i18n. Is that a KDE/QT thing, if its e.g. a function that returns a char * then it might not be a safe change, while if its a define, then depending on what it does it might be ok. -m_sMozillaURI = rtl::OUString::createFromAscii( getSchemeURI( SCHEME_MOZILLA ) ); +m_sMozillaURI = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( getSchemeURI( SCHEME_MOZILLA )) ); is definitely not safe here. The RTL_CONSTASCII_USTRINGPARAM does a sizeof on its arg, so it should only be passed a string literal or array, not a char*. Otherwise, it looks good, so pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core
On Fri, 2010-11-19 at 23:23 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core Looks good, top part was duplicate of previous patch. So pushed the extra bits. Thanks for this. When I see an empty sting being created, e.g. OUString::createFromAscii() best to just replace it with the default ctor of OUString() as better style. So I made that change while I was at it. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/fpicker
On Sat, 2010-11-20 at 17:50 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/fpicker Looks all good. Thanks for this. I did leave out the changes inside the VISTAFILEDIALOG_CHECKED_COMCALL macro. as its inside a define where the parameter is passed into it, so it can't be guaranteed to be a literal. As an aside though, nothing in LibreOffice itself appears to use VISTAFILEDIALOG_CHECKED_COMCALL, so I wonder if it can be removed entirely. Though maybe VISTAFILEDIALOG_CHECKED_COMCALL called via some other strange windows programming specific magic. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers
On Sun, 2010-11-21 at 02:36 +0900, Takeshi Abe wrote: Both versions of i18n return a QString. Thanks. Yeah, and with an operator to convert to const char*, not a candidate for RTL_CONSTASCII_USTRINGPARAM then. The check I have in the rostrings branch would catch that when integrated once I figure out how to convert from the older sgi std::identity to the new c++0x std::identity thing. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/embeddedobj
On Sat, 2010-11-20 at 13:47 +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/embeddedobj Thanks for this. Pushed. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
