[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara 
On Fri, 2010-11-19 at 22:53 +0100, Julien Nabet wrote:
 Hello,
 
 Here's patch for the last changes to do that I've seen in 
 libs-core/connectivity/drivers

-(::rtl::OUString::createFromAscii( i18n(Address Book) ));
+(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( i18n(Address
Book)) ));

Hmm, what's i18n in this context, I can't seem to see a define or
function called i18n. Is that a KDE/QT thing, if its e.g. a function
that returns a char * then it might not be a safe change, while if its a
define, then depending on what it does it might be ok.


-m_sMozillaURI =
rtl::OUString::createFromAscii( getSchemeURI( SCHEME_MOZILLA ) );
+m_sMozillaURI =
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( getSchemeURI( SCHEME_MOZILLA )) );

is definitely not safe here. The RTL_CONSTASCII_USTRINGPARAM does a
sizeof on its arg, so it should only be passed a string literal or
array, not a char*.

Otherwise, it looks good, so pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/drivers

2010-11-20 Thread Caolán McNamara 
On Sun, 2010-11-21 at 02:36 +0900, Takeshi Abe wrote:
 Both versions of i18n return a QString.

Thanks. Yeah, and with an operator to convert to const char*, not a
candidate for RTL_CONSTASCII_USTRINGPARAM then. The check I have in the
rostrings branch would catch that when integrated once I figure out how
to convert from the older sgi std::identity to the new c++0x
std::identity thing.

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice