Re: [Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes

2011-04-21 Thread Korrawit Pruegsanusak
Hello Robert,

On Thu, Apr 21, 2011 at 05:42, Robert Dargaud  wrote:
> Hi Michael,
>
> Yes, I found the patch, but not the origin of deletion of this line in the
> history !
> What tool can be used to find easily history for each line ?
>

Would you mind if I answer this instead of Michael? ;)
I used 'Annotate' tools at http://opengrok.libreoffice.org/
which probably equals to git blame or git annotate.
But since that line was deleted, the annotation didn't show up,
already explained in this git manual:
http://www.kernel.org/pub/software/scm/git/docs/git-blame.html

Best Regards
--
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes

2011-04-20 Thread Robert Dargaud

Hi Michael,

Le 20/04/11 15:44, Michael Meeks a écrit :

[...]

It's very strange than this line was deleted ! I try to find the origine
of this delete with "qgit" and "gitk". But I can't find it !

It seems you found it, and it was an error; nice work.


Yes, I found the patch, but not the origin of deletion of this line in 
the history !

What tool can be used to find easily history for each line ?


I've pushed the patch to master, and will merge it to libreoffice-3-4 -
what's next ? :-)

This one ;-)
https://bugs.freedesktop.org/show_bug.cgi?id=36404

Best regard

Bob

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes

2011-04-20 Thread Michael Meeks

On Wed, 2011-04-20 at 21:04 +0700, Korrawit Pruegsanusak wrote:
> May we close this fdo#36399 bug then?

Indeedie - always worth closing it if it got fixed; I just did that
myself :-)

Thanks guys,

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes

2011-04-20 Thread Korrawit Pruegsanusak
Hello all
May we close this fdo#36399 bug then?
Best Regards
--
Korrawit Pruegsanusak




On Wed, Apr 20, 2011 at 20:44, Michael Meeks  wrote:
> Hi Robert,
>
> On Wed, 2011-04-20 at 00:44 +0200, Robert Dargaud wrote:
>> Last week, my answer was "no". But this evening, after many printf, it's
>> "yes" I've a patch who fixe this bug ;-)
>
>        Nice ! :-)
>
>> It's very strange than this line was deleted ! I try to find the origine
>> of this delete with "qgit" and "gitk". But I can't find it !
>
>        It seems you found it, and it was an error; nice work.
>
>        I've pushed the patch to master, and will merge it to libreoffice-3-4 -
> what's next ? :-)
>
>        Thanks !
>
>                Michael.
>
> --
>  michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot
>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PUSHED] fix fdo#36399 - ScrollBar display bug on dialog boxes

2011-04-20 Thread Michael Meeks
Hi Robert,

On Wed, 2011-04-20 at 00:44 +0200, Robert Dargaud wrote:
> Last week, my answer was "no". But this evening, after many printf, it's 
> "yes" I've a patch who fixe this bug ;-)

Nice ! :-)

> It's very strange than this line was deleted ! I try to find the origine 
> of this delete with "qgit" and "gitk". But I can't find it !

It seems you found it, and it was an error; nice work.

I've pushed the patch to master, and will merge it to libreoffice-3-4 -
what's next ? :-)

Thanks !

Michael.

-- 
 michael.me...@novell.com  <><, Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice