[Libreoffice] [PUSHED] Remove dead codes and undesired comments with fixed typo

2010-11-26 Thread Michael Meeks 
Hi Takeshi,

On Fri, 2010-11-26 at 01:48 +0900, Takeshi Abe wrote:
 yet another cleanup on base.

Great to see you fixing English spellings :-)

  switch( nColId )
  {
  //
 -// NameCell
 -case FIELD_NAME:
 -{
 -// removed the former duplicate-check. this is done in 
 OTableDocShell::CheckDefConsistency now.
 -// FS - 07.12.99 - 69575
 -
 -} break;

By removing this case statement, we could change the control flow of
course - so FIELD_NAME will go through to a default statement, but in
this case - the is none - so it's fine :-)


  case FIELD_PROPERTY_NUMTYPE:
  OSL_ENSURE(sal_False, OTableEditorCtrl::GetCellData: invalid 
 column!);
 -//   return pFieldDescr-GetNumType();
 +break;

This again looks like an inadvertent drop-through; though presumably
~never called.
 
 -} // if(!_bSet  _pFieldDesc-getTypeInfo()-bNullable)
 +}

Odd isn't it :-)

This is some lovely work - thanks !

Pushed,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments

2010-11-22 Thread David Tardon 
On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote:
 Hi,
 
 Easy Hacks on base, some of indentions are left unchanged for clarity.
 

Thanks! I pushed it except one hunk containing the magical word TODO :)

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice