Re: [Libreoffice] [Partly pushed] Easy Hack completed - All bogus comments removed
Hi Cédric,
I think it's done. :-) The big one is in bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=36234
All bogus comments removed keeping the indentation, the bug id and the
remainder comment in the same line of the pattern. The next patch will
remove the trash in that replacement, e.g. empty comments, closure of SCM
comments // <--, etc.
Under the LGPLv3+ / MPL license.
Regards,
Júlio.
P.S.: If you want something more, just let me know!
From 4ea8dd2b6430a995ed9f48d855b02bd5dd2d40fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=BAlio=20Hoffimann?=
Date: Sat, 16 Apr 2011 22:39:51 -0300
Subject: [PATCH] all bogus comments removed keeping the indentation
---
cui/source/inc/border.hxx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cui/source/inc/border.hxx b/cui/source/inc/border.hxx
index 51ff23a..eccfed5 100644
--- a/cui/source/inc/border.hxx
+++ b/cui/source/inc/border.hxx
@@ -110,7 +110,7 @@ private:
//properties - "Merge with next paragraph" in Writer
FixedLine aPropertiesFL;
CheckBoxaMergeWithNextCB;
-// --> collapsing table borders #i29550#
+// #i29550#
CheckBoxaMergeAdjacentBordersCB;
// <--
--
1.7.0.4
From ccdc61f334845566e79dfdcf58458e91c478d373 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=BAlio=20Hoffimann?=
Date: Sat, 16 Apr 2011 22:41:35 -0300
Subject: [PATCH] all bogus comments removed keeping the indentation
---
xmloff/source/draw/ximpshap.cxx |2 +-
xmloff/source/text/txtimp.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx
index c699a03..8280ccd 100644
--- a/xmloff/source/draw/ximpshap.cxx
+++ b/xmloff/source/draw/ximpshap.cxx
@@ -1927,7 +1927,7 @@ void SdXMLConnectorShapeContext::StartElement(const uno::Reference< xml::sax::XA
if ( maPath.hasValue() )
{
-// --> OD #i115492#
+// #i115492#
// Ignore svg:d attribute for text documents created by OpenOffice.org
// versions before OOo 3.3, because these OOo versions are storing
// svg:d values not using the correct unit.
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 1c1e90f..be7bcd1 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -149,7 +149,7 @@ static SvXMLTokenMapEntry aTextElemTokenMap[] =
{ XML_NAMESPACE_OFFICE, XML_FORMS, XML_TOK_TEXT_FORMS },
{ XML_NAMESPACE_TABLE, XML_CALCULATION_SETTINGS, XML_TOK_TEXT_CALCULATION_SETTINGS },
{ XML_NAMESPACE_TEXT, XML_ALPHABETICAL_INDEX_AUTO_MARK_FILE, XML_TOK_TEXT_AUTOMARK },
-// --> FLR #i52127#
+// #i52127#
{ XML_NAMESPACE_TEXT, XML_NUMBERED_PARAGRAPH, XML_TOK_TEXT_NUMBERED_PARAGRAPH },
// <--
--
1.7.0.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Partly pushed] Easy Hack completed - All bogus comments removed
Ok Cedric, no problem. I will fix these problems. Thank you for return. Regards, Júlio. 2011/4/15 Cedric Bosdonnat > Hi Julio, > > Many thanks for your patches nice patches. I think we'll manage to > eradicate loads of useless comments this way ;) > > I pushed both patches in libs-gui and libs-core after some manual edits, > but it takes too much time to manually adjust the patch for sw. Could > you please adjust your regexps to fix the following problems: > * comments indentation is reduced to 4 spaces in all cases: you should > keep the number of existing leading spaces to avoid breaking the > indentation > * #b[0-9]\+# comments should be purely removed: we don't need them as > they refer to some Oracle internal bug database. Please pay attention > here ase you may have #b...# and #i# references on the same line > * you often have some comment after the bug number, please keep them. > Some could be removed, but not all. > * While at it, could you remove the lines with comments like '// <--' > as those are the "closing" comments for the other silly SCM-like > comments? > > Don't forget to check your patch after running your regexps as you may > have other unexpected cases. > > Regards, > > On Thu, 2011-04-14 at 19:26 -0300, Júlio Hoffimann wrote: > > I forget to mention... > > > > > > This patch is under the LGPLv3+ / MPL license. > > > > 2011/4/14 Júlio Hoffimann > > ... and the last and big one. ;-) > > > > > > https://bugs.freedesktop.org/show_bug.cgi?id=36234 > > > > > > Regards, > > Júlio. > > > > > > > > > > ___ > > LibreOffice mailing list > > LibreOffice@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/libreoffice > > -- > Cédric Bosdonnat > LibreOffice hacker > http://documentfoundation.org > OOo Eclipse Integration developer > http://cedric.bosdonnat.free.fr > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Partly pushed] Easy Hack completed - All bogus comments removed
Hi Julio, Many thanks for your patches nice patches. I think we'll manage to eradicate loads of useless comments this way ;) I pushed both patches in libs-gui and libs-core after some manual edits, but it takes too much time to manually adjust the patch for sw. Could you please adjust your regexps to fix the following problems: * comments indentation is reduced to 4 spaces in all cases: you should keep the number of existing leading spaces to avoid breaking the indentation * #b[0-9]\+# comments should be purely removed: we don't need them as they refer to some Oracle internal bug database. Please pay attention here ase you may have #b...# and #i# references on the same line * you often have some comment after the bug number, please keep them. Some could be removed, but not all. * While at it, could you remove the lines with comments like '// <--' as those are the "closing" comments for the other silly SCM-like comments? Don't forget to check your patch after running your regexps as you may have other unexpected cases. Regards, On Thu, 2011-04-14 at 19:26 -0300, Júlio Hoffimann wrote: > I forget to mention... > > > This patch is under the LGPLv3+ / MPL license. > > 2011/4/14 Júlio Hoffimann > ... and the last and big one. ;-) > > > https://bugs.freedesktop.org/show_bug.cgi?id=36234 > > > Regards, > Júlio. > > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
