Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
I agree, Markus please apply for commit access ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
On Fri, 2011-04-29 at 13:15 +0200, Markus Mohrhard wrote: > > I saw one minor issue though. When I defined a global range > name > (Insert -> Names -> Define) and saved as Excel 2007 xlsx > format, Excel > 2007 opened the file but said that the content of defined name > was > unreadable & must be repaired. Could you perhaps look into > this? > > > Has been fixed with the help of Katarina. See patch > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=68206b17395af00991e9c7468269d79a9f4fee35 > > The relevant lines were removed by accident. Thank you both for > spotting and helping to fix it. Thanks for the quick fix! BTW, Markus. Please consider applying for git access to our repository. I think you deserve it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
> I saw one minor issue though. When I defined a global range name
> (Insert -> Names -> Define) and saved as Excel 2007 xlsx format, Excel
> 2007 opened the file but said that the content of defined name was
> unreadable & must be repaired. Could you perhaps look into this?
Just for the record, we found the issue with Marcus (moggi) -- a piece of code
assigning the value into msSymbol ('Sheet1!$so$me:$ran$ge') was removed in the
original patch by mistake, and with undefined value, Calc produced something
like this:
which is certainly not a valid piece of OOXML. After re-introducing the code,
all works again. Pushed the fix to master
B.
--
\ Katarina Machalkova
\\\__o LibO developer
__\\\'/_ & hedgehog painter
signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
2011/4/29 Kohei Yoshida > On Fri, 2011-04-29 at 01:46 +0200, Markus Mohrhard wrote: > > Hello, > > > > > > > > this patch allows to export the sheet local anonymous db data to > > OOXML. The export of named db data is no longer supported with this > > patch because Excel only supports the concept of one sheet local > > anonymous db data(named ranges are still supported). > > > > > > Additionally this patch fixes several issues around the export of > > built-in defined names. > > > > > > I tested the export of autofilter to binary excel format and OOXML and > > excel could read both files. > > Looks good. Pushed to master. > > I saw one minor issue though. When I defined a global range name > (Insert -> Names -> Define) and saved as Excel 2007 xlsx format, Excel > 2007 opened the file but said that the content of defined name was > unreadable & must be repaired. Could you perhaps look into this? > > Has been fixed with the help of Katarina. See patch http://cgit.freedesktop.org/libreoffice/calc/commit/?id=68206b17395af00991e9c7468269d79a9f4fee35 The relevant lines were removed by accident. Thank you both for spotting and helping to fix it. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] [PUSHED] Support export of anonymous db data to OOXML
On Fri, 2011-04-29 at 01:46 +0200, Markus Mohrhard wrote: > Hello, > > > > this patch allows to export the sheet local anonymous db data to > OOXML. The export of named db data is no longer supported with this > patch because Excel only supports the concept of one sheet local > anonymous db data(named ranges are still supported). > > > Additionally this patch fixes several issues around the export of > built-in defined names. > > > I tested the export of autofilter to binary excel format and OOXML and > excel could read both files. Looks good. Pushed to master. I saw one minor issue though. When I defined a global range name (Insert -> Names -> Define) and saved as Excel 2007 xlsx format, Excel 2007 opened the file but said that the content of defined name was unreadable & must be repaired. Could you perhaps look into this? The xls binary export worked fine. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
