Re: [Libreoffice] [Patch] Remove OOoImprovement
On 12/18/2011 08:40 PM, Stefan Knorr (Astron) wrote: By the way: is the gbuild conversion project removing some of the basis for this feature or did I misunderstand that? It is getting rid of testtool that removes a feature introduced by testtool and reused by oooimprovement. The removal of that feature renders oooimprovement non-functional, so it was decided to remove oooimprovement along with testtool. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Remove OOoImprovement
On Sun, 2011-12-18 at 20:40 +0100, Stefan Knorr (Astron) wrote: > Here's an idea: building the server side for this should be a > medium-size task that is also separate from most of LibO and requires > lots of new code, so wouldn't this be ideal as a GSoC task? Sounds like a good idea to me; I'd be happy to mentor it with someone else. > By the way: is the gbuild conversion project removing some of the > basis for this feature or did I misunderstand that? That's rather orthogonal - it's 'just' substantially improving how we build the code :-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Remove OOoImprovement
Hi everyone, > Yep - it's a nice feature to keep, for sure - if we have the > infrastructure to back it up. Then again - we can resurrect and port the > client code (I suspect) as/when/if we have someone to admin the server > side if it is too much of a pain to maintain now. Here's an idea: building the server side for this should be a medium-size task that is also separate from most of LibO and requires lots of new code, so wouldn't this be ideal as a GSoC task? Astron. By the way: is the gbuild conversion project removing some of the basis for this feature or did I misunderstand that? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Remove OOoImprovement
On Fri, 2011-12-16 at 12:22 +0100, Christoph Noack wrote: > I'm not fully sure whether you refer to the OpenOffice.org improvement > program. If yes, then this issue had been discussed some months ago. I > also had some discussions with others (e.g. with Michael at the > LibOConf) how to get that back working. Yep - it's a nice feature to keep, for sure - if we have the infrastructure to back it up. Then again - we can resurrect and port the client code (I suspect) as/when/if we have someone to admin the server side if it is too much of a pain to maintain now. Thanks for catching this. ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Remove OOoImprovement
On Fri, 2011-12-16 at 00:20 -0500, August Sodora wrote: > somebody mind reviewing/pushing this? I was forced to upgrade and am > still waiting for my gpg key to be changed. Oh ! you filed a sysadmin bug vs. freedesktop for that ? if so you want to poke me privately with the bug # to expidite it ;-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Remove OOoImprovement
Hi all, I'm not fully sure whether you refer to the OpenOffice.org improvement program. If yes, then this issue had been discussed some months ago. I also had some discussions with others (e.g. with Michael at the LibOConf) how to get that back working. Here is one of the mails: http://lists.freedesktop.org/archives/libreoffice/2011-January/006178.html Cheers, Christoph PS: I'm currently 99,9% offline due to personal stuff, so (if anybody cares) sorry for not replying (also) on the other lists :-\ Am Freitag, den 16.12.2011, 00:20 -0500 schrieb August Sodora: > Hello, > > I realized there were still a few things left over from the testtool > removal so I created the attached patch. There seem to be some > logging-related things left in comphelper and officecfg that are used > all over the place but I'm not 100% sure about them yet. Would > somebody mind reviewing/pushing this? I was forced to upgrade and am > still waiting for my gpg key to be changed. > > August Sodora > aug...@gmail.com > (201) 280-8138 > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Patch] Remove OOoImprovement
Hello, I realized there were still a few things left over from the testtool removal so I created the attached patch. There seem to be some logging-related things left in comphelper and officecfg that are used all over the place but I'm not 100% sure about them yet. Would somebody mind reviewing/pushing this? I was forced to upgrade and am still waiting for my gpg key to be changed. August Sodora aug...@gmail.com (201) 280-8138 From 9a660bb921402e6ef1f70101af7024f2b08529dc Mon Sep 17 00:00:00 2001 From: August Sodora Date: Thu, 15 Dec 2011 00:00:07 -0500 Subject: [PATCH 1/2] Remove OOoImprovement --- officecfg/Configuration_officecfg.mk |1 - officecfg/qa/cppheader.cxx |1 - officecfg/registry/Makefile|1 - officecfg/registry/files.mk|1 - .../schema/org/openoffice/Office/Logging.xcs | 27 -- .../openoffice/Office/OOoImprovement/Settings.xcs | 98 postprocess/packregistry/makefile.mk |1 - scp2/source/ooo/common_brand.scp |5 - 8 files changed, 0 insertions(+), 135 deletions(-) delete mode 100644 officecfg/registry/schema/org/openoffice/Office/OOoImprovement/Settings.xcs diff --git a/officecfg/Configuration_officecfg.mk b/officecfg/Configuration_officecfg.mk index 0b0a8b0..3d7f8d2 100644 --- a/officecfg/Configuration_officecfg.mk +++ b/officecfg/Configuration_officecfg.mk @@ -108,7 +108,6 @@ $(eval $(call gb_Configuration_add_schemas,registry,officecfg/registry/schema,\ org/openoffice/Office/UI/GlobalSettings.xcs \ org/openoffice/Office/UI/WindowContentFactories.xcs \ org/openoffice/Office/DataAccess/Drivers.xcs \ - org/openoffice/Office/OOoImprovement/Settings.xcs \ org/openoffice/TypeDetection/Types.xcs \ org/openoffice/TypeDetection/Filter.xcs \ org/openoffice/TypeDetection/GraphicFilter.xcs \ diff --git a/officecfg/qa/cppheader.cxx b/officecfg/qa/cppheader.cxx index 12042ca..2dac76d 100644 --- a/officecfg/qa/cppheader.cxx +++ b/officecfg/qa/cppheader.cxx @@ -66,7 +66,6 @@ #include "officecfg/Office/Linguistic.hxx" #include "officecfg/Office/Logging.hxx" #include "officecfg/Office/Math.hxx" -#include "officecfg/Office/OOoImprovement/Settings.hxx" #include "officecfg/Office/OptionsDialog.hxx" #include "officecfg/Office/Paths.hxx" #include "officecfg/Office/ProtocolHandler.hxx" diff --git a/officecfg/registry/Makefile b/officecfg/registry/Makefile index edb80b0..0810755 100644 --- a/officecfg/registry/Makefile +++ b/officecfg/registry/Makefile @@ -52,7 +52,6 @@ endef # appears to let % span sub-directories, so that the above rule would produce # unexpected results; sorting this way seems to avoid the problem: $(eval $(call my_target,Office,DataAccess)) -$(eval $(call my_target,Office,OOoImprovement)) $(eval $(call my_target,Office,UI)) $(eval $(call my_target,Office)) $(eval $(call my_target,TypeDetection)) diff --git a/officecfg/registry/files.mk b/officecfg/registry/files.mk index f4c72d7..c6cebcf 100644 --- a/officecfg/registry/files.mk +++ b/officecfg/registry/files.mk @@ -28,7 +28,6 @@ FILES = \ Office/Linguistic \ Office/Logging \ Office/Math \ -Office/OOoImprovement/Settings \ Office/OptionsDialog \ Office/Paths \ Office/ProtocolHandler \ diff --git a/officecfg/registry/schema/org/openoffice/Office/Logging.xcs b/officecfg/registry/schema/org/openoffice/Office/Logging.xcs index 2fda9ea..4e8426e 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Logging.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Logging.xcs @@ -79,33 +79,6 @@ - - - b_michaelsen -specifies settings for the logging of userinterface events. - - - - only if this is true, usage tracking is allowed and its options will be shown - - -false - - - - directory where the logs will get saved - - -$(user)/temp/Feedback - - - - idle time in minutes. If two log event are separated by a longer - time, the log will be rotated. - -180 - - contains the settings for all known loggers in OpenOffice.org. diff --git a/officecfg/registry/schema/org/openoffice/Office/OOoImprovement/Settings.xcs b/officecfg/registry/schema/org/openoffice/Office/OOoImprovement/Settings.xcs deleted file mode 100644 index a4339cc..000 --- a/officecfg/registry/schema/org/openoffice/Office/OOoImprovement/Settings.xcs +++ /dev/null @@ -1,98 +0,0 @@ - -http://openoffice.org/2001/registry"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; oor:name="Settings" oor:package="org.openoffice.Office.OOoImprovement" xml:lang="en-US"> - -Contains preferences for the OpenOffice.org Improvement Program components. - - - - - -
