Re: [Libreoffice] [Patch] Remove some dead code in sc

2011-01-15 Thread Caolán McNamara
On Sat, 2011-01-15 at 01:01 +0100, Julien Nabet wrote:
> Here is a small patch for dead code cleaning on sc

Looks good, pushed, thanks for this.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [Patch] Remove some dead code in sc

2011-01-14 Thread Julien Nabet

Hello,

Here is a small patch for dead code cleaning on sc

(LGPLv3+ / MPL)

Julien
commit 70660374dc7702e77d8089b8253cfdf39c651411
Author: serval 
Date:   Sat Jan 15 01:00:00 2011 +0100

Remove some dead code

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 9e92ac8..733964a 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -89,7 +89,6 @@
 
 // Abstand zur naechsten Zelle beim Loeschen (bShrink), damit der Anker
 // immer an der richtigen Zelle angezeigt wird
-//#define SHRINK_DIST  3
 // und noch etwas mehr, damit das Objekt auch sichtbar in der Zelle liegt
 #define SHRINK_DIST25
 
diff --git a/sc/source/core/tool/chartlis.cxx b/sc/source/core/tool/chartlis.cxx
index 095fdbd..45ca915 100644
--- a/sc/source/core/tool/chartlis.cxx
+++ b/sc/source/core/tool/chartlis.cxx
@@ -46,9 +46,6 @@ using ::std::auto_ptr;
 using ::std::unary_function;
 using ::std::for_each;
 
-//2do: DocOption TimeOut?
-//#define SC_CHARTTIMEOUT 1000 // eine Sekunde keine Aenderung/KeyEvent
-
 // Update chart listeners quickly, to get a similar behavior to loaded charts
 // which register UNO listeners.
 #define SC_CHARTTIMEOUT 10
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index 7e49aa8..0bbc1f1 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -57,8 +57,6 @@ using namespace formula;
 #define SCdEpsilon1.0E-7
 #define SC_MAX_ITERATION_COUNT20
 #define MAX_ANZ_DOUBLE_FOR_SORT 10
-// PI jetzt als F_PI aus solar.h
-//#define   PI3.1415926535897932
 
 const double ScInterpreter::fMaxGammaArgument = 171.624376956302;  // found 
experimental
 const double fMachEps = ::std::numeric_limits::epsilon();
diff --git a/sc/source/ui/docshell/docsh8.cxx b/sc/source/ui/docshell/docsh8.cxx
index 81887cf..32fec8a 100644
--- a/sc/source/ui/docshell/docsh8.cxx
+++ b/sc/source/ui/docshell/docsh8.cxx
@@ -98,7 +98,6 @@ using ::std::vector;
 #define SC_SERVICE_DRVMAN  
"com.sun.star.sdbc.DriverManager"
 
 //!move to a header file?
-//#define SC_DBPROP_DATASOURCENAME "DataSourceName"
 #define SC_DBPROP_ACTIVECONNECTION "ActiveConnection"
 #define SC_DBPROP_COMMAND  "Command"
 #define SC_DBPROP_COMMANDTYPE  "CommandType"
diff --git a/sc/source/ui/drawfunc/futext2.cxx 
b/sc/source/ui/drawfunc/futext2.cxx
index 0fd5c74..3b2e5ce 100644
--- a/sc/source/ui/drawfunc/futext2.cxx
+++ b/sc/source/ui/drawfunc/futext2.cxx
@@ -42,92 +42,22 @@
 #define _TREELIST_HXX
 #define _CACHESTR_HXX
 #define _NEW_HXX
-//#define _SHL_HXX
-//#define _LINK_HXX
-//#define _ERRCODE_HXX
-//#define _GEN_HXX
-//#define _FRACT_HXX
-//#define _STRING_HXX
-//#define _MTF_HXX
-//#define _CONTNR_HXX
-//#define _LIST_HXX
-//#define _TABLE_HXX
 #define _DYNARY_HXX
-//#define _UNQIDX_HXX
 #define _SVMEMPOOL_HXX
-//#define _UNQID_HXX
-//#define _DEBUG_HXX
-//#define _DATE_HXX
-//#define _TIME_HXX
-//#define _DATETIME_HXX
-//#define _INTN_HXX
-//#define _WLDCRD_HXX
-//#define _FSYS_HXX
-//#define _STREAM_HXX
 #define _CACHESTR_HXX
 #define _SV_MULTISEL_HXX
 
 //SV
-//#define _CLIP_HXX ***
 #define _CONFIG_HXX
 #define _CURSOR_HXX
 #define _FONTDLG_HXX
 #define _PRVWIN_HXX
-//#define _COLOR_HXX
-//#define _PAL_HXX
-//#define _BITMAP_HXX
-//#define _GDIOBJ_HXX
-//#define _POINTR_HXX
-//#define _ICON_HXX
-//#define _IMAGE_HXX
-//#define _KEYCOD_HXX
-//#define _EVENT_HXX
 #define _HELP_HXX
-//#define _APP_HXX
-//#define _MDIAPP_HXX
-//#define _TIMER_HXX
-//#define _METRIC_HXX
-//#define _REGION_HXX
-//#define _OUTDEV_HXX
-//#define _SYSTEM_HXX
-//#define _VIRDEV_HXX
-//#define _JOBSET_HXX
-//#define _PRINT_HXX
-//#define _WINDOW_HXX
-//#define _SYSWIN_HXX
-//#define _WRKWIN_HXX
 #define _MDIWIN_HXX
-//#define _FLOATWIN_HXX
-//#define _DOCKWIN_HXX
-//#define _CTRL_HXX
-//#define _SCRBAR_HXX
-//#define _BUTTON_HXX
-//#define _IMAGEBTN_HXX
-//#define _FIXED_HXX
-//#define _GROUP_HXX
-//#define _EDIT_HXX
-//#define _COMBOBOX_HXX
-//#define _LSTBOX_HXX
-//#define _SELENG_HXX ***
-//#define _SPLIT_HXX
 #define _SPIN_HXX
-//#define _FIELD_HXX
-//#define _MOREBTN_HXX ***
-//#define _TOOLBOX_HXX
 #define _STATUS_HXX
 #define _SVTCTRL3_HXX
-//#define _DIALOG_HXX
-//#define _MSGBOX_HXX
-//#define _SYSDLG_HXX
-//#define _FILDLG_HXX ***
-//#define _PRNDLG_HXX
 #define _COLDLG_HXX
-//#define _TABDLG_HXX
-//#define _MENU_HXX ***
-//#define _GDIMTF_HXX
-//#define _POLY_HXX
-//#define _ACCEL_HXX
-//#define _GRAPH_HXX
 #define _SOUND_HXX
 
 #if defined  WIN
@@ -137,48 +67,28 @@
 //svtools
 #define _SCRWIN_HXX
 #define _RULER_HXX
-//#define _TABBAR_HXX
-//#define _VALUESET_HXX
 #define _STDMENU_HXX
-//#define _STDCTRL_HXX
-//#define _CTRLBOX_HXX
 #define _CTRLTOOL_HXX
 #define _EXTATTR_HXX
 #define _FRM3D_HXX
 #define _EXTATTR_HXX
 
 //SVTOOLS
-//#define _SVTREELIST_HXX
 #define _FILTER_HXX
-//#define _SVLBOXITM_HXX
-//#define _SVTREEBO