Re: [Libreoffice] [REVIEW] ugly diplay of toolbar menus in fontwork toolbar

2011-02-11 Thread Caolán McNamara
On Mon, 2011-02-07 at 11:40 +0100, Cedric Bosdonnat wrote:
> Hello people,
> 
> Since I fixed the toolbar menus on the fontwork toolbar, I saw that one
> of them as pretty badly shaped. The spacing menu was writing the text of
> the items over the controls that were supposed to be displayed on the
> left of it.
> 
> Could anyone review this commit, sign it off and cherry-pick to 3.3

Yeah, this looks good. Got a little side-tracked because fontwork wasn't
working at all in master (see the hash foo mail). I did in master expand
the space between checkbox and text to the same amount that vcl uses.

I cherry-picked the basic change to not overwrite the text onto the
checkbox for 3-3, though not for 3-3-1.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [REVIEW] ugly diplay of toolbar menus in fontwork toolbar

2011-02-07 Thread Cedric Bosdonnat
Hello people,

Since I fixed the toolbar menus on the fontwork toolbar, I saw that one
of them as pretty badly shaped. The spacing menu was writing the text of
the items over the controls that were supposed to be displayed on the
left of it.

Could anyone review this commit, sign it off and cherry-pick to 3.3
branch?

http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=560ee224078b7b153c8acf305d5e3387dc46bcbc

Regards,

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice