Re: [Libreoffice] [PATCH] Display non printable characters on the end of line
Hi Bartosz, On 2011-05-01 at 18:09 +0200, Bartosz wrote: My name is Bartosz Kosiorek and I have already pushed ruler patch for LibreOffice/OpenOffice: http://openoffice.org/bugzilla/show_bug.cgi?id=84723 I see - great stuff! :-) and very annoying crash, during the replacing of moldy svarray to STD to OpenOffice. Maybe it should be also pushed to LibreOffice? http://openoffice.org/bugzilla/show_bug.cgi?id=84159 http://www.openoffice.org/issues/show_bug.cgi?id=112395 All changes is available at svarray CWS: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fsvarray Is it possible to push this CWS into LibreOffice (this CWS needs some improvements (i115684 and http://openoffice.org/bugzilla/show_bug.cgi?id=112395#c31) ? I could help to move this patch into LibreOffice. Yes, indeed we can push it to LibreOffice. The best is if you can mail here the patches, ideally as an output of git format-patch, see: http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline#How_to_submit_a_patch [again with note that it is licensed LGPL3+ / MPL.] Please make sure that you set your name and email address using git config before you commit locally (like eg. git config --global user.name Bartosz Kosiorek ; git --global config user.email gan...@o2.pl). Now I created patch for display spaces at the end of the line: https://bugs.freedesktop.org/show_bug.cgi?id=33167 With that patch editing the non printable characters is much easier/better that before. Feel free to test and comment it. Really thanks for that! I am sure you'll hear feedback (or a note that it has been pushed) today. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Display non printable characters on the end of line
Hi Bartosz, Kendy, On Mon, 2011-05-02 at 10:20 +0200, Jan Holesovsky wrote: On 2011-05-01 at 18:09 +0200, Bartosz wrote: My name is Bartosz Kosiorek and I have already pushed ruler patch for LibreOffice/OpenOffice: http://openoffice.org/bugzilla/show_bug.cgi?id=84723 Great to have you on board! and very annoying crash, during the replacing of moldy svarray to STD to OpenOffice. Maybe it should be also pushed to LibreOffice? http://openoffice.org/bugzilla/show_bug.cgi?id=84159 http://www.openoffice.org/issues/show_bug.cgi?id=112395 All changes is available at svarray CWS: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fsvarray Is it possible to push this CWS into LibreOffice (this CWS needs some improvements (i115684 and http://openoffice.org/bugzilla/show_bug.cgi?id=112395#c31) ? I could help to move this patch into LibreOffice. It would be great to have that one in :) Now I created patch for display spaces at the end of the line: https://bugs.freedesktop.org/show_bug.cgi?id=33167 With that patch editing the non printable characters is much easier/better that before. Feel free to test and comment it. Really thanks for that! I am sure you'll hear feedback (or a note that it has been pushed) today. The patch look correct to me and I just pushed it. http://cgit.freedesktop.org/libreoffice/writer/commit/?id=4ee4892968d3e42efc03c1158bebfcdd7bb3249e Is there any reason to apply those changes only for Left aligned paragraphs? Couldn't it be useful for other cases? Regards, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Display non printable characters on the end of line
Hi. Wow! - so this is your first contribution to LibreOffice, right? Very nice :-) Cedric - can you please check the patch? Bartosz - can you please provide us with your full name, and also can you confirm that your patch is under LGPLv3+ and MPL? My name is Bartosz Kosiorek and I have already pushed ruler patch for LibreOffice/OpenOffice: http://openoffice.org/bugzilla/show_bug.cgi?id=84723 and very annoying crash, during the replacing of moldy svarray to STD to OpenOffice. Maybe it should be also pushed to LibreOffice? http://openoffice.org/bugzilla/show_bug.cgi?id=84159 http://www.openoffice.org/issues/show_bug.cgi?id=112395 All changes is available at svarray CWS: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fsvarray Is it possible to push this CWS into LibreOffice (this CWS needs some improvements (i115684 and http://openoffice.org/bugzilla/show_bug.cgi?id=112395#c31) ? I could help to move this patch into LibreOffice. Now I created patch for display spaces at the end of the line: https://bugs.freedesktop.org/show_bug.cgi?id=33167 With that patch editing the non printable characters is much easier/better that before. Feel free to test and comment it. All this patches is available under LGPLv3+/MPL. Best Regards Bartosz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Display non printable characters on the end of line
Hi Bartosz, On 2011-04-28 at 14:37 +0200, Bartosz wrote: I have created patch which resolve problem with displaing non printable characters at the end of line: https://bugs.freedesktop.org/attachment.cgi?id=45888 Wow! - so this is your first contribution to LibreOffice, right? Very nice :-) Cedric - can you please check the patch? Bartosz - can you please provide us with your full name, and also can you confirm that your patch is under LGPLv3+ and MPL? Thank you a lot, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Display non printable characters on the end of line
Hi. I have created patch which resolve problem with displaing non printable characters at the end of line: https://bugs.freedesktop.org/attachment.cgi?id=45888 Full bug report: https://bugs.freedesktop.org/show_bug.cgi?id=33167 It works only with left align (the rest aligns was unchanged) One of the most big benefits of blank5.patch, is possible to edit non printable character at the end of line (for example inserting new characters). Here is an screenshot without patch: http://bugzilla-attachments-20878.openoffice.org/bugzilla/attachment.cgi?id=76240 and with patch: http://bugzilla-attachments-20878.openoffice.org/bugzilla/attachment.cgi?id=76239 Could you please take a look at this patch and then push it to LibreOffice? Best Regards Bartosz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
