Re: [Libreoffice] Callcatch ScAttrArray::HasLines

2010-12-10 Thread Julien Nabet 

Le 10/12/2010 22:13, Julien Nabet a écrit :

Hello,

The function ScAttrArray::HasLines is called in the file 
sc/source/core/data/column2.cxx (line 1246).
BOOL ScColumn::IsEmptyBlock(SCROW nStartRow, SCROW nEndRow, bool 
bIgnoreNotes) const

{
Rectangle aRect;
if (pAttrArray->HasLines(nStartRow, nEndRow, aRect, TRUE, TRUE))
return FALSE;
...

I missed something or it was just a false positive ?

Julien.

I used this :
http://people.redhat.com/caolanm/callcatcher/DEV300_m87/sc.callcatcher.log, 
the link I found on

http://wiki.documentfoundation.org/Development/Easy_Hacks#call-catcher_.2F_bloat_removal
Since, it's DEV300_m87, it's my mistake, at first glance i thought it 
was a report from LO git sources like cppcheck.


Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Callcatch ScAttrArray::HasLines

2010-12-10 Thread Caolán McNamara 
On Fri, 2010-12-10 at 22:13 +0100, Julien Nabet wrote:
> Hello,
> 
> The function ScAttrArray::HasLines is called in the file 
> sc/source/core/data/column2.cxx (line 1246).
> BOOL ScColumn::IsEmptyBlock(SCROW nStartRow, SCROW nEndRow, bool 
> bIgnoreNotes) const
> {
>  Rectangle aRect;
>  if (pAttrArray->HasLines(nStartRow, nEndRow, aRect, TRUE, TRUE))
>  return FALSE;
> ...
> 
> I missed something or it was just a false positive ?

Are you getting HasLines marked as unused in a callcatcher run of your
own, or are you working off one of my OpenOffice.org lists, e.g.
http://people.redhat.com/caolanm/callcatcher/DEV300_m86/

i.e. in the OpenOffice.org DEV300_m86 HasLines is unused, while in
LibreOffice master HasLines is not unused.


C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Callcatch ScAttrArray::HasLines

2010-12-10 Thread Julien Nabet 

Hello,

The function ScAttrArray::HasLines is called in the file 
sc/source/core/data/column2.cxx (line 1246).
BOOL ScColumn::IsEmptyBlock(SCROW nStartRow, SCROW nEndRow, bool 
bIgnoreNotes) const

{
Rectangle aRect;
if (pAttrArray->HasLines(nStartRow, nEndRow, aRect, TRUE, TRUE))
return FALSE;
...

I missed something or it was just a false positive ?

Julien.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice