[Libreoffice] Comment-translation of writer/sw/source/ui/config
Hi, this translates all german code comments in the writer/sw/source/ui/config directory to english! one patch per file for easy reviewing before pushing. thanks, Martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
On 2/24/11 7:33 PM, Martin Kepplinger wrote: Hi, this translates all german code comments in the writer/sw/source/ui/config directory to english! one patch per file for easy reviewing before pushing. thanks, Martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
Am 24.02.2011 19:46, schrieb Jonathan Aquilina: On 2/24/11 7:33 PM, Martin Kepplinger wrote: Hi, this translates all german code comments in the writer/sw/source/ui/config directory to english! one patch per file for easy reviewing before pushing. thanks, Martin Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. hi, From now on I'll sum up reasonable translation-patch sizes. thanks, Martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. For the record this is what git send-email --thread --no-change-reply-to does, which the guideline mentions. http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline under Send patches as attachments or use git send-email. We need to either continue allowing this, or change the guideline. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
Am 24.02.2011 20:33, schrieb Kohei Yoshida: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. For the record this is what git send-email --thread --no-change-reply-to does, which the guideline mentions. you meant --no-chain-reply-to, that's what I use. http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline under Send patches as attachments or use git send-email. We need to either continue allowing this, or change the guideline. Kohei Yes. It's a nice feature of git that I would miss if it wouldn't be allowed. But in this case, I can simply follow Jonathan's suggestion by _committing_ larger junks of translated comments to my local branch, regardless of their files. No problem. Martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
On 02/24/2011 08:33 PM, Kohei Yoshida wrote: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. For the record this is what git send-email --thread --no-change-reply-to does, which the guideline mentions. yes but it does not recommend to make a commit per file for the same task within the same directory... Looking at the patches, there are some with 1 line changed in one file. In this case, I would recommend to have one commit for translation within a directory. If you are programming, you will very often not be able to have one commit with just one file changed, knowing that a commit should be compilable and runnable... Martin, you can still locally commit as often as you did. But when you are finished with your work, you can group together commits where it makes sense. (in your case, e.g. one commit for translation per directory, except with extra-big file for example). Just beware, still holds to the rule 1 commit is compilable For this you can use git rebase -i. At http://book.git-scm.com/4_interactive_rebasing.html you have a good explanation. At the end, you can then send the git send-mail, with the fewer number of commits. (I am not sure if this could be achieved on the fly, but I think this could be risky, a least too risky for me...) I hope this can help regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config
On Thu, 2011-02-24 at 21:31 +0100, Pierre-André Jacquod wrote: On 02/24/2011 08:33 PM, Kohei Yoshida wrote: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in one email. For the record this is what git send-email --thread --no-change-reply-to does, which the guideline mentions. yes but it does not recommend to make a commit per file for the same task within the same directory... Looking at the patches, there are some with 1 line changed in one file. In this case, I would recommend to have one commit for translation within a directory. Yup, a good suggestion. I somehow overlooked that his patches were one per file. We indeed want to avoid per-file patches. I also agree with the rest of your suggestion. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
