Re: [Libreoffice] GNU cp dependency
Hi Francois, On Sun, 2011-03-20 at 08:27 +0100, Francois Tigeot wrote: It was not luck, there was some conditional code to use either GNU or straight cp. It may have been a hack though. Hey - well, if we can do a build with your 'cp' that works, then we should tweak the configure check to cope with that. Patches accepted - and apologies for the regression, some of these things are almost inevitable sadly. I guess you should read Bjoern's commit: commit f16cbbb6f5d718d84fee42025535d8441f6f72c8 Author: Bjoern Michaelsen b_michael...@openoffice.org Date: Sun Jan 16 02:56:23 2011 +0100 gnumake3: #i116440# configure should only use a GNU cp from coreutils with preserve= support and fall back to POSIX cp otherwise in bootstrap/ first. I have bigger build issues to tackle for now. Since the new code has fixed the gnu cp location issue, I have simply added a --with-gnu-cp knob in my autoconf.sh line. :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] GNU cp dependency
Hey Bjoern, On Sun, Mar 20, 2011 at 01:05:07AM +0100, Bjoern Michaelsen wrote: On Sat, 19 Mar 2011 06:09:10 +0100 Francois Tigeot ftig...@wolfpond.org wrote: Well, all my builds of the last few month were run without it. That is luck and you dont want to count on that. Anyone using a variable GNUCOPY in the old build system has every right to expect it to contain a GNU cp. It was not luck, there was some conditional code to use either GNU or straight cp. It may have been a hack though. Neat. Is there a timeframe for that ? As soon as you have migrated all modules to the new system. ;D Okay. Maybe sometime in 2021 then :p I'm runnning DragonFly and the behavior has clearly changed. Should I remove/change the test in configure.in ? You could set GNUCOPY to empty (on BSD as on OSX) if there isnt one available. Likely you will get breakers now on BSD from that and issues might pop up again now and then as long as the old build system is around I have bigger build issues to tackle for now. Since the new code has fixed the gnu cp location issue, I have simply added a --with-gnu-cp knob in my autoconf.sh line. Honestly, I think the time spend on working around the awkwardness of the old build system is better spend on migrating to the new build system though. I completely agree. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] GNU cp dependency
Hi Francois, On Sat, 19 Mar 2011 06:09:10 +0100 Francois Tigeot ftig...@wolfpond.org wrote: Well, all my builds of the last few month were run without it. That is luck and you dont want to count on that. Anyone using a variable GNUCOPY in the old build system has every right to expect it to contain a GNU cp. Neat. Is there a timeframe for that ? As soon as you have migrated all modules to the new system. ;D I'm runnning DragonFly and the behavior has clearly changed. Should I remove/change the test in configure.in ? You could set GNUCOPY to empty (on BSD as on OSX) if there isnt one available. But then the old build system will set GNUCOPY to a non-GNU cp. Likely you will get breakers now on BSD from that and issues might pop up again now and then as long as the old build system is around. So if you do that change, you would be completely responsible for fixing those yourself. Anyone assuming GNUCOPY to contain a GNU cp is perfectly ok, so doing that even in the old build system is absolutely innocent IMHO. Dont complain to them. Honestly, I think the time spend on working around the awkwardness of the old build system is better spend on migrating to the new build system though. Best Regards, Bjoern -- https://launchpad.net/~bjoern-michaelsen signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] GNU cp dependency
Hi Bjoern, On Sat, Mar 19, 2011 at 05:36:02AM +0100, Bjoern Michaelsen wrote: On Fri, 18 Mar 2011 23:17:34 +0100 Francois Tigeot ftig...@wolfpond.org wrote: configure: error: no, GNU cp needed. install or specify with --with-gnu-cp=/path/to/it As the guy who changed that (back when I was still at Oracle): No, this didnt introduce a new dependency on GNU cp -- it always was there. Well, all my builds of the last few month were run without it. There was a variable GNUCOPY in the old build system which everyone expected to be GNU cp. The funny thing is: the build system would still fall back to any cp it will find in most cases. Thus you could end up with some POSIX cp in the variable GNUCOPY leading to very interesting effects AFAIK, there is (was?) some code to check for this and use correct arguments for straight cp. I agree the old build system was buggy: at one time I installed coreutils and tried to use its included cp, specifying the full path but the scripts still tried to use /bin/cp instead. Once we get rid of the old build system we dont need to require GNU cp Neat. Is there a timeframe for that ? P.S.: Also note that the old build system did not always require GNU cp. For example on OSX it did not (and configure should not complain there). I'm runnning DragonFly and the behavior has clearly changed. Should I remove/change the test in configure.in ? Kind Regards, -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
