Re: [Libreoffice] HC Cleanup
On Wed, 24 Nov 2010 11:48:01 +0100, Sebastian Spaeth wrote: > To my absolute shame, I had filed the marker bug to not forget it but > still haven't done or moved anything. So that should be resolved at the > same time, or has Joe already done it? If so, can you mark as resolved? > > https://bugs.freedesktop.org/show_bug.cgi?id=31679 Now that Joe already had removed the code using this, I could move the files in git, so the above bug is resolved and the marker images are in the hicontrast theme. Thanks! Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
On Tue, 23 Nov 2010 20:57:47 +, "Andrew C. E. Dent" wrote: > I've uploaded the files for the HC theme > here:http://people.bath.ac.uk/ea2aced/OOo/svx.zip > However, Sebastain has been rocking the HC theme and moving files via > Git.Perhaps he could upload the files, or just git copy and rename as > required? To my absolute shame, I had filed the marker bug to not forget it but still haven't done or moved anything. So that should be resolved at the same time, or has Joe already done it? If so, can you mark as resolved? https://bugs.freedesktop.org/show_bug.cgi?id=31679 Sebastian P.S. I am just building a build without the classic theme, and if that works out well, I'll commit that. P.P.S Michael had mentioned the possibility to flatten the remaining industrial theme into the tango theme, should we pursue that further? pgpwFWu8q7w3X.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
Hi Joe I've uploaded the files for the HC theme here:http://people.bath.ac.uk/ea2aced/OOo/svx.zip However, Sebastain has been rocking the HC theme and moving files via Git.Perhaps he could upload the files, or just git copy and rename as required? Cheers,Andrew > From: jpower...@cox.net > Subject: HC Cleanup > Date: Mon, 22 Nov 2010 19:18:25 -0800 > CC: libreoffice@lists.freedesktop.org > To: ace_d...@hotmail.com > > While creating the HC Icon set, could you look into the following? > > default_images/svx/source/svdraw > cropmarkers.png - 2d icons for cropping > cropmarkers2.png- 3d icons for cropping > cropmarkersACC.png - HC icons for cropping > > markers.png - 2d icons for markers > markers2.png- 3d icons for markers > markersACC.png - HC icons for markers > > The ACC versions will need to be copied in the 2d & 3d version in the HC set. > I've removed the code referring to the ACC versions. > > -- > > Just to confuse people, I changed the Auto-Detect HC mode option to change > the default theme to the High Contrast one. Yes, I know that when changing > the OS back to a normal theme, I don't change LibO back to the old theme (we > currently don't have a place to store the option). > > I changed the Windows Only code to match this behavior; however, I don't have > access to a Windows build system so the change is 1) un-tested & 2) > theoretically correct. Any testing would be great. > > -- > > It should now be save to remove all the HC versions of the icons from all > sets and start packaging the HC set as it's own theme. > > -- > > Joe P. > > PS: I believe I've removed all the code dealing with loading HC version of > Icons. If no-one objects, I'll remove the task from the Easy-Hacks page. > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
Hi Joseph,
On Tue, 2010-11-23 at 05:12 -0800, Joseph Powers wrote:
> Do you mean something like in: clone/libs-gui/vcl/source/app/settings.cxx
Ah ! yes - exactly :-)
> ULONG StyleSettings::GetAutoSymbolsStyle() const
> {
> ...
> if( bCont )
> {
> if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "gnome" ) ||
> rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "windows" ) )
> nRet = STYLE_SYMBOLS_TANGO;
So - I guess we should whack this into the backend itself, so we can
override it per platform; particularly if there is a high-contrast
setting there already.
> else if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "kde" ) )
> nRet = STYLE_SYMBOLS_CRYSTAL;
> else if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "kde4" ) )
> nRet = STYLE_SYMBOLS_OXYGEN;
In particular, OXYGEN or CRYSTAL can be used in GNOME and vv. for Tango
in GNOME I guess.
> We already seem to select a per-system default when the icon theme is set to
> auto.
Right; we just need to be slightly more clever here, so we can
auto-detect the high-contrast-ness for those impaired users that need it
shouldn't be much code.
Many thanks !
Michael.
PS. I wonder if we could hook a per-theme post-load filter into that
icon loading path to implement 'HighContrast Inverse' in the fullness of
time, and low-contrast too ;-) but perhaps that is just crack-smoking
over-engineering.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
On Nov 23, 2010, at 4:54 AM, Michael Meeks wrote:
> Hi Joseph,
>
> On Mon, 2010-11-22 at 19:18 -0800, Joseph Powers wrote:
>> While creating the HC Icon set, could you look into the following?
> ..
>> I changed the Windows Only code to match this behavior; however, I don't
>> have access to a Windows build system so the change is 1) un-tested &
>> 2) theoretically correct. Any testing would be great.
>
> Cool :-) Hopefullly we'll get our nightly snapshot building working
> soon, and the QA guys can have a bang on it.
>
>> It should now be save to remove all the HC versions of the icons from
>> all sets and start packaging the HC set as it's own theme.
>
> Brilliant :-) I believe we're nearly there on that anyway, but no doubt
> some residual cleanup is needed.
>
>> PS: I believe I've removed all the code dealing with loading HC version
>> of Icons. If no-one objects, I'll remove the task from the Easy-Hacks page.
>
> Wonderful work ! :-) how does it feel ? - I'm thrilled to have had all
> that crud removed, and please do hack it out of the wiki [ and add any
> other easy tasks you stumbled upon while hacking around here :-]
>
> Incidentally - we should prolly do some extra work in our backends to
> allow the default icon theme to be specified per platform, and made to
> match the native theme.
Do you mean something like in: clone/libs-gui/vcl/source/app/settings.cxx
ULONG StyleSettings::GetAutoSymbolsStyle() const
{
...
if( bCont )
{
if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "gnome" ) ||
rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "windows" ) )
nRet = STYLE_SYMBOLS_TANGO;
else if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "kde" ) )
nRet = STYLE_SYMBOLS_CRYSTAL;
else if( rDesktopEnvironment.equalsIgnoreAsciiCaseAscii( "kde4" ) )
nRet = STYLE_SYMBOLS_OXYGEN;
}
}
We already seem to select a per-system default when the icon theme is set to
auto.
> eg. in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx we setup the color
> schemes for gtk+ - but, AFAICS we don't detect the name of the system
> theme and adapt to it.
>
> By looking for the "High Contrast.*" theme names, we could pick a good
> default - ditto selecting, "oxygen" or "crystal" or "tango" if the
> system theme matches that: I -thought- we used to do that, but ... :-)
>
> Anyhow - some great work here.
>
> Thanks !
>
> Michael.
>
> --
> michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HC Cleanup
Hi Joseph, On Mon, 2010-11-22 at 19:18 -0800, Joseph Powers wrote: > While creating the HC Icon set, could you look into the following? .. > I changed the Windows Only code to match this behavior; however, I don't > have access to a Windows build system so the change is 1) un-tested & > 2) theoretically correct. Any testing would be great. Cool :-) Hopefullly we'll get our nightly snapshot building working soon, and the QA guys can have a bang on it. > It should now be save to remove all the HC versions of the icons from > all sets and start packaging the HC set as it's own theme. Brilliant :-) I believe we're nearly there on that anyway, but no doubt some residual cleanup is needed. > PS: I believe I've removed all the code dealing with loading HC version > of Icons. If no-one objects, I'll remove the task from the Easy-Hacks page. Wonderful work ! :-) how does it feel ? - I'm thrilled to have had all that crud removed, and please do hack it out of the wiki [ and add any other easy tasks you stumbled upon while hacking around here :-] Incidentally - we should prolly do some extra work in our backends to allow the default icon theme to be specified per platform, and made to match the native theme. eg. in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx we setup the color schemes for gtk+ - but, AFAICS we don't detect the name of the system theme and adapt to it. By looking for the "High Contrast.*" theme names, we could pick a good default - ditto selecting, "oxygen" or "crystal" or "tango" if the system theme matches that: I -thought- we used to do that, but ... :-) Anyhow - some great work here. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] HC Cleanup
While creating the HC Icon set, could you look into the following? default_images/svx/source/svdraw cropmarkers.png - 2d icons for cropping cropmarkers2.png- 3d icons for cropping cropmarkersACC.png - HC icons for cropping markers.png - 2d icons for markers markers2.png- 3d icons for markers markersACC.png - HC icons for markers The ACC versions will need to be copied in the 2d & 3d version in the HC set. I've removed the code referring to the ACC versions. -- Just to confuse people, I changed the Auto-Detect HC mode option to change the default theme to the High Contrast one. Yes, I know that when changing the OS back to a normal theme, I don't change LibO back to the old theme (we currently don't have a place to store the option). I changed the Windows Only code to match this behavior; however, I don't have access to a Windows build system so the change is 1) un-tested & 2) theoretically correct. Any testing would be great. -- It should now be save to remove all the HC versions of the icons from all sets and start packaging the HC set as it's own theme. -- Joe P. PS: I believe I've removed all the code dealing with loading HC version of Icons. If no-one objects, I'll remove the task from the Easy-Hacks page. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
