Re: [Libreoffice] Questions about push access
Thanks a lot for all useful tips! :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about push access
On 10/06/2011 08:22 PM, Ivan Timofeev wrote: 2. What changes should I avoid in my commits? I mean, what changes are unwanted, needless, etc. One thing to watch out for is to avoid pushing accidental merge commits. (It does happen, and is harmless, but also easily avoided.) That is, if you cannot push because someone else already pushed something newer, do a "git pull --rebase" before your next push attempt, so that your local changes are shuffled around to the branch head and git does not need to create a merge commit. -Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about push access
Hi Ivan, Michael, On 2011-10-06 at 20:08 +0100, Michael Meeks wrote: > > 1. I've performed my first push today and received this message: > > Heh ;-) we get to add each committer to the commiters list manually - > that is something I ought to do I guess, but Thorsten tends to do idly > when the bounces happen. Based on this, I've changed the rule there so that any new committer should be allowed to post without need of further tweaking of the settings. > > 2. What changes should I avoid in my commits? I mean, what changes are > > unwanted, needless, etc. > > Clearly running indent gratuitously on the code, while it may improve > it, makes the diff very hard to read ;-) beyond that - code cleanup, > porting, easy hacks - anything non-controversial should go straight into > master. Anything you're not sure - just ask on the list :-) > > If you're hacking a module substantially, it makes sense to dung out > un-necessary cruft, vertical line wasteage, over-verbose comments that > reduce readability are all fair game I think. Also, don't be shy to push for other people that send patches to the mailing list! :-) It is trivial - when you see a patch on the mailing list that is correct, and you think it should go in, just save it (eg. as the_patch.patch), and do: # apply the patch (it applies including setting the right committer name # and the commit message) git am the_patch.patch # check that everything applied well git log -p # check that it builds / does the work # and finally git push # then send a reply to the mailing list that you pushed the patch; add # [PUSHED] to the subject of the mail And that's it :-) You need to do more when the patch sent to the mailing list is not produced using 'git format-patch' - in that case you have to set the committer name using --author switch of the git commit command. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about push access
Hi Ivan, On Thu, 2011-10-06 at 22:22 +0400, Ivan Timofeev wrote: > 1. I've performed my first push today and received this message: Heh ;-) we get to add each committer to the commiters list manually - that is something I ought to do I guess, but Thorsten tends to do idly when the bounces happen. > I've canceled posting foolishly. I was not supposed to do that, was I? > And is it possible not to receive such mailings? No problem cancelling it, we can read the git log -u much more easily these days. > 2. What changes should I avoid in my commits? I mean, what changes are > unwanted, needless, etc. Clearly running indent gratuitously on the code, while it may improve it, makes the diff very hard to read ;-) beyond that - code cleanup, porting, easy hacks - anything non-controversial should go straight into master. Anything you're not sure - just ask on the list :-) If you're hacking a module substantially, it makes sense to dung out un-necessary cruft, vertical line wasteage, over-verbose comments that reduce readability are all fair game I think. Excited to see what you'll work on :-) All the best, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Questions about push access
Hello, let me ask a few questions. 1. I've performed my first push today and received this message: 2011/10/6 > Your mail to 'Libreoffice-commits' with the subject > > .: tools/source > > Is being held until the list moderator can review it for approval. > > The reason it is being held: > > Post by non-member to a members-only list > > Either the message will get posted to the list, or you will receive > notification of the moderator's decision. If you would like to cancel > this posting, please visit the following URL: I've canceled posting foolishly. I was not supposed to do that, was I? And is it possible not to receive such mailings? 2. What changes should I avoid in my commits? I mean, what changes are unwanted, needless, etc. Thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
