Re: [Libreoffice] SvxHyperlinkDlg still used?
Hi Christoph, On Sat, 2010-11-13 at 01:15 +0100, Christoph Noack wrote: > A first look ... did that help anyhow? Yes, that helped a lot! :-) Thanks a lot for the very detailed analysis on this. If I read your analysis correctly, we can probably safely remove this without upsetting too many users. And based on the input from others on this thread removing this toolbar will not be missed, and the code is so old that it's probably not worth trying to salvage it for recycling. I just resurrected this item on the Easy Hacks page, and edited it to provide more hints. http://wiki.documentfoundation.org/Development/Easy_Hacks#Remove_obsolete_Hyperlink_Bar I look forward to having someone brave enough to step up for this task. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Cor Nouws wrote (14-11-10 21:25) Kálmán „KAMI” Szalai wrote (14-11-10 18:11) It is easy way to inset links Yes indeed, I realised that is allows working with hyperlinks without being kept in a modal dialogue :-) Well, that is what I thought it is. Reading the mail from Camille, I realised I was wrong: it is a non-modal one. But to be honest, close to all hyperlinks I create is just by typing and autoformatting the URL. Do you use the toolbar for other purposes? Any data/experiences from other users? Regards, Cor -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On 14/11/2010 18:11, Kálmán „KAMI” Szalai wrote: > 2010-11-14 17:35 keltezéssel, Sebastian Spaeth írta: >> On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks >> wrote: >>> On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. >> +1 for removing that beast anyway. > It is easy way to insert links Yes but, this part is also covered by the Hyperlink Dialog, which happens to be non modal, so you can keep it open if you want to insert many links in a row. The interest of this bar was IMHO the websearch part, but it's not convenient enough to be actually used IRL. My thoughts on that http://wiki.services.openoffice.org/wiki/User:Camillem/MyDrafts#Web_search_Toolbar So, I would be in favour of removing it, as it's old code that can't be easily recycled (see Mathias Bauer's answer in the Technical details part of the link above). Camille ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Hi Kami, Kálmán „KAMI” Szalai wrote (14-11-10 18:11) It is easy way to inset links Yes indeed, I realised that is allows working with hyperlinks without being kept in a modal dialogue :-) But to be honest, close to all hyperlinks I create is just by typing and autoformatting the URL. Do you use the toolbar for other purposes? Any data/experiences from other users? Regards, Cor -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Title: Szalai Kálmán It is easy way to inset links KAMI 2010-11-14 17:35 keltezéssel, Sebastian Spaeth írta: On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks wrote: On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. +1 for removing that beast anyway. Sebastian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Best regards, Kálmán „KAMI” Szalai | 神 | kami911 [at] gmail [dot] com My favorite projects: OxygenOffice Professional - office suite - for everybody | Magyarul - In Hungarian Blog | Support Follow me, if you can signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 12 Nov 2010 16:46:19 +, Michael Meeks wrote: > On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: > > Heh! The short story is that this dialog code still *is* used, as a > > Hyperlink *toolbar*. +1 for removing that beast anyway. Sebastian pgpiwvdu3P3U0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Just to add my 'Aye' to Michaels comments (as a humble user).A quick Google reveals that predominately the full insert hyperlink function is referenced in online guides.I think this is a fair reflection of the expected UX and the toolbar is redundant. Cheers,Andrew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Hi Michael, hi Kohei, all! Am Freitag, den 12.11.2010, 16:46 + schrieb Michael Meeks: > On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: > > Heh! The short story is that this dialog code still *is* used, as a > > Hyperlink *toolbar*. > > ;-> Yep, it also looks a bit dated ... To me, it isn't even a toolbar, because it doesn't behave like the other toolbars. Similar to the "color bar"; e.g one of the tiny usability issues is, that the items in View -- Toolbars are translated, but do not consider the sort order in the menu. [...] > Riight - on the other hand, using that toolbar I'm somewhat appalled by > it. Christoph - any chance of some quick review of that hyperlink bar ? > it looks to me as if it is some legacy cruft from the days when > StarOffice was an HTML editor. > > Worse than that, it seems that it provides editable controls that do > not allow you to edit the hyperlink itself ;-) There is a also this > top-level 'web link' editor button in the top-level UI. Finally there is > a tool-tip that provides the target link information in an > easy-to-get-at way. Okay, to start with the HTML editor stuff - about two years ago, some guys in Hamburg and myself sat together and discussed whether the current HTML editor makes sense at the moment. We all came to the conclusion that - in the long-term - this module is outdated and may be removed (or at least not shown). Although nothing thrilling happened here, it is an indicator how other guys currently rate its "usefulness". Concerning the hyperlink toolbar: * It seems to be rarely used (that is how I interpret the data) * Some "old" functionality, strange behavior (you noticed that) * But some features are unique (no alternative within LibO/OOo) RARELY USED I had a look at the User Feedback Data [1] and tried to identify the elements there (as some of you know, playing Dr. Watson). I tried to use some features, but they don't seem to be noticed by the system ... so guesswork. Only enabling/disabling of the toolbar is tracked (.uno:InsertHyperlink) - most probably the first item here (for all modules): dispatch ToolbarsMenuController .uno:InsertHyperlink 503 dispatch GenericToolbarController .uno:InsertHyperlink 17 The last column is the number of "uses" which should be considered a relative value - just for comparison: "Use of Backspace" = 150025254 Although it is used, it seems rarely used. Although I have to admit that there might be people/businesses using it - and we know nothing about it (e.g. because they do not want to share Usage Feedback Data with us). OLD FUNCTIONALITY, STRANGE BEHAVIOR Some of the functionality seems to suit very experienced users - or is simply a bit old (e.g. adding "_top" or whatever links). Besides the fact, that it is possible to (very) quickly add hyperlinks, the behavior (usability) is a bit strange: * Some of the functionality is confirmed via RETURN, although this is "invisible". * It is also easy to mess up some text content by playing around with the (unnamed) drop-down field and the combo box. * The "Hyperlink" toolbar element doesn't define a "default" action. You have to use the dropdown at the right side. * Strange separator use ... things are shown together that don't belong together. UNIQUE FEATURES Well, some of the features aren't that bad, so here is what I consider helpful. * Inserting Hyperlink buttons is simple --> No real alternative * Search functionality (web search) --> No alternative * List of hyperlinks within the document (but, doesn't work well if one URL name is used multiple times) --> Alternative: Navigator Well, if people don't really need the hyperlink buttons, then there are better alternatives within the office suite. Or, with regard to the search functionality, it is somehow limited. So it might be replaced / moved, or people won't miss it (too much). > My suggestion is that we rid ourselves of it, and save one menu item, > and one module of under-used code. I would second that, but I recommend to ask on one of our mailing lists whether anybody knows if any large business makes use of it for internal workflows or such things. If we see no further problem here, then you may: * remove the hyperlink bar * remove the related search options (Options - Internet - Search) Concerning some kind of improvement / alternative, we might: * come up with some alternative "research functionality" (e.g. Wikipedia, improved SmartTags use, ...) * think about Hyperlink handling improvements (e.g. [2]) A first look ... did that help anyhow? Cheers, Christoph [1] http://wiki.services.openoffice.org/wiki/File:OOo31_Usage_Feedback_Data.ods [2] http://wiki.services.openoffice.org/wiki/User_Experience/DirectManipulationSnippets#Mockups __
Re: [Libreoffice] SvxHyperlinkDlg still used?
Michael Meeks wrote (12-11-10 17:46) Riight - on the other hand, using that toolbar I'm somewhat appalled by it. Christoph - any chance of some quick review of that hyperlink bar ? it looks to me as if it is some legacy cruft from the days when StarOffice was an HTML editor. Worse than that, it seems that it provides editable controls that do not allow you to edit the hyperlink itself ;-) Hmm, its not that bad. Put the cursor on an existing hyperlink, or select a button, change the url in the toolbar, choose Text/Button again and it is changed. There is a also this top-level 'web link' editor button in the top-level UI. ==Insert>Hyperlink There is some analogy between the Find&Replace window and the new quick find toolbar, and the Hyperlink dialog and this toolbar. The toolbar is really simple to use. Finally there is a tool-tip that provides the target link information in an easy-to-get-at way. Yes. That is a fairly recent improvement. My suggestion is that we rid ourselves of it, and save one menu item, and one module of under-used code. Since the context menu provides easy access, I would say OK. Since the Hyperlink dialog is more complex (compare F&R and quick Find), I doubt .. Although, people able to choose between target _blank, _self etc, must be considered skilled enough to handle the dialog too. Just my 2c of course. Cor -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: > Heh! The short story is that this dialog code still *is* used, as a > Hyperlink *toolbar*. ;-> > Go to View -> Toolbars -> Hyperlink Bar to enable > a new toolbar to allow some sort of quick insertion of URL buttons. > That toolbar makes use of SvxHyperlinkDlg. Riight - on the other hand, using that toolbar I'm somewhat appalled by it. Christoph - any chance of some quick review of that hyperlink bar ? it looks to me as if it is some legacy cruft from the days when StarOffice was an HTML editor. Worse than that, it seems that it provides editable controls that do not allow you to edit the hyperlink itself ;-) There is a also this top-level 'web link' editor button in the top-level UI. Finally there is a tool-tip that provides the target link information in an easy-to-get-at way. My suggestion is that we rid ourselves of it, and save one menu item, and one module of under-used code. Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: > On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: > > On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: > > > Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never > > > instantiated. It is registered by the applications on startup, but > > > that's the only place I see it being used. > > > > Ah true ;-) I see there is a new cui/ hyperlink dialog that is used. > > > > > > Presuambly we came to that conclusion already as it is still > > > > there. > > > > > > Nope, it's there because I added it to the Easy Hack page. > > > > :-) I guess there is prolly other cruft that goes with it eg. the > > several calls to: > > > > SFX_CHILDWINDOW_REGISTRATION( SID_HYPERLINK_INSERT ); > > > > and the: > > > > svx/source/dialog/hyprlink.cxx:SFX_IMPL_CHILDWINDOW(SvxHyperlinkDlgWrapper, > > SID_HYPERLINK_INSERT) > > > > and of course mentions of that in various sdi and src files. > > > > Did you do the unwinding to satisfy yourself that whatever mapping > > between SID_HYPERLINK_INSERT and this dialog is never exploited ? > > Heh! The short story is that this dialog code still *is* used, as a > Hyperlink *toolbar*. Go to View -> Toolbars -> Hyperlink Bar to enable > a new toolbar to allow some sort of quick insertion of URL buttons. > That toolbar makes use of SvxHyperlinkDlg. This line http://opengrok.go-oo.org/xref/libs-core/framework/source/uielement/toolbarsmenucontroller.cxx#509 addCommand( m_xPopupMenu, rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( CMD_HYPERLINKBAR )), 10360, aEmptyString ); (where CMD_HYPERLINKBAR == ".uno:InsertHyperlink") inserts the internal value of SID_HYPERLINK_INSERT as a hard-coded integer value! No wonder searching for SID_HYPERLINK_INSERT didn't turn up that line I've been with this code base for many years, and it is still full of surprises. :-P Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 11:12 -0500, Kohei Yoshida wrote: > > Did you do the unwinding to satisfy yourself that whatever mapping > > between SID_HYPERLINK_INSERT and this dialog is never exploited ? > > Heh! The short story is that this dialog code still *is* used, as a > Hyperlink *toolbar*. Go to View -> Toolbars -> Hyperlink Bar to enable > a new toolbar to allow some sort of quick insertion of URL buttons. > That toolbar makes use of SvxHyperlinkDlg. Turns out that the code is called indirectly via UNO command ".uno:InsertHyperlink", which is mapped to SID_INSERT_HYPERLINK and automatically translated somewhere in the framework code. Heh. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 15:32 +, Michael Meeks wrote: > On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: > > Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never > > instantiated. It is registered by the applications on startup, but > > that's the only place I see it being used. > > Ah true ;-) I see there is a new cui/ hyperlink dialog that is used. > > > > Presuambly we came to that conclusion already as it is still there. > > > > Nope, it's there because I added it to the Easy Hack page. > > :-) I guess there is prolly other cruft that goes with it eg. the > several calls to: > > SFX_CHILDWINDOW_REGISTRATION( SID_HYPERLINK_INSERT ); > > and the: > > svx/source/dialog/hyprlink.cxx:SFX_IMPL_CHILDWINDOW(SvxHyperlinkDlgWrapper, > SID_HYPERLINK_INSERT) > > and of course mentions of that in various sdi and src files. > > Did you do the unwinding to satisfy yourself that whatever mapping > between SID_HYPERLINK_INSERT and this dialog is never exploited ? Heh! The short story is that this dialog code still *is* used, as a Hyperlink *toolbar*. Go to View -> Toolbars -> Hyperlink Bar to enable a new toolbar to allow some sort of quick insertion of URL buttons. That toolbar makes use of SvxHyperlinkDlg. Ok I'm removing this task from the Easy Hack page. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 08:35 -0500, Kohei Yoshida wrote: > Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never > instantiated. It is registered by the applications on startup, but > that's the only place I see it being used. Ah true ;-) I see there is a new cui/ hyperlink dialog that is used. > > Presuambly we came to that conclusion already as it is still there. > > Nope, it's there because I added it to the Easy Hack page. :-) I guess there is prolly other cruft that goes with it eg. the several calls to: SFX_CHILDWINDOW_REGISTRATION( SID_HYPERLINK_INSERT ); and the: svx/source/dialog/hyprlink.cxx:SFX_IMPL_CHILDWINDOW(SvxHyperlinkDlgWrapper, SID_HYPERLINK_INSERT) and of course mentions of that in various sdi and src files. Did you do the unwinding to satisfy yourself that whatever mapping between SID_HYPERLINK_INSERT and this dialog is never exploited ? Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-12 at 12:26 +, Michael Meeks wrote:
> Hi there,
>
> On Fri, 2010-11-05 at 09:28 -0400, Kohei Yoshida wrote:
> > On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote:
> > > Does anyone know if SvxHyperlinkDlg* is still used?
> >
> > Did a full git grep SvxHyperlinkDlg on all repos
>
> It looks to me, that we just use the SvxHyperlinkDlgWrapper to wrap the
> dialog, but we do use the implemetation (surely) ?
Yes, I was aware of this, and even SvxHyperlinkDlgWrapper is never
instantiated. It is registered by the applications on startup, but
that's the only place I see it being used.
>
> SvxHyperlinkDlgWrapper::SvxHyperlinkDlgWrapper( Window* _pParent, USHORT nId,
> SfxBindings* _pBindings,
> SfxChildWinInfo* /*pInfo*/ ) :
> SfxChildWindow( _pParent, nId )
> {
> pWindow = new SvxHyperlinkDlg( _pBindings, _pParent );
>
> So (sadly) we can't remove it.
But if SvxHyperlinkDlgWrapper is not used, then surely we can remove
both? :-)
> Presuambly we came to that conclusion already as it is still there.
Nope, it's there because I added it to the Easy Hack page.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Hi there,
On Fri, 2010-11-05 at 09:28 -0400, Kohei Yoshida wrote:
> On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote:
> > Does anyone know if SvxHyperlinkDlg* is still used?
>
> Did a full git grep SvxHyperlinkDlg on all repos
It looks to me, that we just use the SvxHyperlinkDlgWrapper to wrap the
dialog, but we do use the implemetation (surely) ?
SvxHyperlinkDlgWrapper::SvxHyperlinkDlgWrapper( Window* _pParent, USHORT nId,
SfxBindings* _pBindings,
SfxChildWinInfo* /*pInfo*/ ) :
SfxChildWindow( _pParent, nId )
{
pWindow = new SvxHyperlinkDlg( _pBindings, _pParent );
So (sadly) we can't remove it.
Presuambly we came to that conclusion already as it is still there.
ATB,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
On Fri, 2010-11-05 at 00:51 -0400, Kohei Yoshida wrote: > Hi there, > > Does anyone know if SvxHyperlinkDlg* is still used? Did a full git grep SvxHyperlinkDlg on all repos and I'm more confident that the answer is 'no'. Though it is still referenced (via SvxHyperlinkDlgWrapper) here and there in writer, calc and impress, it is never instantiated. Let's remove this on master. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SvxHyperlinkDlg still used?
Hi there, Does anyone know if SvxHyperlinkDlg* is still used? Just by looking at the code, that dialog doesn't appear to be used anymore. It gets registered in Calc and Writer (haven't checked other apps), but they don't appear to be used anywhere in those apps. If it's no longer used, that class, along with several controls that are only used in that class (such as HyperCombo and HyperFixedText) should be candidates for removal. This came up while talking to Joseph (JoeP) on IRC about the use of hard-coded strings "http://www.stardiv.dewww"; and "StarDivision GmbHwww" in svx/source/dialog/hyprlink.cxx:859 which led me to dig deeper... Kohei * libs-core/svx/source/dialog/hyprdlg.hxx -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
