[Libreoffice-commits] core.git: 2 commits - svx/source sw/qa sw/source

2021-10-31 Thread Mike Kaganski (via logerrit) 
 svx/source/accessibility/AccessibleShape.cxx  |5 
 svx/source/core/graphichelper.cxx |   19 -
 svx/source/customshapes/EnhancedCustomShape2d.cxx |5 
 svx/source/customshapes/EnhancedCustomShapeEngine.cxx |3 
 svx/source/dialog/charmap.cxx |   12 -
 svx/source/dialog/compressgraphicdialog.cxx   |   13 -
 svx/source/dialog/docrecovery.cxx |   77 
 svx/source/dialog/rubydialog.cxx  |5 
 svx/source/dialog/signaturelinehelper.cxx |6 
 svx/source/form/databaselocationinput.cxx |3 
 svx/source/form/fmshimp.cxx   |3 
 svx/source/form/fmtextcontrolshell.cxx|6 
 svx/source/form/formcontroller.cxx|8 
 svx/source/form/tbxform.cxx   |7 
 svx/source/gallery2/galbrws1.cxx  |7 
 svx/source/gallery2/galbrws2.cxx  |   51 ++---
 svx/source/gallery2/galmisc.cxx   |7 
 svx/source/items/clipfmtitem.cxx  |6 
 svx/source/items/customshapeitem.cxx  |   22 +-
 svx/source/items/galleryitem.cxx  |   24 +-
 svx/source/items/viewlayoutitem.cxx   |   13 -
 svx/source/items/zoomslideritem.cxx   |   19 +
 svx/source/mnuctrls/clipboardctl.cxx  |7 
 svx/source/sdr/overlay/overlaymanager.cxx |7 
 svx/source/smarttags/SmartTagMgr.cxx  |   15 -
 svx/source/stbctrls/pszctrl.cxx   |   10 -
 svx/source/stbctrls/selctrl.cxx   |9 
 svx/source/stbctrls/xmlsecctrl.cxx|   10 -
 svx/source/stbctrls/zoomctrl.cxx  |   19 -
 svx/source/stbctrls/zoomsliderctrl.cxx|8 
 svx/source/svdraw/svdlayer.cxx|8 
 svx/source/svdraw/svdoashp.cxx|  168 -
 svx/source/svdraw/svdoole2.cxx|6 
 svx/source/tbxctrls/PaletteManager.cxx|   13 -
 svx/source/tbxctrls/StylesPreviewWindow.cxx   |   21 --
 svx/source/tbxctrls/colrctrl.cxx  |   10 -
 svx/source/tbxctrls/extrusioncontrols.cxx |   41 +---
 svx/source/tbxctrls/fontworkgallery.cxx   |   21 --
 svx/source/tbxctrls/formatpaintbrushctrl.cxx  |6 
 svx/source/tbxctrls/grafctrl.cxx  |   12 -
 svx/source/tbxctrls/itemwin.cxx   |5 
 svx/source/tbxctrls/layctrl.cxx   |   17 -
 svx/source/tbxctrls/lboxctrl.cxx  |6 
 svx/source/tbxctrls/linectrl.cxx  |   22 --
 svx/source/tbxctrls/tbcontrl.cxx  |   57 ++---
 svx/source/tbxctrls/tbunocontroller.cxx   |6 
 svx/source/unodraw/UnoGraphicExporter.cxx |   10 -
 svx/source/unodraw/unomod.cxx |   52 ++---
 svx/source/unodraw/unoshap4.cxx   |   11 -
 svx/source/unogallery/unogalthemeprovider.cxx |3 
 svx/source/xml/xmleohlp.cxx   |   12 -
 svx/source/xml/xmlexport.cxx  |7 
 svx/source/xoutdev/xattr.cxx  |   32 +--
 svx/source/xoutdev/xattrbmp.cxx   |   12 -
 sw/qa/extras/odfexport/odfexport.cxx  |6 
 sw/qa/extras/odfimport/odfimport.cxx  |  172 --
 sw/qa/extras/rtfimport/rtfimport.cxx  |4 
 sw/qa/extras/unowriter/unowriter.cxx  |9 
 sw/qa/uibase/uiview/uiview.cxx|4 
 sw/qa/unit/swmodeltestbase.cxx|   11 -
 sw/source/core/access/accpara.cxx |5 
 sw/source/core/crsr/findtxt.cxx   |6 
 sw/source/core/doc/DocumentStatisticsManager.cxx  |   33 +--
 sw/source/core/doc/doc.cxx|3 
 sw/source/core/docnode/retrieveinputstream.cxx|   11 -
 sw/source/core/ole/ndole.cxx  |6 
 sw/source/core/swg/SwXMLTextBlocks1.cxx   |7 
 sw/source/core/unocore/unochart.cxx   |   23 +-
 sw/source/core/unocore/unocoll.cxx|8 
 sw/source/core/unocore/unocrsrhelper.cxx  |5 
 sw/source/core/unocore/unoobj.cxx |   11 -
 sw/source/core/unocore/unoparagraph.cxx   |5 
 sw/source/core/unocore/unoport.cxx|5 
 sw/source/core/unocore/unostyle.cxx   |   25 +-
 sw/source/core/view/printdata.cxx |   45 +---
 sw/source/filter/ww8/ww8par.cxx   |3 
 sw/source/filter/ww8/ww8par3.cxx  |3 
 sw/source/filter/ww8/ww8toolbar.cxx

[Libreoffice-commits] core.git: 2 commits - svx/source sw/qa sw/source

2021-02-14 Thread Noel (via logerrit) 
 svx/source/accessibility/AccessibleTextHelper.cxx |4 -
 svx/source/accessibility/GraphCtlAccessibleContext.cxx|2 
 svx/source/accessibility/charmapacc.cxx   |2 
 svx/source/accessibility/svxpixelctlaccessiblecontext.cxx |2 
 svx/source/accessibility/svxrectctaccessiblecontext.cxx   |2 
 svx/source/dialog/charmap.cxx |2 
 svx/source/dialog/dlgctrl.cxx |4 -
 svx/source/dialog/frmsel.cxx  |4 -
 svx/source/dialog/graphctl.cxx|2 
 svx/source/dialog/weldeditview.cxx|2 
 svx/source/form/fmcontrollayout.cxx   |6 -
 svx/source/form/fmdocumentclassification.cxx  |2 
 svx/source/form/fmobj.cxx |2 
 svx/source/form/fmscriptingenv.cxx|4 -
 svx/source/form/fmshimp.cxx   |4 -
 svx/source/form/fmsrcimp.cxx  |6 -
 svx/source/form/fmundo.cxx|   15 ++--
 svx/source/form/fmview.cxx|4 -
 svx/source/form/fmvwimp.cxx   |2 
 svx/source/form/formcontroller.cxx|6 -
 svx/source/form/navigatortree.cxx |4 -
 svx/source/form/navigatortreemodel.cxx|   14 ++--
 svx/source/form/tabwin.cxx|2 
 svx/source/gallery2/galbrws2.cxx  |2 
 svx/source/items/drawitem.cxx |2 
 svx/source/sdr/primitive2d/sdrdecompositiontools.cxx  |   10 +--
 svx/source/sdr/primitive2d/sdrmeasureprimitive2d.cxx  |2 
 svx/source/svdraw/svdoole2.cxx|   20 ++
 svx/source/table/accessibletableshape.cxx |9 +-
 svx/source/table/cell.cxx |3 
 svx/source/table/cellrange.cxx|2 
 svx/source/table/propertyset.cxx  |2 
 svx/source/table/svdotable.cxx|8 +-
 svx/source/table/tablecolumns.cxx |2 
 svx/source/table/tablemodel.cxx   |6 -
 svx/source/tbxctrls/colrctrl.cxx  |2 
 svx/source/xml/xmlgrhlp.cxx   |6 -
 svx/source/xml/xmlxtimp.cxx   |   12 +--
 sw/qa/core/frmedt/frmedt.cxx  |2 
 sw/qa/extras/uiwriter/uiwriter.cxx|2 
 sw/qa/extras/uiwriter/uiwriter2.cxx   |2 
 sw/qa/extras/uiwriter/uiwriter3.cxx   |   44 +++---
 sw/qa/extras/unowriter/unowriter.cxx  |2 
 sw/qa/uibase/dochdl/dochdl.cxx|2 
 sw/qa/unit/swmodeltestbase.cxx|2 
 sw/source/core/access/acccontext.cxx  |2 
 sw/source/core/access/accmap.cxx  |6 -
 sw/source/core/fields/docufld.cxx |2 
 sw/source/core/ole/ndole.cxx  |6 -
 sw/source/core/unocore/unofield.cxx   |2 
 sw/source/core/unocore/unotbl.cxx |6 -
 sw/source/filter/ww8/docxattributeoutput.cxx  |6 -
 sw/source/filter/xml/XMLRedlineImportHelper.cxx   |2 
 sw/source/filter/xml/xmlexp.cxx   |4 -
 sw/source/filter/xml/xmlfmt.cxx   |4 -
 sw/source/filter/xml/xmlimp.cxx   |5 -
 sw/source/filter/xml/xmlitem.cxx  |2 
 sw/source/filter/xml/xmltbli.cxx  |2 
 sw/source/ui/dbui/dbtablepreviewdialog.cxx|2 
 sw/source/ui/vba/vbadocument.cxx  |2 
 sw/source/uibase/app/docshdrw.cxx |2 
 sw/source/uibase/dbui/dbmgr.cxx   |8 +-
 sw/source/uibase/docvw/srcedtw.cxx|4 -
 63 files changed, 151 insertions(+), 157 deletions(-)

New commits:
commit 948c29710a0bb168ec07e3aca510fa6860f2da52
Author: Noel 
AuthorDate: Fri Feb 12 15:36:24 2021 +0200
Commit: Noel Grandin 
CommitDate: Mon Feb 15 08:38:42 2021 +0100

loplugin:referencecasting in svx

Change-Id: I072ba9da976cefd61f4a916e70b0601439e8a123
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110818
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx 
b/svx/source/accessibility/AccessibleTextHelper.cxx
index f11ce49b3beb..f8ff9013e929 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++

[Libreoffice-commits] core.git: 2 commits - svx/source sw/qa

2017-11-15 Thread Caolán McNamara 
 svx/source/dialog/ClassificationDialog.cxx |1 +
 sw/qa/extras/tiledrendering/tiledrendering.cxx |3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

New commits:
commit c2602c5f0eb6555dc5cbcfc74a02c0e3b0347e37
Author: Caolán McNamara 
Date:   Wed Nov 15 09:14:12 2017 +

coverity#1421163 Unchecked dynamic_cast

and

coverity#1421165 Unchecked dynamic_cast

Change-Id: Iabd9560d41ec3ddbdb7a560b7839024b7749f917

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index b55e775d0ba7..91f5f2235901 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -1828,12 +1828,13 @@ void SwTiledRenderingTest::testAllTrackedChanges()
 
 // view #1
 SwView* pView1 = dynamic_cast(SfxViewShell::Current());
+CPPUNIT_ASSERT(pView1);
 SwWrtShell* pWrtShell1 = pView1->GetWrtShellPtr();
 
 // view #2
 SfxLokHelper::createView();
 SwView* pView2 = dynamic_cast(SfxViewShell::Current());
-CPPUNIT_ASSERT(pView1 != pView2);
+CPPUNIT_ASSERT(pView2 && pView1 != pView2);
 SwWrtShell* pWrtShell2 = pView2->GetWrtShellPtr();
 // Insert text and reject all
 {
commit 44844b60847af68b8b1b91137eb6af4b65979697
Author: Caolán McNamara 
Date:   Wed Nov 15 09:09:51 2017 +

coverity#1421071 Uninitializer scalar field

Change-Id: I6b52c62574013ba24297c2cbd7bfceea0e29

diff --git a/svx/source/dialog/ClassificationDialog.cxx 
b/svx/source/dialog/ClassificationDialog.cxx
index 34b5d1504344..0bb8e7892d4e 100644
--- a/svx/source/dialog/ClassificationDialog.cxx
+++ b/svx/source/dialog/ClassificationDialog.cxx
@@ -166,6 +166,7 @@ ClassificationDialog::ClassificationDialog(vcl::Window* 
pParent, const bool bPer
 , maInternationalHelper(SfxObjectShell::Current()->getDocProperties(), 
/*bUseLocalizedPolicy*/ false)
 , m_bPerParagraph(bPerParagraph)
 , m_aParagraphSignHandler(rParagraphSignHandler)
+, m_nCurrentSelectedCategory(-1)
 {
 get(m_pOkButton, "ok");
 get(m_pEditWindow, "classificationEditWindow");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits